Wednesday, 2024-05-15

opendevreviewTakashi Kajinami proposed openstack/octavia master: Use built-in json module  https://review.opendev.org/c/openstack/octavia/+/91727402:16
opendevreviewTakashi Kajinami proposed openstack/octavia master: Use built-in json module  https://review.opendev.org/c/openstack/octavia/+/91727402:21
opendevreviewTakashi Kajinami proposed openstack/octavia master: Use built-in json module  https://review.opendev.org/c/openstack/octavia/+/91727402:24
opendevreviewTakashi Kajinami proposed openstack/octavia master: Use built-in json module  https://review.opendev.org/c/openstack/octavia/+/91727402:57
opendevreviewTakashi Kajinami proposed openstack/octavia master: Use built-in json module  https://review.opendev.org/c/openstack/octavia/+/91727403:04
opendevreviewTakashi Kajinami proposed openstack/octavia master: Use built-in json module  https://review.opendev.org/c/openstack/octavia/+/91727403:08
opendevreviewMichael Johnson proposed openstack/octavia master: Fix listener update when using SRIOV VIP  https://review.opendev.org/c/openstack/octavia/+/91954603:28
opendevreviewGregory Thiemonge proposed openstack/octavia master: Add spec for custom SGs on VIP ports  https://review.opendev.org/c/openstack/octavia/+/91511411:15
opendevreviewGregory Thiemonge proposed openstack/octavia master: Add sg_id to Vip data_model  https://review.opendev.org/c/openstack/octavia/+/91971811:18
opendevreviewGregory Thiemonge proposed openstack/octavia master: Add get_security_group_by_id to network driver  https://review.opendev.org/c/openstack/octavia/+/91971911:18
opendevreviewGregory Thiemonge proposed openstack/octavia master: Add vip_sg_ids to the API  https://review.opendev.org/c/openstack/octavia/+/91972011:18
opendevreviewGregory Thiemonge proposed openstack/octavia master: Handle custom security groups in controller  https://review.opendev.org/c/openstack/octavia/+/91972111:18
opendevreviewGregory Thiemonge proposed openstack/octavia-lib master: Add vip_sg_ids and vip_sgs to the data model  https://review.opendev.org/c/openstack/octavia-lib/+/91972211:19
opendevreviewMerged openstack/octavia master: Fix new pylint errors  https://review.opendev.org/c/openstack/octavia/+/91958711:25
opendevreviewTom Weininger proposed openstack/octavia master: Add typing information to octavia.amphorae package  https://review.opendev.org/c/openstack/octavia/+/90519311:32
opendevreviewTom Weininger proposed openstack/octavia master: Add typing information to octavia.api package  https://review.opendev.org/c/openstack/octavia/+/90519411:32
opendevreviewTom Weininger proposed openstack/octavia master: Add typing information to remaining octavia code  https://review.opendev.org/c/openstack/octavia/+/90519511:32
opendevreviewTom Weininger proposed openstack/octavia master: Integrate mypy type checker  https://review.opendev.org/c/openstack/octavia/+/87974911:32
opendevreviewTom Weininger proposed openstack/octavia master: Add typing information to remaining octavia code  https://review.opendev.org/c/openstack/octavia/+/90519511:57
opendevreviewTom Weininger proposed openstack/octavia master: Integrate mypy type checker  https://review.opendev.org/c/openstack/octavia/+/87974911:57
opendevreviewTakashi Kajinami proposed openstack/octavia master: Use built-in json module  https://review.opendev.org/c/openstack/octavia/+/91727412:07
opendevreviewGregory Thiemonge proposed openstack/octavia stable/2024.1: Pin pylint on 2024.1  https://review.opendev.org/c/openstack/octavia/+/91972712:27
gthiemonge^ unblocks the gates on 2024.112:28
QGHi, Is it my configuration or do we not have the user_id in the octavia API logs?12:41
gthiemongeQG hey12:49
gthiemongewe should inherit it from oslo_log if it's not defined in the octavia config files12:49
gthiemongehttps://opendev.org/openstack/oslo.log/src/branch/master/oslo_log/_options.py#L153-L15812:49
gthiemongebut AFAIK the setting is also defined by the deployment tools12:52
opendevreviewMerged openstack/octavia master: Ignore temp file created by coverage  https://review.opendev.org/c/openstack/octavia/+/91820414:26
QGThanks gthiemonge !  14:55
QGShouldn't we use the ciphersuites parameter instead of ciphers one when using TLSv1.3 in haproxy ?15:02
QGWhen you specify in the pool the tls_ciphers to ['TLSv1.2', 'TLSv1.3'] and the list of ciphers to : TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256 15:03
johnsomIf I remember correctly, we include both in the default config and openssl knows which ones to pull out of the list for which TLS version15:04
QGhumm because  Haproxy give you an error like : [ALERT]    (5360) : Proxy 'ae99a24d-5919-4bd0-966d-ddf80245ac94:d01e9f6c-62f6-4943-a467-e6707f697c2f', server 'cee5d52f-2965-4fe0-a553-302ad4b2c554' [haproxy.cfg.new-failed:44] : unable to set SSL cipher list to 'TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256'.15:05
johnsomHmm, that seems odd. Can you open a bug for it?15:06
johnsomI mean, those two settings are the default in Octavia (with a few more ciphers added in.15:07
QGYes sure !15:08
johnsomFYI, I found that HAProxy changed a few of the status variable formats in HAProxy 2.4, so the grafana dashboard has some issues with the "status" pie charts. I will fix that in the dashboard soon-ish. There will be a octavia patch too, but it will only update the help text.15:10
QGah cool ! 15:21
gthiemonge#startmeeting Octavia16:00
opendevmeetMeeting started Wed May 15 16:00:36 2024 UTC and is due to finish in 60 minutes.  The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'octavia'16:00
gthiemongeo/16:00
johnsomo/16:00
tweiningo/16:01
gthiemonge#topic Announcements16:02
gthiemonge* 2024.2 Dalmatian Release Schedule: Dalmatian-116:02
gthiemongeit's already Dalmatian-116:02
johnsomFYI: The OpenStack Summit Asia call for papers closes May 29th.16:02
johnsom#link https://openinfrafoundation.formstack.com/forms/openinfra_asia_summit_202416:02
gthiemongeI can't remember if we defined some internal deadlines/milestones16:02
gthiemongeDo you have anything for Dalmatian-1? patches, specs, ...?16:03
gthiemongejohnsom: +116:03
QGo/16:03
johnsomI was trying to think myself.16:04
johnsomThe SG spec is still open16:05
johnsomAs is resize16:05
johnsomThough there are two of those, so confusing16:05
gthiemongeI updated the SG spec this morning16:05
gthiemongemypy?16:05
johnsomIt's not a spec, last time I looked it was waiting on a requirements repo dependency16:06
gthiemongeoh right16:06
gthiemongeanywys, for spec, Dalmatian-1 is not a blocking deadline, just an internal milestone16:07
johnsomRight, but it's great if we can land specs early in the cycle16:07
tweiningonly a friendly reminder that we wanted to integrate the typing patches at the beginning of the cycle16:07
gthiemonge+116:08
gthiemongeAny other announcements?16:10
gthiemongeour last meeting was 3 weeks ago, I probably missed a few things16:10
tweiningI haven't even started with the rate limiting spec so far btw.16:11
tweiningre mypy/typing the requirements dep is merged now16:12
gthiemongeok16:13
gthiemonge#topic CI Status16:13
gthiemongeA few ongoing issues:16:13
gthiemongepylint was/is broken on master and 2024.116:13
gthiemongethe fix on master merged earlier today (thanks tkajinam!)16:13
gthiemongethen I have a commit that pins pylint on 2024.116:13
gthiemongehttps://review.opendev.org/c/openstack/octavia/+/91972716:14
gthiemonge(already got W+1, should merge soon)16:14
gthiemongethen 2023.1 gates are also broken because of grenade16:14
gthiemongeIFAIK we have to disable grenade because zed is now unmaintained16:14
gthiemongehttps://review.opendev.org/c/openstack/octavia/+/91957216:14
johnsom+116:14
gthiemongethat's all for the CI16:15
gthiemonge#topic Brief progress reports / bugs needing review16:15
gthiemongeas mentionned earlier, I have updated the spec for custom Security Groups on VIP ports16:16
gthiemongehttps://review.opendev.org/c/openstack/octavia/+/91511416:16
gthiemongeI received a lot of feedback on this spec (thanks!) one important point was to not limit the feature to one SG per VIP, so I changed it a little bit, now the spec allows multiple SGs per VIP16:16
johnsomI have been making progress on SRIOV for members. It now works in the normal create path. I have removed some old unneeded code with this change. I have also been testing nova/neutron failure cases to make sure we only roll back the member and not the LB, etc.16:17
johnsomI also found a nasty bug I introduced late in the SRIOV for VIPs chain and have created a patch:16:17
gthiemongejohnsom: nice!16:17
johnsom#link https://review.opendev.org/c/openstack/octavia/+/91954616:17
johnsomReviews would be appreciated as this needs to be backported to caracal and is a MAJOR bug for people trying out the SRIOV for VIPs code.16:18
johnsomIt's bad enough I will probably propose a dot release of caracal once we land it16:19
tweiningapproved16:19
gthiemongeack16:19
johnsomAlso of note, I fired up a Ubuntu 24.04 VM and ran tox. It hits two issues, the TaskFlow issue we have a patch for, and the requirements checks.16:20
gthiemongelooking at the open backports for Caracal, I don't see any really urgent fixes16:20
johnsomOne of the requirements check jobs is easy to fix, the other I have no idea what is wrong with it.16:20
gthiemongedoes it use py312?16:21
gthiemongeyou mention taskflow, so I assume it does16:22
johnsomYes it does16:22
gthiemongespeaking about taskflow, Octavia is a big user of taskflow, and I have a few open patches there, I think it's good to ask reviews here too16:24
gthiemongeI have a fix for an issue that can happen when creating an A/S LB16:24
gthiemongehttps://review.opendev.org/c/openstack/taskflow/+/90074616:24
johnsomAlso of note, I tested out the Grafana dashboard with the latest versions of everything. It loads up fine, but I found HAProxy made a breaking change to the Prometheus "status" metrics. I have already figured out a fix, I just need to take the time to implement it.16:24
gthiemonge(related to https://bugs.launchpad.net/octavia/+bug/2043360)16:25
johnsomOk, yeah, I have taskflow reviews on my todo list16:25
gthiemongeand I've implemented an Etcd backedn for jobboard16:26
gthiemongehttps://review.opendev.org/c/openstack/taskflow/+/91549216:26
johnsomWe are going to need to land that py3.12 patch soon I think16:26
gthiemongedon't know why it's V-1, I'll check that16:26
gthiemongejohnsom: I'll review it 16:26
gthiemonge#topic Open Discussion16:29
johnsomI think I covered all of my topics16:31
tweiningme too16:31
gthiemongecool!16:32
gthiemongethen that's it for this week!16:32
gthiemongethank you guys!16:32
tweiningamen ;)16:32
gthiemonge#endmeeting16:32
opendevmeetMeeting ended Wed May 15 16:32:33 2024 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:32
opendevmeetMinutes:        https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-05-15-16.00.html16:32
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-05-15-16.00.txt16:32
opendevmeetLog:            https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-05-15-16.00.log.html16:32
opendevreviewMerged openstack/octavia stable/2024.1: Pin pylint on 2024.1  https://review.opendev.org/c/openstack/octavia/+/91972717:32
opendevreviewMerged openstack/octavia master: Fix listener update when using SRIOV VIP  https://review.opendev.org/c/openstack/octavia/+/91954618:08
opendevreviewMichael Johnson proposed openstack/octavia stable/2024.1: Fix listener update when using SRIOV VIP  https://review.opendev.org/c/openstack/octavia/+/91964918:36
opendevreviewGregory Thiemonge proposed openstack/octavia master: Don't create load-balancer_* roles when using keystone default roles  https://review.opendev.org/c/openstack/octavia/+/91977020:05
opendevreviewMichael Johnson proposed openstack/octavia master: Update the Grafana dashboard for HAProxy 2.4+  https://review.opendev.org/c/openstack/octavia/+/91977620:49

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!