| houtknots | Hi everyone, would it be possible for someone to review my merge request? If anything needs to be changed please let me know. 917841: Add more data into event notification payload | https://review.opendev.org/c/openstack/octavia/+/917841 | 11:23 |
|---|---|---|
| gthiemonge | houtknots: yep, I'll take a look at it next week, it looks interesting | 12:24 |
| houtknots2 | Thanks! Please let me know if you have any suggestions or feedback :D | 12:27 |
| tweining | I'll have a look too. thanks | 12:36 |
| tweining | one piece of feedback I can already give is that the new code would benefit from some more comments. e.g. what is a "transformed"/"cleaned" dict? | 12:39 |
| tweining | it's not your fault of course, but I find that particular module has some room for improvement :) | 12:43 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Use only keystone roles in keystone RBAC tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/919789 | 13:24 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Use only keystone roles in keystone RBAC tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/919789 | 13:40 |
| gthiemonge | #startmeeting Octavia | 16:00 |
| opendevmeet | Meeting started Wed May 29 16:00:33 2024 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| gthiemonge | hi | 16:00 |
| johnsom | o/ | 16:00 |
| tweining | o/ | 16:01 |
| gthiemonge | #topic Announcements | 16:01 |
| gthiemonge | well, I have no announcements today, does anyone have anything? | 16:01 |
| johnsom | nope | 16:01 |
| gthiemonge | ok! | 16:03 |
| gthiemonge | #topic CI Status | 16:03 |
| gthiemonge | nothing to report here, the gates for 2023.1 were broken, because of grenade, it's fixed now, there are a few patches that need a "recheck" | 16:04 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:06 |
| tweining | nothing new from my side. I know the f-string patch is being reviewed. after that is merged lots of patches will probably need to be rebased. | 16:08 |
| gthiemonge | just a heads-up for | 16:08 |
| gthiemonge | https://review.opendev.org/c/openstack/octavia/+/864192 | 16:08 |
| johnsom | I am just about done with testing work on the SR-IOV for members patch, then I will move to do the nftables part of it. | 16:08 |
| gthiemonge | it has been there for a long time and today someone reported this exact issue on launchpad | 16:09 |
| johnsom | Did we ever figure out how to fix the unit tests jobs that rely on octavia-lib changes? | 16:09 |
| johnsom | My patch is failing even with a depends-on. | 16:09 |
| johnsom | I think it's because the unit tests are a template from the main zuul jobs and they don't have required-project of octavia-lib | 16:10 |
| johnsom | Oh, that is a good one to get reviewed. | 16:11 |
| gthiemonge | #topic Open Discussion | 16:14 |
| tweining | nothing else from me | 16:16 |
| gthiemonge | ok, it was a quick one! | 16:17 |
| gthiemonge | thank you guys! | 16:17 |
| gthiemonge | #endmeeting | 16:17 |
| opendevmeet | Meeting ended Wed May 29 16:17:35 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:17 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-05-29-16.00.html | 16:17 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-05-29-16.00.txt | 16:17 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-05-29-16.00.log.html | 16:17 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!