Monday, 2024-07-29

*** tobias-urdin|pto is now known as tobias-urdin06:31
opendevreviewTom Weininger proposed openstack/octavia-tempest-plugin master: Add scenario tests for failover circuit breaker  https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/83787811:10
opendevreviewTom Weininger proposed openstack/octavia-tempest-plugin master: Add scenario tests for failover circuit breaker  https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/83787811:45
opendevreviewGregory Thiemonge proposed openstack/octavia master: Add spec for custom SGs on VIP ports  https://review.opendev.org/c/openstack/octavia/+/91511411:47
opendevreviewTom Weininger proposed openstack/octavia-tempest-plugin master: Add scenario tests for failover circuit breaker  https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/83787812:28
sorbalHello, I am looking at the get_update_listener_flow() (listener's TaskFlow) and more specifically at how ListenersUpdate is executed before UpdateListenerInDB but the first one uses the database state of the loadbalancer in order to update the listener config in the Amphorae 16:49
sorbalHow is it possible for ListenersUpdate to have the new updated listener if it only requires the loadbalancer id16:50
sorbalI am trying to find more information at the docs or commit history but I can't16:51
sorbalI am probably misunderstanding the purpose of UpdateListenerInDB16:58
johnsomYeah, that is an interesting find.20:15
johnsomsorbal Orignally we didn't update the database until the amphora configuration was fully updated, i.e. don't reflect the change in the DB until it has actually changed. However, somewhere along the line we changed the API behavior to commit it to the DB when the driver accepts the update.20:16
johnsomSo, UpdateListenerInDB may not be a necessary task anymore.20:16
johnsomThe API commits it here: https://github.com/openstack/octavia/blob/master/octavia/api/v2/controllers/listener.py#L66520:17

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!