| *** jcosmao is now known as Guest7955 | 13:22 | |
| *** QG8 is now known as QG | 13:32 | |
| gthiemonge | #startmeeting Octavia | 16:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Oct 30 16:00:19 2024 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| gthiemonge | hi | 16:00 |
| tweining | o/ | 16:00 |
| johnsom | o/ | 16:00 |
| gthiemonge | #topic Announcements | 16:01 |
| gthiemonge | It's our first meeting post-PTG! | 16:01 |
| gthiemonge | so welcome to the Epoxy Release Cycle | 16:01 |
| gthiemonge | reminder: you can find the release schedule at https://releases.openstack.org/epoxy/schedule.html | 16:01 |
| gthiemonge | you may have noticed that Epoxy-1 is in 2 weeks, we don't have any specific goals for this milestone, but it's a reminder that time flies :D | 16:02 |
| gthiemonge | do we have any other announcement folks? | 16:02 |
| johnsom | Nope | 16:03 |
| tweining | most important is feature freeze end of feb, but afair new features in openstack client need to get in even earlier? | 16:03 |
| gthiemonge | I'm going to skip CI status, no update since last meeting or PTG | 16:03 |
| gthiemonge | client freeze is at the same date | 16:03 |
| gthiemonge | but octavia-lib freeze is one week before | 16:03 |
| tweining | ah, ok I confused the two then. it will be important for rate limiting probably | 16:04 |
| gthiemonge | yeah and if you need some code in octavia-lib, we need to propose a new release so it's pulled by all the CI jobs | 16:05 |
| johnsom | I think we have at least three features that need to land. SG for vips, SR-IOV for members, and rate limiting | 16:05 |
| gthiemonge | it means a lot of reviews | 16:06 |
| johnsom | Yeah, I hit a number of tempest reviews in the last week | 16:06 |
| johnsom | I updated the review etherpad for those | 16:07 |
| gthiemonge | thanks | 16:07 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:08 |
| tweining | thanks for reviewing the typing patches. I've updated them | 16:10 |
| johnsom | I have the RBAC switch to using keystone default roles by default (instead of advanced RBAC we have had) patch done. I think this is going to be one where we need to disable gate jobs temporarily to complete the switch due to the dependency chain. | 16:10 |
| tweining | https://review.opendev.org/q/topic:%22mypy%22+project:openstack/octavia | 16:10 |
| tweining | it did hurt a bit to loose the CR+2s though | 16:10 |
| gthiemonge | johnsom: ack we can sync for this | 16:11 |
| tweining | I can try to get rid of more "#type: ignore" comments if you prefer. I can probably do that using the typing.cast() trick. | 16:11 |
| johnsom | I just worry that the code will be littered with those | 16:12 |
| tweining | https://review.opendev.org/c/openstack/octavia/+/880986 also, I worked on integrating ruff into pre-commit, at least in our main repo | 16:12 |
| johnsom | Over time we can improve that | 16:13 |
| gthiemonge | FYI there are a few backports waiting on stable branches: | 16:13 |
| gthiemonge | https://review.opendev.org/q/project:openstack/octavia+status:open+branch:%5Estable/.* | 16:13 |
| gthiemonge | I'll take a look at the V-{1,2} | 16:13 |
| johnsom | I really hope we can stop adding linting tools. They really put the releases at risk. It's fine to run them locally, but adding them to the gate is a huge risk | 16:13 |
| tweining | I'd suggest we merge the pre-commit updates soon, so we have time to test it. There isn't any risk. | 16:16 |
| gthiemonge | ack | 16:17 |
| gthiemonge | #topic Open Discussion | 16:17 |
| gthiemonge | do you have anything else for this week folks? | 16:18 |
| johnsom | I don't think I have anything else | 16:18 |
| tweining | btw. I configured it to use not only the ruff lint tool, but also the formatter. I noticed the PyCharm formatter sometimes formats in a way that our flake8 config doesn't like. I hope ruff does it better | 16:18 |
| gthiemonge | does it mean that pre-commit reformats/updates our code? | 16:19 |
| tweining | the code you commit | 16:19 |
| gthiemonge | the file? or just the patch? | 16:19 |
| johnsom | This is why I think these are a bad idea and unnecessary. | 16:19 |
| tweining | that's a good question. I need to check | 16:20 |
| tweining | chatgpt says it runs on whole files | 16:21 |
| gthiemonge | lol | 16:22 |
| gthiemonge | anyway we'll test it when we will review the patch | 16:22 |
| tweining | golang has the "go fmt" tool. I think such official tool would be the optimal solution. | 16:23 |
| johnsom | Like their crypto library? | 16:23 |
| tweining | well, i mean the concept of having an official formatter for a language is a good idea. | 16:24 |
| tweining | because I also think that many different linters,checker,formatter is a bad thing | 16:25 |
| tweining | "go fmt" isn't great either. in fact, I am pretty disappointed by it tbh. but we digest... | 16:25 |
| tweining | *digress | 16:26 |
| gthiemonge | hehe | 16:26 |
| gthiemonge | anything else guys? | 16:26 |
| tweining | yes | 16:26 |
| johnsom | I can't think of anything | 16:26 |
| tweining | who will take care of abandoning old patches? | 16:27 |
| gthiemonge | the PTL? or a volunteer? | 16:27 |
| tweining | I think I can do it. I already figured out a way to automate it, but haven't tested it. | 16:28 |
| tweining | one more thing | 16:28 |
| tweining | I forgot to mention that I've updated the failover cb test patch | 16:28 |
| tweining | https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/932061 | 16:28 |
| gthiemonge | ack | 16:29 |
| johnsom | Please review them and don't just auto-abandon. There may be some that are valid and/or duplicates to other fixes that should be noted. | 16:29 |
| gthiemonge | I think we need a quick glance at the list of patches before abandoning them | 16:29 |
| tweining | I set health_check_interval to 300, but the test still fails. I should update the timeouts in the test as well, but I didn't have time to investigate | 16:30 |
| gthiemonge | tweining: let's talk offline about the method we can use | 16:30 |
| tweining | ok | 16:30 |
| gthiemonge | ok I guess that's all for this week | 16:33 |
| gthiemonge | thank you guys | 16:34 |
| gthiemonge | #endmeeting | 16:34 |
| opendevmeet | Meeting ended Wed Oct 30 16:34:36 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:34 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-10-30-16.00.html | 16:34 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-10-30-16.00.txt | 16:34 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-10-30-16.00.log.html | 16:34 |
| tweining | o/ | 16:34 |
| *** amorin_ is now known as amorin | 17:35 | |
| opendevreview | Merged openstack/octavia stable/2024.2: Pin pylint on 2024.2 https://review.opendev.org/c/openstack/octavia/+/933214 | 18:14 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily at 20:30 utc (half an hour from now) to apply a configuration change | 20:02 | |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily to apply a configuration change | 20:31 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!