gthiemonge | #startmeeting Octavia | 16:00 |
---|---|---|
opendevmeet | Meeting started Wed Dec 4 16:00:20 2024 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
gthiemonge | o/ | 16:00 |
tweining | o/ | 16:00 |
johnsom | o/ | 16:00 |
gthiemonge | #topic Announcements | 16:01 |
gthiemonge | well, no announcements from me this week, I was on PTO :D anything to mention here? | 16:02 |
tweining | mmh, I can't think of anything | 16:02 |
johnsom | I don't think I have anything. Just a reminder that Library freeze is coming up the week of Feb 17th | 16:03 |
tweining | working on the rate limiting rfe might become my personal christmas project ;) | 16:04 |
gthiemonge | lol | 16:04 |
gthiemonge | happy holidays ;-) | 16:05 |
gthiemonge | #topic CI Status | 16:05 |
johnsom | Yeah, getting OVN to behave so I can work on my SR-IOV patches might become mine. | 16:05 |
gthiemonge | I think we're still stuck in octavia-tempest-plugin because of multiple failures | 16:05 |
gthiemonge | hacking, doc, unmaintained branch removal, etc.. | 16:06 |
gthiemonge | we may have to squash a patchchain to move forward | 16:06 |
gthiemonge | https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/934270 | 16:06 |
tweining | or we could temporarily disable pep8 just to integrate that chain? | 16:07 |
gthiemonge | i don't know which template enables pep8 | 16:07 |
johnsom | It's one of the "base" jobs provided | 16:08 |
gthiemonge | could be a solution, like what we're doing here with the doc job: https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/934270/4/zuul.d/projects.yaml | 16:08 |
gthiemonge | https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/project-templates.yaml#L3489-L3501 | 16:09 |
gthiemonge | it's the only job in tempest-plugin-jobs, IMHO it's safe to disable it temporarily | 16:10 |
gthiemonge | any objections? | 16:11 |
johnsom | Nope | 16:11 |
gthiemonge | ok, we have a plan! | 16:11 |
gthiemonge | I will update the patch | 16:12 |
gthiemonge | anything else to report about CI? | 16:12 |
johnsom | Thanks for handling that | 16:12 |
tweining | +1 | 16:13 |
tweining | nothing else I think | 16:14 |
tweining | oh wait | 16:14 |
tweining | do the failure we discussed also include the openstack-tox-pip-check-reqs job failure? | 16:15 |
gthiemonge | where's that? | 16:15 |
johnsom | It's not clear if one of the unpin patches will fix that or not. It might just be broken | 16:15 |
tweining | https://review.opendev.org/c/openstack/octavia/+/936811?tab=change-view-tab-header-zuul-results-summary for instance | 16:16 |
gthiemonge | not related | 16:16 |
tweining | honestly, I did not understand that failure | 16:16 |
gthiemonge | yeah I haven't seen this failure | 16:16 |
gthiemonge | so no idea | 16:17 |
johnsom | It's falsely reporting that some requirements in requirements.txt are not used even though they are. It was triggered by the change to Noble from Jammy | 16:17 |
johnsom | IMO it's a nice to have check, but I'm not going to lose sleep if we disable it for now | 16:18 |
tweining | from my perspective it fails, but does not print any error | 16:18 |
johnsom | It's in the log: | 16:19 |
johnsom | https://www.irccloud.com/pastebin/AYjdCtJu/ | 16:19 |
johnsom | It is flagging most if not all as unused requirements | 16:20 |
tweining | that does not look like an error to me. I agree that it is probably not crucial to have | 16:20 |
gthiemonge | we can create a launchpad and disable it temporarily | 16:20 |
johnsom | It just catches the case where we remove a dependency from the code and forget to remove it from requirement.txt | 16:20 |
johnsom | I can take this one | 16:22 |
gthiemonge | thanks johnsom | 16:23 |
gthiemonge | #topic Brief progress reports / bugs needing review | 16:23 |
tweining | not much progress, but I worked a little bit on the rate limiting rfe | 16:24 |
tweining | the api-ref part to be precise | 16:24 |
johnsom | I had some holiday time off, but right now I am working on setting up a multinode devstack on bare metal to continue the SR-IOV for members work. | 16:25 |
* johnsom notes, pypi is down... sigh | 16:25 | |
gthiemonge | nothing new on my side | 16:27 |
gthiemonge | #topic Open Discussion | 16:28 |
gthiemonge | anything else guys? | 16:28 |
johnsom | Nope | 16:28 |
gthiemonge | ack | 16:30 |
gthiemonge | we can close the meeting | 16:30 |
gthiemonge | thank you guys! | 16:30 |
tweining | maybe https://review.opendev.org/q/topic:%22bug/2090782%22 ? | 16:30 |
tweining | yeah, I noticed it has actually not directly to do with octavia | 16:31 |
gthiemonge | I'm not convinced it should be added to octavia-lib | 16:31 |
johnsom | As we discussed at the PTG I think this is a temp fix. Really we need to go through and make the models flat or limited where it makes sense. Then remove all of this recursive model loading stuff. We have had to hack it so many times.... | 16:32 |
gthiemonge | we agreed to use limited_graph as a backportable solution until we find a better way to deal with objects | 16:32 |
tweining | right | 16:32 |
johnsom | Yeah, interestingly enough, I was 90% the driver lib/agent was already flat | 16:33 |
gthiemonge | I'm wondering if there's a need for recursive objects there | 16:34 |
gthiemonge | if all the gets are limited_graph=True, maybe we can do that directly in the agent | 16:34 |
johnsom | We explicitly did not have recursive objects in the driver agent | 16:35 |
johnsom | Yeah, right | 16:35 |
gthiemonge | ok, I'll take a closer look at it | 16:35 |
johnsom | It should probably go here if anywhere: https://github.com/openstack/octavia/blob/master/octavia/api/drivers/driver_agent/driver_get.py | 16:35 |
gthiemonge | hmm yeah | 16:36 |
johnsom | Ah, I see recurse there, so I think someone requested that change, probably for OVN | 16:36 |
gthiemonge | they are updating it there: https://review.opendev.org/c/openstack/octavia/+/936857/1/octavia/api/drivers/driver_agent/driver_get.py | 16:37 |
gthiemonge | still recurse=True but limited_graph is optional | 16:38 |
gthiemonge | I will check with the ovn-provider folks too | 16:40 |
gthiemonge | anything else? | 16:40 |
gthiemonge | I guess that's all for this week | 16:42 |
gthiemonge | thank you! | 16:42 |
gthiemonge | #endmeeting | 16:42 |
opendevmeet | Meeting ended Wed Dec 4 16:42:29 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:42 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-12-04-16.00.html | 16:42 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-12-04-16.00.txt | 16:42 |
opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-12-04-16.00.log.html | 16:42 |
opendevreview | Michael Johnson proposed openstack/octavia master: Unpin pip-extra-reqs https://review.opendev.org/c/openstack/octavia/+/936811 | 19:42 |
opendevreview | Michael Johnson proposed openstack/octavia master: Unpin pip-extra-reqs https://review.opendev.org/c/openstack/octavia/+/936811 | 20:22 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!