| *** openstack has joined #openstack-manila | 15:44 | |
| *** akshai has joined #openstack-manila | 15:46 | |
| *** gouthamr has joined #openstack-manila | 15:47 | |
| *** lpetrut has joined #openstack-manila | 15:47 | |
| *** lpetrut has quit IRC | 15:49 | |
| *** martyturner has joined #openstack-manila | 15:59 | |
| *** timcl has joined #openstack-manila | 16:02 | |
| *** openstackstatus has joined #openstack-manila | 16:15 | |
| *** ChanServ sets mode: +v openstackstatus | 16:15 | |
| csaba | vponomaryov: ping | 16:20 |
|---|---|---|
| *** sgotliv has joined #openstack-manila | 16:21 | |
| *** sac has quit IRC | 16:27 | |
| *** rhagarty has joined #openstack-manila | 16:27 | |
| *** sac has joined #openstack-manila | 16:31 | |
| vponomaryov | csaba: pong | 16:32 |
| *** zhongjun2 has joined #openstack-manila | 16:37 | |
| *** zhongjun has quit IRC | 16:38 | |
| *** chlong has joined #openstack-manila | 16:40 | |
| csaba | vponomaryov: can you please check my answer to your review for https://review.openstack.org/235729 ? | 16:43 |
| *** sgotliv has quit IRC | 16:43 | |
| *** xyang1 has joined #openstack-manila | 16:45 | |
| vponomaryov | csaba: рь | 16:46 |
| vponomaryov | csaba: hm | 16:46 |
| csaba | vponomaryov: :) | 16:47 |
| vponomaryov | csaba: looks like bug in your driver is covered with bug in unit tests | 16:47 |
| vponomaryov | csaba: so, it is definitely bad thing that unit tests do it on its own way | 16:47 |
| csaba | vponomaryov: it's a nice challenge to find out where the unit test _ comes from -- when printed, it's just shown as "lambda: <address>" | 16:49 |
| csaba | do you know of some technique to answer this? | 16:50 |
| *** martyturner has quit IRC | 16:51 | |
| vponomaryov | csaba: look at "manila/tests/__init__.py" | 16:52 |
| vponomaryov | csaba: looks like it is the thing you need | 16:52 |
| vponomaryov | csaba: and, considering the fact that we already import that func explicitely, we do not need anymore such mock | 16:54 |
| vponomaryov | csaba: so, just remove mock in file "manila/tests/__init__.py" and that will do the magic | 16:55 |
| vponomaryov | csaba: and maybe it will discover more places with lost import )) | 16:57 |
| vponomaryov | csaba: I will post it in gerrit | 16:59 |
| csaba | vponomaryov: sounds good -- but then what do you want to do with my patch? if you remove the fake test _, then you'll have to fix up all places where _ is used but not imported. And that would fix the particular istance my patch is about. So do you want me to abandon this singular fix or shall we merge it before your general underscore cleanup? | 17:01 |
| *** gouthamr is now known as gouthamr_away | 17:02 | |
| vponomaryov | csaba: "all places where _ is used but not imported" - is bug places | 17:03 |
| vponomaryov | csaba: that is the point | 17:03 |
| csaba | sure | 17:03 |
| vponomaryov | csaba: it should be imported explicitely | 17:03 |
| vponomaryov | csaba: so, your fix should be extended | 17:03 |
| vponomaryov | csaba: with removal of that thing and, if any, addon of lost imports | 17:04 |
| vponomaryov | not directly saying about driver | 17:04 |
| vponomaryov | but fixing imports | 17:04 |
| vponomaryov | and test coverage for it | 17:04 |
| vponomaryov | csaba: did I answer your question? | 17:05 |
| csaba | vponomaryov: you just said: "csaba: I will post it in gerrit" -- I thought it was about posting such a fix, taking over the problem from me. Did you mean something else? Posting a review comment to my patch maybe? | 17:06 |
| vponomaryov | csaba: yeah, I meant posting comment )) | 17:06 |
| vponomaryov | csaba: to have it in history of commit | 17:06 |
| vponomaryov | csaba: sorry for confusion | 17:06 |
| csaba | vponomaryov: ah OK, so then I'll deliver the generalized fix. | 17:06 |
| vponomaryov | csaba: yes, is it ok for you? | 17:07 |
| csaba | vponomaryov: yeah. | 17:07 |
| *** gouthamr_away has quit IRC | 17:07 | |
| vponomaryov | csaba: thanks | 17:09 |
| csaba | vponomaryov: my pleasure | 17:10 |
| *** eharney has joined #openstack-manila | 17:14 | |
| *** a_ta_ has joined #openstack-manila | 17:14 | |
| *** a_ta has quit IRC | 17:15 | |
| *** dustins has joined #openstack-manila | 17:16 | |
| *** jcsp has joined #openstack-manila | 17:16 | |
| *** rebase has joined #openstack-manila | 17:19 | |
| openstackgerrit | Stephen Gordon proposed openstack/manila: Remove mention of isilon_share_root_dir https://review.openstack.org/251480 | 17:20 |
| *** timcl has quit IRC | 17:25 | |
| *** timcl has joined #openstack-manila | 17:34 | |
| *** nkrinner has quit IRC | 17:38 | |
| openstackgerrit | Clinton Knight proposed openstack/manila: NetApp cDOT multi-SVM driver can't handle duplicate addresses https://review.openstack.org/251487 | 17:46 |
| *** timcl has quit IRC | 17:58 | |
| rraja | /nick rraja|afk | 17:58 |
| *** rraja is now known as rraja|afk | 17:59 | |
| *** jwang_ has quit IRC | 18:04 | |
| *** jwang has joined #openstack-manila | 18:08 | |
| *** chlong has quit IRC | 18:10 | |
| *** timcl has joined #openstack-manila | 18:11 | |
| *** a_ta_ has quit IRC | 18:19 | |
| *** a_ta has joined #openstack-manila | 18:20 | |
| *** tbarron has quit IRC | 18:21 | |
| *** a_ta has quit IRC | 18:24 | |
| *** bswartz has quit IRC | 18:25 | |
| *** chlong has joined #openstack-manila | 18:26 | |
| *** a_ta has joined #openstack-manila | 18:37 | |
| *** tbarron has joined #openstack-manila | 18:42 | |
| *** bswartz has joined #openstack-manila | 18:42 | |
| *** sgotliv has joined #openstack-manila | 18:48 | |
| *** markstur has joined #openstack-manila | 18:50 | |
| *** gregsfortytwo has quit IRC | 19:02 | |
| *** gregsfortytwo has joined #openstack-manila | 19:04 | |
| *** timcl has quit IRC | 19:05 | |
| *** dustins has quit IRC | 19:14 | |
| *** timcl has joined #openstack-manila | 19:21 | |
| *** mkoderer has quit IRC | 19:26 | |
| *** mkoderer has joined #openstack-manila | 19:29 | |
| *** cknight has joined #openstack-manila | 19:31 | |
| *** eharney has quit IRC | 20:22 | |
| *** eharney has joined #openstack-manila | 20:37 | |
| *** lpabon has joined #openstack-manila | 21:00 | |
| *** a_ta has quit IRC | 21:16 | |
| *** a_ta has joined #openstack-manila | 21:17 | |
| *** a_ta has quit IRC | 21:21 | |
| *** cknight has quit IRC | 21:46 | |
| *** jasonsb has quit IRC | 21:48 | |
| *** lpabon has quit IRC | 21:53 | |
| *** timcl has quit IRC | 21:53 | |
| *** timcl has joined #openstack-manila | 21:56 | |
| *** timcl has quit IRC | 22:00 | |
| *** timcl has joined #openstack-manila | 22:04 | |
| *** timcl has quit IRC | 22:10 | |
| openstackgerrit | Merged openstack/manila: Add share-networks validation https://review.openstack.org/249660 | 22:12 |
| *** eharney has quit IRC | 22:20 | |
| *** a_ta has joined #openstack-manila | 22:20 | |
| *** jasonsb has joined #openstack-manila | 22:36 | |
| *** jasonsb has quit IRC | 22:37 | |
| *** jasonsb has joined #openstack-manila | 22:37 | |
| *** a_ta has quit IRC | 22:41 | |
| *** a_ta has joined #openstack-manila | 22:41 | |
| *** a_ta has quit IRC | 22:44 | |
| *** a_ta has joined #openstack-manila | 22:44 | |
| *** sgotliv_ has joined #openstack-manila | 22:53 | |
| *** sgotliv has quit IRC | 22:56 | |
| *** sgotliv_ has quit IRC | 23:00 | |
| *** a_ta has quit IRC | 23:06 | |
| *** a_ta has joined #openstack-manila | 23:06 | |
| *** a_ta has quit IRC | 23:10 | |
| *** bswartz has quit IRC | 23:10 | |
| *** bswartz has joined #openstack-manila | 23:11 | |
| *** breitz has quit IRC | 23:15 | |
| *** breitz has joined #openstack-manila | 23:15 | |
| *** xyang1 has quit IRC | 23:41 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!