*** pgbridge has quit IRC | 00:02 | |
*** a_ta has joined #openstack-manila | 00:14 | |
*** lpabon has joined #openstack-manila | 00:16 | |
*** a_ta has quit IRC | 00:19 | |
*** markstur_ has joined #openstack-manila | 00:21 | |
*** markstur_ has quit IRC | 00:22 | |
*** lpabon has quit IRC | 00:38 | |
*** adrianofr has quit IRC | 01:06 | |
*** chlong has joined #openstack-manila | 01:07 | |
openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs: document irregular behavior with gluster-nfs on access revocation https://review.openstack.org/258745 | 01:16 |
---|---|---|
openstackgerrit | zhongjun proposed openstack/manila: QoS support for shares https://review.openstack.org/247286 | 01:21 |
*** merooney has joined #openstack-manila | 01:43 | |
openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs/vol layout: remove manila-created vols upon delete_share https://review.openstack.org/237454 | 01:57 |
*** mtanino has joined #openstack-manila | 01:59 | |
*** gouthamr has joined #openstack-manila | 02:04 | |
*** gouthamr_ has joined #openstack-manila | 02:06 | |
*** gouthamr has quit IRC | 02:09 | |
*** chlong has quit IRC | 02:10 | |
*** chlong has joined #openstack-manila | 02:22 | |
*** logan- has joined #openstack-manila | 03:47 | |
*** a_ta has joined #openstack-manila | 03:50 | |
*** a_ta has quit IRC | 03:55 | |
*** vbellur has joined #openstack-manila | 03:56 | |
openstackgerrit | Merged openstack/python-manilaclient: Updated from global requirements https://review.openstack.org/256522 | 04:30 |
*** nidhimittalhada has joined #openstack-manila | 04:39 | |
nidhimittalhada | @bswartz @cknight @vponomaryov @cfouts ...could someone please review manila client change : -https://review.openstack.org/#/c/255802/ | 04:39 |
*** merooney has quit IRC | 04:52 | |
*** shausy has joined #openstack-manila | 05:09 | |
*** mtanino has quit IRC | 05:30 | |
*** nidhimittalhada has quit IRC | 05:33 | |
*** gouthamr_ has quit IRC | 05:35 | |
*** gouthamr has joined #openstack-manila | 05:35 | |
*** gouthamr has quit IRC | 05:59 | |
*** shausy has quit IRC | 06:18 | |
*** shausy has joined #openstack-manila | 06:20 | |
*** haomaiwang has joined #openstack-manila | 06:27 | |
*** sgotliv has joined #openstack-manila | 06:35 | |
*** shausy has quit IRC | 06:37 | |
*** haomaiwang has quit IRC | 06:37 | |
*** shausy has joined #openstack-manila | 06:38 | |
*** 5EXAAIFVW has joined #openstack-manila | 06:38 | |
openstackgerrit | Ankit Agrawal proposed openstack/manila: Remove duplicate keys from dictionary https://review.openstack.org/258826 | 06:39 |
openstackgerrit | daiki kato proposed openstack/manila: Add space to message in manila/consistency_group/api.py https://review.openstack.org/257224 | 06:58 |
*** 5EXAAIFVW has quit IRC | 07:01 | |
*** haomaiwang has joined #openstack-manila | 07:01 | |
*** deepakcs has joined #openstack-manila | 07:10 | |
*** nidhimittalhada has joined #openstack-manila | 07:11 | |
*** shausy has quit IRC | 07:22 | |
*** shausy has joined #openstack-manila | 07:22 | |
*** haomaiwang has quit IRC | 07:26 | |
*** a_ta has joined #openstack-manila | 07:27 | |
*** tobe has joined #openstack-manila | 07:27 | |
*** haomaiwang has joined #openstack-manila | 07:29 | |
*** a_ta has quit IRC | 07:31 | |
nidhimittalhada | @vponomaryov: | 07:33 |
nidhimittalhada | Can i safely assume that at all times when i fire unmanage on a share, It has "only one" "share instance" behind it .. ???? | 07:33 |
nidhimittalhada | (as multiple share instance come into play when migration is in progress.. can an unmanage command on share come in between ???) | 07:33 |
nidhimittalhada | can an unmanage command on share in between when migration on it is progress? | 07:33 |
nidhimittalhada | sorry again wrong grammar | 07:33 |
nidhimittalhada | can an "unmanage" request on share come, when migration on it is progress? | 07:34 |
nidhimittalhada | hi | 07:34 |
nidhimittalhada | .. | 07:34 |
nidhimittalhada | .. | 07:34 |
*** chlong has quit IRC | 07:36 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Implement export location metadata feature https://review.openstack.org/251930 | 07:58 |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-manila | 08:01 | |
*** nidhimittalhada has quit IRC | 08:02 | |
*** lpetrut has joined #openstack-manila | 08:17 | |
*** shausy has quit IRC | 08:27 | |
*** nidhimittalhada has joined #openstack-manila | 08:34 | |
nidhimittalhada | @vponomaryov: On running tox -epy27 on manila repo -- which is fresh + few of my changes ... | 08:35 |
nidhimittalhada | i get this http://paste.openstack.org/show/482163/ | 08:35 |
nidhimittalhada | Obtaining file:///opt/stack/manila | 08:35 |
nidhimittalhada | Complete output from command python setup.py egg_info: | 08:35 |
nidhimittalhada | running egg_info | 08:35 |
nidhimittalhada | writing dependency_links to manila.egg-info/dependency_links.txt | 08:35 |
nidhimittalhada | error: [Errno 13] Permission denied: 'manila.egg-info/dependency_links.txt' | 08:35 |
nidhimittalhada | ---------------------------------------- | 08:35 |
nidhimittalhada | Command "python setup.py egg_info" failed with error code 1 in /opt/stack/manila | 08:35 |
nidhimittalhada | @vponomaryov: its again some similar reason of not setting up the repo correctly | 08:36 |
nidhimittalhada | i have run the oython setup.py install in it | 08:36 |
nidhimittalhada | now i did this manually sudo python setup.py egg_info | 08:37 |
nidhimittalhada | perhaps it will work | 08:37 |
nidhimittalhada | solved the prob | 08:59 |
*** nidhimittalhada has quit IRC | 08:59 | |
*** haomaiwang has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-manila | 09:01 | |
*** alyson_ has quit IRC | 09:02 | |
*** lpetrut has quit IRC | 09:06 | |
*** tpsilva has joined #openstack-manila | 09:09 | |
*** zigo has quit IRC | 09:25 | |
*** zigo_ has joined #openstack-manila | 09:26 | |
*** tobe has quit IRC | 09:38 | |
*** alyson_ has joined #openstack-manila | 09:38 | |
*** haomaiwang has quit IRC | 09:40 | |
*** tobe has joined #openstack-manila | 09:40 | |
*** tobe has quit IRC | 09:41 | |
*** tobe has joined #openstack-manila | 09:41 | |
*** tobe has quit IRC | 09:46 | |
*** openstackgerrit has quit IRC | 09:47 | |
*** haomaiwang has joined #openstack-manila | 09:47 | |
*** openstackgerrit has joined #openstack-manila | 09:48 | |
openstackgerrit | jay.xu proposed openstack/manila: EMC VNX: Add multi-pools support https://review.openstack.org/256224 | 09:48 |
*** haomaiwang has quit IRC | 09:58 | |
*** haomaiwa_ has joined #openstack-manila | 10:02 | |
*** haomaiw__ has joined #openstack-manila | 10:06 | |
*** haomaiwa_ has quit IRC | 10:07 | |
toabctl | markstur: https://github.com/openstack/manila-ui/commit/6ea516ecd803ed72de2fa5e6dd3539fcf4c9c22a broke the manila-ui for me when using v2 api | 10:16 |
toabctl | markstur: the api_version is not set now and it uses v1. the positional arg is wrong (should be "2" and not "2.X" because it's the major version | 10:17 |
vponomaryov | toabctl: what client version do you use? | 10:22 |
toabctl | vponomaryov: 1.5 | 10:22 |
*** haomaiw__ has quit IRC | 10:24 | |
vponomaryov | toabctl: you are right, it now uses v1 | 10:26 |
toabctl | vponomaryov: I know :) | 10:26 |
vponomaryov | toabctl: verified )) | 10:26 |
toabctl | vponomaryov: I fill a bug against manila-ui | 10:27 |
*** haomaiwang has joined #openstack-manila | 10:28 | |
vponomaryov | toabctl: we already bekported it to liberty branch of manila-ui >< | 10:28 |
vponomaryov | s/bekported/backported/ | 10:28 |
toabctl | vponomaryov: yes. that's why I recognized it | 10:28 |
toabctl | vponomaryov: hm. maybe we should just use the current bug 1524508 | 10:28 |
openstack | bug 1524508 in manila-ui "Manila-ui causes red pop-ups in Horizon. Doesn't work." [High,Fix released] https://launchpad.net/bugs/1524508 - Assigned to Mark Sturdevant (mark-sturdevant) | 10:28 |
toabctl | vponomaryov: the bug doesn't mention which manilaclient version was used there. maybe it's a problem with 1.4? | 10:29 |
vponomaryov | toabctl: maybe we should make release of manilaclient and set it as minimal version | 10:29 |
toabctl | btw. http://docs.openstack.org/releases/releases/liberty.html still says that 1.4.0 is the liberty release (which is imo wrong) | 10:30 |
*** haomaiwang has quit IRC | 10:31 | |
toabctl | vponomaryov: let's wait for markstur to clarify when the problem he mentioned in the bug happens. | 10:31 |
vponomaryov | toabctl: looks like we need to rename arg of common client and provide both | 10:33 |
vponomaryov | in latest master, then backport it, then it should work | 10:33 |
vponomaryov | for both | 10:33 |
vponomaryov | kwarg should exist anyway for old client | 10:33 |
*** haomaiwa_ has joined #openstack-manila | 10:33 | |
vponomaryov | or we should restrict its usage | 10:33 |
*** adrianofr has joined #openstack-manila | 10:42 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Implement export location metadata feature https://review.openstack.org/251930 | 10:50 |
*** vbellur has quit IRC | 10:58 | |
*** alyson_ has quit IRC | 11:00 | |
*** haomaiwa_ has quit IRC | 11:01 | |
*** haomaiwang has joined #openstack-manila | 11:01 | |
openstackgerrit | sonu proposed openstack/python-manilaclient: Removes MANIFEST.in as it is not needed explicitely by PBR https://review.openstack.org/258950 | 11:02 |
*** a_ta has joined #openstack-manila | 11:03 | |
*** deepakcs has quit IRC | 11:04 | |
*** a_ta has quit IRC | 11:08 | |
*** adrianofr has quit IRC | 11:40 | |
*** adrianofr has joined #openstack-manila | 11:42 | |
*** adrianofr has quit IRC | 11:54 | |
openstackgerrit | Igor Malinovskiy proposed openstack/manila: Add update_access() method to driver interface https://review.openstack.org/245126 | 12:00 |
*** haomaiwang has quit IRC | 12:01 | |
*** haomaiwang has joined #openstack-manila | 12:01 | |
*** lpetrut has joined #openstack-manila | 12:03 | |
*** zhongjun2 has joined #openstack-manila | 12:20 | |
*** zhongjun has quit IRC | 12:23 | |
*** nidhimittalhada has joined #openstack-manila | 12:23 | |
*** adrianofr has joined #openstack-manila | 12:26 | |
*** timcl has joined #openstack-manila | 12:33 | |
nidhimittalhada | @vponomaryov: a doubt related to mock and assert_called_once_with .. plz see .. http://paste.openstack.org/show/482183/ | 12:35 |
vponomaryov | nidhimittalhada: any mocked object works ok | 12:37 |
nidhimittalhada | means? | 12:37 |
vponomaryov | nidhimittalhada: and your example completely confusing | 12:37 |
nidhimittalhada | ohk | 12:38 |
nidhimittalhada | i tried to make it simple. | 12:38 |
nidhimittalhada | but i guess no | 12:38 |
nidhimittalhada | let me try it in another paste with real code. | 12:38 |
vponomaryov | nidhimittalhada: real code is simple | 12:39 |
nidhimittalhada | ok | 12:39 |
*** haomaiwang has quit IRC | 12:43 | |
*** lpabon has joined #openstack-manila | 13:05 | |
*** nidhimittalhada has left #openstack-manila | 13:06 | |
*** gouthamr has joined #openstack-manila | 13:16 | |
*** gouthamr is now known as gouthamr_away | 13:16 | |
*** gouthamr_away is now known as gouthamr | 13:16 | |
openstackgerrit | Devin proposed openstack/manila: [admin-guide] add manila manually install-guide https://review.openstack.org/258996 | 13:16 |
*** gouthamr_ has joined #openstack-manila | 13:19 | |
*** gouthamr has quit IRC | 13:22 | |
*** breitz has quit IRC | 13:32 | |
*** breitz has joined #openstack-manila | 13:33 | |
*** porrua has joined #openstack-manila | 13:43 | |
openstackgerrit | zhongjun proposed openstack/manila-ui: Can not create a LDAP security-service with no auth https://review.openstack.org/259012 | 13:48 |
openstackgerrit | Shuquan Huang proposed openstack/python-manilaclient: Replace assertEqual(None, *) with assertIsNone in tests https://review.openstack.org/259016 | 13:50 |
*** lgreg has joined #openstack-manila | 13:53 | |
*** lgreg has left #openstack-manila | 13:54 | |
*** akerr has joined #openstack-manila | 13:54 | |
*** tpsilva has quit IRC | 13:56 | |
*** tpsilva has joined #openstack-manila | 13:58 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Refactor share metadata tests to use DB https://review.openstack.org/259024 | 14:01 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Implement export location metadata feature https://review.openstack.org/251930 | 14:02 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Implement export location metadata feature https://review.openstack.org/251930 | 14:05 |
*** xyang1 has joined #openstack-manila | 14:09 | |
*** dustins|out is now known as dustins | 14:10 | |
*** haomaiwang has joined #openstack-manila | 14:11 | |
*** merooney has joined #openstack-manila | 14:16 | |
*** ociuhandu has joined #openstack-manila | 14:35 | |
*** a_ta has joined #openstack-manila | 14:39 | |
*** a_ta has quit IRC | 14:43 | |
*** cknight has joined #openstack-manila | 14:44 | |
*** eharney has joined #openstack-manila | 14:48 | |
*** markstur_ has joined #openstack-manila | 14:54 | |
*** a_ta has joined #openstack-manila | 14:58 | |
*** haomaiwang has quit IRC | 15:01 | |
*** haomaiwang has joined #openstack-manila | 15:01 | |
*** vbellur has joined #openstack-manila | 15:08 | |
*** jasonsb has joined #openstack-manila | 15:24 | |
*** haomaiwang has quit IRC | 15:25 | |
*** adrianofr has quit IRC | 15:30 | |
*** mtanino has joined #openstack-manila | 15:36 | |
*** jasonsb has quit IRC | 15:49 | |
*** esker has joined #openstack-manila | 15:54 | |
*** david-lyle_ has joined #openstack-manila | 15:55 | |
*** esker has quit IRC | 15:56 | |
*** esker has joined #openstack-manila | 15:56 | |
*** david-lyle_ has quit IRC | 15:57 | |
*** esker has quit IRC | 15:57 | |
*** david-lyle has quit IRC | 15:59 | |
bswartz | zhongjun: did I answer your question? | 16:01 |
*** markstur_ has quit IRC | 16:01 | |
vponomaryov | zhongjun2: ^ | 16:02 |
toabctl | vponomaryov: any opinion about https://review.openstack.org/#/c/257358/ ? | 16:02 |
vponomaryov | toabctl: does it mean that absence of a key directly leads to error? | 16:03 |
*** zhongjun has joined #openstack-manila | 16:03 | |
vponomaryov | toabctl: and password never tried? | 16:03 |
toabctl | vponomaryov: yes | 16:04 |
toabctl | vponomaryov: so basically you can not say "don't use a key" | 16:04 |
ganso | cknight: can I ask you a question about the generic grouping proposal? | 16:04 |
cknight | ganso: of course | 16:04 |
*** david-lyle has joined #openstack-manila | 16:05 | |
ganso | cknight: are we enforcing grouping? there will be no more shares without groups, a single share has to be a single group, right? | 16:05 |
bswartz | ganso: no! | 16:05 |
cknight | ganso: No. There can still be ungrouped shares. | 16:06 |
bswartz | shares can exist outside groups | 16:06 |
ganso | cknight: wouldn't it make for two branches of code for each API action? | 16:06 |
vponomaryov | toabctl: confirm, reproduced on lab | 16:06 |
toabctl | vponomaryov: thx! | 16:06 |
bswartz | ganso: the theory is that 2 branches is better than N branches (where N is the number of features that need to work together) | 16:07 |
cknight | ganso: Yes. If we were starting today, we could design an API where each action could handle a share or a share group. | 16:07 |
vponomaryov | toabctl: find another +2 ) | 16:07 |
toabctl | vponomaryov: your +2 hopefully enrouage others to follow you! :) | 16:07 |
cknight | ganso: I haven't looked too closely at the API implications, so any simplifying suggestions you have are welcome. | 16:07 |
toabctl | encourage | 16:07 |
vponomaryov | ) | 16:07 |
*** pgbridge has joined #openstack-manila | 16:08 | |
vponomaryov | bswartz, cknight: I am not sure I see problems if we extend existing share types instead of adding group types | 16:08 |
ganso | cknight: it is probably more effort to change everything to work as a group, but for me it seems easier to maintain | 16:09 |
ganso | cknight: my suggestion it to change how manila works, user first has to create an empty group (with extra-specs or not), then create shares in it | 16:09 |
cknight | ganso: That *is* the proposed workflow for grouped shares, but ungrouped shares will still work as always. | 16:10 |
cknight | ganso: If we grouped everything it might be cleaner, but the upgrade path could be challenging, and as a user, sometimes I just want shares and don't want to be bothered with an extra step. | 16:11 |
cknight | ganso: The idea is to create a group when you need the manageability goodness that comes with it. | 16:12 |
ganso | cknight: if he wants to create another completely separate share that has nothing in common with the other share, then create another group and repeat the proccess. That way, all operation such as snapshots, access-allow, access-deny, delete, will not have to check if it is in a group or not to follow 2 different code paths. Maybe I am going to far with this | 16:12 |
ganso | proposal because I am predicting this will be the case for migration, 2 very different code paths | 16:12 |
ganso | s/proposal/suggestion | 16:12 |
cknight | ganso: Yes, 2 paths, but that was going to be true anyway with the current CG implementation. | 16:13 |
cknight | ganso: And if we added another group mechanism for replication, it gets worse. | 16:13 |
toabctl | cknight: there could be a "default group" if you are to lazy to create one | 16:13 |
cknight | ganso: And on & on. Better to handle group migration once. | 16:13 |
toabctl | but I havn't followed the discussion and I need to read the wiki first... | 16:14 |
cknight | toabctl: Yes, agreed. I'm envisioning this as consistent as possible with the share types that users & admins already understand. | 16:14 |
*** timcl has quit IRC | 16:16 | |
*** zhongjun has quit IRC | 16:16 | |
ganso | cknight: what other group mechanism for replication, sorry I did not understand this, I thought the approach fits replication | 16:17 |
*** rebase has joined #openstack-manila | 16:18 | |
*** rebase has quit IRC | 16:18 | |
*** merooney has quit IRC | 16:22 | |
gouthamr_ | ganso: think he meant we're not proposing a separate replication group concept anymore | 16:24 |
ganso | gouthamr_: I see, as what was before a replicated CG | 16:25 |
ganso | gouthamr_: thanks | 16:26 |
gouthamr_ | ganso: you're welcome.. | 16:26 |
ganso | xyang1: ping | 16:27 |
gouthamr_ | cknight: i'm wondering how polling for replica health would change -> can it still be atomic to each share replica? | 16:27 |
xyang1 | ganso: I am in meeting now | 16:27 |
ganso | xyang1: ok | 16:28 |
xyang1 | ganso: I can answer you later if you want to write down what you want? | 16:28 |
xyang1 | ganso: back to back meeting all day | 16:28 |
*** merooney has joined #openstack-manila | 16:28 | |
cknight | gouthamr_: good question. I think it would still be atomic on each share, but that would also need to roll up to the group. Just having groups doesn't mean it's members aren't visible or don't have states. | 16:29 |
gouthamr_ | cknight: so the new group model would need to have a replica_state sorta field? | 16:30 |
gouthamr_ | cknight: i know this is still being decided, wanted to chew over the implications :) | 16:30 |
ganso | xyang1: sure. I am sorry I possibly may have misunderstood what you meant about the share type change bug using manage/unmanage. I implied that the admin was wrong (like trying to cheat the system that does not allow retyping) by using it but your scenario may not be intentional at all. I have been thinking about other possible scenarios and would like to | 16:32 |
ganso | know if that is case or not | 16:32 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Implement export location metadata feature https://review.openstack.org/251930 | 16:38 |
*** aorourke has quit IRC | 16:38 | |
*** aorourke has joined #openstack-manila | 16:38 | |
*** aorourke has quit IRC | 16:39 | |
*** aorourke has joined #openstack-manila | 16:40 | |
*** vbellur has quit IRC | 16:40 | |
*** marcusvrn_ has joined #openstack-manila | 16:42 | |
-openstackstatus- NOTICE: Zuul is moving in very slow motion since roughly 13:30 UTC; the Infra team is investigating. | 16:42 | |
*** merooney has quit IRC | 16:45 | |
*** lpetrut has quit IRC | 16:52 | |
xyang1 | ganso: I was not trying to describe a bug for manage/unmanage. I was trying to bring up a general problem that can occur if admin does not do the right things regarding type. sorry for the confusion. | 16:57 |
markstur | toabctl, I'm here now. | 17:01 |
*** tpsilva has quit IRC | 17:01 | |
*** a_ta has quit IRC | 17:03 | |
ganso | xyang1: oh, so it was not a bug at all. thanks for clarifying :) | 17:04 |
*** a_ta has joined #openstack-manila | 17:04 | |
*** eharney has quit IRC | 17:05 | |
markstur | toabctl, vponomaryov https://review.openstack.org/#/c/256019/ is the abandoned client-side fix | 17:06 |
*** a_ta has quit IRC | 17:08 | |
vponomaryov | markstur: this change ignores kwarg | 17:08 |
*** eharney has joined #openstack-manila | 17:09 | |
bswartz | anyone know why the gate is slow today? | 17:09 |
markstur | vponomaryov, should it ignore version? | 17:10 |
markstur | vponomaryov, Ignore 1st positional called "api_version" | 17:10 |
*** merooney has joined #openstack-manila | 17:10 | |
vponomaryov | markstur: I think both should be considered | 17:11 |
vponomaryov | markstur: and if kwarg not set then make it equal to arg | 17:11 |
markstur | vponomaryov, if both set does kwarg overrule positional? | 17:12 |
vponomaryov | markstur: use position for picking up client class and kwarg to provide as argument to that class | 17:13 |
vponomaryov | s/position/positional/ | 17:13 |
markstur | vponomaryov, Doesn't that allow the 2 versions to be inconsistent? | 17:15 |
vponomaryov | markstur: yes | 17:15 |
vponomaryov | markstur: who in sane mind will send incompatible versions? | 17:16 |
vponomaryov | markstur: in this case it should be expected error | 17:16 |
markstur | vponomaryov, inconsistency and insanity are both common afflictions around here | 17:16 |
vponomaryov | markstur: you have better proposal? | 17:17 |
markstur | vponomaryov, No. | 17:17 |
markstur | vponomaryov, Unfortunately I was only looking at the manila-ui. Not so sure about the other callers. | 17:17 |
vponomaryov | markstur: if we keep backward compat, what problems could be? | 17:18 |
vponomaryov | markstur: we have no release of client with broken compat | 17:19 |
vponomaryov | markstur: agree? | 17:19 |
markstur | vponomaryov, yes | 17:19 |
openstackgerrit | Mark Sturdevant proposed openstack/python-manilaclient: Client fix for api_version in positional and kwarg https://review.openstack.org/256019 | 17:22 |
vponomaryov | markstur: are you going to restore this commit? | 17:22 |
vponomaryov | oh ))) | 17:22 |
vponomaryov | 2 sec latency )) | 17:22 |
markstur | vponomaryov, Because of typos | 17:22 |
markstur | vponomaryov, I haven't ran the tests yet. | 17:23 |
markstur | vponomaryov, is that logic what you were thinking | 17:23 |
vponomaryov | markstur: it will fail | 17:25 |
vponomaryov | api_version should instance of class ApiVersion | 17:25 |
vponomaryov | should *be* | 17:25 |
vponomaryov | markstur: so, logic tha tis done for "version" should also applied for "api_version" | 17:26 |
vponomaryov | markstur: if it is set | 17:26 |
vponomaryov | *be* applied | 17:26 |
markstur | vponomaryov, is it possible any client would have done that? | 17:27 |
vponomaryov | markstur: ? | 17:27 |
markstur | vponomaryov, nevermind. fail | 17:27 |
vponomaryov | )) | 17:27 |
vponomaryov | markstur: added comments | 17:30 |
*** eharney has quit IRC | 17:32 | |
*** lpetrut has joined #openstack-manila | 17:33 | |
*** timcl has joined #openstack-manila | 17:36 | |
openstackgerrit | Mark Sturdevant proposed openstack/python-manilaclient: Client fix for api_version in positional and kwarg https://review.openstack.org/256019 | 17:39 |
markstur | vponomaryov, Still failing some tests, but updated logic | 17:39 |
*** eharney has joined #openstack-manila | 17:49 | |
*** ociuhandu has quit IRC | 17:49 | |
*** merooney has quit IRC | 17:58 | |
*** a_ta has joined #openstack-manila | 17:59 | |
*** merooney has joined #openstack-manila | 18:03 | |
*** esker has joined #openstack-manila | 18:05 | |
*** eharney has quit IRC | 18:11 | |
*** lpetrut has quit IRC | 18:12 | |
*** esker has quit IRC | 18:12 | |
*** esker has joined #openstack-manila | 18:20 | |
*** eharney has joined #openstack-manila | 18:26 | |
markstur | bswartz, cknight, toabctl, vponomaryov, u_glide Anyone have time to review https://review.openstack.org/#/c/245383/ ? It passed check. Needs another approver and a "~reverify" if the gate clears up today | 18:32 |
markstur | ^ It is not as a bad as that red bar makes it look. Mostly test code. | 18:32 |
cknight | markstur: Sure, I | 18:33 |
cknight | have already read it. So I'll look once more. | 18:33 |
markstur | Thanks! | 18:34 |
bswartz | (notice) NOTICE: Zuul is moving in very slow motion since roughly 13:30 UTC; the Infra team is investigating. | 18:38 |
bswartz | ^ saw that from openstackstatus bot | 18:38 |
markstur | My theory is that Zuul is distracted by the new Gerrit UI. | 18:39 |
cknight | markstur: +1 I'm distracted by it as well. And not in a good mesmerizing sort of way. | 18:42 |
*** esker has quit IRC | 18:47 | |
*** esker has joined #openstack-manila | 18:47 | |
*** gouthamr_ has quit IRC | 18:55 | |
*** eharney has quit IRC | 18:56 | |
*** eharney has joined #openstack-manila | 18:56 | |
*** a_ta has quit IRC | 18:57 | |
*** esker has quit IRC | 18:57 | |
*** gouthamr has joined #openstack-manila | 18:57 | |
*** gouthamr has quit IRC | 18:59 | |
*** esker has joined #openstack-manila | 19:04 | |
*** esker has quit IRC | 19:07 | |
*** merooney has quit IRC | 19:12 | |
*** absubram has joined #openstack-manila | 19:15 | |
*** merooney has joined #openstack-manila | 19:31 | |
*** a_ta has joined #openstack-manila | 19:53 | |
*** a_ta has quit IRC | 19:58 | |
openstackgerrit | Diem Tran proposed openstack/manila: Add feature support information of Oracle ZFSSA Manila driver. https://review.openstack.org/259166 | 19:59 |
*** esker has joined #openstack-manila | 20:32 | |
*** esker has quit IRC | 20:32 | |
openstackgerrit | Mark Sturdevant proposed openstack/python-manilaclient: Client fix for api_version in positional and kwarg https://review.openstack.org/256019 | 20:32 |
*** esker has joined #openstack-manila | 20:33 | |
*** a_ta has joined #openstack-manila | 20:39 | |
*** esker has quit IRC | 21:06 | |
*** akerr has quit IRC | 21:36 | |
*** cknight has quit IRC | 21:38 | |
*** ganso has quit IRC | 21:49 | |
*** a_ta has quit IRC | 22:01 | |
*** a_ta has joined #openstack-manila | 22:02 | |
*** merooney has quit IRC | 22:02 | |
*** a_ta has quit IRC | 22:06 | |
*** a_ta has joined #openstack-manila | 22:11 | |
*** a_ta has joined #openstack-manila | 22:11 | |
*** xyang1 has quit IRC | 22:12 | |
*** dustins is now known as dustins|out | 22:12 | |
*** a_ta has quit IRC | 22:16 | |
*** eharney has quit IRC | 22:18 | |
*** absubram has quit IRC | 22:36 | |
*** porrua has quit IRC | 22:42 | |
*** pgbridge has quit IRC | 23:38 | |
*** darrenc is now known as darrenc_afk | 23:44 | |
*** erlon has quit IRC | 23:46 | |
*** esker has joined #openstack-manila | 23:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!