Monday, 2016-02-08

*** haomaiwang has quit IRC00:01
*** haomaiwang has joined #openstack-manila00:01
*** darrenc_afk is now known as darrenc00:13
*** chlong has joined #openstack-manila00:26
*** haomaiwang has quit IRC01:01
*** haomaiwang has joined #openstack-manila01:01
*** chlong has quit IRC01:03
*** haomaiw__ has joined #openstack-manila01:06
*** haomaiwang has quit IRC01:07
*** gouthamr has joined #openstack-manila01:27
*** rkhanbikov has joined #openstack-manila01:35
*** gouthamr has quit IRC01:39
*** rkhanbikov has quit IRC01:40
*** rkhanbikov has joined #openstack-manila01:40
*** haomaiw__ has quit IRC02:01
*** haomaiwang has joined #openstack-manila02:01
*** gouthamr has joined #openstack-manila02:03
*** gouthamr has quit IRC02:05
*** chlong has joined #openstack-manila02:06
*** casusbel_ has joined #openstack-manila02:25
*** casusbelli has quit IRC02:28
*** rkhanbikov has quit IRC02:38
*** akshai has joined #openstack-manila02:48
*** rkhanbikov has joined #openstack-manila02:49
*** akshai has quit IRC02:54
*** haomaiwang has quit IRC03:01
*** haomaiwang has joined #openstack-manila03:01
*** rkhanbikov has joined #openstack-manila03:07
*** rkhanbikov has quit IRC03:13
openstackgerritxing-yang proposed openstack/manila: Manage and unmanage snapshot  https://review.openstack.org/24954203:32
*** rkhanbikov has joined #openstack-manila03:39
*** rkhanbikov has quit IRC03:41
*** rkhanbikov has joined #openstack-manila03:48
*** cknight has joined #openstack-manila03:59
*** haomaiwang has quit IRC04:01
*** haomaiwang has joined #openstack-manila04:01
*** rkhanbikov has quit IRC04:05
*** david-lyle has quit IRC04:30
*** winston-1 has joined #openstack-manila04:36
*** winston-d has quit IRC04:38
*** david-lyle has joined #openstack-manila04:45
*** akerr is now known as akerr_away04:46
*** sgotliv has joined #openstack-manila05:00
*** haomaiwang has quit IRC05:01
*** haomaiwang has joined #openstack-manila05:01
*** rraja has joined #openstack-manila05:22
*** rkhanbikov has joined #openstack-manila05:38
*** cknight has quit IRC05:42
*** haomaiwang has quit IRC06:01
*** haomaiwa_ has joined #openstack-manila06:01
*** sgotliv has quit IRC06:28
*** rkhanbikov has quit IRC06:28
*** rkhanbikov has joined #openstack-manila06:29
*** haomaiwa_ has quit IRC07:01
*** haomaiwang has joined #openstack-manila07:01
*** rkhanbikov has quit IRC07:03
*** chlong has quit IRC07:03
*** rkhanbikov has joined #openstack-manila07:03
*** haomaiwang has quit IRC08:01
*** haomaiwang has joined #openstack-manila08:01
*** haomaiwang has quit IRC08:10
*** haomaiwa_ has joined #openstack-manila08:11
*** chlong has joined #openstack-manila08:48
*** nkrinner has joined #openstack-manila08:53
*** haomaiwa_ has quit IRC09:01
*** haomaiwa_ has joined #openstack-manila09:01
*** openstackgerrit has quit IRC09:02
*** openstackgerrit has joined #openstack-manila09:03
*** lpetrut has joined #openstack-manila09:14
*** haomaiwa_ has quit IRC10:01
*** haomaiwang has joined #openstack-manila10:01
*** ociuhandu has quit IRC10:30
openstackgerritvenkatamahesh proposed openstack/manila: Fix two words spelling  https://review.openstack.org/27558810:44
openstackgerritvenkatamahesh proposed openstack/manila: Fix misspellings  https://review.openstack.org/27558810:48
*** tpsilva has joined #openstack-manila10:49
*** jcsp has joined #openstack-manila10:55
*** haomaiwang has quit IRC11:01
*** 21WAA0U3N has joined #openstack-manila11:01
openstackgerritvenkatamahesh proposed openstack/manila: Fix misspellings  https://review.openstack.org/27558811:09
openstackgerritAlexey Ovchinnikov proposed openstack/manila: [WIP] LXC/LXD driver  https://review.openstack.org/24575111:12
*** akerr has joined #openstack-manila11:17
*** akerr_away has quit IRC11:18
*** zhonghua has quit IRC11:22
*** zhonghua-lee has joined #openstack-manila11:23
*** ganso has joined #openstack-manila11:58
*** 21WAA0U3N has quit IRC12:01
*** erlon has joined #openstack-manila12:01
*** haomaiwang has joined #openstack-manila12:01
*** alyson_ has joined #openstack-manila12:09
*** adrianofr has joined #openstack-manila12:20
*** timcl has joined #openstack-manila12:23
*** ociuhandu has joined #openstack-manila12:25
*** akerr has quit IRC12:34
*** krotscheck_dcm is now known as krotscheck12:39
openstackgerritAlyson proposed openstack/manila: Update the share access interface for Hitachi HNAS driver  https://review.openstack.org/27736612:42
*** haomaiwang has quit IRC13:01
*** haomaiwang has joined #openstack-manila13:01
*** krotscheck has quit IRC13:06
*** xyang1 has joined #openstack-manila13:16
*** krotscheck has joined #openstack-manila13:18
*** rkhanbikov has joined #openstack-manila13:25
openstackgerritxing-yang proposed openstack/manila: Manage and unmanage snapshot  https://review.openstack.org/24954213:29
*** sgotliv has joined #openstack-manila13:30
*** zhongjun has quit IRC13:38
*** zhongjun has joined #openstack-manila13:39
openstackgerritTiago Pasqualini da Silva proposed openstack/manila: Hitachi HNAS driver share shrink  https://review.openstack.org/26543413:39
*** sgotliv has quit IRC13:45
openstackgerritxing-yang proposed openstack/python-manilaclient: CLI for manage/unmanage snapshot  https://review.openstack.org/24954413:47
*** porrua has joined #openstack-manila13:50
*** akerr has joined #openstack-manila13:52
*** haomaiwang has quit IRC14:01
*** haomaiwang has joined #openstack-manila14:01
*** csaba has quit IRC14:02
*** csaba has joined #openstack-manila14:03
*** gouthamr has joined #openstack-manila14:05
openstackgerritRodrigo Barbieri proposed openstack/manila: Implement update_access() method in generic driver  https://review.openstack.org/25628114:07
openstackgerritAlyson proposed openstack/manila: Implement update_access() method in Hitachi HNAS driver  https://review.openstack.org/27736614:13
*** dcain has joined #openstack-manila14:14
openstackgerritValeriy Ponomaryov proposed openstack/manila: Add ZFSonLinux share driver  https://review.openstack.org/27719214:16
*** merooney has joined #openstack-manila14:20
*** rkhanbikov has quit IRC14:22
*** rkhanbikov has joined #openstack-manila14:22
openstackgerritValeriy Ponomaryov proposed openstack/manila: Add ZFSonLinux share driver  https://review.openstack.org/27719214:28
*** cknight has joined #openstack-manila14:31
*** esker has quit IRC14:31
*** rraja has quit IRC14:35
*** aovchinnikov has joined #openstack-manila14:40
*** dustins has joined #openstack-manila14:49
*** cknight has quit IRC14:55
*** a_ta has joined #openstack-manila14:57
*** haomaiwang has quit IRC15:01
*** haomaiwa_ has joined #openstack-manila15:01
*** eharney has joined #openstack-manila15:13
*** rkhanbikov has quit IRC15:13
*** rkhanbikov has joined #openstack-manila15:18
*** cknight has joined #openstack-manila15:21
*** sgotliv has joined #openstack-manila15:22
openstackgerritValeriy Ponomaryov proposed openstack/manila: Add admin network for DHSS=True share drivers  https://review.openstack.org/26002115:37
*** mtanino has joined #openstack-manila15:37
*** esker has joined #openstack-manila15:38
*** esker has quit IRC15:39
*** esker has joined #openstack-manila15:39
*** adrianofr has quit IRC15:40
openstackgerritMerged openstack/manila: Fix params order in assertEqual  https://review.openstack.org/26672415:41
*** rkhanbikov has quit IRC15:42
openstackgerritAlexey Ovchinnikov proposed openstack/manila: [WIP] LXC/LXD driver  https://review.openstack.org/24575115:43
openstackgerritAlexey Ovchinnikov proposed openstack/manila: LXC/LXD driver  https://review.openstack.org/24575115:44
*** aovchinnikov has quit IRC15:45
*** adrianofr has joined #openstack-manila15:48
*** rkhanbikov has joined #openstack-manila15:56
*** rkhanbikov has quit IRC15:58
*** haomaiwa_ has quit IRC16:01
*** haomaiwang has joined #openstack-manila16:01
*** gouthamr has quit IRC16:11
openstackgerritRodrigo Barbieri proposed openstack/manila: Move Share Migration code to Data Service  https://review.openstack.org/25051516:12
openstackgerritRodrigo Barbieri proposed openstack/manila: Add new Share migration API functions  https://review.openstack.org/25964216:12
gansovponomaryov: ping16:12
vponomaryovganso: pong16:14
gansovponomaryov: Hello. I have been testing an approach to implement admin export location on generic driver in DHSS=True mode16:14
gansovponomaryov: #link https://review.openstack.org/#/c/27692216:15
gansovponomaryov: for that patch, I tried to use the private network as a "fake admin network", since it is not used by tempest when running tests, tempest creates another private network16:15
gansovponomaryov: so I created a neutron port in that network, created a tap interface, and assigned an IP, so the host can have direct connectivity to the share16:16
gansovponomaryov: in my lab it worked16:16
gansovponomaryov: but in CI it didn't16:16
vponomaryov ganso: the same code?16:17
gansovponomaryov: one thing that I observed in my lab, which I suspect is causing the approach to fail, is that I initially wanted to do this with the public network. But the public network is external, is linked directly to br-ex, which the host already has an IP, and when booting the share server VM, it would not assign the IP to the eth1... if I logged in16:17
gansothrough eth0 10.254.0.3 and assign it myself, it would work16:17
gansovponomaryov: yes, in that case, the same code16:18
gansovponomaryov: so, in my lab, using the public network did not work. But the symptom was the same as CI16:18
vponomaryovganso: you do not change config opts in CI16:18
gansovponomaryov: which config opts?16:19
gansovponomaryov: I believe I changed everything I needed through scripts16:19
vponomaryovganso: https://review.openstack.org/#/c/276922/4/devstack/plugin.sh -> no update of option that enables usage of two interfaces16:19
*** gouthamr has joined #openstack-manila16:20
vponomaryovwith public router16:20
gansovponomaryov: as far as I know, no needed to, I am doing the same thing that option does, through the new options I added16:20
gansovponomaryov: because, that option would connect the share server to the private network tempest creates, 10.100.x.x16:21
gansovponomaryov: my options use the previously created private network 10.0.1.0/20, which tempest does not use16:21
vponomaryovganso: wait, you wanted to test DHSS=False driver mode?16:22
gansovponomaryov: no, DHSS=True16:22
vponomaryovganso: options "service_net_name_or_ip" and "tenant_net_name_or_ip" are used only in DHSS=False16:23
gansovponomaryov: yes, I am not using them16:23
vponomaryovganso: in https://review.openstack.org/#/c/276922/4/devstack/plugin.sh you update DHSS=False stuff16:24
gansovponomaryov: that was just something hardcoded I replaced to test16:24
gansovponomaryov: yes, disregard that update16:24
gansovponomaryov: "private" was hardcoded16:24
gansovponomaryov: I tested that in the noshareservers job, which worked16:25
gansovponomaryov: but it is unrelated to what I am trying to do16:25
vponomaryovganso: ok, what is your question?16:25
gansovponomaryov: do you know anything that could possibly cause the share server VM to not have its eth1 IP assigned? API shows correctly, but the eth1 interface in the instance does not have the IP16:26
gansovponomaryov: and the approach I used is very similar to your approach of "connect_share_server_to_tenant_network", except that it does not connect to the host16:26
vponomaryovganso: image should have configuration for two net interfaces16:27
gansovponomaryov: I am doing the same thing the driver already does for the 10.254.0.4 port it creates on host, but for a different network, equivalent to manila_service_network16:27
gansovponomaryov: why does the image have 2 interfaces working correctly with "connect_share_server_to_tenant_network" ?16:28
vponomaryovganso: http://docs.openstack.org/developer/manila/devref/generic_driver.html#requirements-for-service-image16:28
vponomaryovganso: and you do not have errors neither in Nova nor in Neutron?16:28
gansovponomaryov: yes, no errors :(16:28
gansovponomaryov: both Nova and Neutron think the IP is assigned correctly16:29
vponomaryovganso: how do you know that it is not?16:29
vponomaryovganso: maybe you ask too early?16:29
gansovponomaryov: the VM hangs a bit when booting, I can see in the console "Trying to setup network configuration", "Trying for 60 more seconds..."16:29
vponomaryovganso: ask VM for IP16:29
gansovponomaryov: Nova IP reports the IP16:30
gansovponomaryov: Nova *API16:30
vponomaryovganso: how do you know that it is not set?16:30
gansovponomaryov: I ssh into the instance16:30
gansovponomaryov: through eth016:30
gansovponomaryov: ifconfig, ip addr, and I see it is not assigned16:31
*** vbellur has quit IRC16:31
gansovponomaryov: assigning it myself through ifconfig command makes everything work16:31
vponomaryovganso: so, you asked about your local lab, not CI?16:31
gansovponomaryov: it works in my local lab16:31
gansovponomaryov: the scenario I described is when using "public" network16:31
gansovponomaryov: but using "private" network, it works16:31
gansovponomaryov: so I expected "private" network to work on CI16:32
gansovponomaryov: but it looks like it does not assign the IP16:32
gansovponomaryov: on CI, I am not sure16:32
gansovponomaryov: it looks that way16:32
gansovponomaryov: logs are all fine16:32
vponomaryovganso: SSH works via SSH key or password?16:32
gansovponomaryov: in my lab, I believe both worked16:33
vponomaryovganso: is there route for 169.254.169.254?16:33
*** gouthamr has quit IRC16:33
gansovponomaryov: yes16:33
vponomaryovganso: SSH works via SSH key or password?16:34
*** vbellur has joined #openstack-manila16:34
*** gouthamr has joined #openstack-manila16:34
gansovponomaryov: it does not ask for my password, so SSH key is working16:35
*** a_ta has quit IRC16:37
*** a_ta has joined #openstack-manila16:38
gouthamrvponomaryov: ping16:38
*** a_ta has quit IRC16:42
*** bill_az has joined #openstack-manila16:43
vponomaryovganso: what values for config option "connect_share_server_to_tenant_network" is set up in your local lab?16:43
vponomaryovgouthamr: yes?16:44
gansovponomaryov: the option is not configured, so False16:44
vponomaryovs/values/value/16:44
vponomaryovganso: so, using public router and autocreated network in both cases - Ci and local  lab?16:45
vponomaryovganso: did you add new private network to public router?16:45
gouthamrvponomaryov: hi.. was speaking to bswartz this morning about quotas; he thinks there's less value having a global quota for replicas... he prefers a configurable (again, global) limit per share.. i.e, you cannot have more than x number of replicas per share.. and these replicas don't affect your shares quota or your gigabyte quota16:46
*** a_ta has joined #openstack-manila16:47
vponomaryovgouthamr: it will be the same for all tenants/users16:48
vponomaryovgouthamr: not flexible at all16:48
gansovponomaryov: I believe the port I create is independent of public router, it should go directly from the host to the "private" network, through a tunnel16:48
vponomaryovgouthamr: API quota will allow us to make it very flexible16:48
gansovponomaryov: this is the approach I use in CI and local lab16:48
gouthamrvponomaryov: yes.. do you think it should be tenant specific. i've no opinion.. bswartz was wondering if there's value in it.16:48
gansovponomaryov: in local lab the private network is connected to public router, in CI I do not know16:49
gansovponomaryov: I will check the logs16:49
vponomaryovgouthamr: I would do quota16:49
gouthamrvponomaryov: thanks. would you mind it being in a follow up patch?16:49
vponomaryovganso: if you do not add private network to public router explicitly, it is not added there16:50
vponomaryovgouthamr: you mean separate?16:50
gouthamrvponomaryov: yep..16:50
vponomaryovgouthamr: why?16:51
gouthamrvponomaryov: so that you can merge this feature if no other concerns exist, but add the quota limitation in the follow up. i'm looking to work on testing your ZFS implementation today..16:51
gansovponomaryov: through the logs I just confirmed that it is indeed connected16:51
gansovponomaryov:  http://logs.openstack.org/22/276922/4/check/gate-manila-tempest-dsvm-neutron-multibackend/d027d1c/logs/devstacklog.txt.gz16:51
vponomaryovganso: which line?16:52
gansovponomaryov:  search for 5b970ad4-bd48-43d5-97d3-3e28a279ec1816:52
vponomaryovganso: it is public network16:53
vponomaryov(18:31:17) ganso: vponomaryov: but using "private" network, it works16:53
vponomaryov(18:31:28) ganso: vponomaryov: so I expected "private" network to work on CI16:53
gansovponomaryov: that router has network b4ce03a9-de75-4f54-8b4e-5d6e4ddaa0fa (private) connected, and is set gateway to public network16:54
gansovponomaryov: the port is created in private network, I am not sure if public network is needed for that, it should not be16:55
gansovponomaryov: but either way, it is connected16:55
vponomaryovganso: can you point to place in logs that makes you think it does not work?16:56
gansovponomaryov: http://logs.openstack.org/22/276922/4/check/gate-manila-tempest-dsvm-neutron-multibackend/d027d1c/logs/screen-m-dat.txt.gz16:56
*** xyang1 has quit IRC16:57
gansovponomaryov: access is allowed to the private cidr, "iniset $MANILA_CONF DEFAULT migration_data_node_ip $private_subnet_cidr" in devstack/plugin.sh16:57
gansovponomaryov: so, data node has a port in 10.0.1.0/20 network, its IP is 10.0.1.516:58
gansovponomaryov: and I access-allow to 10.0.1.0/2016:58
vponomaryovganso: access rules not related to timeouts16:58
gansovponomaryov: yes... if it had connectivity it should say access-dined16:59
gansovponomaryov: denied16:59
gansovponomaryov: but it appears to not have connectivity, that's why I suspect the eth1 interface does not have its IP set16:59
*** haomaiwang has quit IRC17:01
*** haomaiwang has joined #openstack-manila17:01
gansovponomaryov: using the test patch I linked you, in my lab, the VM works correctly #link http://paste.openstack.org/show/486307/17:07
*** esker has quit IRC17:11
gansovponomaryov: admin node can mount successfully http://paste.openstack.org/show/486309/17:12
vponomaryovganso: where do you create tap device?17:14
vponomaryovganso: I mean code17:14
gansovponomaryov: https://review.openstack.org/#/c/276922/4/manila/share/drivers/service_instance.py17:14
*** xyang1 has joined #openstack-manila17:16
*** a_ta has quit IRC17:16
*** a_ta has joined #openstack-manila17:17
*** a_ta has quit IRC17:19
*** a_ta has joined #openstack-manila17:19
tpsilvacknight: ping17:22
vponomaryovganso: look at logs in http://logs.openstack.org/22/276922/4/check/gate-manila-tempest-dsvm-neutron-multibackend/d027d1c/logs/screen-m-shr.txt.gz , ther is lots of DOWN ports17:25
vponomaryovs/ther/there/17:26
vponomaryovganso: within "b4ce03a9-de75-4f54-8b4e-5d6e4ddaa0fa" subnet that is 10.1.0.0/2017:27
gansovponomaryov: hummm hold on I will compare that to a successful run17:28
*** lpetrut has quit IRC17:28
gansovponomaryov: but either way, search for manila-admin-share, which is the port I create, it is "ACTIVE"17:28
gansovponomaryov: wait, that network that you said that is down is exactly related to my port, but it becomes ACTIVE17:29
vponomaryovganso: http://logs.openstack.org/22/276922/4/check/gate-manila-tempest-dsvm-neutron-multibackend/d027d1c/logs/screen-m-shr.txt.gz#_2016-02-06_13_15_18_61117:30
vponomaryovganso: your port is DOWN17:30
vponomaryovganso: http://logs.openstack.org/22/276922/4/check/gate-manila-tempest-dsvm-neutron-multibackend/d027d1c/logs/screen-m-dat.txt.gz#_2016-02-06_13_28_58_64217:30
vponomaryovganso: "binding:host_id": "" shoudl not be empty17:31
vponomaryovganso: creating port you need to provide host_id17:31
gansovponomaryov: weird, in http://logs.openstack.org/22/276922/4/check/gate-manila-tempest-dsvm-neutron-multibackend/d027d1c/logs/screen-m-shr.txt.gz#_2016-02-06_13_15_26_794 it is up, but in 13:28:58 it is back DOWN o_O17:31
vponomaryovganso: sorry, now I need to go17:32
gansovponomaryov: ok17:32
gansovponomaryov: thanks a lot for your help! I will continue to debug! :)17:32
*** porrua has quit IRC17:38
cknighttpsilva: pong17:39
tpsilvacknight: hello. Sorry to bother, but our CI was cloudy... it's fixed now17:40
tpsilvacknight: https://review.openstack.org/#/c/265434/17:40
tpsilvacknight: it's ready for workflow :)17:40
cknighttpsilva: OK, no worries.  I was going to review that oneā€¦17:40
tpsilvacknight: thank you17:40
*** sgotliv has quit IRC17:41
*** jasonsb has quit IRC17:58
*** haomaiwang has quit IRC18:01
*** haomaiwang has joined #openstack-manila18:01
*** porrua has joined #openstack-manila18:13
*** rkhanbikov has joined #openstack-manila18:16
*** ociuhandu has quit IRC18:16
*** ociuhandu has joined #openstack-manila18:17
*** jwang_ has quit IRC18:17
*** jwang has joined #openstack-manila18:18
*** rkhanbikov has quit IRC18:21
*** a_ta has quit IRC18:21
*** a_ta has joined #openstack-manila18:21
*** rkhanbikov has joined #openstack-manila18:22
*** rkhanbikov has quit IRC18:23
*** a_ta has quit IRC18:26
*** lpetrut has joined #openstack-manila18:48
*** casusbel_ has quit IRC18:53
*** haomaiwang has quit IRC19:01
*** nkrinner has quit IRC19:01
*** haomaiwa_ has joined #openstack-manila19:01
openstackgerritRodrigo Barbieri proposed openstack/manila: Add new Share migration API functions  https://review.openstack.org/25964219:13
*** akshai has joined #openstack-manila19:32
*** a_ta has joined #openstack-manila19:36
*** esker has joined #openstack-manila19:37
*** esker has quit IRC19:37
*** esker has joined #openstack-manila19:38
openstackgerritGoutham Pacha Ravi proposed openstack/manila: Scheduler enhancements for Share Replication  https://review.openstack.org/27754519:39
*** ociuhandu has quit IRC19:46
*** akshai has quit IRC19:57
*** haomaiwa_ has quit IRC20:01
*** haomaiwang has joined #openstack-manila20:01
*** akshai has joined #openstack-manila20:02
*** ociuhandu has joined #openstack-manila20:05
*** cknight has quit IRC20:13
*** cknight has joined #openstack-manila20:15
*** pgbridge has joined #openstack-manila20:24
*** akshai has quit IRC20:24
*** lpabon has joined #openstack-manila20:26
*** akshai has joined #openstack-manila20:36
*** lpabon has quit IRC20:39
*** lpabon has joined #openstack-manila20:43
*** lpetrut has quit IRC20:46
*** lpabon has quit IRC20:47
*** lpabon has joined #openstack-manila20:49
openstackgerritAlex Meade proposed openstack/manila: NetApp: Add Replication support in cDOT  https://review.openstack.org/27541620:52
*** haomaiwang has quit IRC21:01
*** haomaiwang has joined #openstack-manila21:01
*** merooney has quit IRC21:13
*** sedwards has joined #openstack-manila21:15
*** lpetrut has joined #openstack-manila21:22
*** akerr has quit IRC21:23
*** dustins has quit IRC21:24
*** dustins has joined #openstack-manila21:30
openstackgerritRodrigo Barbieri proposed openstack/manila: Add new Share migration API functions  https://review.openstack.org/25964221:30
openstackgerritRodrigo Barbieri proposed openstack/manila: [Do not merge] Testing CI network for migration #3  https://review.openstack.org/27719021:32
*** mtanino has quit IRC21:34
*** porrua has quit IRC21:46
*** dustins has quit IRC21:53
scottdacknight: Hi21:58
*** haomaiwang has quit IRC22:01
*** haomaiwang has joined #openstack-manila22:01
*** timcl has quit IRC22:03
*** akshai has quit IRC22:05
*** cknight has quit IRC22:08
*** cknight has joined #openstack-manila22:12
*** akshai has joined #openstack-manila22:13
cknightscottda: Hi, Scott.22:18
scottdacknight: I had a question regarding when you added /v2 manila endpoint...22:18
cknightscottda: OK, go ahead.22:18
scottdaIt looks like you started by importing the existing manila.api.v1 modueles (like limits, share_networks, share_manage, etc) in v2/router.py22:19
scottdaAnd then only added modules in manila/api/v2 as new features were added.22:20
scottdaIs that correct?22:20
scottdaI ask because PatrickEast was recommending the same thing for the Cinder microversions patches, and it seemed fine but I thought I'd verify with you.22:20
cknightSounds about right.  That's not quite what I did initially, but that's where Manila ended up.22:21
cknightWe also removed all API extensions (the code, not the mechanism itself) during Mitaka, so we don't have to worry about versioning extensions.22:21
*** esker has quit IRC22:22
cknightWe moved all extension code into the API endpoints, with microversions, so both the older extension-style URL works up to a specific microversion, and the newer non-extension URL works for the next microversion.22:22
scottdaAnd the same for tests? I'm starting to look at that code, but I'd like to not have to copy all the /v2 testing in Cinder to the new tests/unit/v3/ dir22:22
scottdaSo you moved the extension code after implementing microversions?22:23
*** esker has joined #openstack-manila22:23
cknightWe duplicated the endpoint clients, but I don't think we duplicated all the tests.  We use DDT to exercise multiple versions of the APIs from each test as appropriate.22:23
scottdacool, that makes sense for the tests.22:24
cknightYes, we moved the extension code in Mitaka, microversions in Liberty.22:24
scottdaOK, that's good news, as I don't think I've time to move the extensions in Mitaka, but I've still hope we can get microversions in.22:24
cknightThe Manila Tempest code is in the Manila tree if you want to see it.  It's in manila/manila_tempest_tests22:25
scottdaGreat. That's my next task.22:25
scottdaThanks for the help.22:25
*** merooney has joined #openstack-manila22:49
*** merooney has quit IRC22:50
*** haomaiwang has quit IRC23:01
*** haomaiwang has joined #openstack-manila23:01
*** eharney has quit IRC23:04
*** mtanino has joined #openstack-manila23:06
*** lpetrut has quit IRC23:08
*** lpabon has quit IRC23:14
*** gouthamr has quit IRC23:15
*** gouthamr has joined #openstack-manila23:15
*** gouthamr has quit IRC23:15
openstackgerritMerged openstack/manila: Hitachi HNAS driver share shrink  https://review.openstack.org/26543423:25
*** liewegas has quit IRC23:39
*** liewegas has joined #openstack-manila23:40
*** esker has quit IRC23:43
*** a_ta has quit IRC23:43
*** a_ta has joined #openstack-manila23:44
*** a_ta has quit IRC23:48
*** akshai has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!