openstackgerrit | Merged openstack/python-manilaclient: Support preferred export locations in Manila CLI https://review.openstack.org/284499 | 00:07 |
---|---|---|
cknight1 | markstur, ganso, bswartz, toabctl: https://review.openstack.org/#/c/278169/ | 00:11 |
*** ganso has quit IRC | 00:19 | |
*** Yogi1 has joined #openstack-manila | 00:27 | |
*** Yogi1 has quit IRC | 00:35 | |
openstackgerrit | Merged openstack/manila: Huawei driver improve support of StandaloneNetworkPlugin https://review.openstack.org/284033 | 00:37 |
*** resker has joined #openstack-manila | 00:45 | |
*** esker has quit IRC | 00:46 | |
*** pgbridge has quit IRC | 01:07 | |
openstackgerrit | Mark Sturdevant proposed openstack/manila-image-elements: Updated from global requirements https://review.openstack.org/278682 | 01:15 |
*** yangyapeng has joined #openstack-manila | 01:15 | |
*** cknight1 has quit IRC | 01:17 | |
*** yangyapeng has quit IRC | 01:19 | |
*** yangyapeng has joined #openstack-manila | 01:23 | |
bswartz | gah! so many merge conflicts in client | 01:25 |
bswartz | was it cknight's patch merging that put them in conflict? | 01:25 |
markstur | I think so. | 01:26 |
markstur | There's a trivial one going in next, but no conflicts on that one. | 01:26 |
bswartz | is anyone working on deconflicting them? | 01:26 |
bswartz | if not I might just do all of them | 01:26 |
bswartz | although I'm looking at a few other things first | 01:27 |
markstur | manage/unmanage is rechecking | 01:27 |
markstur | When one goes in the others have a version problem | 01:27 |
bswartz | okay so maybe we wait for those 2 to merge before rebasing | 01:27 |
markstur | Would have been easier but some of them would get to gate and fail and start over. So it was a race with an undetermined number of laps. | 01:28 |
bswartz | well as long as the unmerged list gets shorter over time there is hope | 01:28 |
markstur | I forgot. That fail was hitting htem all until Valeriy fixed it. | 01:28 |
bswartz | I want to keep making progress though | 01:28 |
bswartz | on the server side we just need to wrap up tegile driver and migration change | 01:29 |
bswartz | and if heketi CI shows up there is a chance to review and merge that driver | 01:29 |
openstackgerrit | Ben Swartzlander proposed openstack/manila: Remove nsenter dependency https://review.openstack.org/287316 | 01:33 |
openstackgerrit | Ben Swartzlander proposed openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 01:38 |
*** amit213 has joined #openstack-manila | 01:41 | |
openstackgerrit | Ben Swartzlander proposed openstack/python-manilaclient: Annotate CLI commands for experimental features https://review.openstack.org/286706 | 01:46 |
openstackgerrit | Ben Swartzlander proposed openstack/python-manilaclient: CLI for manage/unmanage snapshot https://review.openstack.org/249544 | 01:46 |
openstackgerrit | Surya Ghatty proposed openstack/manila: Remove unintended exposure of private attribute https://review.openstack.org/287506 | 01:46 |
bswartz | oh crap! | 01:46 |
bswartz | I screwed up xyang's patch | 01:47 |
bswartz | damn git rebase!!! | 01:47 |
*** openstackgerrit has quit IRC | 01:47 | |
*** openstackgerrit has joined #openstack-manila | 01:48 | |
openstackgerrit | Ben Swartzlander proposed openstack/python-manilaclient: CLI for manage/unmanage snapshot https://review.openstack.org/249544 | 01:50 |
bswartz | okay I'm not going to rebase anything else until that patch merges | 01:53 |
openstackgerrit | Surya Ghatty proposed openstack/manila: Remove unintended exposure of private attribute https://review.openstack.org/287506 | 01:53 |
gouthamr | bswartz: how do you restore an old patchset? :O | 01:54 |
gouthamr | bswartz: with the votes | 01:54 |
markstur | gouthamr, Usually with some googling, some IRC pinging, and some begging (maybe some crying). | 01:55 |
bswartz | git clone https://github.com/openstack/python-manilaclient.git | 01:55 |
bswartz | cd python-manilaclient | 01:55 |
bswartz | git review -d 249544,21 | 01:55 |
bswartz | git review | 01:55 |
markstur | or that | 01:56 |
*** jasonsb has joined #openstack-manila | 01:56 | |
bswartz | ^ those 4 commands | 01:56 |
* bswartz has strong gerrit-fu | 01:56 | |
bswartz | too bad I can't figure out git-rebase | 01:56 |
gouthamr | markstur: hahaha.. i was actually rechecking multiple times and following log files on that patch.. and then suddenly, i saw an "aborted by anonymous". i should get on with life. | 01:57 |
*** baojg has joined #openstack-manila | 01:58 | |
markstur | Life can wait until after M-3. | 01:58 |
gouthamr | wise words indeed | 01:58 |
markstur | Unfortunately I have to step out for about 2h now. Life interrupts. | 01:59 |
*** cknight has joined #openstack-manila | 01:59 | |
*** mtanino has quit IRC | 02:01 | |
gouthamr | :P well come back soon. manila needs y | 02:01 |
gouthamr | you* | 02:01 |
*** jasonsb has quit IRC | 02:02 | |
openstackgerrit | Abhilash Divakaran proposed openstack/manila: Add share driver for Tegile IntelliFlash Arrays https://review.openstack.org/278169 | 02:02 |
*** markstur_ has joined #openstack-manila | 02:16 | |
*** liewegas_ has joined #openstack-manila | 02:18 | |
*** cknight has quit IRC | 02:20 | |
*** mkoderer__ has quit IRC | 02:23 | |
*** vbellur has quit IRC | 02:23 | |
*** markstur has quit IRC | 02:23 | |
*** liewegas has quit IRC | 02:23 | |
*** mkoderer___ has joined #openstack-manila | 02:23 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/python-manilaclient: Revert usage of help text marking "admin only" CLIs https://review.openstack.org/287436 | 02:27 |
*** Yogi1 has joined #openstack-manila | 02:30 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/python-manilaclient: Revert usage of help text marking "admin only" CLIs https://review.openstack.org/287436 | 02:31 |
*** vbellur has joined #openstack-manila | 02:32 | |
gouthamr | tempest decided to break us? http://logs.openstack.org/06/287506/4/check/gate-manila-tempest-dsvm-neutron/0a3140a/console.html | 02:36 |
*** Yogi1 has quit IRC | 02:39 | |
*** fthiagogv_ has quit IRC | 02:47 | |
gouthamr | for anyone else looking, neutron-fwaas changed from tempest_lib to tempest.lib https://github.com/openstack/neutron-fwaas/commit/216e78e93e3e9ea7ba8db278ac938de90ba8552c an hour ago. | 02:48 |
*** resker has quit IRC | 02:48 | |
*** esker has joined #openstack-manila | 02:52 | |
bswartz | we pin ourselves to an old tempest commit though | 02:54 |
bswartz | how are we affected? | 02:55 |
gouthamr | bswartz: yep.. neutron-fwaas updated to use tempest.lib (i.e, lib was copied into tempest) | 02:55 |
gouthamr | bswartz: and our tempest doesn't have that change.. since the copy itself was like a few days ago | 02:55 |
bswartz | but we don't run the neutron tests | 02:56 |
bswartz | tempest changes all the time and it doesn't break us | 02:56 |
gouthamr | bswartz: https://review.openstack.org/#/c/283691/ -> that's the change we don't have | 02:57 |
bswartz | and why does it matter | 02:57 |
gouthamr | bswartz: we don't probably run these tests, but we import them (ostestr imports all tests for its regex filtering) | 02:59 |
gouthamr | bswartz: "Failed to import test module: neutron_fwaas.tests.tempest_plugin.tests.api.test_fwaas_extensions" | 02:59 |
bswartz | ah crap | 02:59 |
gouthamr | bswartz: "ImportError: No module named lib.common.utils" | 02:59 |
bswartz | screwed by neutron again! | 02:59 |
gouthamr | bswartz: may be not.. our tempest is about a month and three days old.. its just time to update :) | 03:00 |
bswartz | yes but NOW is not the ideal time to deal with this crap | 03:00 |
gouthamr | bswartz: true.. | 03:01 |
*** houming has joined #openstack-manila | 03:02 | |
amrith | folks, could someone help me figure out what I'm doing wrong here. I created a manila share (type NFS) which succeeded. | 03:04 |
amrith | amrith@amrith-work:/etc/manila$ manila show a03f92d3-907f-4a66-a716-40e3401ab55b | 03:04 |
amrith | +-----------------------------+--------------------------------------------------------------------+ | 03:04 |
amrith | | Property | Value | | 03:04 |
amrith | +-----------------------------+--------------------------------------------------------------------+ | 03:04 |
amrith | | status | available | | 03:04 |
amrith | | share_type_name | default | | 03:04 |
amrith | | description | None | | 03:04 |
amrith | | availability_zone | nova | | 03:04 |
bswartz | amrith: paste.openstack.org is your friend | 03:04 |
amrith | | share_network_id | 7a9c3dc6-9d00-43ed-b56f-f77384fcbd92 | | 03:04 |
gouthamr | amrith: paste.openstack.org :) | 03:04 |
amrith | | export_locations | | | 03:04 |
amrith | | | uuid = f2c153fe-d62a-4762-9a4c-1f41cdfab234 | | 03:05 |
amrith | | | created_at = 2016-03-03T02:41:02.000000 | | 03:05 |
amrith | | | updated_at = 2016-03-03T02:41:02.000000 | | 03:05 |
amrith | | | is_admin_only = False | | 03:05 |
amrith | | | share_instance_id = 124d4522-b2c1-49a4-9fea-0fc037f3cfa8 | | 03:05 |
amrith | | | path = 10.0.0.2:/shares/share-124d4522-b2c1-49a4-9fea-0fc037f3cfa8 | | 03:05 |
amrith | | share_server_id | 0027c61c-bbed-460a-bfe2-6be9c2d46dd6 | | 03:05 |
amrith | | host | amrith-work@generic1#GENERIC1 | | 03:05 |
amrith | | access_rules_status | active | | 03:05 |
amrith | | snapshot_id | None | | 03:05 |
amrith | | is_public | False | | 03:05 |
amrith | | task_state | None | | 03:05 |
amrith | | snapshot_support | True | | 03:05 |
amrith | | id | a03f92d3-907f-4a66-a716-40e3401ab55b | | 03:05 |
amrith | | size | 3 | | 03:05 |
amrith | | name | testshare | | 03:05 |
amrith | | share_type | dfeba8fc-2046-41aa-a2a4-be191b04b38b | | 03:05 |
amrith | | has_replicas | False | | 03:05 |
amrith | | replication_type | None | | 03:05 |
amrith | | created_at | 2016-03-03T02:40:13.000000 | | 03:06 |
amrith | | share_proto | NFS | | 03:06 |
amrith | | consistency_group_id | None | | 03:06 |
amrith | | source_cgsnapshot_member_id | None | | 03:06 |
amrith | | project_id | 391a288e0dff4df9ae0009248d1bbfaf | | 03:06 |
amrith | | metadata | {} | | 03:06 |
amrith | +-----------------------------+--------------------------------------------------------------------+ | 03:06 |
amrith | amrith@amrith-work:/etc/manila$ | 03:06 |
amrith | amrith@amrith-work:~$ showmount -e 10.0.0.2 | 03:06 |
amrith | Export list for 10.0.0.2: | 03:06 |
amrith | amrith@amrith-work:~$ | 03:06 |
amrith | On the Manila instance, take a look at the mounts. | 03:06 |
amrith | amrith@amrith-work:~$ ssh manila@10.0.0.2 | 03:06 |
amrith | Welcome to Ubuntu 14.04.2 LTS (GNU/Linux 3.13.0-53-generic i686) | 03:06 |
amrith | * Documentation: https://help.ubuntu.com/ | 03:06 |
amrith | Last login: Thu Mar 3 02:51:44 2016 from 10.0.0.1 | 03:06 |
amrith | $ more /etc/mtab | 03:06 |
amrith | [...] | 03:06 |
amrith | What's the command to mount this? I'm assuming it is | 03:06 |
amrith | amrith@amrith-work:~$ sudo mount -t nfs 10.0.0.2:/shares/share-124d4522-b2c1-49a4-9fea-0fc037f3cfa8 /tmp/mountpoint | 03:06 |
amrith | mount.nfs: access denied by server while mounting 10.0.0.2:/shares/share-124d4522-b2c1-49a4-9fea-0fc037f3cfa8 | 03:06 |
amrith | amrith@amrith-work:~$ | 03:06 |
amrith | But I get the error (above). Any idea what I'm doing wrong? | 03:06 |
amrith | bswartz, yes, sorry ... I did gist but I guess I forgot to copy the gist URL ;( | 03:07 |
amrith | DOH! | 03:07 |
amrith | OK, this time, I'm copying correctly ... | 03:07 |
amrith | https://gist.github.com/anonymous/feb7433f5fc14204498b | 03:07 |
amrith | bswartz, gouthamr thanks (in advance) | 03:07 |
amrith | In effect, I can't seem to get access to the NFS share. | 03:07 |
amrith | clearly it is accessible (showmount) | 03:07 |
amrith | but why not mount? | 03:07 |
gouthamr | bswartz: https://github.com/openstack/tempest-lib/commit/781aec763e6f46f070c960e5e19a4c0d5be1ecb8 | 03:07 |
gouthamr | amrith: you need access-allow | 03:08 |
amrith | gouthamr, I did | 03:08 |
amrith | The command was ... | 03:08 |
gouthamr | amrith: sorry didn't see that command in the paste.. | 03:08 |
amrith | manila access-allow a03f92d3-907f-4a66-a716-40e3401ab55b ip 0.0.0.0/0 --access-level rw | 03:08 |
amrith | yes, you are correct. I should have added that I did do that | 03:08 |
bswartz | amrith: tried sudo mount -t nfs -o vers=3 .... ? | 03:09 |
bswartz | if you're doing NFSv4 lots of things can go wrong | 03:09 |
amrith | bswartz, let me check | 03:09 |
bswartz | you can also inspect the syslog on the service instance to see why access was deined | 03:10 |
bswartz | denied | 03:10 |
amrith | same error | 03:10 |
amrith | nothing in the auth.log on the manila instance | 03:10 |
amrith | I'm not sure where NFS logs errors | 03:10 |
bswartz | /var/log/syslog IIRC | 03:10 |
amrith | sorry, nothing there | 03:12 |
bswartz | what's the IP of the machine mounting? | 03:13 |
bswartz | usually when I can't get an error message out of the client or the server and NFS is still giving access denied my next step is wireshark | 03:14 |
amrith | bswartz, I've tried from both 10.0.0.1 and from on the manila server itself. | 03:16 |
bswartz | okay just wanted to know if it was same L2 segment | 03:17 |
bswartz | sounds like yes | 03:17 |
bswartz | so I'm out of ideas | 03:17 |
amrith | ok, this is weird | 03:18 |
amrith | I did this ... | 03:18 |
amrith | manila access-allow a03f92d3-907f-4a66-a716-40e3401ab55b ip 10.0.0.1/32 --access-level rw | 03:18 |
amrith | Now I'm able to mount it | 03:18 |
amrith | so, what's the wildcard address? 0.0.0.0/0? | 03:18 |
amrith | yes, that's the standard representation for * | 03:18 |
bswartz | NFS servers don't always respond well to that wildcard | 03:19 |
bswartz | if you did 10.0.0.0/24 it probably would have worked | 03:19 |
amrith | let me try that ... | 03:19 |
gouthamr | bswartz: https://bugs.launchpad.net/manila/+bug/1552520 | 03:19 |
openstack | Launchpad bug 1552520 in Manila "Manila tempest jobs are broken - Need to switch to using tempest.lib over tempest_lib" [Undecided,New] | 03:19 |
bswartz | I'm not sure why, but it could be a limitation of nfs-kernel-server | 03:19 |
gouthamr | bswartz: adding details. | 03:19 |
openstackgerrit | Ben Swartzlander proposed openstack/manila: Update tempest commit and switch to tempest.lib https://review.openstack.org/287574 | 03:20 |
amrith | bswartz, that works too. | 03:20 |
amrith | many thanks! | 03:20 |
amrith | Yippie doo-dah, I have a manila share. | 03:20 |
openstackgerrit | Tin Lam proposed openstack/manila: Moved CORS middleware configuration into oslo-config-generator https://review.openstack.org/287575 | 03:20 |
bswartz | amrith: you might want to file a bug about the 0.0.0.0/0 thing -- IMO that should work | 03:20 |
amrith | A bottle of champagne on its way to you bswartz ... Thanks, and good night. | 03:20 |
*** jwang_ has joined #openstack-manila | 03:21 | |
amrith | bswartz, I will retest and file a bug. | 03:21 |
amrith | thanks muchly | 03:21 |
bswartz | gouthamr: that patch hasn't been tested, I only pushed it so you can take a look and see if I missed anything | 03:22 |
bswartz | I'm testing it now | 03:22 |
gouthamr | bswartz: sure thing. | 03:22 |
*** netapp_ has joined #openstack-manila | 03:25 | |
*** divab has joined #openstack-manila | 03:26 | |
*** netapp has quit IRC | 03:26 | |
*** vponomaryov has quit IRC | 03:26 | |
*** abhi has quit IRC | 03:26 | |
*** jwang__ has quit IRC | 03:26 | |
*** sbjorn has quit IRC | 03:26 | |
*** _laco has quit IRC | 03:26 | |
*** netapp_ is now known as netapp | 03:27 | |
*** vponomaryov has joined #openstack-manila | 03:27 | |
amrith | bswartz, confirmed and entered a bug. https://bugs.launchpad.net/manila/+bug/1552526 | 03:32 |
openstack | Launchpad bug 1552526 in Manila "manila access-allow doesn't appear to properly handle 0.0.0.0" [Undecided,New] | 03:32 |
amrith | thanks | 03:32 |
*** cknight has joined #openstack-manila | 03:33 | |
*** baojg has quit IRC | 03:35 | |
*** _laco has joined #openstack-manila | 03:37 | |
*** baojg has joined #openstack-manila | 03:38 | |
sghatty | Hi All: I have submitted a patch for https://bugs.launchpad.net/manila/+bug/1551497. However, Jenkins reports that all the tempest tests have failed for this patch. | 03:42 |
openstack | Launchpad bug 1551497 in Manila "ganesha: private attribute leaks to public API" [Undecided,In progress] - Assigned to Surya Ghatty (ghatty) | 03:42 |
sghatty | Are these failures related to the bug here: https://bugs.launchpad.net/manila/+bug/1552520? or should I be worried that I introduced something to cause these failures? | 03:43 |
openstack | Launchpad bug 1552520 in Manila "Manila tempest jobs are broken - Need to switch to using tempest.lib over tempest_lib" [Critical,In progress] - Assigned to Ben Swartzlander (bswartz) | 03:43 |
bswartz | sghatty: yes our tempest tests seem to be broken thanks to neutron | 03:46 |
bswartz | it's probably not your fault | 03:46 |
gouthamr | amrith: still here | 03:46 |
gouthamr | ? | 03:46 |
amrith | yes | 03:47 |
amrith | sorry, had to step away for a couple of minutes. | 03:47 |
gouthamr | hey amrith.. | 03:47 |
gouthamr | np.. | 03:47 |
amrith | hiya gouthamr | 03:47 |
gouthamr | amrith: https://bugs.launchpad.net/manila/+bug/1552526 | 03:47 |
openstack | Launchpad bug 1552526 in Manila "manila access-allow doesn't appear to properly handle 0.0.0.0" [Undecided,New] | 03:47 |
amrith | yes | 03:47 |
gouthamr | amrith: what backend are you using? | 03:47 |
bswartz | gouthamr: generic driver | 03:48 |
bswartz | that should be mentioned in the bug | 03:48 |
bswartz | it's almost certainly a driver-specific bug | 03:48 |
amrith | yes, generic driver and I added a line about NOVA ... | 03:48 |
amrith | I will update the bug | 03:48 |
amrith | thanks. | 03:48 |
gouthamr | bswartz: yes.. ran through the code path if we're throwing it out anywhere, just in case.. this is at the driver. | 03:48 |
gouthamr | thanks amrith | 03:48 |
amrith | done | 03:49 |
gouthamr | haha, my bad... i've seen crazy host names so i ignored: "amrith-work@generic1#GENERIC1" which probably would've answered my question :) | 03:49 |
sghatty | bswartz, thanks for the info. Do I have to re-do the git review once the tempest tests are back? | 03:50 |
amrith | no worries gouthamr ... my first week with Manila | 03:50 |
amrith | so I have no idea what I'm up to | 03:50 |
gouthamr | sghatty: nope.. we'll recheck once we fix it. | 03:50 |
gouthamr | amrith: glad you're trying manila :) | 03:50 |
*** a_ta has joined #openstack-manila | 03:51 | |
amrith | gouthamr, working on seeing what it'll take to make Trove use Manila | 03:51 |
gouthamr | amrith: sweet! | 03:51 |
bswartz | sghatty: you'll need to rebase your change on top of the gate-fixing change, or add Depends-On to the commit message, or wait for the fix to merge | 03:51 |
bswartz | any of those 3 should do it | 03:52 |
*** sbjorn has joined #openstack-manila | 03:52 | |
bswartz | we haven't confirmed a fix yet though | 03:52 |
gouthamr | amrith: good luck, and "Help will always be given at *cough cough* #openstack-manila to those who ask for it." 8) | 03:53 |
amrith | gouthamr, yes. have had occasion to use that help a couple of times today. earlier today with vponomaryov. just now with bswartz and you. thanks folks! good night (for now). bbitm ;) | 03:54 |
gouthamr | bswartz: it could be our lucky day.. i only see ... ok's so far.. https://jenkins06.openstack.org/job/gate-manila-tempest-dsvm-neutron/1743/console | 03:54 |
gouthamr | goodnight amrith ! | 03:54 |
bswartz | gouthamr: pep8 is taking a dump on my change though | 03:54 |
bswartz | damn alphabetical order imports | 03:54 |
gouthamr | bswartz: those are always the hardest to fix ;) | 03:55 |
bswartz | there's like 25 files! | 03:55 |
*** a_ta has quit IRC | 03:55 | |
bswartz | editting them all will take forever | 03:55 |
sghatty | bswartz: sounds like a painful process. anything I can do to help? | 03:58 |
bswartz | sghatty: write a script that makes pep8 actually fix the errors it finds rather than just complaining about them | 03:58 |
bswartz | ¬_¬ | 03:58 |
sghatty | 😃 | 03:58 |
*** shausy has joined #openstack-manila | 04:00 | |
*** divab is now known as abhi | 04:03 | |
bswartz | gouthamr: tempest passed on my dev system | 04:07 |
bswartz | pep8 nearly sorted out | 04:07 |
gouthamr | bswartz: awesome.. do you have a multibackend setup? | 04:07 |
mdnadeem | sghatty, bswartz , gouthamr , can you please respnse to this query: http://pastebin.com/uKmRSD2b | 04:07 |
bswartz | mdnadeem: I've got your email -- honestly I don't know what's going on with ubuntu's packages | 04:08 |
bswartz | I was going to investigate after we get pass feature freeze | 04:08 |
bswartz | this isn't a good time | 04:08 |
openstackgerrit | Ben Swartzlander proposed openstack/manila: Update tempest commit and switch to tempest.lib https://review.openstack.org/287574 | 04:09 |
mdnadeem | bswartz, ohk, Thanks for your response :) | 04:09 |
gouthamr | bswartz: looks like we're good. The tests nearly passed.. | 04:11 |
gouthamr | bswartz: and your rebase worked.. https://review.openstack.org/#/c/286706 | 04:13 |
bswartz | gouthamr: yeah I have a good feeling | 04:16 |
bswartz | too bad nobody is around to merge it | 04:16 |
gouthamr | vponomaryov uses "ninja-merging" as a technique to unblock gates. | 04:16 |
bswartz | yes for a gate blocker a ninja merge may be called for | 04:17 |
*** amrith is now known as _amrith_ | 04:19 | |
bswartz | also infra is really not very busy right now so maybe things will go fast | 04:21 |
bswartz | still it will probably be past midnight | 04:22 |
* bswartz doesn't want to stay up all night... | 04:22 | |
sghatty | bswartz: So, would adding this to the end of my commit message work for my patch? | 04:22 |
sghatty | Depends-On: Id7d43dee256856062bd0dadad9c469c1500ee36e | 04:22 |
sghatty | I pulled that id from your proposed change | 04:23 |
bswartz | yes | 04:23 |
bswartz | Depends-On will work as long as your patch doesn't conflict with my patch | 04:23 |
openstackgerrit | Surya Ghatty proposed openstack/manila: Remove unintended exposure of private attribute https://review.openstack.org/287506 | 04:23 |
sghatty | thanks, bswartz. No conflicts - going by the files you changed. | 04:25 |
* gouthamr we should have core members around the world :) | 04:25 | |
bswartz | we do... | 04:25 |
bswartz | we have 5 timezones covered | 04:26 |
gouthamr | 5? EST, PST, GMT+2, UTC-3:00 .. | 04:26 |
gouthamr | oh wait, the US is like 5 timezones in itself. | 04:27 |
bswartz | US east, US west, Brazil, Germany, Ukraine | 04:27 |
gouthamr | ah i left out Germany. | 04:28 |
openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs-native: use Heketi layout via self-signing https://review.openstack.org/282101 | 04:28 |
openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs: heketi: Add support for JWT Auth https://review.openstack.org/280486 | 04:28 |
openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs: introducing Heketi layout https://review.openstack.org/279090 | 04:28 |
bswartz | csaba: you're up late! | 04:28 |
csaba | bswartz: or early? ;) | 04:28 |
bswartz | csaba: heketi CI reporting yet? | 04:29 |
bswartz | good point | 04:29 |
gouthamr | insert -(talk about US centric)- joke here. | 04:29 |
bswartz | gouthamr: csaba is in Hungary IIRC -- it must be 5:30 AM there | 04:30 |
gouthamr | bswartz: ah... that's early then. | 04:30 |
csaba | bswartz: correct | 04:32 |
bswartz | markstur_ vponomaryov toabctl cknight: looking for reviews on https://review.openstack.org/#/c/287574/ planning to ninja merge if needed | 04:34 |
csaba | bswartz: the update I've just committed was a fix for a blocker issue. | 04:34 |
bswartz | csaba: I saw 3 commits | 04:35 |
csaba | bswartz: the actual fixage was for the first one, the other two has been updates and dependents. | 04:35 |
csaba | (or in order of openstackgerrit reporting, last one) | 04:36 |
bswartz | csaba: I don't understand how we're going to get heketi CI -- do you have a project-config patch waiting for merge? there's no job yet | 04:37 |
bswartz | csaba: also unit tests already failed on your patch | 04:38 |
bswartz | i'm watching zuul | 04:38 |
cknight | bswartz: I wondered why everything was failing suddenly. | 04:39 |
openstackgerrit | Merged openstack/manila-image-elements: Updated from global requirements https://review.openstack.org/278682 | 04:40 |
bswartz | cknight: read back last 75 minutes | 04:40 |
csaba | bswartz: what fails? | 04:42 |
bswartz | csaba: see for yourself https://jenkins07.openstack.org/job/gate-manila-python27/1807/console | 04:43 |
bswartz | csaba: did you not do run_tests.sh? | 04:43 |
*** jasonsb has joined #openstack-manila | 04:45 | |
openstackgerrit | Ben Swartzlander proposed openstack/manila: Remove nsenter dependency https://review.openstack.org/287316 | 04:45 |
*** resker has joined #openstack-manila | 04:45 | |
*** esker has quit IRC | 04:47 | |
*** fthiagogv_ has joined #openstack-manila | 04:51 | |
bswartz | markstur_: thanks for covering the migration patch | 04:52 |
bswartz | markstur_: it will need at least 1 recheck after my fix merges | 04:52 |
*** fthiagogv has quit IRC | 04:54 | |
bswartz | just need a second reviewer for tegile driver now | 04:55 |
gouthamr | https://jenkins04.openstack.org/job/gate-manila-tempest-dsvm-neutron-multibackend/1005/console <- ninja merge is indeed in order. Nice job, back to replication now.. goodnight bswartz! | 05:01 |
*** gouthamr has quit IRC | 05:03 | |
cknight | bswartz: looks good, thanks for the fix | 05:03 |
bswartz | cknight: gouthamr actually figured out what went wrong and how to fix it | 05:04 |
bswartz | I just spent 15 minutes fighting with pep8 to actually make the fix | 05:04 |
cknight | bswartz: Goutham helped me with a Tempest failure this morning. I nominate him to fix all our concurrency issues. | 05:05 |
*** cknight has quit IRC | 05:08 | |
*** martyturner has joined #openstack-manila | 05:09 | |
*** martyturner has quit IRC | 05:14 | |
abhi | what is "ninja merging"? | 05:15 |
bswartz | abhi: it's an exception to our normal rules for workflowing changes | 05:16 |
bswartz | every core has the power to merge changes by themselves, but we restrain ourselves and require two +2 before something merges | 05:17 |
abhi | bswartz: I see, thanks for ninja merging then. CI was failing for all the tests :( | 05:18 |
bswartz | abhi: yes, you can rebase on top of my fix or use the Depends-On line in your commit message | 05:19 |
bswartz | that will enable you to pass tempest earlier than waiting for my patch to merge | 05:19 |
bswartz | it's possible my patch will require a recheck or 2 if the gate is unfriendly tonight | 05:19 |
openstackgerrit | Merged openstack/python-manilaclient: CLI for manage/unmanage snapshot https://review.openstack.org/249544 | 05:39 |
*** fthiagogv__ has joined #openstack-manila | 05:40 | |
*** fthiagogv_ has quit IRC | 05:43 | |
openstackgerrit | Ben Swartzlander proposed openstack/python-manilaclient: Annotate CLI commands for experimental features https://review.openstack.org/286706 | 05:50 |
openstackgerrit | Devin proposed openstack/manila: [Doc] Update quick start guide from Kilo release to Liberty release. https://review.openstack.org/287604 | 05:53 |
*** resker has quit IRC | 06:01 | |
*** esker has joined #openstack-manila | 06:05 | |
openstackgerrit | Ben Swartzlander proposed openstack/manila: Remove nsenter dependency https://review.openstack.org/287316 | 06:07 |
*** mdnadeem has quit IRC | 06:27 | |
*** mdnadeem has joined #openstack-manila | 06:27 | |
*** rraja has joined #openstack-manila | 06:32 | |
*** amit213 has quit IRC | 06:33 | |
*** rraja has quit IRC | 06:35 | |
*** rraja|afk is now known as rraja | 06:35 | |
*** ayma has joined #openstack-manila | 06:43 | |
*** lpetrut has joined #openstack-manila | 06:58 | |
*** amit213 has joined #openstack-manila | 07:04 | |
*** amit213 has quit IRC | 07:06 | |
*** amit213 has joined #openstack-manila | 07:08 | |
*** amit213 has quit IRC | 07:10 | |
openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs-native: use Heketi layout via self-signing https://review.openstack.org/282101 | 07:14 |
openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs: heketi: Add support for JWT Auth https://review.openstack.org/280486 | 07:14 |
openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs: introducing Heketi layout https://review.openstack.org/279090 | 07:14 |
*** amit213 has joined #openstack-manila | 07:15 | |
*** mdnadeem has quit IRC | 07:16 | |
*** mdnadeem has joined #openstack-manila | 07:16 | |
*** jasonsb has quit IRC | 07:16 | |
*** amit213 has quit IRC | 07:18 | |
*** lpetrut has quit IRC | 07:39 | |
*** amit213 has joined #openstack-manila | 07:40 | |
*** amit213 has quit IRC | 07:42 | |
openstackgerrit | Andrea Ma proposed openstack/manila: glusterManager instantiation regexp validation https://review.openstack.org/283777 | 07:44 |
*** pcaruana has joined #openstack-manila | 07:45 | |
*** jasonsb has joined #openstack-manila | 07:47 | |
openstackgerrit | Merged openstack/manila: Update tempest commit and switch to tempest.lib https://review.openstack.org/287574 | 07:50 |
*** jasonsb has quit IRC | 07:52 | |
*** yangyape_ has joined #openstack-manila | 07:53 | |
*** yangyapeng has quit IRC | 07:56 | |
*** yangyapeng has joined #openstack-manila | 07:59 | |
*** resker has joined #openstack-manila | 08:01 | |
*** esker has quit IRC | 08:01 | |
*** yangyape_ has quit IRC | 08:02 | |
*** amit213 has joined #openstack-manila | 08:09 | |
sghatty | bswartz, many tests still failing on my patch. Do I need to re-submit it? Any suggestions? | 08:11 |
sghatty | https://review.openstack.org/#/c/287506/ | 08:11 |
*** amit213 has quit IRC | 08:13 | |
*** amit213 has joined #openstack-manila | 08:16 | |
openstackgerrit | Mark Sturdevant proposed openstack/manila: Move Share Migration code to Data Service https://review.openstack.org/250515 | 08:16 |
*** amit213 has quit IRC | 08:18 | |
*** amit213 has joined #openstack-manila | 08:24 | |
openstackgerrit | Andrea Ma proposed openstack/manila: glusterManager instantiation regexp validation https://review.openstack.org/283777 | 08:35 |
openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs-native: use Heketi layout via self-signing https://review.openstack.org/282101 | 08:43 |
openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs: heketi: Add support for JWT Auth https://review.openstack.org/280486 | 08:43 |
openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs: introducing Heketi layout https://review.openstack.org/279090 | 08:43 |
*** jasonsb has joined #openstack-manila | 08:51 | |
*** jasonsb has quit IRC | 08:55 | |
*** resker has quit IRC | 09:01 | |
*** esker has joined #openstack-manila | 09:05 | |
openstackgerrit | Abhilash Divakaran proposed openstack/manila: Add share driver for Tegile IntelliFlash Arrays https://review.openstack.org/278169 | 09:25 |
*** ayma has quit IRC | 09:38 | |
*** houming has quit IRC | 09:39 | |
*** mdnadeem_ has joined #openstack-manila | 09:47 | |
*** mdnadeem has quit IRC | 09:50 | |
*** sbjorn has quit IRC | 09:53 | |
*** openstackgerrit_ has joined #openstack-manila | 09:54 | |
*** openstackgerrit_ has quit IRC | 10:02 | |
*** sbjorn has joined #openstack-manila | 10:14 | |
*** nidhimittalhada has joined #openstack-manila | 10:14 | |
*** yangyapeng has quit IRC | 10:16 | |
*** jasonsb has joined #openstack-manila | 10:52 | |
*** tpsilva has joined #openstack-manila | 10:55 | |
*** lpetrut has joined #openstack-manila | 10:56 | |
*** jasonsb has quit IRC | 10:57 | |
*** baojg has quit IRC | 10:58 | |
*** nidhimittalhada has quit IRC | 11:01 | |
*** mdnadeem_ has quit IRC | 11:03 | |
*** ociuhandu has joined #openstack-manila | 11:06 | |
*** rraja has quit IRC | 11:08 | |
*** rraja has joined #openstack-manila | 11:08 | |
*** dencaval has joined #openstack-manila | 11:25 | |
*** yangyapeng has joined #openstack-manila | 11:32 | |
*** yangyapeng has quit IRC | 11:33 | |
*** yangyapeng has joined #openstack-manila | 11:33 | |
*** mdnadeem has joined #openstack-manila | 11:37 | |
*** ganso has joined #openstack-manila | 11:57 | |
*** openstackgerrit has quit IRC | 12:03 | |
*** openstackgerrit has joined #openstack-manila | 12:04 | |
*** _amrith_ is now known as amrith | 12:09 | |
*** Yogi1 has joined #openstack-manila | 12:10 | |
rraja | ganso: ping | 12:11 |
ganso | rraja: pong | 12:12 |
*** Yogi1_ has joined #openstack-manila | 12:13 | |
rraja | ganso: about your comments on https://review.openstack.org/#/c/274952/4/manilaclient/v2/shares.py | 12:15 |
rraja | ganso: wondering if this is what you suggest, http://pastebin.com/zDag9sZ6 , can you please take a look? | 12:16 |
*** Yogi1 has quit IRC | 12:17 | |
ganso | rraja: yes! looks great! =D | 12:21 |
openstackgerrit | Surya Ghatty proposed openstack/manila: Remove unintended exposure of private attribute https://review.openstack.org/287506 | 12:22 |
rraja | ganso: i'm confused about what really calls that allow() with different arguments, particularly valid_access_types, based on api microversion? | 12:23 |
rraja | ganso: i'm finding it hard to follow the call flow | 12:23 |
ganso | rraja: yes, that part is missing from your pastebin | 12:23 |
ganso | rraja: it is line 449 | 12:24 |
rraja | ganso: OK, or more correctly line 438? | 12:25 |
openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Fix update_access concurrency issue https://review.openstack.org/287758 | 12:25 |
ganso | rraja: my mistake, no I got it mixed up as well, you should move your validation code to line 449 | 12:26 |
openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Fix update_access concurrency issue https://review.openstack.org/287758 | 12:27 |
ganso | rraja: line 58 comes directly from shell.py | 12:27 |
ganso | rraja: that section cannot be microversioned | 12:27 |
ganso | rraja: let me confirm this again | 12:28 |
openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Fix update_access concurrency issue https://review.openstack.org/287758 | 12:28 |
*** Yogi1_ has quit IRC | 12:28 | |
rraja | ganso: so the call flow is actually, shell.Share.allow() --> shares.Share.allow() ---> share.ShareManager.allow() ? | 12:29 |
ganso | rraja: correct | 12:30 |
ganso | so shares.Share.allow() should not have this intelligence | 12:30 |
ganso | rraja: ^ | 12:30 |
ganso | rraja: share.ShareManager.allow is microversioned, and should be performing validation | 12:31 |
rraja | ganso: yep. i was confused with your comments. so i just add another share.ShareManager.allow microversion with 2.13 (start) and perform extra ceph validation there. | 12:32 |
ganso | rraja: extra ceph validation? you moved the validation code or created another section? | 12:33 |
rraja | ganso: and leave share.Share.allow() and share.Share._validate_access() unchanged? | 12:34 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Move Share Migration code to Data Service https://review.openstack.org/250515 | 12:34 |
rraja | ganso: I currently modify share.Share._validate_access(). | 12:35 |
ganso | rraja: no, move share.Share._validate_access() | 12:35 |
rraja | in the diff I shared. | 12:35 |
ganso | rraja: move to share.ShareManager._validate_access() | 12:35 |
rraja | ganso: OK. and use that validation in all the three microversioned share.ShareManager.access() functions? thanks! | 12:38 |
ganso | rraja: yes =) | 12:39 |
rraja | ganso: cool! and when do I need to get this patch merged by to make FF deadline? :( | 12:39 |
ganso | rraja: today | 12:40 |
rraja | ganso: ok. | 12:41 |
openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 12:41 |
*** gouthamr has joined #openstack-manila | 12:44 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/python-manilaclient: Revert usage of help text marking "admin only" CLIs https://review.openstack.org/287436 | 12:51 |
*** baojg has joined #openstack-manila | 12:52 | |
*** jasonsb has joined #openstack-manila | 12:54 | |
*** a_ta has joined #openstack-manila | 12:56 | |
*** porrua has joined #openstack-manila | 12:57 | |
*** jasonsb has quit IRC | 12:59 | |
*** a_ta has quit IRC | 13:00 | |
ganso | gouthamr: ping | 13:04 |
*** martyturner has joined #openstack-manila | 13:04 | |
gouthamr | ganso: hey! | 13:04 |
ganso | gouthamr: good morning Goutham | 13:04 |
gouthamr | ganso: Good morning! | 13:04 |
ganso | gouthamr: I am having a hard time understand what "action='single_alias'," is | 13:04 |
gouthamr | ganso: it is so that you can't provide the same option twice using the alias, for example 'manila share-replica-list --share-id "my_share" --share "my_share_2"' | 13:05 |
gouthamr | ganso: because --share-id and --share have been aliased to the same CLI arg.. | 13:06 |
gouthamr | ganso: as far as i tested :) | 13:06 |
ganso | gouthamr: oh great! thanks! | 13:06 |
csaba | bswartz, vponomaryov, ganso, toabctl : can you please review https://review.openstack.org/#/c/287632/ (project-config: Add jobs for Manila glusterfs, glusterfs-native drivers with Heketi layout)? I need a +1 from manila side to get the infra folks approve it. | 13:07 |
bswartz | csaba: read my comment | 13:09 |
*** amrith is now known as _amrith_ | 13:10 | |
*** timcl has joined #openstack-manila | 13:10 | |
bswartz | jcsp: https://review.openstack.org/#/c/274952/ | 13:11 |
bswartz | ^ this has to merge today | 13:11 |
ganso | gouthamr: I think there was some confusion around notify and force-host-copy default values | 13:11 |
bswartz | rraja ^ | 13:11 |
ganso | gouthamr: their default value is true | 13:11 |
ganso | gouthamr: so if you do not specify, they are true | 13:12 |
ganso | gouthamr: wouldn't the purpose of "store_true" be to use True only by specifying --notify when default is False? | 13:12 |
rraja | bswartz: yes. i'm on it/ | 13:13 |
gouthamr | ganso: you could be right.. because every place we use it is when the default option is different | 13:14 |
gouthamr | ganso: you're right. https://docs.python.org/2/library/optparse.html #TIL. thanks! | 13:18 |
ganso | gouthamr: =) | 13:25 |
*** JoseMello has joined #openstack-manila | 13:26 | |
*** akerr has joined #openstack-manila | 13:28 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 13:29 |
openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Fix update_access concurrency issue https://review.openstack.org/287758 | 13:32 |
*** shausy has quit IRC | 13:33 | |
*** akerr_ has joined #openstack-manila | 13:33 | |
openstackgerrit | Ramana Raja proposed openstack/python-manilaclient: Add 'cephx' authentication type https://review.openstack.org/274952 | 13:35 |
*** akerr has quit IRC | 13:36 | |
*** akerr_ is now known as akerr | 13:36 | |
*** xyang1 has joined #openstack-manila | 13:37 | |
*** adrianofr_ has quit IRC | 13:40 | |
rraja | ganso gouthamr : are you folks fine with this approach to micoversion on the client side to cephx auth type? please see https://review.openstack.org/#/c/274952/5/manilaclient/v2/shares.py | 13:40 |
ganso | rraja: reading it right now | 13:41 |
gouthamr | rraja: just commented.. i think the version check can be done inline in the _validate_access_types method | 13:42 |
gouthamr | rraja: if the url or the parameters (action name) changes, we can redefine the method; my 0.02 :) | 13:43 |
mkoderer___ | gouthamr: btw https://github.com/gondor/openstack4j/pull/587 | 13:48 |
gouthamr | oh awesome mkoderer___ ... we were just talking about this at NetApp this morning! | 13:48 |
gouthamr | mkoderer___: taking a look :) | 13:48 |
mkoderer___ | gouthamr: you need to thank dgonzalez :) | 13:49 |
gouthamr | yes thanks dgonzalez! | 13:49 |
*** yangyapeng has quit IRC | 13:50 | |
dgonzalez | gouthamr: you're welcome :) | 13:50 |
*** yangyapeng has joined #openstack-manila | 13:50 | |
*** adrianofr_ has joined #openstack-manila | 13:50 | |
*** baojg has quit IRC | 13:51 | |
dgonzalez | gouthamr: if you have any issues with it, don't hesitate to contact me. I'm glad to help :) | 13:55 |
gouthamr | dgonzalez: sure thing, i'll try using this on my devstack. I see you've based this off liberty? | 13:56 |
dgonzalez | gouthamr: yes, it's based on the official API documentation | 13:57 |
openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 13:57 |
*** EinstCrazy has joined #openstack-manila | 13:58 | |
gouthamr | dgonzalez: do you request a particular microversion? | 14:04 |
gouthamr | dgonzalez: do you allow* requesting a particular microversion? | 14:04 |
dgonzalez | gouthamr: no, not at the moment | 14:05 |
gouthamr | dgonzalez: is it hardcoded to anything, i'm not able to find it in the code.. | 14:06 |
dgonzalez | gouthamr: no it's not hardcoded either. I guess it should be possible to support this, but i have not looked into it yet | 14:07 |
gouthamr | dgonzalez: can go as an addition.. it would involve sending a header 'X-OpenStack-Manila-API-Version: x.y' with the requests.. | 14:10 |
gouthamr | dgonzalez: http://docs.openstack.org/developer/manila/devref/api_microversion_dev.html | 14:10 |
gouthamr | dgonzalez: if you don't send it, the server always responds with the minimum microversion it supports for that endpoint. which in our case is 2.0 for the /v2 endpoint that we introduced in liberty | 14:11 |
gouthamr | dgonzalez: i would be in favor of setting it to the release maximum.. (for liberty, it was 2.6) "X-Openstack-Manila-Api-Version: 2.6" | 14:12 |
dgonzalez | gouthamr: yeah i will look into this. I am currently looking if openstack4j supports nova microversions. If yes it should be easy to "copy" this over to manila | 14:12 |
gouthamr | dgonzalez: nice! thanks again for all your hard work :) | 14:13 |
openstackgerrit | Merged openstack/python-manilaclient: Annotate CLI commands for experimental features https://review.openstack.org/286706 | 14:16 |
*** alkhodos_ has joined #openstack-manila | 14:27 | |
*** cknight has joined #openstack-manila | 14:28 | |
*** eharney has quit IRC | 14:31 | |
*** erlon has joined #openstack-manila | 14:33 | |
csaba | bswartz: /me updated the project-config patch | 14:34 |
bswartz | csaba: I'm fine with this change, but I feat it comes too late | 14:36 |
bswartz | fear | 14:36 |
bswartz | we have to think in terms of this Heketi driver going into Newton | 14:37 |
bswartz | I don't see how we're going to get all the patches merged and see positive CI results | 14:37 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/python-manilaclient: Revert usage of help text marking "admin only" CLIs https://review.openstack.org/287436 | 14:38 |
*** absubram has joined #openstack-manila | 14:38 | |
*** akshai has joined #openstack-manila | 14:42 | |
rraja | gouthamr: if I follow your approach, how do I get the micro version of the request inside the allow method here https://review.openstack.org/#/c/274952/5/manilaclient/v2/shares.py? Is is just self.api_version? | 14:47 |
gouthamr | rraja: had a draft that i never finished. will comment on the patch in a minute. | 14:48 |
rraja | gouthamr: thanks! | 14:49 |
*** _amrith_ is now known as amrith | 14:49 | |
bswartz | ganso: you here? | 14:54 |
*** markstur has joined #openstack-manila | 14:55 | |
*** dustins has joined #openstack-manila | 14:55 | |
*** eharney has joined #openstack-manila | 14:55 | |
ganso | bswartz: pong | 14:55 |
ganso | bswartz: just got back from lunch | 14:56 |
*** aovchinnikov has joined #openstack-manila | 14:56 | |
bswartz | grrr -- I'm hungry! | 14:56 |
bswartz | I can't have lunch until after meeting :-( | 14:56 |
bswartz | ganso: you have merge conflict https://review.openstack.org/#/c/250518/ | 14:56 |
bswartz | let's get that fixed and workflowed | 14:57 |
ganso | bswartz: thanks, gonna rebase now | 14:57 |
ganso | bswartz: what's the difference between recheck and reverify? | 14:58 |
bswartz | ganso: there is no difference | 14:59 |
bswartz | ganso: the regex matches both strings | 15:00 |
rraja | gouthamr: my question was not how could I do the version comparison, rather how do I get hold of 'version' object that you use to compare the versions? | 15:01 |
bswartz | anyone know how to make tegile CI run? | 15:01 |
*** esker has quit IRC | 15:02 | |
*** a_ta has joined #openstack-manila | 15:02 | |
toabctl | bswartz: I guess abhi knows | 15:03 |
bswartz | I found it | 15:03 |
bswartz | the instructions are in the Tegile CI reporting message | 15:04 |
bswartz | "run tegile" | 15:04 |
*** Yogi1 has joined #openstack-manila | 15:04 | |
dustins | bswartz: Meeting? | 15:04 |
*** alkhodos_ has quit IRC | 15:07 | |
*** esker has joined #openstack-manila | 15:07 | |
*** EinstCrazy has quit IRC | 15:08 | |
*** yangyapeng has quit IRC | 15:08 | |
*** yangyapeng has joined #openstack-manila | 15:09 | |
*** kaisers_ has joined #openstack-manila | 15:14 | |
*** alyson_ has joined #openstack-manila | 15:16 | |
*** kaisers_92 has joined #openstack-manila | 15:19 | |
bswartz | vponomaryov: meeting? | 15:20 |
*** kaisers_ has quit IRC | 15:21 | |
*** a_ta has quit IRC | 15:23 | |
*** a_ta has joined #openstack-manila | 15:24 | |
*** jasonsb has joined #openstack-manila | 15:25 | |
*** kaisers_92 has quit IRC | 15:25 | |
*** a_ta has quit IRC | 15:28 | |
*** a_ta has joined #openstack-manila | 15:28 | |
*** mtanino has joined #openstack-manila | 15:29 | |
*** aovchinnikov has quit IRC | 15:45 | |
*** esker has quit IRC | 15:45 | |
*** esker has joined #openstack-manila | 15:55 | |
*** a_ta has quit IRC | 15:58 | |
*** esker has quit IRC | 15:58 | |
*** ayma has joined #openstack-manila | 15:59 | |
*** Yogi1 has quit IRC | 16:00 | |
*** a_ta has joined #openstack-manila | 16:00 | |
bswartz | ganso: looks like migration is headed for the gate pipeline | 16:02 |
ganso | bswartz: gotta be lucky twice | 16:04 |
ganso | bswartz: in a row | 16:04 |
gouthamr | ganso: https://bugs.launchpad.net/python-manilaclient/+bug/1552771 description modified. | 16:07 |
openstack | Launchpad bug 1552771 in python-manilaclient "Single alias action does not support non None default values " [Undecided,New] | 16:07 |
ganso | gouthamr: llama | 16:08 |
ganso | gouthamr: xD | 16:09 |
gouthamr | ganso: autocorrect. | 16:10 |
* gouthamr loves llamas, specially the spitting ones | 16:10 | |
*** Yogi1 has joined #openstack-manila | 16:12 | |
openstackgerrit | Tin Lam proposed openstack/manila: Moved CORS middleware configuration into oslo-config-generator https://review.openstack.org/287575 | 16:13 |
*** martyturner has quit IRC | 16:14 | |
*** markstur has quit IRC | 16:15 | |
*** nkrinner has quit IRC | 16:16 | |
*** esker has joined #openstack-manila | 16:16 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 16:19 |
*** Yogi1 has quit IRC | 16:24 | |
rraja | ganso: ping | 16:28 |
ganso | rraja: pong | 16:29 |
*** pgbridge has joined #openstack-manila | 16:32 | |
*** Yogi1 has joined #openstack-manila | 16:35 | |
*** timcl has quit IRC | 16:40 | |
rraja | gouthamr bswartz ganso cknight : the patch https://review.openstack.org/#/c/274952/, since the deadline is so short are you OK with merging patchset 3 of that patch that just does not microversion else nearly complete (one assert missing). the patchset 3 is much close to being merged | 16:42 |
rraja | gouthamr bswartz ganso cknight : https://review.openstack.org/#/c/274952/3 | 16:42 |
*** timcl has joined #openstack-manila | 16:44 | |
rraja | markstur_ xyang1 : ^^ | 16:47 |
xyang1 | rraja: hi | 16:51 |
rraja | xyang1: were you able to look at what I'd posted earlier? | 16:53 |
xyang1 | rraja: not yet | 16:54 |
*** esker has quit IRC | 16:58 | |
*** a_ta has quit IRC | 17:06 | |
bswartz | rraja: I don't understanding what you're asking | 17:07 |
bswartz | you want us to give you a pass on unit tests and you'll do them later? | 17:08 |
rraja | bswartz: nope! | 17:08 |
bswartz | what is the issue? is there one that's really tough or is there a large number of them missing? | 17:08 |
bswartz | oh, you want to go back in time to and older patch? | 17:09 |
bswartz | will that even work? | 17:09 |
rraja | bswartz: would you be OK with patchset 3 that is close to complete but just doesn't microversion (which is done in the server side anyway)? | 17:09 |
bswartz | I haven't reviewed this one so I don't know what the state of patchset 3 was | 17:09 |
rraja | bswartz: ganso was OK with the idea. can you please take a look at it? | 17:10 |
rraja | bswartz: there are a large number of unit tests that need to be reshuffled if I continue using the approach I use in my last patch set. | 17:10 |
bswartz | rraja: I'd rather do it right, even if a FFE is needed | 17:11 |
ganso | bswartz: rraja will not be able to finish in the estimated time he has given you during the meeting | 17:11 |
rraja | bswartz: https://review.openstack.org/#/c/274952/3 | 17:11 |
bswartz | can we just tag the client without rraja's patch and give him proper time to fix the tests? | 17:11 |
ganso | bswartz: +1, considering this is most likely a bug than a feature, it could be fixed in M4 | 17:12 |
bswartz | how bad would a user's experience be if he was trying to use the ceph driver without this patch at all? | 17:12 |
ganso | bswartz: I don't think this is necessary to work | 17:12 |
bswartz | compared to how bad would be if we went back to patchset 3 and merged that? | 17:12 |
openstackgerrit | Merged openstack/manila: Move Share Migration code to Data Service https://review.openstack.org/250515 | 17:13 |
ganso | bswartz: as far as I understand (please rraja correct me if I am wrong), without this patch: cephx user would send request to server without validation, server validates and responds back with error | 17:13 |
openstackgerrit | Merged openstack/manila: Add share driver for Tegile IntelliFlash Arrays https://review.openstack.org/278169 | 17:14 |
rraja | ganso: without basic validation, you can't allow access for a share created using the cephfs driver | 17:14 |
bswartz | :-D :-D :-D :-D :-D :-D :-D | 17:14 |
ganso | bswartz: with this patch: cephx would invoke command, client would validate and show response without having to send request on the server | 17:14 |
bswartz | manila M-3 is done! | 17:14 |
*** porrua has quit IRC | 17:14 | |
ganso | bswartz: yes! \o/ | 17:14 |
ganso | rraja: basic validation is done in the server | 17:14 |
ganso | rraja: doing the same validation in the client just prevents a request from being sent | 17:15 |
bswartz | rraja: I hear that if we don't merge your change at all, ceph is unusable in the M-3 milestone | 17:15 |
bswartz | but perhaps we could fix that by RC-1 | 17:15 |
bswartz | so what can do wrong if we merge patchset 3 | 17:15 |
bswartz | what can go* wrong | 17:15 |
rraja | bswartz: i think patchset 3 should be OK. | 17:16 |
ganso | bswartz: nevermind, my mistake, it is unusable | 17:16 |
rraja | ganso: Yes!!! thanks! | 17:16 |
ganso | bswartz: manilaclient has an "else" that will reject anything different than "ip", "user" and "cert" | 17:17 |
bswartz | what was there are patchset 4 and 5 then? | 17:17 |
rraja | ganso: exactly! | 17:17 |
bswartz | what was the feedback that required more work? | 17:17 |
ganso | bswartz: this change that adds an additional validation of "cephx" access type, in my point of view, should require a microversion adjustment for allow_access in manilaclient | 17:18 |
ganso | bswartz: so, PS 3 was basically almost done, and I asked for this change | 17:18 |
bswartz | microversions are a server thing though | 17:18 |
bswartz | either the server bumped the microversion or it didn't | 17:18 |
bswartz | the client should just use the correct one | 17:18 |
bswartz | sorry I don't have the background on this | 17:19 |
rraja | bswartz: :) | 17:19 |
ganso | bswartz: it is not a matter of the client being in the correct version | 17:19 |
rraja | bswartz: i too was quite confused with the need for microversioning in the client side. | 17:19 |
ganso | bswartz: but such change on PS 3 was introducing a validation that should not be performed on versions prior to 2.13 | 17:19 |
ganso | bswartz: so, if 2.13 is used in client, then it checks for cephx access type, if 2.12 is used, it should not perform such validation, cephx access type should not even exist in this version | 17:20 |
ganso | bswartz: so, I suggested adding such validation. | 17:21 |
rraja | ganso: can we treat that as a known bug for now? | 17:22 |
bswartz | the guys here are out to lunch | 17:22 |
bswartz | I want to understand how we've been handling similar situations elsewhere in the client | 17:22 |
bswartz | cfouts did a lot of the client work | 17:23 |
rraja | cFouts: ^^ | 17:23 |
bswartz | he's out to lunch rraja | 17:24 |
bswartz | I'll ask him when he's back | 17:24 |
bswartz | I guess I'm still confused why adding a microversion check blows up all the tests | 17:24 |
ganso | bswartz: so, one way or another, fixing the "else" clause of manilaclient can be seen as a bug-fixing, which I suppose we can fix in M.4 | 17:24 |
ganso | bswartz: or this could be seen as a blueprint that adds support... which rraja would need to create, the patch does not have a blueprint yet | 17:25 |
ganso | bswartz: it blows up because manilaclient had validation of access rules in the wrong place since API v1 | 17:26 |
* bswartz sighs | 17:26 | |
ganso | bswartz: so, in order to have this validation microversioned, it needs to be moved to the proper place, where unit tests are different, so they blow up | 17:26 |
rraja | ganso: i used cephfs-driver blueprint for the python-manila client patch. | 17:27 |
bswartz | okay let me get back to this in 1 second | 17:27 |
ganso | rraja: manilaclient changes require their own blueprint | 17:27 |
bswartz | ganso: you -1 your own patch? https://review.openstack.org/#/c/250518/ | 17:27 |
ganso | bswartz: I am fixing a bug | 17:27 |
ganso | bswartz: it is quick | 17:27 |
bswartz | how long until that goes back up? | 17:27 |
*** martyturner has joined #openstack-manila | 17:28 | |
bswartz | we have _no_ _time_ | 17:28 |
ganso | bswartz: less than 15 minutes | 17:28 |
bswartz | okay focus on that | 17:28 |
bswartz | I'm going to read through all the feedback on rraja's patch | 17:28 |
openstackgerrit | Merged openstack/python-manilaclient: Use 'example' instead of 'foo' or 'bar' in help outputs https://review.openstack.org/267383 | 17:28 |
bswartz | okay rraja | 17:29 |
*** JoseMello has quit IRC | 17:29 | |
bswartz | so if ganso withdraws his -1 for microversion stuff | 17:30 |
*** adrianofr_ has quit IRC | 17:30 | |
bswartz | can you put up a version of patchset 3 that addresses gouthamr's points? | 17:30 |
bswartz | and then we can review that? | 17:30 |
rraja | bswartz: sure! just a better assertion was needed. | 17:31 |
bswartz | okay please do that | 17:32 |
bswartz | we'll get ganso and gouthamr to review again | 17:32 |
bswartz | and another core | 17:32 |
ganso | bswartz: ok | 17:32 |
bswartz | ^ the cursed patch made it in after a rebase | 17:32 |
bswartz | last 2 things are ganso's and rraja's patches | 17:33 |
bswartz | so I'm waiting on you guys | 17:33 |
bswartz | before tagging | 17:33 |
bswartz | although I'm going to the server tag while I wait | 17:33 |
openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 17:43 |
ganso | bswartz: ^ | 17:43 |
bswartz | ack | 17:43 |
tpsilva | ganso: https://review.openstack.org/#/c/287758/ | 17:45 |
*** jasonsb has quit IRC | 17:47 | |
openstackgerrit | Ramana Raja proposed openstack/python-manilaclient: Add 'cephx' authentication type https://review.openstack.org/274952 | 17:47 |
bswartz | ganso: I see mention of task state here | 17:51 |
sghatty | bswartz, csaba: I was wondering if one of you could quickly take a look at https://review.openstack.org/#/c/287506/? This is a bug that exposes a private variable to public. The fix has been code reviewed by several folks and has one +2, and +1 verification from Jenkins. Missing another +2 and workflow. | 17:51 |
bswartz | ganso: I thought we had planned to remove task state? | 17:51 |
ganso | bswartz: not in Mitaka, we decided this in midcycle, we would remove this once we had a "jobs" table | 17:51 |
bswartz | kk | 17:53 |
cknight | sghatty: Your bugfix patch can merge in M.4, no? | 17:53 |
bswartz | cknight: I targetted that bug to rc1 | 17:53 |
cknight | bswartz: good | 17:54 |
*** a_ta has joined #openstack-manila | 17:54 | |
rraja | gouthamr: is there a check for valid protocol on the client side? | 17:55 |
gouthamr | rraja: apart from the one you added? | 17:56 |
sghatty | cknight, bswartz: M.4, and rc1? - do you know when those dates are? sorry. still trying to get familiar with the deadlines. | 17:56 |
gouthamr | rraja: don't understand the question.. | 17:56 |
bswartz | sghatty: RC-1 is targeted for 2 weeks from today | 17:56 |
bswartz | sghatty: M.4 isn't a real thing -- it's just the time period between feature freeze and release for Mitaka | 17:56 |
sghatty | bswartz, thanks for clarifying | 17:57 |
bswartz | sghatty: your bugfix could get merged today though, if everyone's okay with it | 17:57 |
sghatty | that would be wonderful.. it's been reviewed by quite a few folks. | 17:58 |
gouthamr | rraja: ? | 17:58 |
* ganso is wondering why Zuul is not running python-manilaclient patches | 17:59 | |
bswartz | ganso: .... it is? | 18:00 |
rraja | gouthamr: i meant protocol, not auth type. | 18:00 |
sghatty | so, question to the channel - any objections on merging https://review.openstack.org/#/c/287506/ today, as bswartz mentioned? | 18:00 |
rraja | gouthamr: NFS, CIFS, GlusterFS, HDFS, etc | 18:00 |
rraja | gouthamr: what I added was an auth type, cephx. | 18:00 |
cknight | sghatty: fine with me, but we won't hold up the tag for it | 18:00 |
ganso | bswartz: oh, something was wrong with my filter | 18:01 |
*** ayma has quit IRC | 18:01 | |
ganso | bswartz: previously I saw it running because of depends on, not it does not have depends-on anymore | 18:01 |
gouthamr | rraja: no such validation.. but there's some help text that seems to suggest that we only support NFS, CIFS, GlusterFS or HDFS | 18:01 |
gouthamr | rraja: look in manilaclient/v2/shell.py | 18:01 |
rraja | gouthamr: can I just add CephFS to it in this patch of mine? | 18:02 |
gouthamr | rraja: sure.. good point! | 18:02 |
sghatty | cknight, I understand. I think the fix is not risky. so, it wont come to holding up the tag. And it has been reviewed by quite a few folks. | 18:02 |
bswartz | rraja: https://review.openstack.org/#/c/274952 | 18:11 |
bswartz | I want to see the bug in LP before we merge this | 18:12 |
bswartz | so we don't lose track of the microversion issue | 18:12 |
gouthamr | rraja: you could add the help text in your bugfix too | 18:12 |
openstackgerrit | Ramana Raja proposed openstack/python-manilaclient: Add 'cephx' authentication type https://review.openstack.org/274952 | 18:15 |
openstackgerrit | Ben Swartzlander proposed openstack/manila: Remove nsenter dependency https://review.openstack.org/287316 | 18:19 |
*** mtanino__ has quit IRC | 18:22 | |
*** dencaval has quit IRC | 18:25 | |
*** Yogi1 has quit IRC | 18:26 | |
*** lpetrut has quit IRC | 18:29 | |
ganso | bswartz: forgot admin tags in manilaclient | 18:29 |
ganso | bswartz: have to re-add them | 18:29 |
bswartz | ganso: I noticed that | 18:30 |
bswartz | thanks -- it's good for consistency while we wait for better solution | 18:30 |
openstackgerrit | Ramana Raja proposed openstack/python-manilaclient: Add 'cephx' authentication type https://review.openstack.org/274952 | 18:30 |
*** Yogi1 has joined #openstack-manila | 18:31 | |
*** ayma has joined #openstack-manila | 18:31 | |
*** a_ta has quit IRC | 18:32 | |
*** a_ta has joined #openstack-manila | 18:33 | |
* gouthamr caused all those extra patchsets for ganso 8) | 18:33 | |
*** a_ta has quit IRC | 18:37 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 18:40 |
*** dencaval has joined #openstack-manila | 18:41 | |
ganso | gouthamr: no problem =) | 18:41 |
rraja | bswartz: filed the bug. it's here, https://bugs.launchpad.net/python-manilaclient/+bug/1552848 | 18:42 |
openstack | Launchpad bug 1552848 in python-manilaclient "cephx auth type not microversioned in API v2" [High,New] - Assigned to Ramana Raja (rraja) | 18:42 |
bswartz | ganso: pep8 fail | 18:51 |
ganso | bswartz: I should have run tox instead of run_tests.sh :\ | 18:53 |
ganso | bswartz: thanks for the heads up | 18:53 |
openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 18:53 |
dustins | Hey all, I'm looking to add a column to the Feature Support Mapping page in the docs for thin provisioning | 18:55 |
dustins | I was going to just leave the boxes blank and let everyone fill it in at their leisure, but I figured while I was here I could just fill them in for everyone | 18:56 |
dustins | If folks want to tell me whether their drivers support thin provisioning or not, I'll add it to the table! | 18:57 |
bswartz | rraja: you failed unit tests | 19:03 |
*** ociuhandu has quit IRC | 19:09 | |
rraja | bswartz: I checked. :( i skipped testing one that actually tests for content of a helper string. | 19:11 |
rraja | bswartz: s/I checked/I checked the zuul console/ | 19:12 |
*** a_ta has joined #openstack-manila | 19:23 | |
gouthamr | rraja: please remove that unit test | 19:26 |
gouthamr | rraja: it has no value.. | 19:26 |
gouthamr | rraja: please include a note in your commit message about why you're removing the unit test. I would suggest "We should not be asserting the contents of help text, so remove unit test that currently does so" .. :) | 19:28 |
*** amrith is now known as _amrith_ | 19:30 | |
markstur_ | dustins, yes to thin for 3par. Thanks. | 19:31 |
dustins | markstur_: you got it! | 19:31 |
gouthamr | rraja: feel free to also just remove the protocols from it, if you think that's wiser. either case seems fine. | 19:32 |
* markstur_ wonders what else dustins might document for markstur | 19:33 | |
openstackgerrit | Ramana Raja proposed openstack/python-manilaclient: Add 'cephx' authentication type https://review.openstack.org/274952 | 19:33 |
rraja | gouthamr: i'm removing that unit test. | 19:34 |
dustins | markstur_: Just call me Dustin the Docs Dude | 19:34 |
dustins | :P | 19:34 |
gouthamr | rraja: +1 | 19:34 |
rraja | gouthamr: i hope that's OK | 19:34 |
markstur_ | dustins, I will not | 19:34 |
gouthamr | rraja: thanks! | 19:34 |
dustins | hahaha | 19:35 |
gouthamr | that actually is cool, dustins, 3D for short. | 19:36 |
* dustins curses the alliteration he used | 19:37 | |
dustins | markstur_: you're set for that, I'll push up what I have upstream at the end of the day today | 19:38 |
*** lpetrut has joined #openstack-manila | 19:43 | |
*** _amrith_ is now known as amrith | 19:45 | |
ganso | bswartz, xyang1, markstur_, cknight, toabctl: https://review.openstack.org/#/c/250518/ | 19:48 |
tpsilva | ganso: please see my comments on https://review.openstack.org/#/c/287758. Thank you! | 19:54 |
*** fthiagogv has joined #openstack-manila | 20:01 | |
*** porrua has joined #openstack-manila | 20:05 | |
*** Yogi1 has quit IRC | 20:06 | |
ganso | tpsilva: please see my reply | 20:13 |
*** rraja has quit IRC | 20:19 | |
*** eharney has quit IRC | 20:19 | |
tpsilva | ganso: thank you! will make the change on the exception and file another bug, since it is out of the scope of this patch | 20:22 |
tpsilva | ganso: I'll work on that as well | 20:22 |
ganso | tpsilva: thanks! =) | 20:23 |
tpsilva | ganso: and please stay away from irc and gerrit on your time off :) | 20:23 |
ganso | tpsilva: will try =P | 20:23 |
bswartz | ganso: jenkins +1 rraja's change | 20:24 |
bswartz | 1 minute after your comment | 20:24 |
ganso | bswartz: it's time | 20:24 |
bswartz | need workflow now | 20:24 |
bswartz | markstur ^ | 20:25 |
bswartz | https://review.openstack.org/#/c/274952/ | 20:25 |
bswartz | markstur_ ^ | 20:25 |
*** Yogi1 has joined #openstack-manila | 20:26 | |
bswartz | cknight: ty | 20:26 |
bswartz | no more rechecks today pls | 20:27 |
* bswartz knocks on wood | 20:27 | |
openstackgerrit | Merged openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 20:34 |
ganso | ^ \o/ | 20:34 |
cknight | :-) | 20:34 |
*** esker has joined #openstack-manila | 20:54 | |
openstackgerrit | Merged openstack/python-manilaclient: Add 'cephx' authentication type https://review.openstack.org/274952 | 21:04 |
*** timcl has quit IRC | 21:04 | |
ganso | ^ \o/ | 21:05 |
ganso | bswartz: ^ | 21:05 |
bswartz | yes I saw | 21:05 |
bswartz | tagging now | 21:05 |
ganso | bswartz: =D | 21:05 |
*** amrith is now known as _amrith_ | 21:07 | |
bswartz | thanks everyone for making Mitaka-3 successful | 21:08 |
bswartz | now is a good time to take a rest | 21:09 |
gouthamr | 8) | 21:09 |
gouthamr | sure. | 21:09 |
bswartz | but make it a short rest because RC1 is just 2 weeks away | 21:09 |
openstackgerrit | Ben Swartzlander proposed openstack/manila: Remove nsenter dependency https://review.openstack.org/287316 | 21:10 |
ganso | =) | 21:11 |
*** Yogi1 has quit IRC | 21:13 | |
*** esker has quit IRC | 21:17 | |
*** fthiagogv_ has joined #openstack-manila | 21:18 | |
*** fthiagogv has quit IRC | 21:21 | |
*** cknight has quit IRC | 21:34 | |
*** fthiagogv_ has quit IRC | 21:36 | |
*** alyson_ has quit IRC | 22:02 | |
*** akerr has quit IRC | 22:07 | |
*** ayma has quit IRC | 22:07 | |
*** lpetrut has quit IRC | 22:11 | |
*** ociuhandu has joined #openstack-manila | 22:14 | |
*** _amrith_ is now known as amrith | 22:27 | |
*** tpsilva has quit IRC | 22:37 | |
*** absubram has quit IRC | 22:41 | |
*** martyturner has quit IRC | 22:45 | |
*** porrua has quit IRC | 22:48 | |
*** akerr has joined #openstack-manila | 23:02 | |
*** a_ta has quit IRC | 23:03 | |
*** a_ta has joined #openstack-manila | 23:04 | |
*** dustins has quit IRC | 23:05 | |
*** akerr_ has joined #openstack-manila | 23:05 | |
*** xyang1 has quit IRC | 23:06 | |
*** xyang1 has joined #openstack-manila | 23:07 | |
*** marcusvrn_ has quit IRC | 23:07 | |
*** akerr has quit IRC | 23:09 | |
*** a_ta has quit IRC | 23:09 | |
*** xyang1 has quit IRC | 23:09 | |
*** akerr_ has quit IRC | 23:16 | |
*** ganso has quit IRC | 23:19 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!