| *** yangyape_ has quit IRC | 00:03 | |
| *** lpetrut has quit IRC | 00:28 | |
| *** mtanino has quit IRC | 00:29 | |
| openstackgerrit | Alex Meade proposed openstack/manila: NetApp cDOT: Handle replicated snapshots https://review.openstack.org/293243 | 00:29 |
|---|---|---|
| openstackgerrit | Alex Meade proposed openstack/manila: Data Replication: Ensure Snapshots across replicas https://review.openstack.org/292659 | 00:29 |
| *** lpetrut has joined #openstack-manila | 00:31 | |
| *** merooney has quit IRC | 01:00 | |
| *** yangyapeng has joined #openstack-manila | 01:12 | |
| *** merooney has joined #openstack-manila | 01:12 | |
| *** ganso has quit IRC | 01:19 | |
| *** ociuhandu has quit IRC | 01:25 | |
| *** ociuhandu has joined #openstack-manila | 01:26 | |
| *** yangyapeng has quit IRC | 01:27 | |
| *** yangyapeng has joined #openstack-manila | 01:28 | |
| openstackgerrit | daiki kato proposed openstack/manila-image-elements: Fix typos https://review.openstack.org/294357 | 01:32 |
| *** yangyapeng has quit IRC | 01:34 | |
| *** yangyapeng has joined #openstack-manila | 01:35 | |
| *** scottda_vacation has quit IRC | 01:45 | |
| *** yangyape_ has joined #openstack-manila | 01:49 | |
| *** yangyapeng has quit IRC | 01:53 | |
| *** lpetrut has quit IRC | 01:54 | |
| *** baojg has joined #openstack-manila | 01:54 | |
| *** a_ta has joined #openstack-manila | 01:56 | |
| *** a_ta has quit IRC | 02:00 | |
| *** csaba has quit IRC | 02:15 | |
| *** csaba has joined #openstack-manila | 02:16 | |
| *** houming has joined #openstack-manila | 02:21 | |
| *** yangyape_ has quit IRC | 02:46 | |
| *** yangyapeng has joined #openstack-manila | 02:47 | |
| *** a_ta has joined #openstack-manila | 02:47 | |
| *** a_ta has quit IRC | 02:52 | |
| *** cknight has joined #openstack-manila | 02:55 | |
| openstackgerrit | daiki kato proposed openstack/puppet-manila: Fix typos https://review.openstack.org/294375 | 03:00 |
| *** ociuhandu has quit IRC | 03:17 | |
| *** ociuhandu has joined #openstack-manila | 03:21 | |
| *** houming has quit IRC | 03:24 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: NetApp cDOT: Fix status updates for replicas https://review.openstack.org/291803 | 03:24 |
| *** houming has joined #openstack-manila | 03:25 | |
| *** houming has quit IRC | 03:28 | |
| *** houming has joined #openstack-manila | 03:50 | |
| *** houming has quit IRC | 04:07 | |
| *** sgotliv has joined #openstack-manila | 04:14 | |
| *** merooney has quit IRC | 04:23 | |
| *** baojg has quit IRC | 04:28 | |
| *** cknight has quit IRC | 04:28 | |
| *** shausy has joined #openstack-manila | 04:30 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: NetApp cDOT: Handle replicated snapshots https://review.openstack.org/293243 | 04:31 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Data Replication: Ensure Snapshots across replicas https://review.openstack.org/292659 | 04:31 |
| *** merooney has joined #openstack-manila | 04:37 | |
| *** baojg has joined #openstack-manila | 04:40 | |
| *** merooney has quit IRC | 04:42 | |
| *** a_ta has joined #openstack-manila | 04:53 | |
| *** a_ta has quit IRC | 04:58 | |
| *** bswartz has quit IRC | 05:02 | |
| *** houming has joined #openstack-manila | 05:03 | |
| *** markstur_ has joined #openstack-manila | 05:08 | |
| *** markstur_ has left #openstack-manila | 05:09 | |
| *** rhagarty has quit IRC | 05:13 | |
| *** rhagarty has joined #openstack-manila | 05:13 | |
| *** bswartz has joined #openstack-manila | 05:29 | |
| *** bswartz has quit IRC | 05:46 | |
| *** pcaruana has quit IRC | 06:18 | |
| *** nkrinner has joined #openstack-manila | 06:19 | |
| openstackgerrit | Merged openstack/manila: Revert "LXC/LXD driver" https://review.openstack.org/293523 | 06:32 |
| *** baojg has quit IRC | 06:55 | |
| *** baojg has joined #openstack-manila | 07:14 | |
| *** baojg has quit IRC | 07:25 | |
| *** pcaruana has joined #openstack-manila | 07:57 | |
| *** aovchinnikov has joined #openstack-manila | 08:21 | |
| *** gregsfortytwo has quit IRC | 08:34 | |
| *** gregsfortytwo has joined #openstack-manila | 08:34 | |
| *** a_ta has joined #openstack-manila | 08:55 | |
| *** yangyape_ has joined #openstack-manila | 08:55 | |
| *** yangyapeng has quit IRC | 08:58 | |
| *** a_ta has quit IRC | 08:59 | |
| openstackgerrit | Merged openstack/puppet-manila: releasenotes: add notes for Mitaka cycle https://review.openstack.org/294259 | 09:18 |
| *** yangyape_ has quit IRC | 09:26 | |
| *** yangyapeng has joined #openstack-manila | 09:26 | |
| *** merooney has joined #openstack-manila | 09:40 | |
| *** merooney has quit IRC | 09:45 | |
| *** lpetrut has joined #openstack-manila | 09:53 | |
| *** baojg has joined #openstack-manila | 09:53 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Fix for incorrect LVMMixin exception message https://review.openstack.org/294481 | 09:59 |
| *** ociuhandu has quit IRC | 10:04 | |
| *** tpsilva has joined #openstack-manila | 10:06 | |
| *** lpetrut has quit IRC | 10:25 | |
| *** yangyapeng has quit IRC | 10:36 | |
| *** lpetrut has joined #openstack-manila | 10:38 | |
| *** merooney has joined #openstack-manila | 10:41 | |
| *** sgotliv has quit IRC | 10:41 | |
| *** lpetrut has quit IRC | 10:43 | |
| *** merooney has quit IRC | 10:46 | |
| *** lpetrut has joined #openstack-manila | 10:57 | |
| *** baojg has quit IRC | 10:58 | |
| *** ganso has joined #openstack-manila | 11:00 | |
| *** mlima has joined #openstack-manila | 11:00 | |
| *** ociuhandu has joined #openstack-manila | 11:00 | |
| *** lpetrut has quit IRC | 11:06 | |
| *** juzuluag has joined #openstack-manila | 11:27 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Make ZFSonLinux driver handle snapshots of replicated shares properly https://review.openstack.org/293377 | 11:41 |
| *** lpetrut has joined #openstack-manila | 11:53 | |
| *** a_ta has joined #openstack-manila | 11:53 | |
| *** yangyapeng has joined #openstack-manila | 11:57 | |
| *** a_ta has quit IRC | 11:58 | |
| *** mlima_ has joined #openstack-manila | 12:01 | |
| *** mlima has quit IRC | 12:04 | |
| *** rraja has joined #openstack-manila | 12:10 | |
| *** rraja has quit IRC | 12:10 | |
| *** jcsp has quit IRC | 12:10 | |
| *** cknight has joined #openstack-manila | 12:27 | |
| *** bswartz has joined #openstack-manila | 12:31 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix manage API ignoring type extra specs https://review.openstack.org/294269 | 12:39 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Make ZFSonLinux driver handle snapshots of replicated shares properly https://review.openstack.org/293377 | 12:41 |
| tpsilva | cknight: ping | 12:41 |
| cknight | tpsilva: pong | 12:41 |
| tpsilva | cknight: Good morning Clinton | 12:41 |
| tpsilva | cknight: regarding this https://review.openstack.org/#/c/287758/15/manila/share/api.py@1136 | 12:42 |
| tpsilva | cknight: by ignoring requests with status active in manager, wouldn't it possibly drop some unprocessed rules? | 12:43 |
| cknight | tpsilva: Good morning Tiago. I wasn't certain when I wrote that, but how else could you get a new rule in the manager with the state active? | 12:44 |
| cknight | tpsilva: The state should be out-of-sync when a new rule arrives, unless you had already handled it. | 12:45 |
| *** timcl has joined #openstack-manila | 12:46 | |
| tpsilva | cknight: that's true, unless there's a problem somewhere else | 12:46 |
| tpsilva | which I really hope it doesn't | 12:46 |
| tpsilva | cknight: well, I'll make this change then and I'll upload a new patch soon | 12:46 |
| cknight | tpsilva: OK, but I suggest you get a second opinion from Ben or Rodrigo, in case one of them can see a flaw in the logic. | 12:47 |
| tpsilva | cknight: comparing the rules would be great, but we don't have a way of getting the rules set on the backend | 12:47 |
| cknight | tpsilva: Yeah, I figured that. | 12:47 |
| cknight | tpsilva: And FWIW, the race (which leads to an extra rule at the manager) doesn't affect my driver, since I always replace all the rules. But others would be affected. | 12:48 |
| *** openstackgerrit has quit IRC | 12:48 | |
| *** openstackgerrit has joined #openstack-manila | 12:49 | |
| tpsilva | cknight: yep, my driver works the same way | 12:49 |
| *** xyang1 has joined #openstack-manila | 12:49 | |
| ganso | cknight, tpsilva: it is worth to note that when the recursive call is triggered, it is always recovery mode. For drivers that implement add_rules and delete_rules, it will be less efficient. And for drivers that do not implement update_access, they will run in fallback mode, which we have not tested | 12:50 |
| *** houming has quit IRC | 12:53 | |
| *** alejandrito has joined #openstack-manila | 12:56 | |
| *** cknight has quit IRC | 12:59 | |
| *** shausy has quit IRC | 13:08 | |
| *** akshai has joined #openstack-manila | 13:22 | |
| *** sgotliv has joined #openstack-manila | 13:24 | |
| *** cknight has joined #openstack-manila | 13:25 | |
| *** sgotliv has quit IRC | 13:31 | |
| openstackgerrit | Marc Koderer proposed openstack/manila: Fix keystone v3 issues for all clients https://review.openstack.org/290511 | 13:38 |
| openstackgerrit | Marc Koderer proposed openstack/manila: Fix keystone v3 issues for all clients https://review.openstack.org/290511 | 13:40 |
| openstackgerrit | Marc Koderer proposed openstack/manila: Fix keystone v3 issues for all clients https://review.openstack.org/290511 | 13:42 |
| *** cknight has quit IRC | 13:54 | |
| *** a_ta has joined #openstack-manila | 13:56 | |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Fix update_access concurrency issue https://review.openstack.org/287758 | 13:57 |
| *** esker has joined #openstack-manila | 13:58 | |
| *** eharney has joined #openstack-manila | 13:58 | |
| bswartz | mkoderer__ mkoderer: 3 patches in 5 minutes? | 14:00 |
| vponomaryov | bswartz: he has patch-gun )) | 14:03 |
| bswartz | aovchinnikov: I was assuming you'd just create a branch on an existing repo | 14:05 |
| bswartz | aovchinnikov: but I mirrored your repo as a branch on my tree: | 14:05 |
| bswartz | https://github.com/bswartz/manila/tree/lxdbackup | 14:05 |
| *** ociuhandu has quit IRC | 14:05 | |
| aovchinnikov | bswartz: oh, ok, my bad. should I remove mine or it won't produce too much confusion? | 14:07 |
| *** erlon has joined #openstack-manila | 14:07 | |
| *** martyturner has joined #openstack-manila | 14:11 | |
| openstackgerrit | Merged openstack/manila: NetApp cDOT: Fix status updates for replicas https://review.openstack.org/291803 | 14:11 |
| bswartz | it doesn't matter much | 14:12 |
| *** nkrinner has quit IRC | 14:12 | |
| aovchinnikov | ok | 14:12 |
| bswartz | just pointing you that you could have forked manila and put it in a side branch on your repo | 14:12 |
| *** cknight has joined #openstack-manila | 14:13 | |
| *** aovchinnikov has quit IRC | 14:15 | |
| *** ChanServ changes topic to "9 bugs left until RC1" | 14:19 | |
| openstackgerrit | Alex Meade proposed openstack/manila: NetApp cDOT: Handle replicated snapshots https://review.openstack.org/293243 | 14:23 |
| openstackgerrit | Alex Meade proposed openstack/manila: Data Replication: Ensure Snapshots across replicas https://review.openstack.org/292659 | 14:23 |
| *** akerr has joined #openstack-manila | 14:31 | |
| *** baojg has joined #openstack-manila | 14:33 | |
| *** baojg has quit IRC | 14:35 | |
| *** akerr has quit IRC | 14:36 | |
| *** pcaruana has quit IRC | 14:38 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Make ZFSonLinux driver handle snapshots of replicated shares properly https://review.openstack.org/293377 | 14:44 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG] Replicated snapshot tests debug https://review.openstack.org/294626 | 14:48 |
| esker | Hello, Manila community! | 14:49 |
| esker | Please consider taking 10 seconds to respond to this highly critical poll asking about what you prefer in the way of a Manila project logo: | 14:49 |
| esker | https://www.surveymonkey.com/r/J8266ZH | 14:49 |
| esker | Again... highly critical ;-) | 14:50 |
| esker | Winner will get submitted to the project subject to the same review process as anything else... | 14:50 |
| bswartz | nice | 14:50 |
| bswartz | this deserves a twitter post | 14:50 |
| esker | Tweet away, please! | 14:50 |
| esker | Was just about to contact you asking you to circulate whether appropriate. | 14:51 |
| bswartz | ganso: why does this have APIImpact? https://review.openstack.org/#/c/294269/ | 15:03 |
| *** gouthamr has joined #openstack-manila | 15:05 | |
| *** mtanino has joined #openstack-manila | 15:10 | |
| ganso | bswartz: because it changes a certain API behavior, before on such error, it would return 202 and the share would have "managing_error" status... now it returns 409 right away | 15:11 |
| gouthamr | ganso: +1 | 15:24 |
| mkoderer___ | esker: great! | 15:26 |
| esker | mkoderer___: perhaps a humorous interlude whilst in the throes of RC1 activities (if that applies)... ;-) | 15:27 |
| bswartz | ganso: but there's no microversion | 15:29 |
| bswartz | we don't want a microversion because we're fixing behavior in all versions | 15:29 |
| bswartz | I guess I'm trying to understand what APIImpact really means | 15:30 |
| *** martyturner has quit IRC | 15:30 | |
| *** baojg has joined #openstack-manila | 15:30 | |
| *** timcl1 has joined #openstack-manila | 15:31 | |
| openstackgerrit | Yogesh proposed openstack/manila: Add tests to ensure snapshots across replicas https://review.openstack.org/293113 | 15:31 |
| *** martyturner has joined #openstack-manila | 15:31 | |
| *** david-lyle has quit IRC | 15:32 | |
| *** david-lyle has joined #openstack-manila | 15:33 | |
| *** timcl has quit IRC | 15:33 | |
| gouthamr | bswartz: APIImpact is a flag to get reviewer attention on APIImpact.. not all APIImpacts lead to microversion changes.. | 15:34 |
| mkoderer___ | esker: voted. great work | 15:36 |
| bswartz | if it was only meant for reviewers it should go in the gerrit comments | 15:36 |
| bswartz | commit messages are stored forever | 15:36 |
| vponomaryov | toabctl: ping | 15:36 |
| mkoderer___ | bswartz: https://review.openstack.org/#/c/290511/ after a +1 of jamie it's ready for merge | 15:36 |
| mkoderer___ | bswartz: when is the finial deadline to get it in RC1 ? | 15:36 |
| bswartz | mkoderer___: today | 15:37 |
| vponomaryov | toabctl: is it correct to say that this -> https://review.openstack.org/#/c/289382/5 still does not work on py3? | 15:37 |
| vponomaryov | toabctl: tests you fixed are skipped | 15:37 |
| mkoderer___ | bswartz: your timezone? | 15:38 |
| bswartz | mkoderer___: what's left to be done? why would a few hours make a difference? | 15:39 |
| gouthamr | bswartz: that's one argument.. but we use a number of flags in openstack.. DocImpact, APIImpact and the likes. | 15:39 |
| mkoderer___ | bswartz: as cknight stated.. we might wait for jamies review | 15:39 |
| mkoderer___ | not sure which time zone he's in | 15:39 |
| *** rraja has joined #openstack-manila | 15:40 | |
| bswartz | I'll give him a few hours to take a look but I won't wait | 15:40 |
| mkoderer___ | bswartz: ok fine up to you | 15:41 |
| cknight | tpsilva: I'm happy with your code. It seems to work with multiple clients doing multiple rapid adds & deletes. Just going to check the unit test coverage now. | 15:41 |
| tpsilva | cknight: great! the coverage is not good enough. I plan on bumping it after lunch... | 15:43 |
| *** ociuhandu has joined #openstack-manila | 15:43 | |
| *** baojg has quit IRC | 15:43 | |
| vponomaryov | mkoderer___, bswartz: based on time of his reviews, he is on west coast | 15:43 |
| *** Yogi1 has joined #openstack-manila | 15:44 | |
| vponomaryov | mkoderer___, bswartz: in best case it is about 6 hours to wait | 15:44 |
| bswartz | tpsilva: you have -1 from jenkins | 15:44 |
| mkoderer___ | vponomaryov: I ping him and we'll see.. but I have a good feeling with the current state | 15:44 |
| tpsilva | bswartz: yeah, I saw that... weird that I cannot run this test on my environment | 15:45 |
| bswartz | tpsilva: failed this unit test: manila.tests.share.test_manager.ShareManagerTestCase.test_delete_share_instance_not_found_2_delete_share | 15:45 |
| tpsilva | bswartz: but I'll fix that as well | 15:45 |
| cknight | tpsilva: I look forward to seeing how you unit test your recursive method. | 15:46 |
| cknight | tpsilva: It's not difficult, but you'll definitely want to ensure it's working in a test. | 15:46 |
| openstackgerrit | Alex Meade proposed openstack/manila: NetApp cDOT: Handle replicated snapshots https://review.openstack.org/293243 | 15:58 |
| *** david-lyle has quit IRC | 16:00 | |
| *** david-lyle has joined #openstack-manila | 16:01 | |
| *** martyturner has quit IRC | 16:03 | |
| ganso | vponomaryov, cknight, bswartz, xyang1, markstur: Could you please take a quick look https://review.openstack.org/#/c/294575/ ? | 16:04 |
| bswartz | now isn't a good time to deal with liberty stuff | 16:04 |
| bswartz | liberty can wait until next week | 16:04 |
| bswartz | it's already noon here and we still have 9 bugs | 16:05 |
| *** martyturner has joined #openstack-manila | 16:07 | |
| *** timcl has joined #openstack-manila | 16:07 | |
| *** mkoderer___ is now known as mkoderer__ | 16:08 | |
| bswartz | if we can get some eyes on https://review.openstack.org/#/c/289441 it looks pretty simpl | 16:09 |
| bswartz | it's gotten unlucky with jenkins timeouts | 16:09 |
| markstur | bswartz, There's an awful lot of red in those Jenkins results | 16:10 |
| bswartz | they're all timing out | 16:10 |
| *** timcl1 has quit IRC | 16:10 | |
| bswartz | might have been unlucky and chosen a slow node | 16:10 |
| bswartz | if something in the patch is actually making things slower than we won't merge i | 16:11 |
| bswartz | it | 16:11 |
| bswartz | but the code doesn't look bad | 16:11 |
| bswartz | it just adds a lock | 16:11 |
| *** a_ta has quit IRC | 16:11 | |
| *** a_ta has joined #openstack-manila | 16:12 | |
| markstur | bswartz, gate-manila-tempest-minimal-dsvm-lvm FAILURE in 1h 06m 16s | 16:14 |
| markstur | bswartz, I'm not convinced one way or the other, but it smells like this patch might be causing the timeouts | 16:14 |
| bswartz | indeed... | 16:15 |
| markstur | bswartz, 9 more "Oops" and we're done. | 16:15 |
| bswartz | okay I'm looking at logs more closely | 16:15 |
| bswartz | rofl | 16:15 |
| bswartz | I honestly don't know how gerrit flipped which patch I was reviewing | 16:16 |
| bswartz | was supposed to be https://review.openstack.org/#/c/294269/ | 16:16 |
| *** rraja has quit IRC | 16:16 | |
| *** a_ta has quit IRC | 16:16 | |
| * bswartz might have too many firefox windows open at the same time... | 16:16 | |
| bswartz | markstur: if we see another timeout I'll throw that bug out | 16:17 |
| bswartz | it was only medium | 16:17 |
| markstur | bswartz, Yeah. I'm still not sure, but today would be a bad day to push something that locks us up. | 16:18 |
| markstur | bswartz, It could easily be a CI issue (bad luck), but usually we don't see all those jobs timeout. It is usually just an unlucky few. | 16:19 |
| *** timcl has quit IRC | 16:22 | |
| *** vbellur has quit IRC | 16:25 | |
| *** sgotliv has joined #openstack-manila | 16:26 | |
| *** ociuhandu has quit IRC | 16:26 | |
| bswartz | vponomaryov: are there any remaining things left in the ZFS patch? | 16:32 |
| bswartz | I saw you pushed a debug patch to test it | 16:32 |
| vponomaryov | bswartz: couple of tempest tests fail on it | 16:32 |
| vponomaryov | bswartz: locally too | 16:32 |
| vponomaryov | bswartz: but using only tempest | 16:32 |
| vponomaryov | bswartz: looks like concurrency | 16:32 |
| bswartz | existing merged tests? or proposed tests? | 16:32 |
| vponomaryov | bswartz: and since NetApp does not face such problem, I suspect NetApp Ci works slower | 16:33 |
| vponomaryov | bswartz: proposed | 16:33 |
| bswartz | your debug patch doesn't Depends-On the proposed tests though | 16:33 |
| vponomaryov | bswartz: it does | 16:34 |
| bswartz | https://review.openstack.org/#/c/294626/ this one? | 16:38 |
| bswartz | I see 3 depends -- the core change and the 2 driver changes | 16:38 |
| bswartz | oh it has an unmerged parent | 16:38 |
| bswartz | okay nevermind | 16:38 |
| *** ociuhandu has joined #openstack-manila | 16:42 | |
| mkoderer__ | bswartz: I will finish for today.. pls merge https://review.openstack.org/#/c/290511/ if possible :) | 16:43 |
| *** timcl has joined #openstack-manila | 16:44 | |
| *** pcaruana has joined #openstack-manila | 16:47 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-manila: CI test - never merge https://review.openstack.org/294712 | 16:49 |
| vponomaryov | ganso: ping | 16:51 |
| ganso | vponomaryov: pong | 16:51 |
| vponomaryov | ganso: about https://review.openstack.org/#/c/294269/ | 16:51 |
| vponomaryov | ganso: scheduler should not be involved | 16:51 |
| vponomaryov | ganso: it is used only for scheduling craetion of shares | 16:51 |
| ganso | vponomaryov: migration uses it to validate as well | 16:51 |
| ganso | vponomaryov: why? | 16:51 |
| vponomaryov | ganso: why do oyu need scheduler? | 16:52 |
| vponomaryov | ganso: API can do it easily | 16:52 |
| ganso | vponomaryov: to run filters | 16:52 |
| ganso | vponomaryov: not easily. For capabilities that are lists, and can accept True and False, it is not so easy | 16:52 |
| ganso | vponomaryov: scheduler already does this | 16:52 |
| ganso | vponomaryov: yesterday someone said Cinder does the same, uses scheduler to validate | 16:53 |
| *** martyturner has quit IRC | 16:55 | |
| *** martyturner has joined #openstack-manila | 16:59 | |
| vponomaryov | bswartz: do you know that replication tests do not run in NetApp CI at all? | 17:00 |
| vponomaryov | bswartz: I am talking about all replication tests in Tempest | 17:00 |
| *** timcl1 has joined #openstack-manila | 17:00 | |
| vponomaryov | bswartz: NetApp driver replication feature is not tested in OpenStack CI | 17:00 |
| vponomaryov | Yogi1, akerr, gouthamr: ^ | 17:02 |
| *** timcl has quit IRC | 17:02 | |
| gouthamr | vponomaryov: no multibackend tests run on the netapp CI as of today | 17:02 |
| gouthamr | vponomaryov: we're working on reporting these tests soon. | 17:03 |
| vponomaryov | gouthamr: O.O | 17:03 |
| *** timcl1 has quit IRC | 17:04 | |
| gouthamr | vponomaryov: we're enhancing our CI to support migration tests, replication tests, multi AZ tests and multi node tests.. we should start reporting some/all of these very soon. they're currently being worked on. | 17:05 |
| *** mlima_ is now known as mlima | 17:05 | |
| *** timcl has joined #openstack-manila | 17:06 | |
| *** a_ta has joined #openstack-manila | 17:28 | |
| *** timcl has quit IRC | 17:28 | |
| *** timcl has joined #openstack-manila | 17:29 | |
| *** ChanServ changes topic to "8 bugs left until RC1" | 17:32 | |
| bswartz | gouthamr: it's just an issue of multibackend right? | 17:32 |
| bswartz | it's not an issue of the tests themselves | 17:33 |
| gouthamr | bswartz: yes.. | 17:33 |
| bswartz | and we've run the multibackend tests but they don't report | 17:33 |
| bswartz | do you know what's so hard about making the multibackend tests report? | 17:33 |
| gouthamr | bswartz: replication tests are required to be multibackend tests, else if we're replicating between pools on the same backend we may not be catching all the issues | 17:34 |
| bswartz | gouthamr: ignoring replication, why is it hard to run multibackend tests in public CI system? | 17:34 |
| gouthamr | bswartz: it would be real easy to just turn them on right now, we have one backend reporting multiple pools | 17:34 |
| * bswartz wishes akerr were here | 17:35 | |
| gouthamr | bswartz: oh.. we haven't done all the configuration work for it | 17:35 |
| gouthamr | bswartz: its not hard | 17:35 |
| bswartz | is it expensive? | 17:35 |
| bswartz | why would we have chosen not to do it? | 17:35 |
| gouthamr | bswartz: not expensive | 17:35 |
| gouthamr | bswartz: the work we're doing now would have our CI be reporting multibackend all the time. | 17:37 |
| bswartz | tpsilva: ping re https://review.openstack.org/#/c/287758/ | 17:37 |
| bswartz | gouthamr: nearly all the gate tests run that way | 17:37 |
| bswartz | gouthamr: I think we should ask all the CI systems to run multibackend | 17:37 |
| tpsilva | bswartz: pong | 17:37 |
| tpsilva | bswartz: working on it... getting more tests | 17:38 |
| bswartz | tpsilva: back from lunch? new patchset soon? | 17:38 |
| gouthamr | bswartz: i agree. | 17:38 |
| bswartz | ok | 17:38 |
| tpsilva | bswartz: problem is, the test that is currently failing | 17:38 |
| tpsilva | bswartz: we cannot find it :) | 17:38 |
| bswartz | tpsilva: lol | 17:38 |
| tpsilva | bswartz: asked ganso to check if I'm not crazy... he couldn't find it either | 17:38 |
| *** vbellur has joined #openstack-manila | 17:39 | |
| *** mlima has left #openstack-manila | 17:39 | |
| bswartz | tpsilva: https://github.com/openstack/manila/blob/master/manila/tests/share/test_manager.py#L2167 | 17:40 |
| bswartz | it's this one ^ | 17:40 |
| tpsilva | oh, my patch probably needs a rebase | 17:40 |
| tpsilva | didn't think that | 17:40 |
| tpsilva | sorry hehe :) | 17:41 |
| bswartz | ganso added that test 21 days ago according to blame | 17:42 |
| cknight | makes sense. I always blame ganso. | 17:42 |
| bswartz | maybe ganso is the crazy one if he can't find the test he wrote | 17:42 |
| ganso | I am crazy, nothing new here | 17:43 |
| cknight | :-) | 17:43 |
| *** a_ta has quit IRC | 17:43 | |
| bswartz | I'm still trying to figure out when this merged though | 17:43 |
| *** a_ta has joined #openstack-manila | 17:43 | |
| bswartz | one of the things that drives ME crazy is that gerrit retains the timestamp of the commiter's push to gerrit when it merges, not the timestamp when gerrit actually merged it | 17:44 |
| *** david-lyle_ has joined #openstack-manila | 17:44 | |
| *** david-lyle has quit IRC | 17:45 | |
| bswartz | Any reason not to merge https://review.openstack.org/#/c/289382/ now? | 17:45 |
| *** david-lyle_ is now known as david-lyle | 17:46 | |
| bswartz | and anyknow know Jamie Lennox's IRC handle? | 17:46 |
| cknight | bswartz: it can merge, just need another reviewer | 17:46 |
| bswartz | nm it appears to be jamielennox | 17:46 |
| *** a_ta has quit IRC | 17:48 | |
| *** akshai has quit IRC | 17:49 | |
| *** timcl has quit IRC | 17:56 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: NetApp cDOT: Handle replicated snapshots https://review.openstack.org/293243 | 17:57 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Data Replication: Ensure Snapshots across replicas https://review.openstack.org/292659 | 17:57 |
| mkoderer__ | bswartz: just saw jamies timezone is UTC+11 (AEDT).. for him it's middle of the night | 18:00 |
| *** martyturner has quit IRC | 18:01 | |
| *** timcl has joined #openstack-manila | 18:03 | |
| bswartz | mkoderer__: okay thanks -- if he reviews after it merges and finds any problems we'll have to file another bug | 18:03 |
| mkoderer__ | bswartz: +1 | 18:03 |
| *** martyturner has joined #openstack-manila | 18:03 | |
| *** lpetrut has quit IRC | 18:06 | |
| tpsilva | bswartz, ganso: yep, rebased my patch and now I can find the test | 18:07 |
| tpsilva | new patch should be up in a moment | 18:08 |
| bswartz | awesome | 18:08 |
| *** JoseMello has joined #openstack-manila | 18:08 | |
| bswartz | tpsilva: your fix is important because the last manilaclient bugfix depends on it | 18:09 |
| bswartz | I cannot tag the client until your fix goes in | 18:09 |
| vponomaryov | bswartz, cknight, please, see comment to commit with snapshot replication - https://review.openstack.org/#/c/292659/10 | 18:15 |
| vponomaryov | bswartz, cknight: share manager sets "error" status to "ok" snapshot | 18:16 |
| vponomaryov | bswartz, cknight: so, I would say we have design bug there | 18:17 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: NetApp cDOT: Handle replicated snapshots https://review.openstack.org/293243 | 18:18 |
| vponomaryov | bswartz, cknight: current approach is ok only if creation of replica is slow operation - slower than time of nearest snapshot instances periodic update | 18:18 |
| *** akshai has joined #openstack-manila | 18:19 | |
| bswartz | vponomaryov: I'm not sure what your first comment refers to | 18:19 |
| bswartz | vponomaryov: I agree with you about the second issue -- it's something to address in the future however | 18:20 |
| vponomaryov | bswartz: em, all of these are single issue | 18:20 |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Fix update_access concurrency issue https://review.openstack.org/287758 | 18:21 |
| tpsilva | bswartz, cknight: ^ | 18:21 |
| tpsilva | hope it's ok now | 18:21 |
| gouthamr | vponomaryov: Yogesh's next patch adds the wait for snapshot before promotion | 18:21 |
| bswartz | vponomaryov: it should not be allowed to promote a replica that is not in sync, and the replica should not be in sync until it has all the snapshots | 18:21 |
| bswartz | it's the test's responsibility to wait | 18:21 |
| vponomaryov | bswartz: share manager does not allow update it from "create replica" call | 18:22 |
| vponomaryov | bswartz; but should allow it, it is design bug | 18:22 |
| bswartz | also, if you create a snapshot and immediately promote before snapshot is active, you expect that snapshot to go to error | 18:22 |
| vponomaryov | bswartz: snapshot resource exists and it is ok | 18:22 |
| vponomaryov | bswartz: share manager just does not set available status | 18:22 |
| bswartz | vponomaryov: I agree it's a design bug. I don't want to fix it now | 18:23 |
| gouthamr | vponomaryov: we spoke about this yesterday, at length. :) | 18:23 |
| gouthamr | vponomaryov | 18:23 |
| bswartz | the driver interface for replication needs a lot of work | 18:23 |
| bswartz | however that should not prevent us from shipping something that works in mitaka | 18:23 |
| gouthamr | vponomaryov: i would say a driver setting a replica to in_sync in the create_replica call is bad design.. | 18:23 |
| bswartz | the alternative is to disable replication APIs and cut the RC with no replication | 18:23 |
| gouthamr | vponomaryov: you'll be waiting on that call for a long time if the share is huge | 18:23 |
| gouthamr | there're tradeoffs to both these approaches, | 18:24 |
| vponomaryov | gouthamr: driver call and API are different things | 18:24 |
| bswartz | I would have been nice if we noticed these issues weeks ago when there was time to fix them | 18:25 |
| vponomaryov | gouthamr: user will not wait for call, he will wait for status | 18:25 |
| bswartz | now we're stuck shipping the best thing we have time to get done | 18:25 |
| gouthamr | vponomaryov: we'll revisit this with the multiple database updates that you're suggesting. | 18:25 |
| vponomaryov | bswartz: ZFSonLinux fix is ready | 18:25 |
| gouthamr | vponomaryov: for now, the tests will wait. | 18:25 |
| vponomaryov | gouthamr: tests can be fixed easily | 18:26 |
| vponomaryov | gouthamr: even now | 18:26 |
| bswartz | vponomaryov: ty | 18:26 |
| bswartz | gouthamr: wait for what | 18:26 |
| vponomaryov | gouthamr: after promote of replica and deletion of another just wait for absense of second replica, then wait for status of snapshot | 18:27 |
| gouthamr | vponomaryov: it's fixed. we're running them multiple times, they'll be up asap. | 18:27 |
| gouthamr | vponomaryov: yep. done | 18:27 |
| bswartz | gouthamr: why wait? | 18:27 |
| vponomaryov | bswartz: it is workaround for bug | 18:27 |
| vponomaryov | bswartz; for tempest tests | 18:27 |
| bswartz | I'm asking is there going to be a patchset 7, and if so, when? | 18:28 |
| bswartz | err | 18:28 |
| gouthamr | bswartz: for tempest tests? | 18:28 |
| bswartz | yes | 18:29 |
| gouthamr | bswartz: i think only the tests need another patch | 18:29 |
| bswartz | gouthamr: when? | 18:29 |
| gouthamr | bswartz: in a bit. They're running for the 3rd time right now (each run takes 15 mins) :) | 18:29 |
| vponomaryov | gouthamr: you run all the tests? )) | 18:30 |
| bswartz | gouthamr: if it passed 2 times, just push it | 18:30 |
| bswartz | I don't understand what we expect to happen the 3rd time | 18:30 |
| bswartz | you realize we're not shipping mitaka tomorrow right? | 18:30 |
| cknight | bswartz: 3rd time is a charm. Everyone knows that! | 18:30 |
| bswartz | you'll have time to find and fix more bugs | 18:31 |
| gouthamr | bswartz: yes ^^ | 18:31 |
| gouthamr | :P | 18:31 |
| bswartz | right now we need to cut RC1 | 18:31 |
| bswartz | RIGHT NOW | 18:31 |
| gouthamr | bswartz: we're testing the debris that gets left behind, vponomaryov pointed out some stuff | 18:31 |
| ameade | that's just for the tests | 18:31 |
| ameade | which we dont have to wait for we discussed | 18:31 |
| bswartz | I would like the tests in RC1 | 18:32 |
| bswartz | we don't need them but I would like them | 18:32 |
| ameade | yeah def, lets get the patches they depend on in now | 18:32 |
| bswartz | ameade: the gate doesn't make you wait -- you can workflow things in parallel | 18:33 |
| *** a_ta has joined #openstack-manila | 18:33 | |
| bswartz | I guess what I'm saying is, unless you know something is wrong with the latest test patch, upload it so we can review it | 18:34 |
| ganso | btw, is it possible to create a share without a type? | 18:34 |
| bswartz | ganso: no | 18:34 |
| ganso | bswartz: great, thanks | 18:34 |
| bswartz | ganso: if you don't specify one, you get the default type | 18:35 |
| bswartz | and the default type is required to exist | 18:35 |
| *** lpetrut has joined #openstack-manila | 18:37 | |
| bswartz | cknight: you saw latest https://review.openstack.org/287758 ? | 18:37 |
| cknight | bswartz: yes, looking already | 18:38 |
| cknight | tpsilva: I see a couple test gaps that should be quick to close | 18:38 |
| bswartz | tpsilva: you know that initialization and initialisation are both correct english right? | 18:39 |
| bswartz | just different regional spellings | 18:39 |
| tpsilva | bswartz: yes.. us vs uk | 18:40 |
| tpsilva | bswartz: why? | 18:40 |
| bswartz | I saw you fixed it in your patch | 18:40 |
| tpsilva | cknight: where? | 18:40 |
| bswartz | err wait | 18:40 |
| bswartz | oh that came from the rebase not your change | 18:40 |
| bswartz | sorry I was comparing PS16 and PS17 | 18:40 |
| tpsilva | yep, the rebase messed the diff | 18:40 |
| bswartz | somebody else made that spelling change | 18:40 |
| cknight | tpsilva: posted comment | 18:41 |
| tpsilva | cknight: right, thank you | 18:41 |
| openstackgerrit | Yogesh proposed openstack/manila: Add tests to ensure snapshots across replicas https://review.openstack.org/293113 | 18:41 |
| bswartz | yogi1: ty | 18:41 |
| Yogi1 | bswartz np | 18:41 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix manage API ignoring type extra specs https://review.openstack.org/294269 | 18:46 |
| ganso | cknight, bswartz: ^ | 18:46 |
| cknight | ganso: looking | 18:48 |
| bswartz | tpsilva: will it be easy to cover those code paths? | 18:48 |
| tpsilva | bswartz: yes, I'm already working on that | 18:49 |
| tpsilva | bswartz: yes, I'm already working on that | 18:52 |
| tpsilva | oops, wrong window | 18:52 |
| vponomaryov | Yogi1: it still will fail | 18:52 |
| *** a_ta has quit IRC | 18:52 | |
| vponomaryov | Yogi1: no waits after promote and replica delete steps | 18:52 |
| Yogi1 | vponomaryov: wait for what after promote? | 18:53 |
| vponomaryov | Yogi1: also, two tests require additional waiters and only one got it in PS7 | 18:53 |
| cknight | ganso: Patch looks fine. I know there isn't time now, but it seems we should have a Tempest test to validate the fix. | 18:54 |
| Yogi1 | One was already sent in earlier patch | 18:54 |
| bswartz | more test coverage! | 18:54 |
| * bswartz shakes fist | 18:54 | |
| vponomaryov | Yogi1: hm, nevermind, waiters will not help | 18:54 |
| ganso | cknight: there is a semi negative test, the one I updated | 18:54 |
| cknight | ganso: nvm, I see it now, thanks. nice job. | 18:55 |
| vponomaryov | Yogi1: ZFSonLinux will still fail on two tests | 18:55 |
| ganso | cknight: in order for the test to suceed, it must behave according to the change | 18:55 |
| ganso | cknight: thanks | 18:55 |
| vponomaryov | Yogi1: you will get active replica in https://review.openstack.org/#/c/293113/6..7/manila_tempest_tests/tests/api/base.py too | 18:55 |
| vponomaryov | Yogi1: and "exceptions.BadRequest" is expected error in case of attempt to delete active | 18:56 |
| vponomaryov | Yogi1: you should be ok only with "NotFound" there | 18:56 |
| cknight | bswartz: Who else is reviewing the sslutils fix? https://review.openstack.org/#/c/289382/ | 18:57 |
| cknight | ganso: Have you looked at it? | 18:57 |
| Yogi1 | vponomaryov : therefore I am ignoring that if there is active replica | 18:57 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add tests to ensure snapshots across replicas https://review.openstack.org/293113 | 18:58 |
| Yogi1 | vponomaryov I don't think we have NotFound exception | 18:58 |
| ganso | cknight: started but did not finish | 18:58 |
| ganso | cknight: will try to finish now | 18:59 |
| bswartz | xyang1 markstur ganso toabctl: https://review.openstack.org/#/c/289382/ https://review.openstack.org/#/c/294269/ | 18:59 |
| Yogi1 | vponomaryov the client returns BadRequest | 18:59 |
| vponomaryov | Yogi1: it is for active and last one | 18:59 |
| vponomaryov | Yogi1: "clear_resources" call can be concurrent | 19:00 |
| gouthamr | vponomaryov: concurrent for the same class? | 19:01 |
| vponomaryov | Yogi1: so, better to add base method that tries delete share replica and wraps NotFound | 19:01 |
| ganso | cknight: we got some failures | 19:01 |
| vponomaryov | Yogi1: and provide it to addCleanup | 19:01 |
| ganso | cknight: how about a recheck? | 19:01 |
| cknight | ganso: where? | 19:02 |
| vponomaryov | Yogi1: and in test do both, call addCleanup first then you can delete share replica in the middle of the test | 19:02 |
| ganso | cknight: zfs and generic-no-share-servers CI | 19:02 |
| ganso | cknight: https://review.openstack.org/#/c/289382/ | 19:02 |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Fix update_access concurrency issue https://review.openstack.org/287758 | 19:02 |
| gouthamr | vponomaryov: that approach is fine. but the current approach will work fine too... it ensures the share can be deleted , even if addCleanup is not added | 19:04 |
| cknight | ganso: OK, done. 25 failures on ZFS. Perhaps vponomaryov should look at that. https://review.openstack.org/#/c/289382/5 | 19:04 |
| ganso | cknight: yea, looked at no-share-servers error, seemed random | 19:04 |
| vponomaryov | cknight: TypeError: update_access() takes at least 5 arguments (4 given) | 19:04 |
| ganso | vponomaryov: ah, right | 19:05 |
| ganso | cknight: well, we should recheck in order to run on updated tree | 19:05 |
| vponomaryov | cknight: there is very old CI report | 19:05 |
| bswartz | just 2 days... | 19:06 |
| vponomaryov | bswartz: 2 days! | 19:06 |
| vponomaryov | bswartz: in our case it is ages | 19:06 |
| ganso | bswartz: lots of stuff merged in 2 days | 19:06 |
| vponomaryov | gouthamr: fi it worked in you lab does not mean it is ok | 19:07 |
| vponomaryov | gouthamr: you delete there untracked stuff | 19:07 |
| vponomaryov | gouthamr: random stuff | 19:07 |
| vponomaryov | gouthamr: only registered ones shoudl be delted | 19:07 |
| gouthamr | vponomaryov: but you're trying to delete the share | 19:08 |
| bswartz | looks like keystonev3 patch passed | 19:08 |
| gouthamr | vponomaryov: why do you care about its untracked replicas | 19:08 |
| *** ChanServ changes topic to "7 bugs left until RC1" | 19:08 | |
| ganso | launchpad says 8 ^ | 19:09 |
| gouthamr | vponomaryov: alright, we can try your approach. however, i think this works for now. i want to see if any ZFS failures exist on this patch. | 19:09 |
| gouthamr | ganso: could it be me closing two bugs with one patch? :P | 19:09 |
| vponomaryov | gouthamr: exists for sure, 2 tests will fail | 19:09 |
| ganso | gouthamr: could be :) | 19:09 |
| vponomaryov | gouthamr: same as in http://logs.openstack.org/26/294626/1/check/gate-manila-tempest-dsvm-postgres-zfsonlinux/6b9e0e4/logs/testr_results.html.gz | 19:09 |
| gouthamr | vponomaryov: meh :( | 19:09 |
| vponomaryov | gouthamr: want make a bet? )) | 19:10 |
| gouthamr | vponomaryov: lol, i trust your CI knowledge too much to risk my money | 19:10 |
| vponomaryov | gouthamr: there is russian saying: "the one who does not accept risk does not drink champagne" | 19:11 |
| gouthamr | vponomaryov: bswartz once promised me scotch for all the risks i've been taking of late | 19:12 |
| vponomaryov | gouthamr: and? )) | 19:12 |
| gouthamr | vponomaryov: im still waiting :P | 19:12 |
| *** chlong has quit IRC | 19:12 | |
| vponomaryov | bswartz, cknight: https://review.openstack.org/#/c/289382/ this one fixes only half of the bug | 19:13 |
| vponomaryov | bswartz, cknight: second part is about fixed py34 support | 19:13 |
| *** a_ta has joined #openstack-manila | 19:14 | |
| openstackgerrit | Merged openstack/manila: Fix keystone v3 issues for all clients https://review.openstack.org/290511 | 19:14 |
| cknight | vponomaryov: What remains? Reenabling the SSL + py3 tests? | 19:16 |
| vponomaryov | cknight: yes | 19:17 |
| vponomaryov | cknight: so, it should have been "partial_fix" | 19:17 |
| *** ociuhandu has quit IRC | 19:18 | |
| cknight | vponomaryov: That's a 2-line change to reenable those. | 19:18 |
| vponomaryov | cknight: yes, but they will fail | 19:18 |
| cknight | vponomaryov: And we can do that anytime. But yes, 'Partial-fix' would have been better. | 19:18 |
| vponomaryov | cknight: bug still exists , we just change with it place where we get options, that all | 19:19 |
| cknight | vponomaryov: oh, so is it just the tests that don't work with py3, or does the wsgi code not work with py3? | 19:19 |
| vponomaryov | cknight: the latter | 19:20 |
| vponomaryov | cknight: wsgi SSL code | 19:20 |
| cknight | vponomaryov: ah, OK, I get it. thanks. | 19:20 |
| vponomaryov | cknight: so, it is not critical to merge it even as partial fix | 19:21 |
| cknight | vponomaryov: that's up to bswartz, then | 19:21 |
| vponomaryov | cknight: only if SSL oslo code gets fixed after some time | 19:21 |
| bswartz | vponomaryov: well we have that other bug still open | 19:22 |
| bswartz | let's target it at N-1 and someone should assign themselves | 19:22 |
| bswartz | py3 doesn't need to work in mitaka | 19:22 |
| bswartz | we don't support it | 19:22 |
| vponomaryov | bswartz: most of our code is compatible with it | 19:23 |
| bswartz | yes but we don't have tempest coverage for py3 | 19:24 |
| vponomaryov | bswartz: just several of things are skipped and SSL wsgi tests among them | 19:24 |
| bswartz | show me passing tempest tests with py3 and I'll start to care more about py3 bugs | 19:25 |
| bswartz | vponomaryov: you're referring to unit tests, right? | 19:25 |
| vponomaryov | bswartz: yes | 19:25 |
| cknight | ganso: sorry, i jumped the gun and workflow'ed the manage fix. I guess we'll see if it passes the check queue. | 19:26 |
| bswartz | vponomaryov: we care about py3 compatibility at unit test level only -- because it means we're not HORRIBLY broken on py3 | 19:26 |
| bswartz | there's a lot of evidence that actual functional tests on py3 won't pass without a ton more work | 19:27 |
| *** lpetrut has quit IRC | 19:27 | |
| ganso | cknight: https://review.openstack.org/#/c/289382/ | 19:28 |
| ganso | cknight: now we really need a recheck | 19:28 |
| cknight | bswartz: ^^ Are you going to retarget this, or must we fix the conflict? | 19:28 |
| *** akshai has quit IRC | 19:30 | |
| *** sgotliv has quit IRC | 19:33 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila: Use sslutils from oslo_service https://review.openstack.org/289382 | 19:38 |
| bswartz | there | 19:39 |
| bswartz | freaking merge conflicts | 19:39 |
| bswartz | this is why it's better to merge everything as early as humanly possible | 19:39 |
| bswartz | vponomaryov: are you ready to merge https://review.openstack.org/#/c/292659/ ? | 19:41 |
| bswartz | that's the big one | 19:41 |
| bswartz | glusterfs CI is reporting "unstable" now | 19:42 |
| tpsilva | yep, glusterfs just failed on my patch | 19:42 |
| *** akshai has joined #openstack-manila | 19:43 | |
| *** ociuhandu has joined #openstack-manila | 19:45 | |
| *** a_ta has quit IRC | 19:45 | |
| *** a_ta has joined #openstack-manila | 19:46 | |
| *** a_ta has quit IRC | 19:46 | |
| *** a_ta has joined #openstack-manila | 19:46 | |
| *** akerr has joined #openstack-manila | 19:47 | |
| bswartz | Yogi1: you failed pep8 | 19:47 |
| Yogi1 | yeah just saw that | 19:48 |
| bswartz | gouthamr: it was actually our commit to yogi1's patch | 19:48 |
| bswartz | s/our/your/ | 19:48 |
| Yogi1 | Will pix and send it again | 19:48 |
| Yogi1 | s/pix/fix/ | 19:48 |
| openstackgerrit | Yogesh proposed openstack/manila: Add tests to ensure snapshots across replicas https://review.openstack.org/293113 | 19:59 |
| *** dencaval has quit IRC | 20:02 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add tests to ensure snapshots across replicas https://review.openstack.org/293113 | 20:03 |
| *** timcl has quit IRC | 20:07 | |
| *** akshai has quit IRC | 20:14 | |
| *** akshai has joined #openstack-manila | 20:18 | |
| *** akshai has quit IRC | 20:23 | |
| *** a_ta has quit IRC | 20:24 | |
| *** a_ta has joined #openstack-manila | 20:25 | |
| *** ChanServ changes topic to "6 bugs left until RC1" | 20:26 | |
| *** a_ta has quit IRC | 20:29 | |
| *** a_ta has joined #openstack-manila | 20:29 | |
| *** akerr has quit IRC | 20:30 | |
| ganso | https://review.openstack.org/#/c/294269/ is ready for workflow | 20:34 |
| bswartz | ganso: thanks | 20:37 |
| ganso | bswartz: =D | 20:37 |
| *** alejandrito has quit IRC | 20:37 | |
| bswartz | ganso: have you reviewed https://review.openstack.org/#/c/287758/ ? | 20:38 |
| ganso | bswartz: yes, waiting for jenkins | 20:38 |
| ganso | bswartz: I tested it on my lab as well | 20:38 |
| ganso | bswartz: depending on errors in CI, may be good to go | 20:38 |
| bswartz | jenkins is in bad shapre today | 20:39 |
| ganso | bswartz: yes | 20:39 |
| bswartz | everything is done except the voting tempest job | 20:39 |
| ganso | bswartz: coverage test got stuck | 20:39 |
| bswartz | chances are high it will timeout | 20:39 |
| bswartz | so a recheck will be needed | 20:39 |
| ganso | bswartz: no o_O | 20:39 |
| bswartz | if you can review the other test results and +2 then we will just recheck until it passes the voting job | 20:39 |
| ganso | bswartz: voting job has passed | 20:39 |
| bswartz | oh wait | 20:40 |
| bswartz | you're right | 20:40 |
| bswartz | o_O | 20:40 |
| bswartz | I didn't line up the blue bar right on my screen | 20:40 |
| bswartz | since it's nonvoting we should be g2g | 20:40 |
| *** akshai has joined #openstack-manila | 20:42 | |
| ganso | bswartz: too many errors in job that failed, but nothing in m-shr o_O | 20:42 |
| ganso | bswartz: no valid host was found everywhere in m-sch | 20:42 |
| bswartz | what are you looking at? | 20:43 |
| ganso | bswartz: guess devstack failed setting up vm | 20:43 |
| ganso | bswartz: no-share-servers job for 287758 | 20:43 |
| bswartz | yeah | 20:43 |
| ganso | bswartz: coverage test will fail as well... do you want to re-run for those two? | 20:45 |
| bswartz | I want to get the +2s and +A and then fight the gate afterwards | 20:45 |
| ganso | bswartz: it succeeded o_O | 20:45 |
| bswartz | anyone can recheck endlessly | 20:45 |
| bswartz | the important thing is to determine that no more patchsets are needed | 20:46 |
| ganso | bswartz: agreed | 20:46 |
| bswartz | and remember that if we find new bugs we can fix them in RC2 | 20:46 |
| bswartz | this is a huge improvement to what we have now | 20:46 |
| bswartz | so I want it in | 20:46 |
| ganso | bswartz: I assured it works in generic NFS, CIFS and HNAS... was mostly worried about other vendors | 20:48 |
| bswartz | vendors with broken CI deserve what they get | 20:48 |
| bswartz | and I expect manual testing to be done on RC1 and bugs to be filed if that uncovers any issues | 20:49 |
| bswartz | the whole point of RC1 is to give everyone something to do they manual regression tests on | 20:49 |
| bswartz | s/they/their/ | 20:50 |
| gouthamr | vponomaryov: still here? | 20:50 |
| ganso | bswartz: what's RC2 date? | 20:50 |
| bswartz | when all the bugs found after RC1 are fixed | 20:51 |
| bswartz | :-p | 20:51 |
| ganso | bswartz: or punted | 20:51 |
| bswartz | correct | 20:51 |
| bswartz | there is no date | 20:51 |
| bswartz | we pray RC2 isn't needed at all | 20:51 |
| bswartz | but if it is, we figure out what needs to be in and we get that done | 20:52 |
| bswartz | RC2 can happen up until like a day before the official release | 20:52 |
| bswartz | same w/ RC3, RC4, etc | 20:52 |
| ganso | bswartz: great | 20:53 |
| bswartz | the bar for getting a fix in gets higher and higher though as we try to eliminate risk | 20:53 |
| *** a_ta has quit IRC | 20:55 | |
| *** a_ta has joined #openstack-manila | 20:55 | |
| *** a_ta has quit IRC | 21:00 | |
| *** vbellur has quit IRC | 21:02 | |
| *** vbellur has joined #openstack-manila | 21:04 | |
| *** david-lyle has quit IRC | 21:06 | |
| *** david-lyle has joined #openstack-manila | 21:07 | |
| *** vbellur has quit IRC | 21:13 | |
| *** gouthamr has quit IRC | 21:21 | |
| openstackgerrit | Merged openstack/manila: Fix manage API ignoring type extra specs https://review.openstack.org/294269 | 21:21 |
| *** Yogi1 has quit IRC | 21:22 | |
| *** akshai_ has joined #openstack-manila | 21:23 | |
| *** furlongm_ has joined #openstack-manila | 21:25 | |
| *** esker has quit IRC | 21:26 | |
| *** furlongm has quit IRC | 21:26 | |
| *** akshai has quit IRC | 21:26 | |
| *** kambiz has quit IRC | 21:26 | |
| *** dhellmann has quit IRC | 21:26 | |
| *** kambiz has joined #openstack-manila | 21:26 | |
| *** dhellmann has joined #openstack-manila | 21:26 | |
| *** esker has joined #openstack-manila | 21:26 | |
| *** rhagarty has quit IRC | 21:27 | |
| *** rhagarty has joined #openstack-manila | 21:28 | |
| *** rhagarty has quit IRC | 21:29 | |
| openstackgerrit | Merged openstack/manila: Fix update_access concurrency issue https://review.openstack.org/287758 | 21:35 |
| *** mtanino has quit IRC | 21:39 | |
| openstackgerrit | Yogesh proposed openstack/manila: Add tests to ensure snapshots across replicas https://review.openstack.org/293113 | 21:48 |
| *** xyang1 has quit IRC | 21:56 | |
| *** erlon has quit IRC | 21:57 | |
| ameade | bswartz: looks ready https://review.openstack.org/#/c/292659/10 | 21:59 |
| ameade | https://review.openstack.org/#/c/293243/9 | 21:59 |
| ameade | needs +2s again | 21:59 |
| *** juzuluag has quit IRC | 22:01 | |
| *** cknight has quit IRC | 22:30 | |
| *** vbellur has joined #openstack-manila | 22:36 | |
| *** martyturner has quit IRC | 22:50 | |
| *** jasonsb has joined #openstack-manila | 22:51 | |
| *** akshai_ has quit IRC | 23:04 | |
| *** JoseMello has quit IRC | 23:29 | |
| *** cknight has joined #openstack-manila | 23:32 | |
| *** gouthamr has joined #openstack-manila | 23:54 | |
| *** gouthamr_ has joined #openstack-manila | 23:55 | |
| *** gouthamr has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!