*** yangyapeng has quit IRC | 00:00 | |
*** pgbridge has quit IRC | 00:00 | |
*** a_ta has quit IRC | 00:03 | |
*** a_ta has joined #openstack-manila | 00:03 | |
*** akshai has joined #openstack-manila | 00:05 | |
*** a_ta_ has joined #openstack-manila | 00:06 | |
*** akshai_ has joined #openstack-manila | 00:06 | |
*** a_ta has quit IRC | 00:08 | |
*** akshai has quit IRC | 00:10 | |
*** a_ta_ has quit IRC | 00:12 | |
*** a_ta has joined #openstack-manila | 00:12 | |
*** a_ta has quit IRC | 00:16 | |
*** a_ta has joined #openstack-manila | 00:23 | |
*** qeelee has joined #openstack-manila | 00:27 | |
*** a_ta has quit IRC | 00:29 | |
*** a_ta has joined #openstack-manila | 00:29 | |
*** a_ta has quit IRC | 00:43 | |
*** qeelee has quit IRC | 00:50 | |
*** qeelee has joined #openstack-manila | 00:50 | |
*** a_ta has joined #openstack-manila | 00:57 | |
*** yangyapeng has joined #openstack-manila | 01:04 | |
*** a_ta has quit IRC | 01:05 | |
*** a_ta has joined #openstack-manila | 01:06 | |
*** a_ta has quit IRC | 01:08 | |
*** a_ta has joined #openstack-manila | 01:08 | |
*** yangyapeng has quit IRC | 01:10 | |
*** a_ta has quit IRC | 01:13 | |
*** a_ta has joined #openstack-manila | 01:14 | |
*** a_ta has quit IRC | 01:18 | |
*** gouthamr_ has joined #openstack-manila | 01:19 | |
*** gouthamr has quit IRC | 01:23 | |
*** yangyapeng has joined #openstack-manila | 01:23 | |
*** cknight1 has joined #openstack-manila | 01:37 | |
*** cknight has quit IRC | 01:40 | |
*** baojg has joined #openstack-manila | 01:48 | |
*** a_ta has joined #openstack-manila | 02:32 | |
*** a_ta has quit IRC | 02:34 | |
*** a_ta has joined #openstack-manila | 02:35 | |
*** a_ta has quit IRC | 02:39 | |
*** cknight1 has quit IRC | 02:42 | |
*** houming has joined #openstack-manila | 02:45 | |
*** a_ta has joined #openstack-manila | 03:00 | |
*** a_ta has quit IRC | 03:02 | |
*** a_ta has joined #openstack-manila | 03:03 | |
*** a_ta_ has joined #openstack-manila | 03:04 | |
*** a_ta has quit IRC | 03:04 | |
*** chlong has quit IRC | 03:12 | |
*** a_ta_ has quit IRC | 03:14 | |
*** chlong has joined #openstack-manila | 03:14 | |
*** a_ta has joined #openstack-manila | 03:15 | |
*** absubram has quit IRC | 03:18 | |
*** a_ta has quit IRC | 03:19 | |
*** qeelee has quit IRC | 03:29 | |
*** qeelee has joined #openstack-manila | 03:33 | |
*** jasonsb has joined #openstack-manila | 03:42 | |
*** a_ta has joined #openstack-manila | 03:56 | |
*** a_ta has quit IRC | 03:58 | |
*** a_ta has joined #openstack-manila | 03:58 | |
*** cknight has joined #openstack-manila | 03:59 | |
*** qeelee has quit IRC | 04:03 | |
*** a_ta has quit IRC | 04:03 | |
*** jasonsb has quit IRC | 04:04 | |
*** a_ta has joined #openstack-manila | 04:12 | |
*** a_ta has quit IRC | 04:16 | |
*** a_ta has joined #openstack-manila | 04:16 | |
*** swamireddy1 has joined #openstack-manila | 04:26 | |
*** jasonsb has joined #openstack-manila | 04:26 | |
*** a_ta has quit IRC | 04:32 | |
*** swamireddy2 has joined #openstack-manila | 04:32 | |
*** a_ta has joined #openstack-manila | 04:33 | |
*** swamireddy1 has quit IRC | 04:33 | |
*** a_ta has quit IRC | 04:37 | |
*** cknight has quit IRC | 04:43 | |
*** swamireddy2 has quit IRC | 04:45 | |
*** swamireddy1 has joined #openstack-manila | 04:47 | |
*** jasonsb_ has joined #openstack-manila | 04:50 | |
*** jasonsb has quit IRC | 04:50 | |
*** qeelee has joined #openstack-manila | 04:53 | |
*** a_ta has joined #openstack-manila | 04:57 | |
*** zhonghua-lee has quit IRC | 05:09 | |
*** a_ta has quit IRC | 05:10 | |
*** zhonghua-lee has joined #openstack-manila | 05:10 | |
*** a_ta has joined #openstack-manila | 05:11 | |
*** a_ta has quit IRC | 05:15 | |
*** qeelee has quit IRC | 05:22 | |
*** yangyape_ has joined #openstack-manila | 05:23 | |
*** yangyapeng has quit IRC | 05:23 | |
*** yangyape_ has quit IRC | 05:24 | |
*** akshai_ has quit IRC | 05:25 | |
*** swamireddy1 has quit IRC | 05:31 | |
*** swamireddy1 has joined #openstack-manila | 05:33 | |
*** houming has quit IRC | 05:37 | |
*** qeelee has joined #openstack-manila | 05:52 | |
*** lpetrut has joined #openstack-manila | 06:38 | |
*** chlong has quit IRC | 06:45 | |
*** lpetrut has quit IRC | 07:29 | |
*** pcaruana has joined #openstack-manila | 07:38 | |
*** qeelee has quit IRC | 07:39 | |
*** qeelee has joined #openstack-manila | 07:43 | |
*** a_ta has joined #openstack-manila | 07:55 | |
*** a_ta has quit IRC | 08:01 | |
*** baojg has quit IRC | 08:21 | |
*** baojg has joined #openstack-manila | 08:29 | |
*** houming has joined #openstack-manila | 08:40 | |
*** baojg has quit IRC | 08:54 | |
*** lpetrut has joined #openstack-manila | 08:57 | |
*** baojg has joined #openstack-manila | 09:03 | |
*** openstackstatus has joined #openstack-manila | 09:08 | |
*** ChanServ sets mode: +v openstackstatus | 09:08 | |
*** gouthamr_ has quit IRC | 09:17 | |
*** lpetrut has quit IRC | 09:21 | |
*** houming has quit IRC | 09:34 | |
*** baojg_ has joined #openstack-manila | 09:38 | |
*** gregsfortytwo1 has joined #openstack-manila | 09:38 | |
*** baojg has quit IRC | 09:39 | |
*** gregsfortytwo has quit IRC | 09:39 | |
*** qeelee has quit IRC | 10:03 | |
*** lpetrut has joined #openstack-manila | 10:11 | |
*** ociuhandu has quit IRC | 10:40 | |
*** baojg_ has quit IRC | 10:43 | |
*** jcsp has quit IRC | 10:55 | |
*** jcsp has joined #openstack-manila | 11:10 | |
*** jcsp has quit IRC | 11:30 | |
*** timcl has joined #openstack-manila | 12:26 | |
*** david-lyle has quit IRC | 12:45 | |
*** ociuhandu has joined #openstack-manila | 12:56 | |
*** gouthamr has joined #openstack-manila | 13:28 | |
*** porrua has joined #openstack-manila | 13:49 | |
*** martyturner has joined #openstack-manila | 13:52 | |
*** absubram has joined #openstack-manila | 13:52 | |
*** cknight has joined #openstack-manila | 13:53 | |
*** absubram_ has joined #openstack-manila | 13:54 | |
*** Yogi1 has joined #openstack-manila | 13:54 | |
*** absubram has quit IRC | 13:57 | |
*** absubram_ is now known as absubram | 13:57 | |
*** resker has quit IRC | 14:35 | |
gouthamr | tbarron: thanks for chiming in on https://review.openstack.org/#/c/296706 | 14:58 |
---|---|---|
gouthamr | tbarron: i learned something :) | 14:58 |
tbarron | gouthamr: you learned that I'm not afraid to ask dumb questions. | 14:59 |
tbarron | gouthamr: there may be very good reasons for the approach being taken there or for the differences overall with cinder. | 15:00 |
*** sgotliv has joined #openstack-manila | 15:01 | |
tbarron | gouthamr: but if these differences haven't had a design discussion then you don't want them creeping in via bug fixes | 15:01 |
gouthamr | tbarron: true. i was wary of the impl for the 'call' vs 'cast' thing; but more code digging showed me there's definitely been much thought into doing it async in the first place. | 15:02 |
tbarron | gouthamr: in cinder we've considered replacing some casts with calls to (1) reduce the number of items left in errored states, and (2) to reduce some race windows. | 15:03 |
tbarron | gouthamr: but each time that has been considered (at least to my knowledge) the proposal has been rejected b/c of the strong desire to keep coupling loose and async | 15:03 |
gouthamr | tbarron: the only advantage we were shooting for is allowing the user to get an appropriate response | 15:03 |
tbarron | gouthamr: yeah, i get it. but maybe we should just get async error reporting implemented! | 15:04 |
gouthamr | tbarron: but then, in this case, the user is the admin.. so that "advantage" wasn't really one. | 15:04 |
*** esker has joined #openstack-manila | 15:04 | |
gouthamr | tbarron: exactly.. | 15:04 |
*** yangyapeng has joined #openstack-manila | 15:05 | |
gouthamr | tbarron: good to see ganso agrees. :) | 15:05 |
*** martyturner has quit IRC | 15:07 | |
tbarron | gouthamr: well, he says "I will change the patch to be synchronous". | 15:07 |
gouthamr | tbarron: asynchronous* | 15:07 |
tbarron | d'ohk, thanks | 15:07 |
tbarron | gouthamr: ^^ | 15:08 |
tbarron | ok, I can't read. | 15:08 |
gouthamr | tbarron: no but, patch can be asynchronous :P | 15:08 |
*** martyturner has joined #openstack-manila | 15:09 | |
tbarron | gouthamr: ameade: my other puzzle is that when ameade filed the bug he seemed to think API had the info it needed to fail this w/o consulting anyone else, e.g. scheduler. | 15:09 |
tbarron | gouthamr: ameade: ganso: (I don't see ganso on, not trying to talke w/o him here). | 15:09 |
tbarron | gouthamr: ameade: ganso: so I'm not sure that the problem ganso is addressing is actually the problem in the bug, though I agree that it is a related problem. | 15:10 |
tbarron | gouthamr: ameade: if there's a narrower case where api can fail fast w/o consulting the scheduler then we should do that. | 15:11 |
tbarron | gouthamr: ameade: but if scheduler has to be consulted then I'm inclined to go async unless manila makes an explicit decision to take a different approach on this stuff than cinder, nova, etc. | 15:12 |
ameade | i think we should always be sync to the sched | 15:13 |
ameade | then we can report issues to the user | 15:13 |
ameade | it's not really a long running task | 15:13 |
ameade | just a thought | 15:14 |
gouthamr | tbarron: in Manila, before https://review.openstack.org/#/c/294269/ we didn't use the scheduler for a manage op | 15:14 |
gouthamr | tbarron: so this is a bugfix to a bugfix really.. | 15:14 |
gouthamr | tbarron: we realized in the first bugfix that we needed to go through the scheduler for all the validation (we were never doing any validation before) | 15:15 |
tbarron | gouthamr: I see. In cinder manage/unmanage go through scheduler. | 15:15 |
tbarron | ameade: as long as that's an explicit design decision manila makes. | 15:16 |
tbarron | ameade: might be a good one. | 15:16 |
tbarron | ameade: it's innovative I think, which means it should be explicit. | 15:16 |
ameade | +1 | 15:16 |
tbarron | ameade: gouthamr: so ganso's pattern of calling sync from api to scheduler and then api calling (or casting) to share manager might be a really good design pattern. | 15:17 |
tbarron | ameade: gouthamr: ganso: if so, probably should use it more generally. | 15:18 |
tbarron | ameade: gouthamr: ganso: but if it's just a one off introduced in a bug fix ... | 15:19 |
tbarron | ok, I've beaten that horse to death. | 15:19 |
*** sgotliv has quit IRC | 15:24 | |
*** esker has quit IRC | 15:25 | |
*** timcl has quit IRC | 15:32 | |
gouthamr | tbarron: sorry was in a meeting. My vote is towards async here... The api can be hanging for a response for a long time and if our intention is to get it to report a failure quickly, we wouldn't be achieving that | 15:33 |
tbarron | gouthamr: yeah, I read your (articulte) remarks in the review. | 15:33 |
tbarron | articulate | 15:34 |
*** david-lyle has joined #openstack-manila | 15:34 | |
tbarron | gouthamr: there remains the question of whether ameade when filing the bug thought there was some smart fail-fast thing api could do (maybe for a narrower set of use cases) without consulting the scheduler. | 15:35 |
gouthamr | tbarron: i know the context of the bug.. it was a cleanup failure in the tests | 15:37 |
gouthamr | tbarron: it may not have been evident in the bug.. ameade could still think the API should fail fast.. | 15:38 |
*** david-lyle_ has joined #openstack-manila | 15:38 | |
gouthamr | tbarron: we need a discussion around this, can i suggest a short one for Austin? bswartz ameade | 15:38 |
*** david-lyle has quit IRC | 15:38 | |
tbarron | gouthamr: i'm in | 15:39 |
*** david-lyle_ is now known as david-lyle | 15:39 | |
gouthamr | tbarron: added :) https://etherpad.openstack.org/p/manila-newton-summit-topics (Part of the APIImpact discussion) | 15:49 |
*** swamireddy1 has quit IRC | 15:52 | |
tbarron | gouthamr: ty | 15:53 |
*** a_ta has joined #openstack-manila | 16:05 | |
*** pcaruana has quit IRC | 16:11 | |
*** a_ta has quit IRC | 16:17 | |
*** a_ta has joined #openstack-manila | 16:17 | |
*** a_ta has quit IRC | 16:22 | |
*** timcl has joined #openstack-manila | 16:30 | |
*** esker has joined #openstack-manila | 16:40 | |
*** esker has quit IRC | 16:44 | |
*** esker has joined #openstack-manila | 16:44 | |
*** esker has quit IRC | 16:45 | |
*** esker has joined #openstack-manila | 16:46 | |
*** Yogi1 has quit IRC | 16:50 | |
*** timcl1 has joined #openstack-manila | 16:58 | |
*** martyturner has quit IRC | 16:59 | |
*** timcl has quit IRC | 17:01 | |
*** martyturner has joined #openstack-manila | 17:03 | |
*** esker has quit IRC | 17:38 | |
*** lpetrut has quit IRC | 17:38 | |
*** esker has joined #openstack-manila | 17:39 | |
*** sgotliv has joined #openstack-manila | 17:39 | |
*** sgotliv has quit IRC | 17:57 | |
*** sgotliv has joined #openstack-manila | 17:59 | |
*** akerr has joined #openstack-manila | 17:59 | |
*** Yogi1 has joined #openstack-manila | 18:05 | |
*** jasonsb_ has quit IRC | 18:06 | |
*** sgotliv has quit IRC | 18:08 | |
*** timcl1 has quit IRC | 18:20 | |
*** merooney has joined #openstack-manila | 18:22 | |
*** zhongjun has joined #openstack-manila | 18:23 | |
*** timcl has joined #openstack-manila | 18:23 | |
*** zhongjun2 has quit IRC | 18:26 | |
*** lpetrut has joined #openstack-manila | 18:53 | |
*** lpetrut has quit IRC | 18:59 | |
*** Yogi1 has quit IRC | 19:00 | |
*** ociuhandu has quit IRC | 19:00 | |
*** merooney has quit IRC | 19:02 | |
*** martyturner has quit IRC | 19:07 | |
*** martyturner has joined #openstack-manila | 19:09 | |
*** timcl1 has joined #openstack-manila | 19:10 | |
*** timcl has quit IRC | 19:13 | |
*** a_ta has joined #openstack-manila | 19:14 | |
*** akerr has quit IRC | 19:19 | |
*** merooney has joined #openstack-manila | 19:19 | |
*** a_ta has quit IRC | 19:20 | |
*** cknight has quit IRC | 19:36 | |
*** merooney has quit IRC | 19:37 | |
*** timcl1 has quit IRC | 19:59 | |
*** martyturner has quit IRC | 20:03 | |
*** porrua has quit IRC | 20:13 | |
*** a_ta has joined #openstack-manila | 20:16 | |
openstackgerrit | Merged openstack/manila: Fix typos https://review.openstack.org/296215 | 20:18 |
*** lpetrut has joined #openstack-manila | 20:18 | |
*** a_ta has quit IRC | 20:21 | |
*** lpetrut has quit IRC | 20:31 | |
*** lpetrut has joined #openstack-manila | 20:44 | |
*** ociuhandu has joined #openstack-manila | 20:51 | |
*** david-lyle_ has joined #openstack-manila | 21:08 | |
*** david-lyle has quit IRC | 21:08 | |
*** david-lyle has joined #openstack-manila | 21:13 | |
*** david-lyle_ has quit IRC | 21:14 | |
*** lpetrut has quit IRC | 21:40 | |
*** lpetrut has joined #openstack-manila | 21:41 | |
*** gouthamr has quit IRC | 22:10 | |
*** lpetrut has quit IRC | 22:56 | |
*** merooney has joined #openstack-manila | 22:57 | |
*** merooney has quit IRC | 23:09 | |
*** dhellmann has quit IRC | 23:24 | |
*** yangyapeng has quit IRC | 23:51 | |
*** a_ta has joined #openstack-manila | 23:52 | |
*** a_ta has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!