| *** furlongm has quit IRC | 00:05 | |
| *** furlongm has joined #openstack-manila | 00:05 | |
| *** Suyi_ has quit IRC | 00:05 | |
| *** yangyapeng has quit IRC | 00:09 | |
| *** sjjfowler has joined #openstack-manila | 00:17 | |
| *** mtanin___ has joined #openstack-manila | 00:28 | |
| *** mtanino has quit IRC | 00:30 | |
| *** yangyapeng has joined #openstack-manila | 01:15 | |
| *** mtanino has joined #openstack-manila | 01:18 | |
| *** mtanin___ has quit IRC | 01:19 | |
| *** hoonetorg has quit IRC | 01:35 | |
| *** mtanino has quit IRC | 01:44 | |
| *** dsariel has quit IRC | 01:48 | |
| *** hoonetorg has joined #openstack-manila | 01:49 | |
| openstackgerrit | Yingzhe Zeng proposed openstack/manila: [WIP]Implement replication support in huawei driver https://review.openstack.org/331586 | 01:57 |
|---|---|---|
| *** catintheroof has quit IRC | 02:06 | |
| openstackgerrit | liyifeng proposed openstack/manila: Use assertEqual() instead of assertDictEqual() https://review.openstack.org/347093 | 02:10 |
| openstackgerrit | xing-yang proposed openstack/manila: Check 'thin_provisioning' in extra specs https://review.openstack.org/315266 | 02:19 |
| openstackgerrit | zhongjun proposed openstack/python-manilaclient: Add snapshot instances admin APIs https://review.openstack.org/304449 | 02:50 |
| openstackgerrit | zhongjun proposed openstack/python-manilaclient: Add snapshot instances admin APIs https://review.openstack.org/304449 | 02:54 |
| openstackgerrit | zhongjun proposed openstack/python-manilaclient: Add snapshot instances admin APIs https://review.openstack.org/304449 | 02:58 |
| *** cfey has joined #openstack-manila | 03:03 | |
| openstackgerrit | Cedric Zhuang proposed openstack/manila: Add EMC Unity Driver for Manila https://review.openstack.org/312423 | 03:27 |
| *** Suyi_ has joined #openstack-manila | 03:28 | |
| openstackgerrit | zhongjun proposed openstack/manila: Add snapshot instances admin APIs https://review.openstack.org/234658 | 03:52 |
| *** pcaruana has quit IRC | 04:34 | |
| *** yangyapeng has quit IRC | 04:37 | |
| *** yangyapeng has joined #openstack-manila | 04:42 | |
| *** yangyapeng has quit IRC | 05:24 | |
| *** lpetrut has joined #openstack-manila | 05:25 | |
| *** Suyi_ has quit IRC | 05:27 | |
| *** yangyapeng has joined #openstack-manila | 05:27 | |
| *** lpetrut has quit IRC | 06:04 | |
| *** yangyapeng has quit IRC | 06:05 | |
| *** yangyapeng has joined #openstack-manila | 06:06 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 06:13 |
| *** yangyape_ has joined #openstack-manila | 06:15 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 06:16 |
| *** yangyape_ has quit IRC | 06:16 | |
| *** yangyape_ has joined #openstack-manila | 06:16 | |
| *** yangyapeng has quit IRC | 06:16 | |
| *** lpetrut has joined #openstack-manila | 06:19 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests tests for Container driver https://review.openstack.org/347137 | 06:23 |
| *** sandanar has joined #openstack-manila | 06:24 | |
| *** cgalan has joined #openstack-manila | 06:24 | |
| openstackgerrit | zhongjun proposed openstack/manila: Add snapshot instances admin APIs https://review.openstack.org/234658 | 06:41 |
| openstackgerrit | Accela Zhao proposed openstack/python-manilaclient: Add driver private storage admin API https://review.openstack.org/336581 | 06:43 |
| *** houming has joined #openstack-manila | 06:53 | |
| *** pcaruana has joined #openstack-manila | 06:55 | |
| *** sjjfowler has quit IRC | 06:59 | |
| *** lpetrut has quit IRC | 07:02 | |
| openstackgerrit | Tina Tang proposed openstack/manila: Add retry in VNX driver when DB lock error happened https://review.openstack.org/344600 | 07:07 |
| openstackgerrit | liyifeng proposed openstack/manila: Use assertEqual() instead of assertDictEqual() https://review.openstack.org/347093 | 07:09 |
| openstackgerrit | Accela Zhao proposed openstack/manila: Remove "host" from driver private data https://review.openstack.org/339592 | 07:39 |
| *** tovchinnikova has joined #openstack-manila | 07:47 | |
| *** nherciu has joined #openstack-manila | 08:09 | |
| *** dsariel has joined #openstack-manila | 08:15 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 08:21 |
| *** lpetrut has joined #openstack-manila | 08:23 | |
| openstackgerrit | Sam Wan proposed openstack/manila: Fix wrong order bug in resource_cleanup() https://review.openstack.org/347185 | 08:27 |
| *** sandanar_ has joined #openstack-manila | 08:36 | |
| *** sandanar_ has quit IRC | 08:36 | |
| *** sandanar_ has joined #openstack-manila | 08:36 | |
| *** sandanar has quit IRC | 08:39 | |
| *** jcsp has quit IRC | 08:48 | |
| *** yangyape_ has quit IRC | 08:56 | |
| *** yangyapeng has joined #openstack-manila | 08:56 | |
| *** lpetrut has quit IRC | 09:02 | |
| *** rraja has joined #openstack-manila | 09:02 | |
| *** sandanar_ has quit IRC | 09:03 | |
| *** sandanar has joined #openstack-manila | 09:03 | |
| *** kaisers_ has joined #openstack-manila | 09:12 | |
| *** yangyapeng has quit IRC | 09:15 | |
| *** yangyapeng has joined #openstack-manila | 09:16 | |
| *** yangyape_ has joined #openstack-manila | 09:18 | |
| *** yangyapeng has quit IRC | 09:18 | |
| *** lpetrut has joined #openstack-manila | 09:21 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests tests for Container driver https://review.openstack.org/347137 | 09:21 |
| *** gouthamr_ has quit IRC | 09:29 | |
| *** nherciu has quit IRC | 09:34 | |
| *** sandanar_ has joined #openstack-manila | 09:40 | |
| *** ociuhandu has quit IRC | 09:41 | |
| *** sandanar has quit IRC | 09:43 | |
| *** yangyapeng has joined #openstack-manila | 09:51 | |
| *** yangyapeng has quit IRC | 09:51 | |
| *** yangyape_ has quit IRC | 09:51 | |
| *** yangyapeng has joined #openstack-manila | 09:52 | |
| *** sandanar__ has joined #openstack-manila | 09:52 | |
| *** sandanar_ has quit IRC | 09:55 | |
| *** ociuhandu has joined #openstack-manila | 10:00 | |
| *** jcsp has joined #openstack-manila | 10:03 | |
| *** cfey has quit IRC | 10:18 | |
| *** cfey has joined #openstack-manila | 10:19 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/manila-ui: Remove incorrect docstrings https://review.openstack.org/340843 | 10:32 |
| openstackgerrit | NidhiMittalHada proposed openstack/python-manilaclient: type-create should support specifying extra-specs https://review.openstack.org/315012 | 10:38 |
| *** sjjfowler has joined #openstack-manila | 10:41 | |
| *** nidhimittalhada has joined #openstack-manila | 11:05 | |
| openstackgerrit | Accela Zhao proposed openstack/manila: Driver private storage admin API https://review.openstack.org/315346 | 11:13 |
| openstackgerrit | Accela Zhao proposed openstack/manila: Remove "host" from driver private data https://review.openstack.org/339592 | 11:13 |
| *** yangyape_ has joined #openstack-manila | 11:27 | |
| *** yangyapeng has quit IRC | 11:30 | |
| *** yangyape_ has quit IRC | 11:31 | |
| *** yangyapeng has joined #openstack-manila | 11:33 | |
| *** alyson_ has joined #openstack-manila | 11:34 | |
| *** ganso has joined #openstack-manila | 11:43 | |
| openstackgerrit | Dinesh Bhor proposed openstack/python-manilaclient: Replace OpenStack LLC with OpenStack Foundation https://review.openstack.org/347285 | 11:43 |
| *** sandanar_ has joined #openstack-manila | 11:43 | |
| *** sandanar__ has quit IRC | 11:47 | |
| *** sandanar__ has joined #openstack-manila | 11:47 | |
| *** sandanar_ has quit IRC | 11:51 | |
| *** sandanar_ has joined #openstack-manila | 12:00 | |
| *** akapil has joined #openstack-manila | 12:01 | |
| *** rhagarty_ has quit IRC | 12:01 | |
| *** rhagarty_ has joined #openstack-manila | 12:01 | |
| *** rhagarty_ has quit IRC | 12:01 | |
| *** rhagarty_ has joined #openstack-manila | 12:01 | |
| *** rhagarty_ has quit IRC | 12:02 | |
| *** rhagarty_ has joined #openstack-manila | 12:02 | |
| *** sandanar__ has quit IRC | 12:04 | |
| *** rhagarty_ has quit IRC | 12:04 | |
| *** houming has quit IRC | 12:11 | |
| *** nidhimittalhada has quit IRC | 12:16 | |
| openstackgerrit | NidhiMittalHada proposed openstack/python-manilaclient: type-create should support specifying extra-specs https://review.openstack.org/315012 | 12:19 |
| openstackgerrit | Dinesh Bhor proposed openstack/python-manilaclient: Replace OpenStack LLC with OpenStack Foundation https://review.openstack.org/347285 | 12:21 |
| *** yangyapeng has quit IRC | 12:26 | |
| *** akapil has quit IRC | 12:33 | |
| *** gouthamr has joined #openstack-manila | 12:35 | |
| *** gouthamr has quit IRC | 12:36 | |
| *** akapil has joined #openstack-manila | 12:39 | |
| *** tpsilva has joined #openstack-manila | 12:42 | |
| *** catintheroof has joined #openstack-manila | 12:46 | |
| *** akshai has joined #openstack-manila | 12:50 | |
| *** gouthamr has joined #openstack-manila | 13:00 | |
| *** porrua has joined #openstack-manila | 13:05 | |
| *** adrianofr has joined #openstack-manila | 13:12 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/manila-ui: Fix improperly rendered Create Snapshot modal form https://review.openstack.org/342221 | 13:13 |
| *** dustins has joined #openstack-manila | 13:14 | |
| *** akerr has joined #openstack-manila | 13:16 | |
| openstackgerrit | Merged openstack/manila: share/access: allow maintenance mode to be triggered https://review.openstack.org/345370 | 13:20 |
| *** merooney has joined #openstack-manila | 13:26 | |
| *** cknight has joined #openstack-manila | 13:33 | |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Add Hitachi HSP driver https://review.openstack.org/329134 | 13:41 |
| *** timcl has joined #openstack-manila | 13:58 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/manila-ui: Remove Cinder leftovers from Create Snapshot View https://review.openstack.org/347407 | 14:01 |
| *** xyang1 has joined #openstack-manila | 14:02 | |
| *** vbellur has quit IRC | 14:06 | |
| *** dustins has quit IRC | 14:17 | |
| *** mtanino has joined #openstack-manila | 14:22 | |
| *** dustins has joined #openstack-manila | 14:23 | |
| gouthamr | tbarron: ping | 14:32 |
| tbarron | gouthamr: wazzup? | 14:32 |
| gouthamr | tbarron: hello! quick question about this patch: https://review.openstack.org/#/c/282875/ | 14:32 |
| gouthamr | tbarron: i am unable to figure out how we aren't failing on stable/liberty patches | 14:32 |
| gouthamr | tbarron: without ignoring E006 | 14:33 |
| gouthamr | tbarron: the patch merged on stable/liberty, and it failed on the NetApp CI, because of E006; i was wondering if you had any insight... :) | 14:33 |
| tbarron | dunno right off, will look but am in two meetings right now :) | 14:35 |
| tbarron | i was puzzled about this myself | 14:35 |
| tbarron | as I think i need it downstream | 14:36 |
| gouthamr | tbarron: okay, will do the cherry-pick :) thank you.. | 14:36 |
| * gouthamr and openstackgerrit ignores stable/liberty patches | 14:37 | |
| gouthamr | https://review.openstack.org/#/c/347429/ <-- tbarron | 14:37 |
| *** akapil_ has joined #openstack-manila | 14:37 | |
| *** akapil_ has quit IRC | 14:38 | |
| *** akapil has quit IRC | 14:41 | |
| *** vbellur has joined #openstack-manila | 14:45 | |
| openstackgerrit | Merged openstack/manila: Migrate API reference into tree https://review.openstack.org/313874 | 14:46 |
| *** timcl has quit IRC | 14:49 | |
| *** jokke_ has quit IRC | 14:54 | |
| *** zhonghua is now known as zhonghua-lee | 14:58 | |
| *** timcl has joined #openstack-manila | 15:08 | |
| *** MikeG451_ has joined #openstack-manila | 15:09 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DNM] Test scenario tests for ZFSonLinux driver https://review.openstack.org/347450 | 15:23 |
| *** pgbridge has joined #openstack-manila | 15:25 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DNM] Test scenario tests for ZFSonLinux driver https://review.openstack.org/347450 | 15:25 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DNM] Test scenario tests for ZFSonLinux driver https://review.openstack.org/347450 | 15:29 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix Share Migration improper behavior for drivers https://review.openstack.org/332267 | 15:40 |
| *** jcsp has quit IRC | 16:05 | |
| openstackgerrit | Merged openstack/manila-ui: Fix improperly rendered Create Snapshot modal form https://review.openstack.org/342221 | 16:06 |
| *** lpetrut has quit IRC | 16:09 | |
| *** rraja has quit IRC | 16:10 | |
| *** rraja has joined #openstack-manila | 16:12 | |
| *** huyang has quit IRC | 16:17 | |
| *** liuke has quit IRC | 16:17 | |
| *** zengyingzhe_ has quit IRC | 16:17 | |
| *** zhongjun_ has quit IRC | 16:18 | |
| *** zhonghua-lee has quit IRC | 16:18 | |
| *** porrua has quit IRC | 16:37 | |
| *** rraja has quit IRC | 16:42 | |
| vponomaryov | xyang1: ping | 16:45 |
| xyang1 | vponomaryov: hi | 16:46 |
| vponomaryov | xyang1: Hello, have you seen my answers in https://review.openstack.org/333994 ? | 16:46 |
| xyang1 | vponomaryov: I did not, I'll take a look now | 16:47 |
| vponomaryov | xyang1: thank you )) | 16:47 |
| xyang1 | vponomaryov: no problem | 16:48 |
| *** akapil has joined #openstack-manila | 16:48 | |
| *** akapil has quit IRC | 16:50 | |
| *** Suyi_ has joined #openstack-manila | 16:56 | |
| *** porrua has joined #openstack-manila | 16:56 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix Share Migration improper behavior for drivers https://review.openstack.org/332267 | 17:07 |
| *** zengyingzhe has joined #openstack-manila | 17:23 | |
| *** zhongjun_ has joined #openstack-manila | 17:23 | |
| *** zhonghua-lee has joined #openstack-manila | 17:24 | |
| *** sandanar_ has quit IRC | 17:25 | |
| ganso | gouthamr: ping | 17:30 |
| gouthamr | ganso: hey! | 17:30 |
| *** akapil has joined #openstack-manila | 17:31 | |
| ganso | gouthamr: Hi Goutham | 17:31 |
| gouthamr | ganso: hi rodrigo.. Wassup? | 17:31 |
| ganso | gouthamr: regarding https://review.openstack.org/#/c/344600/1/manila/tests/share/drivers/emc/plugins/vnx/test_object_manager.py I must be really blind because I cannot find the usage... Tina replied mentioning "StorageObjectTestCaseBase" but I am talking about the Non-Base one "StorageObjectTestCase" | 17:32 |
| ganso | gouthamr: my grep could not find it either | 17:32 |
| gouthamr | ganso: that's a unit test class.. | 17:32 |
| gouthamr | ganso: their TestCaseBase class inherits from test.TestCase | 17:33 |
| ganso | gouthamr: yes, but then this "StorageObjectTestCaseBase" inherits from "StorageObjectTestCaseBase" | 17:33 |
| gouthamr | ganso: so any class that inherits their TestCaseBase class can have unit tests that the testrunner will be able to find and execute | 17:33 |
| ganso | gouthamr: and all other classes use "StorageObjectTestCaseBase", not Non-base | 17:33 |
| gouthamr | ganso: StorageObjectTestCaseBase is the base class, they have divided their tests into StorageObjectTestCase, FileSystemTestCase, MountPointTestCase etc.. | 17:34 |
| ganso | gouthamr: oops, fixing above: "yes, but then this "StorageObjectTestCase" inherits from "StorageObjectTestCaseBase"" | 17:34 |
| ganso | gouthamr: yes, but I can't find where StorageObjectTestCase is used | 17:35 |
| gouthamr | ganso: yes... so as long as StorageObjectTestCaseBase has no tests, we should be okay | 17:35 |
| gouthamr | ganso: StorageObjectTestCaseBase can have tests of its own.. but that may turn out to be an ugly way of running tests for two separate classes.. lemme pull up an example | 17:36 |
| ganso | vponomaryov: oh I see, StorageObjectTestCase is not supposed to be inherited | 17:36 |
| *** akapil has quit IRC | 17:36 | |
| vponomaryov | ganso: O.O | 17:37 |
| ganso | vponomaryov: oops sorry | 17:37 |
| ganso | vponomaryov: lol | 17:37 |
| gouthamr | ganso: https://review.openstack.org/#/c/283494/19/manila/tests/network/neutron/test_neutron_plugin.py <-- see comment here | 17:37 |
| ganso | gouthamr: ^ | 17:37 |
| vponomaryov | ganso: since you summoned me, see this - https://review.openstack.org/#/c/333994/4/manila/share/drivers/zfsonlinux/driver.py | 17:37 |
| gouthamr | vponomaryov: lol | 17:37 |
| openstackgerrit | Merged openstack/manila: Remove "host" from driver private data https://review.openstack.org/339592 | 17:37 |
| gouthamr | ganso: yep.. | 17:38 |
| ganso | gouthamr: yea, I just noticed it has only one test, test_xml_retry | 17:38 |
| ganso | gouthamr: thanks | 17:38 |
| ganso | gouthamr: sorry to bother | 17:38 |
| vponomaryov | ganso: how long have not you been asleep? )) | 17:38 |
| openstackgerrit | Merged openstack/manila-ui: Remove Cinder leftovers from Create Snapshot View https://review.openstack.org/347407 | 17:39 |
| ganso | vponomaryov: lol | 17:39 |
| vponomaryov | captain fail )) | 17:39 |
| *** Yogi1 has joined #openstack-manila | 17:40 | |
| ganso | vponomaryov: if manage fails, don't you need to revert your private storage change? | 17:40 |
| gouthamr | ganso: np problem.. :) | 17:40 |
| vponomaryov | ganso: why? | 17:41 |
| ganso | vponomaryov: it is a new entry for that share["id"] | 17:41 |
| ganso | vponomaryov: oh nevermind, the user is going to delete and you are going to remove there | 17:41 |
| vponomaryov | ganso: also, API will not allow you to make duplication | 17:41 |
| ganso | vponomaryov: indeed, thanks | 17:46 |
| *** tovchinnikova has quit IRC | 17:50 | |
| *** timcl1 has joined #openstack-manila | 18:00 | |
| *** timcl has quit IRC | 18:00 | |
| *** cgalan has quit IRC | 18:02 | |
| openstackgerrit | Merged openstack/manila: Add share manage/unmanage of Oracle ZFSSA driver https://review.openstack.org/327897 | 18:11 |
| *** zhongjun_ has quit IRC | 18:11 | |
| *** zengyingzhe has quit IRC | 18:11 | |
| *** zhonghua-lee has quit IRC | 18:11 | |
| *** zhongjun_ has joined #openstack-manila | 18:20 | |
| *** zengyingzhe has joined #openstack-manila | 18:20 | |
| *** zhonghua-lee has joined #openstack-manila | 18:20 | |
| *** ociuhandu has quit IRC | 18:22 | |
| *** dsariel has quit IRC | 18:24 | |
| *** faiz89 has joined #openstack-manila | 18:25 | |
| *** timcl1 has quit IRC | 18:30 | |
| tpsilva | gouthamr: ping | 18:35 |
| gouthamr | tpsilva: pong | 18:35 |
| tpsilva | gouthamr: ah nvm, I was going to ask about the response codes you suggested on the mountable snapshots patch | 18:37 |
| tpsilva | gouthamr: but I already found the answer :) | 18:37 |
| tpsilva | gouthamr: thanks for the review btw! | 18:37 |
| gouthamr | tpsilva: ah.. np.. i hope i answered it *in* the review | 18:38 |
| tpsilva | gouthamr: actually I was going to say that some other requests were failing with HTTPUnprocessableEntity instead of HTTPBadRequest, but that's a child of bad request | 18:39 |
| gouthamr | tpsilva: HTTPBadRequest > HTTPUnprocessableEntity because of all the things that came in RFC 7231 does not define it.. and it was defined in others; but we should not be using it. | 18:42 |
| gouthamr | tpsilva: https://specs.openstack.org/openstack/api-wg/guidelines/http.html <-- some more detail here | 18:42 |
| tpsilva | gouthamr: oh, that's really useful | 18:43 |
| tpsilva | gouthamr: the manage/unmanage snapshots api are wrong then | 18:43 |
| tpsilva | gouthamr: I'm using some of the validation code already in there... I should probably push a bugfix for this to avoid changing this exception on this commit | 18:46 |
| *** zengyingzhe has quit IRC | 18:56 | |
| *** zengyingzhe_ has joined #openstack-manila | 18:56 | |
| gouthamr | tpsilva: yes.. there's a bunch of inconsistent APIs that we have.. we discussed this at the manila meeting last week, slightly. i'm yet to groom the bug list | 18:57 |
| tpsilva | gouthamr: is there already a bug for that? | 19:09 |
| gouthamr | tpsilva: not yet.. | 19:11 |
| tpsilva | gouthamr: I'll file one just for this case so I can fix it and rebase my patch on top of it | 19:12 |
| gouthamr | tpsilva: is this snapshot manage/unmanage APIs? | 19:12 |
| tpsilva | gouthamr: yes | 19:12 |
| gouthamr | tpsilva: cool.. link me when ur done, i'll tag it appropriately | 19:12 |
| *** zhonghua-lee has quit IRC | 19:13 | |
| *** zhonghua-lee has joined #openstack-manila | 19:14 | |
| *** timcl has joined #openstack-manila | 19:22 | |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Fix response code on snapshot manage/unmanage APIs https://review.openstack.org/347529 | 19:23 |
| tpsilva | gouthamr: ^ | 19:23 |
| gouthamr | tpsilva: thanks; tagged | 19:25 |
| *** lpetrut has joined #openstack-manila | 19:25 | |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Fix response code on snapshot manage/unmanage APIs https://review.openstack.org/347529 | 19:26 |
| gouthamr | xyang1: ping, do you have some time for questions regarding https://review.openstack.org/#/c/315266/ | 19:33 |
| xyang1 | gouthamr: sure | 19:33 |
| gouthamr | xyang1: thanks! so it seems like the solution solves the problem i raised in the bug.. but i have a concern with the way provisioned_capacity_gb works | 19:34 |
| xyang1 | gouthamr: that is reported by driver, what is your concern | 19:35 |
| gouthamr | xyang1: So, you're expecting this from drivers.. what if they can't figure it out | 19:35 |
| gouthamr | xyang1 | 19:35 |
| xyang1 | gouthamr: there is an estimation | 19:35 |
| gouthamr | ; brb | 19:35 |
| gouthamr | xyang1: sorry, got a urgent call, will ping right back. | 19:36 |
| xyang1 | ok | 19:36 |
| *** zhonghua has joined #openstack-manila | 19:36 | |
| *** zhonghua-lee has quit IRC | 19:39 | |
| *** kaisers_ has quit IRC | 19:40 | |
| *** zhongjun_ has quit IRC | 19:52 | |
| *** zhongjun_ has joined #openstack-manila | 19:52 | |
| *** akerr has quit IRC | 19:53 | |
| gouthamr | xyang1: sorry about that.. I was trying to say that provisioned_capacity_gb is something my backend cannot tell me in a straightforward way.. | 19:55 |
| gouthamr | xyang1: i feel that manila should be the source of truth for this since it knows all the share sizes.. | 19:56 |
| gouthamr | xyang1: what's the estimation? i see that the fallback to using provisioned_capacity_gb is taking allocated_capacity_gb | 19:57 |
| gouthamr | xyang1: which feels like used space to me (total capacity - free capacity) | 19:57 |
| xyang1 | gouthamr: that is not used space. manila does not know how to estimate used space. that is the sum of all shares your backend provisioned thru manila | 19:59 |
| gouthamr | xyang1: so, what's the problem with provisioned_capacity_gb being calculated by manila? | 20:01 |
| gouthamr | xyang1: s/calculated/estimated | 20:02 |
| xyang1 | gouthamr: there is an assumption backend is only used by manila and no one will create anything outside of manila | 20:03 |
| gouthamr | xyang1 : yep.. and that's what we're telling customers :) | 20:03 |
| gouthamr | xyang1: things can go wrong if these resources are shared.. | 20:03 |
| *** porrua has quit IRC | 20:04 | |
| xyang1 | gouthamr: only backend knows the whole truth. if backend does not keep track of it, there is nothing we can do | 20:04 |
| gouthamr | xyang1: hmmm.. we are expecting manila to do all the provisioning on the backend, so it feels straightforward that manila keeps all of this information... | 20:06 |
| gouthamr | xyang1: apart from allowing for the backend to be shared between processes, what other objection is there for manila to estimate this provisioned_capacity_gb | 20:07 |
| *** mtanin___ has joined #openstack-manila | 20:08 | |
| openstackgerrit | Merged openstack/manila: [ZFSonLinux] Add 'manage share' feature support https://review.openstack.org/333994 | 20:08 |
| xyang1 | gouthamr: that is it | 20:08 |
| xyang1 | gouthamr: if you don't report it, scheduler will calculate for you | 20:09 |
| *** mtanino has quit IRC | 20:09 | |
| *** akshai has quit IRC | 20:09 | |
| gouthamr | xyang1: https://github.com/openstack/manila/blob/d8fc55728958429c95635b6418d0d9c0d592af73/manila/scheduler/host_manager.py#L371 | 20:10 |
| gouthamr | xyang1: that's not calculated at the point, it defaults to 'allocated_capacity_gb' | 20:11 |
| gouthamr | xyang1: am i missing something | 20:11 |
| *** mtanino has joined #openstack-manila | 20:11 | |
| xyang1 | gouthamr: allocated capacity is calcultaed by scheduler | 20:12 |
| xyang1 | gouthamr: that is the sum of all shares created by manila | 20:12 |
| *** mtanin___ has quit IRC | 20:12 | |
| xyang1 | gouthamr: that is why it is used as default | 20:12 |
| gouthamr | xyang1: i don't see the code where it is calculated by manila | 20:13 |
| xyang1 | gouthamr: Let me check | 20:13 |
| gouthamr | xyang1: only instantiation: https://github.com/openstack/manila/blob/d8fc55728958429c95635b6418d0d9c0d592af73/manila/scheduler/host_manager.py#L361 | 20:13 |
| xyang1 | gouthamr: unless if it is not ported from cinder? | 20:14 |
| gouthamr | xyang1: :) that i'm not sure of.. lemme check | 20:14 |
| gouthamr | xyang1: https://github.com/openstack/cinder/blob/0ca7afbe9e63c30e48123350a8b6150a35c45c34/cinder/scheduler/host_manager.py#L272 | 20:15 |
| * gouthamr looks like we need a bot to diff this code once in a while and roll it over | 20:15 | |
| xyang1 | gouthamr: it is missing | 20:16 |
| bswartz | gouthamr: that used to exist and we killed it | 20:16 |
| gouthamr | bswartz: ah. | 20:16 |
| gouthamr | bswartz: any reason why? | 20:16 |
| *** timcl has quit IRC | 20:16 | |
| xyang1 | gouthamr: there is a consume_from_volume in cinder but not in manila | 20:16 |
| bswartz | well it wasn't entirely automated | 20:16 |
| gouthamr | bswartz: i didn't get you.. | 20:18 |
| *** merooney has quit IRC | 20:20 | |
| bswartz | gouthamr: there used to be a think called olso incubator which did what you wanted | 20:20 |
| bswartz | it went away because it was too much work | 20:21 |
| gouthamr | bswartz: ah yes!.. i thought you meant consume_from_volume.. | 20:21 |
| gouthamr | bswartz xyang1: so we're in agreement that manila's scheduler should calculate 'allocated_capacity_gb' if the driver does not report it? | 20:21 |
| xyang1 | gouthamr: I thought it is there, yes, I think so | 20:23 |
| *** mtanin___ has joined #openstack-manila | 20:30 | |
| *** mtanino has quit IRC | 20:32 | |
| gouthamr | xyang1: thank you.. | 20:33 |
| *** Yogi1 has quit IRC | 20:37 | |
| gouthamr | xyang1: https://bugs.launchpad.net/manila/+bug/1606691 <-- will add more content to the bug report | 20:39 |
| openstack | Launchpad bug 1606691 in Manila "manila does not calculate allocated_capacity_gb" [Undecided,New] | 20:39 |
| xyang1 | gouthamr: ok | 20:46 |
| *** catintheroof has quit IRC | 20:52 | |
| *** xyang1 has quit IRC | 21:06 | |
| openstackgerrit | Merged openstack/manila: Fix devref README and remove Makefile https://review.openstack.org/346525 | 21:07 |
| *** zhongjun_ has quit IRC | 21:08 | |
| *** zhongjun_ has joined #openstack-manila | 21:14 | |
| *** vbellur has quit IRC | 21:17 | |
| *** faiz89 has quit IRC | 21:19 | |
| *** dustins has quit IRC | 21:24 | |
| *** kaisers_ has joined #openstack-manila | 21:28 | |
| *** kaisers_ has quit IRC | 21:33 | |
| *** lpetrut has quit IRC | 21:44 | |
| *** akapil has joined #openstack-manila | 22:00 | |
| *** darrenc is now known as darrenc_afk | 22:01 | |
| *** cknight has quit IRC | 22:02 | |
| *** openstackgerrit has quit IRC | 22:03 | |
| *** openstackgerrit has joined #openstack-manila | 22:04 | |
| openstackgerrit | Mark Sturdevant proposed openstack/manila: HPE3PAR make share from snapshot writable https://review.openstack.org/337926 | 22:04 |
| openstackgerrit | Mark Sturdevant proposed openstack/manila: HPE3PAR make share from snapshot writable https://review.openstack.org/337926 | 22:21 |
| *** erlon has quit IRC | 22:26 | |
| *** darrenc_afk is now known as darrenc | 22:35 | |
| *** akapil has quit IRC | 22:38 | |
| *** tpsilva has quit IRC | 22:38 | |
| *** gouthamr has quit IRC | 22:45 | |
| *** openstackgerrit has quit IRC | 22:48 | |
| *** openstackgerrit has joined #openstack-manila | 22:49 | |
| *** sjjfowler has quit IRC | 22:59 | |
| *** cknight has joined #openstack-manila | 23:14 | |
| *** kaisers_ has joined #openstack-manila | 23:17 | |
| *** kaisers_ has quit IRC | 23:22 | |
| *** merooney has joined #openstack-manila | 23:35 | |
| *** merooney has quit IRC | 23:45 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!