*** akerr_ has joined #openstack-manila | 00:01 | |
*** akerr has quit IRC | 00:05 | |
*** yangyapeng has quit IRC | 00:06 | |
*** Suyi has quit IRC | 00:08 | |
openstackgerrit | Sam Wan proposed openstack/manila: TrivialFix: Fix a wrong order bug in resource_cleanup() https://review.openstack.org/347185 | 00:25 |
---|---|---|
*** ganso has quit IRC | 00:31 | |
*** ganso has joined #openstack-manila | 00:36 | |
*** mtanino has joined #openstack-manila | 00:55 | |
*** xyang_ has joined #openstack-manila | 01:02 | |
openstackgerrit | zhongjun proposed openstack/manila: Add snapshot instances admin APIs https://review.openstack.org/234658 | 01:04 |
*** xyang_ has quit IRC | 01:05 | |
*** chlong has joined #openstack-manila | 01:06 | |
*** gouthamr has joined #openstack-manila | 01:08 | |
*** yangyapeng has joined #openstack-manila | 01:16 | |
*** sjjfowler has joined #openstack-manila | 01:23 | |
*** xyang_ has joined #openstack-manila | 01:36 | |
*** faiz89 has joined #openstack-manila | 01:38 | |
*** faiz891 has joined #openstack-manila | 01:42 | |
*** faiz89 has quit IRC | 01:42 | |
*** faiz89 has joined #openstack-manila | 01:43 | |
*** xyang_ has quit IRC | 01:43 | |
*** faiz891 has quit IRC | 01:46 | |
*** xyang_ has joined #openstack-manila | 01:47 | |
*** xyang_ has quit IRC | 01:47 | |
*** yangyape_ has joined #openstack-manila | 01:48 | |
*** yangyapeng has quit IRC | 01:49 | |
*** yangyapeng has joined #openstack-manila | 01:52 | |
*** yangyape_ has quit IRC | 01:57 | |
*** akerr_ has quit IRC | 02:10 | |
openstackgerrit | zhongjun proposed openstack/manila: Add snapshot instances admin APIs https://review.openstack.org/234658 | 02:30 |
*** MikeG451 has quit IRC | 02:37 | |
*** MikeG451 has joined #openstack-manila | 02:52 | |
*** faiz89 has quit IRC | 02:54 | |
*** gouthamr_ has joined #openstack-manila | 02:55 | |
*** gouthamr has quit IRC | 02:59 | |
*** gouthamr_ has quit IRC | 03:10 | |
*** gouthamr has joined #openstack-manila | 03:14 | |
*** vbellur has joined #openstack-manila | 03:33 | |
*** mtanino has quit IRC | 03:39 | |
*** sandanar has joined #openstack-manila | 03:40 | |
*** bill_az has quit IRC | 03:49 | |
*** yangyape_ has joined #openstack-manila | 03:50 | |
*** yangyapeng has quit IRC | 03:54 | |
*** bill_az has joined #openstack-manila | 04:01 | |
*** gouthamr has quit IRC | 04:32 | |
*** shausy has joined #openstack-manila | 04:39 | |
*** bill_az has quit IRC | 04:44 | |
*** sandanar has quit IRC | 05:16 | |
*** ganso has quit IRC | 05:21 | |
*** yangyape_ has quit IRC | 05:36 | |
openstackgerrit | Cedric Zhuang proposed openstack/manila: Add EMC Unity Driver for Manila https://review.openstack.org/312423 | 05:41 |
*** yangyapeng has joined #openstack-manila | 05:45 | |
*** yangyape_ has joined #openstack-manila | 05:52 | |
*** yangyapeng has quit IRC | 05:56 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 06:13 |
*** pcaruana has joined #openstack-manila | 06:17 | |
*** tovchinnikova has joined #openstack-manila | 06:18 | |
*** nkrinner_afk is now known as nkrinner | 06:19 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 06:20 |
openstackgerrit | Silvan Kaiser proposed openstack/manila: Replaces httplib with requests lib in Quobyte RPC layer https://review.openstack.org/345219 | 06:31 |
*** sandanar has joined #openstack-manila | 06:33 | |
*** dsariel has joined #openstack-manila | 06:45 | |
*** nherciu has joined #openstack-manila | 07:00 | |
*** nidhimittalhada has joined #openstack-manila | 07:07 | |
*** permalac has joined #openstack-manila | 07:13 | |
*** sjjfowler has quit IRC | 07:18 | |
*** yangyape_ has quit IRC | 07:18 | |
*** akapil has joined #openstack-manila | 07:23 | |
*** akapil has quit IRC | 07:25 | |
*** akapil has joined #openstack-manila | 07:25 | |
openstackgerrit | NidhiMittalHada proposed openstack/manila: Unary operator used with NoneType https://review.openstack.org/348160 | 07:35 |
*** yangyapeng has joined #openstack-manila | 07:45 | |
*** chlong has quit IRC | 07:47 | |
*** yangyape_ has joined #openstack-manila | 07:50 | |
*** yangyapeng has quit IRC | 07:51 | |
*** rraja has joined #openstack-manila | 08:11 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 08:17 |
*** permalac has quit IRC | 08:26 | |
*** permalac has joined #openstack-manila | 08:26 | |
*** zhongjun_ has quit IRC | 08:36 | |
*** zhongjun_ has joined #openstack-manila | 08:36 | |
openstackgerrit | zhongjun proposed openstack/manila: Add snapshot instances admin APIs https://review.openstack.org/234658 | 08:39 |
*** gouthamr has joined #openstack-manila | 09:04 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 09:04 |
*** sjjfowler has joined #openstack-manila | 09:07 | |
openstackgerrit | zhongjun proposed openstack/manila: Add snapshot instances admin APIs https://review.openstack.org/234658 | 09:09 |
zhongjun_ | gouthamr: ping | 09:22 |
gouthamr | zhongjun_: hi | 09:22 |
zhongjun_ | gouthamr: about snapshot instances code | 09:22 |
gouthamr | zhongjun_ | 09:22 |
zhongjun_ | gouthamr: If I add following code in get_instances function. Is it ok? | 09:23 |
zhongjun_ | gouthamr: try: | 09:23 |
zhongjun_ | db.share_snapshot_get(context, snapshot_id) | 09:23 |
zhongjun_ | except exception.NotFound: | 09:23 |
zhongjun_ | msg = _("Snapshot ID %s not found.") % snapshot_id | 09:23 |
zhongjun_ | raise exc.HTTPNotFound(explanation=msg) | 09:23 |
gouthamr | zhongjun_: you should be raising HTTPBadRequest | 09:24 |
zhongjun_ | gouthamr: like https://github.com/openstack/manila/blob/master/manila/api/v2/share_replicas.py#L72 | 09:24 |
zhongjun_ | gouthamr: why we need raising HTTPBadRequest | 09:25 |
gouthamr | zhongjun_: don't use that example.. :( | 09:25 |
*** permalac has quit IRC | 09:25 | |
gouthamr | zhongjun_: HTTPNotFound is when the server cannot find a resource that is specified in the URI.. | 09:26 |
zhongjun_ | gouthamr: :) | 09:26 |
zhongjun_ | gouthamr: but I saw most of the places is return HTTPNotFound | 09:27 |
gouthamr | zhongjun_: let me check and get back to you on that.. | 09:28 |
zhongjun_ | gouthamr: thanks | 09:30 |
gouthamr | zhongjun_: responded in the review. thanks for checking! | 09:48 |
zhongjun_ | gouthamr: thanks for responded in the review. | 09:52 |
nidhimittalhada | @gouthamr: https://review.openstack.org/#/c/348160/ a very small change for quick review .. | 09:55 |
gouthamr | zhongjun_: you're welcome | 09:56 |
gouthamr | nidhimittalhada: sure. | 09:56 |
nidhimittalhada | @gouthamr: thnks | 09:56 |
nidhimittalhada | @ganso @vponomaryov @zhongjun @gouthamr https://review.openstack.org/315012 for review please | 09:58 |
*** ociuhandu has joined #openstack-manila | 10:01 | |
zhongjun_ | nidhimittalhada: ok | 10:01 |
*** liyifeng has joined #openstack-manila | 10:23 | |
*** Dinesh_Bhor has joined #openstack-manila | 10:26 | |
Dinesh_Bhor | Hi, Can someone from the core please take a look at it ? https://review.openstack.org/#/c/347285/ | 10:29 |
*** akapil has quit IRC | 10:29 | |
*** yangyape_ has quit IRC | 10:30 | |
*** akapil has joined #openstack-manila | 10:50 | |
*** akapil has quit IRC | 10:54 | |
*** shausy has quit IRC | 11:00 | |
*** akapil has joined #openstack-manila | 11:10 | |
*** ganso has joined #openstack-manila | 11:20 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 11:41 |
*** gouthamr has quit IRC | 11:44 | |
*** tovchinnikova has quit IRC | 11:54 | |
*** tovchinnikova has joined #openstack-manila | 11:55 | |
*** chlong has joined #openstack-manila | 11:55 | |
*** hoonetorg has quit IRC | 11:56 | |
*** nidhimittalhada has quit IRC | 12:09 | |
*** yangyapeng has joined #openstack-manila | 12:11 | |
*** mtanino has joined #openstack-manila | 12:12 | |
*** yangyapeng has quit IRC | 12:13 | |
*** yangyapeng has joined #openstack-manila | 12:13 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Dummy driver] Add share migration support https://review.openstack.org/347853 | 12:22 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix Share Migration improper behavior for drivers https://review.openstack.org/332267 | 12:24 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Testing, please do not merge me https://review.openstack.org/348276 | 12:24 |
*** hoonetorg has joined #openstack-manila | 12:27 | |
*** akapil has quit IRC | 12:28 | |
*** dustins has joined #openstack-manila | 12:29 | |
*** tpsilva has joined #openstack-manila | 12:34 | |
*** akapil has joined #openstack-manila | 12:37 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 12:40 |
*** akerr has joined #openstack-manila | 12:51 | |
*** cknight has joined #openstack-manila | 12:55 | |
ganso | zhongjun_: ping | 13:12 |
*** sjjfowler has quit IRC | 13:13 | |
ganso | vponomaryov: ping | 13:14 |
*** yangyape_ has joined #openstack-manila | 13:16 | |
*** yangyapeng has quit IRC | 13:17 | |
*** yangyapeng has joined #openstack-manila | 13:17 | |
vponomaryov | ganso: pong | 13:17 |
*** akshai has joined #openstack-manila | 13:18 | |
ganso | vponomaryov: I noticed that ZFS CI passed on your dummy driver migration patch, which is dependent on mine | 13:18 |
ganso | vponomaryov: so it is a race condition | 13:18 |
ganso | vponomaryov: it is not related to code logic | 13:18 |
vponomaryov | ganso: you mean that "acceess rule removal" bug? | 13:18 |
ganso | vponomaryov: yes | 13:18 |
vponomaryov | ganso: my point was in mentioning bug that is not fixed | 13:19 |
ganso | vponomaryov: you are probably misinterpreting the bug | 13:19 |
vponomaryov | which one? | 13:19 |
ganso | vponomaryov: the access rule one | 13:19 |
vponomaryov | ganso: Rodrigo, I filed it | 13:19 |
*** vbellur has quit IRC | 13:20 | |
*** yangyape_ has quit IRC | 13:20 | |
vponomaryov | ganso: so, who is likely misinterpretin git? )) | 13:20 |
ganso | vponomaryov: unless Goutham misinterpreted and believed to be fixing that bug with my implementation, which he suggested me to add the closes-bug tag | 13:20 |
*** faiz89 has joined #openstack-manila | 13:20 | |
zhongjun_ | ganso: hi | 13:21 |
vponomaryov | ganso: we have fact - it is not fixed | 13:21 |
vponomaryov | ganso; so, just remove its mentioning | 13:21 |
ganso | vponomaryov: anyway, I will try adding a lock, if it does not fix, I will remove the closes-bug tag, because it was not my intention in the first place, and Goutham possibly confused it with something else I was fixing | 13:21 |
*** bill_az has joined #openstack-manila | 13:21 | |
*** yangyape_ has joined #openstack-manila | 13:22 | |
ganso | zhongjun_: hi ZhongJun, could you please explain better your comment in LN 692 for this patch? https://review.openstack.org/#/c/328437/ | 13:22 |
ganso | zhongjun_: I did not understand what you meant | 13:22 |
*** gouthamr has joined #openstack-manila | 13:22 | |
zhongjun_ | ganso: It means we could remove @api_versions.wraps("2.19") | 13:23 |
*** yangyap__ has joined #openstack-manila | 13:24 | |
ganso | zhongjun_: oh you mean it blocks 2.15-2.18? | 13:25 |
*** yangyapeng has quit IRC | 13:25 | |
zhongjun_ | ganso: yes | 13:26 |
ganso | zhongjun_: but if I do that, a client that is using 2.18 will see preserve-metadata and writable | 13:26 |
ganso | zhongjun_: won't it? | 13:26 |
vponomaryov | ganso: you can answer it yourself looking at https://review.openstack.org/#/c/328437/10/manilaclient/v2/shares.py | 13:27 |
ganso | vponomaryov: I am not sure if the user types 'manila help migration-start' will check the microversion in shares.py or shell.py | 13:28 |
*** timcl has joined #openstack-manila | 13:28 | |
ganso | vponomaryov: I know that if he uses a command, the shares.py microversion will block | 13:28 |
ganso | vponomaryov: but I am not sure about the help command | 13:28 |
*** yangyape_ has quit IRC | 13:29 | |
vponomaryov | ganso: note microversions in help messages explicitly | 13:29 |
*** Dinesh_Bhor has quit IRC | 13:30 | |
vponomaryov | ganso: like "--foo provides foo thing (available since 2.19)" | 13:30 |
ganso | vponomaryov: I wish I could avoid that whenever possible | 13:31 |
*** yangyapeng has joined #openstack-manila | 13:31 | |
vponomaryov | ganso: you can contribute for implementation of versioned help messages | 13:31 |
vponomaryov | (: | 13:31 |
vponomaryov | ganso: make this world better! | 13:32 |
ganso | zhongjun_: indeed it blocks, but indeed it shows preserve-metadata and writable... I will add the microversion to the help text | 13:32 |
ganso | vponomaryov: lol sure, for ocata? :) | 13:33 |
vponomaryov | ganso: as you wish | 13:33 |
*** porrua has joined #openstack-manila | 13:33 | |
*** yangyap__ has quit IRC | 13:34 | |
*** Dinesh_Bhor has joined #openstack-manila | 13:35 | |
*** gouthamr has quit IRC | 13:36 | |
zhongjun_ | ganso: It will be good, if not blocks 2.15-2.18 and show the right text to user. | 13:36 |
openstackgerrit | Accela Zhao proposed openstack/python-manilaclient: Add driver private storage admin API https://review.openstack.org/336581 | 13:38 |
*** merooney has joined #openstack-manila | 13:39 | |
openstackgerrit | zhongjun proposed openstack/manila: Add snapshot instances admin APIs https://review.openstack.org/234658 | 13:47 |
*** gouthamr has joined #openstack-manila | 13:51 | |
*** vbellur has joined #openstack-manila | 13:53 | |
*** dsariel has quit IRC | 13:54 | |
*** dustins has quit IRC | 13:55 | |
openstackgerrit | Silvan Kaiser proposed openstack/manila: Replaces httplib with requests lib in Quobyte RPC layer https://review.openstack.org/345219 | 14:05 |
gouthamr | kaisers: dictionary wrapping http://docs.openstack.org/developer/hacking/#dictionaries-lists https://review.openstack.org/#/c/345219/9..10/manila/share/drivers/quobyte/jsonrpc.py | 14:06 |
openstackgerrit | Merged openstack/manila: TrivialFix: Fix a wrong order bug in resource_cleanup() https://review.openstack.org/347185 | 14:07 |
mkoderer | ganso: https://review.openstack.org/#/c/346680/ - jenkins is through ;) | 14:12 |
openstackgerrit | Alyson proposed openstack/manila: Add support for CIFS shares in HNAS driver https://review.openstack.org/342960 | 14:16 |
*** akapil has quit IRC | 14:25 | |
*** xyang1 has joined #openstack-manila | 14:27 | |
*** dsariel has joined #openstack-manila | 14:30 | |
*** vbellur has quit IRC | 14:30 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Try delete resources in cleanup only once https://review.openstack.org/306332 | 14:32 |
*** yangyape_ has joined #openstack-manila | 14:34 | |
*** yangyapeng has quit IRC | 14:34 | |
*** akapil has joined #openstack-manila | 14:38 | |
*** aovchinnikov has joined #openstack-manila | 14:43 | |
*** vbellur has joined #openstack-manila | 14:46 | |
*** akapil_ has joined #openstack-manila | 14:56 | |
*** akapil_ has quit IRC | 14:57 | |
*** dustins has joined #openstack-manila | 14:58 | |
*** akapil has quit IRC | 15:00 | |
*** openstackgerrit has quit IRC | 15:18 | |
*** openstackgerrit has joined #openstack-manila | 15:19 | |
*** xyang has joined #openstack-manila | 15:21 | |
*** pcaruana has quit IRC | 15:22 | |
*** nkrinner is now known as nkrinner_afk | 15:23 | |
rraja | bswartz: can you help merge this useful mitaka backport, https://review.openstack.org/#/c/347413/ ? | 15:25 |
*** rraja has quit IRC | 15:27 | |
openstackgerrit | Accela Zhao proposed openstack/python-manilaclient: Add driver private storage admin API https://review.openstack.org/336581 | 15:34 |
*** alyson_ has quit IRC | 15:53 | |
*** mtanino has quit IRC | 15:54 | |
*** dsariel has quit IRC | 15:57 | |
*** faiz89 has quit IRC | 16:01 | |
*** akapil has joined #openstack-manila | 16:01 | |
*** xyang has quit IRC | 16:08 | |
*** xyang has joined #openstack-manila | 16:10 | |
*** vbellur has quit IRC | 16:20 | |
*** xyang has quit IRC | 16:21 | |
*** dsariel has joined #openstack-manila | 16:28 | |
*** akapil has quit IRC | 16:30 | |
*** vbellur has joined #openstack-manila | 16:35 | |
*** dustins has quit IRC | 16:36 | |
*** dustins has joined #openstack-manila | 16:40 | |
openstackgerrit | zhongjun proposed openstack/manila: Add snapshot instances admin APIs https://review.openstack.org/234658 | 16:41 |
*** mtanino has joined #openstack-manila | 16:45 | |
*** faiz89 has joined #openstack-manila | 16:48 | |
*** tovchinnikova has quit IRC | 16:55 | |
*** faiz89 has quit IRC | 16:58 | |
*** faiz89 has joined #openstack-manila | 17:01 | |
*** akshai has quit IRC | 17:10 | |
*** akshai has joined #openstack-manila | 17:12 | |
openstackgerrit | Accela Zhao proposed openstack/manila: Driver private storage admin API https://review.openstack.org/315346 | 17:18 |
*** nherciu has quit IRC | 17:19 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 17:22 |
*** aovchinnikov has quit IRC | 17:29 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share migration Newton improvements https://review.openstack.org/328431 | 17:38 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix Share Migration improper behavior for drivers https://review.openstack.org/332267 | 17:38 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Base Data Copy changes https://review.openstack.org/329174 | 17:38 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Driver Data Service Helper https://review.openstack.org/295836 | 17:38 |
*** alyson_ has joined #openstack-manila | 17:38 | |
*** akshai has quit IRC | 17:39 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration https://review.openstack.org/345142 | 17:39 |
*** JoseMello has joined #openstack-manila | 17:42 | |
*** akshai has joined #openstack-manila | 17:47 | |
*** akshai has quit IRC | 18:00 | |
*** akshai has joined #openstack-manila | 18:01 | |
*** Suyi_ has joined #openstack-manila | 18:02 | |
*** sandanar has quit IRC | 18:09 | |
*** faiz89 has quit IRC | 18:11 | |
*** ociuhandu has quit IRC | 18:14 | |
*** faiz89 has joined #openstack-manila | 18:15 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Update Share Migration CLI https://review.openstack.org/328437 | 18:24 |
openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Add share type change to Share Migration CLI https://review.openstack.org/345125 | 18:24 |
*** faiz89 has quit IRC | 18:29 | |
*** catintheroof has joined #openstack-manila | 18:34 | |
*** ociuhandu has joined #openstack-manila | 18:44 | |
*** dsariel has quit IRC | 18:51 | |
*** timcl has quit IRC | 19:01 | |
*** akshai has quit IRC | 19:02 | |
*** gouthamr has quit IRC | 19:10 | |
*** dsariel has joined #openstack-manila | 19:31 | |
*** akerr has quit IRC | 19:53 | |
*** JoseMello has quit IRC | 20:10 | |
*** merooney has quit IRC | 20:14 | |
*** porrua has quit IRC | 20:26 | |
openstackgerrit | Alyson proposed openstack/manila: Add support for CIFS shares in HNAS driver https://review.openstack.org/342960 | 20:55 |
*** vbellur has quit IRC | 20:56 | |
*** mtanino has quit IRC | 21:08 | |
*** dsariel has quit IRC | 21:23 | |
*** xyang1 has quit IRC | 21:33 | |
*** porrua has joined #openstack-manila | 21:41 | |
openstackgerrit | Clinton Knight proposed openstack/manila: Implement share revert to snapshot https://review.openstack.org/340502 | 21:47 |
*** gouthamr has joined #openstack-manila | 21:54 | |
openstackgerrit | Clinton Knight proposed openstack/python-manilaclient: Support share revert to snapshot in Manila client https://review.openstack.org/340556 | 22:09 |
*** porrua has quit IRC | 22:16 | |
*** gouthamr_ has joined #openstack-manila | 22:16 | |
*** gouthamr has quit IRC | 22:19 | |
*** dustins has quit IRC | 22:45 | |
*** sjjfowler has joined #openstack-manila | 23:02 | |
*** zhonghua-lee has quit IRC | 23:02 | |
*** alyson_ has quit IRC | 23:03 | |
*** zhonghua-lee has joined #openstack-manila | 23:03 | |
*** tpsilva has quit IRC | 23:08 | |
openstackgerrit | Clinton Knight proposed openstack/python-manilaclient: Support share revert to snapshot in Manila client https://review.openstack.org/340556 | 23:16 |
openstackgerrit | Clinton Knight proposed openstack/manila: Implement share revert to snapshot https://review.openstack.org/340502 | 23:18 |
*** akapil has joined #openstack-manila | 23:21 | |
*** cknight has quit IRC | 23:30 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!