Thursday, 2016-07-28

*** akerr_ has joined #openstack-manila00:01
*** akerr has quit IRC00:05
*** yangyapeng has quit IRC00:06
*** Suyi has quit IRC00:08
openstackgerritSam Wan proposed openstack/manila: TrivialFix: Fix a wrong order bug in resource_cleanup()  https://review.openstack.org/34718500:25
*** ganso has quit IRC00:31
*** ganso has joined #openstack-manila00:36
*** mtanino has joined #openstack-manila00:55
*** xyang_ has joined #openstack-manila01:02
openstackgerritzhongjun proposed openstack/manila: Add snapshot instances admin APIs  https://review.openstack.org/23465801:04
*** xyang_ has quit IRC01:05
*** chlong has joined #openstack-manila01:06
*** gouthamr has joined #openstack-manila01:08
*** yangyapeng has joined #openstack-manila01:16
*** sjjfowler has joined #openstack-manila01:23
*** xyang_ has joined #openstack-manila01:36
*** faiz89 has joined #openstack-manila01:38
*** faiz891 has joined #openstack-manila01:42
*** faiz89 has quit IRC01:42
*** faiz89 has joined #openstack-manila01:43
*** xyang_ has quit IRC01:43
*** faiz891 has quit IRC01:46
*** xyang_ has joined #openstack-manila01:47
*** xyang_ has quit IRC01:47
*** yangyape_ has joined #openstack-manila01:48
*** yangyapeng has quit IRC01:49
*** yangyapeng has joined #openstack-manila01:52
*** yangyape_ has quit IRC01:57
*** akerr_ has quit IRC02:10
openstackgerritzhongjun proposed openstack/manila: Add snapshot instances admin APIs  https://review.openstack.org/23465802:30
*** MikeG451 has quit IRC02:37
*** MikeG451 has joined #openstack-manila02:52
*** faiz89 has quit IRC02:54
*** gouthamr_ has joined #openstack-manila02:55
*** gouthamr has quit IRC02:59
*** gouthamr_ has quit IRC03:10
*** gouthamr has joined #openstack-manila03:14
*** vbellur has joined #openstack-manila03:33
*** mtanino has quit IRC03:39
*** sandanar has joined #openstack-manila03:40
*** bill_az has quit IRC03:49
*** yangyape_ has joined #openstack-manila03:50
*** yangyapeng has quit IRC03:54
*** bill_az has joined #openstack-manila04:01
*** gouthamr has quit IRC04:32
*** shausy has joined #openstack-manila04:39
*** bill_az has quit IRC04:44
*** sandanar has quit IRC05:16
*** ganso has quit IRC05:21
*** yangyape_ has quit IRC05:36
openstackgerritCedric Zhuang proposed openstack/manila: Add EMC Unity Driver for Manila  https://review.openstack.org/31242305:41
*** yangyapeng has joined #openstack-manila05:45
*** yangyape_ has joined #openstack-manila05:52
*** yangyapeng has quit IRC05:56
openstackgerritAlexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests  https://review.openstack.org/34023606:13
*** pcaruana has joined #openstack-manila06:17
*** tovchinnikova has joined #openstack-manila06:18
*** nkrinner_afk is now known as nkrinner06:19
openstackgerritAlexey Ovchinnikov proposed openstack/manila: Container driver  https://review.openstack.org/30893006:20
openstackgerritSilvan Kaiser proposed openstack/manila: Replaces httplib with requests lib in Quobyte RPC layer  https://review.openstack.org/34521906:31
*** sandanar has joined #openstack-manila06:33
*** dsariel has joined #openstack-manila06:45
*** nherciu has joined #openstack-manila07:00
*** nidhimittalhada has joined #openstack-manila07:07
*** permalac has joined #openstack-manila07:13
*** sjjfowler has quit IRC07:18
*** yangyape_ has quit IRC07:18
*** akapil has joined #openstack-manila07:23
*** akapil has quit IRC07:25
*** akapil has joined #openstack-manila07:25
openstackgerritNidhiMittalHada proposed openstack/manila: Unary operator used with NoneType  https://review.openstack.org/34816007:35
*** yangyapeng has joined #openstack-manila07:45
*** chlong has quit IRC07:47
*** yangyape_ has joined #openstack-manila07:50
*** yangyapeng has quit IRC07:51
*** rraja has joined #openstack-manila08:11
openstackgerritAlexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests  https://review.openstack.org/34023608:17
*** permalac has quit IRC08:26
*** permalac has joined #openstack-manila08:26
*** zhongjun_ has quit IRC08:36
*** zhongjun_ has joined #openstack-manila08:36
openstackgerritzhongjun proposed openstack/manila: Add snapshot instances admin APIs  https://review.openstack.org/23465808:39
*** gouthamr has joined #openstack-manila09:04
openstackgerritAlexey Ovchinnikov proposed openstack/manila: Container driver  https://review.openstack.org/30893009:04
*** sjjfowler has joined #openstack-manila09:07
openstackgerritzhongjun proposed openstack/manila: Add snapshot instances admin APIs  https://review.openstack.org/23465809:09
zhongjun_gouthamr: ping09:22
gouthamrzhongjun_: hi09:22
zhongjun_gouthamr: about snapshot instances code09:22
gouthamrzhongjun_09:22
zhongjun_gouthamr: If I add following code in get_instances function. Is it ok?09:23
zhongjun_gouthamr: try:09:23
zhongjun_    db.share_snapshot_get(context, snapshot_id)09:23
zhongjun_except exception.NotFound:09:23
zhongjun_    msg = _("Snapshot ID %s not found.") % snapshot_id09:23
zhongjun_    raise exc.HTTPNotFound(explanation=msg)09:23
gouthamrzhongjun_: you should be raising HTTPBadRequest09:24
zhongjun_gouthamr: like https://github.com/openstack/manila/blob/master/manila/api/v2/share_replicas.py#L7209:24
zhongjun_gouthamr: why we need raising HTTPBadRequest09:25
gouthamrzhongjun_: don't use that example.. :(09:25
*** permalac has quit IRC09:25
gouthamrzhongjun_: HTTPNotFound is when the server cannot find a resource that is specified in the URI..09:26
zhongjun_ gouthamr: :)09:26
zhongjun_ gouthamr: but I saw most of the places is return HTTPNotFound09:27
gouthamrzhongjun_: let me check and get back to you on that..09:28
zhongjun_gouthamr: thanks09:30
gouthamrzhongjun_: responded in the review. thanks for checking!09:48
zhongjun_gouthamr: thanks for responded in the review.09:52
nidhimittalhada@gouthamr: https://review.openstack.org/#/c/348160/ a very small change for quick review ..09:55
gouthamrzhongjun_: you're welcome09:56
gouthamrnidhimittalhada: sure.09:56
nidhimittalhada@gouthamr: thnks09:56
nidhimittalhada@ganso @vponomaryov @zhongjun @gouthamr   https://review.openstack.org/315012  for review please09:58
*** ociuhandu has joined #openstack-manila10:01
zhongjun_nidhimittalhada: ok10:01
*** liyifeng has joined #openstack-manila10:23
*** Dinesh_Bhor has joined #openstack-manila10:26
Dinesh_BhorHi, Can someone from the core please take a look at it ? https://review.openstack.org/#/c/347285/10:29
*** akapil has quit IRC10:29
*** yangyape_ has quit IRC10:30
*** akapil has joined #openstack-manila10:50
*** akapil has quit IRC10:54
*** shausy has quit IRC11:00
*** akapil has joined #openstack-manila11:10
*** ganso has joined #openstack-manila11:20
openstackgerritAlexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests  https://review.openstack.org/34023611:41
*** gouthamr has quit IRC11:44
*** tovchinnikova has quit IRC11:54
*** tovchinnikova has joined #openstack-manila11:55
*** chlong has joined #openstack-manila11:55
*** hoonetorg has quit IRC11:56
*** nidhimittalhada has quit IRC12:09
*** yangyapeng has joined #openstack-manila12:11
*** mtanino has joined #openstack-manila12:12
*** yangyapeng has quit IRC12:13
*** yangyapeng has joined #openstack-manila12:13
openstackgerritValeriy Ponomaryov proposed openstack/manila: [Dummy driver] Add share migration support  https://review.openstack.org/34785312:22
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix Share Migration improper behavior for drivers  https://review.openstack.org/33226712:24
openstackgerritRodrigo Barbieri proposed openstack/manila: Testing, please do not merge me  https://review.openstack.org/34827612:24
*** hoonetorg has joined #openstack-manila12:27
*** akapil has quit IRC12:28
*** dustins has joined #openstack-manila12:29
*** tpsilva has joined #openstack-manila12:34
*** akapil has joined #openstack-manila12:37
openstackgerritAlexey Ovchinnikov proposed openstack/manila: Container driver  https://review.openstack.org/30893012:40
*** akerr has joined #openstack-manila12:51
*** cknight has joined #openstack-manila12:55
gansozhongjun_: ping13:12
*** sjjfowler has quit IRC13:13
gansovponomaryov: ping13:14
*** yangyape_ has joined #openstack-manila13:16
*** yangyapeng has quit IRC13:17
*** yangyapeng has joined #openstack-manila13:17
vponomaryovganso: pong13:17
*** akshai has joined #openstack-manila13:18
gansovponomaryov: I noticed that ZFS CI passed on your dummy driver migration patch, which is dependent on mine13:18
gansovponomaryov: so it is a race condition13:18
gansovponomaryov: it is not related to code logic13:18
vponomaryovganso: you mean that "acceess rule removal" bug?13:18
gansovponomaryov: yes13:18
vponomaryovganso: my point was in mentioning bug that is not fixed13:19
gansovponomaryov: you are probably misinterpreting the bug13:19
vponomaryovwhich one?13:19
gansovponomaryov: the access rule one13:19
vponomaryovganso: Rodrigo, I filed it13:19
*** vbellur has quit IRC13:20
*** yangyape_ has quit IRC13:20
vponomaryovganso: so, who is likely misinterpretin git? ))13:20
gansovponomaryov: unless Goutham misinterpreted and believed to be fixing that bug with my implementation, which he suggested me to add the closes-bug tag13:20
*** faiz89 has joined #openstack-manila13:20
zhongjun_ganso: hi13:21
vponomaryovganso: we have fact - it is not fixed13:21
vponomaryovganso; so, just remove its mentioning13:21
gansovponomaryov: anyway, I will try adding a lock, if it does not fix, I will remove the closes-bug tag, because it was not my intention in the first place, and Goutham possibly confused it with something else I was fixing13:21
*** bill_az has joined #openstack-manila13:21
*** yangyape_ has joined #openstack-manila13:22
gansozhongjun_: hi ZhongJun, could you please explain better your comment in LN 692 for this patch? https://review.openstack.org/#/c/328437/13:22
gansozhongjun_: I did not understand what you meant13:22
*** gouthamr has joined #openstack-manila13:22
zhongjun_ganso: It means we could remove @api_versions.wraps("2.19")13:23
*** yangyap__ has joined #openstack-manila13:24
gansozhongjun_: oh you mean it blocks 2.15-2.18?13:25
*** yangyapeng has quit IRC13:25
zhongjun_ganso: yes13:26
gansozhongjun_: but if I do that, a client that is using 2.18 will see preserve-metadata and writable13:26
gansozhongjun_: won't it?13:26
vponomaryovganso: you can answer it yourself looking at https://review.openstack.org/#/c/328437/10/manilaclient/v2/shares.py13:27
gansovponomaryov: I am not sure if the user types 'manila help migration-start' will check the microversion in shares.py or shell.py13:28
*** timcl has joined #openstack-manila13:28
gansovponomaryov: I know that if he uses a command, the shares.py microversion will block13:28
gansovponomaryov: but I am not sure about the help command13:28
*** yangyape_ has quit IRC13:29
vponomaryovganso: note microversions in help messages explicitly13:29
*** Dinesh_Bhor has quit IRC13:30
vponomaryovganso: like "--foo provides foo thing (available since 2.19)"13:30
gansovponomaryov: I wish I could avoid that whenever possible13:31
*** yangyapeng has joined #openstack-manila13:31
vponomaryovganso: you can contribute for implementation of versioned help messages13:31
vponomaryov(:13:31
vponomaryovganso: make this world better!13:32
gansozhongjun_: indeed it blocks, but indeed it shows preserve-metadata and writable... I will add the microversion to the help text13:32
gansovponomaryov: lol sure, for ocata? :)13:33
vponomaryovganso: as you wish13:33
*** porrua has joined #openstack-manila13:33
*** yangyap__ has quit IRC13:34
*** Dinesh_Bhor has joined #openstack-manila13:35
*** gouthamr has quit IRC13:36
zhongjun_ganso: It will be good, if not blocks 2.15-2.18 and show the right text to user.13:36
openstackgerritAccela Zhao proposed openstack/python-manilaclient: Add driver private storage admin API  https://review.openstack.org/33658113:38
*** merooney has joined #openstack-manila13:39
openstackgerritzhongjun proposed openstack/manila: Add snapshot instances admin APIs  https://review.openstack.org/23465813:47
*** gouthamr has joined #openstack-manila13:51
*** vbellur has joined #openstack-manila13:53
*** dsariel has quit IRC13:54
*** dustins has quit IRC13:55
openstackgerritSilvan Kaiser proposed openstack/manila: Replaces httplib with requests lib in Quobyte RPC layer  https://review.openstack.org/34521914:05
gouthamrkaisers: dictionary wrapping http://docs.openstack.org/developer/hacking/#dictionaries-lists https://review.openstack.org/#/c/345219/9..10/manila/share/drivers/quobyte/jsonrpc.py14:06
openstackgerritMerged openstack/manila: TrivialFix: Fix a wrong order bug in resource_cleanup()  https://review.openstack.org/34718514:07
mkodererganso: https://review.openstack.org/#/c/346680/ - jenkins is through ;)14:12
openstackgerritAlyson proposed openstack/manila: Add support for CIFS shares in HNAS driver  https://review.openstack.org/34296014:16
*** akapil has quit IRC14:25
*** xyang1 has joined #openstack-manila14:27
*** dsariel has joined #openstack-manila14:30
*** vbellur has quit IRC14:30
openstackgerritValeriy Ponomaryov proposed openstack/manila: [Tempest] Try delete resources in cleanup only once  https://review.openstack.org/30633214:32
*** yangyape_ has joined #openstack-manila14:34
*** yangyapeng has quit IRC14:34
*** akapil has joined #openstack-manila14:38
*** aovchinnikov has joined #openstack-manila14:43
*** vbellur has joined #openstack-manila14:46
*** akapil_ has joined #openstack-manila14:56
*** akapil_ has quit IRC14:57
*** dustins has joined #openstack-manila14:58
*** akapil has quit IRC15:00
*** openstackgerrit has quit IRC15:18
*** openstackgerrit has joined #openstack-manila15:19
*** xyang has joined #openstack-manila15:21
*** pcaruana has quit IRC15:22
*** nkrinner is now known as nkrinner_afk15:23
rrajabswartz: can you help merge this useful mitaka backport, https://review.openstack.org/#/c/347413/ ?15:25
*** rraja has quit IRC15:27
openstackgerritAccela Zhao proposed openstack/python-manilaclient: Add driver private storage admin API  https://review.openstack.org/33658115:34
*** alyson_ has quit IRC15:53
*** mtanino has quit IRC15:54
*** dsariel has quit IRC15:57
*** faiz89 has quit IRC16:01
*** akapil has joined #openstack-manila16:01
*** xyang has quit IRC16:08
*** xyang has joined #openstack-manila16:10
*** vbellur has quit IRC16:20
*** xyang has quit IRC16:21
*** dsariel has joined #openstack-manila16:28
*** akapil has quit IRC16:30
*** vbellur has joined #openstack-manila16:35
*** dustins has quit IRC16:36
*** dustins has joined #openstack-manila16:40
openstackgerritzhongjun proposed openstack/manila: Add snapshot instances admin APIs  https://review.openstack.org/23465816:41
*** mtanino has joined #openstack-manila16:45
*** faiz89 has joined #openstack-manila16:48
*** tovchinnikova has quit IRC16:55
*** faiz89 has quit IRC16:58
*** faiz89 has joined #openstack-manila17:01
*** akshai has quit IRC17:10
*** akshai has joined #openstack-manila17:12
openstackgerritAccela Zhao proposed openstack/manila: Driver private storage admin API  https://review.openstack.org/31534617:18
*** nherciu has quit IRC17:19
openstackgerritAlexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests  https://review.openstack.org/34023617:22
*** aovchinnikov has quit IRC17:29
openstackgerritRodrigo Barbieri proposed openstack/manila: Share migration Newton improvements  https://review.openstack.org/32843117:38
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix Share Migration improper behavior for drivers  https://review.openstack.org/33226717:38
openstackgerritRodrigo Barbieri proposed openstack/manila: Base Data Copy changes  https://review.openstack.org/32917417:38
openstackgerritRodrigo Barbieri proposed openstack/manila: Driver Data Service Helper  https://review.openstack.org/29583617:38
*** alyson_ has joined #openstack-manila17:38
*** akshai has quit IRC17:39
openstackgerritRodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration  https://review.openstack.org/34514217:39
*** JoseMello has joined #openstack-manila17:42
*** akshai has joined #openstack-manila17:47
*** akshai has quit IRC18:00
*** akshai has joined #openstack-manila18:01
*** Suyi_ has joined #openstack-manila18:02
*** sandanar has quit IRC18:09
*** faiz89 has quit IRC18:11
*** ociuhandu has quit IRC18:14
*** faiz89 has joined #openstack-manila18:15
openstackgerritRodrigo Barbieri proposed openstack/python-manilaclient: Update Share Migration CLI  https://review.openstack.org/32843718:24
openstackgerritRodrigo Barbieri proposed openstack/python-manilaclient: Add share type change to Share Migration CLI  https://review.openstack.org/34512518:24
*** faiz89 has quit IRC18:29
*** catintheroof has joined #openstack-manila18:34
*** ociuhandu has joined #openstack-manila18:44
*** dsariel has quit IRC18:51
*** timcl has quit IRC19:01
*** akshai has quit IRC19:02
*** gouthamr has quit IRC19:10
*** dsariel has joined #openstack-manila19:31
*** akerr has quit IRC19:53
*** JoseMello has quit IRC20:10
*** merooney has quit IRC20:14
*** porrua has quit IRC20:26
openstackgerritAlyson proposed openstack/manila: Add support for CIFS shares in HNAS driver  https://review.openstack.org/34296020:55
*** vbellur has quit IRC20:56
*** mtanino has quit IRC21:08
*** dsariel has quit IRC21:23
*** xyang1 has quit IRC21:33
*** porrua has joined #openstack-manila21:41
openstackgerritClinton Knight proposed openstack/manila: Implement share revert to snapshot  https://review.openstack.org/34050221:47
*** gouthamr has joined #openstack-manila21:54
openstackgerritClinton Knight proposed openstack/python-manilaclient: Support share revert to snapshot in Manila client  https://review.openstack.org/34055622:09
*** porrua has quit IRC22:16
*** gouthamr_ has joined #openstack-manila22:16
*** gouthamr has quit IRC22:19
*** dustins has quit IRC22:45
*** sjjfowler has joined #openstack-manila23:02
*** zhonghua-lee has quit IRC23:02
*** alyson_ has quit IRC23:03
*** zhonghua-lee has joined #openstack-manila23:03
*** tpsilva has quit IRC23:08
openstackgerritClinton Knight proposed openstack/python-manilaclient: Support share revert to snapshot in Manila client  https://review.openstack.org/34055623:16
openstackgerritClinton Knight proposed openstack/manila: Implement share revert to snapshot  https://review.openstack.org/34050223:18
*** akapil has joined #openstack-manila23:21
*** cknight has quit IRC23:30

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!