| openstackgerrit | Andrew Kerr proposed openstack/manila: Implement share revert to snapshot https://review.openstack.org/340502 | 00:05 |
|---|---|---|
| *** yangyapeng has quit IRC | 00:06 | |
| openstackgerrit | Jay Mehta proposed openstack/manila: HPE 3PAR driver pool support https://review.openstack.org/329552 | 00:06 |
| *** MikeG451 has joined #openstack-manila | 00:08 | |
| *** Suyi has quit IRC | 00:24 | |
| *** sticker has quit IRC | 00:27 | |
| *** ganso has quit IRC | 00:41 | |
| openstackgerrit | Andrew Kerr proposed openstack/manila: Implement share revert to snapshot https://review.openstack.org/340502 | 00:46 |
| *** sticker has joined #openstack-manila | 00:49 | |
| openstackgerrit | Clinton Knight proposed openstack/manila: NetApp: Support share revert to snapshot https://review.openstack.org/357545 | 00:53 |
| *** furlongm has quit IRC | 00:55 | |
| *** furlongm has joined #openstack-manila | 00:55 | |
| *** gouthamr has quit IRC | 00:57 | |
| *** akerr has quit IRC | 00:57 | |
| *** cknight has quit IRC | 00:58 | |
| *** bill_az has quit IRC | 01:01 | |
| *** vbellur has quit IRC | 01:01 | |
| *** tbarron|afk is now known as tbarron | 01:18 | |
| *** wangqun has joined #openstack-manila | 01:20 | |
| *** yangyapeng has joined #openstack-manila | 01:22 | |
| *** chlong has joined #openstack-manila | 01:24 | |
| *** zengyingzhe has joined #openstack-manila | 01:39 | |
| *** mtanino has quit IRC | 01:42 | |
| *** chlong has quit IRC | 02:29 | |
| *** chlong has joined #openstack-manila | 02:46 | |
| zhongjun_ | tbarron: ping | 02:54 |
| *** chlong has quit IRC | 03:39 | |
| *** chlong has joined #openstack-manila | 03:52 | |
| *** vbellur has joined #openstack-manila | 03:53 | |
| *** chlong has quit IRC | 04:10 | |
| *** chlong has joined #openstack-manila | 04:23 | |
| *** lpetrut has joined #openstack-manila | 04:44 | |
| openstackgerrit | Thomas Bechtold proposed openstack/python-manilaclient: Remove ordereddict from test-requirements.txt https://review.openstack.org/357607 | 04:59 |
| *** chlong has quit IRC | 05:12 | |
| *** chlong has joined #openstack-manila | 05:26 | |
| openstackgerrit | Merged openstack/manila: Add dedupe report in HNAS driver https://review.openstack.org/352400 | 05:43 |
| *** rraja has joined #openstack-manila | 05:48 | |
| *** chlong has quit IRC | 05:52 | |
| *** lpetrut has quit IRC | 05:55 | |
| *** lpetrut has joined #openstack-manila | 06:02 | |
| *** lpetrut has quit IRC | 06:13 | |
| *** chlong has joined #openstack-manila | 06:21 | |
| *** sticker has quit IRC | 06:26 | |
| *** aovchinnikov has joined #openstack-manila | 07:10 | |
| *** dsariel has quit IRC | 07:11 | |
| *** lpetrut has joined #openstack-manila | 07:21 | |
| *** tovchinnikova has joined #openstack-manila | 07:33 | |
| openstackgerrit | zhongjun proposed openstack/manila: Implement share backup https://review.openstack.org/343980 | 07:45 |
| openstackgerrit | zhongjun proposed openstack/manila: Implement share backup https://review.openstack.org/343980 | 07:57 |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** openstackgerrit has joined #openstack-manila | 08:04 | |
| *** akapil has joined #openstack-manila | 08:10 | |
| *** akapil has quit IRC | 08:14 | |
| *** akapil has joined #openstack-manila | 08:33 | |
| *** hoonetorg has quit IRC | 08:43 | |
| *** hoonetorg has joined #openstack-manila | 08:53 | |
| openstackgerrit | Yingzhe Zeng proposed openstack/manila: Implement replication support in huawei driver https://review.openstack.org/331586 | 08:58 |
| *** chlong has quit IRC | 09:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila: Updated from global requirements https://review.openstack.org/357700 | 09:05 |
| *** yangyape_ has joined #openstack-manila | 09:07 | |
| *** aovchinnikov has quit IRC | 09:08 | |
| *** yangyapeng has quit IRC | 09:10 | |
| *** ociuhandu has quit IRC | 09:33 | |
| *** yangyapeng has joined #openstack-manila | 09:53 | |
| *** yangyapeng has quit IRC | 09:55 | |
| *** yangyape_ has quit IRC | 09:57 | |
| *** akapil has quit IRC | 10:10 | |
| *** akapil has joined #openstack-manila | 10:33 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Adding NFS support to container driver https://review.openstack.org/337007 | 10:40 |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Adding NFS support to container driver https://review.openstack.org/337007 | 10:47 |
| tbarron | zhongjun_: pong | 10:49 |
| *** tovchinnikova has quit IRC | 11:00 | |
| *** yangyapeng has joined #openstack-manila | 11:01 | |
| *** aovchinnikov has joined #openstack-manila | 11:03 | |
| *** tovchinnikova has joined #openstack-manila | 11:06 | |
| *** wangqun has quit IRC | 11:06 | |
| *** alyson_ has joined #openstack-manila | 11:07 | |
| -openstackstatus- NOTICE: Precise tests on OSIC provider are currently failing, please stop your checks until the issue is resolved. | 11:16 | |
| *** yangyapeng has quit IRC | 11:20 | |
| -openstackstatus- NOTICE: DSVM jobs on OSIC currently failing because of IP collisions, fix is in the gate - https://review.openstack.org/#/c/357764/ - please hold rechecks until merged | 11:21 | |
| *** ociuhandu has joined #openstack-manila | 11:28 | |
| *** ganso has joined #openstack-manila | 11:36 | |
| *** akapil has quit IRC | 11:36 | |
| *** akapil has joined #openstack-manila | 11:45 | |
| -openstackstatus- NOTICE: OSIC has burned through the problematic IP range with failures, things should be back to normal now. | 11:49 | |
| *** dmellado is now known as dmellado|lunch | 12:02 | |
| *** dmellado|lunch is now known as dmellado | 12:02 | |
| *** tpsilva has joined #openstack-manila | 12:16 | |
| *** vbellur has quit IRC | 12:16 | |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Rename and move HNAS driver https://review.openstack.org/356049 | 12:18 |
| openstackgerrit | Merged openstack/manila-ui: Updated from global requirements https://review.openstack.org/356874 | 12:21 |
| *** vbellur has joined #openstack-manila | 12:33 | |
| *** gouthamr has joined #openstack-manila | 12:52 | |
| rraja | ganso: gouthamr: https://review.openstack.org/#/c/343306/ , would be great if you can provide feedback when you've the time. | 12:55 |
| gouthamr | rraja: sure | 12:56 |
| ganso | rraja: I got comments on draft | 12:56 |
| ganso | rraja: I am testing it | 12:56 |
| rraja | gouthamr: thanks! | 12:58 |
| *** tovchinnikova has quit IRC | 12:58 | |
| rraja | gouthamr: ganso: sure! you've a got a lot on your plate already. really appreciate your help. | 12:58 |
| *** yangyapeng has joined #openstack-manila | 13:03 | |
| openstackgerrit | Merged openstack/python-manilaclient: Remove ordereddict from test-requirements.txt https://review.openstack.org/357607 | 13:05 |
| *** xyang1 has joined #openstack-manila | 13:07 | |
| *** bill_az has joined #openstack-manila | 13:09 | |
| *** mtanino has joined #openstack-manila | 13:13 | |
| openstackgerrit | Tom Barron proposed openstack/manila: Use ipaddr module for IP network validation https://review.openstack.org/357507 | 13:14 |
| gouthamr | rraja: ping | 13:17 |
| rraja | gouthamr: pong | 13:17 |
| openstackgerrit | Merged openstack/manila: Updated from global requirements https://review.openstack.org/357700 | 13:17 |
| gouthamr | rraja: hey.. any reason why you want a dict back from the drivers? | 13:18 |
| *** bill_az has quit IRC | 13:18 | |
| *** bill_az has joined #openstack-manila | 13:19 | |
| gouthamr | rraja: i'm asking because it's kinda confusing if the drivers were to actually build/apply access rules serially.. in that case, i would suggest a list of dicts, because we may take back more values per access_id in the future.. | 13:20 |
| *** mtanino has quit IRC | 13:21 | |
| rraja | gouthamr: hmmm. maybe. but we agreed upon in this spec. | 13:21 |
| rraja | s/this/the/ | 13:22 |
| rraja | maybe we can improve it later. it's not a public facing structure. so we can always modify it, right? | 13:22 |
| *** bill_az has quit IRC | 13:23 | |
| gouthamr | rraja: sure.. just curious if there was a reason beyond "works for now" :) | 13:23 |
| gouthamr | rraja: improving driver interfaces is harder than APIs, we don't have microversions.. no big deal, for now, we're okay. | 13:24 |
| rraja | gouthamr: cool! maybe it was intuitive to do a simple access ID to access key mapping. also we can extend the access_keys's dictionary value, correct? | 13:26 |
| gouthamr | rraja: yeah, we could.. we'll tackle it when we get there.. | 13:28 |
| rraja | gouthamr: :) | 13:29 |
| *** porrua has joined #openstack-manila | 13:31 | |
| gouthamr | rraja: okay, imma bug you a while.. | 13:37 |
| gouthamr | rraja: when you have two share instances, what happens? | 13:38 |
| gouthamr | rraja: are both the share instances expected to have the same access_keys for a CEPHX user? | 13:38 |
| *** vbellur has quit IRC | 13:41 | |
| rraja | gouthamr: np | 13:42 |
| rraja | gouthamr: yeah. it's like allowing two shares to the same IP | 13:43 |
| rraja | just that IP cred is already authenticated externally, while to authenticate cephx ID you need a access key | 13:43 |
| rraja | gouthamr: for reference, http://eavesdrop.openstack.org/irclogs/%23openstack-manila/%23openstack-manila.2016-06-06.log.html#t2016-06-06T17:53:51 | 13:47 |
| *** catintheroof has joined #openstack-manila | 13:54 | |
| gouthamr | rraja: thanks.. | 14:00 |
| rraja | gouthamr: you're welcome. | 14:00 |
| *** catintheroof has quit IRC | 14:01 | |
| ganso | xyang1, gouthamr, tbarron, bswartz, markstur: Could you please take a look athttps://review.openstack.org/#/c/355946 ? This has to merge before all migration patches | 14:11 |
| *** vbellur has joined #openstack-manila | 14:12 | |
| *** chlong has joined #openstack-manila | 14:13 | |
| bswartz | ganso: you have a -1 | 14:13 |
| ganso | bswartz: I replied to comments | 14:14 |
| ganso | bswartz: he isn't online to ping to talk about it | 14:14 |
| bswartz | k | 14:14 |
| *** bill_az has joined #openstack-manila | 14:15 | |
| *** ksumit has joined #openstack-manila | 14:21 | |
| tbarron | ganso: what does get_progress() return if self.current_copy is None at line 50? | 14:23 |
| *** vbellur has quit IRC | 14:23 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [Do not merge] Check scenario tests https://review.openstack.org/357914 | 14:24 |
| *** JoseMello has joined #openstack-manila | 14:25 | |
| ganso | tbarron: just a sec | 14:26 |
| ganso | tbarron: line 46 above | 14:27 |
| ganso | tbarron: returns total_progress = 0 | 14:27 |
| *** mtanino has joined #openstack-manila | 14:28 | |
| tbarron | ganso: if the "else" for line 50 is handled earlier at line 46 then you should rewrite the logic so that you don't have an "if" at line 50 :) | 14:29 |
| ganso | tbarron: yes, possibly. I should look at this again if it is not clear | 14:31 |
| tbarron | ganso: your decision tree may be correct, but the style at this point is quite confusing | 14:32 |
| *** aovchinnikov has quit IRC | 14:32 | |
| *** yangyapeng has quit IRC | 14:33 | |
| openstackgerrit | Graham Hayes proposed openstack/manila: Get ready for os-api-ref sphinx theme change https://review.openstack.org/357924 | 14:33 |
| *** yangyapeng has joined #openstack-manila | 14:34 | |
| *** cknight has joined #openstack-manila | 14:35 | |
| *** vbellur has joined #openstack-manila | 14:39 | |
| *** rraja has quit IRC | 14:50 | |
| *** akapil_ has joined #openstack-manila | 14:55 | |
| *** akapil has quit IRC | 14:58 | |
| *** akapil_ has quit IRC | 15:00 | |
| zhongjun_ | tbarron: ping | 15:09 |
| zhongjun_ | tbarron: in https://review.openstack.org/#/c/312321/ | 15:09 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix fallback share migration with empty files https://review.openstack.org/355946 | 15:11 |
| *** ksumit has quit IRC | 15:13 | |
| tbarron | zhongjun_: sorry, my net connection appears to be bouncing ... | 15:14 |
| *** ksumit has joined #openstack-manila | 15:14 | |
| zhongjun_ | tbarron: It is ok | 15:15 |
| tbarron | zhongjun_: i missed whatever you said :( | 15:15 |
| zhongjun_ | tbarron: I used the ipaddress.ip_network(access_to) for check the ipv6 format, but it doesn't work | 15:17 |
| tbarron | zhongjun_: ? | 15:18 |
| tbarron | zhongjun_: I thought it worked when I tried it, what is the issue? | 15:18 |
| zhongjun_ | tbarron:first: for example: 'AD80:0000:0000:0000:ABAA:0000:00C2:0002/64', ip_network will raise "ValueError: .. has host bits set" | 15:20 |
| tbarron | yes, that's not valid for the reason given :) | 15:21 |
| tbarron | your validation method allows it though | 15:21 |
| tbarron | that's why I favor not writing our own ip ipv6 validation rouutines, it's hard to do | 15:22 |
| tbarron | there is a semantic as well as a syntactic aspect to ip/ipv6 addr parsing and validation | 15:23 |
| zhongjun_ | tbarron: but this is a valid format for manila | 15:23 |
| tbarron | even the syntax is hard b/c of the various forms in whith e.g. v6 addrs can be presented | 15:23 |
| tbarron | i think it's a bug in manila | 15:24 |
| zhongjun_ | tbarron: We can see it in command description in manilaclient | 15:24 |
| ganso | zhongjun_: aren't you missing [AD80:...:0002]:/... | 15:24 |
| zhongjun_ | tbarron: such like ip formart | 15:24 |
| tbarron | manila can't redefiine what is valid for ipv6 or ipv4 :) | 15:24 |
| tbarron | we have some hand written validation routines that are too lax | 15:25 |
| tbarron | in the strawman patch I put up to re-do the ipv4 validation I added unit test case that would currently pass but should not | 15:26 |
| *** pcaruana has quit IRC | 15:26 | |
| zhongjun_ | tbarron: Does you means we only support AD80:0000:0000:0000:ABAA:0000:00C2:0002 ? | 15:27 |
| tbarron | zhongjun_: i mean that host bits shouldn't be set (bits past the netmask) This isn't my opinion, it's the standard. | 15:28 |
| tbarron | for any particular example you provide, my reply is "run the standard library routine to find out if it is valid" | 15:29 |
| tbarron | zhongjun_: I think the only reason we have these authored-by-us validations is that the ipaddr module wasn't orignally backported to python2 from python3 | 15:30 |
| tbarron | so historically, it is quite understandable that we wrote our own validation | 15:30 |
| tbarron | but now there is no reason not to use the official module to do this stuff | 15:30 |
| zhongjun_ | tbarron: Ipv6 frefix is the part of the ipv6, Does we not need to pass it? | 15:32 |
| tbarron | zhongjun_: whatever the official library says, it's not a matter of my opinion :) | 15:33 |
| zhongjun_ | tbarron: The ip_network function can check the both of ipv4 and ipv6, Does you means we need to conbine it togeter? | 15:33 |
| zhongjun_ | tbarron: together | 15:33 |
| tbarron | zhongjun_: i think that would be good, but might be a second step | 15:34 |
| tbarron | zhongjun_: if the other cores want to wait and do ipv6 and ipv4 together as a second step and use your roll-your-own validation in the mean time, that's OK | 15:34 |
| tbarron | by me | 15:34 |
| tbarron | I personally favor at least doiing the new code with the standard validation module now. | 15:35 |
| zhongjun_ | ganso: Hi, What's your opinion? | 15:35 |
| tbarron | I proposed https://review.openstack.org/#/c/357507/ to show how we *can* do it right; it's too late for it by itself right now but probably it (or the ipv6 equivalent) could go in your review if you choose to do that | 15:36 |
| tbarron | if everyone decides to defer doing it "the right way" (IMO) then I'll propose a revision of https://review.openstack.org/#/c/357507/ to do both IPv4 and IPv6 early in O | 15:37 |
| tbarron | the only downside of that that I see is that there's a longer time that we allow customers to use invalid network specifications | 15:38 |
| *** bill_az has quit IRC | 15:39 | |
| zhongjun_ | tbarron: If ipv6 and ipv4 together as a second step, the ip_network function does not meet our requirement(just for ipv6) | 15:40 |
| *** ksumit has quit IRC | 15:41 | |
| zhongjun_ | tbarron: thanks for your new patch, I saw it | 15:43 |
| *** ksumit has joined #openstack-manila | 15:43 | |
| tbarron | zhongjun_: I hope it makes clear what my view is :) | 15:43 |
| tbarron | zhongjun_: it would be pretty easy to extend it to handle the ipv6 case as well | 15:44 |
| tbarron | line 453 would change to say "if access_type in ('ip', 'ipv6'): | 15:45 |
| tbarron | in manila/api/v1/shares.py | 15:46 |
| tbarron | and add one more ddt test case in test_shares.py that puts host bits in an ipv6 net specification in test_allow_access_error | 15:47 |
| zhongjun_ | tbarron: 'AD80:0000:0000:0000:ABAA:0000:00C2:0002/65' | 15:48 |
| zhongjun_ | tbarron:in test_allow_access_error | 15:48 |
| tbarron | zhongjun_: yup | 15:50 |
| *** bill_az has joined #openstack-manila | 15:51 | |
| zhongjun_ | tbarron: About "if access_type in ('ip', 'ipv6')". If we separate access type to ip and ipv6, we should not use same method to check both ip and ipv6 format. right? | 15:52 |
| *** ksumit has quit IRC | 15:53 | |
| *** akerr has joined #openstack-manila | 15:54 | |
| tbarron | zhongjun_: maybe not, i'd have to look more closely. Offhand I thought it wouldn't matter since the ipaddr module handles both transparently | 15:54 |
| tbarron | zhongjun_: i've got to run out to a meeting for a while. overall I think your patch looks good but as you know I think that any time we write our own code where there are standard modules that do what is needed we are asking for trouble :) | 15:55 |
| tbarron | once this little issue is resolved I think your patch is good from my POV | 15:56 |
| zhongjun_ | tbarron: If I change the check ip method, most of the manila driver will also need to be changed. | 15:56 |
| tbarron | if that's really true then probably we shouldn't do what I say now then, i've got to run off for a while though | 15:56 |
| *** rraja has joined #openstack-manila | 15:58 | |
| zhongjun_ | tbarron: oh, see you later. | 16:00 |
| *** rraja has quit IRC | 16:01 | |
| *** porrua has quit IRC | 16:10 | |
| *** lpetrut has quit IRC | 16:29 | |
| *** Suyi has joined #openstack-manila | 16:41 | |
| *** krotscheck is now known as the_other_clarkb | 16:42 | |
| *** the_other_clarkb is now known as krotscheck | 16:43 | |
| openstackgerrit | zhongjun proposed openstack/manila: Implement share backup https://review.openstack.org/343980 | 17:01 |
| *** ociuhandu has quit IRC | 17:05 | |
| openstackgerrit | zhongjun proposed openstack/manila: Add IPv6 ACL support in Manila https://review.openstack.org/312321 | 17:05 |
| *** aovchinnikov has joined #openstack-manila | 17:06 | |
| *** kaisers has quit IRC | 17:24 | |
| *** kaisers1 has quit IRC | 17:25 | |
| openstackgerrit | Jay Mehta proposed openstack/manila: HPE 3PAR driver pool support https://review.openstack.org/329552 | 17:26 |
| *** kaisers has joined #openstack-manila | 17:29 | |
| *** kaisers1 has joined #openstack-manila | 17:29 | |
| *** bill_az has quit IRC | 17:30 | |
| mkoderer__ | gouthamr: bswartz: cknight: can I get a review on https://review.openstack.org/#/c/283494/ | 17:51 |
| mkoderer__ | container tempest tests are passing | 17:52 |
| mkoderer__ | IMHO it's ready to merge ;) | 17:52 |
| *** porrua has joined #openstack-manila | 18:05 | |
| *** aovchinnikov has quit IRC | 18:06 | |
| gouthamr | mkoderer__: IMHO I agree :) Happy Vacation! | 18:10 |
| tpsilva | gouthamr: ping | 18:10 |
| gouthamr | tpsilva: hey Tiago! | 18:11 |
| tpsilva | gouthamr: Hey Goutham! | 18:11 |
| tpsilva | gouthamr: ganso told me that you will not be able to work with the update_access bug, right? | 18:11 |
| tpsilva | gouthamr: since the new snapshot semantics was punted to ocata, I can help you with that | 18:12 |
| gouthamr | tpsilva: i haven't had time to finish it.. | 18:12 |
| gouthamr | tpsilva: sure.. had started with it a while ago, but would gladly take help ... :) | 18:12 |
| tpsilva | gouthamr: okay, I'll try to prioritize that into my activities... do you think it's possible to finish that for newton? | 18:14 |
| gouthamr | tpsilva: yes, still on high priority. | 18:14 |
| tpsilva | gouthamr: considering that I would continue what you already started | 18:14 |
| ganso | gouthamr: hi Goutham. Sorry to drop in like this, could you please take a look at the comments I replied in https://review.openstack.org/#/c/332267/ when you have some time? I know you're very busy, but if we can address everything in that patch we can look at the others sooner. | 18:14 |
| gouthamr | ganso: sure.. | 18:15 |
| tpsilva | bswartz: ping | 18:27 |
| *** erlon has joined #openstack-manila | 18:28 | |
| bswartz | tpsilva: pong | 18:33 |
| tpsilva | bswartz: I might need a FPFE for the HSP driver but I'm not sure that's a bug or not | 18:34 |
| bswartz | tpsilva: which patch? | 18:34 |
| tpsilva | bswartz: lemme explain... the driver merged without a filter function, but that function is needed since the backend does not support shares with less than 128GB | 18:35 |
| bswartz | tpsilva: there are no FPFEs btw, just FFEs | 18:35 |
| bswartz | tpsilva: a similar issue came up in the cinder context | 18:35 |
| bswartz | you can't have a manila driver that doesn't support GB-increment shares | 18:36 |
| bswartz | we can provide a feature that makes it easier for deployers to avoid putting small shares on that backend | 18:36 |
| tpsilva | the driver supports GB-increment shares | 18:36 |
| tpsilva | it only does not support shares with less than 128GB | 18:36 |
| bswartz | if "manila create NFS 1" won't work then there's a problem | 18:36 |
| tpsilva | I would only need to add that filter-function on the driver | 18:37 |
| tpsilva | I remember that discussion in a weekly meeting | 18:38 |
| tpsilva | that I decided to port the driver filter to manila | 18:38 |
| bswartz | what I'm trying to say is that you need a weigher and the driver needs to support 1GB shares somehow, otherwise it doesn't meet the contract of what a manila driver is supposed to do | 18:39 |
| bswartz | it's okay to avoid putting small shares on that backend in actual deployments but we've never said it's okay for a driver to simply not support small shares | 18:39 |
| cknight | bswartz: the filter function (just an arithmetic expression) can prevent smaller shares from going to his driver. | 18:39 |
| tpsilva | yep | 18:40 |
| tpsilva | the filter function would just prevent that | 18:40 |
| bswartz | cknight: you mean the whole filter function feature didn't get added yet? | 18:40 |
| cknight | bswartz: in a mixed environment, all the smaller shares would go to netapp. I'm ok with that :-) | 18:40 |
| cknight | bswartz: it did get added | 18:40 |
| cknight | bswartz: tiago led that effort | 18:41 |
| bswartz | what what's missing to make tpsilva happy? | 18:41 |
| tpsilva | bswartz: the filter function on the driver... that's what is needed | 18:41 |
| cknight | bswartz: the driver needs to return a filter string in their shares data. seems like a trivial thing. | 18:41 |
| cknight | tpsilva: would that be a hard-coded string. | 18:41 |
| tpsilva | cknight: yes | 18:41 |
| cknight | tpsilva: then I'd consider that almost a bugfix | 18:42 |
| bswartz | cknight -- it does seem trivial | 18:42 |
| tpsilva | alright, I'll push that as a bugfix | 18:42 |
| bswartz | tpsilva: get it done fast | 18:42 |
| tpsilva | thanks | 18:42 |
| bswartz | as long as it actually merges before FF, if it's trivial in scope we can use our judgement and merge it | 18:43 |
| tpsilva | alright thanks | 18:43 |
| bswartz | mainly I don't want it to be a habit to wait until the last minute for stuff like this though -- if everyone saves their "trivial fixes" for the week before feature freeze we'll be drowning in trivial fixes | 18:43 |
| tpsilva | bswartz: agreed... I should have included that on the driver patch itself... | 18:45 |
| tpsilva | that's probably enough for it to be considered a bug though | 18:45 |
| tpsilva | anyway | 18:45 |
| tpsilva | I'll that quickly, thanks | 18:45 |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-ui: wDisable creation of public share types per configuration https://review.openstack.org/325666 | 18:52 |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-ui: Disable creation of public share types per configuration https://review.openstack.org/325666 | 18:54 |
| *** aorourke has quit IRC | 18:58 | |
| *** dsariel has joined #openstack-manila | 19:07 | |
| *** akerr is now known as akerr_away | 19:17 | |
| *** akerr_away is now known as akerr | 19:17 | |
| *** cknight1 has joined #openstack-manila | 19:21 | |
| *** cknight has quit IRC | 19:21 | |
| *** porrua has quit IRC | 19:22 | |
| ganso | bswartz: ping https://review.openstack.org/#/c/331779/ | 19:29 |
| ganso | bswartz: we decided in the midcycle to remove ensure_share | 19:29 |
| ganso | bswartz: adjusting all drivers | 19:30 |
| ganso | bswartz: seems to me we are a little late for that | 19:30 |
| ganso | bswartz: to me it is not a bugfix, or if it is, a risky one | 19:30 |
| openstackgerrit | Clinton Knight proposed openstack/manila: Implement share revert to snapshot https://review.openstack.org/340502 | 19:34 |
| openstackgerrit | Clinton Knight proposed openstack/manila: NetApp: Support share revert to snapshot https://review.openstack.org/357545 | 19:34 |
| openstackgerrit | Clinton Knight proposed openstack/manila: Add create_share_from_snapshot_support extra spec https://review.openstack.org/356682 | 19:34 |
| bswartz | ganso: how does this have +2 and -W at the same time? | 19:35 |
| bswartz | ganso: if the patch is ready for merge then now is the right time | 19:35 |
| bswartz | I need to review it more to form my own opinion but how do you feel? | 19:36 |
| ganso | bswartz: first idea of the patch was to fix logging, then in midcycle we decided to remove ensure completely... Valeriy's +2 was before midcycle | 19:36 |
| ganso | bswartz: if we decide that ensure will be removed, patch as-is is pointless | 19:36 |
| ganso | bswartz: at least to me, looks pointless | 19:37 |
| bswartz | then -2 it | 19:37 |
| *** cknight1 has quit IRC | 19:37 | |
| ganso | bswartz: I did, before, but then we agreed it would change, so I removed -2 so this is worked within Newton, but this seems no longer a valid case | 19:37 |
| ganso | bswartz: just asking you if you believe this is risky as well to merge during bugfix week before RC | 19:38 |
| *** akerr has quit IRC | 19:39 | |
| ganso | bswartz, markstur, gouthamr: Jenkins has run: https://review.openstack.org/#/c/355946/ | 19:41 |
| bswartz | if it's a bugfix, then we can merge it any time before RC1 | 19:41 |
| bswartz | we'll have to weigh the risk of not merging it against merging it | 19:41 |
| openstackgerrit | Tom Barron proposed openstack/manila: Use ipaddr module for IP network validation https://review.openstack.org/357507 | 19:48 |
| *** Suyi has quit IRC | 19:51 | |
| *** Suyi has joined #openstack-manila | 19:51 | |
| *** Suyi has quit IRC | 19:53 | |
| *** bill_az has joined #openstack-manila | 19:56 | |
| *** xyang1 has quit IRC | 20:02 | |
| *** xyang1 has joined #openstack-manila | 20:02 | |
| *** vbellur has quit IRC | 20:03 | |
| *** xyang1 has quit IRC | 20:04 | |
| *** xyang1 has joined #openstack-manila | 20:06 | |
| *** cknight has joined #openstack-manila | 20:09 | |
| *** mtanino has quit IRC | 20:10 | |
| *** dsariel has quit IRC | 20:11 | |
| *** cknight has quit IRC | 20:13 | |
| *** vbellur has joined #openstack-manila | 20:36 | |
| *** gouthamr has quit IRC | 20:39 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [DEBUG] PLEASE DO NOT MERGE https://review.openstack.org/358112 | 20:47 |
| *** vbellur has quit IRC | 20:55 | |
| *** gouthamr has joined #openstack-manila | 20:55 | |
| openstackgerrit | Faiz Abidi proposed openstack/python-manilaclient: Allow deletion of multiple resources for some manila commands https://review.openstack.org/358119 | 20:58 |
| *** gouthamr_ has joined #openstack-manila | 21:01 | |
| *** gouthamr has quit IRC | 21:04 | |
| *** rhagarty has joined #openstack-manila | 21:06 | |
| *** xyang1 has quit IRC | 21:21 | |
| *** Suyi has joined #openstack-manila | 21:49 | |
| *** gouthamr_ has quit IRC | 21:56 | |
| *** akapil has joined #openstack-manila | 21:57 | |
| *** gouthamr has joined #openstack-manila | 22:01 | |
| *** cknight has joined #openstack-manila | 22:01 | |
| *** alyson_ has quit IRC | 22:03 | |
| *** cknight has quit IRC | 22:13 | |
| openstackgerrit | Merged openstack/manila: Fix fallback share migration with empty files https://review.openstack.org/355946 | 22:14 |
| *** erlon has quit IRC | 22:17 | |
| *** JoseMello has quit IRC | 22:20 | |
| *** Suyi has quit IRC | 22:21 | |
| *** Suyi has joined #openstack-manila | 22:22 | |
| *** akapil has quit IRC | 22:29 | |
| *** tpsilva has quit IRC | 22:38 | |
| *** vbellur has joined #openstack-manila | 22:42 | |
| *** ganso has quit IRC | 23:21 | |
| *** bill_az has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!