Wednesday, 2016-09-07

*** merooney has quit IRC00:03
*** ganso has quit IRC00:05
*** Suyi_ has quit IRC00:08
*** yangyapeng has quit IRC00:11
*** kaisers has quit IRC00:42
*** kaisers has joined #openstack-manila00:43
*** felix23ma has joined #openstack-manila00:50
*** vbellur has joined #openstack-manila01:05
*** wangqun has joined #openstack-manila01:19
*** yangyapeng has joined #openstack-manila01:20
*** felix23ma has quit IRC01:22
*** felix23ma has joined #openstack-manila01:40
*** yangyape_ has joined #openstack-manila02:00
*** merooney has joined #openstack-manila02:00
*** esker[away] is now known as esker02:01
*** yangyapeng has quit IRC02:02
*** yangyapeng has joined #openstack-manila02:03
*** yangyape_ has quit IRC02:04
zhongjun_jay-mehta: hello02:18
*** akshai has joined #openstack-manila02:23
*** felix23ma has quit IRC02:26
*** felix23ma has joined #openstack-manila02:28
*** merooney has quit IRC02:29
*** akshai has quit IRC02:30
*** merooney has joined #openstack-manila02:31
*** felix23ma has quit IRC02:31
*** felix23ma has joined #openstack-manila02:34
*** akshai has joined #openstack-manila02:42
*** yangyape_ has joined #openstack-manila02:43
*** yangyapeng has quit IRC02:45
*** merooney has quit IRC02:52
*** felix23ma has quit IRC03:06
*** felix23ma has joined #openstack-manila03:08
*** felix23ma has quit IRC03:25
*** gouthamr has quit IRC03:37
*** kambiz has quit IRC03:40
*** gouthamr has joined #openstack-manila03:45
*** felix23ma has joined #openstack-manila03:56
*** esker is now known as esker[away]04:03
*** gouthamr has quit IRC04:21
*** senk has joined #openstack-manila04:26
*** akshai has quit IRC04:27
*** akshai has joined #openstack-manila04:48
*** nidhimittalhada has joined #openstack-manila04:52
*** senk has quit IRC04:55
*** nidhimittalhada has quit IRC04:59
*** nidhimittalhada has joined #openstack-manila05:00
*** nidhimittalhada has joined #openstack-manila05:01
*** openstackgerrit has quit IRC05:18
*** rooneym has quit IRC05:19
*** openstackgerrit has joined #openstack-manila05:19
*** akshai has quit IRC05:24
*** akshai has joined #openstack-manila05:29
*** senk has joined #openstack-manila05:29
nidhimittalhadahttps://review.openstack.org/348160   https://review.openstack.org/351034   @vponomaryov @ganso @tbarron @zhongjun @cknight Can you please review?05:36
*** akshai has quit IRC05:39
*** nidhimittalhada has quit IRC05:47
openstackgerritVijay Ladani proposed openstack/manila: HPE 3PAR: Manila file share support of AD  https://review.openstack.org/36604505:57
*** nkrinner_afk is now known as nkrinner06:03
*** dsariel has joined #openstack-manila06:04
*** yangyapeng has joined #openstack-manila06:10
*** yangyap__ has joined #openstack-manila06:10
*** yangyape_ has quit IRC06:11
*** yangyapeng has quit IRC06:14
*** pcaruana has joined #openstack-manila06:34
*** sticker has quit IRC06:42
*** lpetrut has joined #openstack-manila06:48
*** aovchinnikov has joined #openstack-manila07:27
*** lpetrut has quit IRC07:38
*** lpetrut has joined #openstack-manila07:52
*** lpetrut has quit IRC08:16
*** openstackgerrit has quit IRC08:34
*** openstackgerrit has joined #openstack-manila08:34
*** lpetrut has joined #openstack-manila08:44
*** rraja has quit IRC08:45
*** rraja has joined #openstack-manila09:01
*** rraja has quit IRC09:13
*** yangyap__ has quit IRC09:43
*** yangyapeng has joined #openstack-manila09:43
openstackgerritTatiana Ovchinnikova proposed openstack/manila-ui: Change Create Replica button availability  https://review.openstack.org/36663509:53
*** hoonetorg has quit IRC09:58
*** dgonzalez has quit IRC10:45
*** dsariel has quit IRC10:45
*** dgonzalez has joined #openstack-manila10:57
*** yangyapeng has quit IRC11:00
*** merooney has joined #openstack-manila11:08
*** wangqun has quit IRC11:08
*** rraja has joined #openstack-manila11:15
openstackgerritTatiana Ovchinnikova proposed openstack/manila-ui: Change Create Replica button availability  https://review.openstack.org/36663511:34
openstackgerritAlexey Ovchinnikov proposed openstack/manila: Fix for CIFSHelperUserAccess failing with no users  https://review.openstack.org/36666011:56
*** timcl has joined #openstack-manila12:01
*** chlong has joined #openstack-manila12:05
openstackgerritValeriy Ponomaryov proposed openstack/manila: [ZFSonLinux] Fix share migration support  https://review.openstack.org/36606612:11
*** hoonetorg has joined #openstack-manila12:23
*** esker[away] has quit IRC12:24
*** rooneym has joined #openstack-manila12:25
openstackgerritAlexey Ovchinnikov proposed openstack/manila: [DNM] More container driver tests  https://review.openstack.org/36674012:57
*** yangyapeng has joined #openstack-manila13:00
*** porrua has joined #openstack-manila13:04
*** dsariel has joined #openstack-manila13:07
*** xyang1 has joined #openstack-manila13:13
openstackgerritRodrigo Barbieri proposed openstack/manila: Improve Share Migration tempest tests  https://review.openstack.org/36632413:21
*** akerr has joined #openstack-manila13:26
*** wangqun has joined #openstack-manila13:31
*** eharney has joined #openstack-manila13:46
*** esker has joined #openstack-manila13:49
*** timcl has quit IRC13:51
*** esker has quit IRC13:52
*** wangqun has quit IRC14:01
*** aovchinnikov has quit IRC14:08
*** timcl has joined #openstack-manila14:16
*** darrenc has quit IRC14:20
*** tpatzig_ has quit IRC14:20
*** felix23ma has quit IRC14:27
*** venkhari has joined #openstack-manila14:31
*** darrenc has joined #openstack-manila14:42
*** tpatzig_ has joined #openstack-manila14:42
*** hoonetorg has quit IRC14:43
*** senk has quit IRC14:49
*** faiz89 has joined #openstack-manila14:52
*** hoonetorg has joined #openstack-manila14:57
*** gouthamr has joined #openstack-manila14:59
*** gouthamr_ has joined #openstack-manila15:01
*** gouthamr has quit IRC15:05
*** timcl has quit IRC15:18
*** ociuhandu has joined #openstack-manila15:21
*** timcl has joined #openstack-manila15:25
*** vbellur has quit IRC15:28
*** rraja has quit IRC15:28
*** nkrinner is now known as nkrinner_afk15:29
*** venkhari has quit IRC15:36
openstackgerritValeriy Ponomaryov proposed openstack/manila: [ZFSonLinux] Fix share migration support  https://review.openstack.org/36606615:37
openstackgerritValeriy Ponomaryov proposed openstack/manila: [ZFSonLinux] Add test coverage for share migration  https://review.openstack.org/36683315:37
*** hoonetorg has quit IRC15:38
*** chlong has quit IRC15:41
*** lpetrut has quit IRC15:42
*** hoonetorg has joined #openstack-manila15:42
*** rraja has joined #openstack-manila15:44
*** senk has joined #openstack-manila15:45
*** ociuhandu has quit IRC15:52
*** sandanar has joined #openstack-manila15:58
*** vbellur has joined #openstack-manila16:00
*** faiz89 has quit IRC16:01
*** pcaruana has quit IRC16:01
*** akshai has joined #openstack-manila16:10
openstackgerritValeriy Ponomaryov proposed openstack/manila: [docs] Update dev docs for ZFSonLinux share driver  https://review.openstack.org/36685616:21
*** rraja has quit IRC16:21
*** akshai_ has joined #openstack-manila16:21
*** akshai has quit IRC16:21
*** timcl has quit IRC16:23
*** porrua has quit IRC16:26
*** aovchinnikov has joined #openstack-manila16:33
*** Yogi1 has joined #openstack-manila16:35
*** baojg has joined #openstack-manila16:38
*** timcl has joined #openstack-manila16:41
*** akshai_ has quit IRC16:43
*** porrua has joined #openstack-manila16:53
*** lpetrut has joined #openstack-manila16:54
*** vbellur has quit IRC16:55
*** aovchinnikov has quit IRC16:58
*** venkhari has joined #openstack-manila17:01
*** vbellur has joined #openstack-manila17:10
*** rraja has joined #openstack-manila17:10
bswartzhttp://civs.cs.cornell.edu/cgi-bin/vote.pl?id=E_6f0d111cec78c5ef&akey=d34a751f2d084d7917:21
bswartzATTENTION EVERYONE17:22
*** baojg has quit IRC17:22
bswartz^ this is the link to vote to choose a new logo17:22
*** baojg has joined #openstack-manila17:22
*** timcl has quit IRC17:25
gouthamr_all caps.. nice :P17:27
*** Suyi_ has joined #openstack-manila17:28
*** faiz89 has joined #openstack-manila17:29
*** gouthamr_ is now known as gouthamr17:29
*** venkhari has quit IRC17:33
jay-mehtavoted my preference :)17:38
*** harlowja has quit IRC17:46
*** harlowja has joined #openstack-manila17:49
*** sandanar_ has joined #openstack-manila17:50
*** sandanar has quit IRC17:53
*** dsariel has quit IRC18:07
*** timcl has joined #openstack-manila18:10
*** ociuhandu has joined #openstack-manila18:13
*** akshai has joined #openstack-manila18:13
*** sandanar_ has quit IRC18:15
*** cknight has joined #openstack-manila18:29
*** baojg has quit IRC18:34
*** rraja has quit IRC18:38
*** akshai has quit IRC18:59
*** StraubTW has joined #openstack-manila19:02
*** lpetrut has quit IRC19:04
*** senk has quit IRC19:05
StraubTWCan anyone point me to a complete example of a generic (cirrus) puppet-manila configuration?19:06
*** dsariel has joined #openstack-manila19:11
*** porrua has quit IRC19:20
bswartzStraubTW: cirrus?19:23
bswartzStraubTW: also I don't know if the puppet-manila guys hang out here19:23
*** faiz89 has quit IRC19:33
StraubTWSorry - Cinder.  Hmmm..  Do you know where they hang out?19:39
bswartzStraubTW: my best guess would be various puppet-oriented channels19:41
StraubTWOk.  Thanks19:41
*** timcl1 has joined #openstack-manila19:42
*** StraubTW has left #openstack-manila19:43
*** timcl has quit IRC19:44
*** lpetrut has joined #openstack-manila19:45
openstackgerritGoutham Pacha Ravi proposed openstack/manila: NetApp cDOT: Avoid cleaning up 'invalid' mirrors  https://review.openstack.org/36693519:46
*** lpetrut has quit IRC19:50
*** faiz89 has joined #openstack-manila19:56
faiz89@bswartz @cknight can one of you please review this - https://review.openstack.org/#/c/358119/19:57
*** lpetrut has joined #openstack-manila20:00
akerrhiya faiz8920:02
*** merooney has quit IRC20:03
faiz89Hello akerr :)20:03
*** openstackgerrit has quit IRC20:04
*** openstackgerrit has joined #openstack-manila20:05
*** Yogi1 has quit IRC20:05
gouthamris the LVM gate job broken?20:06
bswartzgouthamr: yes20:08
bswartzgouthamr: see https://bugs.launchpad.net/manila/+bug/162108120:09
openstackLaunchpad bug 1621081 in Manila "LVM job fails after adding extra services" [Undecided,New]20:09
*** akerr has quit IRC20:10
gouthamrbswartz: oh..20:10
bswartzgouthamr: the fix is already posted20:11
gouthamrbswartz: found it https://review.openstack.org/#/c/366771/20:11
bswartzindeed20:11
*** timcl1 has quit IRC20:24
*** vbellur has quit IRC20:26
*** lpetrut has quit IRC20:29
*** ociuhandu has quit IRC20:43
*** ociuhandu has joined #openstack-manila20:51
jay-mehtazhongjun_, hi20:51
jay-mehtagouthamr, hi20:53
*** dsariel has quit IRC20:53
jay-mehtaI have -1 for https://review.openstack.org/#/c/360088/20:53
jay-mehtaThat patch is just to correct the arguments for call self.driver.setup_server() in unit tests20:54
jay-mehtaThe actual driver gets called with metadata argument, however these unit tests are not passing that keyword argument.20:55
jay-mehtaNot a big correction tough20:55
gouthamrjay-mehta: you already corrected that with the patch that merged: https://review.openstack.org/#/c/329552/15/manila/tests/share/test_manager.py20:56
jay-mehtagouthamr, yes20:56
gouthamrjay-mehta: https://review.openstack.org/#/c/360088/ could be abandoned. there's nothing left to fix20:56
jay-mehtaThere is nothing wrong with these unit tests, its not breaking20:57
jay-mehtabut i think the unit test which mock as manager and call self.driver.setup_server() should pass metadata keyword argument20:57
jay-mehtathat is what I am trying to convey20:58
jay-mehtaAnd thats is what the patch is trying to correct.20:58
gouthamrjay-mehta: its a kwarg that has a default value.. its valid to not pass it when it's not required.20:59
jay-mehtaYes.20:59
jay-mehtaBut when the unit test try to mock the manager which is actually passing kwarg metadata, ideally it should be passed in unit test too.21:00
jay-mehtaDon't you think so?21:00
jay-mehtaTomorrow if the driver starts utilizing this kwarg, the first correction would be to correct the necessary parameters in unit test21:01
gouthamrjay-mehta: its not a bug. i don't see anyplace where the manager's call is mocked..21:02
jay-mehtagouthamr, If i not mistaken, I think all calls as self.driver.setup_server() are being mocked. Am I right?21:04
jay-mehtahttps://review.openstack.org/#/c/360088/1/manila/tests/share/drivers/huawei/test_huawei_nas.py  line 309121:04
*** ociuhandu has quit IRC21:08
gouthamrjay-mehta: when you subclass ShareDriver, you can choose to ignore the kwargs; its not ideal, but its valid; so.. you should talk to the driver maintainers to see if they are willing to make the change21:13
jay-mehtagouthamr, yes. I agree. It is just a correction. It should have been caught at review stage. If the call accepts a kwarg parameter, it should be passed in unit test, even if the driver is not using it.21:14
*** merooney has joined #openstack-manila21:17
*** merooney_ has joined #openstack-manila21:18
*** faiz89 has quit IRC21:18
*** merooney has quit IRC21:21
*** lpetrut has joined #openstack-manila21:30
*** faiz89 has joined #openstack-manila21:39
*** vbellur has joined #openstack-manila22:06
*** chlong has joined #openstack-manila22:12
*** lpetrut has quit IRC22:19
*** merooney_ has quit IRC22:22
*** merooney has joined #openstack-manila22:24
*** faiz89 has quit IRC22:27
*** akshai has joined #openstack-manila22:30
*** cknight has quit IRC22:52
*** xyang1 has quit IRC22:55
*** gouthamr has quit IRC22:58
*** harlowja has quit IRC23:03
*** akshai has quit IRC23:23
*** akshai has joined #openstack-manila23:24
*** akshai has quit IRC23:25
*** gouthamr has joined #openstack-manila23:34
*** gouthamr_ has joined #openstack-manila23:34
*** gouthamr has quit IRC23:38
*** akshai has joined #openstack-manila23:49
*** cknight has joined #openstack-manila23:50
*** akshai has quit IRC23:57
*** Suyi_ has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!