*** merooney has quit IRC | 00:03 | |
*** ganso has quit IRC | 00:05 | |
*** Suyi_ has quit IRC | 00:08 | |
*** yangyapeng has quit IRC | 00:11 | |
*** kaisers has quit IRC | 00:42 | |
*** kaisers has joined #openstack-manila | 00:43 | |
*** felix23ma has joined #openstack-manila | 00:50 | |
*** vbellur has joined #openstack-manila | 01:05 | |
*** wangqun has joined #openstack-manila | 01:19 | |
*** yangyapeng has joined #openstack-manila | 01:20 | |
*** felix23ma has quit IRC | 01:22 | |
*** felix23ma has joined #openstack-manila | 01:40 | |
*** yangyape_ has joined #openstack-manila | 02:00 | |
*** merooney has joined #openstack-manila | 02:00 | |
*** esker[away] is now known as esker | 02:01 | |
*** yangyapeng has quit IRC | 02:02 | |
*** yangyapeng has joined #openstack-manila | 02:03 | |
*** yangyape_ has quit IRC | 02:04 | |
zhongjun_ | jay-mehta: hello | 02:18 |
---|---|---|
*** akshai has joined #openstack-manila | 02:23 | |
*** felix23ma has quit IRC | 02:26 | |
*** felix23ma has joined #openstack-manila | 02:28 | |
*** merooney has quit IRC | 02:29 | |
*** akshai has quit IRC | 02:30 | |
*** merooney has joined #openstack-manila | 02:31 | |
*** felix23ma has quit IRC | 02:31 | |
*** felix23ma has joined #openstack-manila | 02:34 | |
*** akshai has joined #openstack-manila | 02:42 | |
*** yangyape_ has joined #openstack-manila | 02:43 | |
*** yangyapeng has quit IRC | 02:45 | |
*** merooney has quit IRC | 02:52 | |
*** felix23ma has quit IRC | 03:06 | |
*** felix23ma has joined #openstack-manila | 03:08 | |
*** felix23ma has quit IRC | 03:25 | |
*** gouthamr has quit IRC | 03:37 | |
*** kambiz has quit IRC | 03:40 | |
*** gouthamr has joined #openstack-manila | 03:45 | |
*** felix23ma has joined #openstack-manila | 03:56 | |
*** esker is now known as esker[away] | 04:03 | |
*** gouthamr has quit IRC | 04:21 | |
*** senk has joined #openstack-manila | 04:26 | |
*** akshai has quit IRC | 04:27 | |
*** akshai has joined #openstack-manila | 04:48 | |
*** nidhimittalhada has joined #openstack-manila | 04:52 | |
*** senk has quit IRC | 04:55 | |
*** nidhimittalhada has quit IRC | 04:59 | |
*** nidhimittalhada has joined #openstack-manila | 05:00 | |
*** nidhimittalhada has joined #openstack-manila | 05:01 | |
*** openstackgerrit has quit IRC | 05:18 | |
*** rooneym has quit IRC | 05:19 | |
*** openstackgerrit has joined #openstack-manila | 05:19 | |
*** akshai has quit IRC | 05:24 | |
*** akshai has joined #openstack-manila | 05:29 | |
*** senk has joined #openstack-manila | 05:29 | |
nidhimittalhada | https://review.openstack.org/348160 https://review.openstack.org/351034 @vponomaryov @ganso @tbarron @zhongjun @cknight Can you please review? | 05:36 |
*** akshai has quit IRC | 05:39 | |
*** nidhimittalhada has quit IRC | 05:47 | |
openstackgerrit | Vijay Ladani proposed openstack/manila: HPE 3PAR: Manila file share support of AD https://review.openstack.org/366045 | 05:57 |
*** nkrinner_afk is now known as nkrinner | 06:03 | |
*** dsariel has joined #openstack-manila | 06:04 | |
*** yangyapeng has joined #openstack-manila | 06:10 | |
*** yangyap__ has joined #openstack-manila | 06:10 | |
*** yangyape_ has quit IRC | 06:11 | |
*** yangyapeng has quit IRC | 06:14 | |
*** pcaruana has joined #openstack-manila | 06:34 | |
*** sticker has quit IRC | 06:42 | |
*** lpetrut has joined #openstack-manila | 06:48 | |
*** aovchinnikov has joined #openstack-manila | 07:27 | |
*** lpetrut has quit IRC | 07:38 | |
*** lpetrut has joined #openstack-manila | 07:52 | |
*** lpetrut has quit IRC | 08:16 | |
*** openstackgerrit has quit IRC | 08:34 | |
*** openstackgerrit has joined #openstack-manila | 08:34 | |
*** lpetrut has joined #openstack-manila | 08:44 | |
*** rraja has quit IRC | 08:45 | |
*** rraja has joined #openstack-manila | 09:01 | |
*** rraja has quit IRC | 09:13 | |
*** yangyap__ has quit IRC | 09:43 | |
*** yangyapeng has joined #openstack-manila | 09:43 | |
openstackgerrit | Tatiana Ovchinnikova proposed openstack/manila-ui: Change Create Replica button availability https://review.openstack.org/366635 | 09:53 |
*** hoonetorg has quit IRC | 09:58 | |
*** dgonzalez has quit IRC | 10:45 | |
*** dsariel has quit IRC | 10:45 | |
*** dgonzalez has joined #openstack-manila | 10:57 | |
*** yangyapeng has quit IRC | 11:00 | |
*** merooney has joined #openstack-manila | 11:08 | |
*** wangqun has quit IRC | 11:08 | |
*** rraja has joined #openstack-manila | 11:15 | |
openstackgerrit | Tatiana Ovchinnikova proposed openstack/manila-ui: Change Create Replica button availability https://review.openstack.org/366635 | 11:34 |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Fix for CIFSHelperUserAccess failing with no users https://review.openstack.org/366660 | 11:56 |
*** timcl has joined #openstack-manila | 12:01 | |
*** chlong has joined #openstack-manila | 12:05 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [ZFSonLinux] Fix share migration support https://review.openstack.org/366066 | 12:11 |
*** hoonetorg has joined #openstack-manila | 12:23 | |
*** esker[away] has quit IRC | 12:24 | |
*** rooneym has joined #openstack-manila | 12:25 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] More container driver tests https://review.openstack.org/366740 | 12:57 |
*** yangyapeng has joined #openstack-manila | 13:00 | |
*** porrua has joined #openstack-manila | 13:04 | |
*** dsariel has joined #openstack-manila | 13:07 | |
*** xyang1 has joined #openstack-manila | 13:13 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Improve Share Migration tempest tests https://review.openstack.org/366324 | 13:21 |
*** akerr has joined #openstack-manila | 13:26 | |
*** wangqun has joined #openstack-manila | 13:31 | |
*** eharney has joined #openstack-manila | 13:46 | |
*** esker has joined #openstack-manila | 13:49 | |
*** timcl has quit IRC | 13:51 | |
*** esker has quit IRC | 13:52 | |
*** wangqun has quit IRC | 14:01 | |
*** aovchinnikov has quit IRC | 14:08 | |
*** timcl has joined #openstack-manila | 14:16 | |
*** darrenc has quit IRC | 14:20 | |
*** tpatzig_ has quit IRC | 14:20 | |
*** felix23ma has quit IRC | 14:27 | |
*** venkhari has joined #openstack-manila | 14:31 | |
*** darrenc has joined #openstack-manila | 14:42 | |
*** tpatzig_ has joined #openstack-manila | 14:42 | |
*** hoonetorg has quit IRC | 14:43 | |
*** senk has quit IRC | 14:49 | |
*** faiz89 has joined #openstack-manila | 14:52 | |
*** hoonetorg has joined #openstack-manila | 14:57 | |
*** gouthamr has joined #openstack-manila | 14:59 | |
*** gouthamr_ has joined #openstack-manila | 15:01 | |
*** gouthamr has quit IRC | 15:05 | |
*** timcl has quit IRC | 15:18 | |
*** ociuhandu has joined #openstack-manila | 15:21 | |
*** timcl has joined #openstack-manila | 15:25 | |
*** vbellur has quit IRC | 15:28 | |
*** rraja has quit IRC | 15:28 | |
*** nkrinner is now known as nkrinner_afk | 15:29 | |
*** venkhari has quit IRC | 15:36 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [ZFSonLinux] Fix share migration support https://review.openstack.org/366066 | 15:37 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [ZFSonLinux] Add test coverage for share migration https://review.openstack.org/366833 | 15:37 |
*** hoonetorg has quit IRC | 15:38 | |
*** chlong has quit IRC | 15:41 | |
*** lpetrut has quit IRC | 15:42 | |
*** hoonetorg has joined #openstack-manila | 15:42 | |
*** rraja has joined #openstack-manila | 15:44 | |
*** senk has joined #openstack-manila | 15:45 | |
*** ociuhandu has quit IRC | 15:52 | |
*** sandanar has joined #openstack-manila | 15:58 | |
*** vbellur has joined #openstack-manila | 16:00 | |
*** faiz89 has quit IRC | 16:01 | |
*** pcaruana has quit IRC | 16:01 | |
*** akshai has joined #openstack-manila | 16:10 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [docs] Update dev docs for ZFSonLinux share driver https://review.openstack.org/366856 | 16:21 |
*** rraja has quit IRC | 16:21 | |
*** akshai_ has joined #openstack-manila | 16:21 | |
*** akshai has quit IRC | 16:21 | |
*** timcl has quit IRC | 16:23 | |
*** porrua has quit IRC | 16:26 | |
*** aovchinnikov has joined #openstack-manila | 16:33 | |
*** Yogi1 has joined #openstack-manila | 16:35 | |
*** baojg has joined #openstack-manila | 16:38 | |
*** timcl has joined #openstack-manila | 16:41 | |
*** akshai_ has quit IRC | 16:43 | |
*** porrua has joined #openstack-manila | 16:53 | |
*** lpetrut has joined #openstack-manila | 16:54 | |
*** vbellur has quit IRC | 16:55 | |
*** aovchinnikov has quit IRC | 16:58 | |
*** venkhari has joined #openstack-manila | 17:01 | |
*** vbellur has joined #openstack-manila | 17:10 | |
*** rraja has joined #openstack-manila | 17:10 | |
bswartz | http://civs.cs.cornell.edu/cgi-bin/vote.pl?id=E_6f0d111cec78c5ef&akey=d34a751f2d084d79 | 17:21 |
bswartz | ATTENTION EVERYONE | 17:22 |
*** baojg has quit IRC | 17:22 | |
bswartz | ^ this is the link to vote to choose a new logo | 17:22 |
*** baojg has joined #openstack-manila | 17:22 | |
*** timcl has quit IRC | 17:25 | |
gouthamr_ | all caps.. nice :P | 17:27 |
*** Suyi_ has joined #openstack-manila | 17:28 | |
*** faiz89 has joined #openstack-manila | 17:29 | |
*** gouthamr_ is now known as gouthamr | 17:29 | |
*** venkhari has quit IRC | 17:33 | |
jay-mehta | voted my preference :) | 17:38 |
*** harlowja has quit IRC | 17:46 | |
*** harlowja has joined #openstack-manila | 17:49 | |
*** sandanar_ has joined #openstack-manila | 17:50 | |
*** sandanar has quit IRC | 17:53 | |
*** dsariel has quit IRC | 18:07 | |
*** timcl has joined #openstack-manila | 18:10 | |
*** ociuhandu has joined #openstack-manila | 18:13 | |
*** akshai has joined #openstack-manila | 18:13 | |
*** sandanar_ has quit IRC | 18:15 | |
*** cknight has joined #openstack-manila | 18:29 | |
*** baojg has quit IRC | 18:34 | |
*** rraja has quit IRC | 18:38 | |
*** akshai has quit IRC | 18:59 | |
*** StraubTW has joined #openstack-manila | 19:02 | |
*** lpetrut has quit IRC | 19:04 | |
*** senk has quit IRC | 19:05 | |
StraubTW | Can anyone point me to a complete example of a generic (cirrus) puppet-manila configuration? | 19:06 |
*** dsariel has joined #openstack-manila | 19:11 | |
*** porrua has quit IRC | 19:20 | |
bswartz | StraubTW: cirrus? | 19:23 |
bswartz | StraubTW: also I don't know if the puppet-manila guys hang out here | 19:23 |
*** faiz89 has quit IRC | 19:33 | |
StraubTW | Sorry - Cinder. Hmmm.. Do you know where they hang out? | 19:39 |
bswartz | StraubTW: my best guess would be various puppet-oriented channels | 19:41 |
StraubTW | Ok. Thanks | 19:41 |
*** timcl1 has joined #openstack-manila | 19:42 | |
*** StraubTW has left #openstack-manila | 19:43 | |
*** timcl has quit IRC | 19:44 | |
*** lpetrut has joined #openstack-manila | 19:45 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: NetApp cDOT: Avoid cleaning up 'invalid' mirrors https://review.openstack.org/366935 | 19:46 |
*** lpetrut has quit IRC | 19:50 | |
*** faiz89 has joined #openstack-manila | 19:56 | |
faiz89 | @bswartz @cknight can one of you please review this - https://review.openstack.org/#/c/358119/ | 19:57 |
*** lpetrut has joined #openstack-manila | 20:00 | |
akerr | hiya faiz89 | 20:02 |
*** merooney has quit IRC | 20:03 | |
faiz89 | Hello akerr :) | 20:03 |
*** openstackgerrit has quit IRC | 20:04 | |
*** openstackgerrit has joined #openstack-manila | 20:05 | |
*** Yogi1 has quit IRC | 20:05 | |
gouthamr | is the LVM gate job broken? | 20:06 |
bswartz | gouthamr: yes | 20:08 |
bswartz | gouthamr: see https://bugs.launchpad.net/manila/+bug/1621081 | 20:09 |
openstack | Launchpad bug 1621081 in Manila "LVM job fails after adding extra services" [Undecided,New] | 20:09 |
*** akerr has quit IRC | 20:10 | |
gouthamr | bswartz: oh.. | 20:10 |
bswartz | gouthamr: the fix is already posted | 20:11 |
gouthamr | bswartz: found it https://review.openstack.org/#/c/366771/ | 20:11 |
bswartz | indeed | 20:11 |
*** timcl1 has quit IRC | 20:24 | |
*** vbellur has quit IRC | 20:26 | |
*** lpetrut has quit IRC | 20:29 | |
*** ociuhandu has quit IRC | 20:43 | |
*** ociuhandu has joined #openstack-manila | 20:51 | |
jay-mehta | zhongjun_, hi | 20:51 |
jay-mehta | gouthamr, hi | 20:53 |
*** dsariel has quit IRC | 20:53 | |
jay-mehta | I have -1 for https://review.openstack.org/#/c/360088/ | 20:53 |
jay-mehta | That patch is just to correct the arguments for call self.driver.setup_server() in unit tests | 20:54 |
jay-mehta | The actual driver gets called with metadata argument, however these unit tests are not passing that keyword argument. | 20:55 |
jay-mehta | Not a big correction tough | 20:55 |
gouthamr | jay-mehta: you already corrected that with the patch that merged: https://review.openstack.org/#/c/329552/15/manila/tests/share/test_manager.py | 20:56 |
jay-mehta | gouthamr, yes | 20:56 |
gouthamr | jay-mehta: https://review.openstack.org/#/c/360088/ could be abandoned. there's nothing left to fix | 20:56 |
jay-mehta | There is nothing wrong with these unit tests, its not breaking | 20:57 |
jay-mehta | but i think the unit test which mock as manager and call self.driver.setup_server() should pass metadata keyword argument | 20:57 |
jay-mehta | that is what I am trying to convey | 20:58 |
jay-mehta | And thats is what the patch is trying to correct. | 20:58 |
gouthamr | jay-mehta: its a kwarg that has a default value.. its valid to not pass it when it's not required. | 20:59 |
jay-mehta | Yes. | 20:59 |
jay-mehta | But when the unit test try to mock the manager which is actually passing kwarg metadata, ideally it should be passed in unit test too. | 21:00 |
jay-mehta | Don't you think so? | 21:00 |
jay-mehta | Tomorrow if the driver starts utilizing this kwarg, the first correction would be to correct the necessary parameters in unit test | 21:01 |
gouthamr | jay-mehta: its not a bug. i don't see anyplace where the manager's call is mocked.. | 21:02 |
jay-mehta | gouthamr, If i not mistaken, I think all calls as self.driver.setup_server() are being mocked. Am I right? | 21:04 |
jay-mehta | https://review.openstack.org/#/c/360088/1/manila/tests/share/drivers/huawei/test_huawei_nas.py line 3091 | 21:04 |
*** ociuhandu has quit IRC | 21:08 | |
gouthamr | jay-mehta: when you subclass ShareDriver, you can choose to ignore the kwargs; its not ideal, but its valid; so.. you should talk to the driver maintainers to see if they are willing to make the change | 21:13 |
jay-mehta | gouthamr, yes. I agree. It is just a correction. It should have been caught at review stage. If the call accepts a kwarg parameter, it should be passed in unit test, even if the driver is not using it. | 21:14 |
*** merooney has joined #openstack-manila | 21:17 | |
*** merooney_ has joined #openstack-manila | 21:18 | |
*** faiz89 has quit IRC | 21:18 | |
*** merooney has quit IRC | 21:21 | |
*** lpetrut has joined #openstack-manila | 21:30 | |
*** faiz89 has joined #openstack-manila | 21:39 | |
*** vbellur has joined #openstack-manila | 22:06 | |
*** chlong has joined #openstack-manila | 22:12 | |
*** lpetrut has quit IRC | 22:19 | |
*** merooney_ has quit IRC | 22:22 | |
*** merooney has joined #openstack-manila | 22:24 | |
*** faiz89 has quit IRC | 22:27 | |
*** akshai has joined #openstack-manila | 22:30 | |
*** cknight has quit IRC | 22:52 | |
*** xyang1 has quit IRC | 22:55 | |
*** gouthamr has quit IRC | 22:58 | |
*** harlowja has quit IRC | 23:03 | |
*** akshai has quit IRC | 23:23 | |
*** akshai has joined #openstack-manila | 23:24 | |
*** akshai has quit IRC | 23:25 | |
*** gouthamr has joined #openstack-manila | 23:34 | |
*** gouthamr_ has joined #openstack-manila | 23:34 | |
*** gouthamr has quit IRC | 23:38 | |
*** akshai has joined #openstack-manila | 23:49 | |
*** cknight has joined #openstack-manila | 23:50 | |
*** akshai has quit IRC | 23:57 | |
*** Suyi_ has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!