Thursday, 2016-12-22

« Wednesday, 2016-12-21 Index Friday, 2016-12-23 »
openstackgerritMark Sturdevant proposed openstack/manila: GPFS KNFS fix deny access to succeed when possible  https://review.openstack.org/41376200:04
*** mtanino has quit IRC00:25
*** dmellado has quit IRC00:29
*** jcsp_ has joined #openstack-manila00:42
*** xinyanzhang has quit IRC00:45
*** jcsp has quit IRC00:45
*** draynium has quit IRC00:45
*** draynium has joined #openstack-manila00:46
*** tuanluong has joined #openstack-manila00:56
*** scottda has quit IRC00:57
openstackgerritTom Barron proposed openstack/manila: WIP - Remove NovaNetworkPlugin  https://review.openstack.org/41045001:00
*** dmellado has joined #openstack-manila01:03
*** tinwood_holiday has quit IRC01:06
*** scottda has joined #openstack-manila01:07
*** tinwood has joined #openstack-manila01:07
*** chatter has joined #openstack-manila01:08
chatterhey guys01:08
chatterallah is doing01:09
chattersun is not doing allah is doing01:09
chatterto accept islam say that i bear witness that there is no deity worthy of worship except allah and muhammad peace be upon him is his slave and messenger01:09
openstackgerritGoutham Pacha Ravi proposed openstack/manila: NetApp cDOT: Add Intra-vserver migration support  https://review.openstack.org/41378301:09
*** mtanino has joined #openstack-manila01:16
*** chatter has quit IRC01:19
*** dmellado has quit IRC01:21
*** dmellado has joined #openstack-manila01:30
*** catintheroof has quit IRC01:42
*** xinyanzhang has joined #openstack-manila01:42
*** wlhc has joined #openstack-manila01:47
*** eharney has quit IRC02:22
openstackgerritZhenyu Zheng proposed openstack/manila: WIP use glance client  https://review.openstack.org/41386002:24
openstackgerritZhenyu Zheng proposed openstack/manila: WIP use glance client  https://review.openstack.org/41386002:28
openstackgerritZhenyu Zheng proposed openstack/manila: Replace assertDictMatch with assertDictEqual method in tests  https://review.openstack.org/41386702:42
openstackgerritZhenyu Zheng proposed openstack/manila: Replace assertDictMatch with assertDictEqual method in tests  https://review.openstack.org/41386702:44
*** wlhc has quit IRC02:44
*** wlhc has joined #openstack-manila02:45
openstackgerritZhaoBo proposed openstack/manila: Replace assertDictMatch with assertDictEqual method in tests  https://review.openstack.org/41386702:53
*** wlhc has quit IRC02:53
*** wlhc has joined #openstack-manila02:53
openstackgerritzhongjun proposed openstack/manila: Enable IPv6 in manila(network plugins and drivers)  https://review.openstack.org/40677603:06
*** mtanino has quit IRC03:10
openstackgerritTina Tang proposed openstack/manila: [Unity driver] VLAN enhancement  https://review.openstack.org/41003703:16
openstackgerritGoutham Pacha Ravi proposed openstack/manila: NetApp cDOT: Add Intra-vserver migration support  https://review.openstack.org/41378303:21
openstackgerritzhongjun proposed openstack/python-manilaclient: Add share_type filter to pool_list  https://review.openstack.org/36852803:37
*** gouthamr has quit IRC03:47
openstackgerritwlhc proposed openstack/manila: Fix extend size return error,manila image base centos7  https://review.openstack.org/41163103:52
openstackgerritZhaoBo proposed openstack/manila: Remove the assertDictMatch in tests  https://review.openstack.org/41390104:01
*** tuanluong has quit IRC04:23
*** senk has joined #openstack-manila05:01
openstackgerritwlhc proposed openstack/manila: Fix extend size return error,manila image base centos7  https://review.openstack.org/41163105:06
*** senk has quit IRC05:57
*** pcaruana has joined #openstack-manila06:17
*** tuanluong has joined #openstack-manila06:21
*** lpetrut has joined #openstack-manila06:36
*** senk has joined #openstack-manila06:37
*** openstackgerrit has quit IRC06:48
*** a-pugachev has joined #openstack-manila07:14
*** lpetrut has quit IRC07:38
*** openstackgerrit has joined #openstack-manila07:42
openstackgerritDigvijay Ukirde proposed openstack/manila: Add support for manage/unmanage in GPFS driver  https://review.openstack.org/37470507:42
openstackgerritDigvijay Ukirde proposed openstack/manila: Add support for manage/unmanage in GPFS driver  https://review.openstack.org/37470507:46
*** openstackgerrit has quit IRC07:48
*** gregsfortytwo has quit IRC08:20
*** gregsfortytwo has joined #openstack-manila08:22
*** a-pugachev has quit IRC08:32
*** rraja has joined #openstack-manila08:33
*** lpetrut has joined #openstack-manila08:40
*** lpetrut has quit IRC08:54
*** lpetrut has joined #openstack-manila08:54
*** lpetrut has quit IRC09:08
*** wlhc has quit IRC09:11
*** breitz has quit IRC09:22
*** breitz has joined #openstack-manila09:23
*** ganso has joined #openstack-manila09:53
*** a-pugachev has joined #openstack-manila10:09
*** alyson_ has joined #openstack-manila10:11
*** lpetrut has joined #openstack-manila10:27
*** a-pugachev has quit IRC10:30
*** a-pugachev has joined #openstack-manila10:31
*** a-pugachev has quit IRC10:43
*** a-pugachev has joined #openstack-manila10:45
*** openstackgerrit has joined #openstack-manila11:25
openstackgerritTom Barron proposed openstack/manila: WIP - Remove NovaNetworkPlugin  https://review.openstack.org/41045011:25
openstackgerritMerged openstack/manila: GPFS KNFS: Do not reuse ssh prefix in loop  https://review.openstack.org/41323911:27
openstackgerritPony Chou proposed openstack/manila: Add QNAP Manila Driver  https://review.openstack.org/39470311:30
*** ociuhandu has quit IRC11:33
openstackgerritValeriy Ponomaryov proposed openstack/manila: Manila Share Groups  https://review.openstack.org/33509311:33
openstackgerritIvan Berezovskiy proposed openstack/puppet-manila: Pin reno version to reno>=0.1.1,!=2.0.0  https://review.openstack.org/41405011:35
openstackgerritValeriy Ponomaryov proposed openstack/manila: [DNM] Test 4.0  https://review.openstack.org/41373711:38
openstackgerritValeriy Ponomaryov proposed openstack/manila: Manila Share Groups  https://review.openstack.org/33509311:39
openstackgerritValeriy Ponomaryov proposed openstack/manila: [DNM] Test 4.0  https://review.openstack.org/41373711:40
openstackgerritValeriy Ponomaryov proposed openstack/manila: Manila Share Groups  https://review.openstack.org/33509311:43
openstackgerritValeriy Ponomaryov proposed openstack/manila: [DNM] Test 4.0  https://review.openstack.org/41373711:44
*** jcsp_ has quit IRC11:47
*** dsariel has joined #openstack-manila12:01
*** tuanluong has quit IRC12:05
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: [DNM] Test share group client changes  https://review.openstack.org/41258712:14
*** porrua has joined #openstack-manila12:14
openstackgerritValeriy Ponomaryov proposed openstack/manila: Rename consistency group modules to share groups  https://review.openstack.org/40986412:15
openstackgerritValeriy Ponomaryov proposed openstack/manila: Manila Share Groups  https://review.openstack.org/33509312:15
openstackgerritValeriy Ponomaryov proposed openstack/manila: [DNM] Test 4.0  https://review.openstack.org/41373712:15
*** ociuhandu has joined #openstack-manila12:20
*** furlongm_ has quit IRC12:23
*** furlongm has joined #openstack-manila12:23
*** furlongm has quit IRC12:25
*** furlongm has joined #openstack-manila12:26
*** JoseMello has joined #openstack-manila12:52
*** gouthamr has joined #openstack-manila13:00
*** gouthamr has quit IRC13:19
*** gouthamr has joined #openstack-manila13:20
openstackgerritwlhc proposed openstack/manila: Fix extend size return error,manila image base centos7  https://review.openstack.org/41163113:21
*** chlong has joined #openstack-manila13:23
*** JoseMello_ has joined #openstack-manila13:25
*** JoseMello has quit IRC13:26
*** JoseMello_ is now known as JoseMello13:26
openstackgerritwlhc proposed openstack/manila: Fix extend size return error,manila image base centos7  https://review.openstack.org/41163113:37
*** tommylikehu_ has joined #openstack-manila13:39
*** tommylikehu_ has quit IRC13:41
*** tommylikehu_ has joined #openstack-manila13:41
gansobswartz: ping14:25
openstackgerritValeriy Ponomaryov proposed openstack/manila: Manila Share Groups  https://review.openstack.org/33509314:29
openstackgerritValeriy Ponomaryov proposed openstack/manila: [DNM] Test 4.0  https://review.openstack.org/41373714:29
*** eharney has joined #openstack-manila14:30
bswartzganso: pong14:33
gansobswartz: Hi Ben. Isn't driver features and refactors included in the driver proposal deadline?14:33
gansobswartz: *Aren't14:33
bswartzganso: huge factors are14:34
bswartzsimply adding new features or doing small refactors can be done up to the FPF14:34
gansobswartz: oh so the deadline for any new driver feature is the FPF (2 weeks prior to FF) ?14:35
bswartzyes14:35
gansobswartz: ok, thanks!14:36
bswartzthe only reason we called out refactor patches is because some vendors have made giant refactor patches (like 10K lines) to their drivers and it was as hard to review as a whole new driver14:36
*** eharney has quit IRC14:37
gansobswartz: for some reason I had clear as day that the deadline was Dec 19th, my team and I prioritized the development of features to meet this deadline14:38
gansogouthamr: sorry for the -2 ^14:38
tommylikehu_any topic for today's irc meeting?14:41
tommylikehu_bswartz:)14:41
bswartzyeah let me fix the agenda14:41
bswartzokay I reset the meeting agenda14:43
bswartzadd any new topics between (1) and (2)14:43
openstackgerritGoutham Pacha Ravi proposed openstack/manila: Fix Migration test variable injection in CI  https://review.openstack.org/41418014:43
bswartzwe'll need to discuss if we want to meet next week -- it's probably vacation for many of us14:44
openstackgerritGoutham Pacha Ravi proposed openstack/manila: Fix Migration test variable injection in CI  https://review.openstack.org/41418014:44
*** a-pugachev has quit IRC14:49
tommylikehu_bswartz: thanks I don't have any topic this time. when will you be back from holiday?14:49
*** cknight has joined #openstack-manila14:50
*** eharney has joined #openstack-manila14:50
tommylikehu_hey cknight could you spend some time on this patch? https://review.openstack.org/#/c/308212/14:52
cknighttommylikehu: I can look at it.14:53
*** a-pugachev has joined #openstack-manila14:54
tommylikehu_cknight:  thanks14:54
tommylikehu_hey gouthamr14:54
gouthamrtommylikehu_: hey..14:54
tommylikehu_what do you mean by test *all* resource for this patch:https://review.openstack.org/#/c/308212/14:54
cknightganso: Did you get a chance to try the create_share_from_snapshot_support patch?  It's green and has a +2, and the client patch is also up.14:54
gouthamrtommylikehu_: you need to add some rows into all the models that we have...14:55
gansocknight: not yet14:55
bswartztommylikehu_: most people in the US will have next week off, and probably Jan 2 as well14:55
tommylikehu_bswartz:  so only ganso, gouthamr, vponomaryov would be available by then?14:57
bswartzgouthamr should be out too (he's US-based)14:58
bswartzI know vponomaryov will be on vacation14:58
tommylikehu_gouthamr: I think there is no need to test all the models there14:58
tommylikehu_bswartz: wow14:58
gouthamrtommylikehu_: it's going to be slow, all of us will be on vacation afaik14:58
gansotommylikehu_: I will be on vacation too14:59
tommylikehu_gouthamr, bswartz, ganso : fine, I can review these myself.14:59
bswartzokay it looks like we know about the meeting next week then...15:00
tommylikehu_yes15:00
bswartzwe can cover it during announcements15:00
bswartzas soon as freezer ends we'll start up15:00
gouthamrtommylikehu_: there is, see comments from tbarron and ganso.. the test coverage is low now.. only shares and share instances are covered; how about snapshots, networks, share servers, consistency-groups, quotas - at least these models must have tests...15:00
gansogouthamr: +115:00
tommylikehu_gouthamr: ganso, ok ~15:01
gouthamrtommylikehu_: share types, services, export locations, access rules as well;15:02
*** xyang_ has joined #openstack-manila15:03
*** mtanino has joined #openstack-manila15:03
tommylikehu_gouthamr, ganso we are using different testcases testing one logic :)15:04
gouthamrtommylikehu_: yep, we're trying to protect the foreign key relationships15:05
openstackgerritEmilien Macchi proposed openstack/puppet-manila: acceptance: stop testing nfs-ganesha backend  https://review.openstack.org/41418915:09
*** senk has quit IRC15:11
openstackgerritEmilien Macchi proposed openstack/puppet-manila: Pin reno version to reno>=0.1.1,!=2.0.0  https://review.openstack.org/41405015:13
*** akerr has joined #openstack-manila15:20
openstackgerritPony Chou proposed openstack/manila: Add QNAP Manila Driver  https://review.openstack.org/39470315:31
*** a-pugachev has quit IRC15:32
*** mtan_____ has joined #openstack-manila15:34
*** mtanino has quit IRC15:35
*** a-pugachev has joined #openstack-manila15:35
openstackgerritwlhc proposed openstack/manila: Fix extend size return error,manila image base centos7  https://review.openstack.org/41163115:43
*** tommylikehu_ has quit IRC15:43
openstackgerritTom Barron proposed openstack/manila: WIP - Remove NovaNetworkPlugin  https://review.openstack.org/41045015:44
*** dsariel has quit IRC15:45
bswartzganso: ping16:01
gansobswartz: pong16:02
gouthamrganso: hey, so previously this "resync" (or recovery, i forget which one) behavior was tied to the access-deny API16:02
gouthamrganso: i disagree with that, but i understand that it was done so because we didn't have per-access-rule states.. .16:02
gouthamrganso: i think this needs an API16:02
gouthamrof its own16:02
bswartzwhat?16:02
gouthamrhowever, i am still unconvinced who cares about such an api16:02
gansobswartz, gouthamr: we have agreed before that having an API to fix things is very ugly16:02
marksturfor testint16:02
marksturtesting16:02
bswartzgouthamr: please no new API16:02
gansobswartz, gouthamr: so we need to detect the error scenario, to trigger the resync only in this case16:03
gouthamrbswartz ganso: i'm agreeing with you, but i refuse to understand why we should hide this into an existing API16:03
bswartzall that we need IMO is for managers to look at the share access rule states on startup and to go fix anything that's in progress16:03
gouthamrbswartz ganso: there's nothing stopping the driver to process "access-rules" and ensure resyncs on every update-access call16:04
bswartzthat's part of the ensure_share discussion we haven't had yet16:04
bswartzgouthamr: +116:04
gansogouthamr: drivers don't look at "access_rules" in every case16:05
gansogouthamr: we have approved that behavior16:05
gansogouthamr: so we are kinda guilty here16:05
bswartzganso: only in the limited case where we know the old access rules were in sync and we're simply adding or deleting 1 rule16:05
gansobswartz: but according to the new spec, we only have this case now16:06
gansobswartz: that's not limited16:06
gansobswartz: I believe it is the norm16:06
gouthamrganso: "denying" rules will not be in access-rules, but "applying" will16:07
bswartzganso: any time you add rules faster than the backend can apply them we end up batching multiple rules in one update16:07
gansobswartz: still, we use the add_rules and delete_rules variables, in that case, the driver will not look at the "access_rules" variable, so it cannot correct itself16:07
gouthamrganso: i.e, "access-rules" will contain all rules that must exist on the backend; "add_rules" will contain "applying" rules and "delete_rules" will contain "denying" riules16:08
gouthamrrules*16:08
gouthamrganso: the add_rules and delete_rules parameters are for the benefit of iirc 1 driver16:08
tbarronganso: are you arguing for a flag that says "do a full refresh" so the driver will do that rather than just applying the delta16:08
gansogouthamr: what if it successively cannot apply/deny a rule? drivers don't maintain history of attempts, and they don't look at rule 'state' to know if they were in error before16:09
gouthamrganso: drivers that can sync rules atomically must ignore add_rules16:09
gansotbarron: we have that "flag" implemented, we signal it through empty add_rules and delete_rules lists16:09
gansogouthamr: yes, those drivers will not have problems16:09
gansogouthamr: and it is a lot more than 1 driver16:09
gansogouthamr: initially it was just ceph16:10
gansogouthamr: but several drivers followed that path later16:10
gouthamrganso: hmmm.. then that must be some misunderstanding of the documentation16:10
marksturMost drivers only do the resync if there add and deletes are both []16:11
gansomarkstur: exactly16:11
gouthamr:(16:11
gansomy idea of solution is: let's detect when error's occurred and trigger resync on the drivers16:11
marksturIt could be an optimization, but also I think it just was a way to use the old code and introduce less new risk16:11
marksturbut that leaves the resync code untest I think in many cases16:12
tbarronganso: I understand how we know to do the bswartz resync use case, but how would we detect your circumstance?16:12
*** tommylikehu_ has joined #openstack-manila16:12
openstackgerritValeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature  https://review.openstack.org/35526416:12
gansopreviously we had a mess of resyncs triggered without proper reason (currently it is like that), let's forget that16:13
gansoso if a rule is in error16:13
*** xinyanzhang has quit IRC16:13
gansoand we try to deny it, and it fails again16:13
gansolet's trigger the resync within the same request16:13
gansoapplying or denying rules that fail end up in error, which the user will try to deny16:14
gouthamrganso: a deny should never fail16:14
markstura deny can fail16:14
gouthamrhow?16:14
gansogouthamr: drivers already handle the deny case where a rule does not exist, they don't raise exceptions16:14
marksturConnection problem to the backend16:14
gansogouthamr: but if it actually fails denying, it will fail16:14
*** JoseMello has quit IRC16:14
marksturIf the backend says that access might exist but I can't delete it or verify it right now16:15
gouthamrokay, so then it works as expected - we set the rule to error and the user retries16:15
gansogouthamr: the user will naturally try to deny the rule16:15
gansogouthamr: if deny fails, we have a problem16:15
gouthamruser can retry denying until the deny gets through, or call an administrator... where had the driver lost its "sync" of access rules here?16:16
tbarronganso: why would a refresh succeed when the denies are consistently failing?16:16
gansotbarron: because the problem could prevent new rules from being applied16:16
gansotbarron: so the new rules would transition to error16:17
gansotbarron: they are in manila DB, but they are not in the backend16:17
*** tommylikehu_ has quit IRC16:17
*** nkrinner_afk has quit IRC16:17
gansotbarron: so the resync would wipe all the rules and tell the backend the correct rules16:18
tbarronganso: so I like the idea of the driver having the smarts to ask for a resync/refresh rather than the manager assuming that because two denies failed in a row it should force a refresh/resync16:18
gouthamrganso: o.O16:18
gouthamrganso: wipe out all rules sounds drastic16:18
gansotbarron: except that the driver may not know where to ask for a resync, that would be a new behavior we would need to introduce16:18
tbarronganso: drivers that need that should ask for it, not make a rule for everyone16:18
tbarronganso: yes, it would be new, but I worry about the manager using that heuristic inappropriately16:19
gansotbarron: currently it is using it inappropriately16:19
gansogouthamr: and we are currently wiping all the rules every time we add 2 rules very fast16:19
gansogouthamr: which is incorrect trigger16:20
gansotbarron: a specific exception would be nice16:20
gansotbarron: and would be a minimal amount of work16:20
gouthamrganso: we'll do it even if it means a lot of work, but i'm still unconvinced about this problem. existing drivers ignoring access_rules sounds like bad reading of the intent of update_access... by ensuring that we're sending the right information in add_rules and delete_rules, we're ensuring the right behavior on those backends that have to genuinely ignore access_rules16:22
*** senk has joined #openstack-manila16:23
gouthamrganso: i'd like to see a vendor driver complaining that their backend is getting out of sync with the manila database, can we then consider the changes you're proposing?16:24
*** cknight1 has joined #openstack-manila16:25
gouthamrganso: add_rules and delete_rules are essentially "allow_access" and "deny_access" - with the magic that the driver can use the "access_rules" parameter to perform resyncs at will16:26
gouthamrganso: for those backends that can't atomically commit a bunch of rules ^16:26
*** cknight has quit IRC16:26
tbarronyeah, that's kinda where I was going to go - arguing against my "request a resync" - the info is already there, so the driver doesn't need to say "please make me resync", it can just do it.16:27
gansogouthamr: ok, I have yet to see the type of problems that may arise after the new spec implementation, I know there is some confidence in sending the correct information in add_rules and delete_rules, and the mechanism is handling the concurrency now much better than it previously was when we had the old approach. One of my backends does not run into this16:27
gansoproblem, although the other may, and I have yet to test that with the new spec implementation, but in that case, as you said, I can fix the problem by doing the resync myself by looking at the "access_rules" var.16:27
bswartzI'm still following this discussion16:27
gouthamrtbarron: +1 - if the driver can raise an "ResyncMe" exception, it knows it is out of sync, so it can use the access_rules parameter16:28
tbarrongouthamr: +116:28
bswartzI think maybe part of the confusion is that the implementation is evolving and some people are thinking about the old implementation and some people are thinking about the new one?16:28
gansogouthamr: but in that case it could at the access_rules itself instead of raising that exception16:28
gansotbarron: we just found out that the exception is unecessary16:28
tbarronthat leaves us with the restart share service case, where a genuine resync would be triggered by sending empty add and delete rules lists16:28
tbarronganso: +116:29
gansotbarron: from the spec: On restarting the share-manager service, the ‘recovery’ step for access rules will be updated. All rules in ‘applying’ state will be reverted to ‘queued_to_apply’ before requesting the driver to sync access rules for a given share instance.16:29
tbarronganso: that sound right to me16:30
gansogouthamr: what if reseting it back to applying leads to error because the service got stopped right after it applied in the backend, but not yet set to active in manila DB?16:30
gouthamrganso: why would it lead to an error?16:31
gouthamrganso: incomplete rule addition on the back end?16:31
gansogouthamr: either that or ShareAccessExists16:31
gouthamrganso: ShareAccessExists should never be raised by a backend16:32
gansogouthamr: the backend can swallow a ShareAccessExists16:32
gouthamrganso: according to manila ShareAccessExists has already been checked at teh API16:32
tbarronbackends should ignore add for rule that is already there or delete for rule that isn't there16:32
gansogouthamr: this is not at the API, this is when manager is restarted16:32
gouthamrganso: yep.. don't raise ShareAccessExists -> that's a manila API exception. the manager will not expect that16:33
gansogouthamr: anyway, we have yet to see if it causes problems for a certain vendor16:33
tbarron?16:33
tbarronsomething inherent in a backend or just a bug?16:34
gouthamrganso: i'll update the driver docstring...16:34
gansotbarron: probably a scenario not covered by a vendor16:34
gouthamrShareAccessExists? not sure...16:34
gansogouthamr: no, other problems16:34
gansogouthamr, tbarron: I mean, I presume most problems may arise from drivers failing while facing some inconsistency between what their being asked to do and what is on their backend. But as you said, they already have "access_rules", so they should know what to do with the data and fix themselves16:36
gansogouthamr: Could you please update the docstring with this guideline?16:36
gouthamrganso vponomaryov tbarron bswartz markstur xyang_ toabctl: Can I please haz +2/+W on this: https://review.openstack.org/#/c/414180/ -> it's a CI bug that i don't want to push 24 hours for :(16:36
gouthamr^ i'd like to report migration tests on teh netapp CI16:36
marksturgouthamr: So don't tell vponomaryov?  Is that what you are saying?16:37
bswartzgouthamr: you're going to run afoul of the 24 hour rule16:37
bswartzoh I see you addressed that16:37
*** senk has quit IRC16:37
gouthamr:P #notmysanta16:38
gansolol16:39
bswartzgouthamr: this is a perfect example of a misuse of a trivial fix16:39
gouthamrganso: sure thing.. i can fix the docstring16:39
bswartztrivial fixes are truly trivial16:39
bswartzthis actually fixes a bug16:39
gouthamrbswartz: but it is a TrivialFix, our tests don't assume multi-backend, but our CI scripts do16:40
gouthamrbswartz: so there's no bug in the project...16:40
gansogouthamr: thanks16:40
bswartzgouthamr: then it's a small RFE16:40
gouthamr:D16:40
bswartzat this point in the release you don't need a LP bug for every change16:41
gouthamrbswartz: "launchpad is too limited for that"16:41
marksturgouthamr: If it is so trivial, then how did it break 3rd-party CI?16:41
tbarrongouthamr: run_host_assisted_migration_tests will be set to True by default for all drivers with this change, right?16:41
bswartzjust don't abuse trivial fix when you don't feel like doing the paperwork16:41
vponomaryovgouthamr: tbarron is right, you change logic there16:41
vponomaryovgouthamr: so, you fix yuors and force some other CI fail and add its own fix too16:42
gouthamrtbarron: good catch. I didn't see that option was defaulting to True.. i might need ganso's help to fix that16:42
gouthamrvponomaryov: see why i asked you for review16:42
gansohumm indeed we should not break the existing CI, although the patch proposes the behavior we want to have16:43
gansothat is showing which CI's are running single-backend and do not have host-assisted-migration tests disabled explicitely16:44
gansobecause, back then that wouldn't make sense16:44
tbarronganso: glad you added that last sentence :D16:44
gansogouthamr: our only solution would to change the default to False, which would cause third-party CI's to have their migration tests automatically disabled, whereas they were running before16:45
gansogouthamr: would *be16:45
gansogouthamr: I don't fully agree with that solution16:46
vponomaryovganso: how many words when the fix is simple )16:46
gouthamrganso: we've already enabled this flag on the first party drivers where necessary?16:46
vponomaryovgouthamr: just add "new" logic, that you will enable explicitly16:46
gansogouthamr: I don't think so, it is running automatically because of previous condition16:46
gouthamrvponomaryov ganso: okay, i get it - it'll default to False but we'll enable it for all first-party drivers - and disable it for the dummy driver?16:48
marksturtrivial?16:48
gansomarkstur, vponomaryov: proper solution will be non-trivial16:48
gouthamryeah, sorry. i'll do the paperwork16:49
vponomaryovmarkstur: the most complicated trivial fix among all trivial fixes )16:49
marksturvponomaryov: Some day we'll look back and say "remember that trivial fix gouthamr started back in 2016..."16:52
* gouthamr goodtimes16:53
marksturlol16:53
gouthamrvponomaryov: if we have variables for many of those test skips, why do we use iniset to $TEMPEST_CONFIG again? https://github.com/openstack/manila/blob/master/contrib/ci/post_test_hook.sh#L15916:56
vponomaryovgouthamr: again?16:57
vponomaryovit is set only once16:57
gouthamrvponomaryov: oh.. i see the pattern.. need to fix a couple of inconsistencies17:03
*** senk has joined #openstack-manila17:15
*** porrua has quit IRC17:18
*** tommylikehu_ has joined #openstack-manila17:25
*** xyang_ has quit IRC17:27
openstackgerritPony Chou proposed openstack/manila: Add QNAP Manila Driver  https://review.openstack.org/39470317:46
*** ociuhandu has quit IRC17:48
*** senk has quit IRC17:56
*** akerr has quit IRC17:57
*** porrua has joined #openstack-manila17:59
*** lpetrut has quit IRC18:13
gansohas anyone experienced: "PasteAppNotFound: Could not load paste app 'osapi_share' from /etc/manila/api-paste.ini" upon updating to latest version of manila?18:14
openstackgerritAkira KAMIO proposed openstack/manila: Fix nfs server service name for rhel, suse  https://review.openstack.org/40784618:20
*** ociuhandu has joined #openstack-manila18:23
*** xyang_ has joined #openstack-manila18:30
*** xyang_ has quit IRC18:31
*** lpetrut has joined #openstack-manila18:33
*** senk has joined #openstack-manila18:35
openstackgerritAkira KAMIO proposed openstack/manila: Fix nfs server service name for rhel, suse  https://review.openstack.org/40784618:40
*** a-pugachev has quit IRC18:42
*** xyang_ has joined #openstack-manila18:44
*** lpetrut has quit IRC18:46
openstackgerritAkira KAMIO proposed openstack/manila: Fix nfs server service name for rhel, suse  https://review.openstack.org/40784618:52
openstackgerritOpenStack Proposal Bot proposed openstack/manila: Updated from global requirements  https://review.openstack.org/41428619:03
*** lpetrut has joined #openstack-manila19:06
*** cknight1 has quit IRC19:15
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: [DNM] Test share group client changes  https://review.openstack.org/41258719:20
*** senk has quit IRC19:23
*** assassin has quit IRC19:50
openstackgerritGoutham Pacha Ravi proposed openstack/manila: Fix test variable injection in CI  https://review.openstack.org/41432320:14
openstackgerritGoutham Pacha Ravi proposed openstack/manila: Fix test variable injection in CI  https://review.openstack.org/41418020:15
*** xyang1 has joined #openstack-manila20:15
openstackgerritMerged openstack/puppet-manila: acceptance: stop testing nfs-ganesha backend  https://review.openstack.org/41418920:25
openstackgerritMerged openstack/puppet-manila: Pin reno version to reno>=0.1.1,!=2.0.0  https://review.openstack.org/41405020:26
*** porrua has quit IRC20:34
*** rraja has quit IRC20:40
*** rraja has joined #openstack-manila20:43
*** rraja has quit IRC20:44
*** mtan_____ has quit IRC21:09
*** cknight has joined #openstack-manila21:36
*** eharney has quit IRC21:42
*** gouthamr has quit IRC21:46
*** cknight has quit IRC22:00
*** alyson_ has quit IRC22:06
*** ganso has quit IRC22:23
*** chlong has quit IRC22:34
*** chlong has joined #openstack-manila22:41
*** furlongm has quit IRC22:45
*** tommylikehu_ has quit IRC22:46
*** tommylikehu_ has joined #openstack-manila22:46
*** tommylikehu_ has quit IRC22:48
*** tommylikehu_ has joined #openstack-manila22:48
*** tommylikehu_ has quit IRC22:52
*** tommylikehu_ has joined #openstack-manila23:05
*** tommylikehu_ has quit IRC23:08
*** xyang1 has quit IRC23:25
*** cknight has joined #openstack-manila23:29
*** lpetrut has quit IRC23:31
*** gouthamr has joined #openstack-manila23:50
« Wednesday, 2016-12-21 Index Friday, 2016-12-23 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!