*** martyt has quit IRC | 00:07 | |
*** tommylikehu has quit IRC | 00:46 | |
*** tommylikehu has joined #openstack-manila | 00:47 | |
*** david-lyle has joined #openstack-manila | 00:51 | |
*** david-lyle has quit IRC | 00:55 | |
*** zhonghua has quit IRC | 00:59 | |
*** zhonghua has joined #openstack-manila | 01:00 | |
openstackgerrit | Ha Van Tu proposed openstack/manila: [api-ref] Refactor share instance export locations API documentation https://review.openstack.org/415114 | 01:07 |
---|---|---|
openstackgerrit | Ryan Liang proposed openstack/manila: Rename the options https://review.openstack.org/415079 | 01:31 |
*** martyt has joined #openstack-manila | 02:08 | |
*** martyt has quit IRC | 02:12 | |
*** xinyanzhang has joined #openstack-manila | 02:20 | |
*** martyt has joined #openstack-manila | 02:30 | |
*** gcb has joined #openstack-manila | 02:36 | |
*** rraja has joined #openstack-manila | 02:46 | |
*** david-lyle has joined #openstack-manila | 02:52 | |
*** david-lyle has quit IRC | 02:57 | |
*** tuanluong has joined #openstack-manila | 03:25 | |
*** tommylikehu_ has quit IRC | 03:34 | |
*** tommylikehu_ has joined #openstack-manila | 03:35 | |
*** rraja has quit IRC | 04:18 | |
*** martyt has quit IRC | 05:05 | |
*** shausy has joined #openstack-manila | 05:10 | |
*** shausy has quit IRC | 05:27 | |
*** shausy has joined #openstack-manila | 05:32 | |
*** shausy has quit IRC | 05:32 | |
*** dsariel has quit IRC | 06:04 | |
*** wlhc has joined #openstack-manila | 06:04 | |
*** martyt has joined #openstack-manila | 06:06 | |
*** rraja has joined #openstack-manila | 06:43 | |
*** lpetrut has joined #openstack-manila | 06:50 | |
*** martyt has quit IRC | 07:12 | |
*** martyt has joined #openstack-manila | 07:22 | |
*** jprovazn has joined #openstack-manila | 07:26 | |
openstackgerrit | zhongjun proposed openstack/manila: P]Enable IPv6 in manila(Implement in generic driver) https://review.openstack.org/416162 | 07:37 |
*** pcaruana has joined #openstack-manila | 07:41 | |
openstackgerrit | zhongjun proposed openstack/manila: [WIP]Enable IPv6 in manila(Implement in generic driver) https://review.openstack.org/416162 | 07:42 |
*** nkrinner_afk is now known as nkrinner | 07:46 | |
*** lpetrut has quit IRC | 07:48 | |
*** dmellado has joined #openstack-manila | 07:57 | |
*** martyt has quit IRC | 07:58 | |
*** martyt has joined #openstack-manila | 07:59 | |
*** martyt has quit IRC | 07:59 | |
*** rraja has quit IRC | 08:30 | |
*** dsariel has joined #openstack-manila | 08:32 | |
*** wlhc has quit IRC | 08:56 | |
*** david-lyle has joined #openstack-manila | 08:57 | |
*** david-lyle has quit IRC | 09:01 | |
*** absubram has joined #openstack-manila | 09:05 | |
openstackgerrit | zhongjun proposed openstack/manila: [WIP]Enable IPv6 in manila(Implement in generic driver) https://review.openstack.org/416162 | 09:16 |
*** zhugaoxiao has joined #openstack-manila | 09:17 | |
*** tinwood has joined #openstack-manila | 09:24 | |
*** lpetrut has joined #openstack-manila | 09:28 | |
*** dsariel has quit IRC | 09:33 | |
*** lpetrut1 has joined #openstack-manila | 09:33 | |
*** lpetrut has quit IRC | 09:34 | |
*** lpetrut1 is now known as lpetrut | 09:34 | |
*** david-lyle has joined #openstack-manila | 09:58 | |
*** david-lyle has quit IRC | 10:02 | |
*** a-pugachev has joined #openstack-manila | 10:09 | |
*** JoseMello has joined #openstack-manila | 10:28 | |
*** shausy has joined #openstack-manila | 11:38 | |
*** gcb has quit IRC | 11:39 | |
*** gcb has joined #openstack-manila | 11:41 | |
*** a-pugachev has quit IRC | 11:50 | |
*** a-pugachev has joined #openstack-manila | 11:54 | |
*** david-lyle has joined #openstack-manila | 11:59 | |
*** porrua has joined #openstack-manila | 12:03 | |
*** david-lyle has quit IRC | 12:04 | |
*** tuanluong has quit IRC | 12:04 | |
*** a-pugachev has quit IRC | 12:07 | |
openstackgerrit | zhongjun proposed openstack/manila: [WIP]Enable IPv6 in manila(Implement in generic driver) https://review.openstack.org/416162 | 12:27 |
*** a-pugachev has joined #openstack-manila | 12:34 | |
*** dsariel has joined #openstack-manila | 12:59 | |
*** rraja has joined #openstack-manila | 13:03 | |
*** eharney has joined #openstack-manila | 13:36 | |
*** shausy has quit IRC | 13:36 | |
*** timcl has joined #openstack-manila | 13:38 | |
openstackgerrit | Tom Barron proposed openstack/manila: Do Not Merge https://review.openstack.org/416238 | 13:38 |
openstackgerrit | Tom Barron proposed openstack/python-manilaclient: Remove Nova Net option for share networks https://review.openstack.org/416239 | 13:39 |
*** shausy has joined #openstack-manila | 13:40 | |
*** eharney has quit IRC | 13:41 | |
*** shausy has quit IRC | 13:43 | |
*** scottda has quit IRC | 13:47 | |
*** furlongm_ has quit IRC | 13:48 | |
*** furlongm has joined #openstack-manila | 13:48 | |
*** scottda has joined #openstack-manila | 13:54 | |
*** tommylik_ has joined #openstack-manila | 13:54 | |
tommylik_ | ping tbarron | 13:54 |
*** tommylik_ has quit IRC | 13:55 | |
*** eharney has joined #openstack-manila | 13:55 | |
*** tommylik_ has joined #openstack-manila | 13:55 | |
*** tommylikehu_ has quit IRC | 13:56 | |
*** tommylik_ has quit IRC | 13:56 | |
*** tommylikehu_ has joined #openstack-manila | 13:56 | |
tbarron | tommylikehu: pong | 13:57 |
tommylikehu_ | thanks tbarron do you know who knows generic driver well? | 14:00 |
*** zhugaoxiao has quit IRC | 14:00 | |
*** david-lyle has joined #openstack-manila | 14:01 | |
*** zhugaoxiao has joined #openstack-manila | 14:01 | |
*** david-lyle has quit IRC | 14:05 | |
tbarron | tommylikehu_: probably vponmaryov knows it best as he and others from mirantis wrote it | 14:06 |
tommylikehu_ | tbarron: great, but I think he is on traveling maybe, anyone else here works in mirantis? | 14:08 |
tbarron | tommylikehu_: I don't know. If you run 'git blame manila/share/drivers/generic.py' you'll see the folks who have done commits there, but probably you should just ask general questions and maybe we'll all learn :D | 14:10 |
bswartz | hey all | 14:12 |
bswartz | Vacation is over and I'm back | 14:12 |
tbarron | tommylikehu_: ^^^ that guy did the specs for the work on that driver I believe | 14:12 |
tbarron | bswartz: happy new year | 14:12 |
bswartz | happy new year! | 14:12 |
* tbarron just got back himself | 14:12 | |
tbarron | bswartz: tommylikehu_ has questions about generic driver; git blame authors are still on vacation, but you are here :D | 14:13 |
bswartz | yeah vponomaryov is on holiday until Jan 10 | 14:13 |
tommylikehu_ | bswartz, tbarron happy new year | 14:13 |
bswartz | orthodox christmas is somewhat late | 14:13 |
tbarron | tommylikehu_: bswartz I'm going to put you as reviewers on my patches to remove nova-net support | 14:14 |
bswartz | tbarron: adding me as a reviewer doesn't do anything | 14:14 |
bswartz | you have to PM me the gerrit link | 14:15 |
*** FL1SK has quit IRC | 14:15 | |
tbarron | bswartz: k, I was forgetting the bswartz process :D | 14:15 |
bswartz | well I hope it's not just me | 14:15 |
bswartz | I just can't tell what adding someone to the reviewer list actually does | 14:15 |
tbarron | bswartz: it sends you mail politely requesting a review | 14:16 |
tbarron | bswartz: preferred by many to a PM ping | 14:16 |
bswartz | is there a gerrit query that lists everything I'm tagged as reviewer on? | 14:16 |
bswartz | tbarron: I get hundreds of those mail per week | 14:16 |
tommylikehu_ | bswartz: in generic driver we can configure admin network for shares, when introduce IPv6 should the tenant network have the same ip version with the admin's one? | 14:17 |
tbarron | bswartz: yeah, not arguing here one way or the other. | 14:17 |
bswartz | tommylikehu_: The tenant network has to match what the tenant expects, but nobody can see the admin network except the administrator | 14:18 |
bswartz | so I don't see a huge problem if they were different | 14:19 |
bswartz | the only area where we might get into trouble is inside the guest VM if it's a hassle to deal with both v4 and v6 for the two cases | 14:19 |
bswartz | but that's a service VM issue more than an architectural one | 14:19 |
tommylikehu_ | bswartz: so that means we only support IPv4 admin network based on our current codes. | 14:20 |
bswartz | tommylikehu_: yes I expect there's significant work to be done in the generic driver for IPv6 support | 14:20 |
*** dustins has joined #openstack-manila | 14:21 | |
tommylikehu_ | bswartz: what does 'significant' means here, should we consider support IPv6 in admin network? | 14:27 |
tommylikehu_ | I think it would be a lot of code and test | 14:28 |
*** cdelatte has joined #openstack-manila | 14:28 | |
bswartz | tommylikehu_: eventually we'll want to support v6 everywhere, but the immediate goal should be enough support to be able to test the feature | 14:28 |
tommylikehu_ | ok | 14:29 |
tommylikehu_ | one more confirm, the vm could communicate with each other even they are from different ip version's subnet when they are attached to one router? | 14:31 |
bswartz | tommylikehu_: no the admin network has to be a single IP version | 14:32 |
bswartz | if the admin chooses to use ipv6 for his admin network, then everything must support that, even if tenants are using v4 | 14:33 |
*** absubram has quit IRC | 14:43 | |
tommylikehu_ | bswartz: ok, how about the service network, this could be used when dhss is true with neutron , also it has the ip version | 14:44 |
bswartz | tommylikehu_: same as the admin network -- it has to match what's being used on the backend side | 14:44 |
tommylikehu_ | bswartz: take these two into consideration when report driver's ip version capability would be a reasonable measure? | 14:47 |
*** chlong has joined #openstack-manila | 14:55 | |
openstackgerrit | Merged openstack/manila: GPFS: Add update_access() https://review.openstack.org/409950 | 14:55 |
*** david-lyle has joined #openstack-manila | 15:01 | |
*** ociuhandu has quit IRC | 15:03 | |
*** david-lyle has quit IRC | 15:06 | |
*** cknight has joined #openstack-manila | 15:06 | |
bswartz | tommylikehu_: not really -- the "capability" is only for the user-facing network interfaces | 15:08 |
bswartz | for the backend-facing interfaces the driver should simply not startup if it can't work with the configure admin networks | 15:09 |
*** timcl has quit IRC | 15:22 | |
*** rraja is now known as rraja|afk | 15:25 | |
tommylikehu_ | bswartz: thans :) | 15:27 |
tommylikehu_ | thanks | 15:27 |
tommylikehu_ | tbarron, ganso, gouthamr this patch is ready for your review :) https://review.openstack.org/#/c/308212/ | 15:28 |
tbarron | tommylikehu_: I am trying to carve off some time to review that, and the ipv6 changes too. | 15:29 |
tbarron | tommylikehu_: Have you thought about how to make sure that in the future, when someone changes the DB schema to add new tables with new foreign key dependencies, your tests for DB purge will also get changed appropriagely. | 15:31 |
tbarron | appropriately? | 15:31 |
tbarron | tommylikehu_: will your tests just start failing if someoone does this and doesn't change your tests? | 15:31 |
tommylikehu_ | yes just failing | 15:31 |
tommylikehu_ | to prevent the code from merging and raise attention | 15:32 |
tbarron | tommylikehu_: good, I think that is the right goal | 15:32 |
*** absubram has joined #openstack-manila | 15:37 | |
*** rraja|afk has quit IRC | 15:38 | |
tommylikehu_ | tbarron: I tried to build the table with correct sequence and dependencies automatically, but failed. | 15:39 |
*** chlong has quit IRC | 15:41 | |
*** tommylikehu_ has quit IRC | 15:42 | |
*** shausy has joined #openstack-manila | 15:51 | |
*** chlong has joined #openstack-manila | 15:54 | |
*** shausy has quit IRC | 15:59 | |
*** FL1SK has joined #openstack-manila | 16:00 | |
*** zhugaoxiao has quit IRC | 16:03 | |
*** xinyanzhang has quit IRC | 16:03 | |
*** zengyingzhe__ has quit IRC | 16:03 | |
*** zhugaoxiao has joined #openstack-manila | 16:04 | |
*** zengyingzhe has joined #openstack-manila | 16:05 | |
openstackgerrit | Merged openstack/puppet-manila: Deprecate signing_dir option https://review.openstack.org/415354 | 16:11 |
*** lseki has joined #openstack-manila | 16:13 | |
lpetrut | Hi, so, we have an issue with the Windows SMB driver. It inherits the Generic driver and this commit broke it, especially considering the interface changes: https://github.com/openstack/manila/commit/c162c4540436f54af91b2f42a9138bb45bc88042 | 16:25 |
lpetrut | I was thinking about moving the common methods to a base class, avoiding duplicated code or having the driver broken like this in the future. | 16:25 |
bswartz | lpetrut: hmm -- yeah I think directly inheriting from the generic driver is dangerous because that driver does tend to change over time | 16:26 |
*** Yogi1 has joined #openstack-manila | 16:27 | |
bswartz | lpetrut: when generic was designed, all of the code that was intended to be shared was broken out into other modules, and what remained in the generic driver itself was assumed to not be shared | 16:27 |
*** timcl has joined #openstack-manila | 16:27 | |
*** dmellado_ has joined #openstack-manila | 16:28 | |
lpetrut | got it, I'll send a fix ASAP so that we don't risk releasing a broken driver | 16:28 |
lpetrut | meanwhile, we have stopped the CI from sending reports | 16:29 |
lpetrut | unfortunately, it seems like it was down when that patch got in | 16:30 |
bswartz | too many CI systems are down all the time | 16:30 |
*** chlong has quit IRC | 16:31 | |
*** chlong has joined #openstack-manila | 16:46 | |
*** dmellado has quit IRC | 16:53 | |
*** nkrinner is now known as nkrinner_afk | 17:00 | |
*** lpetrut has quit IRC | 17:00 | |
*** david-lyle has joined #openstack-manila | 17:03 | |
*** david-lyle has quit IRC | 17:08 | |
*** timcl has quit IRC | 17:15 | |
*** lpetrut has joined #openstack-manila | 17:26 | |
*** timcl has joined #openstack-manila | 17:27 | |
*** xyang_ has joined #openstack-manila | 17:37 | |
*** a-pugachev has quit IRC | 17:50 | |
*** breitz has joined #openstack-manila | 17:51 | |
*** pcaruana has quit IRC | 17:58 | |
openstackgerrit | Clinton Knight proposed openstack/python-manilaclient: Add create_share_from_snapshot_support extra spec https://review.openstack.org/356683 | 18:00 |
*** david-lyle has joined #openstack-manila | 18:03 | |
*** david-lyle has quit IRC | 18:08 | |
*** timcl has quit IRC | 18:09 | |
*** chlong has quit IRC | 18:10 | |
*** porrua has quit IRC | 18:33 | |
*** dsariel has quit IRC | 18:33 | |
*** chlong has joined #openstack-manila | 18:41 | |
*** david-lyle has joined #openstack-manila | 18:42 | |
*** chlong has quit IRC | 18:48 | |
*** porrua has joined #openstack-manila | 18:53 | |
*** chlong has joined #openstack-manila | 19:02 | |
*** ociuhandu has joined #openstack-manila | 19:08 | |
*** catintheroof has quit IRC | 19:33 | |
*** Yogi1 has quit IRC | 19:34 | |
*** catintheroof has joined #openstack-manila | 19:34 | |
*** JoseMello has quit IRC | 19:35 | |
*** tinwood has quit IRC | 19:35 | |
*** tinwood has joined #openstack-manila | 19:36 | |
*** JoseMello has joined #openstack-manila | 19:38 | |
*** harlowja has joined #openstack-manila | 19:38 | |
*** catintheroof has quit IRC | 19:38 | |
*** openstackgerrit has quit IRC | 20:03 | |
bswartz | tbarron: you going to update https://review.openstack.org/#/c/410449/ ? | 20:05 |
*** openstackgerrit has joined #openstack-manila | 20:06 | |
openstackgerrit | Tom Barron proposed openstack/manila: Remove nova net support from service_instance https://review.openstack.org/410449 | 20:06 |
openstackgerrit | Tom Barron proposed openstack/manila: Remove NovaNetworkPlugin https://review.openstack.org/410450 | 20:06 |
tbarron | bswartz: ^^ | 20:06 |
bswartz | wow that was fast service! | 20:06 |
tbarron | bswartz: co-incidental :D | 20:07 |
tbarron | bswartz: on the second, sanity check the microversion no-backwards compat responsed to ganso's good questions | 20:07 |
tbarron | response | 20:08 |
openstackgerrit | Tom Barron proposed openstack/python-manilaclient: Remove Nova Net option for share networks https://review.openstack.org/416239 | 20:11 |
*** xyang_ has quit IRC | 20:12 | |
*** xyang_ has joined #openstack-manila | 20:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/manila: Updated from global requirements https://review.openstack.org/415968 | 20:23 |
openstackgerrit | Clinton Knight proposed openstack/manila: Implement share revert to snapshot https://review.openstack.org/340502 | 20:52 |
openstackgerrit | Clinton Knight proposed openstack/python-manilaclient: Support share revert to snapshot in Manila client https://review.openstack.org/340556 | 20:52 |
*** absubram has quit IRC | 20:56 | |
*** porrua has quit IRC | 21:03 | |
*** JoseMello has quit IRC | 21:05 | |
*** xyang_ has quit IRC | 21:10 | |
*** xyang_ has joined #openstack-manila | 21:12 | |
*** xyang_ has quit IRC | 21:15 | |
*** xyang_ has joined #openstack-manila | 21:23 | |
*** xyang_ has quit IRC | 21:24 | |
*** xyang_ has joined #openstack-manila | 21:25 | |
*** xyang_ has quit IRC | 21:26 | |
*** breitz has quit IRC | 21:34 | |
*** breitz has joined #openstack-manila | 21:41 | |
*** cdelatte has quit IRC | 21:48 | |
*** cknight has quit IRC | 21:51 | |
*** eharney has quit IRC | 22:01 | |
*** dustins has quit IRC | 22:02 | |
*** chlong has quit IRC | 22:10 | |
*** jprovazn has quit IRC | 22:12 | |
*** xyang_ has joined #openstack-manila | 22:19 | |
*** xyang_ has quit IRC | 22:20 | |
openstackgerrit | Merged openstack/python-manilaclient: Add create_share_from_snapshot_support extra spec https://review.openstack.org/356683 | 22:22 |
*** lpetrut has quit IRC | 22:27 | |
*** lseki has quit IRC | 22:30 | |
*** xyang_ has joined #openstack-manila | 22:51 | |
*** tommylikehu_ has joined #openstack-manila | 22:52 | |
*** xyang_ has quit IRC | 22:54 | |
*** xyang_ has joined #openstack-manila | 22:55 | |
*** xyang_ has quit IRC | 22:58 | |
*** tommylikehu_ has quit IRC | 22:59 | |
*** tommylikehu_ has joined #openstack-manila | 22:59 | |
openstackgerrit | Tom Barron proposed openstack/manila: DO NOT MERGE https://review.openstack.org/352606 | 23:01 |
*** openstack has joined #openstack-manila | 23:16 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!