| *** harlowja has joined #openstack-manila | 00:06 | |
| *** cknight has joined #openstack-manila | 00:24 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Refactor Access Rules APIs https://review.openstack.org/369668 | 00:29 |
|---|---|---|
| *** cknight has quit IRC | 00:30 | |
| *** tuanluong has joined #openstack-manila | 01:11 | |
| *** mtanino has quit IRC | 01:14 | |
| *** bswartz has quit IRC | 01:24 | |
| *** ianychoi has quit IRC | 01:27 | |
| *** ianychoi has joined #openstack-manila | 01:29 | |
| openstackgerrit | TommyLike proposed openstack/manila: Add manila-manage db purge command https://review.openstack.org/308212 | 01:34 |
| *** bswartz has joined #openstack-manila | 01:39 | |
| openstackgerrit | Merged openstack/manila: Implement share revert to snapshot https://review.openstack.org/340502 | 01:44 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Refactor Access Rules APIs https://review.openstack.org/369668 | 01:47 |
| gouthamr | huh? | 01:48 |
| *** breitz has quit IRC | 01:58 | |
| openstackgerrit | Pony Chou proposed openstack/manila: Add QNAP Manila Driver https://review.openstack.org/394703 | 02:12 |
| *** houming has joined #openstack-manila | 02:14 | |
| openstackgerrit | Tina Tang proposed openstack/manila: [Unity driver] VLAN enhancement https://review.openstack.org/410037 | 02:17 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Refactor Access Rules APIs https://review.openstack.org/369668 | 02:20 |
| *** harlowja has quit IRC | 02:36 | |
| *** dsariel has quit IRC | 02:51 | |
| *** gcb has joined #openstack-manila | 02:54 | |
| *** carthaca_ has quit IRC | 02:58 | |
| *** carthaca_ has joined #openstack-manila | 02:59 | |
| openstackgerrit | TommyLike proposed openstack/manila: Add manila-manage db purge command https://review.openstack.org/308212 | 03:10 |
| *** tommylikehu has joined #openstack-manila | 03:11 | |
| tommylikehu | vponomaryov: https://review.openstack.org/#/c/308212/, done, also add some improvements. | 03:17 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Refactor Access Rules APIs https://review.openstack.org/369668 | 03:27 |
| *** gouthamr has quit IRC | 03:28 | |
| *** tommylikehu1 has joined #openstack-manila | 03:33 | |
| *** tommylikehu has quit IRC | 03:36 | |
| *** tommylikehu1 is now known as tommylikehu | 03:36 | |
| *** gcb has quit IRC | 03:38 | |
| *** gcb has joined #openstack-manila | 03:39 | |
| openstackgerrit | wlhc proposed openstack/manila: Fix ``exportfs -u`` usage in generic driver. https://review.openstack.org/411631 | 03:42 |
| openstackgerrit | Ha Van Tu proposed openstack/manila: [api-ref] Refactor share network documentation https://review.openstack.org/421651 | 04:08 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/manila: Replace yaml.load() with yaml.safe_load() https://review.openstack.org/420582 | 04:39 |
| *** shausy has joined #openstack-manila | 05:34 | |
| *** lpetrut has joined #openstack-manila | 06:12 | |
| *** lpetrut has quit IRC | 06:13 | |
| *** lpetrut has joined #openstack-manila | 06:14 | |
| *** nkrinner_afk is now known as nkrinner | 06:20 | |
| openstackgerrit | zhongjun proposed openstack/manila: Enable IPv6 in manila(allow access) https://review.openstack.org/312321 | 06:45 |
| *** houming has quit IRC | 06:58 | |
| *** lpetrut has quit IRC | 07:06 | |
| openstackgerrit | zhongjun proposed openstack/manila: Enable IPv6 in manila(network plugins and drivers) https://review.openstack.org/406776 | 07:06 |
| *** lgreg has joined #openstack-manila | 07:09 | |
| *** lgreg has quit IRC | 07:15 | |
| *** jprovazn has joined #openstack-manila | 07:20 | |
| *** dsariel has joined #openstack-manila | 07:22 | |
| *** a-pugachev has joined #openstack-manila | 07:28 | |
| *** dgonzalez_ has joined #openstack-manila | 07:50 | |
| *** mkoderer_ has joined #openstack-manila | 07:50 | |
| *** dgonzalez_ has quit IRC | 07:52 | |
| *** mkoderer_ has quit IRC | 07:52 | |
| *** lpetrut has joined #openstack-manila | 08:00 | |
| *** a-pugachev has quit IRC | 08:01 | |
| *** lpetrut has quit IRC | 08:07 | |
| *** lpetrut has joined #openstack-manila | 09:01 | |
| *** ociuhandu has joined #openstack-manila | 09:10 | |
| *** lgreg has joined #openstack-manila | 09:12 | |
| *** a-pugachev has joined #openstack-manila | 09:12 | |
| *** lgreg has quit IRC | 09:16 | |
| *** sapcc-bot1 has quit IRC | 09:39 | |
| *** databus23_1 has quit IRC | 09:39 | |
| *** carthaca_ has quit IRC | 09:39 | |
| *** pcaruana has joined #openstack-manila | 09:41 | |
| *** sapcc-bot has joined #openstack-manila | 09:46 | |
| *** mkoderer_ has joined #openstack-manila | 09:46 | |
| *** tpatzig_ has joined #openstack-manila | 09:46 | |
| *** dgonzalez_ has joined #openstack-manila | 09:46 | |
| *** mkoderer_ has quit IRC | 09:48 | |
| *** dgonzalez_ has quit IRC | 09:48 | |
| *** tpatzig_ has quit IRC | 09:48 | |
| *** tuanluong_ has joined #openstack-manila | 10:06 | |
| *** tuanluong has quit IRC | 10:07 | |
| *** tuanluong_ has quit IRC | 10:14 | |
| *** alyson_ has joined #openstack-manila | 10:18 | |
| *** ganso has joined #openstack-manila | 10:19 | |
| *** pcaruana has quit IRC | 10:38 | |
| ganso | vponomaryov: ping | 10:53 |
| *** jprovazn has quit IRC | 10:55 | |
| *** yumiriam has joined #openstack-manila | 11:04 | |
| *** gcb has quit IRC | 11:05 | |
| *** lgreg has joined #openstack-manila | 11:14 | |
| *** lgreg has quit IRC | 11:19 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share Migration Ocata Improvements https://review.openstack.org/406305 | 11:36 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Implement Share Migration Ocata improvements https://review.openstack.org/406306 | 11:42 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila-ui: Implement Share Migration Ocata improvements https://review.openstack.org/406307 | 11:42 |
| *** pcaruana has joined #openstack-manila | 11:56 | |
| *** yumiriam has quit IRC | 12:04 | |
| *** yumiriam has joined #openstack-manila | 12:05 | |
| *** cdelatte has joined #openstack-manila | 12:15 | |
| *** sapcc-bot has quit IRC | 12:23 | |
| *** dgonzalez_ has joined #openstack-manila | 12:23 | |
| *** tpatzig_ has joined #openstack-manila | 12:23 | |
| *** sapcc-bot1 has joined #openstack-manila | 12:23 | |
| *** dgonzalez_ has quit IRC | 12:25 | |
| *** tpatzig_ has quit IRC | 12:25 | |
| *** nkrinner has quit IRC | 12:40 | |
| *** nkrinner has joined #openstack-manila | 12:43 | |
| *** jprovazn has joined #openstack-manila | 12:52 | |
| openstackgerrit | Vitaliy Levitski proposed openstack/manila-ui: Add MapRFS protocol https://review.openstack.org/421884 | 12:53 |
| openstackgerrit | Vitaliy Levitski proposed openstack/manila-ui: Add MapRFS protocol https://review.openstack.org/421884 | 12:56 |
| *** tongli has joined #openstack-manila | 13:01 | |
| *** sapcc-bot1 has quit IRC | 13:02 | |
| *** sapcc-bot has joined #openstack-manila | 13:02 | |
| *** tpatzig_ has joined #openstack-manila | 13:02 | |
| *** mkoderer_ has joined #openstack-manila | 13:02 | |
| *** dgonzalez_ has joined #openstack-manila | 13:02 | |
| *** surabujin has quit IRC | 13:02 | |
| *** tpatzig_ has quit IRC | 13:04 | |
| *** mkoderer_ has quit IRC | 13:04 | |
| *** dgonzalez_ has quit IRC | 13:04 | |
| *** rraja has joined #openstack-manila | 13:09 | |
| *** surabujin has joined #openstack-manila | 13:15 | |
| *** lgreg has joined #openstack-manila | 13:16 | |
| *** lgreg has quit IRC | 13:20 | |
| *** tommylikehu_ has joined #openstack-manila | 13:21 | |
| *** tommylikehu_ has quit IRC | 13:22 | |
| *** tommylikehu_ has joined #openstack-manila | 13:22 | |
| tommylikehu_ | time | 13:23 |
| *** tommylik_ has joined #openstack-manila | 13:33 | |
| *** tommylikehu_ has quit IRC | 13:34 | |
| tommylik_ | hey bswartz, could you spend sometime on this db purge patch again? https://review.openstack.org/#/c/308212/ | 13:35 |
| *** tommylik_ has quit IRC | 13:35 | |
| *** tommylikehu_ has joined #openstack-manila | 13:35 | |
| *** catintheroof has joined #openstack-manila | 13:45 | |
| *** xyang1 has joined #openstack-manila | 13:53 | |
| openstackgerrit | Helen Walsh proposed openstack/manila: VMAX manila plugin - Support for VMAX in Manila https://review.openstack.org/404859 | 14:03 |
| vponomaryov | ganso: pong | 14:04 |
| *** gouthamr has joined #openstack-manila | 14:13 | |
| ganso | vponomaryov: Hi Valeriy. I have questions about some review comments | 14:13 |
| ganso | vponomaryov: regarding https://review.openstack.org/#/c/419163/7/manila_tempest_tests/tests/api/admin/test_share_instances.py | 14:14 |
| vponomaryov | ganso: Hello Rodrigo | 14:14 |
| ganso | vponomaryov: are you suggesting that I change the test class to always invoke a single method that append keys according to the microversion? | 14:14 |
| *** lgreg has joined #openstack-manila | 14:15 | |
| vponomaryov | ganso: ? | 14:15 |
| ganso | vponomaryov: why exactly is the change redundant while it is doing the same thing as the other microversioned changes in that test class? | 14:16 |
| vponomaryov | ganso: I suggest removing those 2 additional tests | 14:16 |
| vponomaryov | as they are: 1) cover separate microversions | 14:16 |
| vponomaryov | 2) do the same things that are done in your latest test | 14:17 |
| ganso | vponomaryov: how would you test 2.11 and 2.22 individually then? I know it is not related to my commit, but if purpose of test class is to test microversions individually, then why not? | 14:18 |
| gouthamr | vponomaryov: those keys weren't tested before | 14:18 |
| vponomaryov | ganso: separate commit | 14:18 |
| vponomaryov | gouthamr: those keys are unrelated to changed feature | 14:18 |
| gouthamr | vponomaryov: +1, we can do a TrivialFix for this... since we know it's missing minor test coverage.. | 14:19 |
| bswartz | gouthamr: when I run w/ tbarron's patch I crashes saying tooz isn't installed | 14:21 |
| bswartz | gouthamr: but I see tooz listed in g-r.txt | 14:21 |
| gouthamr | bswartz: new devstack | 14:21 |
| bswartz | why isn't g-r.txt getting installed? | 14:21 |
| bswartz | I thought devstack installed g-r.txt always | 14:21 |
| gouthamr | bswartz: missed the question mark, but you answered my question.. | 14:22 |
| gouthamr | bswartz: it should, can you verify in logs? i may not have devstack-ed with the patch.. | 14:23 |
| *** dustins has joined #openstack-manila | 14:23 | |
| bswartz | I ran devstack first and patched after | 14:23 |
| bswartz | I can go back and do it the other way | 14:23 |
| ganso | vponomaryov: the other question is about https://review.openstack.org/#/c/345526/41/manila/tests/test_exception.py | 14:26 |
| ganso | vponomaryov: ShareAccessExists is 500 too, and ManilaException which I and many others inherit is 500 too | 14:27 |
| ganso | vponomaryov: that test is not testing API response | 14:27 |
| vponomaryov | ganso: then what is the reason to test code? | 14:27 |
| ganso | vponomaryov: API response is 400 | 14:27 |
| ganso | vponomaryov: coverage, that's all | 14:27 |
| vponomaryov | ganso: it is redundant assertion | 14:28 |
| ganso | vponomaryov: why | 14:28 |
| vponomaryov | ganso: because you do not need to test code | 14:28 |
| vponomaryov | ganso: no logic that depends on it | 14:28 |
| ganso | vponomaryov: test is already there now, why remove? | 14:28 |
| vponomaryov | ganso: I am talking about concrete code line in test | 14:29 |
| *** kaisers has joined #openstack-manila | 14:29 | |
| vponomaryov | where comment is located | 14:29 |
| ganso | vponomaryov: other tests are redundant as well? | 14:29 |
| vponomaryov | ganso: I think comment is pretty clear | 14:30 |
| ganso | vponomaryov: is someone going to propose a TrivialFix patch to remove from the other tests because they are redundant? they are also checking the code | 14:30 |
| vponomaryov | ganso: existing code everywhere contains bad examples as well as good ones | 14:31 |
| vponomaryov | ganso: I am saying there is no sense in it, you say - it is how it is done in other similar places | 14:31 |
| ganso | vponomaryov: your comment says "Handled exceptions should not have "5xx" error codes. Never." This suggests changing the code from 5xx to another one. But the code is right | 14:32 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add cast_rules_to_readonly to share instances https://review.openstack.org/419163 | 14:33 |
| bswartz | ganso: you know the differece between HTTP 5xx and HTTP 4xx errors right? | 14:33 |
| bswartz | 4xx errors are for cases when the client did something wrong and 5xx are for cases when the server did something wrong | 14:34 |
| ganso | bswartz: yes, but that exception is handled internally, it is not being sent back to the user, it is converted to 400 at the API layer, just how ShareAccessExists is | 14:34 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share Migration Ocata Improvements https://review.openstack.org/406305 | 14:39 |
| vponomaryov | ganso: no matter where it is handled, you make assertion on wrong thing | 14:41 |
| vponomaryov | ganso: so, I am ok if oyu just remove that assertion | 14:42 |
| vponomaryov | ganso: in good case, all exception codes should be redefined | 14:42 |
| vponomaryov | ganso: to appropriate error codes | 14:42 |
| *** gcb has joined #openstack-manila | 14:47 | |
| *** breitz has joined #openstack-manila | 14:50 | |
| *** porrua has joined #openstack-manila | 14:52 | |
| vponomaryov | tbarron, gouthamr, bswartz: this client change should be merged too -> https://review.openstack.org/#/c/368567 | 14:54 |
| vponomaryov | because server side change has been merged for long time | 14:55 |
| bswartz | k | 14:55 |
| tommylikehu_ | thanks vponomaryov :) | 14:55 |
| vponomaryov | also, need to reach out cknight about https://review.openstack.org/#/c/340556/ | 14:56 |
| tbarron | vponomaryov: yeah | 14:56 |
| *** shausy has quit IRC | 14:56 | |
| vponomaryov | so we could keep client up-to-date | 14:56 |
| vponomaryov | and not slow down other client changes | 14:56 |
| *** tongli has quit IRC | 15:00 | |
| *** mtanino has joined #openstack-manila | 15:01 | |
| *** cknight has joined #openstack-manila | 15:05 | |
| openstackgerrit | Merged openstack/manila: Add manila-manage db purge command https://review.openstack.org/308212 | 15:05 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Rename consistency group modules to share groups https://review.openstack.org/409864 | 15:06 |
| openstackgerrit | Merged openstack/manila: Fix ``exportfs -u`` usage in generic driver. https://review.openstack.org/411631 | 15:12 |
| *** openstack has joined #openstack-manila | 15:20 | |
| *** xinyanzhang has joined #openstack-manila | 15:22 | |
| *** timcl has quit IRC | 15:23 | |
| *** tinwood has joined #openstack-manila | 15:24 | |
| *** timcl has joined #openstack-manila | 15:25 | |
| *** DuncanT has joined #openstack-manila | 15:27 | |
| *** lgreg has quit IRC | 15:29 | |
| *** ganso has joined #openstack-manila | 15:32 | |
| openstackgerrit | Clinton Knight proposed openstack/manila: NetApp: Support share revert to snapshot https://review.openstack.org/357545 | 15:37 |
| *** tommylikehu_ has quit IRC | 15:39 | |
| *** kaisers has quit IRC | 15:46 | |
| *** david-lyle has joined #openstack-manila | 15:47 | |
| *** lgreg has joined #openstack-manila | 15:50 | |
| *** lgreg has quit IRC | 15:51 | |
| *** lgreg1 has joined #openstack-manila | 15:51 | |
| openstackgerrit | Merged openstack/python-manilaclient: Add the ability to check tenant quota detail https://review.openstack.org/368567 | 15:52 |
| openstackgerrit | Clinton Knight proposed openstack/manila: Trivial fixes to snapshot revert patch https://review.openstack.org/422045 | 15:52 |
| cknight | tbarron: ^^ | 15:52 |
| *** kaisers has joined #openstack-manila | 15:53 | |
| tbarron | cknight: k | 15:53 |
| *** rraja has quit IRC | 15:54 | |
| *** eharney has joined #openstack-manila | 15:54 | |
| *** dustins has quit IRC | 16:03 | |
| *** dustins_ has joined #openstack-manila | 16:03 | |
| *** nkrinner is now known as nkrinner_afk | 16:05 | |
| *** lgreg1 has quit IRC | 16:11 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 16:16 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature https://review.openstack.org/355264 | 16:16 |
| *** adrianofr_ has joined #openstack-manila | 16:23 | |
| *** lgreg has joined #openstack-manila | 16:24 | |
| *** sage has joined #openstack-manila | 16:32 | |
| *** JoseMello has joined #openstack-manila | 16:37 | |
| *** harlowja has joined #openstack-manila | 16:39 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add mountable snapshots support https://review.openstack.org/345526 | 16:43 |
| bswartz | gouthamr: tooz patching working great for me | 16:47 |
| bswartz | gouthamr: so far | 16:47 |
| openstackgerrit | Alyson proposed openstack/python-manilaclient: Add mountable snapshots support to manila client https://review.openstack.org/345625 | 17:00 |
| *** ianychoi has quit IRC | 17:04 | |
| gouthamr | bswartz: that's great to hear :) | 17:12 |
| gouthamr | s/hear/read: i also read it aloud | 17:12 |
| openstackgerrit | Clinton Knight proposed openstack/python-manilaclient: Support share revert to snapshot in Manila client https://review.openstack.org/340556 | 17:14 |
| *** porrua has quit IRC | 17:22 | |
| *** lpetrut has quit IRC | 17:31 | |
| *** harlowja has quit IRC | 17:33 | |
| *** a-pugachev has quit IRC | 17:34 | |
| *** a-pugachev has joined #openstack-manila | 17:34 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Refactor Access Rules APIs https://review.openstack.org/369668 | 17:35 |
| *** david-lyle is now known as bailing-wire | 17:37 | |
| *** a-pugachev has quit IRC | 17:41 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 17:43 |
| *** catintheroof has quit IRC | 17:44 | |
| *** porrua has joined #openstack-manila | 17:44 | |
| *** catintheroof has joined #openstack-manila | 17:44 | |
| *** catintheroof has quit IRC | 17:44 | |
| *** catintheroof has joined #openstack-manila | 17:45 | |
| *** bailing-wire has quit IRC | 17:46 | |
| openstackgerrit | Helen Walsh proposed openstack/manila: VMAX manila plugin - Support for VMAX in Manila https://review.openstack.org/404859 | 17:47 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 17:47 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature https://review.openstack.org/355264 | 17:48 |
| *** catintheroof has quit IRC | 17:50 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add mountable snapshots support https://review.openstack.org/345526 | 17:53 |
| openstackgerrit | Merged openstack/manila: Trivial fixes to snapshot revert patch https://review.openstack.org/422045 | 17:57 |
| *** lgreg has quit IRC | 17:59 | |
| vponomaryov | bswartz, tbarron, gouthamr, ganso: merge this -> https://review.openstack.org/#/c/340556 ? | 18:08 |
| gouthamr | vponomaryov: actively reviewing | 18:09 |
| vponomaryov | gouthamr: this or something else meaning "busy"? | 18:09 |
| gouthamr | vponomaryov: same patch :) | 18:09 |
| vponomaryov | ok ) | 18:09 |
| *** dustins_ is now known as dustins | 18:14 | |
| *** dustins has quit IRC | 18:15 | |
| *** gcb has quit IRC | 18:18 | |
| *** dustins has joined #openstack-manila | 18:28 | |
| openstackgerrit | Helen Walsh proposed openstack/manila: VMAX manila plugin - Support for VMAX in Manila https://review.openstack.org/404859 | 18:33 |
| *** absubram has joined #openstack-manila | 18:35 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 18:36 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature https://review.openstack.org/355264 | 18:40 |
| *** dustins_ has joined #openstack-manila | 18:50 | |
| *** sticker_ has joined #openstack-manila | 18:51 | |
| *** sticker has quit IRC | 18:54 | |
| *** dustins has quit IRC | 18:55 | |
| *** dustins_ is now known as dustins | 18:55 | |
| *** jprovazn has quit IRC | 18:55 | |
| *** ianychoi has joined #openstack-manila | 19:04 | |
| *** jprovazn has joined #openstack-manila | 19:09 | |
| *** ociuhandu has quit IRC | 19:10 | |
| *** absubram has quit IRC | 19:17 | |
| *** ociuhandu has joined #openstack-manila | 19:21 | |
| *** absubram has joined #openstack-manila | 19:22 | |
| *** jcsp has joined #openstack-manila | 19:26 | |
| openstackgerrit | Clinton Knight proposed openstack/python-manilaclient: Support share revert to snapshot in Manila client https://review.openstack.org/340556 | 19:31 |
| *** porrua has quit IRC | 19:31 | |
| markstur | cknight: Is that indent change fix something that should be split out for backport? Or is the "else" case not a legit concern? | 19:40 |
| cknight | markstur: Given that it's just a test, and it's never failed (it definitely would fail if not a string), it seems fairly unimportant | 19:41 |
| *** jcsp has quit IRC | 19:41 | |
| cknight | markstur: But you're welcome to! :-) | 19:41 |
| markstur | Ahhh. I was missing the "just a test" part. Thought Rodrigo may have found a real bug and I looked at the logic, but wasn't paying much attention to the context | 19:43 |
| markstur | whew | 19:44 |
| ganso | markstur: hey I found a real bug | 19:44 |
| ganso | markstur: :P | 19:44 |
| ganso | markstur: don't say my bug is not real :( | 19:45 |
| markstur | ganso: File it! | 19:45 |
| ganso | markstur: no need to, cknight is fixing it in his patch | 19:45 |
| markstur | it is not a real bug until it is confirmed in launchpad | 19:45 |
| markstur | real bug swept under the rug? | 19:46 |
| ganso | markstur: and still, no need to file as it is a trivialFix | 19:46 |
| markstur | trivialBugFix | 19:46 |
| markstur | if a bug is squashed in the forest and nobody is around to hear the squish. Does it deserve and LP? | 19:47 |
| gouthamr | markstur: don't think it's a bug.. we always passed something that needed a string cast.. | 19:48 |
| ganso | gouthamr: we never invoked the bug | 19:49 |
| ganso | gouthamr: but it was there | 19:49 |
| markstur | yeah. I agree. Test fix stuff is not a concern. Just good to fix it before someone stumbles into it later. | 19:49 |
| gouthamr | ganso: yuh, i think we should always cast to string type for a given spec, and not have that if condition there.. | 19:49 |
| cknight | gouthamr: +1 I considered that… | 19:50 |
| ganso | gouthamr: I was wondering that myself, if parameters to tests are always hardcoded, then we would not need to consider such scenario | 19:50 |
| gouthamr | cknight ganso: future proofing code :P | 19:51 |
| markstur | would be a good fix for someone needing a pass to the summit. Oh nevermind. | 19:53 |
| ganso | markstur: back in the day | 19:54 |
| gouthamr | goodtimes | 19:58 |
| *** bailing-wire has joined #openstack-manila | 20:00 | |
| *** yumiriam has quit IRC | 20:01 | |
| markstur | ganso: gouthamr You guys sound like such old-timers. What's next? "Get off my lawn"? | 20:02 |
| *** bailing-wire is now known as david-lyle | 20:02 | |
| gouthamr | markstur: property* | 20:03 |
| gouthamr | down here in the south :) | 20:03 |
| markstur | Right. I'm such a suburbanite | 20:04 |
| openstackgerrit | Helen Walsh proposed openstack/manila: VMAX manila plugin - Support for VMAX in Manila https://review.openstack.org/404859 | 20:32 |
| *** absubram has quit IRC | 20:43 | |
| *** alyson_ has quit IRC | 20:57 | |
| *** absubram has joined #openstack-manila | 21:00 | |
| *** jprovazn has quit IRC | 21:20 | |
| *** absubram has quit IRC | 21:21 | |
| *** JoseMello has quit IRC | 21:25 | |
| bswartz | ganso: ping | 21:28 |
| bswartz | ganso: is there a style guide somewhere that says API params should have underscores instead of hyphens? | 21:28 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add access-rules tests to improve the coverage https://review.openstack.org/390380 | 21:32 |
| *** absubram has joined #openstack-manila | 21:33 | |
| *** gouthamr has quit IRC | 21:34 | |
| *** lgreg has joined #openstack-manila | 21:43 | |
| *** sticker_ is now known as sticker | 21:44 | |
| *** lgreg has quit IRC | 21:44 | |
| *** lgreg1 has joined #openstack-manila | 21:44 | |
| openstackgerrit | Merged openstack/python-manilaclient: Support share revert to snapshot in Manila client https://review.openstack.org/340556 | 21:48 |
| *** gouthamr has joined #openstack-manila | 21:57 | |
| *** ganso has quit IRC | 22:14 | |
| gouthamr | tbarron: any more comments that you'd like me to wait for on https://review.openstack.org/#/c/369668/ ? | 22:30 |
| *** david-lyle has quit IRC | 22:32 | |
| *** david-lyle has joined #openstack-manila | 22:40 | |
| tbarron | gouthamr: I'll push a few in a sec. I'm slow at reviewing big patches. | 22:40 |
| tbarron | gouthamr: after that, don't wait, I can refresh, check diffs, and keep going to the stuff I haven't dug into yet. | 22:41 |
| gouthamr | tbarron: :) sure thing. thanks for reviewing | 22:47 |
| tbarron | it's fun stuff but sometimes makes my head hurt. The problem, that is, not the coding style :D | 22:47 |
| *** eharney has quit IRC | 22:54 | |
| *** tommylikehu_ has joined #openstack-manila | 22:59 | |
| *** tommylikehu_ has quit IRC | 23:02 | |
| *** dustins has quit IRC | 23:05 | |
| *** absubram has quit IRC | 23:09 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Refactor Access Rules APIs https://review.openstack.org/369668 | 23:17 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/python-manilaclient: [DNM] Testing this against the access rule API refactor https://review.openstack.org/422307 | 23:19 |
| gouthamr | tbarron: i read the first part and assumed the opposite of the second part | 23:20 |
| tbarron | gouthamr: ? (part of ?) | 23:21 |
| gouthamr | the coding style... i try hard | 23:21 |
| tbarron | gouthamr: ah, yeah the coding style is fine. And you've taught cknight well too. | 23:22 |
| tbarron | gouthamr: it's all the stuff that happens under the covers in the DB model that gives me headaches. | 23:22 |
| gouthamr | tbarron: haha, the second sentence is the exact opposite this time (@your earlier comment) | 23:22 |
| tbarron | but igor isn't here to whine at | 23:22 |
| gouthamr | i know | 23:23 |
| gouthamr | Igor :D | 23:23 |
| *** ianychoi has quit IRC | 23:24 | |
| *** furlongm_ has quit IRC | 23:24 | |
| *** sapcc-bot has quit IRC | 23:24 | |
| tbarron | I don't understand though your remark that "access_create returns only with the share data, does not set the instance access mapping data" | 23:24 |
| *** ianychoi has joined #openstack-manila | 23:24 | |
| *** furlongm_ has joined #openstack-manila | 23:24 | |
| *** sapcc-bot has joined #openstack-manila | 23:24 | |
| tbarron | it does iterate over instances and set instance to rule maps, no? | 23:25 |
| * gouthamr wonders if markstur set up a trigger against the author name on the IBM CI | 23:25 | |
| markstur | ??? | 23:25 |
| gouthamr | markstur: trolling, like your CI :) | 23:26 |
| *** kaisers has quit IRC | 23:27 | |
| markstur | oh yeah... if "outham" in author: gpfs_fast_fail() | 23:27 |
| gouthamr | tbarron: actually on second thought that refresh does look unnecessary, lemme look and see why it was added.. | 23:28 |
| markstur | matches all your aliases except GPR which I've been promoting but no one else seems to use | 23:29 |
| *** xyang1 has quit IRC | 23:29 | |
| tbarron | gouthamr: cool. Part of the reason I'm focusing a bit on these perhaps unnecessary DB refreshes is t | 23:29 |
| gouthamr | markstur: haha... smart. hey i was GPR all my life until "Gotham" started sounding better in this part of the world. | 23:30 |
| tbarron | that (1) they give false security that we're avoiding races, and (2) | 23:30 |
| tbarron | DB accesses are actually a source of potential big delay, that can exacerbate race windows on distributed systems | 23:30 |
| gouthamr | tbarron: +1 - that comment was from Iff1ec2e3176a46e9f6bd383b38ffc5d838aa8bb8 | 23:32 |
| tbarron | gouthamr: smart on using 'Gotham' | 23:32 |
| gouthamr | 'as in Batman', yeah. works great at Starbucks | 23:33 |
| tbarron | yeah, I was thinking batman too | 23:33 |
| markstur | gouthamr: I was M6S back in the IBM mainframe days, but I guess I'll stick w/ markstur or marks now that we have more than 3 chars | 23:33 |
| gouthamr | markstur: haha.. M6S sounds badass | 23:34 |
| markstur | Yeah. I watch Gotham and it sounds cool, but GPR has style. Maybe I flashback to GNR (guns-n-roses) concerts | 23:34 |
| gouthamr | you're making that cooler now ^ | 23:35 |
| tbarron | GPR would look good on big cuff-links | 23:35 |
| markstur | +1 | 23:35 |
| markstur | Or a big gold GPR hanging on a way-too-much-gold chain | 23:36 |
| * gouthamr which as a matter of fact i own, thanks to a certain somebody who thought it'd be a great birthday gift | 23:36 | |
| gouthamr | wow, this is a roast | 23:36 |
| gouthamr | walked right into it | 23:36 |
| * markstur thinks he claims the cuff-links and not the Mr. T chain | 23:36 | |
| gouthamr | :P | 23:41 |
| gouthamr | tbarron: yep, we can get read of that... it was added here: https://review.openstack.org/#/c/245126/15..34/manila/share/api.py | 23:41 |
| gouthamr | tbarron: s/read/rid | 23:42 |
| tbarron | gouthamr: cool, the snail review continues ... | 23:42 |
| cknight | How I see Goutham now: https://goo.gl/SwE8rn | 23:42 |
| gouthamr | tbarron: it was because the 'state' was no longer a column and needed all the instances to report a state | 23:42 |
| gouthamr | cknight: roflmao.. you were saving that one | 23:42 |
| cknight | :-) Yep | 23:43 |
| tbarron | cknight: :D | 23:43 |
| bswartz | wow that's a lot of gold | 23:43 |
| markstur | LOL | 23:44 |
| *** cdelatte has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!