| *** tinwood has quit IRC | 00:00 | |
| *** makowals has quit IRC | 00:01 | |
| openstackgerrit | Merged openstack/manila: Tooz integration https://review.openstack.org/318336 | 00:04 |
|---|---|---|
| tbarron | w00t ^^ | 00:09 |
| *** mtanino has quit IRC | 00:13 | |
| *** ganso has quit IRC | 01:14 | |
| *** zengyingzhe__ has quit IRC | 01:18 | |
| *** zengyingzhe has joined #openstack-manila | 01:18 | |
| *** xyang_ has joined #openstack-manila | 01:22 | |
| *** xyang_ has quit IRC | 01:23 | |
| *** makowals has joined #openstack-manila | 01:25 | |
| tommylikehu | ping gouthamr | 01:29 |
| gouthamr | tommylikehu: pong | 01:29 |
| tommylikehu | gouthamr you are reviewing the patches of IPv6 now? | 01:30 |
| gouthamr | tommylikehu: yep | 01:30 |
| tommylikehu | gou | 01:30 |
| tommylikehu | I think the documentation patch is not ready for merge conflict | 01:31 |
| tommylikehu | you can review the framework patches first | 01:31 |
| tommylikehu | https://review.openstack.org/#/c/406776/ | 01:31 |
| tommylikehu | https://review.openstack.org/#/c/312321/ | 01:31 |
| tommylikehu | gouthamr: thanks | 01:32 |
| gouthamr | sure | 01:35 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila-ui: Updated from global requirements https://review.openstack.org/422960 | 01:47 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/manila: Replace yaml.load() with yaml.safe_load() https://review.openstack.org/420582 | 02:23 |
| tommylikehu | ping gouthamr | 02:29 |
| tommylikehu | still around? | 02:29 |
| gouthamr | tommylikehu: pong | 02:29 |
| tommylikehu | thanks | 02:29 |
| tommylikehu | https://review.openstack.org/#/c/416870/1/doc/source/devref/share_back_ends_feature_support_mapping.rst | 02:29 |
| tommylikehu | I think the 'IPv4 access ' column in table 'Mapping of share drivers and share features support' should be changed to the version when they exist | 02:30 |
| tommylikehu | not the table 'Mapping of share drivers and common capabilities' | 02:30 |
| tommylikehu | how do you think of this? | 02:30 |
| gouthamr | tommylikehu: i think you shouldn't extend that table.. you should maybe add that to the table below | 02:31 |
| gouthamr | tommylikehu: Mapping of share drivers and share access rules support | 02:31 |
| tommylikehu | make sense | 02:32 |
| tommylikehu | how about the second table 'Mapping of share drivers and common capabilities' | 02:32 |
| gouthamr | tommylikehu: the column names in that table should be the capability: 'ipv4_support', 'ipv6_support' | 02:33 |
| tommylikehu | and the version? | 02:34 |
| gouthamr | tommylikehu: you can use the short forms 'ipv4', 'ipv6' and specify in the note below what the common capability is | 02:34 |
| tommylikehu | thanks | 02:34 |
| gouthamr | tommylikehu: since allowing IP access for NFS has always meant ipv4, you can take the first release where access control was added to each driver as the release to specify under that parameter | 02:35 |
| gouthamr | tommylikehu: i take that back. these capabilities didn't exist and we're not persisting them in the database | 02:36 |
| gouthamr | tommylikehu: 'O' is appropriate | 02:36 |
| openstackgerrit | TommyLike proposed openstack/manila: Enable IPv6 in manila(documentation) https://review.openstack.org/416870 | 03:13 |
| openstackgerrit | TommyLike proposed openstack/manila: Enable IPv6 in manila(allow access) https://review.openstack.org/312321 | 03:53 |
| openstackgerrit | yankee proposed openstack/manila: Allow use of <is> with DHSS and snapshot support https://review.openstack.org/413338 | 04:41 |
| *** gouthamr has quit IRC | 04:46 | |
| *** catinthe_ has quit IRC | 04:54 | |
| *** catintheroof has joined #openstack-manila | 05:02 | |
| *** catintheroof has quit IRC | 05:14 | |
| *** shausy has joined #openstack-manila | 05:26 | |
| *** surabujin has quit IRC | 05:38 | |
| *** catintheroof has joined #openstack-manila | 05:46 | |
| *** surabujin has joined #openstack-manila | 05:50 | |
| *** shausy has quit IRC | 05:51 | |
| *** shausy has joined #openstack-manila | 05:52 | |
| *** sandanar has joined #openstack-manila | 05:55 | |
| *** lpetrut has joined #openstack-manila | 06:03 | |
| openstackgerrit | TommyLike proposed openstack/manila: Enable IPv6 in manila(documentation) https://review.openstack.org/416870 | 06:05 |
| *** sticker has quit IRC | 06:12 | |
| *** absubram has joined #openstack-manila | 06:19 | |
| openstackgerrit | TommyLike proposed openstack/python-manilaclient: Enable IPv6 in manila(client) https://review.openstack.org/328932 | 06:24 |
| *** jprovazn has joined #openstack-manila | 06:38 | |
| *** zhonghua2 has joined #openstack-manila | 06:51 | |
| *** furlongm_ has quit IRC | 06:51 | |
| *** nkrinner_afk is now known as nkrinner | 06:53 | |
| *** zhonghua has quit IRC | 06:54 | |
| *** lpetrut has quit IRC | 06:59 | |
| *** lpetrut has joined #openstack-manila | 07:07 | |
| *** absubram has quit IRC | 07:08 | |
| *** zengyingzhe has quit IRC | 07:16 | |
| *** zengyingzhe has joined #openstack-manila | 07:17 | |
| *** lpetrut has quit IRC | 07:24 | |
| *** shausy has quit IRC | 07:41 | |
| *** shausy has joined #openstack-manila | 07:41 | |
| *** pcaruana has joined #openstack-manila | 07:43 | |
| *** dgonzalez has quit IRC | 07:51 | |
| *** dgonzalez has joined #openstack-manila | 07:51 | |
| openstackgerrit | Helen Walsh proposed openstack/manila: VMAX manila plugin - Support for VMAX in Manila https://review.openstack.org/404859 | 08:15 |
| openstackgerrit | Pony Chou proposed openstack/manila: Add QNAP Manila Driver https://review.openstack.org/394703 | 08:41 |
| *** wlhc has joined #openstack-manila | 08:47 | |
| *** openstackgerrit has quit IRC | 09:02 | |
| *** johnthetubaguy has quit IRC | 09:16 | |
| *** johnthetubaguy has joined #openstack-manila | 09:19 | |
| *** wlhc has quit IRC | 09:21 | |
| *** dgonzalez_ has joined #openstack-manila | 09:23 | |
| *** lpetrut has joined #openstack-manila | 09:24 | |
| *** dgonzalez has quit IRC | 09:27 | |
| *** dgonzalez_ is now known as dgonzalez | 09:27 | |
| *** openstackgerrit has joined #openstack-manila | 09:32 | |
| *** tommylikehu has quit IRC | 09:32 | |
| openstackgerrit | TommyLike proposed openstack/manila: Enable IPv6 in manila(network plugins and drivers) https://review.openstack.org/406776 | 09:32 |
| *** tommylikehu has joined #openstack-manila | 09:33 | |
| *** lpetrut has quit IRC | 09:42 | |
| *** a-pugachev has joined #openstack-manila | 09:51 | |
| openstackgerrit | Ha Dung proposed openstack/manila: Fixes all current typo errors on Manila project. https://review.openstack.org/423164 | 10:06 |
| *** alyson_ has joined #openstack-manila | 10:10 | |
| *** ganso has joined #openstack-manila | 10:12 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share Migration Ocata Improvements https://review.openstack.org/406305 | 10:13 |
| *** gcb has joined #openstack-manila | 10:14 | |
| openstackgerrit | Pony Chou proposed openstack/manila: Add QNAP Manila Driver https://review.openstack.org/394703 | 10:17 |
| *** lpetrut has joined #openstack-manila | 10:21 | |
| openstackgerrit | Merged openstack/manila-ui: Updated from global requirements https://review.openstack.org/422960 | 10:23 |
| *** gcb has quit IRC | 10:34 | |
| *** yumiriam has joined #openstack-manila | 10:44 | |
| *** sandanar_ has joined #openstack-manila | 10:47 | |
| *** sandanar has quit IRC | 10:50 | |
| *** rraja has joined #openstack-manila | 10:50 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/python-manilaclient: Add share group support to Manila client https://review.openstack.org/335120 | 10:55 |
| openstackgerrit | Merged openstack/manila: Refactor Access Rules APIs https://review.openstack.org/369668 | 11:11 |
| openstackgerrit | Helen Walsh proposed openstack/manila: VMAX manila plugin - Support for VMAX in Manila https://review.openstack.org/404859 | 11:19 |
| openstackgerrit | Helen Walsh proposed openstack/manila: VMAX manila plugin - Support for VMAX in Manila https://review.openstack.org/404859 | 11:43 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Rename consistency group modules to share groups https://review.openstack.org/409864 | 11:44 |
| *** shausy has quit IRC | 11:44 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 11:44 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/python-manilaclient: Add share group support to Manila client https://review.openstack.org/335120 | 11:45 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share Migration Ocata Improvements https://review.openstack.org/406305 | 11:45 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 11:46 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature https://review.openstack.org/355264 | 11:50 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Implement Share Migration Ocata improvements https://review.openstack.org/406306 | 11:53 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 11:58 |
| *** pcaruana has quit IRC | 11:59 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Implement Share Migration Ocata improvements https://review.openstack.org/406306 | 12:00 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature https://review.openstack.org/355264 | 12:01 |
| *** ociuhandu has quit IRC | 12:05 | |
| *** pcaruana has joined #openstack-manila | 12:06 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila-ui: Implement Share Migration Ocata improvements https://review.openstack.org/406307 | 12:06 |
| *** cdelatte has joined #openstack-manila | 12:08 | |
| *** catinthe_ has joined #openstack-manila | 12:32 | |
| *** catintheroof has quit IRC | 12:33 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 12:48 |
| *** ociuhandu has joined #openstack-manila | 12:50 | |
| *** JoseMello has joined #openstack-manila | 12:52 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature https://review.openstack.org/355264 | 12:54 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Implement Share Migration Ocata improvements https://review.openstack.org/406306 | 12:59 |
| *** dsariel has quit IRC | 13:04 | |
| *** tinwood has joined #openstack-manila | 13:13 | |
| *** sandanar__ has joined #openstack-manila | 13:16 | |
| *** dsariel has joined #openstack-manila | 13:18 | |
| *** gcb has joined #openstack-manila | 13:19 | |
| *** sandanar_ has quit IRC | 13:20 | |
| *** timcl has joined #openstack-manila | 13:46 | |
| *** dgonzalez has quit IRC | 14:06 | |
| *** tommylikehu_ has joined #openstack-manila | 14:09 | |
| *** tommylikehu_ has quit IRC | 14:10 | |
| *** tommylikehu_ has joined #openstack-manila | 14:10 | |
| *** tommylikehu_ has quit IRC | 14:11 | |
| *** dgonzalez has joined #openstack-manila | 14:11 | |
| *** tommylikehu_ has joined #openstack-manila | 14:11 | |
| *** gouthamr has joined #openstack-manila | 14:22 | |
| gouthamr | vponomaryov tbarron ganso: can we merge the access rules tests? https://review.openstack.org/#/c/390380 | 14:31 |
| ganso | gouthamr: waiting for third party CIs to report | 14:32 |
| tbarron | gouthamr: will review soon | 14:33 |
| *** catintheroof has joined #openstack-manila | 14:33 | |
| gouthamr | ganso tbarron: thank you. i rechecked Netapp, we can't handle gerrit dependencies, but this run should pass because the dependency merged | 14:33 |
| ganso | gouthamr: I am also going to review it | 14:34 |
| ganso | gouthamr: btw, possibly a race condition https://review.openstack.org/#/c/406306/14 | 14:34 |
| gouthamr | ganso: where? | 14:35 |
| *** nkrinner is now known as nkrinner_afk | 14:35 | |
| ganso | gouthamr: migration test failed, in m_shr says it says the wait for update access rules status timed out | 14:35 |
| ganso | gouthamr: the server passed jenkins | 14:36 |
| *** catinthe_ has quit IRC | 14:36 | |
| *** zengyingzhe has quit IRC | 14:37 | |
| *** zengyingzhe has joined #openstack-manila | 14:37 | |
| *** dustins has joined #openstack-manila | 14:39 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add cast_rules_to_readonly to share instances https://review.openstack.org/419163 | 14:42 |
| *** absubram has joined #openstack-manila | 14:42 | |
| gouthamr | ganso: strange, the request never got to the share manager | 14:43 |
| vponomaryov | gouthamr: client change? | 14:43 |
| *** eharney has joined #openstack-manila | 14:43 | |
| gouthamr | vponomaryov: there isn't one, i just tested it working against the change.. https://review.openstack.org/#/c/422307/ | 14:44 |
| gouthamr | vponomaryov: what needs to change on the client side? | 14:45 |
| gouthamr | vponomaryov: i'd hope the next patch merging will bump up the micro-version.. | 14:45 |
| *** dustins has quit IRC | 14:45 | |
| *** dustins has joined #openstack-manila | 14:45 | |
| vponomaryov | "poke-people-driver-development" ^_^ | 14:46 |
| vponomaryov | gouthamr: you changed API | 14:47 |
| vponomaryov | gouthamr: so, it should be completely supported | 14:47 |
| gouthamr | vponomaryov: yeah.. we fixed a bunch of stuff without breaking "expected" behavior, so i don't see what changes are necessary on the client. it'll work just fine - ofcourse, i'll bump up the microversion | 14:48 |
| bswartz | gouthamr: this matters because we want to do a client release today | 14:48 |
| gouthamr | bswartz: og | 14:49 |
| gouthamr | bswartz: oh* | 14:49 |
| gouthamr | bswartz: sure thing. will push that change | 14:49 |
| *** breitz has quit IRC | 14:50 | |
| ganso | bswartz: do you if cknight is going to be around today? | 14:51 |
| *** breitz has joined #openstack-manila | 14:51 | |
| bswartz | ganso: I haven't heard otherwise -- I'll let you know if he calls in sick or something | 14:52 |
| ganso | bswartz: thanks | 14:52 |
| ganso | bswartz: btw I updated the migration patch | 14:52 |
| ganso | bswartz: it is waiting for reviews | 14:53 |
| bswartz | ganso: he hasn't turned up in the office yet but it's normally late | 14:53 |
| bswartz | ganso: I saw | 14:53 |
| ganso | bswartz: I indeed had forgotten to remove the sorting | 14:53 |
| *** porrua has joined #openstack-manila | 14:59 | |
| tbarron | ganso: sorry for the double recheck on https://review.openstack.org/#/c/390380 - didn't see that you had just done it | 14:59 |
| *** dustins has quit IRC | 15:01 | |
| *** dustins has joined #openstack-manila | 15:01 | |
| *** gcb has quit IRC | 15:09 | |
| *** mtanino has joined #openstack-manila | 15:10 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/python-manilaclient: Support changes to access rules APIs https://review.openstack.org/422307 | 15:15 |
| ganso | tbarron: np | 15:15 |
| *** xyang_ has joined #openstack-manila | 15:23 | |
| *** rraja has quit IRC | 15:24 | |
| xyang_ | vponomaryov: ping | 15:24 |
| vponomaryov | xyang_: pong | 15:24 |
| xyang_ | vponomaryov: about the max driver https://review.openstack.org/#/c/404859/ | 15:24 |
| *** absubram has quit IRC | 15:25 | |
| xyang_ | vponomaryov: VMAX product management decided not to share code with VNX driver, because VNX driver will eventually go away | 15:25 |
| vponomaryov | xyang_: what is bad in sharing code? | 15:26 |
| xyang_ | vponomaryov: for easier maintainability, they want to keep it separate | 15:26 |
| vponomaryov | xyang_: especially when it is identical | 15:26 |
| vponomaryov | and we speak about thousands of lines | 15:26 |
| xyang_ | vponomaryov: so right now it is identical but it will diverge | 15:26 |
| vponomaryov | xyang_: 1) for the moment - it is identical, need to change imports; 2) further you can just inherit those and redefine needed parts | 15:29 |
| vponomaryov | BUT | 15:29 |
| vponomaryov | you just said it will go aaway | 15:29 |
| vponomaryov | then there will be no "diverge" | 15:29 |
| vponomaryov | there will be just moving of files from one dir to other | 15:29 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add mountable snapshots support https://review.openstack.org/345526 | 15:30 |
| xyang_ | vponomaryov: It is too late in Ocata now and there is not enough time to re-write the driver. Can you let the VMAX driver merge in Ocata and I will ask VMAX team to refactor it and share code with VNX in Pike? | 15:30 |
| vponomaryov | xyang_: to be honest, change of imports is very-very fast change | 15:31 |
| vponomaryov | xyang_: and in case you fix some bugs there, you will need to change only 1 place | 15:32 |
| vponomaryov | xyang_: but yes, I can say "ok, if you ask, I can close my eyes on such kind of things in THOSE drivers" | 15:33 |
| xyang_ | vponomaryov: right, you are fast and can get it done in no time but it takes much longer for others:) It's just getting so late and the current code has been reviewed and tested | 15:33 |
| vponomaryov | xyang_: ok, even not considering copy-paste | 15:34 |
| vponomaryov | xyang_: there are comments to be addressed | 15:34 |
| vponomaryov | xyang_: valueable such as behaviour deleting wrong access rules | 15:34 |
| xyang_ | vponomaryov: I am just asking you to let VMAX team fix the copy-paste issue in Pike | 15:34 |
| xyang_ | vponomaryov: I have not looked at your other recent comments yet | 15:35 |
| vponomaryov | xyang_: ok, I will not insist on removing copy-paste | 15:35 |
| xyang_ | vponomaryov: I got a urgent ping this morning about the copy paste issue:) | 15:35 |
| vponomaryov | xyang_: but still will be horrified because of it )) | 15:35 |
| vponomaryov | xyang_: waking up in the middles of the night screaming "copy-paste is everywhere" | 15:36 |
| xyang_ | vponomaryov: thanks for all your helpful comments. they should continue to address them. Just the copy paste thing will be delayed to pike | 15:36 |
| vponomaryov | cry and suffer | 15:36 |
| xyang_ | vponomaryov: so this driver gave you nightmare ?:) | 15:37 |
| vponomaryov | I haven't sleep yet after getting know it | 15:37 |
| xyang_ | vponomaryov: well you are a perfectionist:) | 15:37 |
| *** tommylikehu1 has joined #openstack-manila | 15:47 | |
| *** cknight has joined #openstack-manila | 15:47 | |
| *** tommylikehu has quit IRC | 15:49 | |
| *** tommylikehu1 is now known as tommylikehu | 15:49 | |
| ganso | gouthamr: could you please take a look at a question I posted in your patch python-manilaclient access rules patch? | 15:52 |
| ganso | cknight: ping | 15:53 |
| *** tommylikehu_ has quit IRC | 15:55 | |
| ganso | vponomaryov: https://review.openstack.org/#/c/419163/10/manila/db/migrations/alembic/versions/e9f79621d83f_add_cast_rules_to_readonly_to_share_instances.py | 15:57 |
| ganso | vponomaryov: look above | 15:57 |
| vponomaryov | ganso: ? | 15:57 |
| ganso | vponomaryov: LN 50 | 15:58 |
| vponomaryov | ganso: then I need to ask you to reread comment | 15:58 |
| ganso | vponomaryov: you meant to edit the column? | 15:58 |
| gouthamr | ganso: yes.. field/fields.. ignore and merge pl0x :) | 15:58 |
| vponomaryov | ganso: there is no update of columns attr that is called "nullable" | 15:58 |
| vponomaryov | so, for the moment, model and real Db will differ | 15:59 |
| vponomaryov | it is possible to set value to None | 15:59 |
| vponomaryov | now | 15:59 |
| ganso | gouthamr: why did you post an output? | 16:00 |
| vponomaryov | but expected to be boolean always | 16:00 |
| gouthamr | ganso: you asked if it was for shares as well. | 16:00 |
| ganso | gouthamr: oh, yes | 16:00 |
| ganso | gouthamr: ok | 16:00 |
| ganso | gouthamr: it is already workflowed | 16:00 |
| gouthamr | ganso: awesome thank you | 16:01 |
| *** pcaruana has quit IRC | 16:03 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add mountable snapshots support https://review.openstack.org/345526 | 16:05 |
| cknight | ganso: pong | 16:06 |
| ganso | cknight: Hi Clinton. Have you tried running reverting a snapshot in the LVM driver while it has an access rule? | 16:06 |
| cknight | ganso: Don't think so. Do you suspect a problem? | 16:06 |
| ganso | cknight: yes, it does not work | 16:07 |
| ganso | cknight: the share stays stuck in LVM merging state | 16:07 |
| ganso | cknight: and so far, my co-worker hasn't found a way to fix it... so it becomes unusable | 16:07 |
| ganso | cknight: I believe the correct way is to have an API validation that prevents revert-to-snapshot if there are access rules registered for the share | 16:08 |
| cknight | ganso: Ben did the LVM revert. Has he looked at it? bswartz ^^ | 16:08 |
| cknight | ganso: Disagree on removing rules before a revert. That's too egregious. | 16:08 |
| ganso | cknight: not, I wasn't aware. bswartz ? | 16:08 |
| bswartz | hi | 16:08 |
| bswartz | but in LVM implementation? | 16:08 |
| bswartz | s/but/bug/ | 16:08 |
| ganso | bswartz: yes | 16:08 |
| ganso | cknight: then something has to be fixed in LVM driver to make it compatible, currently this seems to me a terrible user experience | 16:09 |
| cknight | ganso: Indeed. I suspect Ben can figure it out. | 16:09 |
| bswartz | ganso: is there a bug on LP with repro instructions? | 16:10 |
| ganso | bswartz: yes | 16:10 |
| ganso | bswartz: just a sec | 16:10 |
| bswartz | I wrote that implementation back in newton, haven't played with it since then | 16:10 |
| ganso | https://bugs.launchpad.net/manila/+bug/1658133 | 16:10 |
| openstack | Launchpad bug 1658133 in Manila "Revert to snapshot fails with mounted share in LVM driver " [Undecided,New] | 16:10 |
| bswartz | k ty | 16:10 |
| *** sandanar__ has quit IRC | 16:15 | |
| *** xyang_ has quit IRC | 16:17 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add cast_rules_to_readonly to share instances https://review.openstack.org/419163 | 16:23 |
| ganso | cknight, bswartz, gouthamr, tbarron: Hello all. This small driver patch is waiting for 1 more +2 and +W https://review.openstack.org/#/c/411923/ Could you please take a look at it? Thanks in advance | 16:24 |
| bswartz | ganso: I'm guessing you checked for this bug that LVM has and your driver doesn't have that one? | 16:29 |
| ganso | bswartz: yup, my driver does not have it | 16:29 |
| cknight | ganso: Your revert-to-snapshot patch looks fine. Just need the release note tweak Goutham pointed out. | 16:33 |
| ganso | cknight: thx, coming up | 16:34 |
| cknight | ganso: I'll +2 once that's fixed. And then I'll ask you to review mine :-) | 16:34 |
| ganso | cknight: sure | 16:34 |
| openstackgerrit | Merged openstack/python-manilaclient: Support changes to access rules APIs https://review.openstack.org/422307 | 16:36 |
| bswartz | (╯°□°）╯︵ ┻━┻ | 16:37 |
| gouthamr | :DD | 16:37 |
| ganso | gouthamr: This look good? http://paste.openstack.org/show/595815/ | 16:40 |
| ganso | bswartz: lol | 16:40 |
| bswartz | I'm just pissed because I keep screwing up my share type while reproing this bug | 16:41 |
| *** xyang_ has joined #openstack-manila | 16:48 | |
| *** xyang_ has quit IRC | 16:49 | |
| bswartz | ganso: I was able to reproduce | 16:50 |
| bswartz | I *hope* I can find a solution | 16:51 |
| gouthamr | ganso: maybe :) http://paste.openstack.org/show/595819/ | 16:52 |
| ganso | gouthamr: thanks! | 16:53 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Implement Revert-to-snapshot in HNAS Driver https://review.openstack.org/411923 | 16:54 |
| gouthamr | if you're using kazoo and manila, please bear with the immense love that the two have for each other.. i'll find a way to reduce the log spam | 16:58 |
| *** xyang_ has joined #openstack-manila | 17:02 | |
| bswartz | gouthamr: most people won't have kazoo enabled because it's not default yet | 17:04 |
| bswartz | gouthamr: so we have time to fix the log spam | 17:04 |
| bswartz | I can modify my dev env to turn off kazoo to solve the problem for myself | 17:04 |
| *** xyang_ has quit IRC | 17:04 | |
| *** xyang_ has joined #openstack-manila | 17:07 | |
| tbarron | ganso, on https://review.openstack.org/#/c/411923 since we're still waiting for jenkins would you mind removing the un-needed Depends-On in the commit mesg? | 17:08 |
| ganso | tbarron: 1) why? 2) if I do that, my CI will not run the patch today, my infra is shutting down in less than 2 hours | 17:09 |
| tbarron | ganso: ok then | 17:09 |
| bswartz | infra shutting down? | 17:09 |
| bswartz | scheduled maintenance? | 17:10 |
| ganso | bswartz: yes | 17:10 |
| tbarron | ganso: normally we do that when the patch on which you depended has merged | 17:10 |
| ganso | tbarron: yea it was leftover | 17:10 |
| bswartz | ganso: regarding the LVM revert issue, it's likely that the fix will involve temporarily removing all access rules during the revert and then readding them | 17:10 |
| tbarron | ganso: just answering "1) why?" - you know why then | 17:11 |
| ganso | tbarron: it was separate before, and then rebased on top, so the depends-on wasn't needed anymore... but still causes no impact having it there | 17:11 |
| tbarron | ganso: but under the circumstances I won't insist | 17:11 |
| ganso | tbarron: thanks | 17:11 |
| ganso | bswartz: only within the LVM driver? | 17:11 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add cast_rules_to_readonly to share instances https://review.openstack.org/419163 | 17:12 |
| bswartz | ganso: well we only have 3 implementations of the revert feature | 17:18 |
| bswartz | ganso: evidently NetApp and HNAS can't revert a mounted filesystem, but LVM can't and I bet others can't | 17:18 |
| ganso | bswartz: ^ can/can't? | 17:19 |
| bswartz | ganso: evidently NetApp and HNAS can revert a mounted filesystem, but LVM can't and I bet others can't | 17:19 |
| ganso | bswartz: why do you bet others can't? | 17:19 |
| bswartz | because at a technical level this is a hard problem | 17:20 |
| ganso | bswartz: so, do you think it is best to have a validation in our API that says "please remove the existing access rules" ? | 17:21 |
| bswartz | many NFS server implementations expose details of the underlying filesystem to clients in ways that aren't abstract enough to allow a revert to an essentially different filesystem transparently | 17:21 |
| bswartz | ganso: no no | 17:22 |
| bswartz | ganso: My proposed fix may involve the manager supplying the list of current access rules to the driver when doing the revert in case the driver wants to remove and re-add all the access rules during the revert | 17:22 |
| ganso | bswartz: I suggested that during review | 17:23 |
| ganso | bswartz: cknight did not agree | 17:23 |
| bswartz | why did you suggest it? | 17:23 |
| bswartz | were you aware of this problem? | 17:23 |
| *** lseki has joined #openstack-manila | 17:24 | |
| *** porrua has quit IRC | 17:24 | |
| ganso | bswartz: because there were 2 ways to do it in my driver | 17:24 |
| *** a-pugachev has quit IRC | 17:24 | |
| cknight | ganso: I didn't agree with the API check that all rules had been removed. I like Ben's suggestion of having the manager supply the rules to the driver, since some backends may need to remove/replace the rules, and others like ours won't. | 17:25 |
| cknight | ganso: Ben's idea makes it automatic. | 17:25 |
| bswartz | yeah I would like to leave this up to the driver | 17:25 |
| bswartz | however the driver needs the list because it can't pull that out of the database on its own (thankfully) | 17:25 |
| ganso | cknight: oh right, I suggested invoking update_access instead of that... I had thought about that before but update_access seemed to me more efficient | 17:26 |
| cknight | ganso: The filesystem is going to change abruptly anyway, so a momentary interruption of access seems OK. | 17:26 |
| ganso | cknight: but update_access would force all drivers to refresh their access_rules, even if they do not need to | 17:28 |
| ganso | cknight: so providing the rules to the driver is better | 17:29 |
| bswartz | ganso: this driver interface change can be part of my bugfix | 17:30 |
| bswartz | and it doesn't need to happen until after FF | 17:30 |
| ganso | bswartz: ok | 17:30 |
| bswartz | I'd rather focus on getting more patches merged | 17:30 |
| ganso | bswartz: me too | 17:30 |
| *** lpetrut has quit IRC | 17:36 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add cast_rules_to_readonly to share instances https://review.openstack.org/419163 | 17:39 |
| *** porrua has joined #openstack-manila | 17:45 | |
| *** xyang_ has quit IRC | 17:59 | |
| *** xyang_ has joined #openstack-manila | 17:59 | |
| *** xyang_ has quit IRC | 18:02 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add mountable snapshots support https://review.openstack.org/345526 | 18:05 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/python-manilaclient: Add share group support to Manila client https://review.openstack.org/335120 | 18:06 |
| *** xyang_ has joined #openstack-manila | 18:08 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add cast_rules_to_readonly to share instances https://review.openstack.org/419163 | 18:16 |
| gouthamr | ganso: https://bugs.launchpad.net/manila/+bug/1658157 | 18:17 |
| openstack | Launchpad bug 1658157 in Manila "Driver assisted migration fails to complete because access rules status never goes to 'active'" [Medium,New] | 18:17 |
| gouthamr | ganso: fix on its way | 18:17 |
| ganso | gouthamr: thanks! | 18:18 |
| openstackgerrit | Clinton Knight proposed openstack/manila: NetApp: Support share revert to snapshot https://review.openstack.org/357545 | 18:29 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Implement Revert-to-snapshot in HNAS Driver https://review.openstack.org/411923 | 18:30 |
| ganso | tbarron: fulfilled your request ^ | 18:31 |
| ganso | tbarron: reno had to be fixed | 18:31 |
| ganso | cknight: thanks for pointing out the reno problem | 18:31 |
| tbarron | ganso: k, it looked good to me otherwise (guess I didn't look at the reno hard enough) | 18:32 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Add mountable snapshots support to manila client https://review.openstack.org/345625 | 18:35 |
| *** lpetrut has joined #openstack-manila | 18:36 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila: Don't call update_access if there are no rules https://review.openstack.org/423407 | 18:39 |
| *** ociuhandu has quit IRC | 18:40 | |
| *** draynium has quit IRC | 18:45 | |
| *** xyang_ has quit IRC | 18:45 | |
| *** draynium has joined #openstack-manila | 18:49 | |
| *** JoseMello has quit IRC | 18:55 | |
| *** ociuhandu has joined #openstack-manila | 19:00 | |
| *** jprovazn has quit IRC | 19:02 | |
| openstackgerrit | Yogesh proposed openstack/manila: Improve test coverage for share migration https://review.openstack.org/418559 | 19:33 |
| ganso | vponomaryov, markstur, cknight, tbarron, bswartz: Hello, could you please review https://review.openstack.org/#/c/406305/ when you have some time? Goutham's +2 is feeling lonely there :) | 19:39 |
| gouthamr | +2s have feelings | 19:40 |
| gouthamr | :0 | 19:40 |
| bswartz | ganso I can +2 it as well but we need to find a 3rd | 19:40 |
| ganso | gouthamr: mind blown right? | 19:40 |
| gouthamr | :) * | 19:40 |
| ganso | bswartz: it is good as well :) | 19:41 |
| gouthamr | ^ yeah he can use all he gets today... | 19:41 |
| markstur | Lot's of lines-of-code need review today. Can't we just have an amnesty day and let it all in? | 19:43 |
| *** yumiriam has quit IRC | 19:44 | |
| markstur | *blasphemy -- I know | 19:44 |
| ganso | gouthamr: you still haven't blessed the patch you're co-author https://review.openstack.org/#/c/419163 | 19:44 |
| *** xyang_ has joined #openstack-manila | 19:45 | |
| *** xyang_ has quit IRC | 19:46 | |
| *** xyang_ has joined #openstack-manila | 19:50 | |
| *** catinthe_ has joined #openstack-manila | 19:50 | |
| *** catintheroof has quit IRC | 19:53 | |
| *** xyang_ has quit IRC | 20:00 | |
| *** gouthamr has quit IRC | 20:07 | |
| tbarron | tests look good on https://review.openstack.org/#/c/419163 so it has one +2 now | 20:13 |
| tbarron | That's the top of the stack at https://etherpad.openstack.org/p/manila-ocata-code-review-focus and will force a rebase on others ... | 20:14 |
| tbarron | I haven't reviewed https://review.openstack.org/#/c/406305/ and it's big, but will conflict as well. | 20:16 |
| *** draynium has quit IRC | 20:16 | |
| *** dustins has quit IRC | 20:22 | |
| *** xyang_ has joined #openstack-manila | 20:24 | |
| *** xyang_ has quit IRC | 20:27 | |
| *** xyang1 has joined #openstack-manila | 20:29 | |
| *** xyang_ has joined #openstack-manila | 20:31 | |
| *** eharney has quit IRC | 20:34 | |
| *** draynium has joined #openstack-manila | 20:36 | |
| *** alyson_ has quit IRC | 20:57 | |
| *** dustins has joined #openstack-manila | 21:01 | |
| *** timcl has quit IRC | 21:02 | |
| *** catinthe_ has quit IRC | 21:02 | |
| *** catintheroof has joined #openstack-manila | 21:03 | |
| *** porrua has quit IRC | 21:05 | |
| *** catintheroof has quit IRC | 21:07 | |
| *** eharney has joined #openstack-manila | 21:13 | |
| *** gouthamr has joined #openstack-manila | 21:14 | |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-image-elements: Adds support for NFS Ganesha https://review.openstack.org/411500 | 21:24 |
| openstackgerrit | Yogesh proposed openstack/manila: Improve test coverage for share migration https://review.openstack.org/418559 | 21:26 |
| bswartz | nobody has +2 the IPv6 patch | 21:31 |
| tbarron | bswartz: nobody has been looking at it but me lately I think. | 21:32 |
| tbarron | bswartz: the plugin patch needs some minor stuff from my perspective | 21:32 |
| tbarron | bswartz: the access list patch mostly needs a rebase | 21:32 |
| tbarron | bswartz: and I haven't tested it yet | 21:33 |
| tbarron | bswartz: want to try running lvm with it but haven't had a chance yet | 21:33 |
| bswartz | tbarron I saw you -1 and also -1 from gouthamr | 21:35 |
| bswartz | I've been starting to look at IPv6 but honestly I'm more interested in hands on testing than reading the code as I think you guys have that covered | 21:35 |
| tbarron | bswartz: my -1 is that we need to hit some docs, update stats tests, etc. | 21:35 |
| tbarron | also that ipv6=True for lvm driver but no extra test coverage | 21:35 |
| tbarron | I think those things could be fixed by Tuesday *if* it works. | 21:36 |
| tbarron | bswartz: so hands on, try lvm. | 21:36 |
| tbarron | That's what I want to try out but I haven't gotten time to set up env yet. | 21:36 |
| *** gouthamr has quit IRC | 21:37 | |
| tbarron | bswartz: the plugin patch doesn't have microversion changes but the access list patch does. | 21:37 |
| tbarron | bswartz: so it would be good to land https://review.openstack.org/#/c/419163/ and the migration improvements patch first | 21:38 |
| tbarron | to save on lots of rebasing | 21:38 |
| tbarron | I haven't had time to review migration improvements patch and its lower prio but I see it has two +2s. | 21:39 |
| bswartz | k | 21:43 |
| bswartz | tbarron: you're welcome to be the 3rd +2 | 21:43 |
| bswartz | if we can get a few things in this evening then people will have the weekend to do rebase hell | 21:43 |
| tbarron | bswartz: I haven't reviewed it and it's a big patch. | 21:43 |
| tbarron | xyang1: markstur ^^^^ you've reviewed https://review.openstack.org/#/c/406305/ recently and it has two +2s (but from same company). Are you comfortable merging? | 21:48 |
| tbarron | xyang1: markstur if you are, it would help with rebase hell ... | 21:48 |
| xyang_ | tbarron: I'll take a look | 21:49 |
| tbarron | xyang_: thanks!! I'm inclined to merge it but honestly I haven't myself reviewed it. | 21:49 |
| xyang_ | tbarron: oh, I thought you consider yourself work for the same company too:) | 21:50 |
| tbarron | xyang_: not any more :) | 21:50 |
| xyang_ | :) | 21:50 |
| tbarron | now I consider them in the same category as DMC | 21:51 |
| tbarron | :) | 21:51 |
| xyang_ | actually DMC is better, at least shorter, but we don't get that name:) | 21:51 |
| tbarron | I'm available for low-cost naming services. | 21:52 |
| xyang_ | tbarron: talk to our branding office:) | 21:52 |
| markstur | talk to the Run D.M.C. guys | 21:52 |
| tbarron | I thought I'd start with the office of the cto | 21:52 |
| xyang_ | cto office is not in the business of rebranding | 21:53 |
| tbarron | hmm, that's what most of them seem to do (he jokes) | 21:53 |
| tbarron | but xyang writes real code instead of just doing slides and marchitechture | 21:54 |
| xyang_ | tbarron: the boring part:) | 21:55 |
| *** gouthamr has joined #openstack-manila | 22:01 | |
| *** xyang_ has quit IRC | 22:12 | |
| tbarron | gouthamr: when the migration improvements merges I will look for a rebase of https://review.openstack.org/#/c/419163/ and re-apply my +2 | 22:13 |
| *** dustins has quit IRC | 22:13 | |
| tbarron | bswartz: we'll need another +2 on that one that's not gouthamr or ganso | 22:13 |
| gouthamr | tbarron: yep. i'm rebasing it right now.. | 22:13 |
| *** xyang_ has joined #openstack-manila | 22:13 | |
| gouthamr | tbarron: thank you! | 22:14 |
| tbarron | then we can rebase the ipv6 stuff | 22:14 |
| openstackgerrit | Merged openstack/manila: Don't call update_access if there are no rules https://review.openstack.org/423407 | 22:17 |
| gouthamr | #mergemergemerge | 22:20 |
| *** lseki has quit IRC | 22:40 | |
| *** xyang_ has quit IRC | 22:40 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add cast_rules_to_readonly to share instances https://review.openstack.org/419163 | 22:47 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add cast_rules_to_readonly to share instances https://review.openstack.org/419163 | 22:50 |
| openstackgerrit | Merged openstack/manila: Share Migration Ocata Improvements https://review.openstack.org/406305 | 22:57 |
| *** xyang1 has quit IRC | 23:14 | |
| *** cknight has quit IRC | 23:14 | |
| openstackgerrit | Helen Walsh proposed openstack/manila: VMAX manila plugin - Support for VMAX in Manila https://review.openstack.org/404859 | 23:21 |
| *** ganso has quit IRC | 23:34 | |
| *** lpetrut has quit IRC | 23:44 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!