| *** mtanino_ has joined #openstack-manila | 00:29 | |
| *** mtanino has quit IRC | 00:30 | |
| *** gouthamr has joined #openstack-manila | 00:48 | |
| *** faiz89 has joined #openstack-manila | 00:54 | |
| *** jcsp has quit IRC | 01:01 | |
| *** catintheroof has quit IRC | 01:02 | |
| *** jcsp has joined #openstack-manila | 01:13 | |
| *** faiz89 has quit IRC | 01:22 | |
| *** crushil has joined #openstack-manila | 01:36 | |
| *** catintheroof has joined #openstack-manila | 01:37 | |
| *** catintheroof has quit IRC | 01:37 | |
| *** catintheroof has joined #openstack-manila | 01:37 | |
| bswartz | markstur: ping | 01:45 |
|---|---|---|
| *** faiz89 has joined #openstack-manila | 01:45 | |
| bswartz | gouthamr: ping | 01:46 |
| gouthamr | bswartz: pong | 01:46 |
| bswartz | soooo | 01:46 |
| bswartz | regarding tabs vs spaces | 01:46 |
| bswartz | I tried to convert another one of my projects from tabs to spaces and I found a serious problem | 01:46 |
| bswartz | bash doesn't allow the use of indented here docs with spaces -- tabs are required | 01:47 |
| bswartz | I can't find a workaround for this that doesn't involve complete restructuring of some shell scripts | 01:48 |
| gouthamr | oh.. which is why the bashate rule? https://google.github.io/styleguide/shell.xml?showone=Indentation#Indentation | 01:48 |
| bswartz | bashate requires spaces | 01:49 |
| bswartz | and bashate expects 4 column indents | 01:49 |
| bswartz | but that precludes the use of indented here docs which basically make code unreadable | 01:49 |
| *** faiz89 has quit IRC | 01:52 | |
| markstur | bswartz: ping | 01:52 |
| bswartz | markstur: read above | 01:52 |
| markstur | s/ping/pong/ :) | 01:52 |
| gouthamr | bswartz: http://unix.stackexchange.com/questions/76481/cant-indent-heredoc-to-match-nestings-indent | 01:53 |
| gouthamr | gah | 01:53 |
| bswartz | gouthamr: exactly my problem | 01:53 |
| gouthamr | says you can't use spaces. missed that :P | 01:53 |
| bswartz | gouthamr, markstur: Makefiles are another file format I know of that seems to require tabs instead of spaces | 01:55 |
| gouthamr | hmmm.. i see there are a few interesting hacks around this... but probably for readability, printf is way better | 01:57 |
| bswartz | gouthamr: doubt it would work for what I need | 01:59 |
| markstur | some interesting options here http://stackoverflow.com/questions/33815600/indenting-heredocs-with-spaces | 02:00 |
| gouthamr | bswartz: did it break in manila-test-image? | 02:00 |
| bswartz | gouthamr: no that project doesn't use here docs | 02:00 |
| bswartz | my dev envirment project uses here docs extensively | 02:00 |
| markstur | Most of the hacks, although creative and perhaps even pretty, could be a source of future problems because they are sneaky | 02:00 |
| markstur | the print one is pretty safe | 02:01 |
| bswartz | there are cases where you want leading spaces in your here doc and you're forced to mix tabs and spaces on the same line | 02:01 |
| markstur | changine heredocs to theredocs (in a file) works for big ones, printf works for small ones | 02:01 |
| bswartz | yeah I considered that but then I'd have to split 2 larges files into about 40 small files | 02:02 |
| markstur | In the link above the one with the leading ": " looks neat, but is kind of sneaky | 02:02 |
| markstur | I would be inclined to just push heredocs to special functions and then not care so much about the indent | 02:03 |
| markstur | but I'm not really sure what the code would look like . I can't picture all the heredocs | 02:03 |
| bswartz | when you do that it becomes difficult to detect (visually) where your functions begin and end | 02:03 |
| markstur | if the function's only purpose is to return the heredoc then it should be easy enough. no? | 02:04 |
| markstur | but then also the doc isn't "here" anymore which might have been nice | 02:04 |
| bswartz | markstur: I write code with this pattern all the time: https://paste.fedoraproject.org/541340/58282991/ | 02:05 |
| bswartz | I'm basically embedding a ton of shell commands in a local script which will be run on a remote machine | 02:06 |
| bswartz | I invoke "ssh bash" and pass it a here doc | 02:06 |
| markstur | I've just always figured heredocs meant no indent. In some ways they are hard to read, but the nice thing is you get a wider here doc. So you can read it. | 02:06 |
| markstur | I don't mind if tabs are needed to do that code your way. | 02:07 |
| markstur | It's just unfortunate if it affects the ability to keep tabs out of other places | 02:07 |
| bswartz | agreed | 02:07 |
| bswartz | maybe the almighty bash gods will take pity on us and invent a way to indent here docs with spaces | 02:08 |
| markstur | cat << ' EOF' | sed -e 's/^ //'; | 02:09 |
| markstur | I think the sed is a little sneaky, but you can have your indent if you are willing to strip it like that | 02:10 |
| bswartz | markstur: I'd have to remember to use that in every here doc | 02:10 |
| bswartz | and as I said my code has dozens of them | 02:10 |
| markstur | and I don't think putting them in would be that bad. It's what happens when someone breaks one and has to learn the hack for the first time that bothers me more | 02:11 |
| markstur | It isn't terrible to read/learn, but it would be unfortunate | 02:11 |
| markstur | I guess I'll admit, I'd be reluctant to put that in dozens of places. | 02:12 |
| bswartz | it would create a maintenance issue | 02:12 |
| bswartz | if there was a way to write that hack one time and use it everywhere I'd be inclined to do it | 02:13 |
| markstur | gotta run | 02:14 |
| bswartz | .o/ | 02:15 |
| *** mtanino has joined #openstack-manila | 02:17 | |
| *** mtanino_ has quit IRC | 02:19 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add access-rules tests to improve the coverage https://review.openstack.org/390380 | 02:20 |
| *** absubram has quit IRC | 02:27 | |
| *** mtanino has quit IRC | 02:34 | |
| *** kaisers_ has joined #openstack-manila | 02:55 | |
| *** kaisers has quit IRC | 02:58 | |
| bswartz | tbarron: you still up by any chance? | 03:03 |
| bswartz | tbarron: http://paste.openstack.org/show/596962/ | 03:07 |
| *** catintheroof has quit IRC | 03:09 | |
| *** catintheroof has joined #openstack-manila | 03:11 | |
| *** catintheroof has quit IRC | 03:15 | |
| *** mtanino has joined #openstack-manila | 03:35 | |
| *** a-pugachev has quit IRC | 03:58 | |
| *** gouthamr has quit IRC | 04:07 | |
| *** mtanino has quit IRC | 04:19 | |
| *** nkrinner_afk is now known as nkrinner | 05:31 | |
| *** crushil has quit IRC | 06:28 | |
| *** lpetrut has joined #openstack-manila | 06:38 | |
| *** dsariel has joined #openstack-manila | 06:44 | |
| *** rraja has joined #openstack-manila | 07:13 | |
| *** lpetrut has quit IRC | 07:20 | |
| *** lpetrut has joined #openstack-manila | 07:30 | |
| *** jprovazn has joined #openstack-manila | 07:41 | |
| *** gaurangt has joined #openstack-manila | 08:53 | |
| *** lpetrut has quit IRC | 08:57 | |
| *** gcb has joined #openstack-manila | 09:52 | |
| *** a-pugachev has joined #openstack-manila | 09:55 | |
| *** dsariel has quit IRC | 10:04 | |
| *** lpetrut has joined #openstack-manila | 10:04 | |
| *** alyson_ has joined #openstack-manila | 10:09 | |
| *** ganso has joined #openstack-manila | 10:12 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix error'ed access rules being sent to driver https://review.openstack.org/426896 | 10:28 |
| openstackgerrit | Merged openstack/manila-ui: Imported Translations from Zanata https://review.openstack.org/426655 | 10:41 |
| openstackgerrit | Alyson proposed openstack/manila: HNAS: avoid mismatch access level for managed shares https://review.openstack.org/427096 | 10:55 |
| openstackgerrit | Alyson proposed openstack/manila: HNAS: avoid mismatch access level for managed shares https://review.openstack.org/427096 | 10:57 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Decrease share migration periodic task interval https://review.openstack.org/427099 | 10:58 |
| *** dmellado has quit IRC | 11:00 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Enable host-assisted migration in ZFSOnLinux CI https://review.openstack.org/427101 | 11:02 |
| *** dmellado has joined #openstack-manila | 11:03 | |
| *** rraja has quit IRC | 11:06 | |
| *** yumiriam has joined #openstack-manila | 11:16 | |
| openstackgerrit | Merged openstack/manila: Add access-rules tests to improve the coverage https://review.openstack.org/390380 | 11:17 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix setup of DHSS=False mode for generic driver https://review.openstack.org/426737 | 11:25 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix setup of DHSS=False mode for generic driver https://review.openstack.org/426737 | 11:27 |
| *** dsariel has joined #openstack-manila | 11:28 | |
| openstackgerrit | Alyson proposed openstack/manila: HNAS: Fix concurrency error when managing snapshots https://review.openstack.org/426806 | 11:46 |
| openstackgerrit | Alyson proposed openstack/manila: HNAS: avoid mismatch access level for managed shares https://review.openstack.org/427096 | 12:16 |
| *** catintheroof has joined #openstack-manila | 12:22 | |
| openstackgerrit | Alyson proposed openstack/manila: HNAS: avoid mismatch access level for managed shares https://review.openstack.org/427096 | 12:31 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-manila: DNM - test puppet module build https://review.openstack.org/427167 | 12:49 |
| tbarron | bswartz: stacking with the localrc you pasted now | 12:51 |
| tbarron | bswartz: after I get out of meetings this morning I'll see how it works out, thanks! | 12:52 |
| * tbarron was going in circles trying to get slaac working on his compute instance yesterday | 12:52 | |
| vponomaryov | tbarron: veeeery early bird | 12:53 |
| tbarron | vponomaryov: today, not always | 12:56 |
| *** rraja has joined #openstack-manila | 13:00 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix setup of DHSS=False mode for generic driver https://review.openstack.org/426737 | 13:11 |
| *** timcl has quit IRC | 13:11 | |
| *** timcl has joined #openstack-manila | 13:11 | |
| ganso | bswartz: ping | 13:12 |
| *** dustins|out is now known as dustins | 13:24 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix setup of DHSS=False mode for generic driver https://review.openstack.org/426737 | 13:27 |
| *** dustins has quit IRC | 13:29 | |
| *** dustins has joined #openstack-manila | 13:29 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix setup of DHSS=False mode for generic driver https://review.openstack.org/426737 | 13:29 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix setup of DHSS=False mode for generic driver https://review.openstack.org/426737 | 13:30 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix setup of DHSS=False mode for generic driver https://review.openstack.org/426737 | 13:32 |
| *** catinthe_ has joined #openstack-manila | 13:36 | |
| *** catintheroof has quit IRC | 13:40 | |
| *** xinyanzhang has quit IRC | 13:47 | |
| *** gouthamr has joined #openstack-manila | 13:56 | |
| *** dsariel has quit IRC | 14:04 | |
| tbarron | working with devstack locally I hit https://bugs.launchpad.net/python-openstackclient/+bug/1659878 b/c global requirements for openstackclient is still 3.8.0 | 14:11 |
| openstack | Launchpad bug 1659878 in python-openstackclient "Network creation ignores --project option" [High,Fix released] - Assigned to Dean Troyer (dtroyer) | 14:11 |
| tbarron | so demo owned network isn't really owned by demo, it's owned by admin ^^^ | 14:12 |
| tbarron | vponomaryov: bswartz does this impact us in CI ^^ | 14:12 |
| tbarron | compute instances created by demo can't attach their nic to the "private" network | 14:13 |
| tbarron | I can work around of course by using LIBS_FROM_GIT | 14:13 |
| *** dsariel has joined #openstack-manila | 14:19 | |
| *** gcb has quit IRC | 14:24 | |
| ganso | gouthamr: ping | 14:25 |
| *** xinyanzhang has joined #openstack-manila | 14:32 | |
| tbarron | bswartz: restacking with your localrc plus that workaround ^^ | 14:32 |
| *** breitz has quit IRC | 14:35 | |
| *** yumiriam1 has joined #openstack-manila | 14:38 | |
| *** dsariel has quit IRC | 14:41 | |
| *** yumiriam has quit IRC | 14:41 | |
| *** yumiriam1 has quit IRC | 14:41 | |
| *** jprovazn has quit IRC | 14:42 | |
| *** yumiriam has joined #openstack-manila | 14:42 | |
| *** mtanino has joined #openstack-manila | 14:45 | |
| *** vkmc has quit IRC | 14:47 | |
| gouthamr | ganso: pong | 14:48 |
| *** vkmc has joined #openstack-manila | 14:52 | |
| *** Yogi1 has joined #openstack-manila | 14:53 | |
| *** dsariel has joined #openstack-manila | 14:54 | |
| *** eharney has joined #openstack-manila | 14:57 | |
| bswartz | ganso: sorry for late pong, I was in a meeting | 14:57 |
| *** porrua has joined #openstack-manila | 14:58 | |
| vponomaryov | tbarron: I haven't seen problem related to that issue | 14:58 |
| *** crushil has joined #openstack-manila | 14:58 | |
| vponomaryov | tbarron: in our CI | 14:58 |
| bswartz | tbarron: I noticed that behavior in my dev environment and I assumed things were working as designed but if it's a bug that's good news | 14:58 |
| *** gaurangt has left #openstack-manila | 14:58 | |
| bswartz | tbarron: I create my own networks and use those and everything works fine | 14:59 |
| bswartz | tbarron: I didn't give you my complete writeup, I wanted to talk to you yesterday about that local.conf | 14:59 |
| bswartz | tbarron: if it works for you I'll proceed with the rest of the writeup | 15:00 |
| vponomaryov | bswartz: here is how Nova API suffers when I tried to workaround its new behaviour -> http://logs.openstack.org/37/426737/11/check/gate-manila-tempest-dsvm-generic-no-share-servers-ubuntu-xenial-nv/cc1915b/logs/screen-n-api.txt.gz?level=ERROR | 15:00 |
| *** dustins_ has joined #openstack-manila | 15:01 | |
| vponomaryov | bswartz: so, I was able using client calls to make Nova hit DB exceptions )) | 15:01 |
| bswartz | vponomaryov: using which workaround? the old one that we know is broken? | 15:01 |
| vponomaryov | https://review.openstack.org/#/c/426737/ | 15:01 |
| bswartz | I just hope the new workaround actually works | 15:01 |
| vponomaryov | so, I have one more way, that will try next | 15:02 |
| vponomaryov | this one already worked eirlier today | 15:02 |
| vponomaryov | just was not brushed enough | 15:02 |
| bswartz | ok | 15:02 |
| *** dustins has quit IRC | 15:04 | |
| *** dustins_ is now known as dustins | 15:06 | |
| *** nkrinner is now known as nkrinner_afk | 15:07 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix setup of DHSS=False mode for generic driver https://review.openstack.org/426737 | 15:09 |
| *** kaisers_ has quit IRC | 15:11 | |
| *** kaisers has joined #openstack-manila | 15:12 | |
| *** cdelatte has joined #openstack-manila | 15:14 | |
| *** rraja has quit IRC | 15:16 | |
| *** kaisers has quit IRC | 15:17 | |
| *** kaisers has joined #openstack-manila | 15:22 | |
| *** kaisers has quit IRC | 15:26 | |
| *** a-pugachev has quit IRC | 15:29 | |
| *** xyang_ has joined #openstack-manila | 15:29 | |
| *** breitz has joined #openstack-manila | 15:33 | |
| openstackgerrit | Arne Wiebalck proposed openstack/manila-ui: Replace 'Extend Share' by 'Resize Share' https://review.openstack.org/411384 | 15:35 |
| *** kaisers has joined #openstack-manila | 15:35 | |
| *** jprovazn has joined #openstack-manila | 15:38 | |
| *** mtanino_ has joined #openstack-manila | 15:39 | |
| *** mtanino has quit IRC | 15:40 | |
| *** catinthe_ has quit IRC | 15:45 | |
| *** a-pugachev has joined #openstack-manila | 15:46 | |
| *** kaisers has quit IRC | 15:48 | |
| *** xyang_ has quit IRC | 15:57 | |
| bswartz | tbarron: https://wiki.openstack.org/wiki/Manila/IPv6 | 15:57 |
| tbarron | bswartz: thanks! I'll work through it this afternoon when I get out of meetings. | 15:58 |
| *** absubram has joined #openstack-manila | 16:02 | |
| *** crushil has quit IRC | 16:03 | |
| *** crushil has joined #openstack-manila | 16:04 | |
| *** absubram_ has joined #openstack-manila | 16:07 | |
| *** absubram has quit IRC | 16:07 | |
| *** absubram_ is now known as absubram | 16:07 | |
| ganso | bswartz: Hi, sorry for the delay, was driving | 16:09 |
| ganso | bswartz: are you around? | 16:09 |
| bswartz | ganso: yes for a few moments | 16:13 |
| ganso | bswartz: ok, couple of questions | 16:13 |
| ganso | bswartz: 1) what do you think about the tenant being about to see the destination instance export location during a migration, while still not able to do anything with it? | 16:14 |
| bswartz | what do you mean not being able to do anything with it? | 16:15 |
| bswartz | they'll be able to attempt to mount it | 16:16 |
| ganso | bswartz: not they will not, because they cannot add rules to mount the destination, we've agreed to this in the past | 16:16 |
| bswartz | it might fail, or not fail, but that would be backend dependant | 16:16 |
| bswartz | oh I see | 16:16 |
| bswartz | without access rules the mount would always fail | 16:16 |
| ganso | bswartz: so do you think it should be hidden? | 16:17 |
| bswartz | I don't feel strongly either way | 16:17 |
| ganso | bswartz: I was testing this morning, and for a moment I did not know which export location to choose... because there were 2, and one was the destination | 16:18 |
| ganso | bswartz: so I had to change to admin tenant to use "share-instance-list" and figure out which one was the source so I could mount the correct one | 16:18 |
| bswartz | were both visible through manila show? | 16:19 |
| bswartz | because in that case we should hide the useless one | 16:19 |
| ganso | bswartz: yes | 16:19 |
| *** porrua has quit IRC | 16:19 | |
| bswartz | and I do feel strongly about that | 16:19 |
| ganso | bswartz: ok great | 16:20 |
| ganso | bswartz: I will log the bug and work on it | 16:20 |
| openstackgerrit | Alyson proposed openstack/manila: HNAS: avoid mismatch access level for managed shares https://review.openstack.org/427096 | 16:21 |
| *** dsariel has quit IRC | 16:25 | |
| bswartz | ganso: you had implied there was more than 1 question | 16:33 |
| ganso | bswartz: oh yes. the other one was this https://bugs.launchpad.net/manila/+bug/1660686 | 16:33 |
| openstack | Launchpad bug 1660686 in Manila "Snapshot export locations always shown even when not supported" [Undecided,New] | 16:33 |
| bswartz | doh | 16:33 |
| ganso | bswartz: I strongly feel this is a bug | 16:34 |
| bswartz | that seems easy to fix in the API service | 16:34 |
| bswartz | +1 | 16:34 |
| ganso | bswartz: in fact, I am fixing that in drivers and manager | 16:34 |
| ganso | bswartz: not in API | 16:34 |
| bswartz | why? | 16:34 |
| ganso | bswartz: because resources are not being handled properly | 16:34 |
| gouthamr | you need the key in the API | 16:34 |
| gouthamr | it can be empty | 16:34 |
| ganso | no no | 16:34 |
| ganso | imagine you have the LVM driver, and 2 shares | 16:34 |
| bswartz | it's just an attribute of the snapshot right? | 16:35 |
| ganso | one created with share type with mount_snapshot_support=True, and the other False | 16:35 |
| bswartz | what am I missing? | 16:35 |
| ganso | then you create a snapshot in each one of them | 16:35 |
| ganso | the LVM driver is creating snapshot exports for both of them | 16:35 |
| bswartz | that's fine | 16:35 |
| ganso | both can create snapshots, because snapshot_support=True | 16:35 |
| gouthamr | oh, isn't that an LVM driver bug? | 16:36 |
| ganso | why is it fine? but one is also creating exports when it is not needed | 16:36 |
| bswartz | as long as the API service doesn't show the export location of the one with mount_snapshot_support=False | 16:36 |
| bswartz | whether it is literally exported or not is up to the driver | 16:36 |
| ganso | LVM, HNAS, and also share manager that should not be reading export locations from snapshot model updates if mount_snapshot_support=False | 16:36 |
| bswartz | from manila's perspective the export_location is merely a string we store and show to users | 16:36 |
| ganso | yes but for drivers they are resources, so we have driver bug and share manager bug here | 16:37 |
| ganso | no need to fix API if we fix share manager | 16:37 |
| bswartz | you mean the manager should not store it in the DB | 16:37 |
| bswartz | even if the driver returns the string | 16:37 |
| *** xyang_ has joined #openstack-manila | 16:37 | |
| ganso | bswartz: exactly | 16:37 |
| bswartz | hmmm | 16:38 |
| *** dsariel has joined #openstack-manila | 16:38 | |
| ganso | bswartz: IMO the manager should do the right thing, not be a wild card | 16:38 |
| bswartz | that seems okay, but I don't see why we wouldn't also fix it in the API service | 16:38 |
| ganso | bswartz: in this case the API will not need fixing, it will not show export locations when they don't exist | 16:39 |
| bswartz | I suppose it's a 1-liner fix in either location | 16:39 |
| ganso | bswartz: it is not | 16:39 |
| ganso | bswartz: also due to the fact that currently drivers cannot determine if mount_snapshot_support is True or False | 16:40 |
| ganso | bswartz: so I am passing this down to drivers so they can determine whether they should create the resource | 16:40 |
| bswartz | it's not just an attribute of the share model? | 16:40 |
| ganso | bswartz: it is, but the share model is not passed | 16:40 |
| gouthamr | ganso: if snapshot.share.mount_snapshot_support ? | 16:40 |
| bswartz | doh | 16:40 |
| bswartz | it's not passed down to where? | 16:41 |
| ganso | gouthamr: no, that's the share_instance, not the share model, I've tried that | 16:41 |
| gouthamr | ganso: set as property in the share model... | 16:41 |
| ganso | bswartz: the share model is not passed down to drivers in create_snapshot | 16:41 |
| bswartz | it should be | 16:41 |
| ganso | gouthamr: I am adjusting where we create a snapshot_instance_dict, and inserting the value there | 16:41 |
| bswartz | rather the share instance model should be, and it should have all these attributes | 16:42 |
| bswartz | maybe that's the bug | 16:42 |
| ganso | bswartz: the share_instance does not have it | 16:42 |
| bswartz | share instance models should have all the extra_specs attributes that he share has | 16:42 |
| ganso | bswartz: and if I am not mistaken, this cannot be proxified | 16:42 |
| gouthamr | ganso: that's the use of self.instance in the share -> only when a share is going through migration will it ever have two instances that have different share types | 16:43 |
| bswartz | I don't see why not | 16:43 |
| gouthamr | ganso: that could have* | 16:43 |
| ganso | gouthamr: I am not sure I am following, how having 2 instances relate to this? | 16:44 |
| ganso | s/relate/relates | 16:44 |
| ganso | bswartz: I'll try proxifying, but last time I tried this it idd not work | 16:44 |
| gouthamr | ganso: ah.. ignore what i said, these capabilities are share properties.. | 16:46 |
| ganso | gouthamr: yes | 16:46 |
| gouthamr | ganso: i was butting into the convo to just tell you you should always sent export_locations, i.e, the key, no matter whether you populate them or not. | 16:47 |
| ganso | gouthamr: in the API? | 16:47 |
| gouthamr | ganso: in the API, beyond the microversion that it was added in | 16:47 |
| ganso | gouthamr: yes, I intended to do that | 16:47 |
| ganso | gouthamr: just not allow the share manager to populate it when not supposed to | 16:47 |
| gouthamr | ganso: +1 that way we don't need that one line fix in the view builder.. | 16:48 |
| *** kaisers has joined #openstack-manila | 16:56 | |
| *** absubram has quit IRC | 16:59 | |
| openstackgerrit | Alyson proposed openstack/manila: HNAS: avoid mismatch access level for managed shares https://review.openstack.org/427096 | 17:07 |
| vponomaryov | ganso: investigating this -> https://bugs.launchpad.net/manila/+bug/1660321 I found out that it has bigger problems )) | 17:10 |
| openstack | Launchpad bug 1660321 in Manila "share-group-snapshot-create is not passing share as part of snapshot" [High,In progress] - Assigned to Valeriy Ponomaryov (vponomaryov) | 17:10 |
| vponomaryov | consistency group snapshot members didn't have "provider_location"s | 17:11 |
| ganso | vponomaryov: humm which problems? initially it seems simple like just passing the ['share'] | 17:11 |
| ganso | vponomaryov: whoa! | 17:11 |
| vponomaryov | but common snapshot instance does | 17:11 |
| ganso | vponomaryov: that is one big problem | 17:11 |
| ganso | vponomaryov: the most important field for snapshots, specially managed snapshots | 17:11 |
| vponomaryov | I am not saying about export locations for snapshot members )) | 17:11 |
| ganso | vponomaryov: is absent | 17:11 |
| ganso | vponomaryov: yea, that too I suppose | 17:11 |
| vponomaryov | so, fix for this ^ would be not so small )) | 17:12 |
| ganso | vponomaryov: glad it is experimental | 17:12 |
| vponomaryov | model update, +1 DB migration, share manager and bse driver classes updates ) | 17:12 |
| ganso | vponomaryov: holy cow | 17:12 |
| *** xyang_ has quit IRC | 17:12 | |
| vponomaryov | + tests )) | 17:13 |
| vponomaryov | API bump | 17:13 |
| ganso | vponomaryov: unit tests and functional tests I suppose | 17:13 |
| *** porrua has joined #openstack-manila | 17:13 | |
| ganso | vponomaryov: python-manilaclient update as well, right? | 17:13 |
| vponomaryov | yes )) | 17:13 |
| vponomaryov | ^_^ | 17:13 |
| ganso | vponomaryov: almost a new feature | 17:13 |
| bswartz | no new features! | 17:14 |
| vponomaryov | bswartz: bugfix )) | 17:14 |
| vponomaryov | just complicated a bit ) | 17:14 |
| ganso | vponomaryov: guess 8K lines of code weren't enough for share groups | 17:15 |
| vponomaryov | ganso: actually, it should have been separate fix -> fix for CGs | 17:15 |
| vponomaryov | ganso: they didn't understand provider locations | 17:15 |
| vponomaryov | so, it is bug of original implementation of "provider_location" feature | 17:16 |
| *** xyang_ has joined #openstack-manila | 17:16 | |
| vponomaryov | that didn't update CGs | 17:16 |
| ganso | vponomaryov: nobody liked CGs back then | 17:16 |
| *** kaisers has quit IRC | 17:17 | |
| ganso | vponomaryov: and share groups is the new kid on the block | 17:17 |
| ganso | bswartz: it was a feature missing a leg | 17:18 |
| vponomaryov | ganso: no, it is house of cards with lack of cards in it, and this one is the top one ) | 17:19 |
| ganso | vponomaryov: house of cards without kevin spacey | 17:20 |
| bswartz | not sure vponomaryov gets that reference | 17:20 |
| bswartz | vponomaryov do you watch american TV? | 17:20 |
| vponomaryov | bswartz: yes, I am aware about that TV series | 17:21 |
| vponomaryov | bswartz: but haven't watched it | 17:21 |
| vponomaryov | bswartz: we are watching various TV series in english as homework for english classes )) | 17:22 |
| ganso | vponomaryov: I suppose "Friends" is among those? | 17:23 |
| vponomaryov | ganso: damn right! | 17:23 |
| bswartz | friends is terrible! | 17:24 |
| bswartz | omg there's so much better TV out there | 17:24 |
| vponomaryov | bswartz: millions of fans disagree with you ) | 17:25 |
| vponomaryov | bswartz: army! of fans | 17:25 |
| ganso | vponomaryov: +1 | 17:28 |
| *** crushil has quit IRC | 17:31 | |
| *** dustins_ has joined #openstack-manila | 17:40 | |
| *** dustins has quit IRC | 17:43 | |
| tbarron | bswartz: looking at https://wiki.openstack.org/wiki/Manila/IPv6 - is generating the test image and its config drive obvious if I check out current manila-test-image repo? | 17:44 |
| bswartz | tbarron: one would hope yes | 17:44 |
| bswartz | tbarron: if it would save time I'll just send you a qcow2 file | 17:45 |
| *** dsariel has quit IRC | 17:45 | |
| tbarron | bswartz: nah, I'll build it and bug you if I hit an issue | 17:45 |
| bswartz | tbarron: the image is only 6.5 MB but building it requires downloading 315MB of stuff | 17:46 |
| tbarron | well, point me to the qcow2 and I'll also build it | 17:46 |
| bswartz | not to mention the OS packages you have to install | 17:46 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix snapshot export locations incorrectly handled https://review.openstack.org/427332 | 17:48 |
| *** gouthamr has quit IRC | 17:51 | |
| *** absubram has joined #openstack-manila | 17:52 | |
| bswartz | markstur: https://review.openstack.org/#/c/426775/ | 17:53 |
| *** catintheroof has joined #openstack-manila | 17:55 | |
| *** a-pugachev has quit IRC | 17:56 | |
| markstur | If we can't outlaw tabs, then maybe we could outlaw copy-paste. Just think of all the copy-paste errors that would be avoided and all the jobs created | 17:57 |
| *** crushil has joined #openstack-manila | 18:00 | |
| *** lpetrut has quit IRC | 18:02 | |
| *** timcl has quit IRC | 18:03 | |
| bswartz | markstur: that would kill 99% of programmers, not to mention stack overflow | 18:04 |
| bswartz | markstur: oh sorry I see what you're responding too | 18:05 |
| bswartz | markstur: I wanted you to look at the experimental job | 18:05 |
| bswartz | markstur: you wanted to see more testing and that job is step 1 for real tests | 18:05 |
| markstur | ok. when I can't copy/paste it is true that everything is super painful -- it was a copy/paste error that was mentioned | 18:06 |
| markstur | bswartz: I see. Success with the experimental build. Nice. | 18:06 |
| *** timcl has joined #openstack-manila | 18:06 | |
| * markstur quickly reads the 30M logged console | 18:07 | |
| bswartz | >_< | 18:07 |
| bswartz | yeah I want to break up that logfile a bit | 18:07 |
| *** gouthamr has joined #openstack-manila | 18:07 | |
| markstur | don't tell me how it ends. still scrolling. no spoilers! | 18:08 |
| bswartz | it ends with a poem | 18:08 |
| markstur | :) | 18:08 |
| bswartz | oh wait that's minecraft... | 18:08 |
| markstur | If you could just summarize that logflie in a haiku that would be a big time and space saver | 18:09 |
| bswartz | Another error. | 18:11 |
| bswartz | Hours of coding go by. | 18:11 |
| bswartz | Compile and repeat. | 18:11 |
| bswartz | (credit Emma M.) | 18:12 |
| bswartz | Skynet comes to life | 18:13 |
| bswartz | Robots overthrow humans | 18:13 |
| bswartz | Forgot the kill switch | 18:13 |
| markstur | s/error/success/ s/go by/go rewarded/ s/repeat/merge/ and you have your success haiku | 18:13 |
| bswartz | (credit Penelope B.) | 18:13 |
| *** lseki has joined #openstack-manila | 18:14 | |
| markstur | I'll be there for you... Yes, I'll be there for you, cuz You're there for me too... | 18:18 |
| markstur | ^ is that a haiku? | 18:19 |
| markstur | credit: internet re: haiku about friends tv show | 18:19 |
| bswartz | my favorite: | 18:22 |
| bswartz | No keyboard present | 18:22 |
| bswartz | Hit F1 to continue | 18:22 |
| bswartz | Zen engineering? | 18:22 |
| markstur | I like that one, but am bothered by the mixing of Zen and frustration | 18:23 |
| bswartz | it's like the sound of 1 hand clapping | 18:23 |
| markstur | Speaking of Zen I got a question about why our GPFS CI is failing | 18:25 |
| markstur | "openstack server add floating ip manila_service_share_server_london 172.24.5.4" | 18:25 |
| markstur | with error : Instance network is not ready yet (HTTP 400) | 18:25 |
| bswartz | markstur: same issue vponomaryov is struggling with | 18:26 |
| markstur | Yeah. Still stuggling? | 18:26 |
| markstur | I assumed he solved it | 18:26 |
| vponomaryov | markstur: no, see https://review.openstack.org/#/c/426737/ | 18:26 |
| markstur | Right on. "I'll be there for you" can be vponomaryov's theme song | 18:27 |
| vponomaryov | markstur: if you see this error, then something wrong with Nova config - 99% | 18:27 |
| vponomaryov | of probability | 18:27 |
| vponomaryov | config and/or setup | 18:28 |
| vponomaryov | markstur: just do the same trick in your case | 18:28 |
| vponomaryov | markstur: create any VMs and floating IPs in "test-config" section of devstack | 18:29 |
| vponomaryov | markstur: it means "run manila-share" service in this section too )) | 18:29 |
| bswartz | Yesterday it worked | 18:30 |
| bswartz | Today it is not working | 18:30 |
| bswartz | Devstack is like that | 18:30 |
| bswartz | ^ markstur | 18:30 |
| vponomaryov | markstur: it can be fixed in devstack, but I haven't planned to create fix there | 18:31 |
| vponomaryov | markstur: fix should be "move default nova cell creation to earlier step than it is now" | 18:32 |
| markstur | should your GenericShareDriver fixes in plugin.sh just apply to all drivers? to re-order for all? | 18:33 |
| markstur | vponomaryov: ^ just looking at that now | 18:33 |
| vponomaryov | markstur: no | 18:33 |
| vponomaryov | markstur: it should be done only for those backends which create Nova VMs and/or floating IPs in devstack | 18:34 |
| vponomaryov | markstur: otherwise it will be unexpected change of logic for lots of other backends | 18:35 |
| vponomaryov | markstur: that just do not care about this issue | 18:35 |
| *** lpetrut has joined #openstack-manila | 18:35 | |
| markstur | Not sure why GPFS would care to throw "openstack server add floating ip manila_service_share_server_london 172.24.5.4" | 18:36 |
| markstur | They already fixed the thing a while back to change where the config injection happened. Maybe that is broken again. | 18:36 |
| vponomaryov | markstur: can you run your CI on top of this fix? | 18:37 |
| vponomaryov | markstur: maybe in your case it is enough? | 18:37 |
| markstur | I was assuming it would run. But part of your fix is only for Generic | 18:38 |
| markstur | and I don't see any results. Wonder if they turned it off. | 18:38 |
| *** xyang_ has quit IRC | 18:39 | |
| *** xyang_ has joined #openstack-manila | 18:41 | |
| *** xyang_ has quit IRC | 18:42 | |
| *** xyang_ has joined #openstack-manila | 18:44 | |
| *** xyang_ has quit IRC | 18:45 | |
| *** xyang_ has joined #openstack-manila | 18:46 | |
| *** xyang_ has quit IRC | 18:47 | |
| tbarron | bswartz: i pretty much followed your wiki - that is | 19:06 |
| tbarron | bswartz: I used the local.conf you put in the pastebin, which is almost the same | 19:07 |
| tbarron | bswartz: didn't create backing files explicitly or set up hypervisor frontend/backend as you do it | 19:07 |
| tbarron | bswartz: just because i already have my hypervisor set up and integrated into my home/wan ipv6 network | 19:08 |
| tbarron | but I used the testing section literally | 19:08 |
| tbarron | bswartz: and it works | 19:08 |
| bswartz | tbarron: cool that backing file stuff is only for lvm | 19:09 |
| bswartz | I wrote that code forever ago -- perhaps it's unneeded these days | 19:09 |
| tbarron | bswartz: yeah, and I was just letting lvm plugin do that for me | 19:10 |
| bswartz | tbarron: does the lvm plugin cope well with multibackend? | 19:10 |
| tbarron | bswartz: not lvm plugin i guess, manila plugin with devstack localrcc | 19:10 |
| tbarron | bswartz: i'm going to try to mix your settings with the CI localrc a bit | 19:11 |
| bswartz | yeah we're talking about the LVM code in the manila devstack plugin | 19:11 |
| tbarron | bswartz: right | 19:11 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix multiple export locations during migration https://review.openstack.org/427360 | 19:11 |
| tbarron | so it makes backing files, etc I guess | 19:11 |
| bswartz | as long as it makes 2 of them | 19:11 |
| bswartz | and as long as they're large enough | 19:11 |
| bswartz | I ran into some issue where it used the same one twice or something | 19:11 |
| tbarron | bswartz: well, big enough for CI with two lvm backends ... | 19:12 |
| tbarron | bswartz: not saying it's big enough or not, just describing what I did | 19:12 |
| bswartz | anyways I'm glad it worked | 19:13 |
| tbarron | bswartz: my thought is to see (1) if I can adapt it a bit to use the devstack/CI "public" and "private" networks | 19:13 |
| bswartz | tbarron: I suspect you need neutron to fix that bug first | 19:13 |
| bswartz | I created my own networks largely to work around that bug | 19:13 |
| tbarron | bswartz: (2) out of curiosity, is there a way I can do tenant created network that uses GUAs from my allocation | 19:13 |
| tbarron | bswartz: which bug? | 19:14 |
| bswartz | tbarron absolutely | 19:14 |
| bswartz | tbarron the on you mentioned a few hours ago ^^^ | 19:14 |
| * bswartz travels back in time | 19:14 | |
| *** xinyanzhang has quit IRC | 19:14 | |
| tbarron | bswartz: oh, that's not neutron, that's openstackclient | 19:14 |
| *** xinyanzhang has joined #openstack-manila | 19:15 | |
| tbarron | bswartz: fixable just by using the git tree for openstackclient, it has been fixed in master but not yet in requirements, etc. | 19:15 |
| bswartz | (09:11:38 AM) tbarron: working with devstack locally I hit https://bugs.launchpad.net/python-openstackclient/+bug/1659878 b/c global requirements for openstackclient is still 3.8.0 | 19:15 |
| openstack | Launchpad bug 1659878 in python-openstackclient "Network creation ignores --project option" [High,Fix released] - Assigned to Dean Troyer (dtroyer) | 19:15 |
| tbarron | bswartz: presumably just a bit of latency | 19:15 |
| bswartz | ah okay | 19:15 |
| tbarron | bswartz: yeah, I wonder if I should push on gua for devstack ... | 19:15 |
| bswartz | tbarron: you can probably just do a LIBS_FROM_GIT trick there | 19:16 |
| tbarron | bswartz: yeah, that's what I'm doing | 19:16 |
| bswartz | what's the name of the lib I need to add? | 19:17 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix error'ed access rules being sent to driver https://review.openstack.org/426896 | 19:17 |
| *** kaisers has joined #openstack-manila | 19:17 | |
| tbarron | bswartz: python-openstackclient | 19:17 |
| bswartz | tbarron: ty I'll test with that | 19:18 |
| bswartz | presumably it will make the private network usable and I can trash demo-net | 19:19 |
| bswartz | tbarron in any case you want to set IPV6_ADDRS_SAFE_TO_USE to be a range in your allocated space | 19:19 |
| bswartz | assuming you have a /56, give openstack a /60 within that space | 19:20 |
| bswartz | that will give you up to 16 subnets which should be plenty for testing | 19:20 |
| tbarron | bswartz: ack | 19:20 |
| bswartz | tbarron: the routing outside of devstack is your problem to solve -- as you saw in my wiki I just hardcoded a route for fd10::/15 | 19:21 |
| *** kaisers has quit IRC | 19:21 | |
| tbarron | bswartz: I've done that myself for now | 19:22 |
| bswartz | and for those that don't know, the fc00::/7 is for private addresses you can do whatever you want with | 19:22 |
| bswartz | you just have to remember to set your firewall to drop those packets at the border of your network to avoid truly evil things occuring | 19:23 |
| tbarron | the tenant owned subnet that devstack sets up by default, named "private", looks like your demo-v6-subnet except | 19:23 |
| bswartz | tbarron: yes they both come from the same subnetpool | 19:24 |
| tbarron | ipv6_address_mode and ipv6_ra_mode are both "None" | 19:24 |
| bswartz | tbarron: add these 2 lines to local.conf: | 19:24 |
| bswartz | IPV6_RA_MODE=dhcpv6-stateful | 19:24 |
| bswartz | IPV6_ADDRESS_MODE=dhcpv6-stateful | 19:24 |
| * bswartz goes to update wiki | 19:25 | |
| tbarron | yeah, I thought I had those cause I copied your local.conf, but will have to double check | 19:25 |
| bswartz | oh wait those are in my local.conf | 19:25 |
| * bswartz scratches head | 19:25 | |
| tbarron | right, so I have to debug why those aren't getting set on the devstack created subnet | 19:26 |
| tbarron | I'm also a bit puzzled why slaac isn't working within the tenant owned net if we leave all the dhcp stuff out | 19:26 |
| tbarron | dhcp6 | 19:26 |
| bswartz | tbarron: devstack is riddled with ipv6 bugs | 19:27 |
| bswartz | tbarron: there are 4 choices: none, slaac, dhcp-stateless, and dhcp-stateful | 19:27 |
| bswartz | none != slaac | 19:27 |
| tbarron | bswartz: when I put a CentOS image on that network and run tcpdump I see RAs | 19:27 |
| tbarron | but the CentOS vm doesn't do the neighbor negotiation properly (though same image does fine outside openstack) | 19:28 |
| bswartz | tbarron is the A bit set to 0 or 1 in those router advertisements? | 19:29 |
| tbarron | bswartz: but for current purposes I'm happy to go with dhcp6, we're manila rather than neutron developers | 19:29 |
| bswartz | router advertisements can set the A bit to 0 which means disable slaac | 19:29 |
| tbarron | bswartz: I'll have to redo the experiment and check. I should have saved logs but everything was inside devstack VM and it was just a cow | 19:30 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix snapshot export locations incorrectly handled https://review.openstack.org/427332 | 19:31 |
| tbarron | bswartz: anyways, I like your test image, will play with it a bit in my spare time. | 19:31 |
| bswartz | tbarron I'm pretty sure teh difference between none and slaac in neutron is probably the value of that A bit in the router advertisements for that subnet | 19:31 |
| *** pcaruana has quit IRC | 19:31 | |
| tbarron | bswartz: sounds reasonable | 19:31 |
| *** crushil has quit IRC | 19:32 | |
| *** xyang_ has joined #openstack-manila | 19:35 | |
| *** xyang_ has quit IRC | 19:36 | |
| *** ociuhandu has joined #openstack-manila | 19:36 | |
| *** xyang_ has joined #openstack-manila | 19:47 | |
| *** xyang_ has quit IRC | 19:52 | |
| *** xyang_ has joined #openstack-manila | 19:54 | |
| *** ociuhandu has quit IRC | 19:56 | |
| *** gouthamr has quit IRC | 20:20 | |
| *** yumiriam has quit IRC | 20:24 | |
| *** mtanino_ has quit IRC | 20:25 | |
| bswartz | vponomaryov: any chance you're still around? | 20:28 |
| *** gouthamr has joined #openstack-manila | 20:29 | |
| *** xyang1 has joined #openstack-manila | 20:47 | |
| *** cdelatte has quit IRC | 20:51 | |
| *** jprovazn has quit IRC | 21:14 | |
| *** porrua has quit IRC | 21:17 | |
| *** xyang_ has quit IRC | 21:20 | |
| *** mtanino has joined #openstack-manila | 21:22 | |
| *** dustins_ has quit IRC | 21:31 | |
| *** crushil has joined #openstack-manila | 21:32 | |
| *** catintheroof has quit IRC | 21:38 | |
| *** catintheroof has joined #openstack-manila | 21:38 | |
| *** catintheroof has quit IRC | 21:39 | |
| *** rushil has joined #openstack-manila | 21:40 | |
| *** rushil has quit IRC | 21:46 | |
| *** alyson_ has quit IRC | 21:57 | |
| *** crushil has quit IRC | 22:04 | |
| *** catintheroof has joined #openstack-manila | 22:05 | |
| *** catintheroof has quit IRC | 22:05 | |
| *** catintheroof has joined #openstack-manila | 22:06 | |
| *** catintheroof has quit IRC | 22:11 | |
| *** Yogi1 has quit IRC | 22:11 | |
| *** ganso has quit IRC | 22:14 | |
| *** kaisers has joined #openstack-manila | 22:17 | |
| *** kaisers has quit IRC | 22:22 | |
| *** lpetrut has quit IRC | 22:39 | |
| *** eharney has quit IRC | 22:42 | |
| *** lseki has quit IRC | 23:00 | |
| *** xyang1 has quit IRC | 23:03 | |
| *** absubram has quit IRC | 23:27 | |
| *** gouthamr has quit IRC | 23:35 | |
| *** crushil has joined #openstack-manila | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!