*** crushil has quit IRC | 00:04 | |
*** crushil has joined #openstack-manila | 00:07 | |
openstackgerrit | Merged openstack/manila master: Disable share groups APIs by default https://review.openstack.org/428840 | 00:42 |
---|---|---|
*** tuanluong has joined #openstack-manila | 00:55 | |
bswartz | gouthamr: ping | 01:12 |
gouthamr | bswartz: pong | 01:16 |
bswartz | gouthamr: nm -- was going to ask you about wrapping insanely long python method names, but I found my answer | 01:16 |
gouthamr | bswartz: what's the answer? :P | 01:16 |
bswartz | get_and_update_share_instance_access_rule <-- evil | 01:16 |
bswartz | the answer is backslashes | 01:17 |
bswartz | but I found a better way | 01:17 |
* gouthamr remembers "create_share_from_snapshot_support" #neverforget | 01:17 | |
gouthamr | bswartz: reassigning? | 01:17 |
bswartz | gouthamr: you'll see when I push the patch | 01:18 |
gouthamr | haha.. okay :) | 01:18 |
bswartz | this should have been done earlier today but all my time got eaten by meetings #toomanymeetings | 01:18 |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 01:38 |
*** yankee has joined #openstack-manila | 01:49 | |
*** gcb has joined #openstack-manila | 02:12 | |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 02:33 |
*** ianychoi has quit IRC | 02:59 | |
*** ianychoi has joined #openstack-manila | 02:59 | |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 03:02 |
*** gouthamr has quit IRC | 03:26 | |
*** crushil has quit IRC | 04:39 | |
*** dsariel has quit IRC | 04:57 | |
*** bswartz has quit IRC | 05:08 | |
*** shausy has joined #openstack-manila | 05:21 | |
openstackgerrit | yankee proposed openstack/manila master: Allow use of <is> with extra_spec_value in share type https://review.openstack.org/413338 | 05:31 |
*** lpetrut has joined #openstack-manila | 05:54 | |
openstackgerrit | TommyLike proposed openstack/manila master: Enable IPv6 in manila(documentation) https://review.openstack.org/416870 | 06:21 |
*** nkrinner_afk is now known as nkrinner | 06:22 | |
openstackgerrit | Cao Xuan Hoang proposed openstack/manila master: Remove a py34 environment from tox https://review.openstack.org/430082 | 06:30 |
*** rraja has joined #openstack-manila | 06:43 | |
*** lpetrut has quit IRC | 06:46 | |
*** nkrinner is now known as nkrinner_afk | 07:08 | |
*** makowals has joined #openstack-manila | 07:18 | |
*** jprovazn has joined #openstack-manila | 07:20 | |
*** makowals_ has quit IRC | 07:21 | |
*** kaisers has joined #openstack-manila | 07:27 | |
*** nkrinner_afk is now known as nkrinner | 07:30 | |
*** dsariel has joined #openstack-manila | 07:31 | |
*** makowals has quit IRC | 07:34 | |
*** makowals has joined #openstack-manila | 07:44 | |
*** pcaruana has joined #openstack-manila | 07:46 | |
*** pcaruana has quit IRC | 07:48 | |
*** makowals has quit IRC | 07:51 | |
*** pcaruana has joined #openstack-manila | 07:55 | |
*** makowals has joined #openstack-manila | 08:03 | |
*** makowals has quit IRC | 08:13 | |
*** makowals has joined #openstack-manila | 08:15 | |
*** lpetrut has joined #openstack-manila | 08:32 | |
*** makowals has quit IRC | 08:42 | |
*** dgonzalez_ has joined #openstack-manila | 08:54 | |
*** sapcc-bot1 has joined #openstack-manila | 08:54 | |
*** databus23_1 has joined #openstack-manila | 08:54 | |
*** carthaca_1 has joined #openstack-manila | 08:54 | |
*** david_1 has joined #openstack-manila | 08:54 | |
*** mkoderer_ has joined #openstack-manila | 08:54 | |
*** databus23_ has quit IRC | 08:54 | |
*** sapcc-bot has quit IRC | 08:54 | |
*** carthaca_ has quit IRC | 08:54 | |
*** makowals has joined #openstack-manila | 08:55 | |
*** dgonzalez_ has quit IRC | 08:56 | |
*** makowals has quit IRC | 08:56 | |
*** mkoderer_ has quit IRC | 08:56 | |
*** david_1 has quit IRC | 08:56 | |
*** makowals has joined #openstack-manila | 09:12 | |
*** makowals has quit IRC | 09:15 | |
*** makowals has joined #openstack-manila | 09:17 | |
*** shausy has quit IRC | 09:46 | |
*** yumiriam has joined #openstack-manila | 09:47 | |
*** shausy has joined #openstack-manila | 09:48 | |
*** carthaca_1 has quit IRC | 10:07 | |
*** sapcc-bot1 has quit IRC | 10:07 | |
*** databus23_1 has quit IRC | 10:07 | |
*** sapcc-bot has joined #openstack-manila | 10:07 | |
*** databus23_ has joined #openstack-manila | 10:07 | |
*** carthaca_ has joined #openstack-manila | 10:07 | |
*** mkoderer_ has joined #openstack-manila | 10:07 | |
*** david_1 has joined #openstack-manila | 10:07 | |
*** dgonzalez_ has joined #openstack-manila | 10:07 | |
*** mkoderer_ has quit IRC | 10:09 | |
*** david_1 has quit IRC | 10:09 | |
*** dgonzalez_ has quit IRC | 10:09 | |
*** gaurangt_ has left #openstack-manila | 10:49 | |
*** gaurangt_ has joined #openstack-manila | 10:56 | |
*** gaurangt_ has quit IRC | 11:17 | |
*** gaurangt has joined #openstack-manila | 11:19 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: Fix default approach for share group snapshot creation https://review.openstack.org/427811 | 11:21 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: Add 'consistent_snapshot_support' attr to 'share_groups' DB model https://review.openstack.org/428748 | 11:23 |
*** makowals_ has joined #openstack-manila | 11:24 | |
*** test123 has joined #openstack-manila | 11:24 | |
*** gaurangt has quit IRC | 11:24 | |
*** makowals has quit IRC | 11:25 | |
openstackgerrit | Jan Provaznik proposed openstack/manila master: User Messages https://review.openstack.org/313549 | 11:26 |
*** gaurangt has joined #openstack-manila | 11:29 | |
*** test123 has left #openstack-manila | 11:30 | |
*** dsariel has quit IRC | 11:56 | |
*** tuanluong has quit IRC | 12:07 | |
openstackgerrit | Jan Provaznik proposed openstack/manila master: User Messages https://review.openstack.org/313549 | 12:08 |
*** porrua has joined #openstack-manila | 12:09 | |
openstackgerrit | Xuepeng Ji proposed openstack/python-manilaclient master: Replace six.iteritems() with .items() https://review.openstack.org/430229 | 12:32 |
*** gcb has quit IRC | 12:36 | |
*** gcb has joined #openstack-manila | 12:37 | |
*** alyson_ has joined #openstack-manila | 12:42 | |
*** sandanar has joined #openstack-manila | 12:43 | |
*** gcb has quit IRC | 12:45 | |
*** catintheroof has joined #openstack-manila | 12:50 | |
*** gcb has joined #openstack-manila | 12:53 | |
openstackgerrit | Alyson proposed openstack/manila master: HNAS: ensure snapshot before trying to revert https://review.openstack.org/430236 | 13:01 |
*** surabujin has quit IRC | 13:01 | |
*** gcb has quit IRC | 13:09 | |
*** dustins has joined #openstack-manila | 13:11 | |
*** chlong has joined #openstack-manila | 13:14 | |
*** dustins_ has joined #openstack-manila | 13:16 | |
*** dustins_ has quit IRC | 13:17 | |
*** dustins_ has joined #openstack-manila | 13:17 | |
*** bobothebear has joined #openstack-manila | 13:19 | |
*** dustins has quit IRC | 13:19 | |
*** dustins_ is now known as dustins | 13:38 | |
*** cdelatte has joined #openstack-manila | 13:43 | |
*** timcl has quit IRC | 13:44 | |
*** mtanino has quit IRC | 13:47 | |
*** bswartz has joined #openstack-manila | 13:50 | |
bswartz | ganso vponomaryov tbarron gouthamr: ping | 13:52 |
vponomaryov | bswartz: yes? | 13:52 |
bswartz | regarding https://review.openstack.org/#/c/428398 we only have about 3 hours to merge this or it has to get punted out of ocata | 13:52 |
bswartz | same applies to https://review.openstack.org/#/c/427811/ and https://review.openstack.org/#/c/428748/ | 13:53 |
vponomaryov | bswartz: even if we start merge now, it is very unlikely to fit time range of 3 hours | 13:57 |
bswartz | okay should I cut the milestone now then? | 13:57 |
vponomaryov | bswartz: I am talking about three changes in summary | 13:57 |
bswartz | I'll still have to push a patch to disable LVM revert | 13:58 |
vponomaryov | bswartz: https://review.openstack.org/#/c/427811/ is ready and valueable to have for case someone tries share groups | 13:58 |
bswartz | let's get it in then | 13:58 |
bswartz | I'm saying that waiting it no longer an option | 13:58 |
bswartz | these patches are in or out | 13:58 |
vponomaryov | and https://review.openstack.org/#/c/428748/ is ready too | 13:58 |
bswartz | vponomaryov: https://review.openstack.org/#/c/427811/ had a +2 from markstur 3 patchsets ago | 14:01 |
*** dsariel has joined #openstack-manila | 14:01 | |
*** shausy has quit IRC | 14:13 | |
*** breitz has joined #openstack-manila | 14:16 | |
*** breitz_ has quit IRC | 14:17 | |
bobothebear | Hi, I'm trying to install devstack (the mitaka branch) on CentOS 7.1503 and I'm getting "Failed building wheel for libvirt-python" | 14:25 |
tbarron | bswartz: i will review 428398 again when you push the next patch | 14:25 |
bobothebear | Before switching to Ubuntu, is this a known problem with a known fix? | 14:26 |
bswartz | tbarron: I will push another patch -- wanted to get a sense of which comments absolutely needed to be addressed for ocata | 14:27 |
bswartz | tbarron: some of your comments seemed advisory | 14:27 |
tbarron | bswartz: I'm not dug in but you should at least fix the api msg | 14:27 |
tbarron | bswartz: others than the PTL at rc1 deadline would be held to the standards expressed on the unit test remarks | 14:28 |
tbarron | bswartz: but I'm not trying to block a fix | 14:28 |
tbarron | bswartz: that we need right now | 14:29 |
tbarron | bswartz: and I think valeriy is right that you should avoid using mutable object as default, probably shouldn't merge with that. | 14:30 |
bswartz | tbarron: sure thing | 14:34 |
bswartz | tbarron: I'm not trying to hold myself to a lower standard, I'm just threatening to kick myself out of ocata | 14:35 |
bswartz | tbarron: which is a weird position to be in | 14:35 |
tbarron | bswartz: oh I know :D | 14:35 |
tbarron | bswartz: I'd really like to get this feature in though, it's a carryover from newton | 14:35 |
tbarron | bswartz: so if you fix the mutable object and the api msg I think we could merge and raise a bug for the tech debt on e.g. the bad api signature from rpcapi into the manager (which you didn't introduced with your fix anyways) | 14:37 |
*** ganso has joined #openstack-manila | 14:37 | |
bswartz | tbarron: yeah I'll fix those 2 and the reno as well | 14:37 |
bswartz | tbarron: I'd like someone to explain to me exactly why mutable objects as default values are a Bad Thing | 14:38 |
bswartz | tbarron: does CPython have buggy behavior when you do that? | 14:38 |
tbarron | bswartz: http://docs.python-guide.org/en/latest/writing/gotchas/ | 14:39 |
tbarron | "arguably language warts" ... | 14:40 |
bswartz | tbarron: that's horrifying | 14:40 |
tbarron | bswartz: :-) | 14:42 |
*** cdelatte has quit IRC | 14:43 | |
*** gouthamr has joined #openstack-manila | 14:47 | |
*** mtanino has joined #openstack-manila | 14:54 | |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 14:58 |
bswartz | crap | 14:59 |
vponomaryov | tbarron: thanks, was going to provide such a link too ) | 14:59 |
bswartz | ^ that patchset has a problem | 15:01 |
tbarron | vponomaryov: yeah, unfortunately I forget and do it myself | 15:01 |
*** eharney has joined #openstack-manila | 15:01 | |
vponomaryov | ganso: share groups tests are disabled now | 15:02 |
ganso | vponomaryov: the patch that disables it have merged? | 15:03 |
vponomaryov | ganso: yes | 15:03 |
ganso | vponomaryov: :\ | 15:03 |
ganso | vponomaryov: can I forcefully enable them? | 15:03 |
vponomaryov | just create test commit above this one | 15:03 |
*** crushil has joined #openstack-manila | 15:03 | |
ganso | vponomaryov: export RUN_MANILA_CG_TESTS=True ? | 15:03 |
vponomaryov | oh, i need to rebase it then | 15:03 |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 15:04 |
vponomaryov | ganso: you need "revert" | 15:04 |
vponomaryov | ganso: policy.json was changed | 15:04 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: Fix default approach for share group snapshot creation https://review.openstack.org/427811 | 15:04 |
ganso | vponomaryov: ok | 15:04 |
vponomaryov | ganso: rebased to latest master | 15:04 |
vponomaryov | ganso: now you can revert changes in dependent test commit | 15:05 |
vponomaryov | I wasnted to create such one too | 15:05 |
vponomaryov | s/wasnted/wanted/ | 15:06 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: [DNM] Revert "Disable share groups APIs by default" https://review.openstack.org/430293 | 15:07 |
bswartz | okay https://review.openstack.org/428398 looks like it's better now <--- vponomaryov, tbarron | 15:07 |
tbarron | bswartz: looking | 15:07 |
bswartz | running unit tests one more time in case the rebase screwed something up | 15:07 |
*** bobothebear has quit IRC | 15:08 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [DNM] test share groups https://review.openstack.org/430296 | 15:08 |
vponomaryov | ganso: ^ | 15:08 |
vponomaryov | bswartz: looking | 15:08 |
ganso | vponomaryov: I had just done that ^ | 15:09 |
vponomaryov | ganso: I do not remove releasenote ^_^ | 15:09 |
ganso | vponomaryov: it is a test patch... | 15:09 |
ganso | vponomaryov: why would you care about the reno being removed? | 15:10 |
vponomaryov | ganso: redundant thing, no need to mix it in | 15:10 |
ganso | vponomaryov: it is going to be abandoned anyway | 15:10 |
vponomaryov | bswartz: https://review.openstack.org/#/c/428398/9..11/manila/share/manager.py ? | 15:16 |
vponomaryov | bswartz: missed comments? | 15:16 |
bswartz | vponomaryov: I skipped that comment on purpose because it didn't seem like a correctness issue | 15:21 |
bswartz | tbarron: you first comment on that file seems worth fixing | 15:21 |
*** gouthamr has quit IRC | 15:22 | |
tbarron | bswartz: well, I think they are both worth fixing :D | 15:22 |
bswartz | the second one might have unit test impact | 15:22 |
bswartz | tbarron: I'll try it out | 15:22 |
tbarron | bswartz: the second is quite confusing | 15:22 |
bswartz | tbarron: I was confused when I wrote it, if that explains anything | 15:22 |
tbarron | we are just carrying tech debt forward from the original instances implementation | 15:23 |
tbarron | i always have to look at the model to see if it is correct ... | 15:23 |
tbarron | and then I swear at at guy who is no longer working on manila | 15:23 |
bswartz | u_glide? | 15:24 |
tbarron | bswartz: yeah, and probably he was just getting stuff done for feature freeze or rc deadlines ... | 15:24 |
tbarron | and I would have said "sure, go ahead, we'll deal with it later." | 15:25 |
bswartz | IIRC u_glide was relatively new to the project at the time | 15:25 |
bswartz | maybe he didn't have the experience to know better | 15:25 |
bswartz | tbarron: there is unit tests impact so give me a second to fix the test | 15:28 |
tbarron | bswartz: sure thing | 15:28 |
*** gouthamr has joined #openstack-manila | 15:29 | |
tbarron | yeah our unit tests use fake objects that have instance properties in shares and vice versa | 15:29 |
*** gouthamr has quit IRC | 15:30 | |
*** xyang_ has joined #openstack-manila | 15:32 | |
ganso | bswartz: reviewing your patch now | 15:34 |
ganso | bswartz: so the reason for the funky behavior was the mutable parameters? | 15:34 |
bswartz | ganso: that's possible | 15:34 |
bswartz | ganso: those mutable parameters would have caused some bug eventually if not the bug I'm seeing | 15:36 |
ganso | bswartz: are you still seeing? | 15:36 |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 15:36 |
bswartz | tbarron: ^ check this one | 15:36 |
tbarron | bswartz: k | 15:36 |
bswartz | ganso: haven't tried tempest tests since making that change | 15:37 |
bswartz | vponmaryov: regaring the "disruption" caused during revert to snapshot, I think that it will be fairly common for mounts to become stale after a revert on many backends | 15:40 |
*** cdelatte has joined #openstack-manila | 15:40 | |
tbarron | is it just my net or is gerrit being really slow to respond | 15:40 |
bswartz | tbarron: can it be both? | 15:40 |
tbarron | bswartz: yes, we are very inclusive | 15:40 |
bswartz | tbarron: gerrit isn't too bad for me | 15:40 |
bswartz | not at the moment | 15:40 |
tbarron | maybe I'll fetch to a server in the office instead then | 15:41 |
*** jprovazn has quit IRC | 15:41 | |
ganso | bswartz: added a couple of comments | 15:41 |
ganso | bswartz: they are in PS #11 | 15:41 |
bswartz | ganso: the commit message bug format is highly flexible | 15:45 |
bswartz | ganso: hashtags are not needed for bugs | 15:45 |
ganso | bswartz: hummm thought they were needed | 15:45 |
ganso | bswartz: is Yogesh around? | 15:47 |
bswartz | ganso: in meeting until 1600 UTC | 15:47 |
ganso | bswartz: ok, thanks | 15:47 |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 15:48 |
bswartz | ganso: ^ this what you intended? | 15:48 |
ganso | bswartz: yes | 15:48 |
ganso | bswartz: thanks | 15:49 |
bswartz | we need another +2 on https://review.openstack.org/#/c/427811/ | 15:50 |
bswartz | markstur had +2'd it a few patchsets ago | 15:50 |
bswartz | markstur: you awake yet? | 15:50 |
*** sandanar has quit IRC | 15:56 | |
*** lpetrut has quit IRC | 15:56 | |
bswartz | markstur: I ninja merged on your behalf -- apologies if there was anything you objected to in recent patchsets | 16:00 |
bswartz | omfg I fail pep8 | 16:01 |
bswartz | every time I run the checker it finds nothing -- when I don't run it it finds something | 16:02 |
* bswartz sighs | 16:04 | |
markstur | bswartz: I'm here now. | 16:06 |
bswartz | markstur: pls take a look at ^ and if you see antyhing you don't like there's time to pull it out of the gate | 16:06 |
markstur | OK | 16:06 |
bswartz | ganso: my patch still fails tempest | 16:07 |
bswartz | not running tests before pushing is really biting me today | 16:08 |
openstackgerrit | Alyson proposed openstack/manila master: HNAS: ensure snapshot before trying to revert https://review.openstack.org/430236 | 16:09 |
ganso | bswartz: was waiting for my CI to run that patch :( | 16:10 |
ganso | bswartz: it is supposed to fix a crash in my driver | 16:10 |
bswartz | ganso, tbarron: the problem is the RPC API broke when I removed share_id=None from the manager | 16:11 |
bswartz | so rather than clean up the whole RPC layer to remove that unused parameter I'm going to just add it back in and let it be ignored | 16:11 |
tbarron | bswartz: yeah, makes sense. maybe just make a bug and put a #todo and put it back | 16:11 |
tbarron | bswartz: I can clean it up post-ocata | 16:12 |
ganso | bswartz: ok | 16:12 |
*** cdelatte has quit IRC | 16:12 | |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 16:15 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Add Share Migration devref docs https://review.openstack.org/375771 | 16:15 |
*** pcaruana has quit IRC | 16:17 | |
*** jcsp has joined #openstack-manila | 16:20 | |
markstur | Any objections to the remove py34 patch??? https://review.openstack.org/#/c/430082/1' | 16:28 |
vponomaryov | markstur: we do not run py34 tests anymore | 16:30 |
vponomaryov | markstur: none, at all | 16:30 |
vponomaryov | markstur: so, at least for this reason we should remove it | 16:30 |
markstur | vponomaryov: So you'd like to add py34 tests back in Valeriy. Maybe 31 also? | 16:31 |
markstur | poke ;) | 16:31 |
vponomaryov | markstur: no, why I should want to do it? ) | 16:32 |
markstur | For nostalgia and the challenge of maintenance | 16:32 |
ganso | vponomaryov: we wouldn't be surprised if you did | 16:32 |
markstur | OK. Just don't need to rush that patch today -- but I think it's good to get it. #24waiver | 16:33 |
markstur | That's #24h-waiver | 16:33 |
*** nkrinner is now known as nkrinner_afk | 16:33 | |
vponomaryov | markstur: you want to us to believe that you follow rules? ) | 16:34 |
vponomaryov | s/to us/us/ | 16:34 |
markstur | I always follow the rules! Or claim I didn't know them. | 16:34 |
vponomaryov | yeas, right | 16:35 |
*** lpetrut has joined #openstack-manila | 16:35 | |
*** openstackgerrit has quit IRC | 16:35 | |
markstur | #not-my-24h-rule (or do it as a form of protest) :) | 16:36 |
*** openstackgerrit has joined #openstack-manila | 16:36 | |
openstackgerrit | Gábor Antal proposed openstack/python-manilaclient master: Handle log message interpolation by the logger https://review.openstack.org/430348 | 16:36 |
*** jprovazn_bbl has joined #openstack-manila | 16:47 | |
bswartz | okay the LVM revert patch passes all my tests on my system | 16:48 |
*** cdelatte has joined #openstack-manila | 16:49 | |
bswartz | jenkins should be done chewing on it in about 35 minutes | 16:49 |
*** lpetrut has quit IRC | 16:56 | |
*** xyang_ has quit IRC | 17:00 | |
*** eharney_ has joined #openstack-manila | 17:01 | |
*** eharney has quit IRC | 17:03 | |
*** eharney_ is now known as eharney | 17:03 | |
markstur | my mouse battery died and I just found out that if my arm rests on my wireless keyboard arrow key while I reach for my mac trackpad the -2,-1,0,+1,+2 button selection goes round and round like a roulette wheel | 17:05 |
markstur | gotta be real quick to hit the right one | 17:05 |
*** dsariel has quit IRC | 17:08 | |
*** lpetrut has joined #openstack-manila | 17:08 | |
openstackgerrit | Merged openstack/manila master: Fix default approach for share group snapshot creation https://review.openstack.org/427811 | 17:13 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: Add 'consistent_snapshot_support' attr to 'share_groups' DB model https://review.openstack.org/428748 | 17:14 |
*** xyang_ has joined #openstack-manila | 17:15 | |
*** breitz has quit IRC | 17:15 | |
*** xyang_ has quit IRC | 17:16 | |
ganso | vponomaryov: it passed | 17:24 |
vponomaryov | ganso: it merged | 17:24 |
ganso | vponomaryov: I saw, that's why I am glad it passed | 17:25 |
vponomaryov | ganso; you do not trust me? | 17:25 |
ganso | vponomaryov: I trust my CI more | 17:25 |
*** xyang_ has joined #openstack-manila | 17:30 | |
*** xyang_ has quit IRC | 17:32 | |
*** kaisers has quit IRC | 17:33 | |
*** kaisers has joined #openstack-manila | 17:37 | |
bswartz | hey guys what are we waiting for? https://review.openstack.org/#/c/428398 <-- tbarron ganso vponomaryov | 17:37 |
tbarron | vponomaryov: you ok with https://review.openstack.org/#/c/428398/ ? The failed nv jobs are timeouts (long migration) | 17:37 |
tbarron | bswartz: yeah, I was eating. | 17:37 |
* bswartz was eating too | 17:37 | |
bswartz | just back from lunch and relieved that Jenkins is not being obstructionist | 17:38 |
* markstur just assumed those guys were making bswartz sweat for the fun of it | 17:38 | |
bswartz | lol | 17:38 |
bswartz | markstur: you were asleep when I brought it up, but the release team is pissed at us for being the last team to make RC1 | 17:38 |
markstur | Sure | 17:39 |
tbarron | bswartz: go talk to dims and dhellman in infra now :) | 17:39 |
markstur | but we did find out that the gate is much friendlier when you are the last one. It was worse last week. :) | 17:39 |
* tbarron means #openstack-release | 17:40 | |
bswartz | tbarron: I'm in every channel | 17:42 |
* bswartz sees all | 17:42 | |
*** AJaeger has joined #openstack-manila | 17:48 | |
AJaeger | bswartz: could you review these two backports, please? https://review.openstack.org/429035 and https://review.openstack.org/429034 | 17:48 |
*** Yogi1 has joined #openstack-manila | 17:55 | |
*** xyang_ has joined #openstack-manila | 17:58 | |
*** xyang_ has quit IRC | 17:59 | |
*** gouthamr has joined #openstack-manila | 18:01 | |
gouthamr | bswartz: this: https://review.openstack.org/#/c/425904/ and https://review.openstack.org/#/c/425907/ | 18:05 |
gouthamr | bswartz: i can't figure out why the o/p has only http://docs-draft.openstack.org/07/425907/1/check/gate-manila-ui-releasenotes/9daa954//releasenotes/build/html/ocata.html | 18:05 |
gouthamr | bswartz: or http://docs-draft.openstack.org/04/425904/1/check/gate-python-manilaclient-releasenotes/1747aa5//releasenotes/build/html/ocata.html | 18:06 |
bswartz | gouthamr: might be because of the commit I made to the releases repo | 18:06 |
gouthamr | bswartz: i looked at that, it was the correct commit.. | 18:06 |
bswartz | gouthamr: can you point to another library that *doesn't* have this problem so I can make sure to see how they got a good result? | 18:06 |
gouthamr | bswartz: i tried cinderclient and they have the same issue: http://docs.openstack.org/releasenotes/python-cinderclient/ocata.html | 18:07 |
bswartz | gouthamr: at that proves is that smcginnis made the same mistake I did or there's a bug in the core of reno | 18:08 |
AJaeger | gouthamr, bswartz, best ask dhellmann in #openstack-release. We merged a couple of bug fixes for reno | 18:08 |
AJaeger | the merge was yesterday and no release so soon yet. | 18:08 |
gouthamr | AJaeger: ah.. nice point.. | 18:08 |
bswartz | yeah I would be completely unsuprised to hear that renos are in flux until the official ocata release | 18:10 |
bswartz | as long as manila is no worse off than other projects I won't be worried about it | 18:10 |
AJaeger | it shouldn't be in flux - but bugs were found and fixed ;) | 18:10 |
*** wiebalck has joined #openstack-manila | 18:10 | |
AJaeger | bswartz: ask dhellmann, he will now. Or test locally and use the reno HEAD for verification | 18:10 |
*** jprovazn_bbl has quit IRC | 18:13 | |
*** faizy has joined #openstack-manila | 18:22 | |
openstackgerrit | Merged openstack/manila master: Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 18:31 |
*** gouthamr has quit IRC | 18:35 | |
*** xyang_ has joined #openstack-manila | 18:36 | |
*** jcsp has quit IRC | 18:42 | |
*** xyang_ has quit IRC | 18:43 | |
*** xyang_ has joined #openstack-manila | 18:45 | |
*** yumiriam has quit IRC | 19:01 | |
*** ociuhandu has joined #openstack-manila | 19:03 | |
*** xyang_ has quit IRC | 19:07 | |
*** xyang_ has joined #openstack-manila | 19:08 | |
*** faizy has quit IRC | 19:16 | |
openstackgerrit | Merged openstack/manila master: Add 'consistent_snapshot_support' attr to 'share_groups' DB model https://review.openstack.org/428748 | 19:28 |
*** ChanServ changes topic to "OpenStack Shared File Systems | Manila | Ocata RC1 is complete!" | 19:38 | |
markstur | woot | 19:40 |
*** gouthamr has joined #openstack-manila | 19:41 | |
*** gouthamr has quit IRC | 19:41 | |
* bswartz limps across the finish line | 19:43 | |
bswartz | last place! | 19:43 |
markstur | participation award trophies all around | 19:43 |
*** breitz has joined #openstack-manila | 19:44 | |
rhagarty | vponomaryov: do you know if there is an issue with the share-group-create api related to availability_zones? I get error "ERROR: The fields set([u'availability_zone']) are invalid." | 19:48 |
openstackgerrit | OpenStack Release Bot proposed openstack/manila master: Update reno for stable/ocata https://review.openstack.org/430424 | 19:56 |
*** dustins has quit IRC | 20:00 | |
*** porrua has quit IRC | 20:28 | |
AJaeger | bswartz: could you review https://review.openstack.org/#/c/429034/ as well,please? That's the final backport. | 20:32 |
bswartz | AJaeger: was waiting for newton flavor to merge | 20:34 |
AJaeger | bswartz: I see - it's in now. | 20:36 |
AJaeger | thanks! | 20:40 |
*** AJaeger has left #openstack-manila | 20:40 | |
*** rraja has quit IRC | 20:43 | |
*** ChanServ changes topic to "OpenStack Shared File Systems | Manila | Ocata RC1 is complete | master branch is now "Pike"" | 20:50 | |
*** crushil has quit IRC | 20:58 | |
*** alyson_ has quit IRC | 21:07 | |
*** harlowja has quit IRC | 21:09 | |
*** crushil has joined #openstack-manila | 21:14 | |
*** gouthamr has joined #openstack-manila | 21:21 | |
*** delattec has joined #openstack-manila | 21:25 | |
*** cdelatte has quit IRC | 21:26 | |
*** harlowja has joined #openstack-manila | 21:35 | |
*** wiebalck has quit IRC | 21:37 | |
*** Yogi1 has quit IRC | 21:39 | |
*** gouthamr has quit IRC | 21:45 | |
*** catintheroof has quit IRC | 21:48 | |
*** catintheroof has joined #openstack-manila | 21:49 | |
*** catintheroof has quit IRC | 21:54 | |
*** ganso has quit IRC | 22:04 | |
*** dsariel has joined #openstack-manila | 22:32 | |
*** dustins has joined #openstack-manila | 22:35 | |
*** xyang_ has quit IRC | 22:36 | |
*** yankee_ has joined #openstack-manila | 22:38 | |
*** xyang_ has joined #openstack-manila | 22:39 | |
*** xyang_ has quit IRC | 22:40 | |
*** xyang_ has joined #openstack-manila | 22:41 | |
*** xyang_ has quit IRC | 22:42 | |
*** gouthamr has joined #openstack-manila | 22:45 | |
*** eharney has quit IRC | 22:51 | |
*** dustins has quit IRC | 22:58 | |
*** lpetrut has quit IRC | 23:07 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!