*** xyang1 has quit IRC | 00:19 | |
*** hongbin has quit IRC | 00:43 | |
*** hoonetorg has quit IRC | 01:02 | |
*** tommylikehu1_ has quit IRC | 01:10 | |
*** markstur has quit IRC | 01:15 | |
*** kaisers has joined #openstack-manila | 01:26 | |
openstackgerrit | Emilien Macchi proposed openstack/manila master: Add sem-ver flag so pbr generates correct version https://review.openstack.org/453405 | 01:27 |
---|---|---|
*** kaisers_ has quit IRC | 01:29 | |
openstackgerrit | Emilien Macchi proposed openstack/manila master: Add sem-ver flag so pbr generates correct version https://review.openstack.org/453421 | 01:33 |
*** markstur has joined #openstack-manila | 01:36 | |
*** markstur has quit IRC | 01:41 | |
*** markstur has joined #openstack-manila | 01:57 | |
*** gcb has joined #openstack-manila | 02:01 | |
*** markstur has quit IRC | 02:01 | |
*** mtanino has joined #openstack-manila | 02:07 | |
zhongjun_ | tbarron: ping | 02:29 |
*** gouthamr has quit IRC | 02:49 | |
*** rraja has joined #openstack-manila | 03:23 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Add spec for ensure share https://review.openstack.org/446494 | 03:35 |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Add spec for infinite share https://review.openstack.org/452097 | 03:43 |
*** markstur has joined #openstack-manila | 03:47 | |
*** rraja has quit IRC | 03:49 | |
*** markstur has quit IRC | 03:51 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Add spec for infinite share https://review.openstack.org/452097 | 03:57 |
*** mtanino has quit IRC | 04:05 | |
*** tinwood has quit IRC | 04:10 | |
*** tinwood has joined #openstack-manila | 04:11 | |
*** markstur has joined #openstack-manila | 04:28 | |
*** markstur has quit IRC | 04:33 | |
*** chlong has quit IRC | 04:49 | |
*** nkrinner_afk is now known as nkrinner | 05:07 | |
*** kaisers has quit IRC | 05:15 | |
*** kaisers has joined #openstack-manila | 05:28 | |
*** hoonetorg has joined #openstack-manila | 05:33 | |
*** kaisers has quit IRC | 05:42 | |
*** kaisers has joined #openstack-manila | 05:46 | |
*** pcaruana has joined #openstack-manila | 06:08 | |
*** kaisers has quit IRC | 06:14 | |
*** dsariel has joined #openstack-manila | 06:19 | |
*** hoonetorg has quit IRC | 06:29 | |
*** jprovazn has joined #openstack-manila | 06:32 | |
*** sticker has quit IRC | 06:37 | |
*** markstur has joined #openstack-manila | 06:39 | |
*** hoonetorg has joined #openstack-manila | 06:42 | |
*** markstur has quit IRC | 06:44 | |
*** rraja has joined #openstack-manila | 07:01 | |
*** kaisers has joined #openstack-manila | 07:09 | |
*** markstur has joined #openstack-manila | 07:20 | |
*** markstur has quit IRC | 07:25 | |
*** gcb has quit IRC | 08:07 | |
*** gcb has joined #openstack-manila | 08:19 | |
*** sapcc-bot has joined #openstack-manila | 08:21 | |
*** david_1 has joined #openstack-manila | 08:21 | |
*** carthaca_ has joined #openstack-manila | 08:21 | |
*** dgonzalez_ has joined #openstack-manila | 08:21 | |
*** tpatzig_ has joined #openstack-manila | 08:21 | |
*** mkoderer_ has joined #openstack-manila | 08:21 | |
*** seife_ has joined #openstack-manila | 08:21 | |
*** databus23_ has joined #openstack-manila | 08:21 | |
*** dgonzalez_ has quit IRC | 08:21 | |
*** david_1 has quit IRC | 08:21 | |
*** carthaca_ has quit IRC | 08:21 | |
*** tpatzig_ has quit IRC | 08:21 | |
*** databus23_ has quit IRC | 08:21 | |
*** sapcc-bot has quit IRC | 08:21 | |
*** mkoderer_ has quit IRC | 08:21 | |
*** seife_ has quit IRC | 08:21 | |
*** david_1 has joined #openstack-manila | 08:22 | |
*** sapcc-bot has joined #openstack-manila | 08:22 | |
*** carthaca_ has joined #openstack-manila | 08:22 | |
*** tpatzig_ has joined #openstack-manila | 08:22 | |
*** databus23_ has joined #openstack-manila | 08:22 | |
*** seife_ has joined #openstack-manila | 08:22 | |
*** mkoderer_ has joined #openstack-manila | 08:22 | |
*** dgonzalez_ has joined #openstack-manila | 08:22 | |
*** sapcc-bot has quit IRC | 08:22 | |
*** carthaca_ has quit IRC | 08:22 | |
*** dgonzalez_ has quit IRC | 08:22 | |
*** mkoderer_ has quit IRC | 08:22 | |
*** david_1 has quit IRC | 08:22 | |
*** tpatzig_ has quit IRC | 08:22 | |
*** databus23_ has quit IRC | 08:22 | |
*** seife_ has quit IRC | 08:22 | |
*** david_2 has joined #openstack-manila | 08:23 | |
*** seife_ has joined #openstack-manila | 08:23 | |
*** carthaca_ has joined #openstack-manila | 08:23 | |
*** dgonzalez_ has joined #openstack-manila | 08:23 | |
*** databus23_ has joined #openstack-manila | 08:23 | |
*** tpatzig_ has joined #openstack-manila | 08:23 | |
*** mkoderer_ has joined #openstack-manila | 08:23 | |
*** sapcc-bot has joined #openstack-manila | 08:23 | |
*** databus23_ has quit IRC | 08:23 | |
*** mkoderer_ has quit IRC | 08:23 | |
*** carthaca_ has quit IRC | 08:23 | |
*** seife_ has quit IRC | 08:23 | |
*** david_2 has quit IRC | 08:23 | |
*** sapcc-bot has quit IRC | 08:23 | |
*** dgonzalez_ has quit IRC | 08:23 | |
*** tpatzig_ has quit IRC | 08:23 | |
*** david_1 has joined #openstack-manila | 08:23 | |
*** sapcc-bot has joined #openstack-manila | 08:23 | |
*** tpatzig_ has joined #openstack-manila | 08:23 | |
*** dgonzalez_ has joined #openstack-manila | 08:23 | |
*** carthaca_ has joined #openstack-manila | 08:23 | |
*** mkoderer_ has joined #openstack-manila | 08:23 | |
*** seife_ has joined #openstack-manila | 08:23 | |
*** databus23_ has joined #openstack-manila | 08:23 | |
*** ianychoi has quit IRC | 08:24 | |
*** ianychoi has joined #openstack-manila | 08:25 | |
*** databus23_ has quit IRC | 08:25 | |
*** seife_ has quit IRC | 08:25 | |
*** mkoderer_ has quit IRC | 08:25 | |
*** tpatzig_ has quit IRC | 08:25 | |
*** dgonzalez_ has quit IRC | 08:25 | |
*** carthaca_ has quit IRC | 08:25 | |
*** david_1 has quit IRC | 08:25 | |
*** sapcc-bot has quit IRC | 08:32 | |
*** sapcc-bot has joined #openstack-manila | 08:32 | |
*** tpatzig_ has joined #openstack-manila | 08:32 | |
*** dgonzalez_ has joined #openstack-manila | 08:32 | |
*** mkoderer_ has joined #openstack-manila | 08:32 | |
*** carthaca_ has joined #openstack-manila | 08:32 | |
*** seife_ has joined #openstack-manila | 08:32 | |
*** databus23_ has joined #openstack-manila | 08:32 | |
*** david_1 has joined #openstack-manila | 08:32 | |
*** databus23_ has quit IRC | 08:34 | |
*** seife_ has quit IRC | 08:34 | |
*** mkoderer_ has quit IRC | 08:34 | |
*** carthaca_ has quit IRC | 08:34 | |
*** dgonzalez_ has quit IRC | 08:34 | |
*** tpatzig_ has quit IRC | 08:34 | |
*** david_1 has quit IRC | 08:34 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Use 'LIKE' operator to filter resource at some columns https://review.openstack.org/447775 | 08:57 |
*** sapcc-bot has quit IRC | 09:05 | |
*** mkoderer_ has joined #openstack-manila | 09:05 | |
*** databus23_ has joined #openstack-manila | 09:05 | |
*** tpatzig_ has joined #openstack-manila | 09:05 | |
*** seife_ has joined #openstack-manila | 09:05 | |
*** sapcc-bot has joined #openstack-manila | 09:05 | |
*** carthaca_ has joined #openstack-manila | 09:05 | |
*** dgonzalez_ has joined #openstack-manila | 09:05 | |
*** david_1 has joined #openstack-manila | 09:05 | |
*** databus23_ has quit IRC | 09:06 | |
*** seife_ has quit IRC | 09:06 | |
*** dgonzalez_ has quit IRC | 09:06 | |
*** carthaca_ has quit IRC | 09:06 | |
*** tpatzig_ has quit IRC | 09:06 | |
*** mkoderer_ has quit IRC | 09:06 | |
*** sapcc-bot has quit IRC | 09:06 | |
*** david_1 has quit IRC | 09:06 | |
*** sapcc-bot has joined #openstack-manila | 09:07 | |
*** lpetrut has joined #openstack-manila | 09:07 | |
*** lpetrut has quit IRC | 09:08 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Filter things out providing flexible way to API https://review.openstack.org/447775 | 09:09 |
*** kaisers has quit IRC | 09:24 | |
*** nkrinner has quit IRC | 09:56 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Enhance update shares https://review.openstack.org/453553 | 09:57 |
openstackgerrit | yfzhao proposed openstack/manila master: Replace six.iteritems() with .items() https://review.openstack.org/451882 | 10:01 |
openstackgerrit | Colleen Murphy proposed openstack/manila master: Fix important:: directive display in install guide https://review.openstack.org/453189 | 10:07 |
*** kaisers has joined #openstack-manila | 10:20 | |
*** pcaruana|afk| has joined #openstack-manila | 10:21 | |
*** pcaruana|afk| has quit IRC | 10:23 | |
*** pcaruana has quit IRC | 10:24 | |
*** pcaruana has joined #openstack-manila | 10:25 | |
*** ganso has joined #openstack-manila | 10:46 | |
*** kaisers has quit IRC | 10:53 | |
*** sapcc-bot has quit IRC | 10:53 | |
*** sapcc-bot has joined #openstack-manila | 10:54 | |
*** david_1 has joined #openstack-manila | 10:55 | |
*** dgonzalez_ has joined #openstack-manila | 10:55 | |
*** mkoderer_ has joined #openstack-manila | 10:55 | |
*** databus23_ has joined #openstack-manila | 10:55 | |
*** carthaca_ has joined #openstack-manila | 10:55 | |
*** gcb has quit IRC | 10:57 | |
*** databus23_ has quit IRC | 10:57 | |
*** mkoderer_ has quit IRC | 10:57 | |
*** dgonzalez_ has quit IRC | 10:57 | |
*** david_1 has quit IRC | 10:57 | |
openstackgerrit | Merged openstack/manila-specs master: Retarget IPv6 to Pike https://review.openstack.org/446800 | 11:14 |
*** tommylikehu_ has joined #openstack-manila | 11:20 | |
*** tommylikehu_ has quit IRC | 11:24 | |
*** sapcc-bot1 has joined #openstack-manila | 11:41 | |
*** carthaca_ has quit IRC | 11:41 | |
*** sapcc-bot has quit IRC | 11:41 | |
*** carthaca_ has joined #openstack-manila | 11:41 | |
*** dgonzalez_ has joined #openstack-manila | 11:41 | |
*** seife_ has joined #openstack-manila | 11:41 | |
*** databus23_ has joined #openstack-manila | 11:41 | |
*** mkoderer_ has joined #openstack-manila | 11:41 | |
*** david_1 has joined #openstack-manila | 11:41 | |
*** david_2 has joined #openstack-manila | 11:42 | |
*** databus23_1 has joined #openstack-manila | 11:42 | |
*** seife_1 has joined #openstack-manila | 11:42 | |
*** mkoderer_1 has joined #openstack-manila | 11:42 | |
*** dgonzalez_1 has joined #openstack-manila | 11:42 | |
*** carthaca_1 has joined #openstack-manila | 11:42 | |
*** sapcc-bot has joined #openstack-manila | 11:42 | |
*** carthaca_ has quit IRC | 11:43 | |
*** dgonzalez_ has quit IRC | 11:43 | |
*** seife_ has quit IRC | 11:43 | |
*** david_1 has quit IRC | 11:43 | |
*** databus23_ has quit IRC | 11:43 | |
*** mkoderer_ has quit IRC | 11:43 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [WIP] Add quotas per share type support https://review.openstack.org/452158 | 11:43 |
*** carthaca_1 has quit IRC | 11:44 | |
*** seife_1 has quit IRC | 11:44 | |
*** dgonzalez_1 has quit IRC | 11:44 | |
*** mkoderer_1 has quit IRC | 11:44 | |
*** databus23_1 has quit IRC | 11:44 | |
*** david_2 has quit IRC | 11:44 | |
openstackgerrit | Emilien Macchi proposed openstack/manila master: Add sem-ver flag so pbr generates correct version https://review.openstack.org/453421 | 11:45 |
*** tommylikehu_ has joined #openstack-manila | 11:46 | |
*** kaisers has joined #openstack-manila | 11:46 | |
*** tommylikehu_ has quit IRC | 11:47 | |
*** tommylikehu_ has joined #openstack-manila | 11:47 | |
openstackgerrit | Merged openstack/manila master: Update to current tempest tag https://review.openstack.org/452450 | 11:49 |
*** tommylikehu_ has quit IRC | 11:50 | |
*** tommylikehu_ has joined #openstack-manila | 11:50 | |
openstackgerrit | Merged openstack/manila master: Fix important:: directive display in install guide https://review.openstack.org/453189 | 11:50 |
*** kaisers has quit IRC | 12:15 | |
*** gouthamr has joined #openstack-manila | 12:29 | |
*** sapcc-bot1 has quit IRC | 12:41 | |
*** sapcc-bot has quit IRC | 12:41 | |
*** sapcc-bot has joined #openstack-manila | 12:41 | |
*** david_1 has joined #openstack-manila | 12:41 | |
*** carthaca_ has joined #openstack-manila | 12:41 | |
*** dgonzalez_ has joined #openstack-manila | 12:41 | |
*** mkoderer_ has joined #openstack-manila | 12:41 | |
*** mkoderer_ has quit IRC | 12:43 | |
*** dgonzalez_ has quit IRC | 12:43 | |
*** carthaca_ has quit IRC | 12:43 | |
*** david_1 has quit IRC | 12:43 | |
*** dsariel has quit IRC | 12:44 | |
*** tongli has joined #openstack-manila | 12:49 | |
-openstackstatus- NOTICE: The Gerrit service on http://review.openstack.org is being restarted to address hung remote replication tasks, and should return to an operable state momentarily | 12:51 | |
*** gouthamr has quit IRC | 12:53 | |
*** gouthamr has joined #openstack-manila | 12:58 | |
*** mtanino has joined #openstack-manila | 12:59 | |
*** eharney has joined #openstack-manila | 13:00 | |
*** porrua has joined #openstack-manila | 13:01 | |
*** catintheroof has joined #openstack-manila | 13:10 | |
*** catintheroof has quit IRC | 13:10 | |
*** kaisers has joined #openstack-manila | 13:11 | |
*** catintheroof has joined #openstack-manila | 13:11 | |
*** chlong has joined #openstack-manila | 13:17 | |
*** rraja has quit IRC | 13:17 | |
*** xyang1 has joined #openstack-manila | 13:20 | |
*** cknight has joined #openstack-manila | 13:25 | |
*** mkoderer has joined #openstack-manila | 13:28 | |
*** rraja has joined #openstack-manila | 13:31 | |
*** dsariel has joined #openstack-manila | 13:36 | |
*** lpetrut has joined #openstack-manila | 13:42 | |
*** dsariel_ has joined #openstack-manila | 13:47 | |
*** david_1 has joined #openstack-manila | 13:47 | |
*** seife_ has joined #openstack-manila | 13:47 | |
*** dgonzalez_ has joined #openstack-manila | 13:47 | |
*** mkoderer_ has joined #openstack-manila | 13:47 | |
*** carthaca_ has joined #openstack-manila | 13:47 | |
*** tpatzig_ has joined #openstack-manila | 13:47 | |
zhongjun_ | ganso: ping :) | 13:48 |
*** gcb has joined #openstack-manila | 13:48 | |
*** carthaca_ has quit IRC | 13:49 | |
*** dgonzalez_ has quit IRC | 13:49 | |
*** mkoderer_ has quit IRC | 13:49 | |
*** seife_ has quit IRC | 13:49 | |
*** tpatzig_ has quit IRC | 13:49 | |
*** david_1 has quit IRC | 13:49 | |
*** dsariel has quit IRC | 13:50 | |
*** arnewiebalck has quit IRC | 13:56 | |
ganso | zhongjun_: pong | 13:57 |
*** lpetrut has quit IRC | 13:58 | |
*** lpetrut has joined #openstack-manila | 13:58 | |
zhongjun_ | ganso: In ensure_share spec: https://review.openstack.org/#/c/446494/15..16/specs/pike/ensure-share.rst | 13:59 |
zhongjun_ | ganso: you means I don't need to change ensure_share to get_shares? | 14:00 |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Add spec for infinite share https://review.openstack.org/452097 | 14:01 |
ganso | zhongjun_: yes, or change to another name, I think "get_shares" is not appropriate | 14:01 |
zhongjun_ | ganso:ok, I could just change it back | 14:03 |
ganso | zhongjun_: that would be ok | 14:03 |
zhongjun_ | ganso:" I would like to see paragraph about how the RPCs will be fenced while a share is under maintenance" | 14:03 |
zhongjun_ | ganso: How about I just add lock in ensure share method? | 14:03 |
ganso | zhongjun_: the problem is not lock in ensure, it is invocations to every other method | 14:04 |
ganso | zhongjun_: bswartz said in his comment that you should prevent several methods, such as extend, create_snapshot, etc while share is performing ensure | 14:05 |
ganso | zhongjun_: but you are not proposing a status to lock that through a status... | 14:05 |
*** hongbin has joined #openstack-manila | 14:06 | |
*** dsariel_ has quit IRC | 14:06 | |
*** esker has joined #openstack-manila | 14:08 | |
zhongjun_ | ganso: but in this spec, we only run ensure share when we restart the service, there is not extend, create_snapshot methods when we restart the sevice, why we should prevent it | 14:08 |
bswartz | ganso: not exactly | 14:09 |
bswartz | ganso: any background maintenance performed by manila should not prevent user requested operations | 14:09 |
bswartz | it acceptable to postpone user requested operations but if we failed any user requested operation on account of maintenance then we'd be breaking an API contract | 14:10 |
ganso | bswartz: yes | 14:10 |
ganso | bswartz: zhongjun_ says that it will only run during restarts | 14:11 |
ganso | bswartz: I see your comment was more general, but zhongjun_ says the workflow is very specific and there should be nothing to worry about | 14:12 |
ganso | bswartz: maybe there is no need to handle this in a generic way? the easier way to handle would be status lock, as every API method has a 'if status == "available"' to run | 14:12 |
zhongjun_ | ganso: we should worry about it in another spec: https://review.openstack.org/#/c/453553/ | 14:13 |
ganso | bswartz, zhongjun_: no, there are specific problems that will be created by your implementation if this is not addressed | 14:14 |
ganso | bswartz, zhongjun_: consider the following scenario | 14:14 |
ganso | bswartz, zhongjun_: a migration is being performed in m-dat | 14:14 |
ganso | bswartz, zhongjun_: so the share is being accessed | 14:14 |
ganso | bswartz, zhongjun_: and then service is restarted and conditions to trigger ensure_share are met, so it puts the share in maintenance, while it is being migrated, or it is about to start a migration | 14:15 |
zhongjun_ | ganso: In this scenario, the share status is not availble. so the share can not go to ensure share method, it means we can not put this share in maintenance | 14:17 |
zhongjun_ | s/available | 14:17 |
ganso | zhongjun_: ok | 14:18 |
ganso | zhongjun_: if any request like "extend" is received after init completes, then it is ok | 14:19 |
ganso | bswartz: do you know any specific situation where the above statement is not true? | 14:20 |
ganso | bswartz: I thought you implied that in your comment | 14:20 |
ganso | bswartz: "A better option is to make the fix stateless and to make the manager smart enough to fence any RPCs related to that share while the maintenance is ongoing. This way a user operation will occur either before or after a maintenance operation -- never at the same time, and never will it be blocked by maintenance." | 14:20 |
zhongjun_ | ganso: currently, any request like "extend" is received after init completes | 14:21 |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Add spec for ensure share https://review.openstack.org/446494 | 14:22 |
bswartz | I'm wary of any proposal to hold locks while performance maintenance | 14:23 |
bswartz | better to have some new kinds of DB state if we really need to perform online maintenance | 14:23 |
bswartz | not actual share states but a hidden flag perhaps | 14:23 |
*** david_1 has joined #openstack-manila | 14:23 | |
*** carthaca_ has joined #openstack-manila | 14:23 | |
*** tpatzig_ has joined #openstack-manila | 14:23 | |
*** dgonzalez_ has joined #openstack-manila | 14:23 | |
*** databus23_ has joined #openstack-manila | 14:23 | |
*** mkoderer_ has joined #openstack-manila | 14:23 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Add spec for ensure share https://review.openstack.org/446494 | 14:25 |
*** mkoderer_ has quit IRC | 14:25 | |
*** databus23_ has quit IRC | 14:25 | |
*** dgonzalez_ has quit IRC | 14:25 | |
*** tpatzig_ has quit IRC | 14:25 | |
*** carthaca_ has quit IRC | 14:25 | |
*** david_1 has quit IRC | 14:25 | |
*** dgonzalez_ has joined #openstack-manila | 14:26 | |
*** tommylikehu_ has quit IRC | 14:26 | |
zhongjun_ | bswartz:ye, we need to perform online maintenance in another spec( https://review.openstack.org/#/c/453553/) I could use lock instead of states. | 14:30 |
*** eharney has quit IRC | 14:30 | |
bswartz | zhongjun_: I've always maintained that locks should only be held briefly -- long enough to toggle DB state but not to do other I/O | 14:34 |
bswartz | because maintenance will involve I/O in nearly all cases, it would be bad to hold a lock that long | 14:34 |
*** rraja has quit IRC | 14:35 | |
*** dustins has joined #openstack-manila | 14:36 | |
zhongjun_ | bswartz: What kinds of DB state? | 14:40 |
*** eharney has joined #openstack-manila | 14:40 | |
*** lpetrut has quit IRC | 14:41 | |
bswartz | zhongjun_: I was just throwing an idea out that we could add a new hidden flag for maintenance | 14:41 |
bswartz | it might be a bad idea | 14:42 |
bswartz | but using locks is also a bad idea and using the user-visible state is also a bad idea | 14:42 |
*** makowals has quit IRC | 14:47 | |
*** kaisers has quit IRC | 14:59 | |
*** kaisers has joined #openstack-manila | 14:59 | |
*** chlong has quit IRC | 15:03 | |
*** chlong has joined #openstack-manila | 15:04 | |
*** markstur has joined #openstack-manila | 15:06 | |
zhongjun_ | bswartz: using the user-visible states, in this way, user could enter the 'ensuring' states, "users will have no control over when this state transition happens and it could block them from doing what they want." but acutually, user can not do anything when we run ensure share method. right? but we still need to let user think there is nothing happend in manila service, and user can do everthing the want(like extend action), we can hold | 15:07 |
zhongjun_ | these in manila service(extend share after ensure share ) | 15:07 |
*** dsariel has joined #openstack-manila | 15:10 | |
zhongjun_ | tbarron:In infinite share spec, you said 'manila create -size -1 ...' or 'manila create -size infinite ...' instead of just assuming infinite size if the size isn't specified. | 15:15 |
tbarron | zhongjun_: right, I thought the spec should explain why you made that choice | 15:15 |
tbarron | to do it implicitly rather than explicitly | 15:16 |
tbarron | It may be the right choice, but you should explain why. | 15:16 |
zhongjun_ | tbarron: you think the default is infinite is not suitable for manila | 15:16 |
tbarron | zhongjun_: no, I didn't say one way or the other; I said: please explain *your* design choice. | 15:16 |
tbarron | zhongjun_: you are writing this spec, not me :D | 15:17 |
*** tongli has quit IRC | 15:17 | |
*** EmilienM has joined #openstack-manila | 15:18 | |
EmilienM | vkmc: hey, can we poke folks to have https://review.openstack.org/#/c/453421/ merged asap, so tripleo CI can test upgrades from ocata to pike. Thanks | 15:18 |
zhongjun_ | tbarron: I got it, I just add it , you could see it wheather it is suitable for manila | 15:18 |
zhongjun_ | whether | 15:19 |
vkmc | EmilienM, sure thing | 15:19 |
EmilienM | thx | 15:19 |
*** chlong has quit IRC | 15:21 | |
zhongjun_ | tbarron: How about add like filter spec: "Unless there is a pressing need to do something in manila right away I'd rather see what works or not there - e.g. the key-value proposal." | 15:24 |
*** arnewiebalck has joined #openstack-manila | 15:26 | |
tbarron | bswartz: https://review.openstack.org/#/c/453421 please | 15:29 |
*** mtanino has quit IRC | 15:31 | |
tbarron | zhongjun_: well I think infinite or no-fixed-size shares make a lot of sense, especially for backends that use a distributed file system and have to implement share sizes by quotas rather than by actual backend allocations | 15:33 |
tbarron | zhongjun_: I just haven't had time to think through the implications well enough to propose it myself. | 15:33 |
tbarron | zhongjun_: so I welcome your work on this front, but I do want the design choices to be explicit and discussed by the community | 15:34 |
tbarron | zhongjun_: and that may take some time, I don't know ... | 15:34 |
*** chlong has joined #openstack-manila | 15:35 | |
*** kaisers has quit IRC | 15:36 | |
zhongjun_ | tbarron: I could add more details in spec or discussed by the community, but in above, there is not about infinite share :D. this is another spec( changing some filter behaviour to use 'LIKE' expression on some columnshttps://review.openstack.org/#/c/447775/ ) | 15:42 |
tbarron | zhongjun_: oh, sorry for the confusion, looking ... | 15:44 |
zhongjun_ | tbarron: haha, It doesn't matter | 15:44 |
*** dsariel has quit IRC | 15:55 | |
*** esker has quit IRC | 15:57 | |
*** swapnil-nilangek has joined #openstack-manila | 16:00 | |
*** tommylikehu_ has joined #openstack-manila | 16:05 | |
*** kaisers has joined #openstack-manila | 16:06 | |
tbarron | bswartz: I guess we are getting towards the 6 month change of phase for backports to stable/newton | 16:08 |
tbarron | bswartz: would be good to get https://review.openstack.org/#/c/415693/ | 16:08 |
tbarron | bswartz: brings the UI into alignment with the CLI and API | 16:08 |
tbarron | bswartz: so I'd argue it's not adding functionality but exposing functionality that's already there | 16:09 |
openstackgerrit | Merged openstack/manila master: Add sem-ver flag so pbr generates correct version https://review.openstack.org/453421 | 16:15 |
*** tommylikehu_ has quit IRC | 16:15 | |
*** gcb has quit IRC | 16:25 | |
bswartz | zhongjun_: all the state changes today are initiated by user action -- adding a state transition that occurs with no user action is bad because it will race with actual user action and break things (low probability, but it will happen) | 16:29 |
bswartz | zhongjun_: there will need to be *some* kind of transition if we perform online maintenance of shares, but it shouldn't be a share state transition -- that's all I'm saying | 16:30 |
bswartz | because if a user sends and API request at the exact moment the maintenance occurs, then the user action still needs to succeed as it would have without the maintenance -- although it might possibly take longer | 16:31 |
bswartz | tbarron: ack | 16:31 |
*** mtanino has joined #openstack-manila | 16:31 | |
tbarron | bswartz: ty | 16:31 |
bswartz | tbarron: what exactly did we merge from EmilienM? it looks like an empty commit to me | 16:33 |
tbarron | bswartz: did you see my comment in the patch pointing to how it works? | 16:33 |
bswartz | tbarron: I started reading that pbr doc -- it sounds pretty horrifying | 16:34 |
bswartz | I just wanted to confirm that the commit was indeed empty | 16:34 |
bswartz | rather, that we intended to merge an empty commmit | 16:34 |
tbarron | bswartz: it is indeed empty, all that matters is that commit tag | 16:35 |
bswartz | what tag? | 16:35 |
tbarron | not git tag | 16:35 |
bswartz | you mean that commit messages now have semantic meaning as far as pbr is concerned? | 16:35 |
tbarron | bswartz: yeah, that's how I understand it | 16:36 |
bswartz | yeah that's exactly what I find horrifying | 16:36 |
*** kaisers has quit IRC | 16:36 | |
*** kaisers has joined #openstack-manila | 16:36 | |
bswartz | oh well, we shall not question the wisdom of pbr | 16:36 |
tbarron | bswartz: understood, but we are just fitting into something bigger than us :D | 16:36 |
*** kaisers has quit IRC | 16:36 | |
*** kaisers has joined #openstack-manila | 16:37 | |
tbarron | bswartz: anyways, ganso workflowed it while you were doing other things, and I think that all things considered it's the right decision | 16:37 |
tbarron | not *going there* with the more general discussion of whether pbr should be using these commit msgs that way, I just mean given that it is, we don't want manila to break on pbr | 16:39 |
tbarron | bswartz: when you get a chance, consider https://review.openstack.org/#/c/415693/ for stable/newton as the cutoff is reportedly tomorrow | 16:41 |
tbarron | cutoff for all but security and critical ... | 16:41 |
*** kaisers has quit IRC | 16:41 | |
EmilienM | tbarron: back from lunch | 16:43 |
EmilienM | yeah it's all magic in the commit mesage | 16:43 |
tbarron | EmilienM: didn't think you ever had time for lunch | 16:43 |
EmilienM | ahah :) | 16:43 |
EmilienM | everyone should take a break for lunch | 16:43 |
tbarron | EmilienM: anyways, it merged | 16:43 |
EmilienM | thx | 16:44 |
openstackgerrit | Alex Schultz proposed openstack/puppet-manila master: Drop -dev for release prep https://review.openstack.org/453764 | 16:45 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [WIP] Add quotas per share type support https://review.openstack.org/452158 | 16:56 |
openstackgerrit | Merged openstack/manila-image-elements master: Allow built image be available via local webserver https://review.openstack.org/444353 | 17:03 |
*** swapnil-nilangek has quit IRC | 17:18 | |
*** esker has joined #openstack-manila | 17:24 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [WIP] Add quotas per share type support https://review.openstack.org/452158 | 17:50 |
*** esker has quit IRC | 17:59 | |
*** harlowja has quit IRC | 18:33 | |
*** kaisers has joined #openstack-manila | 18:36 | |
*** hoonetorg has quit IRC | 18:51 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-specs master: Integration with ceilometer https://review.openstack.org/445441 | 19:00 |
*** chenying_ has quit IRC | 19:05 | |
*** chenying_ has joined #openstack-manila | 19:06 | |
*** jprovazn has quit IRC | 19:07 | |
*** bswartz has quit IRC | 19:22 | |
*** esker has joined #openstack-manila | 19:35 | |
*** xyang_ has joined #openstack-manila | 19:45 | |
xyang_ | gouthamr, ganso: hi, what do you guys think about this backport since you reviewed the original patch? https://review.openstack.org/#/c/451130/ | 19:47 |
*** esker has quit IRC | 19:54 | |
*** markstur_ has joined #openstack-manila | 19:57 | |
*** harlowja has joined #openstack-manila | 19:58 | |
*** esker has joined #openstack-manila | 19:59 | |
*** esker has quit IRC | 20:00 | |
*** markstur has quit IRC | 20:00 | |
*** esker has joined #openstack-manila | 20:00 | |
*** pcaruana has quit IRC | 20:01 | |
gouthamr | xyang_: i'm okay with it; don't consider it risky or anything. | 20:02 |
xyang_ | gouthamr: great. thanks | 20:03 |
*** porrua has quit IRC | 20:21 | |
*** cknight has quit IRC | 20:52 | |
*** hoonetorg has joined #openstack-manila | 20:53 | |
*** kaisers has quit IRC | 20:56 | |
*** gouthamr has quit IRC | 21:21 | |
*** dustins has quit IRC | 21:26 | |
*** eharney has quit IRC | 21:31 | |
*** xyang_ has quit IRC | 21:46 | |
*** xyang_ has joined #openstack-manila | 21:47 | |
*** catintheroof has quit IRC | 21:54 | |
*** chlong has quit IRC | 22:02 | |
*** harlowja has quit IRC | 22:05 | |
*** xyang1 has quit IRC | 22:09 | |
*** xyang_ has quit IRC | 22:10 | |
*** kaisers has joined #openstack-manila | 22:36 | |
*** kaisers has quit IRC | 22:41 | |
*** ganso has quit IRC | 23:05 | |
*** porrua has joined #openstack-manila | 23:12 | |
*** porrua_ has joined #openstack-manila | 23:14 | |
*** porrua has quit IRC | 23:17 | |
*** markstur_ has quit IRC | 23:21 | |
*** harlowja has joined #openstack-manila | 23:25 | |
*** bswartz has joined #openstack-manila | 23:38 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!