*** gouthamr has quit IRC | 00:00 | |
*** markstur has quit IRC | 00:35 | |
*** a-pugachev has quit IRC | 00:36 | |
*** markstur has joined #openstack-manila | 00:36 | |
*** markstur has quit IRC | 00:40 | |
*** kaisers has quit IRC | 01:04 | |
*** kaisers has joined #openstack-manila | 01:44 | |
openstackgerrit | TommyLike proposed openstack/manila master: Add perodic task to clean up expired reservation https://review.openstack.org/440155 | 01:58 |
---|---|---|
*** tuanluong has joined #openstack-manila | 01:59 | |
*** tuanluong_ has joined #openstack-manila | 02:02 | |
*** tuanluong has quit IRC | 02:05 | |
*** gouthamr has joined #openstack-manila | 02:05 | |
*** markstur has joined #openstack-manila | 02:26 | |
*** markstur has quit IRC | 02:44 | |
*** kaisers has quit IRC | 02:46 | |
*** tuanluong has joined #openstack-manila | 02:47 | |
*** tuanluong_ has quit IRC | 02:49 | |
*** markstur has joined #openstack-manila | 03:14 | |
*** gouthamr has quit IRC | 03:16 | |
*** markstur has quit IRC | 03:19 | |
*** kaisers has joined #openstack-manila | 03:42 | |
*** catintheroof has joined #openstack-manila | 03:43 | |
*** markstur has joined #openstack-manila | 03:50 | |
*** catintheroof has quit IRC | 03:51 | |
*** markstur has quit IRC | 03:53 | |
*** kaisers has quit IRC | 04:23 | |
*** kaisers has joined #openstack-manila | 04:24 | |
*** markstur has joined #openstack-manila | 04:24 | |
*** kaisers has quit IRC | 04:25 | |
*** kaisers has joined #openstack-manila | 04:25 | |
*** kaisers has quit IRC | 04:31 | |
*** kaisers has joined #openstack-manila | 04:55 | |
*** ociuhandu has quit IRC | 05:00 | |
*** ociuhandu has joined #openstack-manila | 05:01 | |
*** markstur has quit IRC | 05:38 | |
*** ociuhandu has quit IRC | 05:55 | |
*** gcb has joined #openstack-manila | 05:57 | |
*** tuanluong has quit IRC | 06:00 | |
*** pcaruana has joined #openstack-manila | 06:01 | |
*** ociuhandu has joined #openstack-manila | 06:05 | |
*** sticker has joined #openstack-manila | 06:11 | |
*** tuanluong has joined #openstack-manila | 06:14 | |
*** dsariel has joined #openstack-manila | 06:23 | |
*** ociuhandu has quit IRC | 06:31 | |
*** ociuhandu has joined #openstack-manila | 06:44 | |
*** jprovazn has joined #openstack-manila | 06:46 | |
*** gaurangt has joined #openstack-manila | 06:59 | |
*** dmellado has joined #openstack-manila | 07:08 | |
*** markstur has joined #openstack-manila | 07:14 | |
*** markstur has quit IRC | 07:19 | |
*** gcb has quit IRC | 07:46 | |
*** lpetrut has joined #openstack-manila | 07:48 | |
*** a-pugachev has joined #openstack-manila | 07:58 | |
*** gcb has joined #openstack-manila | 08:12 | |
*** ociuhandu has quit IRC | 08:51 | |
*** ociuhandu has joined #openstack-manila | 09:00 | |
*** tuanluong has quit IRC | 09:10 | |
*** ociuhandu has quit IRC | 09:14 | |
*** ociuhandu has joined #openstack-manila | 09:18 | |
*** rpittau has joined #openstack-manila | 09:31 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-specs master: Add spec for share_groups quota resource https://review.openstack.org/452270 | 09:43 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-specs master: Add spec for share_groups quota resource https://review.openstack.org/452270 | 09:45 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: Add possibility to run 'manila-api' with wsgi web servers https://review.openstack.org/448190 | 09:49 |
*** gcb has quit IRC | 10:16 | |
zhongjun_ | vponomaryov: ping | 10:21 |
*** ociuhandu has quit IRC | 10:25 | |
vponomaryov | zhongjun_: pong | 10:31 |
zhongjun_ | vponomaryov: in https://review.openstack.org/#/c/448969/7/specs/pike/support-filter-share-by-export-location.rst | 10:33 |
zhongjun_ | vponomaryov: Only shares API? Why not "share-instances" API too? | 10:33 |
zhongjun_ | vponomaryov: We can get share instances from share id. | 10:34 |
zhongjun_ | vponomaryov: s/from/by | 10:36 |
zhongjun_ | vponomaryov: Could we focous on share filter? | 10:36 |
vponomaryov | zhongjun_: still don't see argument for not implementing filter in share-instances LIST API | 10:38 |
vponomaryov | zhongjun_: now you say that you will use 2 API calls instead of 1 | 10:38 |
vponomaryov | zhongjun_: 1 - get share ID and then filter share instances using share ID | 10:39 |
vponomaryov | zhongjun_: instad of filtering share instances directly | 10:39 |
vponomaryov | s/instad/instead/ | 10:39 |
zhongjun_ | vponomaryov: Use this logic, it sounds like we need to add more filters in share-instances LIST API :D | 10:41 |
vponomaryov | could be | 10:42 |
vponomaryov | but others are out of scope for your spec | 10:42 |
*** markstur has joined #openstack-manila | 10:50 | |
*** jprovazn has quit IRC | 10:51 | |
zhongjun_ | vponomaryov: OK, It will good for admin. | 10:53 |
*** markstur has quit IRC | 10:55 | |
*** ociuhandu has joined #openstack-manila | 10:55 | |
*** ganso has joined #openstack-manila | 10:59 | |
zhongjun_ | vponomaryov: We could get share instance ID from share export location path, and use "share-instance-show <instance>" command to find out associated share. | 11:10 |
vponomaryov | zhongjun_: mot always you can do it | 11:11 |
vponomaryov | s/mot/not/ | 11:11 |
zhongjun_ | vponomaryov: just 1 API, but not directly to get instance ID | 11:11 |
zhongjun_ | vponomaryov: in spec, gason said: I don't see share-instances as a much needed requirement since shares API is the one user-facing whi share-instances is admin-only | 11:18 |
zhongjun_ | vponomaryov: How's your opinion about this? | 11:18 |
vponomaryov | gason )) | 11:19 |
zhongjun_ | vponomaryov: When we run share-instances-list command, we can not see the export location in the share instances list https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py#L1572 | 11:21 |
vponomaryov | zhongjun_: policies can be changed anyhow. admin/user - should not make diff | 11:21 |
vponomaryov | zhongjun_: "export-locaion" is share instance's part, not share's | 11:22 |
vponomaryov | zhongjun_:and still don't see argument for not implementing it | 11:22 |
zhongjun_ | vponomaryov: yes, just not show up in share-instances-list command | 11:22 |
vponomaryov | zhongjun_: what exactly do you lose if you implement that filtering there too? | 11:22 |
zhongjun_ | vponomaryov: OK, I think your idea is good for admin | 11:23 |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Support retrieve shares filtered by export-location https://review.openstack.org/448969 | 11:25 |
zhongjun_ | vponomaryov: If I am a admin, I think I will like you very much. | 11:26 |
zhongjun_ | vponomaryov: Done, Please take a look again : ) | 11:26 |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Support retrieve shares filtered by export-location https://review.openstack.org/448969 | 11:31 |
*** jprovazn has joined #openstack-manila | 11:32 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Support retrieve shares filtered by export-location https://review.openstack.org/448969 | 11:32 |
*** belmoreira has joined #openstack-manila | 11:36 | |
openstackgerrit | zhongshengping proposed openstack/puppet-manila master: oslo db: check puppet resource instead of actual config in spec https://review.openstack.org/455274 | 11:39 |
vponomaryov | zhongjun_: do not use "master" as reference does not mean "delete it" | 11:40 |
tommylikehu | zhongjun, you could aslo like vponomaryov | 11:40 |
tommylikehu | even if you are not a administrator | 11:40 |
vponomaryov | tommylikehu: ^_^ | 11:40 |
ganso | tommylikehu: lol | 11:40 |
vponomaryov | zhongjun_: do not use "master" as reference means use specific tag or commit reference instead | 11:41 |
vponomaryov | zhongjun_: in other words - "immutable" reference | 11:42 |
zhongjun_ | vponomaryov: Ok, I got it. | 11:42 |
zhongjun_ | vponomaryov: Done, Dear vponomaryov. haha | 11:44 |
*** mtanino has joined #openstack-manila | 11:51 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Support retrieve shares filtered by export-location https://review.openstack.org/448969 | 11:51 |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Add spec for infinite share https://review.openstack.org/452097 | 11:57 |
openstackgerrit | Merged openstack/manila master: Updated from global requirements https://review.openstack.org/453882 | 12:09 |
*** gouthamr has joined #openstack-manila | 12:28 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Allow to filter resources by inexact value matching in 'list' APIs https://review.openstack.org/447775 | 12:30 |
vponomaryov | zhongjun_: any other "stable" branch is mutable too | 12:30 |
zhongjun_ | vponomaryov:I think I could just remove it | 12:31 |
vponomaryov | zhongjun_: you could just use immutable one based on commit id | 12:31 |
zhongjun_ | vponomaryov: The links are not very important | 12:32 |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Support retrieve shares filtered by export-location https://review.openstack.org/448969 | 12:33 |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Support retrieve shares filtered by export-location https://review.openstack.org/448969 | 12:34 |
*** catintheroof has joined #openstack-manila | 12:36 | |
*** dsariel has quit IRC | 12:41 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Enhance update shares https://review.openstack.org/453553 | 12:46 |
*** gcb has joined #openstack-manila | 12:50 | |
*** dustins has joined #openstack-manila | 12:51 | |
vponomaryov | zhongjun_: set +2, keeping hope in heart to see appropriate links when they appear in future | 12:53 |
zhongjun_ | vponomaryov: Thanks :) I will | 12:54 |
vponomaryov | example: https://github.com/openstack/manila/blob/31a19b1f/manila/api/v2/share_instances.py#L90 | 12:54 |
vponomaryov | it is immutable link | 12:54 |
*** dsariel has joined #openstack-manila | 12:54 | |
*** cknight has joined #openstack-manila | 12:55 | |
zhongjun_ | vponomaryov: lol | 12:56 |
zhongjun_ | tbarron: hi, " A sequence diagram would be quite helpful here I think." What kind of sequence diagram? Is there an example? | 12:57 |
zhongjun_ | tbarron: link: https://review.openstack.org/#/c/446494/20/specs/pike/ensure-share.rst | 12:58 |
*** xyang1 has joined #openstack-manila | 12:58 | |
vponomaryov | zhongjun_: about https://review.openstack.org/#/c/453553/2..3/specs/pike/enhance-update-shares.rst | 13:01 |
vponomaryov | zhongjun_: you cannot add new sections | 13:01 |
vponomaryov | zhongjun_: we have template | 13:02 |
vponomaryov | zhongjun_: it should be common for all | 13:02 |
zhongjun_ | vponomaryov: oh | 13:02 |
vponomaryov | zhongjun_: second, other existing comments are not fully addressed | 13:02 |
vponomaryov | zhongjun_: amount of commit updates should be minimized as much as possible | 13:02 |
vponomaryov | zhongjun_: else you make reviewer life nightmare to track down all discussions about all concerns | 13:03 |
zhongjun_ | vponomaryov: Which part is suitable for workflow example | 13:04 |
vponomaryov | zhongjun_: how do you think? | 13:04 |
zhongjun_ | vponomaryov: I think "Proposed change" is suitable :) | 13:06 |
vponomaryov | zhongjun_: why? | 13:06 |
zhongjun_ | vponomaryov: Because it is a part of proposed change | 13:06 |
zhongjun_ | vponomaryov: we still change the workflow | 13:07 |
vponomaryov | zhongjun_: look, your spec https://review.openstack.org/#/c/453553/ means following: run "ensure_share" using periodic task and stop running it on manila-share service start-up | 13:08 |
zhongjun_ | vponomaryov: The spec don't means stop running it on manila-share service start-up | 13:09 |
vponomaryov | zhongjun_: is it intended? | 13:10 |
vponomaryov | s/intended/intentional/ | 13:10 |
zhongjun_ | vponomaryov: maybe I did not express the intention well | 13:11 |
zhongjun_ | vponomaryov: We can support run "ensure_share" using periodic task and running it on manila-share service start-up | 13:12 |
vponomaryov | zhongjun_: anyway, need to describe how and when it will be called now compared to old approach and why | 13:12 |
zhongjun_ | vponomaryov: Cool | 13:13 |
zhongjun_ | vponomaryov: lol | 13:15 |
vponomaryov | zhongjun_: ? | 13:15 |
zhongjun_ | vponomaryov: I agree with you | 13:15 |
vponomaryov | zhongjun_: the main problem is that you do not imagine whole picture of your personal proposal, I do such statement reading spec and looking at changes that "address" comments. If you do not imagine, who else should do it? | 13:17 |
vponomaryov | zhongjun_: If you really want to keep "workflow" then it is a point for "use cases" section | 13:19 |
vponomaryov | zhongjun_: the idea of it | 13:19 |
*** Administrator_ has quit IRC | 13:23 | |
*** Administrator_ has joined #openstack-manila | 13:24 | |
zhongjun_ | vponomaryov: It was a complete spec in the past, I separeted it(enhance-update-shares) from ensure_share spec. It is too many mixed together, I will focus more on that. | 13:25 |
*** eharney has joined #openstack-manila | 13:26 | |
*** mtanino has quit IRC | 13:28 | |
*** chlong has joined #openstack-manila | 13:31 | |
*** openstackgerrit has quit IRC | 13:33 | |
*** porrua has joined #openstack-manila | 13:35 | |
*** cknight has quit IRC | 13:47 | |
*** cknight has joined #openstack-manila | 13:48 | |
*** hongbin has joined #openstack-manila | 14:01 | |
*** openstackgerrit has joined #openstack-manila | 14:04 | |
openstackgerrit | Jan Provaznik proposed openstack/manila-specs master: Add spec for user messages https://review.openstack.org/434277 | 14:04 |
*** a-pugachev has quit IRC | 14:11 | |
*** a-pugachev has joined #openstack-manila | 14:12 | |
*** mtanino has joined #openstack-manila | 14:16 | |
*** esker has joined #openstack-manila | 14:25 | |
*** markstur has joined #openstack-manila | 14:27 | |
*** markstur has quit IRC | 14:31 | |
*** belmoreira has quit IRC | 14:46 | |
*** scottda has joined #openstack-manila | 14:57 | |
*** carthaca_ has joined #openstack-manila | 15:05 | |
*** cknight has quit IRC | 15:34 | |
*** dsariel has quit IRC | 15:38 | |
*** esker has quit IRC | 15:40 | |
*** makowals_ has joined #openstack-manila | 15:41 | |
*** chenying_ has quit IRC | 15:43 | |
*** makowals has quit IRC | 15:43 | |
*** chenying_ has joined #openstack-manila | 15:44 | |
*** lpetrut has quit IRC | 15:47 | |
*** esker has joined #openstack-manila | 15:52 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Allow to filter resources by inexact value matching in 'list' APIs https://review.openstack.org/447775 | 15:52 |
openstackgerrit | Merged openstack/puppet-manila master: oslo db: check puppet resource instead of actual config in spec https://review.openstack.org/455274 | 15:58 |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Allow to filter resources by inexact value matching in 'list' APIs https://review.openstack.org/447775 | 16:10 |
*** Zhongjun__ has joined #openstack-manila | 16:11 | |
*** esker has quit IRC | 16:33 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Add spec for infinite share https://review.openstack.org/452097 | 16:37 |
*** a-pugachev has quit IRC | 16:44 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [WIP] Add quotas per share type support https://review.openstack.org/452158 | 16:51 |
*** markstur has joined #openstack-manila | 16:53 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Add spec for infinite share https://review.openstack.org/452097 | 16:57 |
*** markstur has quit IRC | 16:58 | |
*** chenying_ has quit IRC | 16:58 | |
*** chenying_ has joined #openstack-manila | 16:58 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [WIP] Add quotas per share type support https://review.openstack.org/452158 | 17:08 |
*** kaisers has quit IRC | 17:09 | |
*** kaisers has joined #openstack-manila | 17:09 | |
*** kaisers has quit IRC | 17:11 | |
*** kaisers has joined #openstack-manila | 17:12 | |
*** kaisers has quit IRC | 17:12 | |
*** kaisers has joined #openstack-manila | 17:14 | |
*** ociuhandu has quit IRC | 17:39 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Add spec for change ensure share to make startup faster https://review.openstack.org/446494 | 17:51 |
*** kaisers has quit IRC | 17:51 | |
*** kaisers has joined #openstack-manila | 17:52 | |
*** kaisers has quit IRC | 17:56 | |
*** cknight has joined #openstack-manila | 18:00 | |
openstackgerrit | zhongjun proposed openstack/manila-specs master: Add spec for infinite share https://review.openstack.org/452097 | 18:01 |
*** ociuhandu has joined #openstack-manila | 18:04 | |
*** cknight has quit IRC | 18:21 | |
openstackgerrit | Jan Provaznik proposed openstack/manila-specs master: Add spec for user messages https://review.openstack.org/434277 | 18:22 |
*** a-pugachev has joined #openstack-manila | 18:40 | |
*** jprovazn has quit IRC | 18:50 | |
*** cknight has joined #openstack-manila | 18:51 | |
*** chatter29 has joined #openstack-manila | 19:07 | |
chatter29 | hey guys | 19:07 |
chatter29 | allah is doing | 19:07 |
chatter29 | sun is not doing allah is doing | 19:07 |
chatter29 | to accept Islam say that i bear witness that there is no deity worthy of worship except Allah and Muhammad peace be upon him is his slave and messenger | 19:08 |
*** cknight has quit IRC | 19:08 | |
*** cknight has joined #openstack-manila | 19:12 | |
*** chatter29 has quit IRC | 19:18 | |
*** cknight has quit IRC | 19:18 | |
*** zhonghua has quit IRC | 19:37 | |
*** zhonghua has joined #openstack-manila | 19:38 | |
*** gouthamr has quit IRC | 19:54 | |
*** porrua has quit IRC | 19:57 | |
*** Zhongjun__ has quit IRC | 20:11 | |
*** markstur has joined #openstack-manila | 20:29 | |
*** markstur has quit IRC | 20:34 | |
*** dustins has quit IRC | 20:55 | |
*** pcaruana has quit IRC | 21:15 | |
*** catintheroof has quit IRC | 21:25 | |
*** eharney has quit IRC | 21:34 | |
*** a-pugachev has quit IRC | 21:58 | |
*** xyang1 has quit IRC | 22:08 | |
*** hoonetorg has quit IRC | 22:16 | |
*** zhonghua has quit IRC | 22:22 | |
*** zhonghua has joined #openstack-manila | 22:23 | |
*** ganso has quit IRC | 22:26 | |
*** catintheroof has joined #openstack-manila | 22:27 | |
*** gouthamr has joined #openstack-manila | 22:31 | |
*** hoonetorg has joined #openstack-manila | 22:39 | |
*** scottda has quit IRC | 23:15 | |
*** zhonghua has quit IRC | 23:23 | |
*** zhonghua has joined #openstack-manila | 23:24 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!