*** markstur_ has quit IRC | 00:46 | |
*** markstur has joined #openstack-manila | 00:47 | |
*** sjjfowler has joined #openstack-manila | 00:53 | |
*** tuanluong has joined #openstack-manila | 01:05 | |
*** markstur has quit IRC | 01:42 | |
*** kaisers_ has joined #openstack-manila | 01:48 | |
*** kaisers__ has quit IRC | 01:50 | |
*** markstur has joined #openstack-manila | 02:02 | |
*** markstur has quit IRC | 02:11 | |
openstackgerrit | Ryan Liang proposed openstack/manila master: VNX: share server cannot be deleted https://review.openstack.org/477863 | 02:20 |
---|---|---|
*** markstur has joined #openstack-manila | 02:48 | |
*** markstur has quit IRC | 02:53 | |
*** gouthamr has quit IRC | 03:25 | |
*** sjjfowler has quit IRC | 03:35 | |
*** dsariel has quit IRC | 03:39 | |
*** arnewiebalck_ has joined #openstack-manila | 04:27 | |
openstackgerrit | zhongjun proposed openstack/manila master: Add like filter https://review.openstack.org/462468 | 04:48 |
openstackgerrit | zhongjun proposed openstack/manila master: Add like filter https://review.openstack.org/462468 | 05:04 |
*** sapcc-bot has quit IRC | 05:08 | |
*** zengyingzhe has quit IRC | 05:08 | |
*** sapcc-bot3 has joined #openstack-manila | 05:08 | |
*** zengyingzhe_ has joined #openstack-manila | 05:08 | |
*** lpetrut has joined #openstack-manila | 05:31 | |
*** markstur has joined #openstack-manila | 05:40 | |
*** markstur has quit IRC | 05:44 | |
*** jprovazn has joined #openstack-manila | 06:21 | |
*** sticker has quit IRC | 06:31 | |
*** lpetrut has quit IRC | 06:35 | |
*** pcaruana has joined #openstack-manila | 06:45 | |
*** rraja has joined #openstack-manila | 06:48 | |
jprovazn | tommylikehu: hi | 06:58 |
tommylikehu | hi | 06:58 |
jprovazn | tommylikehu: could you remind me why oslo_versionedobjects.fields.Enum is used here? https://review.openstack.org/#/c/448384/22/cinder/message/message_field.py First I thought it's primarily because it would take care of only valid values, but now when I'm looking closer how Enum class works, it's not the case :) | 07:01 |
tommylikehu | jprovazn: I wanna store the enum key itself into db. for example 'SCHEDULE_ALLOCATE_VOLUME' | 07:03 |
* jprovazn looks again how versionedobjects work | 07:07 | |
tommylikehu | jprovazn ok. let me try to rethink it again | 07:09 |
openstackgerrit | zhongjun proposed openstack/python-manilaclient master: Add export-location filter in share and share instance list https://review.openstack.org/468277 | 07:10 |
jprovazn | tommylikehu: it might be that I overlooked something but it looks like it's not needed there | 07:18 |
tommylikehu | so you guess the original enum is enough? | 07:19 |
*** arnewiebalck_ has quit IRC | 07:23 | |
tommylikehu | jprovazn: the first idea to use the osloversionedobjects enum is that the value can be directly obtained without specifying the value key. such as 'Action.SCHEDULE_ALLOCATE_VOLUME' rather than 'Action.SCHEDULE_ALLOCATE_VOLUME.value' | 07:26 |
tommylikehu | jprovazn: what's your advice? | 07:28 |
*** markstur has joined #openstack-manila | 07:28 | |
jprovazn | tommylikehu: goutham raised the question why versionedobjects in https://review.openstack.org/#/c/313549/46/manila/message/message_field.py , in that time I copied from cinder and misunderstood the prupose of fields usage in this package, now I' mtrying to justify/understand it :) | 07:30 |
jprovazn | tommylikehu: so far it seems to me that nowhere is used any feature of these versionedobjects, but honestly the oslodoc for this feature is not very clear to me | 07:32 |
tommylikehu | jprovazn: it seems to, and we may have better choice, if you have one please ping me :) | 07:32 |
*** markstur has quit IRC | 07:33 | |
jprovazn | tommylikehu: so I wonder, in this code https://review.openstack.org/#/c/448384/22/cinder/message/message_field.py - if we would not inherit from the fields.Enum for Action and Detail classes, where would it fail? | 07:33 |
*** lpetrut has joined #openstack-manila | 07:35 | |
tommylikehu | we would change our translate logic a little bit | 07:37 |
tommylikehu | jprovazn: use xxx.value inside | 07:37 |
*** gouthamr has joined #openstack-manila | 07:40 | |
*** lpetrut has quit IRC | 07:42 | |
jprovazn | tommylikehu: .value would not be defined | 07:44 |
jprovazn | tommylikehu: these constants are accessed as classic contants everywhere anyway | 07:45 |
*** dims has quit IRC | 07:45 | |
*** dims has joined #openstack-manila | 07:48 | |
tommylikehu | jprovazn: so, could you update your patch, So maybe I can get a better understanding on your idea | 07:57 |
jprovazn | tommylikehu: sure, sec | 07:57 |
jprovazn | tommylikehu: s/sec/30 mins/ | 07:58 |
tommylikehu | jprovazn: great! | 07:59 |
*** rodolof has joined #openstack-manila | 07:59 | |
*** rraja has quit IRC | 08:36 | |
*** markstur has joined #openstack-manila | 08:40 | |
*** markstur has quit IRC | 08:45 | |
*** dims has quit IRC | 08:45 | |
*** dims has joined #openstack-manila | 08:47 | |
jprovazn | tommylikehu: hm it will take more time - got stuck on fixing one tempest test | 08:51 |
openstackgerrit | Ryan Liang proposed openstack/manila master: Unity: unexpected data in share from snapshot https://review.openstack.org/479218 | 09:14 |
*** markstur has joined #openstack-manila | 09:16 | |
*** markstur has quit IRC | 09:21 | |
*** lpetrut has joined #openstack-manila | 09:27 | |
openstackgerrit | Jan Provaznik proposed openstack/manila master: User Messages https://review.openstack.org/313549 | 09:42 |
jprovazn | tommylikehu: ^ https://review.openstack.org/#/c/313549/47/manila/message/message_field.py | 09:43 |
tommylikehu | jprovazn: thanks | 09:43 |
*** arnewiebalck_ has joined #openstack-manila | 09:45 | |
tommylikehu | jprovazn: that's simpler and cleaner :) | 09:49 |
jprovazn | tommylikehu: cool :) | 09:56 |
*** rraja has joined #openstack-manila | 10:02 | |
*** tuanluong has quit IRC | 10:07 | |
*** jprovazn has quit IRC | 10:08 | |
openstackgerrit | Merged openstack/manila master: Add export-location filter in share and share instance list API https://review.openstack.org/461712 | 10:17 |
openstackgerrit | zhongjun proposed openstack/manila master: Add share usage size tracking https://review.openstack.org/465055 | 10:19 |
*** markstur has joined #openstack-manila | 10:29 | |
*** markstur has quit IRC | 10:33 | |
*** arnewiebalck_ has quit IRC | 10:40 | |
*** ganso has joined #openstack-manila | 10:48 | |
*** arnewiebalck_ has joined #openstack-manila | 10:56 | |
*** markstur has joined #openstack-manila | 11:05 | |
*** rodolof has quit IRC | 11:05 | |
*** arnewiebalck_ has quit IRC | 11:08 | |
*** markstur has quit IRC | 11:10 | |
*** chenying has quit IRC | 11:11 | |
*** chenying has joined #openstack-manila | 11:12 | |
openstackgerrit | Merged openstack/manila master: Updated from global requirements https://review.openstack.org/477952 | 11:17 |
*** gouthamr has quit IRC | 11:26 | |
*** rraja has quit IRC | 11:35 | |
openstackgerrit | Jan Provaznik proposed openstack/manila master: User Messages https://review.openstack.org/313549 | 11:46 |
openstackgerrit | Jan Provaznik proposed openstack/python-manilaclient master: Add commands for user messages https://review.openstack.org/429614 | 11:51 |
openstackgerrit | Jan Provaznik proposed openstack/manila master: Extend usage of user messages https://review.openstack.org/443101 | 11:57 |
openstackgerrit | Jan Provaznik proposed openstack/manila master: Add user messages periodic cleanup task https://review.openstack.org/474540 | 12:00 |
openstackgerrit | Jan Provaznik proposed openstack/manila master: Provide filter name in user messages https://review.openstack.org/443102 | 12:08 |
openstackgerrit | Jan Provaznik proposed openstack/manila master: User Messages https://review.openstack.org/313549 | 12:10 |
*** markstur has joined #openstack-manila | 12:17 | |
*** markstur has quit IRC | 12:22 | |
*** markstur has joined #openstack-manila | 12:53 | |
*** markstur has quit IRC | 12:58 | |
*** gcb has quit IRC | 13:07 | |
*** jmlowe has quit IRC | 13:41 | |
*** rraja has joined #openstack-manila | 13:58 | |
*** jmlowe has joined #openstack-manila | 14:02 | |
*** markstur has joined #openstack-manila | 14:05 | |
*** markstur has quit IRC | 14:09 | |
openstackgerrit | zhongjun proposed openstack/manila master: Add like filter https://review.openstack.org/462468 | 14:26 |
*** gouthamr has joined #openstack-manila | 14:26 | |
*** rraja has quit IRC | 14:40 | |
*** markstur has joined #openstack-manila | 14:41 | |
*** markstur has quit IRC | 14:46 | |
*** rodolof has joined #openstack-manila | 14:50 | |
*** markstur has joined #openstack-manila | 15:02 | |
*** FL1SK has quit IRC | 15:19 | |
*** lpetrut has quit IRC | 15:28 | |
*** rodolof has quit IRC | 15:47 | |
*** kaisers_ has quit IRC | 16:09 | |
*** kaisers_ has joined #openstack-manila | 16:09 | |
*** kaisers_ has quit IRC | 16:13 | |
*** kaisers_ has joined #openstack-manila | 16:32 | |
*** kaisers_ has quit IRC | 16:37 | |
*** kaisers_ has joined #openstack-manila | 16:47 | |
*** kaisers_ has quit IRC | 16:51 | |
*** kaisers_ has joined #openstack-manila | 17:42 | |
*** pcaruana has quit IRC | 17:42 | |
*** kaisers_ has quit IRC | 17:46 | |
openstackgerrit | Jan Provaznik proposed openstack/manila master: User Messages https://review.openstack.org/313549 | 18:01 |
*** markstur has quit IRC | 18:18 | |
*** lpetrut has joined #openstack-manila | 18:25 | |
*** rodolof has joined #openstack-manila | 18:27 | |
*** kaisers_ has joined #openstack-manila | 18:48 | |
*** kaisers_ has quit IRC | 18:50 | |
openstackgerrit | Merged openstack/manila master: NetApp cDOT: Add gateway information to create static routes https://review.openstack.org/478705 | 19:19 |
*** rodolof has quit IRC | 19:22 | |
*** david_1 has joined #openstack-manila | 19:29 | |
*** jmlowe has quit IRC | 19:46 | |
*** mkoderer_ has joined #openstack-manila | 19:53 | |
*** a-pugachev has joined #openstack-manila | 20:28 | |
*** lpetrut has quit IRC | 20:41 | |
*** markstur has joined #openstack-manila | 20:58 | |
*** a-pugachev has quit IRC | 21:29 | |
*** ganso has quit IRC | 22:23 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!