Thursday, 2017-07-27

*** jiaopengju has joined #openstack-manila00:39
*** harlowja has quit IRC01:19
*** cdelatte has quit IRC01:27
openstackgerritBen Swartzlander proposed openstack/manila master: Add NFSExportsHelper  https://review.openstack.org/47623901:54
*** cknight has joined #openstack-manila02:33
openstackgerritBen Swartzlander proposed openstack/manila master: Add NFSExportsHelper  https://review.openstack.org/47623902:48
*** cknight has quit IRC02:58
*** jiaohaolin has joined #openstack-manila03:04
*** jiaohaolin1 has quit IRC03:07
*** harlowja has joined #openstack-manila03:31
*** tuanluong has joined #openstack-manila03:51
*** hoonetorg has joined #openstack-manila04:26
*** gouthamr has quit IRC04:38
*** ganso has quit IRC04:49
*** harlowja has quit IRC04:52
*** arnewiebalck_ has joined #openstack-manila05:16
*** arnewiebalck_ has quit IRC05:22
*** dsariel has joined #openstack-manila06:18
openstackgerritzhongjun proposed openstack/manila master: Enable IPv6 in manila(network plugins and drivers)  https://review.openstack.org/40677607:17
openstackgerritzhongjun proposed openstack/manila master: Enable IPv6 in manila(network plugins and drivers)  https://review.openstack.org/40677607:24
openstackgerritzhongjun proposed openstack/python-manilaclient master: Enable IPv6 in manila(client)  https://review.openstack.org/32893207:44
*** rraja has joined #openstack-manila08:16
openstackgerritzhongjun proposed openstack/python-manilaclient master: Add export-location filter in share and share instance list  https://review.openstack.org/46827708:54
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient master: Add share group quotas  https://review.openstack.org/47348209:18
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient master: Add share group quotas  https://review.openstack.org/47348209:19
*** jiaopengju has quit IRC10:15
openstackgerritzhongjun proposed openstack/manila master: Enable IPv6 in manila(network plugins and drivers)  https://review.openstack.org/40677610:29
*** jiaopengju has joined #openstack-manila10:40
*** ganso has joined #openstack-manila10:46
openstackgerritzhongjun proposed openstack/python-manilaclient master: Add like filter  https://review.openstack.org/47442810:50
*** dsariel_ has joined #openstack-manila11:09
*** tuanluong has quit IRC11:47
*** abhi has quit IRC11:50
*** catintheroof has joined #openstack-manila12:11
*** dsariel_ has quit IRC12:27
*** dsariel has quit IRC12:28
*** dgonzalez_ has joined #openstack-manila12:40
*** seife_ has joined #openstack-manila12:40
*** seife_ has quit IRC12:41
*** dgonzalez_ has quit IRC12:41
*** dsariel has joined #openstack-manila12:47
openstackgerritRaissa Sarmento proposed openstack/manila master: DNM Use tempest-plugin service client registration  https://review.openstack.org/33459612:48
openstackgerritzhongjun proposed openstack/python-manilaclient master: Add like filter  https://review.openstack.org/47442812:50
*** jiaopengju has quit IRC12:55
*** jiaopengju has joined #openstack-manila12:56
*** gcb has quit IRC13:02
*** gcb has joined #openstack-manila13:04
openstackgerritMerged openstack/python-manilaclient master: Add share group quotas  https://review.openstack.org/47348213:06
*** eharney has joined #openstack-manila13:28
bswartzwho remembers the command to run unit tests with py3?13:30
*** dustins has joined #openstack-manila13:32
*** gouthamr has joined #openstack-manila13:32
*** dustins has quit IRC13:34
tbarronbswartz: tox -epy3513:34
*** dustins has joined #openstack-manila13:34
bswartztbarron: ty13:35
bswartzI just realized that our devstack plugin doesn't really allow multiple share drivers at the same time13:35
tbarronbswartz: I've tricked it into doing lvm plus cephfs/nfs but that can work b/c there's and extra plugin for the cephfs stuff13:37
bswartzwhich plugin?13:37
tbarronbswartz: even then I think I have to massage manila.conf afterwards13:37
bswartzI know devstack has actual plugins for cinder drivers13:38
bswartzbut not for manila13:38
tbarronbswartz: local.conf has 'enable_plugin manila ...' followed by 'enable_plugin_ceph' ...13:39
bswartzright13:39
bswartzwell if I'm going to need to massage the config I may as well just do everything in that step13:39
*** cknight has joined #openstack-manila13:41
tbarronbswartz: yeah but for lvm and ceph there are some things that need to be done before manila.conf - backing file stuff - for other backend combos you can probably just use lvm style local.conf and then massage manila.conf13:41
tbarronso I need both plugins but with a netapp plus lvm you wouldn't13:42
bswartzthe manila devstack plugin will do the backing file for you if you select LVM13:42
bswartzMy current goal is LVM+Generic13:42
tbarronright, so I do that, but I also need a backing file/xfs/ceph OSD thing13:42
tbarronso I have to use two plugins13:43
bswartzoh ceph has it's own goofy backing file mechanism?13:43
tbarronfor generic just do LVM and massage manila.conf13:43
tbarronyeah, ceph has to run OSDs which require "disk drives"13:43
bswartzsomehow I thought ceph was able to use the local filesystem13:44
bswartzI guess if xfs is required then you need a loopback13:44
bswartztox -epy35 is failing with 'db type could not be determined'13:47
openstackgerritBen Swartzlander proposed openstack/manila master: Add NFSExportsHelper  https://review.openstack.org/47623913:50
tbarronbswartz: 'rm -rf .testrepository' first; onetime operation13:53
*** dustins has quit IRC13:53
tbarronbswartz: after that both 'tox -e py35' and 'tox -e py27' will work13:53
tbarronbswartz: or just 'tox' which will run both13:54
bswartzinteresting13:54
tbarronbswartz: you have a py27-compatible-only test DB13:54
bswartzI think I've stumbled across this before13:54
bswartzI wish we would stop supporting both py2 and py313:55
bswartzthe transition is interminable13:55
tbarronIf you switch from runtests.sh to 'tox' you don't hit this b/c tox.ini is set up to run py35 first13:56
bswartzI _like_ runtests though13:56
*** dustins has joined #openstack-manila13:56
openstackgerritzhongjun proposed openstack/python-manilaclient master: Add export-location filter in share and share instance list  https://review.openstack.org/46827714:06
tbarronbswartz: update it to run python3 and convince the rest of the open stack development world to go back to it then14:08
tbarronI _like_ steam power.14:08
*** xyang_ has joined #openstack-manila14:17
openstackgerritzhongjun proposed openstack/manila master: Change ensure share to make startup faster  https://review.openstack.org/45754514:32
*** kaisers_ has joined #openstack-manila14:41
*** jiaopengju has quit IRC15:03
gouthamrvponomaryov: does this have to be rebased: https://review.openstack.org/#/c/468899/ django errors..15:05
vponomaryovgouthamr: not rebased, reworked, it does not work with django1.1115:05
vponomaryovgouthamr: it works with django 1.10 and 1.915:05
gouthamrouch..15:06
vponomaryovgouthamr: try to run test commit15:06
vponomaryovgouthamr: it should be broken in general15:06
vponomaryovnot that commit15:06
openstackgerritGoutham Pacha Ravi proposed openstack/manila-ui master: Do not merge, yes, you.  https://review.openstack.org/48790015:08
gansogouthamr: lol15:08
gouthamr:P15:08
openstackgerritMerged openstack/manila master: Enable IPv6 in manila(network plugins and drivers)  https://review.openstack.org/40677615:53
gouthamr^ wow15:53
gouthamr#success: started on the journey for total ipv6 support in OpenStack/Manila. Great job zhongjun15:54
openstackstatusgouthamr: Added success to Success page15:54
gouthamrand bswartz, as always :)15:54
gouthamrwe need to start tagging more successes, eh openstackstatus15:56
bswartz#winning15:56
*** arnewiebalck_ has joined #openstack-manila16:11
openstackgerritMerged openstack/python-manilaclient master: Add export-location filter in share and share instance list  https://review.openstack.org/46827716:16
openstackgerritRaissa Sarmento proposed openstack/manila master: DNM Use tempest-plugin service client registration  https://review.openstack.org/33459616:22
*** kaisers_ has quit IRC16:29
*** kaisers_ has joined #openstack-manila16:29
*** kaisers_ has quit IRC16:34
*** arnewiebalck_ has quit IRC16:42
*** kaisers_ has joined #openstack-manila16:54
*** zengyingzhe has quit IRC17:01
*** zengyingzhe has joined #openstack-manila17:01
bswartzvponomaryov: https://review.openstack.org/#/c/487900/ passed jenkins17:04
bswartzso there's something about your change that's specifically incompatible with dj11117:04
vponomaryovbswartz: actually, I sad it during meeting ))17:05
vponomaryovbswartz: and already have fix17:05
vponomaryovrerunning tox jobs locally17:05
vponomaryovand will upload if it is ok17:06
vponomaryovs/sad/said/17:06
vponomaryovit is related to one specific place that we have only in this new commit17:06
*** harlowja has joined #openstack-manila17:09
openstackgerritValeriy Ponomaryov proposed openstack/manila-ui master: Add support of share groups  https://review.openstack.org/46889917:11
vponomaryovbswartz, tbarron, xyang_: I expect it to work ^17:12
vponomaryovit passed -> http://logs.openstack.org/99/468899/19/check/gate-manila-ui-python27-ubuntu-xenial/7ac0b07/console.html#_2017-07-27_17_16_31_80298617:18
vponomaryovgouthamr, bswartz, tbarron, xyang_ ^17:19
*** rraja has quit IRC17:19
vponomaryovfull list of running set of jobs can be viewed here: http://status.openstack.org/zuul/17:19
gouthamrnice.. the diff is removing use of ChoiceFieldRenderer. that's pretty neat.17:23
bswartzvponomaryov: ack17:25
gouthamrbswartz: https://review.openstack.org/#/c/328932 https://review.openstack.org/#/c/474428/17:26
openstackgerritBen Swartzlander proposed openstack/python-manilaclient master: Enable IPv6 in manila(client)  https://review.openstack.org/32893217:29
bswartz^ this might fail flake817:29
* bswartz waits for it....17:30
bswartzoh whew17:30
bswartzno problems17:30
openstackgerritTom Barron proposed openstack/python-manilaclient master: Add like filter  https://review.openstack.org/47442817:38
tbarrongouthamr: bswartz rebased & release notes tweaked ^^^17:38
tbarrongouthamr: bswartz since I hope zhongjun is getting some sleep17:39
*** dsariel has quit IRC17:43
bswartztbarron: doh!17:45
bswartzI was working on the same patch17:46
bswartzthanks for getting it done!17:46
tbarronbswartz: oh sorry, should have synced with you17:46
tbarronfeel free to push yours over it if there's any difference17:46
gouthamrtbarron: https://review.openstack.org/#/c/474428/17..18/manilaclient/tests/functional/test_shares_listing.py17:47
gouthamrtbarron: what do you think of that assert?17:47
gouthamrs/that assert/those asserts17:47
tbarrongouthamr: oh, I missed those remarks of yours17:48
tbarronexact numbers would be better17:48
tbarronbswartz: you want it or me ^^^17:48
tbarrongouthamr: w.r.t. the second remark it is already an assertEqual now17:51
tbarrongouthamr: I am making the first one assertEqual(3, len(shares))17:52
openstackgerritTom Barron proposed openstack/python-manilaclient master: Add like filter  https://review.openstack.org/47442817:53
*** xyang_ has quit IRC18:15
*** xyang_ has joined #openstack-manila18:17
*** xyang_ has quit IRC18:18
bswartztbarron: sorry, ppl in my office18:19
bswartzlooking now18:19
gouthamrs/pplgouthamr18:19
tbarronbswartz: good ppl18:19
bswartzand chad18:20
bswartzalthough I don't think he's in this channel18:20
gouthamrsome people are scared of irc, it bites18:20
bswartzI'm scared of Slack18:22
bswartztbarron: I found a bug18:22
tbarronbswartz: why don't you just fix it then, my trivial changes shouldn't disqualify me from reviewing it18:23
bswartztbarron: did you have anything else to push or are you done?18:24
bswartzdid you address gouthamr's feedback or do I still need to do that18:24
tbarronbswartz: I don't have anything else.  gouthamr's feedback is addressed IMO18:25
openstackgerritBen Swartzlander proposed openstack/python-manilaclient master: Add like filter  https://review.openstack.org/47442818:26
gouthamrokay, looks like the number of people that can approve this change keeps going down :P18:26
bswartzgouthamr: no you can still approve it as long as you're not a co-author18:27
bswartzbeing a committer doesn't automatically disqualify you18:27
*** jmlowe has quit IRC18:28
tbarronbswartz: i introduced that bug resolving the merge conflict18:28
openstackgerritMerged openstack/manila-ui master: Add support of share groups  https://review.openstack.org/46889918:28
tbarroni think we can tell the difference between just a committer and a genuine co-author who just didn't add 'Co-authored by'18:29
tbarronDoes it pass the sniff test: if you added 'Co-authored by' for just rebasing, for example, that would smell wrong.18:29
tbarronyou are just a committer.18:30
tbarronsame for fixing an obvious minimal bug while the author is sleeping, etc.18:30
tbarronIf we see teams of people working together to push stuff through by making a real contributing author a reviewer, that would be one thing and maybe we'd need to be more rigid, but I haven't seen any signs of that, even from netapp.18:31
tbarron:)18:31
bswartzit kind of annoys me that gerrit adds the notion of an "owner" into all of this18:40
*** arnewiebalck_ has joined #openstack-manila18:40
bswartzdoes having an owner defined differently from the author/committer add any value?18:40
gouthamrowner is just a gerrit thing, makes it easier to find stuff18:46
bswartzwhen the owner and the author diverges though (which can happen) it becomes confusing and you can't fix it18:47
gouthamryes, unless you change the Change ID and make a new change altogether..18:48
gouthamrwhich is probably what gerrit wanted..18:49
gouthamrthe internal database stuff has gotten more and more complex over releases18:49
openstackgerritBen Swartzlander proposed openstack/python-manilaclient master: Enable IPv6 in manila(client)  https://review.openstack.org/32893218:49
bswartzthat's what databases do18:50
bswartzI've never seen a database get simpler over time18:50
gouthamrsure, but the fact that there's no easy way to migrate is horrible maintenance burden18:51
bswartzthat's just contempt for users18:52
bswartzprobably related to the fact that gerrit isn't a product you can buy or get paid support for18:53
*** zengyingzhe has quit IRC18:53
*** zengyingzhe has joined #openstack-manila18:53
gouthamrbswartz: true..18:53
*** jmlowe has joined #openstack-manila18:57
*** arnewiebalck_ has quit IRC19:08
*** xyang_ has joined #openstack-manila19:08
*** xyang_ has quit IRC19:09
openstackgerritOpenStack Proposal Bot proposed openstack/manila master: Updated from global requirements  https://review.openstack.org/48801219:11
*** xyang1 has joined #openstack-manila19:12
*** xyang_ has joined #openstack-manila19:17
openstackgerritOpenStack Proposal Bot proposed openstack/python-manilaclient master: Updated from global requirements  https://review.openstack.org/48812119:21
openstackgerritBen Swartzlander proposed openstack/manila master: Add NFSExportsHelper  https://review.openstack.org/47623919:22
*** arnewiebalck_ has joined #openstack-manila19:24
*** eharney_ has joined #openstack-manila19:24
*** eharney has quit IRC19:25
*** eharney_ is now known as eharney19:25
*** xyang_ has quit IRC19:26
*** xyang_ has joined #openstack-manila19:26
*** eharney has quit IRC19:30
gouthamr 3 != 819:32
gouthamr:O19:32
*** xyang_ has quit IRC20:01
*** xyang_ has joined #openstack-manila20:01
openstackgerritOpenStack Proposal Bot proposed openstack/manila master: Updated from global requirements  https://review.openstack.org/48801220:05
*** eharney has joined #openstack-manila20:13
*** xyang_ has quit IRC20:19
*** xyang1 has quit IRC20:21
*** jmlowe has quit IRC20:27
*** xyang_ has joined #openstack-manila20:27
tbarrongouthamr: i'm jumping back and forth between this and other stuff and am not seeing right off where the eight shares20:30
*** eharney has quit IRC20:30
tbarronwith name starting with 'name' and description starting with 'description' are getting created.20:31
tbarrongouthamr: probably I don't understand these functional tests.20:31
tbarrongouthamr: atm I'm not qualified to s/3/8/ b/c i'm blind20:32
tbarrongouthamr: I see three shares getting created in the setUpClass but they have random names anyways20:33
*** xyang_ has quit IRC20:33
gouthamrtbarron: i suspect it is test concurrency with other tests..20:34
bswartztbarron: https://review.openstack.org/#/c/328932/ you keep +1 this but never +220:34
gouthamrwill test this change locally20:35
tbarrongouthamr: but how was this test supposed to work anyways since the pattern doesn't match20:35
tbarronbswartz: I'll go on and +2 b/c I don't see anything wrong20:35
tbarronbswartz: but jenkins may be finding a legit issue, I dunno.20:36
tbarronbswartz: +2ed20:36
bswartztbarron: there might be a legit issue20:36
bswartzit was a timeout in a waiter related to access rules20:37
tbarronbswartz: generally I'm brave about doing +2 rather than "waiting for jenkins"20:37
bswartzbut the bug would be on the server in that case20:37
*** arnewiebalck_ has quit IRC20:37
tbarronfiguring if jenkins finds something I don't, so what?20:37
tbarronbut I'm a bit more cautious at release time, don't want something to get released if we have indeterministic failure and we don't track it down20:38
bswartztbarron: well the issue today is that I have to push a tag and this either merges before the tag or it doesn't20:38
tbarronbswartz: ack and I'll go with it20:38
bswartzif it doesn't then we have to do a FFE thing and it's annoying20:39
tbarronbswartz: but the cost may be that we have an indeterministic bug.20:39
bswartzI'm sure we'll have time to get to the bottom of the problem if there really is one20:39
bswartzat this point it looks like both the like filter and the ipv6 client patches won't make it20:40
tbarronjust b/c it's a client side change that exposes it and we know it's server side doesn't in general (in ideal world w/o pragmatic tradeoffs at release time) mean we should merge20:40
bswartzwe need jenkins to cooperate though20:40
*** xyang1 has joined #openstack-manila20:41
tbarronbswartz: yeah, well as gouthamr pointed out the filter functional tests may be indeterministic b/c of concurrency issues.20:41
*** xyang_ has joined #openstack-manila20:41
tbarronwhen we changed a > count_of_shares test to an exact equality we see failures20:42
tbarronand those > count checks are in lots of the existing code in that test suite, old code20:42
bswartztbarron: yes that change was not an improvement20:42
* tbarron tells himself not to get depressed20:42
bswartzI suspect that the tests are just badly written and nobody has spend time to make then good20:42
tbarronbswartz: well it is an improvement in our knowledge, we know that there's a more general issue and indeterminism there with concurrency20:43
tbarronit's not indeterminism that affects our functional code though so far as I can tell20:43
bswartzyes but we've known that for years and still done nothing about it20:43
tbarronjust our functional test apparatus20:43
bswartzif there is any nondeterminism in the test fixture, then the text fixture is at fault20:44
tbarronbswartz: gouthamr so should we just push that change again with the assertGreaterThan20:44
gouthamrtbarron: i used assertGreaterEqual20:44
bswartzI'd prefer that we leave those the way zhongjun wrote them20:44
tbarronmaking it assertEqual(8, len(shares)) is just black magic20:44
tbarrongouthamr: that's what I meant20:45
bswartzit seems like her test code was no worse than what existed before20:45
tbarronack20:45
*** xyang_ has quit IRC20:50
*** cknight has quit IRC20:51
*** xyang_ has joined #openstack-manila20:51
gouthamrbswartz tbarron: https://bugs.launchpad.net/manila/+bug/170706621:03
openstackLaunchpad bug 1707066 in Manila "Can't deny ipv6 access rule" [Critical,New]21:03
tbarrongouthamr: bswartz so we fix that in m4, right?21:07
tbarronoh, the bug is from the functional tests21:10
tbarronbut the fix will have to be in manila, which is out the door21:11
tbarronso skip the test with the BZ#?21:12
gouthamrtbarron: yes21:13
tbarrons/m4/P-4/  (I used downstream term)21:14
openstackgerritGoutham Pacha Ravi proposed openstack/python-manilaclient master: Enable IPv6 in manila(client)  https://review.openstack.org/32893221:14
gouthamr think that should work, will test it locally ^21:14
tbarronnice to have some content for bug swat day21:16
openstackgerritGoutham Pacha Ravi proposed openstack/python-manilaclient master: Add like filter  https://review.openstack.org/47442821:39
gansogouthamr: reno job broken? https://review.openstack.org/#/c/488012/21:51
gouthamrganso: recheck, bug_1564623_change-e286060a27b02f64.yaml was fixed a long time ago..21:52
gouthamrthis happens sometimes, we haven't gotten to the bottom of it21:52
gansogouthamr: oh21:52
*** xyang_ has quit IRC21:57
*** xyang_ has joined #openstack-manila21:58
*** xyang_ has quit IRC22:01
*** gouthamr has quit IRC22:10
*** gouthamr_ has joined #openstack-manila22:11
*** jiaohaolin1 has joined #openstack-manila22:11
*** jiaohaolin has quit IRC22:13
openstackgerritGoutham Pacha Ravi proposed openstack/python-manilaclient master: Enable IPv6 in manila(client)  https://review.openstack.org/32893222:25
*** catintheroof has quit IRC22:27
*** gouthamr_ has quit IRC22:37
*** openstack has joined #openstack-manila22:45
openstackgerritMerged openstack/python-manilaclient master: Updated from global requirements  https://review.openstack.org/48812122:46
*** gouthamr has joined #openstack-manila22:53
*** xyang1 has quit IRC23:00
openstackgerritMerged openstack/python-manilaclient master: Add like filter  https://review.openstack.org/47442823:32
*** catintheroof has joined #openstack-manila23:52

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!