| *** markstur has quit IRC | 00:00 | |
| *** jmlowe has joined #openstack-manila | 00:00 | |
| *** markstur has joined #openstack-manila | 00:04 | |
| *** jmlowe has quit IRC | 00:05 | |
| *** markstur has quit IRC | 00:09 | |
| *** ociuhandu has joined #openstack-manila | 00:55 | |
| *** ociuhandu has quit IRC | 01:21 | |
| *** gouthamr has joined #openstack-manila | 01:21 | |
| *** toabctl has quit IRC | 01:22 | |
| *** jungleboyj has quit IRC | 01:22 | |
| *** gouthamr has quit IRC | 01:22 | |
| *** masber has quit IRC | 01:22 | |
| *** tommylikehu has quit IRC | 01:22 | |
| *** harlowja has quit IRC | 01:22 | |
| *** guyr-infinidat has quit IRC | 01:22 | |
| *** zhongjun has quit IRC | 01:22 | |
| *** chenying has quit IRC | 01:22 | |
| *** EmilienM has quit IRC | 01:22 | |
| *** dgonzalez has quit IRC | 01:22 | |
| *** tbarron has quit IRC | 01:22 | |
| *** raissa has quit IRC | 01:22 | |
| *** openstackgerrit has quit IRC | 01:22 | |
| *** dims has quit IRC | 01:22 | |
| *** ameade has quit IRC | 01:22 | |
| *** logan- has quit IRC | 01:22 | |
| *** DuncanT has quit IRC | 01:22 | |
| *** yuval has quit IRC | 01:22 | |
| *** ChanServ has quit IRC | 01:22 | |
| *** vivsoni has quit IRC | 01:22 | |
| *** gcb has quit IRC | 01:22 | |
| *** kaisers has quit IRC | 01:22 | |
| *** batrick has quit IRC | 01:22 | |
| *** kambiz has quit IRC | 01:22 | |
| *** cFouts has quit IRC | 01:22 | |
| *** MikeG451 has quit IRC | 01:22 | |
| *** zengyingzhe has quit IRC | 01:22 | |
| *** zigo has quit IRC | 01:22 | |
| *** sapcc-bot2 has quit IRC | 01:22 | |
| *** cfey has quit IRC | 01:22 | |
| *** cargonza has quit IRC | 01:22 | |
| *** hoonetorg has quit IRC | 01:22 | |
| *** arnewiebalck has quit IRC | 01:22 | |
| *** aspiers[m] has quit IRC | 01:22 | |
| *** tinwood has quit IRC | 01:22 | |
| *** vkmc has quit IRC | 01:22 | |
| *** amito-infinidat has quit IRC | 01:22 | |
| *** andreaf has quit IRC | 01:22 | |
| *** Reepicheep has quit IRC | 01:22 | |
| *** wes_dillingham has quit IRC | 01:22 | |
| *** threestrands has quit IRC | 01:22 | |
| *** eharney has quit IRC | 01:22 | |
| *** bswartz has quit IRC | 01:22 | |
| *** cyberde has quit IRC | 01:22 | |
| *** gregsfortytwo has quit IRC | 01:22 | |
| *** rhagarty has quit IRC | 01:22 | |
| *** kfox1111 has quit IRC | 01:22 | |
| *** gouthamr has joined #openstack-manila | 01:28 | |
| *** masber has joined #openstack-manila | 01:28 | |
| *** wes_dillingham has joined #openstack-manila | 01:28 | |
| *** threestrands has joined #openstack-manila | 01:28 | |
| *** eharney has joined #openstack-manila | 01:28 | |
| *** raissa has joined #openstack-manila | 01:28 | |
| *** hoonetorg has joined #openstack-manila | 01:28 | |
| *** arnewiebalck has joined #openstack-manila | 01:28 | |
| *** zigo has joined #openstack-manila | 01:28 | |
| *** sapcc-bot2 has joined #openstack-manila | 01:28 | |
| *** zengyingzhe has joined #openstack-manila | 01:28 | |
| *** vivsoni has joined #openstack-manila | 01:28 | |
| *** gcb has joined #openstack-manila | 01:28 | |
| *** aspiers[m] has joined #openstack-manila | 01:28 | |
| *** tommylikehu has joined #openstack-manila | 01:28 | |
| *** bswartz has joined #openstack-manila | 01:28 | |
| *** cfey has joined #openstack-manila | 01:28 | |
| *** chenying has joined #openstack-manila | 01:28 | |
| *** EmilienM has joined #openstack-manila | 01:28 | |
| *** openstackgerrit has joined #openstack-manila | 01:28 | |
| *** toabctl has joined #openstack-manila | 01:28 | |
| *** jungleboyj has joined #openstack-manila | 01:28 | |
| *** dims has joined #openstack-manila | 01:28 | |
| *** harlowja has joined #openstack-manila | 01:28 | |
| *** ameade has joined #openstack-manila | 01:28 | |
| *** guyr-infinidat has joined #openstack-manila | 01:28 | |
| *** cyberde has joined #openstack-manila | 01:28 | |
| *** tinwood has joined #openstack-manila | 01:28 | |
| *** vkmc has joined #openstack-manila | 01:28 | |
| *** kaisers has joined #openstack-manila | 01:28 | |
| *** batrick has joined #openstack-manila | 01:28 | |
| *** logan- has joined #openstack-manila | 01:28 | |
| *** kambiz has joined #openstack-manila | 01:28 | |
| *** DuncanT has joined #openstack-manila | 01:28 | |
| *** Guest18637 has joined #openstack-manila | 01:28 | |
| *** zhongjun has joined #openstack-manila | 01:28 | |
| *** cargonza has joined #openstack-manila | 01:28 | |
| *** MikeG451 has joined #openstack-manila | 01:28 | |
| *** yuval has joined #openstack-manila | 01:28 | |
| *** dgonzalez has joined #openstack-manila | 01:28 | |
| *** gregsfortytwo has joined #openstack-manila | 01:28 | |
| *** tbarron has joined #openstack-manila | 01:28 | |
| *** amito-infinidat has joined #openstack-manila | 01:28 | |
| *** rhagarty has joined #openstack-manila | 01:28 | |
| *** kfox1111 has joined #openstack-manila | 01:28 | |
| *** andreaf has joined #openstack-manila | 01:28 | |
| *** Reepicheep has joined #openstack-manila | 01:28 | |
| *** ChanServ has joined #openstack-manila | 01:28 | |
| *** barjavel.freenode.net sets mode: +o ChanServ | 01:28 | |
| *** ianychoi has joined #openstack-manila | 02:24 | |
| *** junboli has joined #openstack-manila | 02:49 | |
| *** jiaopengju has joined #openstack-manila | 03:09 | |
| *** AlexeyAbashkin has joined #openstack-manila | 03:21 | |
| *** AlexeyAbashkin has quit IRC | 03:25 | |
| *** gcb has quit IRC | 03:58 | |
| *** gcb has joined #openstack-manila | 03:59 | |
| *** gcb has quit IRC | 04:04 | |
| *** gcb has joined #openstack-manila | 04:04 | |
| openstackgerrit | Merged openstack/python-manilaclient master: Updated from global requirements https://review.openstack.org/519804 | 04:15 |
|---|---|---|
| *** junboli has quit IRC | 04:20 | |
| *** wes_dillingham has quit IRC | 04:22 | |
| openstackgerrit | zhongjun proposed openstack/manila master: [policy in code] Add support for share instance export location resource https://review.openstack.org/507054 | 04:39 |
| *** gouthamr has quit IRC | 05:31 | |
| *** junboli has joined #openstack-manila | 05:40 | |
| openstackgerrit | Akihiro Motoki proposed openstack/manila-ui master: Drop django_openstack_auth from requirements.txt https://review.openstack.org/520310 | 06:33 |
| *** dsariel has joined #openstack-manila | 06:40 | |
| *** vivsoni has quit IRC | 07:10 | |
| *** vivsoni has joined #openstack-manila | 07:10 | |
| *** hoonetorg has quit IRC | 07:14 | |
| *** jprovazn has joined #openstack-manila | 07:19 | |
| *** lpetrut_ has joined #openstack-manila | 07:22 | |
| openstackgerrit | Arne Wiebalck proposed openstack/puppet-manila master: Fix typos: Remove "native" from cephfs backend driver https://review.openstack.org/519655 | 07:25 |
| *** threestrands has quit IRC | 07:30 | |
| *** hoonetorg has joined #openstack-manila | 07:31 | |
| *** lpetrut_ has quit IRC | 07:59 | |
| *** lpetrut_ has joined #openstack-manila | 08:12 | |
| *** pcaruana has joined #openstack-manila | 08:14 | |
| *** jmlowe has joined #openstack-manila | 08:24 | |
| *** pcaruana has quit IRC | 08:28 | |
| *** AlexeyAbashkin has joined #openstack-manila | 08:29 | |
| *** pcaruana has joined #openstack-manila | 08:32 | |
| *** lpetrut_ has quit IRC | 08:41 | |
| *** gcb has quit IRC | 08:54 | |
| *** masber has quit IRC | 09:03 | |
| *** jmlowe has quit IRC | 09:07 | |
| *** a-pugachev has joined #openstack-manila | 09:23 | |
| *** ganso has joined #openstack-manila | 09:51 | |
| *** lpetrut_ has joined #openstack-manila | 10:03 | |
| *** jiaopengju has quit IRC | 10:05 | |
| *** ociuhandu has joined #openstack-manila | 10:10 | |
| *** ociuhandu has quit IRC | 10:10 | |
| *** gcb has joined #openstack-manila | 10:18 | |
| *** jprovazn has quit IRC | 10:23 | |
| *** jprovazn has joined #openstack-manila | 10:23 | |
| *** jprovazn has quit IRC | 10:24 | |
| *** erlon has joined #openstack-manila | 10:28 | |
| *** vivsoni has quit IRC | 10:47 | |
| *** vivsoni has joined #openstack-manila | 10:55 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila master: Updated from global requirements https://review.openstack.org/520426 | 11:09 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila-ui master: Updated from global requirements https://review.openstack.org/520427 | 11:09 |
| *** vivsoni has quit IRC | 12:02 | |
| *** jiaopengju has joined #openstack-manila | 12:03 | |
| *** jprovazn has joined #openstack-manila | 12:03 | |
| *** toabctl has quit IRC | 12:11 | |
| openstackgerrit | Merged openstack/manila master: Updated from global requirements https://review.openstack.org/520426 | 12:36 |
| *** vivsoni has joined #openstack-manila | 12:47 | |
| *** vivsoni has quit IRC | 12:49 | |
| *** vivsoni has joined #openstack-manila | 12:50 | |
| *** dsariel has quit IRC | 12:53 | |
| *** vivsoni has quit IRC | 12:57 | |
| *** junboli has quit IRC | 13:03 | |
| *** dustins has joined #openstack-manila | 13:12 | |
| *** dustins has quit IRC | 13:20 | |
| *** dsariel has joined #openstack-manila | 13:37 | |
| *** belmoreira has joined #openstack-manila | 13:46 | |
| *** wes_dillingham has joined #openstack-manila | 14:10 | |
| *** dustins has joined #openstack-manila | 14:17 | |
| *** wes_dillingham has quit IRC | 14:20 | |
| *** eharney has quit IRC | 14:25 | |
| *** belmoreira has quit IRC | 14:26 | |
| *** dsariel has quit IRC | 14:34 | |
| *** jiaopengju has quit IRC | 14:38 | |
| *** jiaopengju has joined #openstack-manila | 14:38 | |
| *** gouthamr has joined #openstack-manila | 14:39 | |
| *** jiaopengju has quit IRC | 14:43 | |
| *** dsariel has joined #openstack-manila | 15:19 | |
| *** eharney has joined #openstack-manila | 15:24 | |
| *** markstur has joined #openstack-manila | 15:26 | |
| openstackgerrit | Merged openstack/manila-ui master: Updated from global requirements https://review.openstack.org/520427 | 15:34 |
| ganso | are we going to continue topics or IPv6 discussion over here? | 16:01 |
| bswartz | ganso: do you want to push a patch that changes the check in driver.py? | 16:01 |
| ganso | bswartz: I am trying to grasp a better idea of how that patch should look like | 16:01 |
| bswartz | have you looked at exactly what the (theoretically) correct check would be? | 16:01 |
| bswartz | gmm | 16:01 |
| bswartz | hmm | 16:02 |
| ganso | bswartz: based on our discussion, one possible conclusion is that the driver needs to return the 'ipv6_support' field in the capabilities dict | 16:02 |
| bswartz | Give me a bit to think about why it might make sense to have separate assertions about ipv4/ipv6 support in update_share_stats() vs get_configed_ip_version() | 16:02 |
| bswartz | ganso: today that's true, but I don't see why the ShareDriver class can't simply insert that value itself | 16:03 |
| *** openstackgerrit has quit IRC | 16:03 | |
| ganso | bswartz: thinking about it, yea we could redesign that logic. It seems to me the driver has 2 sole responsibilities: 1) report if ipv6 is implemented. This could be a static ipv6_implemented = True. The other should be if ipv6 is active for the current network configuration | 16:03 |
| bswartz | the real question is: is there ANY valid reason to have ipv4/ipv6_support NOT match the values returned by get_configed_ip_version() | 16:03 |
| bswartz | if yes, then the code stays the way it is | 16:04 |
| bswartz | if not, then we should change it | 16:04 |
| bswartz | ganso, zhongjun: ^ | 16:04 |
| ganso | get_configured_ip_version should return the realtime value, so there is no need for returning it in capabilities. | 16:05 |
| ganso | For everything else it should look at driver.ipv6_implemented | 16:05 |
| ganso | currently manila core code is looking at 3 flags, not 2 | 16:05 |
| bswartz | whether we call get_configured_ip_version() one time or every 60 seconds is another issue I think | 16:13 |
| *** pcaruana has quit IRC | 16:13 | |
| bswartz | the main question is if there's a good reason to tell the scheduler something different than what the driver tells the share manager | 16:13 |
| *** markstur has quit IRC | 16:15 | |
| *** markstur has joined #openstack-manila | 16:21 | |
| *** wes_dillingham has joined #openstack-manila | 16:23 | |
| *** AlexeyAbashkin has quit IRC | 16:32 | |
| *** rraja has joined #openstack-manila | 16:44 | |
| *** jmlowe has joined #openstack-manila | 16:59 | |
| *** ianychoi has quit IRC | 17:02 | |
| *** ianychoi has joined #openstack-manila | 17:03 | |
| *** jmlowe has quit IRC | 17:08 | |
| *** jmlowe has joined #openstack-manila | 17:30 | |
| *** a-pugachev has quit IRC | 17:31 | |
| *** jmlowe has quit IRC | 17:35 | |
| bswartz | https://github.com/openstack/manila/blob/master/manila/share/drivers/lvm.py#L173 | 17:35 |
| bswartz | https://github.com/openstack/manila/blob/master/manila/share/drivers/lvm.py#L219 | 17:35 |
| bswartz | https://github.com/openstack/manila/blob/master/manila/share/drivers/lvm.py#L435 | 17:35 |
| bswartz | gouthamr: ^ | 17:35 |
| bswartz | that's what ganso is referring to when he says 3 | 17:35 |
| gouthamr | bswartz: so line L219 can, instead of defaulting to True, call get_configured_ip_version | 17:36 |
| gouthamr | bswartz: probably just once and remember the result | 17:36 |
| bswartz | gouthamr: yes but the parent class should do that | 17:36 |
| bswartz | not every driver | 17:36 |
| gouthamr | yes, that would be a good optimization in driver.py | 17:40 |
| ganso | bswartz, gouthamr: anyone against calling get_configured_ip_version on every capabilities update? | 17:48 |
| *** openstackgerrit has joined #openstack-manila | 17:49 | |
| openstackgerrit | Raissa Sarmento proposed openstack/manila master: [wip] Remove in-tree tempest plugin https://review.openstack.org/512300 | 17:49 |
| gouthamr | ganso: i'd agree with calling it in driver.py during _update_share_stats() (calling a memoized version for optimization) | 17:50 |
| bswartz | ganso: we should look at the existing implementations of that method and make sure none of them are particularly inefficient | 17:50 |
| gouthamr | and fixing the LVM driver so it doesn't do the wrong thing by overriding that to True | 17:50 |
| bswartz | it could be that a driver assumes it can be slow because it's called just once | 17:50 |
| ganso | gouthamr: what if the backend configuration changes without a driver restart? are we at all interested in covering this use case? | 17:52 |
| *** markstur has quit IRC | 17:54 | |
| gouthamr | ganso: that use case is not very much different from someone changing export IP addresses on the backend and not reconciling that in manila | 17:54 |
| ganso | gouthamr: so we don't need runtime values. If we don't care about that, then we can just simplify the function in driver.py. That function already memoizes the result | 17:55 |
| bswartz | it's tough because something bad will always happen if you add/remove IPs from a backend with existing shares | 17:55 |
| bswartz | adding IPs is less bad than removing them or changing them | 17:55 |
| *** markstur has joined #openstack-manila | 17:55 | |
| *** markstur has quit IRC | 17:55 | |
| bswartz | I think our stance in the past has generally been: you can never remove/change an IP without deleting all the shares first or hacking the database to fix up the existing shares | 17:56 |
| bswartz | and adding an IP is okay if you restart the backend | 17:56 |
| *** jmlowe has joined #openstack-manila | 17:56 | |
| *** gouthamr has quit IRC | 17:58 | |
| *** gouthamr has joined #openstack-manila | 17:59 | |
| *** jmlowe has quit IRC | 18:01 | |
| *** markstur has joined #openstack-manila | 18:09 | |
| *** markstur has quit IRC | 18:14 | |
| *** eharney has quit IRC | 18:39 | |
| *** LobsterRoll has joined #openstack-manila | 18:59 | |
| *** lpetrut_ has quit IRC | 19:00 | |
| *** wes_dillingham has quit IRC | 19:01 | |
| *** LobsterRoll is now known as wes_dillingham | 19:01 | |
| *** rraja has quit IRC | 19:04 | |
| dustins | gouthamr: ping | 19:13 |
| openstackgerrit | Andreas Jaeger proposed openstack/manila-ui master: Remove setting of version/release from releasenotes https://review.openstack.org/520696 | 19:18 |
| gouthamr | dustins: pong | 19:25 |
| dustins | gouthamr: Welcome back :) Quick question about setting API microversion with the Manila client | 19:25 |
| gouthamr | dustins: thanks... yep, wassup | 19:26 |
| dustins | gouthamr: How do I do that? | 19:26 |
| dustins | hahaha | 19:26 |
| gouthamr | oh | 19:26 |
| gouthamr | --os-share-api-version | 19:26 |
| gouthamr | like: manila --os-share-api-version 2.17 list | 19:27 |
| gouthamr | you can also export an env variable: OS_SHARE_API_VERSION | 19:28 |
| dustins | gouthamr: That's...remarkably easy | 19:29 |
| dustins | Figured it was a keyword option or something | 19:30 |
| dustins | Thanks! | 19:30 |
| gouthamr | dustins: you're welcome.. | 19:30 |
| *** eharney has joined #openstack-manila | 19:31 | |
| *** raissa has quit IRC | 19:32 | |
| *** jmlowe has joined #openstack-manila | 19:34 | |
| *** toabctl has joined #openstack-manila | 19:40 | |
| openstackgerrit | Andreas Jaeger proposed openstack/python-manilaclient master: Remove setting of version/release from releasenotes https://review.openstack.org/520729 | 19:44 |
| *** lpetrut_ has joined #openstack-manila | 20:02 | |
| *** jmlowe has quit IRC | 20:04 | |
| *** pcaruana has joined #openstack-manila | 20:06 | |
| *** ianychoi has quit IRC | 20:16 | |
| *** ianychoi has joined #openstack-manila | 20:17 | |
| *** jmlowe has joined #openstack-manila | 20:30 | |
| *** jmlowe has quit IRC | 20:39 | |
| *** jprovazn has quit IRC | 20:39 | |
| *** ianychoi_ has joined #openstack-manila | 21:10 | |
| *** ianychoi has quit IRC | 21:13 | |
| *** lpetrut_ has quit IRC | 21:13 | |
| *** lpetrut_ has joined #openstack-manila | 21:15 | |
| *** lpetrut_ has quit IRC | 21:23 | |
| *** pcaruana has quit IRC | 21:24 | |
| *** erlon has quit IRC | 21:29 | |
| *** markstur has joined #openstack-manila | 21:47 | |
| *** wes_dillingham has quit IRC | 21:49 | |
| *** dustins has quit IRC | 22:04 | |
| *** markstur has quit IRC | 22:12 | |
| *** a-pugachev has joined #openstack-manila | 22:12 | |
| *** gouthamr has quit IRC | 22:20 | |
| *** masber has joined #openstack-manila | 22:49 | |
| *** dsariel has quit IRC | 23:09 | |
| *** jmlowe has joined #openstack-manila | 23:10 | |
| *** gouthamr has joined #openstack-manila | 23:12 | |
| *** dsariel has joined #openstack-manila | 23:16 | |
| *** dsariel has quit IRC | 23:38 | |
| *** wes_dillingham has joined #openstack-manila | 23:42 | |
| *** a-pugachev has quit IRC | 23:42 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!