*** aspiers[m] has quit IRC | 00:13 | |
*** aspiers[m] has joined #openstack-manila | 00:49 | |
*** caowei has joined #openstack-manila | 01:05 | |
*** absubram has joined #openstack-manila | 01:13 | |
*** absubram has quit IRC | 01:39 | |
openstackgerrit | zhongjun proposed openstack/manila master: Fix UnicodeDecodeError when decode API input https://review.openstack.org/539406 | 01:43 |
---|---|---|
bswartz | tbarron: does this satisfy you? https://review.openstack.org/539406 | 01:44 |
tbarron | bswartz: sure, I'll +2 +W first thing in the morning after jenkins confirms if you +2 now | 01:46 |
tbarron | bswartz: I've got to get up early tomorrow and won't stay up long tonight | 01:46 |
bswartz | tbarron: reviewing another patch | 01:46 |
bswartz | I'll come back to it | 01:46 |
tbarron | bswartz: k, no prob | 01:47 |
bswartz | tbarron: goodnight :-) | 01:47 |
zhongjun | tbarron: goodnight and thanks :) | 01:51 |
*** masber has quit IRC | 01:59 | |
openstackgerrit | zhongjun proposed openstack/manila master: Fix UnicodeDecodeError when decode API input https://review.openstack.org/539406 | 02:08 |
*** aspiers[m] has quit IRC | 02:54 | |
*** gaurangt has quit IRC | 02:57 | |
*** gaurangt has joined #openstack-manila | 03:00 | |
*** tinwood has quit IRC | 03:20 | |
*** tinwood has joined #openstack-manila | 03:21 | |
openstackgerrit | Merged openstack/manila master: Fix NFS/CIFS share creation failure issue https://review.openstack.org/531638 | 03:23 |
*** ianychoi_ has quit IRC | 03:49 | |
*** ianychoi_ has joined #openstack-manila | 03:50 | |
*** openstackgerrit has quit IRC | 04:04 | |
*** openstackgerrit has joined #openstack-manila | 04:05 | |
openstackgerrit | haobing proposed openstack/manila master: Fix tap device disappear after node restart https://review.openstack.org/539924 | 04:05 |
*** harlowja has quit IRC | 04:32 | |
*** lpetrut has joined #openstack-manila | 04:40 | |
*** dsariel has quit IRC | 04:52 | |
*** lpetrut has quit IRC | 05:21 | |
*** markstur has quit IRC | 05:34 | |
*** junboli has joined #openstack-manila | 05:37 | |
*** harlowja has joined #openstack-manila | 05:37 | |
*** aspiers[m] has joined #openstack-manila | 06:23 | |
openstackgerrit | haobing proposed openstack/manila master: Fix tap device disappear after node restart https://review.openstack.org/539924 | 06:23 |
openstackgerrit | zhongjun proposed openstack/manila master: Fix UnicodeDecodeError when decode API input https://review.openstack.org/539406 | 06:37 |
*** junboli has quit IRC | 06:44 | |
*** harlowja has quit IRC | 06:52 | |
*** dsariel has joined #openstack-manila | 06:58 | |
*** AlexeyAbashkin has joined #openstack-manila | 07:22 | |
*** AlexeyAbashkin has quit IRC | 07:42 | |
*** a-pugachev has joined #openstack-manila | 07:47 | |
*** AlexeyAbashkin has joined #openstack-manila | 07:54 | |
*** a-pugachev has quit IRC | 08:09 | |
*** ianychoi_ has quit IRC | 08:14 | |
*** ianychoi_ has joined #openstack-manila | 08:19 | |
*** threestrands has quit IRC | 08:22 | |
*** ianychoi_ has quit IRC | 08:28 | |
*** ianychoi_ has joined #openstack-manila | 08:30 | |
*** pcaruana has joined #openstack-manila | 08:38 | |
*** ianychoi_ has quit IRC | 08:45 | |
*** ianychoi_ has joined #openstack-manila | 08:46 | |
*** arnewiebalck_ has joined #openstack-manila | 08:47 | |
*** arnewiebalck_ has quit IRC | 09:01 | |
*** a-pugachev has joined #openstack-manila | 09:36 | |
*** pcaruana has quit IRC | 09:57 | |
*** lpetrut has joined #openstack-manila | 09:58 | |
*** caowei has quit IRC | 10:03 | |
*** ganso has joined #openstack-manila | 10:09 | |
*** pcaruana has joined #openstack-manila | 10:13 | |
*** ianychoi_ has quit IRC | 10:21 | |
*** ianychoi_ has joined #openstack-manila | 10:24 | |
*** lpetrut has quit IRC | 10:28 | |
*** gcb has quit IRC | 10:29 | |
*** tpsilva has joined #openstack-manila | 10:59 | |
*** ianychoi_ has quit IRC | 11:05 | |
*** ianychoi_ has joined #openstack-manila | 11:07 | |
*** pcaruana has quit IRC | 11:09 | |
*** rraja has joined #openstack-manila | 11:17 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila-tempest-plugin master: Allow IPv6 Share Migration tests https://review.openstack.org/541684 | 11:38 |
*** haobing has joined #openstack-manila | 11:45 | |
haobing | https://review.openstack.org/#/c/539924/ | 11:46 |
haobing | need review | 11:46 |
*** ianychoi_ has quit IRC | 12:00 | |
*** haobing has quit IRC | 12:12 | |
*** pcaruana has joined #openstack-manila | 12:13 | |
*** haobing has joined #openstack-manila | 12:13 | |
*** lpetrut has joined #openstack-manila | 12:23 | |
*** AlexeyAbashkin has quit IRC | 12:25 | |
ganso | tbarron: ping | 12:31 |
*** AlexeyAbashkin has joined #openstack-manila | 12:40 | |
*** haobing has quit IRC | 12:45 | |
*** rraja has quit IRC | 12:55 | |
*** rraja has joined #openstack-manila | 12:57 | |
*** jmlowe has quit IRC | 13:07 | |
tpsilva | tbarron: ping | 13:09 |
tbarron | ganso: tpsilva pong | 13:29 |
ganso | tbarron: hey Tom, good morning! =) | 13:29 |
tbarron | ganso: And good morning to you. | 13:30 |
ganso | tbarron: could you please take a look at this bugfix when you have some time? https://review.openstack.org/#/c/541478/ | 13:30 |
tbarron | ganso: sure | 13:31 |
ganso | tbarron: thanks =D | 13:31 |
tbarron | ganso: np | 13:31 |
*** AlexeyAbashkin has quit IRC | 13:34 | |
tbarron | bswartz: should we target https://review.openstack.org/#/c/539924 for rc? | 13:35 |
*** AlexeyAbashkin has joined #openstack-manila | 13:35 | |
*** eharney has quit IRC | 13:37 | |
openstackgerrit | Tom Barron proposed openstack/manila master: DO NOT MERGE ME https://review.openstack.org/537867 | 13:37 |
*** AlexeyAbashkin has quit IRC | 13:40 | |
*** cyberde has joined #openstack-manila | 13:42 | |
*** rraja_ has joined #openstack-manila | 13:42 | |
*** rraja has quit IRC | 13:44 | |
*** jmlowe has joined #openstack-manila | 13:46 | |
*** AlexeyAbashkin has joined #openstack-manila | 13:55 | |
*** dustins has joined #openstack-manila | 14:14 | |
*** ianychoi has joined #openstack-manila | 14:17 | |
*** eharney has joined #openstack-manila | 14:24 | |
bswartz | tbarron: what do you think? | 14:42 |
bswartz | it's a very old bug, and the fix seems kinds of risky to me | 14:43 |
bswartz | Also, the indentation in the patch is horrifying | 14:43 |
bswartz | I hate the awkward things we do for the sake of line wrapping | 14:43 |
rraja_ | arnewiebalck: ping | 14:49 |
tbarron | bswartz: you probably have the best understanding of the code that he's fixing anyways. Probably | 14:49 |
arnewiebalck | rraja_: hi! | 14:49 |
tbarron | bswartz: you should explain that we want to do it for Rocky and encourage the patch, etc. | 14:50 |
tbarron | bswartz: it could be a queens backport if it goes in early in Rocky | 14:50 |
bswartz | tbarron: well I know what the issue is, but I'm not sure if this is the best fix | 14:50 |
bswartz | Yeah that's the safer move | 14:50 |
bswartz | Given how long this bug has existed | 14:50 |
tbarron | bswartz: ack | 14:50 |
rraja_ | arnewiebalck: hi! heard about Dan's talk in Ceph day, Germany. In one of his slides it says that it Manila/CephFS is now in production. I was wondering which share protocol you're using? the native CephFS one, right? | 14:52 |
bswartz | 2 bugs left to workflow | 14:52 |
tbarron | now 1 | 14:53 |
bswartz | =D | 14:53 |
tbarron | I'll look at the share migration one in a few | 14:53 |
arnewiebalck | rraja_: You’re up-to-date, the talk was today :) | 14:56 |
arnewiebalck | rraja_: Yes, it’s native CephFS. | 14:57 |
arnewiebalck | rraja_: 81 shares, 105TB | 14:58 |
rraja_ | arnewiebalck: cool! | 14:59 |
arnewiebalck | rraja_: But it has just been declared prod, so I have started to move services over from our NFS service. | 14:59 |
arnewiebalck | rraja_: So it should grow in the next couple of months. | 14:59 |
arnewiebalck | rraja_: Trying NFS on CephFS is on my list :) | 14:59 |
rraja_ | arnewiebalck: Great! right now there is no out of the box HA of the NFS-Ganesha service for CephFS. You'd need something like pacemaker/corosync infra to do that. | 15:01 |
*** arnewiebalck_ has joined #openstack-manila | 15:02 | |
tbarron | ganso: bswartz +W | 15:05 |
bswartz | Okay, now we wait for the gate to work its magic and the we can tag | 15:05 |
tbarron | but the postgresql jobs seem to be failing devstack setup: http://logs.openstack.org/78/541478/1/check/manila-tempest-dsvm-postgres-generic-singlebackend/7583cce/logs/devstack-early.txt.gz#_2018-02-07_02_39_32_740 | 15:05 |
tbarron | all non-voting | 15:05 |
bswartz | Last chance to target bugs to RC1 | 15:05 |
* bswartz looks | 15:06 | |
tbarron | I can't work on this today, so if someone wants to pick this up be my guest | 15:06 |
ganso | bswartz: what about manila-tempest-plugin? is it tagged as well or is it always master-only ? | 15:06 |
tbarron | at least that's my working hypothesis given a quick look at the failures | 15:06 |
bswartz | ganso: tempest is branchless | 15:07 |
*** dustins has quit IRC | 15:16 | |
toabctl | is there anybody who wants to be manila PTL? I have not seens any (self) nomination yet... | 15:23 |
*** AlexeyAbashkin has quit IRC | 15:24 | |
*** AlexeyAbashkin has joined #openstack-manila | 15:24 | |
*** absubram has joined #openstack-manila | 15:25 | |
*** lpetrut has quit IRC | 15:27 | |
ganso | tbarron: thanks! | 15:28 |
tbarron | toabctl: I'm thinking about it but let's see if anyone else here wants to do it! | 15:29 |
toabctl | tbarron, you'll have my vote (even if it not needed) ! | 15:29 |
*** absubram has quit IRC | 15:30 | |
amito | tbarron: +1 from me | 15:30 |
*** absubram has joined #openstack-manila | 15:31 | |
openstackgerrit | Merged openstack/manila master: Fix UnicodeDecodeError when decode API input https://review.openstack.org/539406 | 15:58 |
*** pcaruana has quit IRC | 16:03 | |
*** markstur has joined #openstack-manila | 16:11 | |
*** arnewiebalck_ has quit IRC | 16:20 | |
openstackgerrit | Merged openstack/manila master: Fix Host-assisted Share Migration with IPv4+IPv6 https://review.openstack.org/541478 | 16:22 |
arnewiebalck | rraja_: Thx, I’ll have a look! | 16:23 |
*** absubram has quit IRC | 16:37 | |
*** dustins has joined #openstack-manila | 16:38 | |
*** lpetrut has joined #openstack-manila | 16:41 | |
*** absubram has joined #openstack-manila | 16:59 | |
*** absubram has quit IRC | 17:00 | |
*** a-pugachev has quit IRC | 17:01 | |
*** lpetrut has quit IRC | 17:04 | |
*** a-pugachev has joined #openstack-manila | 17:05 | |
*** rraja_ has quit IRC | 17:09 | |
*** harlowja has joined #openstack-manila | 17:11 | |
*** lpetrut has joined #openstack-manila | 17:13 | |
bswartz | I've targeted another bug to RC1 at ganso's request: https://bugs.launchpad.net/manila/+bug/1746723 | 17:15 |
openstack | Launchpad bug 1746723 in Manila "LVM driver does not handle IPv6 addresses in recovery mode" [Undecided,New] | 17:15 |
bswartz | We hope to have this one sorted out today | 17:15 |
ganso | patch coming in a min | 17:16 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Fix LVM driver not handling IPv6 in recovery mode https://review.openstack.org/541807 | 17:16 |
ganso | bswartz: ^ | 17:17 |
*** harlowja has quit IRC | 17:17 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila-tempest-plugin master: Allow IPv6 Share Migration tests https://review.openstack.org/541684 | 17:19 |
*** AlexeyAbashkin has quit IRC | 17:26 | |
*** absubram has joined #openstack-manila | 17:33 | |
*** chenying has quit IRC | 17:40 | |
*** chenying has joined #openstack-manila | 17:40 | |
*** a-pugachev has quit IRC | 18:01 | |
*** harlowja has joined #openstack-manila | 18:11 | |
*** harlowja has quit IRC | 18:18 | |
*** chenying has quit IRC | 18:50 | |
*** chenying has joined #openstack-manila | 18:51 | |
*** rraja_ has joined #openstack-manila | 19:10 | |
*** jmlowe_ has joined #openstack-manila | 19:16 | |
*** jmlowe has quit IRC | 19:17 | |
*** jmlowe has joined #openstack-manila | 19:33 | |
*** lpetrut has quit IRC | 19:33 | |
*** jmlowe has quit IRC | 19:33 | |
*** jmlowe_ has quit IRC | 19:34 | |
*** AlexeyAbashkin has joined #openstack-manila | 19:37 | |
*** pcaruana has joined #openstack-manila | 19:52 | |
*** a-pugachev has joined #openstack-manila | 20:01 | |
*** jmlowe has joined #openstack-manila | 20:02 | |
*** pcaruana has quit IRC | 20:07 | |
*** eharney has quit IRC | 20:24 | |
*** AlexeyAbashkin has quit IRC | 20:33 | |
*** a-pugachev has quit IRC | 20:38 | |
*** rraja_ has quit IRC | 20:47 | |
*** rraja_ has joined #openstack-manila | 20:47 | |
*** rraja_ has quit IRC | 20:49 | |
*** rraja_ has joined #openstack-manila | 20:49 | |
markstur | tbarron: way to step up! | 21:13 |
tbarron | markstur: :-) | 21:14 |
*** tpsilva has quit IRC | 21:19 | |
*** eharney has joined #openstack-manila | 21:20 | |
markstur | throw your (red) hat into the ring | 21:21 |
*** ganso has quit IRC | 21:29 | |
*** ganso has joined #openstack-manila | 21:37 | |
ganso | tbarron, bswartz: generic driver is broken since the glance client change | 21:37 |
ganso | tbarron, bswartz: see console and m-shr logs here http://logs.openstack.org/07/541807/1/check/manila-tempest-dsvm-mysql-generic/5784f7f/ | 21:37 |
ganso | tbarron, bswartz: we should fix this before the RC1 | 21:37 |
*** threestrands has joined #openstack-manila | 21:39 | |
ganso | tbarron: if you could please review this change https://review.openstack.org/#/c/541807/, we could merge this now and focus on this glance client issue | 21:40 |
bswartz | ganso: I thought that patch passed the generic tests | 21:40 |
bswartz | I'm looking now | 21:40 |
tbarron | ganso: was looking at it and got pulled into a meeting, sec | 21:40 |
bswartz | Maybe I missed something | 21:40 |
bswartz | I think I did miss this | 21:41 |
bswartz | This is what we get for making the generic driver non-gating | 21:41 |
ganso | bswartz: it passed generic no-share-servers tests, and passed LVM if you look at the manila-tempest-plugin patch here https://review.openstack.org/#/c/541684/ that uses the LVM fix | 21:41 |
bswartz | ganso: do you know what the problem is yet? | 21:41 |
ganso | bswartz: so my fix is fine, generic driver breakage is related to the glance client update we merged this week | 21:41 |
bswartz | ganso: https://review.openstack.org/#/c/531638/ | 21:42 |
ganso | bswartz: generic driver did not pass on that | 21:42 |
bswartz | This change looked pretty safe to me, but I didn't scrutinze the tests closely enough | 21:42 |
ganso | bswartz: http://logs.openstack.org/38/531638/3/check/manila-tempest-dsvm-mysql-generic/0d7fb1a/logs/screen-m-shr.txt.gz#_Feb_07_01_34_43_760981 | 21:42 |
ganso | bswartz: glance client issue | 21:43 |
bswartz | K | 21:43 |
bswartz | I wonder how junbo.li tested this | 21:43 |
*** rraja_ has quit IRC | 21:44 | |
tbarron | ganso: bswartz bottom line here is back out 561638 and merge 541807? | 21:45 |
tbarron | 541807 looks ok; the issue is occurring without it. | 21:46 |
tbarron | we've had that 26 volume limitation for a long time and I guess we're rushing the fix | 21:46 |
bswartz | Unless we can find a fix quickly for the new issue, I agree that backing out 561638 is the safer approach | 21:46 |
ganso | bswartz: I replied you on https://review.openstack.org/#/c/541684 | 21:47 |
bswartz | Merging 541807 is not blocked by this issue, it just makes tests results harder to consume | 21:47 |
tbarron | bswartz: so you want to wait for the backout, then workflow it? | 21:48 |
ganso | we can create a revert patch on 561638 and see what Zuul says about it | 21:48 |
bswartz | Yes let's do that | 21:48 |
tbarron | ganso: you got it, or you want one of us to revert? | 21:48 |
bswartz | Then if a fix patch can be produced, we'll have 2 options to consider later tonight or tomorrow morning | 21:48 |
tbarron | +1 | 21:49 |
bswartz | I can't do it, I'm about to head out to get my daughter from school | 21:49 |
bswartz | I'll be back online in ~3 hours | 21:49 |
tbarron | I can do it but if ganso does it we can both vote | 21:49 |
ganso | tbarron: it would be better if you or bswartz did it, as I am not sure if I need to talk to my manager before doing this revert | 21:49 |
tbarron | I will do it, we'll round up votes tomorrow | 21:49 |
bswartz | I can do it if y'all can wait 3 hours ;-) | 21:50 |
tbarron | I'll go on and do it. | 21:50 |
bswartz | ganso, tbarron: this close to the RC date we wouldn't enforce our voting rules for an obviously important patch | 21:50 |
ganso | bswartz: I believe we got quorum on that | 21:51 |
ganso | bswartz: oh actually no, if tbarron sends the patch... well, let's not enforce the rules then | 21:54 |
*** dustins has quit IRC | 22:17 | |
openstackgerrit | Tom Barron proposed openstack/manila master: Revert Id905d47600bda9923cebae617749c8286552ec94 https://review.openstack.org/541927 | 22:28 |
tbarron | ganso: bswartz ^^ let's see | 22:35 |
ganso | tbarron: =) | 22:35 |
ganso | tbarron: dummy driver failed for some random reason | 23:23 |
ganso | tbarron: we will have to recheck it | 23:23 |
*** masber has joined #openstack-manila | 23:27 | |
ganso | tbarron: generic passed | 23:29 |
bswartz | ganso: the dummy driver should be unable to fail for random reasons | 23:32 |
bswartz | That should really concern us | 23:32 |
ganso | bswartz: race conditions | 23:32 |
ganso | bswartz: they are real | 23:33 |
bswartz | The dummy driver should be the best way to reproduce and fix them | 23:33 |
bswartz | Because the driver isn't doing anything racy internally, the race condition must exist in the manager code | 23:33 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!