Wednesday, 2018-02-07

*** aspiers[m] has quit IRC00:13
*** aspiers[m] has joined #openstack-manila00:49
*** caowei has joined #openstack-manila01:05
*** absubram has joined #openstack-manila01:13
*** absubram has quit IRC01:39
openstackgerritzhongjun proposed openstack/manila master: Fix UnicodeDecodeError when decode API input  https://review.openstack.org/53940601:43
bswartztbarron: does this satisfy you? https://review.openstack.org/53940601:44
tbarronbswartz: sure, I'll +2 +W first thing in the morning after jenkins confirms if you +2 now01:46
tbarronbswartz: I've got to get up early tomorrow and won't stay up long tonight01:46
bswartztbarron: reviewing another patch01:46
bswartzI'll come back to it01:46
tbarronbswartz: k, no prob01:47
bswartztbarron: goodnight :-)01:47
zhongjuntbarron: goodnight and thanks :)01:51
*** masber has quit IRC01:59
openstackgerritzhongjun proposed openstack/manila master: Fix UnicodeDecodeError when decode API input  https://review.openstack.org/53940602:08
*** aspiers[m] has quit IRC02:54
*** gaurangt has quit IRC02:57
*** gaurangt has joined #openstack-manila03:00
*** tinwood has quit IRC03:20
*** tinwood has joined #openstack-manila03:21
openstackgerritMerged openstack/manila master: Fix NFS/CIFS share creation failure issue  https://review.openstack.org/53163803:23
*** ianychoi_ has quit IRC03:49
*** ianychoi_ has joined #openstack-manila03:50
*** openstackgerrit has quit IRC04:04
*** openstackgerrit has joined #openstack-manila04:05
openstackgerrithaobing proposed openstack/manila master: Fix tap device disappear after node restart  https://review.openstack.org/53992404:05
*** harlowja has quit IRC04:32
*** lpetrut has joined #openstack-manila04:40
*** dsariel has quit IRC04:52
*** lpetrut has quit IRC05:21
*** markstur has quit IRC05:34
*** junboli has joined #openstack-manila05:37
*** harlowja has joined #openstack-manila05:37
*** aspiers[m] has joined #openstack-manila06:23
openstackgerrithaobing proposed openstack/manila master: Fix tap device disappear after node restart  https://review.openstack.org/53992406:23
openstackgerritzhongjun proposed openstack/manila master: Fix UnicodeDecodeError when decode API input  https://review.openstack.org/53940606:37
*** junboli has quit IRC06:44
*** harlowja has quit IRC06:52
*** dsariel has joined #openstack-manila06:58
*** AlexeyAbashkin has joined #openstack-manila07:22
*** AlexeyAbashkin has quit IRC07:42
*** a-pugachev has joined #openstack-manila07:47
*** AlexeyAbashkin has joined #openstack-manila07:54
*** a-pugachev has quit IRC08:09
*** ianychoi_ has quit IRC08:14
*** ianychoi_ has joined #openstack-manila08:19
*** threestrands has quit IRC08:22
*** ianychoi_ has quit IRC08:28
*** ianychoi_ has joined #openstack-manila08:30
*** pcaruana has joined #openstack-manila08:38
*** ianychoi_ has quit IRC08:45
*** ianychoi_ has joined #openstack-manila08:46
*** arnewiebalck_ has joined #openstack-manila08:47
*** arnewiebalck_ has quit IRC09:01
*** a-pugachev has joined #openstack-manila09:36
*** pcaruana has quit IRC09:57
*** lpetrut has joined #openstack-manila09:58
*** caowei has quit IRC10:03
*** ganso has joined #openstack-manila10:09
*** pcaruana has joined #openstack-manila10:13
*** ianychoi_ has quit IRC10:21
*** ianychoi_ has joined #openstack-manila10:24
*** lpetrut has quit IRC10:28
*** gcb has quit IRC10:29
*** tpsilva has joined #openstack-manila10:59
*** ianychoi_ has quit IRC11:05
*** ianychoi_ has joined #openstack-manila11:07
*** pcaruana has quit IRC11:09
*** rraja has joined #openstack-manila11:17
openstackgerritRodrigo Barbieri proposed openstack/manila-tempest-plugin master: Allow IPv6 Share Migration tests  https://review.openstack.org/54168411:38
*** haobing has joined #openstack-manila11:45
haobinghttps://review.openstack.org/#/c/539924/11:46
haobingneed review11:46
*** ianychoi_ has quit IRC12:00
*** haobing has quit IRC12:12
*** pcaruana has joined #openstack-manila12:13
*** haobing has joined #openstack-manila12:13
*** lpetrut has joined #openstack-manila12:23
*** AlexeyAbashkin has quit IRC12:25
gansotbarron: ping12:31
*** AlexeyAbashkin has joined #openstack-manila12:40
*** haobing has quit IRC12:45
*** rraja has quit IRC12:55
*** rraja has joined #openstack-manila12:57
*** jmlowe has quit IRC13:07
tpsilvatbarron: ping13:09
tbarronganso: tpsilva pong13:29
gansotbarron: hey Tom, good morning! =)13:29
tbarronganso: And good morning to you.13:30
gansotbarron: could you please take a look at this bugfix when you have some time? https://review.openstack.org/#/c/541478/13:30
tbarronganso: sure13:31
gansotbarron: thanks =D13:31
tbarronganso: np13:31
*** AlexeyAbashkin has quit IRC13:34
tbarronbswartz: should we target https://review.openstack.org/#/c/539924 for rc?13:35
*** AlexeyAbashkin has joined #openstack-manila13:35
*** eharney has quit IRC13:37
openstackgerritTom Barron proposed openstack/manila master: DO NOT MERGE ME  https://review.openstack.org/53786713:37
*** AlexeyAbashkin has quit IRC13:40
*** cyberde has joined #openstack-manila13:42
*** rraja_ has joined #openstack-manila13:42
*** rraja has quit IRC13:44
*** jmlowe has joined #openstack-manila13:46
*** AlexeyAbashkin has joined #openstack-manila13:55
*** dustins has joined #openstack-manila14:14
*** ianychoi has joined #openstack-manila14:17
*** eharney has joined #openstack-manila14:24
bswartztbarron: what do you think?14:42
bswartzit's a very old bug, and the fix seems kinds of risky to me14:43
bswartzAlso, the indentation in the patch is horrifying14:43
bswartzI hate the awkward things we do for the sake of line wrapping14:43
rraja_arnewiebalck: ping14:49
tbarronbswartz: you probably have the best understanding of the code that he's fixing anyways.  Probably14:49
arnewiebalckrraja_: hi!14:49
tbarronbswartz: you should explain that we want to do it for Rocky and encourage the patch, etc.14:50
tbarronbswartz: it could be a queens backport if it goes in early in Rocky14:50
bswartztbarron: well I know what the issue is, but I'm not sure if this is the best fix14:50
bswartzYeah that's the safer move14:50
bswartzGiven how long this bug has existed14:50
tbarronbswartz: ack14:50
rraja_arnewiebalck: hi! heard about Dan's talk in Ceph day, Germany. In one of his slides it says that it Manila/CephFS is now in production. I was wondering which share protocol you're using? the native CephFS one, right?14:52
bswartz2 bugs left to workflow14:52
tbarronnow 114:53
bswartz=D14:53
tbarronI'll look at the share migration one in a few14:53
arnewiebalckrraja_: You’re up-to-date, the talk was today :)14:56
arnewiebalckrraja_: Yes, it’s native CephFS.14:57
arnewiebalckrraja_: 81 shares, 105TB14:58
rraja_arnewiebalck: cool!14:59
arnewiebalckrraja_: But it has just been declared prod, so I have started to move services over from our NFS service.14:59
arnewiebalckrraja_: So it should grow in the next couple of months.14:59
arnewiebalckrraja_: Trying NFS on CephFS is on my list :)14:59
rraja_arnewiebalck: Great! right now there is no out of the box HA of the NFS-Ganesha service for CephFS. You'd need something like pacemaker/corosync infra to do that.15:01
*** arnewiebalck_ has joined #openstack-manila15:02
tbarronganso: bswartz +W15:05
bswartzOkay, now we wait for the gate to work its magic and the we can tag15:05
tbarronbut the postgresql jobs seem to be failing devstack setup: http://logs.openstack.org/78/541478/1/check/manila-tempest-dsvm-postgres-generic-singlebackend/7583cce/logs/devstack-early.txt.gz#_2018-02-07_02_39_32_74015:05
tbarronall non-voting15:05
bswartzLast chance to target bugs to RC115:05
* bswartz looks15:06
tbarronI can't work on this today, so if someone wants to pick this up be my guest15:06
gansobswartz: what about manila-tempest-plugin? is it tagged as well or is it always master-only ?15:06
tbarronat least that's my working hypothesis given a quick look at the failures15:06
bswartzganso: tempest is branchless15:07
*** dustins has quit IRC15:16
toabctlis there anybody who wants to be manila PTL? I have not seens any (self) nomination yet...15:23
*** AlexeyAbashkin has quit IRC15:24
*** AlexeyAbashkin has joined #openstack-manila15:24
*** absubram has joined #openstack-manila15:25
*** lpetrut has quit IRC15:27
gansotbarron: thanks!15:28
tbarrontoabctl: I'm thinking about it but let's see if anyone else here wants to do it!15:29
toabctltbarron, you'll have my vote (even if it not needed) !15:29
*** absubram has quit IRC15:30
amitotbarron: +1 from me15:30
*** absubram has joined #openstack-manila15:31
openstackgerritMerged openstack/manila master: Fix UnicodeDecodeError when decode API input  https://review.openstack.org/53940615:58
*** pcaruana has quit IRC16:03
*** markstur has joined #openstack-manila16:11
*** arnewiebalck_ has quit IRC16:20
openstackgerritMerged openstack/manila master: Fix Host-assisted Share Migration with IPv4+IPv6  https://review.openstack.org/54147816:22
arnewiebalckrraja_: Thx, I’ll have a look!16:23
*** absubram has quit IRC16:37
*** dustins has joined #openstack-manila16:38
*** lpetrut has joined #openstack-manila16:41
*** absubram has joined #openstack-manila16:59
*** absubram has quit IRC17:00
*** a-pugachev has quit IRC17:01
*** lpetrut has quit IRC17:04
*** a-pugachev has joined #openstack-manila17:05
*** rraja_ has quit IRC17:09
*** harlowja has joined #openstack-manila17:11
*** lpetrut has joined #openstack-manila17:13
bswartzI've targeted another bug to RC1 at ganso's request: https://bugs.launchpad.net/manila/+bug/174672317:15
openstackLaunchpad bug 1746723 in Manila "LVM driver does not handle IPv6 addresses in recovery mode" [Undecided,New]17:15
bswartzWe hope to have this one sorted out today17:15
gansopatch coming in a min17:16
openstackgerritRodrigo Barbieri proposed openstack/manila master: Fix LVM driver not handling IPv6 in recovery mode  https://review.openstack.org/54180717:16
gansobswartz: ^17:17
*** harlowja has quit IRC17:17
openstackgerritRodrigo Barbieri proposed openstack/manila-tempest-plugin master: Allow IPv6 Share Migration tests  https://review.openstack.org/54168417:19
*** AlexeyAbashkin has quit IRC17:26
*** absubram has joined #openstack-manila17:33
*** chenying has quit IRC17:40
*** chenying has joined #openstack-manila17:40
*** a-pugachev has quit IRC18:01
*** harlowja has joined #openstack-manila18:11
*** harlowja has quit IRC18:18
*** chenying has quit IRC18:50
*** chenying has joined #openstack-manila18:51
*** rraja_ has joined #openstack-manila19:10
*** jmlowe_ has joined #openstack-manila19:16
*** jmlowe has quit IRC19:17
*** jmlowe has joined #openstack-manila19:33
*** lpetrut has quit IRC19:33
*** jmlowe has quit IRC19:33
*** jmlowe_ has quit IRC19:34
*** AlexeyAbashkin has joined #openstack-manila19:37
*** pcaruana has joined #openstack-manila19:52
*** a-pugachev has joined #openstack-manila20:01
*** jmlowe has joined #openstack-manila20:02
*** pcaruana has quit IRC20:07
*** eharney has quit IRC20:24
*** AlexeyAbashkin has quit IRC20:33
*** a-pugachev has quit IRC20:38
*** rraja_ has quit IRC20:47
*** rraja_ has joined #openstack-manila20:47
*** rraja_ has quit IRC20:49
*** rraja_ has joined #openstack-manila20:49
marksturtbarron: way to step up!21:13
tbarronmarkstur: :-)21:14
*** tpsilva has quit IRC21:19
*** eharney has joined #openstack-manila21:20
marksturthrow your (red) hat into the ring21:21
*** ganso has quit IRC21:29
*** ganso has joined #openstack-manila21:37
gansotbarron, bswartz: generic driver is broken since the glance client change21:37
gansotbarron, bswartz: see console and m-shr logs here http://logs.openstack.org/07/541807/1/check/manila-tempest-dsvm-mysql-generic/5784f7f/21:37
gansotbarron, bswartz: we should fix this before the RC121:37
*** threestrands has joined #openstack-manila21:39
gansotbarron: if you could please review this change https://review.openstack.org/#/c/541807/, we could merge this now and focus on this glance client issue21:40
bswartzganso: I thought that patch passed the generic tests21:40
bswartzI'm looking now21:40
tbarronganso: was looking at it and got pulled into a meeting, sec21:40
bswartzMaybe I missed something21:40
bswartzI think I did miss this21:41
bswartzThis is what we get for making the generic driver non-gating21:41
gansobswartz: it passed generic no-share-servers tests, and passed LVM if you look at the manila-tempest-plugin patch here https://review.openstack.org/#/c/541684/ that uses the LVM fix21:41
bswartzganso: do you know what the problem is yet?21:41
gansobswartz: so my fix is fine, generic driver breakage is related to the glance client update we merged this week21:41
bswartzganso: https://review.openstack.org/#/c/531638/21:42
gansobswartz: generic driver did not pass on that21:42
bswartzThis change looked pretty safe to me, but I didn't scrutinze the tests closely enough21:42
gansobswartz: http://logs.openstack.org/38/531638/3/check/manila-tempest-dsvm-mysql-generic/0d7fb1a/logs/screen-m-shr.txt.gz#_Feb_07_01_34_43_76098121:42
gansobswartz: glance client issue21:43
bswartzK21:43
bswartzI wonder how junbo.li tested this21:43
*** rraja_ has quit IRC21:44
tbarronganso: bswartz bottom line here is back out 561638 and merge 541807?21:45
tbarron541807 looks ok; the issue is occurring without it.21:46
tbarronwe've had that 26 volume limitation for a long time and I guess we're rushing the fix21:46
bswartzUnless we can find a fix quickly for the new issue, I agree that backing out 561638 is the safer approach21:46
gansobswartz: I replied you on https://review.openstack.org/#/c/54168421:47
bswartzMerging 541807 is not blocked by this issue, it just makes tests results harder to consume21:47
tbarronbswartz: so you want to wait for the backout, then workflow it?21:48
gansowe can create a revert patch on 561638  and see what Zuul says about it21:48
bswartzYes let's do that21:48
tbarronganso: you got it, or you want one of us to revert?21:48
bswartzThen if a fix patch can be produced, we'll have 2 options to consider later tonight or tomorrow morning21:48
tbarron+121:49
bswartzI can't do it, I'm about to head out to get my daughter from school21:49
bswartzI'll be back online in ~3 hours21:49
tbarronI can do it but if ganso does it we can both vote21:49
gansotbarron: it would be better if you or bswartz did it, as I am not sure if I need to talk to my manager before doing this revert21:49
tbarronI will do it, we'll round up votes tomorrow21:49
bswartzI can do it if y'all can wait 3 hours ;-)21:50
tbarronI'll go on and do it.21:50
bswartzganso, tbarron: this close to the RC date we wouldn't enforce our voting rules for an obviously important patch21:50
gansobswartz: I believe we got quorum on that21:51
gansobswartz: oh actually no, if tbarron sends the patch... well, let's not enforce the rules then21:54
*** dustins has quit IRC22:17
openstackgerritTom Barron proposed openstack/manila master: Revert Id905d47600bda9923cebae617749c8286552ec94  https://review.openstack.org/54192722:28
tbarronganso: bswartz ^^ let's see22:35
gansotbarron: =)22:35
gansotbarron: dummy driver failed for some random reason23:23
gansotbarron: we will have to recheck it23:23
*** masber has joined #openstack-manila23:27
gansotbarron: generic passed23:29
bswartzganso: the dummy driver should be unable to fail for random reasons23:32
bswartzThat should really concern us23:32
gansobswartz: race conditions23:32
gansobswartz: they are real23:33
bswartzThe dummy driver should be the best way to reproduce and fix them23:33
bswartzBecause the driver isn't doing anything racy internally, the race condition must exist in the manager code23:33

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!