| *** gouthamr has joined #openstack-manila | 00:23 | |
| *** masuberu has quit IRC | 00:35 | |
| *** masuberu has joined #openstack-manila | 00:37 | |
| *** jmlowe has quit IRC | 01:24 | |
| *** jmlowe has joined #openstack-manila | 01:46 | |
| *** AlexeyAbashkin has joined #openstack-manila | 01:49 | |
| *** gouthamr has quit IRC | 01:50 | |
| *** AlexeyAbashkin has quit IRC | 01:53 | |
| *** markstur has quit IRC | 02:12 | |
| *** harlowja has quit IRC | 02:13 | |
| *** chrisyang_0660 has joined #openstack-manila | 02:19 | |
| *** jmlowe has quit IRC | 02:28 | |
| *** Guest76416 has quit IRC | 02:41 | |
| *** masuberu has quit IRC | 02:42 | |
| *** rishabh has joined #openstack-manila | 02:42 | |
| *** rishabh is now known as Guest26459 | 02:43 | |
| *** masber has joined #openstack-manila | 03:02 | |
| *** markstur has joined #openstack-manila | 03:08 | |
| *** markstur has quit IRC | 03:11 | |
| *** markstur has joined #openstack-manila | 03:11 | |
| *** masber has quit IRC | 03:36 | |
| *** masber has joined #openstack-manila | 03:47 | |
| *** gouthamr has joined #openstack-manila | 03:55 | |
| *** gouthamr has quit IRC | 03:55 | |
| *** glance_ has quit IRC | 04:25 | |
| *** glance_ has joined #openstack-manila | 04:26 | |
| *** chrisyang_0660 has quit IRC | 04:27 | |
| *** masuberu has joined #openstack-manila | 04:36 | |
| *** masber has quit IRC | 04:40 | |
| *** masber has joined #openstack-manila | 04:40 | |
| *** masuberu has quit IRC | 04:42 | |
| *** masuberu has joined #openstack-manila | 05:32 | |
| *** masber has quit IRC | 05:35 | |
| *** Guest26459 has quit IRC | 06:24 | |
| *** markstur has quit IRC | 06:25 | |
| *** masuberu has quit IRC | 06:38 | |
| *** threestrands_ has joined #openstack-manila | 07:09 | |
| *** threestrands_ has quit IRC | 07:09 | |
| *** threestrands_ has joined #openstack-manila | 07:09 | |
| *** threestrands has quit IRC | 07:10 | |
| *** threestrands_ has quit IRC | 07:13 | |
| *** pcaruana has joined #openstack-manila | 07:54 | |
| *** pcaruana has quit IRC | 07:55 | |
| *** pcaruana has joined #openstack-manila | 07:55 | |
| *** AlexeyAbashkin has joined #openstack-manila | 07:58 | |
| *** threestrands has joined #openstack-manila | 08:32 | |
| *** threestrands has quit IRC | 08:32 | |
| *** threestrands has joined #openstack-manila | 08:32 | |
| *** threestrands has quit IRC | 08:36 | |
| *** rraja has joined #openstack-manila | 08:40 | |
| *** rraja has quit IRC | 08:58 | |
| *** a-pugachev has joined #openstack-manila | 09:18 | |
| *** rishabh_ has joined #openstack-manila | 10:26 | |
| *** rishabh_ has quit IRC | 10:34 | |
| *** rishabh has joined #openstack-manila | 10:44 | |
| *** rishabh is now known as Guest30894 | 10:45 | |
| *** Guest30894 is now known as rishabh_ | 10:46 | |
| *** ganso has joined #openstack-manila | 11:00 | |
| openstackgerrit | jiaohaolin proposed openstack/manila master: Manila share driver for Inspur as13000 staorage. https://review.openstack.org/550454 | 11:53 |
|---|---|---|
| *** caowei has quit IRC | 11:59 | |
| *** assassin has joined #openstack-manila | 12:05 | |
| *** rishabh__ has joined #openstack-manila | 12:32 | |
| *** sticker has joined #openstack-manila | 12:33 | |
| *** rishabh_ has quit IRC | 12:35 | |
| *** rraja has joined #openstack-manila | 12:36 | |
| *** rishabh_ has joined #openstack-manila | 12:47 | |
| *** rishabh__ has quit IRC | 12:50 | |
| *** a-pugachev_ has joined #openstack-manila | 13:49 | |
| *** a-pugachev has quit IRC | 13:51 | |
| *** a-pugachev_ is now known as a-pugachev | 13:51 | |
| *** a-pugachev has quit IRC | 13:55 | |
| *** a-pugachev has joined #openstack-manila | 13:59 | |
| *** dustins has joined #openstack-manila | 14:10 | |
| *** erlon has joined #openstack-manila | 14:21 | |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-tempest-plugin master: Create a default share type https://review.openstack.org/540070 | 14:36 |
| *** erlon_ has joined #openstack-manila | 14:54 | |
| *** erlon has quit IRC | 14:57 | |
| *** erlon_ is now known as erlon | 14:57 | |
| rishabh_ | ganso, zhongjun hi. if you find some time can you please review these patches[1] [2] [3]? [2] and [3] are dependent of [1]. | 15:05 |
| rishabh_ | [1] https://review.openstack.org/539186 | 15:05 |
| rishabh_ | [2] https://review.openstack.org/540394 | 15:05 |
| rishabh_ | [3] https://review.openstack.org/542309 | 15:05 |
| *** eharney has quit IRC | 15:12 | |
| *** a-pugachev has quit IRC | 15:50 | |
| *** rishabh_ has quit IRC | 15:51 | |
| *** gouthamr has joined #openstack-manila | 16:00 | |
| *** a-pugachev has joined #openstack-manila | 16:05 | |
| *** eharney has joined #openstack-manila | 16:06 | |
| *** pcaruana has quit IRC | 16:10 | |
| *** markstur has joined #openstack-manila | 16:10 | |
| *** markstur has quit IRC | 16:12 | |
| *** markstur has joined #openstack-manila | 16:12 | |
| *** a-pugachev has quit IRC | 16:30 | |
| vkmc | ganso, o/ | 16:30 |
| vkmc | ganso, submitted changes as we discussed on the ptg for https://review.openstack.org/#/c/540070/ | 16:30 |
| vkmc | I'm hitting a ton of new errors now... if you have a chance to look into it I'd appreciate | 16:31 |
| *** a-pugachev has joined #openstack-manila | 16:32 | |
| *** sticker has quit IRC | 16:41 | |
| ganso | vkmc: hey =) | 16:43 |
| ganso | vkmc: LVM job timed out, I am looking at the zfsonlinux one | 16:43 |
| ganso | vkmc: type object 'ShareSnapshotUserRulesForCIFSTest' has no attribute 'share_type_id' | 16:43 |
| * vkmc checks | 16:44 | |
| ganso | vkmc: you created the share_type_id attribute in BaseSharesAdminTest | 16:49 |
| ganso | vkmc: some classes do not inherit from that one | 16:49 |
| ganso | vkmc: they inherit from BaseSharesTest, hence, they do not find the attribute | 16:50 |
| vkmc | ganso, that makes sense... I missed a few classes | 16:50 |
| vkmc | thanks for checking | 16:50 |
| ganso | vkmc: same for BaseSharesMixedTest, classes that do not inherit from that directly cannot find the attribute | 16:51 |
| vkmc | ganso, they should, share_type_id is defined for both admin and mixed | 16:51 |
| ganso | vkmc: class BaseShareSnapshotRulesTest(base.BaseSharesTest) | 16:52 |
| ganso | vkmc: that one that is failing inherits from BaseSharesTest | 16:52 |
| ganso | vkmc: and Mixed inherits from BaseSharesTest, so those that one does not inherit from mixed | 16:52 |
| ganso | vkmc: s/those// | 16:53 |
| ganso | vkmc: the way tempest base classes are structured, any class that inherits from BaseSharesTest is never supposed to have access to an admin API | 16:57 |
| vkmc | ganso, yeah, that's is clear | 16:58 |
| vkmc | and for share_type creation you need admin access | 16:58 |
| ganso | vkmc: there is another way to create that attribute and make it accessible to the BaseSharesTest, but it is hacky | 16:58 |
| vkmc | that's why I'm changing those that are base but require a share type as basesharesmixedtest | 16:58 |
| vkmc | yeah | 16:58 |
| ganso | vkmc: your code is currently creating 2 share types, one in mixed and one in admin base class | 16:59 |
| vkmc | exactly | 16:59 |
| ganso | vkmc: you could try doing a conf.set_default on a config option after creating one, and then it will be accessible for every test | 17:00 |
| ganso | vkmc: I am not sure that works because by then all classes may have an instance of conf that does not include the new default | 17:01 |
| ganso | vkmc: depends on how pointers to conf are implemented | 17:01 |
| ganso | vkmc: it will be also prone to race conditions :\ | 17:02 |
| vkmc | ganso, I thought about it... if we had a way of making a share_type default... that would be another history | 17:02 |
| vkmc | yeah | 17:02 |
| vkmc | the current approach is not the best I think, but at least is one share_type per class | 17:02 |
| ganso | vkmc: yes, but what would your solution for the ones that inherit BaseSharesTest be? | 17:03 |
| vkmc | ganso, let me see which are those tests | 17:05 |
| vkmc | probably we need a share_type for the majority of tests | 17:05 |
| vkmc | ganso, for the ones that need to create a share, we need to create a share type | 17:12 |
| vkmc | hence we would need those tests to inherit from the mixed class | 17:13 |
| vkmc | imho there shouldn't be a security concern on that front | 17:13 |
| ganso | vkmc: agreed | 17:13 |
| vkmc | I'll submit the required changes and we can discuss on the weekly meeting | 17:14 |
| vkmc | and see if someone thing we should do it in a different way | 17:14 |
| *** markstur has quit IRC | 17:26 | |
| *** markstur has joined #openstack-manila | 17:27 | |
| *** a-pugachev has quit IRC | 17:32 | |
| *** markstur has quit IRC | 17:49 | |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-tempest-plugin master: Create a default share type https://review.openstack.org/540070 | 17:49 |
| *** markstur has joined #openstack-manila | 17:50 | |
| *** pcaruana has joined #openstack-manila | 17:57 | |
| *** AlexeyAbashkin has quit IRC | 18:06 | |
| *** markstur_ has joined #openstack-manila | 18:15 | |
| *** markstur has quit IRC | 18:18 | |
| *** rraja has quit IRC | 19:00 | |
| *** erlon has quit IRC | 19:24 | |
| *** harlowja has joined #openstack-manila | 19:26 | |
| *** AlexeyAbashkin has joined #openstack-manila | 19:33 | |
| *** AlexeyAbashkin has quit IRC | 19:37 | |
| *** AlexeyAbashkin has joined #openstack-manila | 19:38 | |
| *** eharney has quit IRC | 19:54 | |
| *** eharney has joined #openstack-manila | 19:59 | |
| *** a-pugachev has joined #openstack-manila | 20:20 | |
| *** AlexeyAbashkin has quit IRC | 20:29 | |
| *** AlexeyAbashkin has joined #openstack-manila | 20:45 | |
| *** AlexeyAbashkin has quit IRC | 20:50 | |
| *** gouthamr has quit IRC | 20:57 | |
| *** AlexeyAbashkin has joined #openstack-manila | 21:04 | |
| *** pcaruana has quit IRC | 21:12 | |
| *** AlexeyAbashkin has quit IRC | 21:28 | |
| *** a-pugachev has quit IRC | 21:54 | |
| *** openstackstatus has quit IRC | 22:13 | |
| *** openstack has joined #openstack-manila | 22:16 | |
| *** ChanServ sets mode: +o openstack | 22:16 | |
| *** eharney has quit IRC | 22:36 | |
| *** openstackstatus has quit IRC | 22:42 | |
| *** openstack has joined #openstack-manila | 22:45 | |
| *** ChanServ sets mode: +o openstack | 22:45 | |
| *** AlexeyAbashkin has joined #openstack-manila | 22:46 | |
| *** tpsilva has quit IRC | 22:47 | |
| *** AlexeyAbashkin has quit IRC | 22:51 | |
| *** threestrands has joined #openstack-manila | 23:12 | |
| *** threestrands has quit IRC | 23:12 | |
| *** threestrands has joined #openstack-manila | 23:12 | |
| *** threestrands_ has joined #openstack-manila | 23:34 | |
| *** threestrands_ has quit IRC | 23:34 | |
| *** threestrands_ has joined #openstack-manila | 23:34 | |
| *** threestrands_ has quit IRC | 23:35 | |
| *** threestrands_ has joined #openstack-manila | 23:36 | |
| *** threestrands has quit IRC | 23:36 | |
| *** jmlowe has joined #openstack-manila | 23:39 | |
| *** AlexeyAbashkin has joined #openstack-manila | 23:45 | |
| *** AlexeyAbashkin has quit IRC | 23:49 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!