Wednesday, 2019-01-02

*** a-pugachev has joined #openstack-manila09:07
openstackgerritMerged openstack/manila master: Add devstack instructions and local.conf samples  https://review.openstack.org/62702009:27
*** e0ne has joined #openstack-manila10:17
*** erlon_ has joined #openstack-manila10:28
openstackgerritMerged openstack/manila master: Adjust ssh timeouts  https://review.openstack.org/62779412:12
openstackgerritMerged openstack/manila master: QNAP: Support QES FW on TDS series NAS  https://review.openstack.org/62789413:38
openstackgerritMerged openstack/manila stable/queens: Fix image_name retrieval in custom-image jobs  https://review.openstack.org/62773014:07
*** erlon_ has quit IRC14:33
openstackgerritTom Barron proposed openstack/manila stable/pike: Fix image_name retrieval in custom-image jobs  https://review.openstack.org/62798114:35
openstackgerritMerged openstack/manila master: [DevRef] Add code review guideline  https://review.openstack.org/60959814:52
*** carlos_silva has joined #openstack-manila15:32
openstackgerritweizj proposed openstack/python-manilaclient master: Update hacking version  https://review.openstack.org/62769815:33
*** e0ne has quit IRC15:41
*** erlon has joined #openstack-manila16:16
*** a-pugachev has left #openstack-manila16:29
openstackgerritweizj proposed openstack/python-manilaclient master: Update hacking version  https://review.openstack.org/62769816:41
openstackgerritTom Barron proposed openstack/manila master: Add Ubuntu Bionic CephFS jobs  https://review.openstack.org/62446716:49
openstackgerritTom Barron proposed openstack/manila master: DNM - test Ubuntu Bionic CephFS jobs under python3  https://review.openstack.org/62800316:51
*** a-pugachev has joined #openstack-manila17:00
openstackgerritTom Barron proposed openstack/manila master: DNM: Test Python3 first devstack  https://review.openstack.org/62306117:07
*** a-pugachev has quit IRC17:32
*** a-pugachev has joined #openstack-manila17:34
*** vollman has quit IRC17:43
*** a-pugachev has quit IRC17:49
openstackgerritTom Barron proposed openstack/manila master: Improve service instance module debug logging  https://review.openstack.org/62779618:19
openstackgerritThomas Bechtold proposed openstack/manila master: Drop is_eventlet_bug105() from manila/utils.py  https://review.openstack.org/62802919:30
toabctlbswartz, tbarron do you remember why https://review.openstack.org/#/c/511048/ was added? the functions are not used and the commit msg doesn't explain why theses are needed19:48
toabctlhappy new year btw!19:49
toabctl^^ this is a perfect example why commit messages are so important :)19:49
bswartztoabctl: >_<19:50
bswartzI do remember why it was added19:50
bswartzLook at the "related changes"19:50
toabctlah. now I also remember :)19:51
bswartzhttps://review.openstack.org/#/c/47623919:51
bswartzPerhaps it was a mistake to break up the change into smaller ones19:51
toabctlbswartz, nope. but a mistake to not explain in the commit msg that follow up commits will use this to do xyz :)19:52
toabctlbswartz, do you plan to work on https://review.openstack.org/#/c/476239 ?19:53
bswartzHonestly the intent was to merge the whole patch series somewhat quickly in sequence19:54
bswartzA wrench got thrown into my plans however and I'm trying to remember what blocked my progress19:54
*** erlon has quit IRC19:54
toabctlbswartz, do you mind if I rebase the patchset ?19:55
bswartzI think I wasn't able to think of a good clean upgrade strategy19:55
bswartzSo people using the existing LVM or generic driver could simply upgrade and having nothing break19:55
bswartzMy initial design assumed a green field deployment and it works fine in that case19:56
bswartzYou're welcome to rebase it19:56
openstackgerritThomas Bechtold proposed openstack/manila master: Reapply access rules when doing ensure share  https://review.openstack.org/54862420:10
*** carlos_silva has quit IRC20:31
openstackgerritTom Barron proposed openstack/manila master: Add Ubuntu Bionic CephFS jobs  https://review.openstack.org/62446721:00
*** jmlowe has quit IRC21:09
*** jmlowe has joined #openstack-manila21:12
openstackgerritTom Barron proposed openstack/manila master: Improve service instance module debug logging  https://review.openstack.org/62779621:17
*** e0ne has joined #openstack-manila22:51
*** e0ne has quit IRC23:19

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!