| *** tosky has quit IRC | 00:23 | |
| *** eharney has quit IRC | 01:19 | |
| *** whoami-rajat has joined #openstack-manila | 02:01 | |
| *** kshitija has joined #openstack-manila | 06:20 | |
| *** kshitija has quit IRC | 06:29 | |
| *** kshitija has joined #openstack-manila | 06:34 | |
| *** logan- has quit IRC | 07:35 | |
| *** logan- has joined #openstack-manila | 07:37 | |
| *** pcaruana has joined #openstack-manila | 08:35 | |
| *** tosky has joined #openstack-manila | 08:39 | |
| *** e0ne has joined #openstack-manila | 09:25 | |
| *** FlorianFa has quit IRC | 09:30 | |
| *** tbarron has quit IRC | 09:30 | |
| *** FlorianFa has joined #openstack-manila | 09:35 | |
| *** kshitija has quit IRC | 09:50 | |
| *** kshitija has joined #openstack-manila | 10:04 | |
| *** kshitija has quit IRC | 10:20 | |
| *** erlon has joined #openstack-manila | 10:48 | |
| *** mauricio_ps has joined #openstack-manila | 10:48 | |
| *** luizbag has joined #openstack-manila | 10:52 | |
| *** ganso has joined #openstack-manila | 10:58 | |
| *** thgcorrea has joined #openstack-manila | 11:13 | |
| *** arne_wiebalck_ has joined #openstack-manila | 12:27 | |
| *** logan_ has joined #openstack-manila | 12:27 | |
| *** logan_ is now known as Guest11647 | 12:28 | |
| *** gouthamr has quit IRC | 12:30 | |
| *** kaisers has quit IRC | 12:30 | |
| *** arne_wiebalck has quit IRC | 12:30 | |
| *** logan- has quit IRC | 12:30 | |
| *** openstackgerrit has quit IRC | 12:30 | |
| *** arne_wiebalck_ is now known as arne_wiebalck | 12:30 | |
| *** Guest11647 is now known as logan- | 12:31 | |
| *** kaisers has joined #openstack-manila | 12:32 | |
| *** gouthamr has joined #openstack-manila | 12:33 | |
| *** arne_wiebalck has quit IRC | 13:05 | |
| *** arne_wiebalck has joined #openstack-manila | 13:07 | |
| *** enriquetaso has joined #openstack-manila | 13:52 | |
| *** enriquetaso has quit IRC | 14:19 | |
| *** enriquetaso has joined #openstack-manila | 14:30 | |
| *** eharney has joined #openstack-manila | 14:46 | |
| *** enriquetaso has quit IRC | 14:48 | |
| *** eharney has quit IRC | 15:13 | |
| *** eharney has joined #openstack-manila | 15:15 | |
| *** e0ne has quit IRC | 15:16 | |
| ganso | gouthamr: hey, we got a dependency problem going on | 15:18 |
|---|---|---|
| ganso | gouthamr: patch https://review.openstack.org/#/c/638231 does not have its dependencies applies probably because of https://review.openstack.org/#/c/635885 | 15:19 |
| ganso | gouthamr: the ideal way of setting up dependencies and merging would be 635885 <= 635831 <= 638231 | 15:20 |
| ganso | gouthamr: but I believe we will need to change to 638231 <= 635831 | 15:20 |
| ganso | gouthamr: there is no way we can run 635831 standalone, because of the test 635885 disables | 15:21 |
| ganso | gouthamr: I've never tested running manila-tempest-plugin with a higher microversion than manila... hopefully that works | 15:22 |
| *** enriquetaso has joined #openstack-manila | 15:43 | |
| *** e0ne has joined #openstack-manila | 15:53 | |
| ganso | gouthamr: yea it doesn't work https://review.openstack.org/639366 | 16:04 |
| ganso | gouthamr: I think we will need to split the tests | 16:08 |
| ganso | gouthamr: and merge it first | 16:09 |
| *** lseki has joined #openstack-manila | 16:15 | |
| *** jmlowe has quit IRC | 16:32 | |
| *** pcaruana has quit IRC | 16:32 | |
| *** kshitija has joined #openstack-manila | 16:50 | |
| *** e0ne has quit IRC | 17:24 | |
| * gouthamr reads scrollback | 17:35 | |
| *** jmlowe has joined #openstack-manila | 17:40 | |
| gouthamr | ganso: i don't see the problem on the upstream gate | 17:41 |
| gouthamr | s/the problem/a problem | 17:41 |
| *** kshitija has quit IRC | 17:41 | |
| gouthamr | what is the dependency problem here? i.e, what breaks? | 17:42 |
| *** openstackgerrit has joined #openstack-manila | 17:42 | |
| openstackgerrit | Merged openstack/puppet-manila stable/rocky: Support cephfs_volume_mode parameter https://review.openstack.org/639327 | 17:42 |
| ganso | gouthamr: sorry for the delay | 17:44 |
| ganso | gouthamr: https://review.openstack.org/#/c/638231 is not running the tests accordingly | 17:44 |
| ganso | gouthamr: if you check the skip message on test_share_manage module tests, they don't make sense, it is like the patch is not being applied at all | 17:45 |
| ganso | gouthamr: the message is not even in the code anymore | 17:45 |
| gouthamr | ganso: http://logs.openstack.org/31/638231/3/check/manila-tempest-minimal-dsvm-dummy/dc29533/logs/tempest_2/testr_results.html.gz <- dummy driver test run from https://review.openstack.org/#/c/638231 | 17:57 |
| gouthamr | ganso: there are other manage tests from the class, and they have run | 17:58 |
| gouthamr | which job are you finding them skipped on? | 17:58 |
| gouthamr | ganso: on a side note, please enable the tests for the container driver implementation patch, or, make the tests depend on the container driver implementation | 18:00 |
| ganso | gouthamr: yea I noticed that I still have to enable them for the container driver. I can't find test_share_servers_manage in the dummy driver run | 18:00 |
| ganso | gouthamr: perhaps it is skipping the class entirely and not printing it | 18:01 |
| ganso | gouthamr: probably because it is not enable in dummy driver DHSS=True run | 18:01 |
| ganso | gouthamr: ok so perhaps the problem is in our CI, not in upstream CI, our CI is currently unable to run the tests at all due to the dependencies | 18:02 |
| gouthamr | ganso: yes, if there's a skip decorator on a test class or method, the tests involved are not "discovered" during the initial test discovery | 18:02 |
| ganso | gouthamr: thanks for the help Goutham, will enable the dummy and container tests | 18:03 |
| gouthamr | ganso: yes, i think we saw that problem on an earlier patch of mine, your CI needs to translate the review URLs to change IDs perhaps.. | 18:03 |
| ganso | gouthamr: so if we change all patches to use change IDs perhaps it will work? | 18:03 |
| gouthamr | ganso: https://review.openstack.org/#/c/628921/ started passing on the netapp job only after the parent merged in manila | 18:04 |
| ganso | gouthamr: since we may be using an older version of gerrit, our gerrit probably does not know how to handle depends-on with URLs | 18:04 |
| ganso | gouthamr: hmm makes sense | 18:04 |
| gouthamr | ganso: your zuul, the depends-on code became really simple in zuulv3 | 18:04 |
| ganso | gouthamr: yea ok, I will change everything to changeIDs | 18:04 |
| *** kshitija has joined #openstack-manila | 18:04 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila-tempest-plugin master: Temporarily disable test_manage_invalid https://review.openstack.org/635885 | 18:20 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Add manage/unmanage of shares in DHSS=True https://review.openstack.org/635831 | 18:34 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Add manage/unmanage of shares in DHSS=True https://review.openstack.org/635831 | 18:36 |
| gouthamr | amito: check these changes: https://review.openstack.org/#/q/status:open+project:openstack/manila+branch:master+topic:pylint , and if you agree, pl0x merge 'em :) | 18:39 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: [NetApp] Add manage/unmanage of share servers https://review.openstack.org/636625 | 18:39 |
| gouthamr | amito: Please review the pylint changes in this order: https://review.openstack.org/637659/ https://review.openstack.org/638127/ https://review.openstack.org/638067/ https://review.openstack.org/638075/ https://review.openstack.org/638095/ | 18:40 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila-tempest-plugin master: Add functional tests for manage/unmanage of shares in DHSS=True https://review.openstack.org/638231 | 18:42 |
| amito | I'll look at it tonight (your daytime :P it's GMT+2 here) and tomorrow morning, and merge it :) | 18:43 |
| amito | gouthamr: ^ | 18:44 |
| gouthamr | amito: absolutely, yeah, don't let pylint keep you up at night :D | 18:44 |
| amito | gouthamr: it's either that or completing another quest in Witcher 3 :P | 18:46 |
| gouthamr | amito: lol :D enjoy! | 18:46 |
| amito | gouthamr: thx! | 18:46 |
| *** gouthamr has quit IRC | 19:20 | |
| *** gouthamr_ has joined #openstack-manila | 19:20 | |
| *** e0ne has joined #openstack-manila | 19:26 | |
| *** e0ne has quit IRC | 19:46 | |
| *** e0ne has joined #openstack-manila | 19:46 | |
| *** thgcorrea has quit IRC | 20:00 | |
| *** mauricio_ps has quit IRC | 20:04 | |
| *** luizbag has quit IRC | 20:07 | |
| openstackgerrit | Eric Harney proposed openstack/python-manilaclient master: Re-enable shell completion cache https://review.openstack.org/639424 | 20:09 |
| *** enriquetaso has quit IRC | 20:24 | |
| *** enriquetaso has joined #openstack-manila | 20:25 | |
| *** e0ne has quit IRC | 20:31 | |
| *** kshitija has quit IRC | 20:36 | |
| *** gouthamr_ is now known as gouthamr | 20:42 | |
| *** takamatsu_ has quit IRC | 20:48 | |
| *** jmlowe has quit IRC | 20:49 | |
| *** takamatsu_ has joined #openstack-manila | 20:50 | |
| ganso | gouthamr: do you think it makes more sense to change container's driver CI regex to run on all API_WITH_BACKEND, or tag the tests to be BACKEND tests instead of API_WITH_BACKEND? | 20:51 |
| ganso | gouthamr: I am more inclined on the former | 20:51 |
| ganso | gouthamr: the container driver is running only 7 tests | 20:51 |
| ganso | gouthamr: I think it should be running more | 20:52 |
| ganso | bswartz, toabctl: Hi folks! Friendly reminder that Manage/Unmanage in DHSS=True patches are ready in gerrit waiting for your reviews: https://wiki.openstack.org/wiki/Manila/SteinCycle#Manage.2FUnmanage_Share_Servers | 20:54 |
| ganso | gouthamr, tbarron: thanks for the reviews so far =D | 20:54 |
| gouthamr | ganso: why not run the full tree? i'd be glad if we didn't filter out the API tests for any of the first party drivers | 20:58 |
| gouthamr | ganso: doubt we're seeing any issues with running time that we envisioned with those tags | 20:59 |
| gouthamr | s/with those/that warranted those | 20:59 |
| *** lseki has quit IRC | 21:01 | |
| *** erlon has quit IRC | 21:02 | |
| ganso | gouthamr: hmm okay :D | 21:04 |
| ganso | gouthamr: but depending on how long it takes (and how unstable it might get due to flaky tests) we might need to change to API_WITH_BACKEND | 21:06 |
| *** jmlowe has joined #openstack-manila | 21:06 | |
| *** enriquetaso has quit IRC | 21:18 | |
| *** e0ne has joined #openstack-manila | 21:28 | |
| *** eharney has quit IRC | 21:33 | |
| *** whoami-rajat has quit IRC | 21:41 | |
| *** e0ne has quit IRC | 22:03 | |
| gouthamr | ganso: true, but the subset of the tests that we'd not be running (i.e, only API tests) are usually only negative tests and they're never supposed to break! | 22:04 |
| gouthamr | okay on to your other patches | 22:04 |
| ganso | gouthamr: haha you should check the dummy driver job failures then | 22:05 |
| gouthamr | ganso: which ones? i know of two issues with concurrency, both both do need the dummy driver to be up and running, so are API_WITH_BACKEND | 22:06 |
| gouthamr | ganso: small activity based off on tbarron's meticulous logging/tagging of these bugs: https://bugs.launchpad.net/manila/+bugs?field.tag=races | 22:10 |
| ganso | gouthamr: test_revert_to_snapshot.RevertToSnapshotTest.test_revert_to_latest_snapshot_2_2_46 and setUpClass (manila_tempest_tests.tests.api.admin.test_migration.MigrationWithDifferentSnapshotSupportNFSTest) | 22:14 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: [DNM] debug https://review.openstack.org/639188 | 22:38 |
| *** cmoura has quit IRC | 23:11 | |
| *** cmoura has joined #openstack-manila | 23:11 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!