| *** erlon has quit IRC | 00:20 | |
| *** irclogbot_2 has quit IRC | 02:19 | |
| *** lpetrut has joined #openstack-manila | 03:50 | |
| *** lpetrut has quit IRC | 04:19 | |
| *** ianychoi has quit IRC | 05:23 | |
| *** ianychoi has joined #openstack-manila | 05:24 | |
| *** whoami-rajat has joined #openstack-manila | 05:31 | |
| *** kopecmartin|off is now known as kopecmartin | 06:30 | |
| *** lpetrut has joined #openstack-manila | 06:57 | |
| *** pcaruana has joined #openstack-manila | 06:58 | |
| *** pcaruana has quit IRC | 07:02 | |
| *** pcaruana has joined #openstack-manila | 07:02 | |
| *** tosky has joined #openstack-manila | 07:13 | |
| *** carthaca has joined #openstack-manila | 07:15 | |
| *** e0ne has joined #openstack-manila | 07:40 | |
| *** e0ne has quit IRC | 08:11 | |
| *** e0ne has joined #openstack-manila | 08:16 | |
| *** a-pugachev has joined #openstack-manila | 08:33 | |
| *** e0ne has quit IRC | 08:50 | |
| *** e0ne has joined #openstack-manila | 08:59 | |
| *** e0ne has quit IRC | 09:16 | |
| *** e0ne has joined #openstack-manila | 09:35 | |
| *** a-pugachev has quit IRC | 10:18 | |
| *** a-pugachev has joined #openstack-manila | 10:20 | |
| *** e0ne has quit IRC | 10:45 | |
| *** carlos_silva has joined #openstack-manila | 10:57 | |
| *** e0ne has joined #openstack-manila | 11:03 | |
| *** e0ne has quit IRC | 11:10 | |
| *** erlon has joined #openstack-manila | 11:13 | |
| *** erlon has quit IRC | 11:39 | |
| *** dviroel_ has joined #openstack-manila | 11:41 | |
| *** erlon has joined #openstack-manila | 11:46 | |
| *** a-pugachev has quit IRC | 11:53 | |
| *** a-pugachev has joined #openstack-manila | 11:58 | |
| *** e0ne has joined #openstack-manila | 12:11 | |
| openstackgerrit | Tom Barron proposed openstack/manila-tempest-plugin master: Add devstack plugin to ease integration tests Instead of requiring users to install the plugin manually, add a devstack plugin that can be enabled in order to perform the installation. This change should allow us to remove the tempest plugin ins https://review.openstack.org/648716 | 12:14 |
|---|---|---|
| openstackgerrit | Tom Barron proposed openstack/manila master: [tests] run all dsvm jobs with python3 https://review.openstack.org/646037 | 12:14 |
| *** enriquetaso has joined #openstack-manila | 12:35 | |
| *** thgcorrea has joined #openstack-manila | 12:37 | |
| *** e0ne has quit IRC | 12:38 | |
| *** jmlowe has quit IRC | 12:55 | |
| *** whoami-rajat has quit IRC | 13:00 | |
| *** a-pugachev has quit IRC | 13:02 | |
| *** whoami-rajat has joined #openstack-manila | 13:05 | |
| *** lseki has joined #openstack-manila | 13:24 | |
| *** irclogbot_1 has joined #openstack-manila | 13:26 | |
| openstackgerrit | Tom Barron proposed openstack/manila-tempest-plugin master: DNM https://review.openstack.org/648716 | 13:32 |
| *** eharney has joined #openstack-manila | 13:39 | |
| *** jmlowe has joined #openstack-manila | 13:55 | |
| *** erlon has quit IRC | 14:00 | |
| *** mrhillsman_wkend is now known as mrhillsman | 14:04 | |
| *** e0ne has joined #openstack-manila | 14:06 | |
| *** nirg22 has joined #openstack-manila | 14:30 | |
| nirg22 | hi! how should I except a manila InvalidInput exception inside a tempest scenario test ? | 14:31 |
| nirg22 | https://github.com/openstack/manila/blob/d877b61c5e37ff012341194b8349af6f38155e5d/manila/share/api.py#L1953 | 14:31 |
| openstackgerrit | Nir Gilboa proposed openstack/manila-tempest-plugin master: Scenario test: Create/shrink share and write data https://review.openstack.org/531615 | 14:36 |
| tbarron | nirg22: do you mean *expect* a manila InvalidInput exception inside a tempest scenario test? | 14:39 |
| tbarron | nirg22: you said 'except a manila Invalid...' | 14:40 |
| tbarron | nirg22: if so, then you can use assertRaises ... | 14:40 |
| tbarron | nirg22: there should be examples under manila_tempest_tests/api/ in some of the negative tests | 14:41 |
| nirg22 | tbarron: actually I would like to try/except it :) | 14:41 |
| tbarron | nirg22: e.g. manila_tempest_tests/tests/api/test_revert_to_snapshot_negative.py | 14:41 |
| nirg22 | tbarron: and this particular exception is not present in tempest exceptions, that's why I'm unsure | 14:41 |
| nirg22 | tbarron: you see the context and gouthamr suggestion on the review I just suggested above | 14:43 |
| nirg22 | tbarron: *can see | 14:43 |
| tbarron | nirg22: well, you can certaily try/except, can you mirror the manila exception in manila_tempest_tests/share_exceptions.py as a tempest exception? | 14:46 |
| tbarron | nirg22: i'm not 100% on that, but maybe that's the way we do it | 14:46 |
| nirg22 | tbarron: ok thanks I'll try that | 14:47 |
| *** a-pugachev has joined #openstack-manila | 14:51 | |
| *** nirg22 has quit IRC | 15:00 | |
| *** lpetrut has quit IRC | 15:04 | |
| *** e0ne has quit IRC | 15:24 | |
| *** e0ne has joined #openstack-manila | 15:44 | |
| *** e0ne has quit IRC | 15:47 | |
| *** a-pugachev has quit IRC | 16:10 | |
| *** kopecmartin is now known as kopecmartin|off | 16:30 | |
| *** erlon has joined #openstack-manila | 16:32 | |
| *** e0ne has joined #openstack-manila | 16:45 | |
| tbarron | ping bswartz ganso xyang Is there any reason for the basic index and show share server apis to be admin only? | 16:47 |
| tbarron | bswartz: ganso xyang they have been that way since day zero: git show 66fd6ab621bafaef58ea7f59ccd8eb9abc4698f2 | 16:47 |
| ganso | tbarron: yes, users shouldn't know about share servers | 16:47 |
| tbarron | bswartz: ganso xyang but this breaks horizon share network | 16:47 |
| ganso | tbarron: breaks how? | 16:48 |
| tbarron | bswartz: ganso xyang you click on a share network and | 16:48 |
| tbarron | bswartz: ganso xyang it comes up with "Unable to show share network details" if | 16:48 |
| tbarron | bswartz: ganso xyang if you are a regular "demo" user | 16:49 |
| ganso | tbarron: I believe something broke it then, it was working last time I used horizon | 16:49 |
| tbarron | bswartz: ganso xyang and the horizon log shows it's trying to retrieve that share servers associated with that share network | 16:49 |
| ganso | tbarron: share networks don't show any share server information other than the ID. I am not sure if the share server ID gets filtered out when the request context is not admin | 16:50 |
| ganso | tbarron: but even so, being a demo tenant shouldn't break it. Is it failing in the DB layer because it does not have permissions to invoke share server get DB methods? | 16:51 |
| tbarron | ganso: vkmc pointed me to https://bugs.launchpad.net/manila-ui/+bug/1702396 | 16:51 |
| openstack | Launchpad bug 1702396 in manila-ui "Non-admin user can't get the share network details" [Medium,Triaged] - Assigned to Victoria Martinez de la Cruz (vkmc) | 16:51 |
| ganso | tbarron: it could be all those check_context decorators that we added to the DB layer | 16:51 |
| tbarron | ganso: it fails at policy validation and if I add a policy rule to allow listing share servers then it works | 16:52 |
| ganso | tbarron: policies are at the API level | 16:52 |
| tbarron | ganso: yes | 16:52 |
| tbarron | ganso: I don't think it's as DB issue | 16:52 |
| ganso | tbarron: if the share networks API policy allows share networks to be listed by non-admin, where is the other policy check that is preventing the API code from obtaining share servers? | 16:53 |
| tbarron | ganso: that bug was reported July 2017 and we just got it reported downstream for OSP13 (queens) | 16:53 |
| ganso | tbarron: yea last time I used horizon was around mitaka~pike | 16:53 |
| ganso | tbarron: oops, ocata~pike | 16:53 |
| tbarron | ganso: share *networks* can be but share *servers* cannnot and horizon calls both when you click on a share network | 16:54 |
| ganso | tbarron: oh so horizon is invoking the APIs | 16:54 |
| ganso | tbarron: IMO it shouldn't be | 16:54 |
| ganso | tbarron: there are 2 types of views for share networks | 16:54 |
| ganso | tbarron: one is the project view, which should only show share network information (perhaps also share_server_id (or filtered out), as I mentioned above)) | 16:55 |
| tbarron | vkmc: ganso xyang bswartz so we could say the bug is in horizon and it should not attempt to get the share net info | 16:55 |
| tbarron | s/share net/share server/ | 16:55 |
| tbarron | share server info | 16:55 |
| ganso | tbarron: the other is the share network admin view, when you go to admin section... there we could show share server details along with share networks, although no reason to do that because we also have the share server tab | 16:55 |
| ganso | tbarron: yes, I believe the bug is in horizon | 16:56 |
| tbarron | ganso: i see, thanks! | 16:56 |
| *** erlon has quit IRC | 17:10 | |
| openstackgerrit | Tom Barron proposed openstack/manila-tempest-plugin master: DNM https://review.openstack.org/648716 | 17:33 |
| *** e0ne has quit IRC | 17:35 | |
| *** zigo has quit IRC | 17:37 | |
| *** gouthamr has left #openstack-manila | 17:38 | |
| *** gouthamr has joined #openstack-manila | 17:38 | |
| *** e0ne has joined #openstack-manila | 17:57 | |
| openstackgerrit | Tom Barron proposed openstack/manila-tempest-plugin master: DNM https://review.openstack.org/648716 | 18:17 |
| *** gouthamr has left #openstack-manila | 18:21 | |
| *** gouthamr has joined #openstack-manila | 18:21 | |
| ganso | tbarron, gouthamr: have you ever had a problem with the generic driver and python-manilaclient, where the generic driver invokes nova to create an instance, it fails saying I don't have supplied credentials? | 18:23 |
| gouthamr | ganso: no, the driver uses the nova client created within manila, and service credentials configured in manila.conf | 18:23 |
| ganso | gouthamr: hmmm perhaps my manila.conf is incorrect. Thought it was a problem with the context, will check, thanks! | 18:24 |
| gouthamr | ganso: yw! | 18:24 |
| *** e0ne has quit IRC | 18:28 | |
| *** erlon has joined #openstack-manila | 18:59 | |
| *** eharney has quit IRC | 19:09 | |
| *** erlon has quit IRC | 19:11 | |
| *** erlon_ has joined #openstack-manila | 19:11 | |
| *** jmlowe has quit IRC | 19:22 | |
| *** e0ne has joined #openstack-manila | 19:27 | |
| *** thgcorrea has quit IRC | 19:56 | |
| *** jmlowe has joined #openstack-manila | 20:26 | |
| *** whoami-rajat has quit IRC | 20:30 | |
| openstackgerrit | Tom Barron proposed openstack/manila-ui master: Show share network details to non-admin https://review.openstack.org/649184 | 20:32 |
| openstackgerrit | Tom Barron proposed openstack/manila-tempest-plugin master: Add devstack plugin to ease integration tests https://review.openstack.org/648716 | 20:37 |
| openstackgerrit | Tom Barron proposed openstack/manila master: [tests] run all dsvm jobs with python3 https://review.openstack.org/646037 | 20:39 |
| openstackgerrit | Tom Barron proposed openstack/manila-ui master: Don't show host field in project tables https://review.openstack.org/591779 | 20:41 |
| *** a-pugachev has joined #openstack-manila | 20:57 | |
| *** a-pugachev has quit IRC | 20:58 | |
| *** e0ne has quit IRC | 21:03 | |
| *** erlon_ has quit IRC | 21:05 | |
| *** pcaruana has quit IRC | 21:17 | |
| openstackgerrit | Tom Barron proposed openstack/manila-ui master: Don't show host field in project tables https://review.openstack.org/591779 | 21:34 |
| *** a-pugachev has joined #openstack-manila | 21:45 | |
| *** mrhillsman is now known as mrhillsman_afk | 21:46 | |
| *** eharney has joined #openstack-manila | 21:52 | |
| *** a-pugachev has quit IRC | 21:53 | |
| *** eharney has quit IRC | 22:04 | |
| *** carlos_silva has quit IRC | 22:16 | |
| *** tosky has quit IRC | 23:28 | |
| *** openstackgerrit has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!