| *** lseki has quit IRC | 00:09 | |
| *** enriquetaso has quit IRC | 00:27 | |
| *** brinzhang has joined #openstack-manila | 01:59 | |
| brinzhang | gouthamr: Could you please review these ptach for manila and manilaclient? https://review.opendev.org/#/q/topic:bp/update-share-type-name-or-description+(status:open+OR+status:merged) | 02:00 |
|---|---|---|
| *** baojg has joined #openstack-manila | 02:03 | |
| *** Kuirong has joined #openstack-manila | 03:26 | |
| *** whoami-rajat has joined #openstack-manila | 03:41 | |
| *** kopecmartin|off is now known as kopecmartin | 05:46 | |
| *** takamatsu has joined #openstack-manila | 06:13 | |
| *** Kuirong has quit IRC | 06:31 | |
| *** e0ne has joined #openstack-manila | 06:57 | |
| *** e0ne has quit IRC | 06:59 | |
| *** pcaruana has quit IRC | 07:12 | |
| openstackgerrit | DingDong proposed openstack/manila master: [Unity] Driver Un-handled Share Server Support. https://review.opendev.org/673948 | 07:30 |
| *** pcaruana has joined #openstack-manila | 07:42 | |
| openstackgerrit | KuiRong proposed openstack/manila master: Add Infortrend Manila Driver https://review.opendev.org/657775 | 07:47 |
| *** e0ne has joined #openstack-manila | 07:53 | |
| *** tosky has joined #openstack-manila | 07:54 | |
| *** lpetrut has joined #openstack-manila | 08:03 | |
| *** lpetrut has quit IRC | 08:04 | |
| *** lpetrut has joined #openstack-manila | 08:04 | |
| openstackgerrit | WooHyung Han proposed openstack/manila master: [CI] Enable glusterfs CI jobs https://review.opendev.org/673771 | 08:13 |
| openstackgerrit | WooHyung Han proposed openstack/manila master: [CI] Enable glusterfs CI jobs https://review.opendev.org/673771 | 08:13 |
| *** lpetrut has quit IRC | 08:29 | |
| openstackgerrit | DingDong proposed openstack/manila master: [Unity] Driver Un-handled Share Server Support. https://review.opendev.org/673948 | 09:15 |
| *** e0ne_ has joined #openstack-manila | 09:36 | |
| *** e0ne has quit IRC | 09:37 | |
| *** e0ne has joined #openstack-manila | 11:29 | |
| *** e0ne_ has quit IRC | 11:30 | |
| *** tosky has quit IRC | 13:10 | |
| *** tosky has joined #openstack-manila | 13:10 | |
| *** enriquetaso has joined #openstack-manila | 13:13 | |
| *** enriquetaso has quit IRC | 13:15 | |
| *** lseki has joined #openstack-manila | 13:33 | |
| *** carloss has joined #openstack-manila | 13:36 | |
| *** enriquetaso has joined #openstack-manila | 13:42 | |
| *** eharney has joined #openstack-manila | 13:46 | |
| *** s0ru has joined #openstack-manila | 14:16 | |
| *** e0ne has quit IRC | 15:37 | |
| *** whoami-rajat has quit IRC | 15:51 | |
| *** enriquetaso has quit IRC | 16:48 | |
| *** whoami-rajat has joined #openstack-manila | 17:15 | |
| lseki | Hi folks, we're coding python-manilaclient to make it work w/ multiple subnets. | 17:21 |
| lseki | I wonder if it's possible to make manilaclient require different set of parameters according to the --os-share-api-version I specify. | 17:21 |
| lseki | For instance, we want the new api version 2.50 to require share_network_subnet parameter | 17:21 |
| lseki | https://www.irccloud.com/pastebin/yJFPgBOT/ | 17:22 |
| lseki | https://www.irccloud.com/pastebin/v4k07SMB/ | 17:22 |
| *** kopecmartin is now known as kopecmartin|off | 17:24 | |
| lseki | In the shell implementation, there're several methods using the decorator @api_versions.wraps('X.Y') https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py | 17:25 |
| lseki | do I just need to add a new method do_share_server_manage w/ decorator @api_version.wraps('2.50'), and add it the new parameter? | 17:30 |
| vkmc | lseki, I believe you can use that decorator | 17:31 |
| vkmc | lseki, or maybe you can set a default value to the extra param... and for previous versions you do nothing | 17:33 |
| lseki | vkmc: seems that the # of parameters are being verified before the version... for instance, the snapshot-manage command that was introduced on 2.12: | 17:36 |
| lseki | https://www.irccloud.com/pastebin/6ccEZ5RT/ | 17:36 |
| lseki | it just ignores the api version I specified, and shows the expected parameters | 17:36 |
| lseki | it only tell me the version support issue when I pass the parameters it expects: | 17:37 |
| lseki | https://www.irccloud.com/pastebin/4jtKGI2w/ | 17:37 |
| *** enriquetaso has joined #openstack-manila | 17:44 | |
| lseki | 14:33:04 <vkmc> lseki, or maybe you can set a default value to the extra param... and for previous versions you do nothing | 17:44 |
| lseki | hmm so I could show the share_network_subnet param as optional (actually it is, the default subnet will be used if not specified) | 17:44 |
| *** s0ru has quit IRC | 17:45 | |
| vkmc | lseki, I see | 17:45 |
| vkmc | lseki, so if you indicate a new version, the implementation to be used will be the one that matches the decorator | 17:46 |
| vkmc | lseki, and in that redefinition you just add the new param with a default value | 17:47 |
| *** senrique_ has joined #openstack-manila | 17:47 | |
| vkmc | that is, at least, what I would do | 17:47 |
| lseki | vkmc I'll try this way, thanks! | 17:47 |
| *** enriquetaso has quit IRC | 17:49 | |
| *** senrique_ has quit IRC | 17:59 | |
| *** tosky has quit IRC | 18:01 | |
| *** eharney has quit IRC | 18:32 | |
| *** eharney has joined #openstack-manila | 18:36 | |
| vkmc | lseki++ | 18:53 |
| *** s0ru has joined #openstack-manila | 19:12 | |
| *** senrique_ has joined #openstack-manila | 19:17 | |
| *** senrique_ has quit IRC | 20:03 | |
| *** eharney has quit IRC | 20:03 | |
| *** tosky has joined #openstack-manila | 20:17 | |
| *** e0ne has joined #openstack-manila | 20:40 | |
| *** s0ru has quit IRC | 20:53 | |
| *** s0ru has joined #openstack-manila | 21:07 | |
| *** senrique_ has joined #openstack-manila | 21:18 | |
| *** tosky has quit IRC | 22:07 | |
| *** senrique_ has quit IRC | 22:10 | |
| *** patrickeast_ has joined #openstack-manila | 22:29 | |
| *** s0ru has quit IRC | 22:30 | |
| *** patrickeast has quit IRC | 22:37 | |
| *** patrickeast_ is now known as patrickeast | 22:37 | |
| *** e0ne_ has joined #openstack-manila | 22:45 | |
| *** e0ne has quit IRC | 22:46 | |
| *** e0ne has joined #openstack-manila | 22:47 | |
| *** e0ne_ has quit IRC | 22:50 | |
| *** e0ne has quit IRC | 22:52 | |
| *** whoami-rajat has quit IRC | 22:55 | |
| *** ianychoi has quit IRC | 23:12 | |
| *** trident has quit IRC | 23:54 | |
| *** trident has joined #openstack-manila | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!