| *** mmethot_ has quit IRC | 00:40 | |
| *** mmethot has joined #openstack-manila | 00:40 | |
| *** mmethot has quit IRC | 00:45 | |
| *** mmethot has joined #openstack-manila | 00:45 | |
| *** mmethot has quit IRC | 00:46 | |
| *** mmethot has joined #openstack-manila | 00:47 | |
| *** mmethot has quit IRC | 00:55 | |
| *** mmethot_ has joined #openstack-manila | 00:55 | |
| *** lseki has quit IRC | 01:14 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/manila master: [train][goal] Define new manila-tempest-minimal-lvm-ipv6-only job https://review.opendev.org/682716 | 01:44 |
|---|---|---|
| openstackgerrit | Merged openstack/manila master: Fix _list_view function for count https://review.opendev.org/673913 | 02:24 |
| *** tinwood has quit IRC | 02:50 | |
| *** tinwood has joined #openstack-manila | 02:52 | |
| *** _mmethot_ has joined #openstack-manila | 04:41 | |
| *** mmethot_ has quit IRC | 04:41 | |
| *** dviroel has quit IRC | 04:52 | |
| *** pcaruana has joined #openstack-manila | 05:28 | |
| *** pcaruana has quit IRC | 05:53 | |
| *** kopecmartin|off is now known as kopecmartin | 06:36 | |
| *** trident has quit IRC | 06:49 | |
| *** trident has joined #openstack-manila | 07:01 | |
| *** trident has quit IRC | 07:07 | |
| *** trident has joined #openstack-manila | 07:17 | |
| *** tosky has joined #openstack-manila | 07:18 | |
| *** e0ne has joined #openstack-manila | 07:46 | |
| *** e0ne has quit IRC | 07:59 | |
| *** e0ne has joined #openstack-manila | 08:24 | |
| *** e0ne has quit IRC | 08:42 | |
| *** pcaruana has joined #openstack-manila | 09:12 | |
| openstackgerrit | haixin proposed openstack/manila-ui master: Add update share-type name description or public access https://review.opendev.org/683336 | 09:30 |
| *** e0ne has joined #openstack-manila | 09:54 | |
| *** e0ne has quit IRC | 10:02 | |
| *** pcaruana has quit IRC | 10:56 | |
| *** e0ne has joined #openstack-manila | 11:03 | |
| *** e0ne has quit IRC | 11:24 | |
| *** pcaruana has joined #openstack-manila | 11:29 | |
| *** carloss has joined #openstack-manila | 11:30 | |
| *** pcaruana has quit IRC | 11:42 | |
| *** pcaruana has joined #openstack-manila | 11:42 | |
| *** dviroel has joined #openstack-manila | 12:11 | |
| *** eharney has joined #openstack-manila | 12:56 | |
| openstackgerrit | Merged openstack/manila master: [train][goal] Define new manila-tempest-minimal-lvm-ipv6-only job https://review.opendev.org/682716 | 13:21 |
| *** sfernand has joined #openstack-manila | 13:56 | |
| *** lseki has joined #openstack-manila | 14:01 | |
| *** openstackgerrit has quit IRC | 14:06 | |
| *** _mmethot_ has quit IRC | 15:04 | |
| *** _mmethot_ has joined #openstack-manila | 15:05 | |
| *** jmlowe has joined #openstack-manila | 15:08 | |
| *** trident has quit IRC | 15:14 | |
| *** trident has joined #openstack-manila | 15:24 | |
| *** trident has quit IRC | 15:29 | |
| *** kopecmartin is now known as kopecmartin|off | 15:35 | |
| *** trident has joined #openstack-manila | 15:40 | |
| *** baojg has joined #openstack-manila | 15:42 | |
| *** pcaruana has quit IRC | 16:19 | |
| *** openstackgerrit has joined #openstack-manila | 16:33 | |
| openstackgerrit | Douglas Viroel proposed openstack/manila-tempest-plugin master: Adds new functional tests for share-network-subnets https://review.opendev.org/676475 | 16:33 |
| gouthamr | dviroel: ping re: https://review.opendev.org/#/c/676475/14/manila_tempest_tests/tests/api/test_share_network_subnets.py@217 | 17:16 |
| dviroel | gouthamr: hi | 17:17 |
| gouthamr | dviroel: hey! so, i meant to say this: if a share is created without specifying an AZ, the scheduler will find the best one for it - when it does, the share must be created on the corresponding AZ's subnet if one exists, and not default | 17:17 |
| gouthamr | dviroel: it's possible the scheduler picks an AZ not exclusively served by any particular subnet - then ofcourse this check won't matter, if there's no subnet for that AZ, default will be picked - that's intended behavior | 17:18 |
| dviroel | gouthamr: ok, so we agree with the current behavior. | 17:20 |
| gouthamr | dviroel: i don't see that specific assert though? | 17:20 |
| dviroel | gouthamr: let me find | 17:20 |
| gouthamr | dviroel: https://review.opendev.org/#/c/676475/15/manila_tempest_tests/tests/api/test_share_network_subnets.py@238 always yields "a" subnet | 17:21 |
| *** e0ne has joined #openstack-manila | 17:22 | |
| gouthamr | dviroel: and that isn't enough - i want the test to fail if: the scheduler's chosen an AZ the share network has a subnet dedicated for, but the share is on the default subnet | 17:22 |
| dviroel | gouthamr: you don't think that the assert in line 238 is enough to test these two positive scenarios? | 17:29 |
| dviroel | gouthamr: for sure there are more negative scenarios that we can add | 17:30 |
| gouthamr | hmmm | 17:33 |
| gouthamr | my bad | 17:33 |
| gouthamr | that should work dviroel | 17:33 |
| dviroel | =) | 17:33 |
| dviroel | that == expected_subnet_id assert? | 17:35 |
| dviroel | Oh, +1 =) | 17:36 |
| dviroel | gouthamr: did you expect more negative tests? | 17:36 |
| gouthamr | dviroel: nope, thanks for adding the ones i asked for; i think we have pretty good coverage | 17:37 |
| dviroel | \o/ | 17:38 |
| dviroel | gouthamr: thanks | 17:38 |
| * gouthamr is not vponomaryov, but usually channels him during tempest code reviews and tortures dviroel | 17:38 | |
| gouthamr | dviroel: do you run these tests with the dummy driver? or the netapp backend? | 17:39 |
| gouthamr | dviroel: if you run that particular test we're talking about, you should see the behavior i pointed out in the server-side review; i was consistently seeing it - although i didn't dig in to find the place we could fix it - that said you/carloss weren't seeing that issue | 17:41 |
| dviroel | gouthamr: I was using the dummy driver today. We can wait for NetApp CI to vote on this one before moving forward | 17:42 |
| gouthamr | dviroel: the expected "behavior" being: "if a share is created without specifying an AZ, the scheduler will find the best one for it - when it does, the share must be created on the corresponding AZ's subnet if one exists, and not default" | 17:42 |
| gouthamr | dviroel: yes | 17:43 |
| dviroel | gouthamr: agree | 17:43 |
| dviroel | gouthamr: about that behavior that you pointed out, I'll try to reproduce it once again, and ask you questions if I cannot reproduce it. | 17:45 |
| dviroel | gouthamr: don't want to see this as a bug in the future =) | 17:46 |
| *** tosky_ has joined #openstack-manila | 17:48 | |
| * dviroel still don't know who is vponomaryov | 17:49 | |
| * carloss never saw him in a meeting or a channel but is used to see his username in a lot of comments in the code xD | 17:50 | |
| *** tosky is now known as Guest87259 | 17:51 | |
| *** tosky_ is now known as tosky | 17:51 | |
| *** Guest87259 has quit IRC | 17:52 | |
| gouthamr | we don't say his real name around here | 17:52 |
| gouthamr | dviroel: we should expect that test you added to fail every now and then - we have all these DHSS=True CIs that don't use a pre-created share network - one of them should catch it, if the behavior exists | 17:54 |
| *** eharney has quit IRC | 18:05 | |
| *** e0ne has quit IRC | 18:34 | |
| *** e0ne has joined #openstack-manila | 18:36 | |
| *** e0ne has quit IRC | 18:36 | |
| *** e0ne has joined #openstack-manila | 18:37 | |
| *** e0ne has quit IRC | 18:41 | |
| *** eharney has joined #openstack-manila | 18:52 | |
| *** _mmethot_ has quit IRC | 21:05 | |
| *** mmethot_ has joined #openstack-manila | 21:05 | |
| dviroel | gouthamr: we don't have two pools configure for manila-cDOT-manila-tempest-plugin-ss job. So those 2 tests that we were talking about were skipped. We can test this on the DNM job that triggers the replication-ss job. | 21:31 |
| *** eharney has quit IRC | 21:39 | |
| dviroel | or the Dummy driver change | 21:44 |
| *** carloss has quit IRC | 22:21 | |
| *** sfernand has quit IRC | 23:25 | |
| *** tosky has quit IRC | 23:28 | |
| * dviroel enjoys watch NetApp CI running subnet tests | 23:44 | |
| dviroel | \o/ Success | 23:50 |
| gouthamr | yeah the dummy driver should catch that | 23:54 |
| gouthamr | i'll merge this and lets watch this through the next week | 23:54 |
| dviroel | gouthamr: http://13.56.159.105/logs/76/677576/1/upstream-check/manila-cDOT-replication-ss/cdfaf84/console.html.gz#_2019-09-20_23_35_46_103884 | 23:56 |
| dviroel | The replication-ss job executed those new tests | 23:56 |
| gouthamr | nice, thanks dviroel | 23:56 |
| dviroel | ty gouthamr | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!