| *** dviroel has joined #openstack-manila | 00:59 | |
| *** zhubx has quit IRC | 03:51 | |
| *** zhubx has joined #openstack-manila | 03:51 | |
| *** dviroel has quit IRC | 04:36 | |
| *** zhubx has quit IRC | 05:48 | |
| *** boxiang has joined #openstack-manila | 05:48 | |
| *** lpetrut has joined #openstack-manila | 06:33 | |
| *** lpetrut has quit IRC | 06:34 | |
| *** lpetrut has joined #openstack-manila | 06:35 | |
| *** trident has quit IRC | 07:37 | |
| *** trident has joined #openstack-manila | 07:48 | |
| *** tosky has joined #openstack-manila | 07:52 | |
| *** tosky has quit IRC | 08:32 | |
| *** tosky has joined #openstack-manila | 08:37 | |
| *** irclogbot_3 has quit IRC | 09:39 | |
| *** irclogbot_3 has joined #openstack-manila | 09:40 | |
| *** tosky has quit IRC | 09:41 | |
| *** tosky has joined #openstack-manila | 09:42 | |
| *** tosky_ has joined #openstack-manila | 09:52 | |
| *** tosky has quit IRC | 09:54 | |
| *** tosky has joined #openstack-manila | 09:58 | |
| *** tosky_ has quit IRC | 10:01 | |
| *** tosky_ has joined #openstack-manila | 10:05 | |
| *** tosky has quit IRC | 10:08 | |
| *** tosky has joined #openstack-manila | 10:14 | |
| *** tosky_ has quit IRC | 10:17 | |
| *** tosky_ has joined #openstack-manila | 10:21 | |
| *** tosky has quit IRC | 10:24 | |
| *** tosky has joined #openstack-manila | 10:34 | |
| *** tosky_ has quit IRC | 10:36 | |
| *** tosky_ has joined #openstack-manila | 10:43 | |
| *** tosky has quit IRC | 10:45 | |
| *** tosky_ has quit IRC | 10:46 | |
| *** tosky has joined #openstack-manila | 10:46 | |
| *** tosky has quit IRC | 11:01 | |
| *** tosky has joined #openstack-manila | 11:01 | |
| *** tosky_ has joined #openstack-manila | 11:05 | |
| *** tosky has quit IRC | 11:06 | |
| *** tosky_ has quit IRC | 11:09 | |
| *** tosky has joined #openstack-manila | 11:09 | |
| *** tosky has quit IRC | 11:17 | |
| *** tosky has joined #openstack-manila | 11:23 | |
| *** tosky_ has joined #openstack-manila | 11:47 | |
| *** tosky has quit IRC | 11:49 | |
| *** tosky has joined #openstack-manila | 11:50 | |
| *** tosky_ has quit IRC | 11:53 | |
| *** dviroel has joined #openstack-manila | 11:58 | |
| *** boxiang has quit IRC | 12:08 | |
| *** boxiang has joined #openstack-manila | 12:09 | |
| *** openstackgerrit has quit IRC | 12:41 | |
| *** eharney has quit IRC | 13:04 | |
| *** eharney has joined #openstack-manila | 13:12 | |
| *** eharney has quit IRC | 14:23 | |
| *** tosky_ has joined #openstack-manila | 15:00 | |
| *** tosky has quit IRC | 15:00 | |
| *** tosky_ is now known as tosky | 15:01 | |
| *** eharney has joined #openstack-manila | 15:05 | |
| *** eharney has quit IRC | 15:17 | |
| *** pcaruana has joined #openstack-manila | 15:28 | |
| *** eharney has joined #openstack-manila | 15:30 | |
| *** tosky has quit IRC | 15:31 | |
| *** tosky has joined #openstack-manila | 15:32 | |
| *** maaritamm has joined #openstack-manila | 15:46 | |
| vkmc | maaritamm, o/ | 15:55 |
|---|---|---|
| maaritamm | vkmc, o/ | 15:55 |
| vkmc | answering your questions | 15:57 |
| vkmc | for the api bumping work we need to do in the ui | 15:57 |
| vkmc | 1. yes, we need to do it one by one | 15:57 |
| vkmc | smaller patches are better | 15:57 |
| vkmc | 2. the next version would be 2.33 | 16:01 |
| vkmc | https://github.com/openstack/manila-ui/blob/master/manila_ui/api/manila.py#L35 | 16:01 |
| maaritamm | yes, I followed the bug description, so the change in 2.33 is Added created_at and updated_at in access_list API. | 16:06 |
| vkmc | great | 16:07 |
| vkmc | so we need to check that api call | 16:07 |
| vkmc | let me see, it description should be here https://docs.openstack.org/api-ref/shared-file-system/ | 16:07 |
| vkmc | this is the api-ref | 16:07 |
| *** lpetrut has quit IRC | 16:10 | |
| maaritamm | yes, that’s where I got stuck. Didn’t find it /wasn’t sure which one is it | 16:10 |
| vkmc | so... a little trick | 16:12 |
| vkmc | it's not clear to me where the changes were introduced by that description | 16:12 |
| vkmc | so, what we can do is do a git blame | 16:12 |
| vkmc | that way we know who did that and when | 16:12 |
| vkmc | https://github.com/openstack/manila/blame/master/manila/api/openstack/api_version_request.py | 16:13 |
| vkmc | (check that out) | 16:13 |
| vkmc | and then we click on the commit message so we see all the changes introduced as part of that patch set | 16:13 |
| vkmc | so... in this case https://github.com/openstack/manila/commit/5a8c3c11b9285c2822475502bb42c26582131442 | 16:13 |
| vkmc | let's inspect that change | 16:13 |
| vkmc | can you see all the files that were changed in order to add this extra params to access lists? | 16:15 |
| vkmc | the basic difference between two versions is that the response now contains these two params | 16:16 |
| vkmc | let's see how this impact the ui | 16:16 |
| vkmc | seems it's encapsulated https://github.com/openstack/manila-ui/blob/master/manila_ui/api/manila.py#L126-L127 | 16:23 |
| vkmc | so not really much to do there, at least that I can tell now | 16:23 |
| vkmc | maybe... /me check timezones | 16:23 |
| vkmc | gouthamr, you around? :D | 16:24 |
| vkmc | or tbarron | 16:24 |
| gouthamr | i am | 16:24 |
| vkmc | yaay | 16:24 |
| vkmc | gouthamr, <3 | 16:24 |
| gouthamr | o/ maaritamm vkmc | 16:24 |
| vkmc | we are checking with maaritamm what we need to update in order to bump to v2.33 in the manila_ui | 16:25 |
| vkmc | there are no added parameters for req, just resp | 16:25 |
| maaritamm | gouthamr o/ | 16:25 |
| vkmc | bumping the version and addding a reno would be enough? | 16:25 |
| vkmc | or am I missing something? | 16:25 |
| gouthamr | vkmc: yes, that's correct.. we'll already getting that data if we use 2.33 as the microversion, i am unsure if we're actively preventing it from displaying on the UI | 16:26 |
| vkmc | gouthamr, cool, so we need to check that maybe... dunno remember exactly how much information on acls we display | 16:27 |
| vkmc | and then propose patch | 16:28 |
| vkmc | maaritamm, up for the challenge? | 16:28 |
| gouthamr | vkmc: yep - otherwise, just move it to two microversions at once instead of one :) | 16:28 |
| maaritamm | vkmc, of course :) | 16:28 |
| vkmc | gouthamr, yeah, we can do that... 2.34 requires a newer client version so that sounds more work | 16:28 |
| vkmc | maaritamm, \o/ | 16:28 |
| vkmc | gouthamr, according to a comment we have inline there, from Valeriy | 16:28 |
| vkmc | maaritamm, ok, we need to check the ui and see how we display that information... and test maybe with the updated microversion to see if there is some breakage in the ui | 16:32 |
| vkmc | submitting the version change and a release note for that case would be enough | 16:32 |
| vkmc | if it's too small for a change, we can bump up to 3.34 instead of 3.33 (two microversions) | 16:32 |
| vkmc | but we need to do the same inspection work we just did: git blame to see what changes were introduced in 3.34, see if those changes affect req or resp params, test the update and see if the ui breaks | 16:33 |
| vkmc | we also need to take into account a comment that was left by a contributor | 16:33 |
| vkmc | https://github.com/openstack/manila-ui/blob/master/manila_ui/api/manila.py#L33-L34 | 16:33 |
| vkmc | this one | 16:33 |
| vkmc | we need to check if the current client supports availability zones | 16:34 |
| vkmc | maaritamm, any question or comment? | 16:35 |
| vkmc | gouthamr++ thanks for your input | 16:36 |
| tbarron | in a meeting will read backlog in a bit ... | 16:41 |
| maaritamm | vkmc, not yet, I’ll get started now | 16:41 |
| vkmc | tbarron, no rush | 16:41 |
| vkmc | maaritamm, cool, let me know if you hit any blocker | 16:42 |
| maaritamm | vkmc, will do, thanks! | 16:42 |
| *** boxiang has quit IRC | 16:48 | |
| *** zhubx has joined #openstack-manila | 16:48 | |
| gouthamr | vkmc maaritamm: just checked the dashboard for a share's access rules ("share rules"): https://github.com/openstack/manila-ui/blob/0dcd47ec535ff9022af8fe23e2a74b04a044c85e/manila_ui/dashboards/project/shares/views.py#L266 | 16:53 |
| gouthamr | we're getting the share rules and limiting the display: https://github.com/openstack/manila-ui/blob/83a0e432fe475a263c2f5e5337511db96263c3b8/manila_ui/dashboards/project/shares/tables.py#L355-L361 | 16:55 |
| gouthamr | vkmc maaritamm: a suggestion would be to display "updated_at" if available - and perhaps use that key to sort the list of rules | 16:56 |
| *** sfernand has joined #openstack-manila | 17:00 | |
| *** pcaruana has quit IRC | 17:03 | |
| *** maaritamm has quit IRC | 18:01 | |
| dviroel | guys, any news regarding ptg photos? | 18:29 |
| tbarron | dviroel: not yet | 19:31 |
| *** maaritamm has joined #openstack-manila | 19:39 | |
| *** maaritamm has quit IRC | 20:15 | |
| *** maaritamm has joined #openstack-manila | 20:26 | |
| *** eharney has quit IRC | 20:57 | |
| *** ganso has quit IRC | 21:07 | |
| *** ganso has joined #openstack-manila | 21:10 | |
| *** eharney has joined #openstack-manila | 21:58 | |
| *** dviroel has quit IRC | 22:15 | |
| *** eharney has quit IRC | 22:31 | |
| *** maaritamm has quit IRC | 22:36 | |
| *** mmethot has quit IRC | 23:21 | |
| *** mmethot has joined #openstack-manila | 23:22 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!