| *** senrique__ has joined #openstack-manila | 00:09 | |
| *** senrique_ has quit IRC | 00:12 | |
| *** senrique__ has quit IRC | 00:23 | |
| *** enriquetaso has joined #openstack-manila | 00:54 | |
| *** enriquetaso has quit IRC | 01:10 | |
| *** sam_wan has quit IRC | 02:14 | |
| *** jcollin has joined #openstack-manila | 05:27 | |
| *** pcaruana has joined #openstack-manila | 06:18 | |
| *** lpetrut has joined #openstack-manila | 07:21 | |
| *** tosky has joined #openstack-manila | 08:27 | |
| *** mmethot has quit IRC | 10:03 | |
| *** mmethot has joined #openstack-manila | 10:04 | |
| *** mmethot has quit IRC | 10:34 | |
| *** mmethot has joined #openstack-manila | 10:42 | |
| *** pcaruana has quit IRC | 11:03 | |
| *** pcaruana has joined #openstack-manila | 11:06 | |
| *** enriquetaso has joined #openstack-manila | 11:41 | |
| *** dviroel has joined #openstack-manila | 11:47 | |
| *** mmethot has quit IRC | 11:52 | |
| *** mmethot has joined #openstack-manila | 11:52 | |
| *** mmethot has quit IRC | 11:58 | |
| *** mmethot has joined #openstack-manila | 12:09 | |
| *** jcollin has quit IRC | 12:25 | |
| *** enriquetaso has quit IRC | 13:01 | |
| *** enriquetaso has joined #openstack-manila | 13:01 | |
| *** enriquetaso has quit IRC | 13:07 | |
| *** FlorianFa has joined #openstack-manila | 13:22 | |
| *** mmethot has quit IRC | 13:24 | |
| *** mmethot has joined #openstack-manila | 13:30 | |
| *** enriquetaso has joined #openstack-manila | 13:51 | |
| *** senrique_ has joined #openstack-manila | 13:54 | |
| *** enriquetaso has quit IRC | 13:56 | |
| *** pcaruana has quit IRC | 13:57 | |
| *** pcaruana has joined #openstack-manila | 14:36 | |
| *** vhari has joined #openstack-manila | 14:42 | |
| vkmc | maaritamm, o/ | 15:08 |
|---|---|---|
| vkmc | getting back to you... little by little | 15:08 |
| vkmc | so, documentation for cliff https://docs.openstack.org/cliff/latest/ | 15:08 |
| vkmc | there we can see what the heck command.Command and command.ShowOne, etc are | 15:08 |
| vkmc | cliff, as mentioned, is a framework for building command line programs | 15:08 |
| vkmc | on top of cliff, we have osclib (what we are using) | 15:09 |
| vkmc | we use cliff through the osclib | 15:09 |
| maaritamm | vkmc, o/ | 15:09 |
| vkmc | we add fancy stuff on top of cliff for our work | 15:09 |
| vkmc | so you can read in that doc I shared more about the rational of some of the abstractions we have :) | 15:09 |
| vkmc | that's the human friendly documentation I was thinking about | 15:10 |
| maaritamm | yes, that one is way more readable :) thanks! | 15:10 |
| vkmc | cool | 15:10 |
| vkmc | and now I'm looking for the self.app.(...) origin | 15:11 |
| openstackgerrit | Merged openstack/manila master: [ussuri][goal] Drop python2.7 support https://review.opendev.org/691134 | 15:17 |
| gouthamr | ^^ end of an era ^^ | 15:17 |
| vkmc | w00t | 15:18 |
| vkmc | finally | 15:18 |
| vkmc | gouthamr, do you happen to know who and why decided to drop "update" for "set"/"unset" on the client? | 15:19 |
| vkmc | I already explained the logic to maaritamm, but I'm trying to find out is there us some historic discussion on that design decision that make things more clear | 15:19 |
| gouthamr | vkmc: yes, just following OSC patterns - dunno if they've documented this - lemme look | 15:20 |
| vkmc | yep, who defined the pattern? | 15:20 |
| * vkmc git blames all the things | 15:20 | |
| gouthamr | vkmc: one reason is that you'll need a way to "unset" stuff, and update may be confusing when you really want to delete, for example a property/metadatum on a share | 15:20 |
| gouthamr | vkmc: set is analogous to update - unset is special, and not everything that you can set can be unset - ex: name of a share type | 15:21 |
| vkmc | right now the only thing we can update is the visibility | 15:22 |
| vkmc | with the current client implementation | 15:22 |
| gouthamr | vkmc: https://docs.openstack.org/python-openstackclient/latest/contributor/specs/commands.html | 15:22 |
| gouthamr | vkmc: for a share type? | 15:23 |
| vkmc | gouthamr, for shares | 15:23 |
| gouthamr | vkmc: hmmm... we should build it such that we must be able to set share metadata (called 'properties' in OSC terminology), name, description and visibility | 15:25 |
| vkmc | gouthamr, but capabilities... such as create_from_snapshot | 15:26 |
| vkmc | == true | 15:26 |
| gouthamr | vkmc: yep, only a finite set of things can be set, we'd have to add that list as options | 15:27 |
| gouthamr | "--property" would be a repeatable option that takes key=value pairs | 15:27 |
| vkmc | maaritamm, ^ | 15:28 |
| vkmc | k, we can work on that list once we start with code | 15:28 |
| gouthamr | ++ | 15:29 |
| vkmc | thanks | 15:29 |
| maaritamm | great comments, thanks, gives me a better idea about it for sure | 15:30 |
| maaritamm | vkmc, so to get coding, what about the naming of branches and how to make the dependency from current correctly? | 15:46 |
| maaritamm | I am on review/goutham_pacha_ravi/bp/openstack-client-support | 15:47 |
| openstackgerrit | Merged openstack/manila master: Make extra_specs value as case-insensitive https://review.opendev.org/688053 | 16:07 |
| *** irclogbot_3 has quit IRC | 16:14 | |
| *** irclogbot_1 has joined #openstack-manila | 16:15 | |
| vkmc | maaritamm, got distracted with some other stuff, sorry | 16:47 |
| vkmc | maaritamm, this is the origin of the self.app.(...) call https://github.com/openstack/cliff/blob/master/cliff/command.py#L84 | 16:48 |
| vkmc | we define an application namespace there | 16:48 |
| vkmc | maaritamm, wrt dependencies, from the current branch you are working on (that review/.../...) | 16:49 |
| vkmc | git checkout -b bp/openstack-client-support | 16:49 |
| vkmc | that will create a new branch depending on the change you need with the name "bp/openstack-client-support" | 16:50 |
| vkmc | add all the code you need | 16:50 |
| vkmc | git commit -a | 16:50 |
| vkmc | git review | 16:50 |
| vkmc | done :) | 16:50 |
| vkmc | maaritamm, about examples, as mentioned, looking on how other projects did stuff is very helpful, e.g. https://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v2/volume.py#L485 | 16:51 |
| vkmc | that's the set volume implementation | 16:51 |
| vkmc | that's cinder, the block storage service for openstack | 16:52 |
| vkmc | (if you notice, the code for cinder in openstack client lives in the python-openstackclient repo instead of in their client repo, they are not a plugin like us) | 16:52 |
| vkmc | (they wanted to change that some time ago... so don't speak too loud about this one or they will try to drag you to their project to do so) | 16:53 |
| vkmc | maaritamm, let me know if there is anything else | 16:53 |
| maaritamm | vkmc, awesome, thanks! | 16:53 |
| maaritamm | lots of good info :) | 16:54 |
| *** lpetrut has quit IRC | 17:07 | |
| *** lpetrut has joined #openstack-manila | 17:08 | |
| *** lpetrut has quit IRC | 17:20 | |
| *** ganso has quit IRC | 19:19 | |
| *** tosky has quit IRC | 19:21 | |
| *** mmethot has quit IRC | 19:40 | |
| *** vhari has quit IRC | 20:08 | |
| *** ganso has joined #openstack-manila | 20:08 | |
| *** pcaruana has quit IRC | 20:19 | |
| openstackgerrit | Merged openstack/manila master: PowerMax and VNX Manila - Read only policy is not working correctly https://review.opendev.org/691878 | 20:57 |
| *** deshipu has left #openstack-manila | 20:58 | |
| *** ganso has quit IRC | 21:09 | |
| *** eharney has quit IRC | 21:43 | |
| *** dviroel has quit IRC | 21:58 | |
| *** Reepicheep has quit IRC | 23:10 | |
| *** Reepicheep has joined #openstack-manila | 23:10 | |
| *** irclogbot_1 has quit IRC | 23:11 | |
| *** irclogbot_2 has joined #openstack-manila | 23:12 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!