| openstackgerrit | Vishal Manchanda proposed openstack/manila-ui master: Remove six usage https://review.opendev.org/702334 | 00:29 |
|---|---|---|
| openstackgerrit | haixin proposed openstack/manila master: Don't send heartbeats if driver not initializing correctly https://review.opendev.org/697957 | 03:34 |
| *** tosky has joined #openstack-manila | 08:19 | |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Fix condition skip for "test_migration_files" https://review.opendev.org/702601 | 09:20 |
| *** pcaruana has joined #openstack-manila | 09:42 | |
| openstackgerrit | Maurice Escher proposed openstack/manila master: Fix over-quota exception of snapshot creation https://review.opendev.org/702618 | 09:54 |
| openstackgerrit | Tom Barron proposed openstack/manila master: DNM - baseline run on master https://review.opendev.org/687833 | 10:21 |
| openstackgerrit | Maurice Escher proposed openstack/manila master: Improve share list speed using lazy='subquery' https://review.opendev.org/702639 | 10:31 |
| openstackgerrit | Merged openstack/manila-ui master: Remove six usage https://review.opendev.org/702334 | 10:51 |
| openstackgerrit | Maari Tamm proposed openstack/python-manilaclient master: Implement OSC share type commands https://review.opendev.org/701229 | 10:55 |
| *** pcaruana has quit IRC | 11:12 | |
| *** dviroel has joined #openstack-manila | 11:58 | |
| openstackgerrit | Maurice Escher proposed openstack/manila master: Fix over-quota exception of snapshot creation https://review.opendev.org/702618 | 12:34 |
| openstackgerrit | Maurice Escher proposed openstack/manila master: Fix over-quota exception of snapshot creation https://review.opendev.org/702618 | 12:35 |
| maaritamm | Hi everyone, I have a question about this batch https://review.opendev.org/702334 | 12:46 |
| maaritamm | I added two questions (as TODO’s) in here https://review.opendev.org/#/c/701229/5/manilaclient/osc/v2/share_types.py | 12:46 |
| maaritamm | basically I am wondering if I should validate/check API versions? | 12:47 |
| *** pcaruana has joined #openstack-manila | 12:49 | |
| vkmc | tbarron, gouthamr ^ | 12:49 |
| vkmc | maybe you can help us with this | 12:49 |
| vkmc | arne_wiebalck, if you are around as well :) | 12:51 |
| maaritamm | vkmc, thanks! I was about to start tagging :) | 12:52 |
| vkmc | maaritamm, team works! | 12:52 |
| arne_wiebalck | vkmc: I can ping Jose, he has apparently already looked into this :) | 12:55 |
| vkmc | arne_wiebalck, that would help | 12:55 |
| vkmc | arne_wiebalck, or Spyros if he is around | 12:55 |
| *** enriquetaso has joined #openstack-manila | 12:55 | |
| arne_wiebalck | vkmc: ping sent :) | 12:57 |
| vkmc | yay, thanks arne_wiebalck! | 12:57 |
| *** josecastroleon has joined #openstack-manila | 12:58 | |
| vkmc | hey josecastroleon o/ | 13:02 |
| josecastroleon | hi | 13:02 |
| vkmc | continuing the work on the osc support, we were wondering about validation for api versions | 13:03 |
| vkmc | maaritamm submitted a new patch set with some questions inline https://review.opendev.org/#/c/701229/5/manilaclient/osc/v2/share_types.py | 13:03 |
| vkmc | we are trying to get some feedback on those | 13:03 |
| vkmc | if you have a moment later, that will be much appreciated :) | 13:04 |
| josecastroleon | did I mentioned that i "like" microversions? | 13:12 |
| josecastroleon | AFAIK osc does not handle microversions (please correct me if wrong) | 13:17 |
| josecastroleon | , I think we should add in the description of the command that this is only supported in version X | 13:18 |
| josecastroleon | like https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server_event.py#L30-L33 | 13:18 |
| *** eharney has quit IRC | 13:20 | |
| tbarron | josecastroleon: vkmc: maaritamm: yeah (say it's only supported in mv >= x) but also make sure that the failure if the server version is lower doesn't *do* anything to manila | 13:26 |
| tbarron | do no harm even when it doesn't work and make the failure message clear | 13:27 |
| josecastroleon | i got your point, but the negotiation about microversions on the client is done at the very begining. | 13:29 |
| josecastroleon | I am not sure if you can access the client object and fetch the microversion from there. | 13:29 |
| josecastroleon | manila will just reply not supported, right? | 13:30 |
| vkmc | I see that we are using flags in other services, as josecastroleon pointed out https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L426 | 13:37 |
| josecastroleon | and raise a commanderror | 13:37 |
| josecastroleon | nice | 13:37 |
| josecastroleon | https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L479-L492 | 13:37 |
| tbarron | josecastroleon: yeah we can't negotiaate the microversions with OSC but I'm just saying that if we add a knob that requires a min microversion then | 13:37 |
| tbarron | we need to think about the case where the server is running lower and make sure we actually get and return an error without somehow doing the wrong thing | 13:38 |
| josecastroleon | yes | 13:38 |
| *** jmlowe has joined #openstack-manila | 13:38 | |
| *** jmlowe has quit IRC | 13:39 | |
| josecastroleon | vkmc pointed to the right command look at https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L479-L492 | 13:39 |
| josecastroleon | it raises a command error if the mv is not correct | 13:39 |
| tbarron | cool | 13:40 |
| josecastroleon | if the parameter has something and the mv is not correct, we can raise the error | 13:40 |
| tbarron | yup, nice, thx vkmc and josecastroleon | 13:40 |
| vkmc | maaritamm, we can follow nova's example here https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L479-L492 | 13:41 |
| maaritamm | cool! thanks everyone, this helps a lot :) | 13:43 |
| *** mnaser has quit IRC | 13:54 | |
| *** mnaser has joined #openstack-manila | 13:55 | |
| *** eharney has joined #openstack-manila | 14:01 | |
| *** sfernand has joined #openstack-manila | 14:02 | |
| openstackgerrit | Maari Tamm proposed openstack/python-manilaclient master: Implements osc share set/unset commands https://review.opendev.org/698848 | 14:03 |
| *** andrebeltrami has joined #openstack-manila | 14:04 | |
| *** vkmc has quit IRC | 14:09 | |
| *** vkmc has joined #openstack-manila | 14:09 | |
| *** lseki has quit IRC | 14:44 | |
| *** lseki has joined #openstack-manila | 14:44 | |
| *** eharney has quit IRC | 15:48 | |
| *** eharney has joined #openstack-manila | 15:52 | |
| *** carloss has joined #openstack-manila | 16:12 | |
| *** sfernand has quit IRC | 16:31 | |
| *** andrebeltrami has quit IRC | 16:34 | |
| *** openstackgerrit has quit IRC | 16:43 | |
| *** pcaruana has quit IRC | 16:45 | |
| *** carloss has quit IRC | 18:18 | |
| *** eharney has quit IRC | 18:26 | |
| *** _erlon_ has quit IRC | 18:30 | |
| *** walshh_ has quit IRC | 18:30 | |
| *** amito has quit IRC | 18:30 | |
| *** arne_wiebalck_ has joined #openstack-manila | 18:31 | |
| *** mnaser has quit IRC | 18:31 | |
| *** xyang has quit IRC | 18:31 | |
| *** arne_wiebalck has quit IRC | 18:31 | |
| *** arne_wiebalck_ is now known as arne_wiebalck | 18:31 | |
| *** openstackstatus has quit IRC | 18:32 | |
| *** mnaser has joined #openstack-manila | 18:33 | |
| *** tosky has quit IRC | 18:33 | |
| *** amito has joined #openstack-manila | 18:36 | |
| *** walshh_ has joined #openstack-manila | 18:36 | |
| *** eharney has joined #openstack-manila | 18:38 | |
| *** xyang has joined #openstack-manila | 18:55 | |
| *** openstackstatus has joined #openstack-manila | 19:22 | |
| *** ChanServ sets mode: +v openstackstatus | 19:22 | |
| *** _erlon_ has joined #openstack-manila | 20:11 | |
| *** enriquetaso has quit IRC | 20:13 | |
| *** enriquetaso has joined #openstack-manila | 20:13 | |
| *** eharney has quit IRC | 20:36 | |
| *** enriquetaso has quit IRC | 20:45 | |
| *** dviroel has quit IRC | 21:10 | |
| *** lseki has quit IRC | 21:14 | |
| *** tommylikehu has quit IRC | 21:42 | |
| *** eharney has joined #openstack-manila | 21:48 | |
| *** ganso has quit IRC | 22:35 | |
| *** enriquetaso has joined #openstack-manila | 22:47 | |
| *** ganso has joined #openstack-manila | 22:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!