openstackgerrit | haixin proposed openstack/manila master: WIP:Support query user message by timestamp https://review.opendev.org/706438 | 00:32 |
---|---|---|
*** openstackstatus has joined #openstack-manila | 01:16 | |
*** ChanServ sets mode: +v openstackstatus | 01:16 | |
*** brinzhang has joined #openstack-manila | 01:36 | |
*** jmlowe has joined #openstack-manila | 02:21 | |
*** jmlowe has quit IRC | 02:28 | |
*** hoonetorg has quit IRC | 02:35 | |
*** dviroel has quit IRC | 02:52 | |
*** jcollin has quit IRC | 03:36 | |
*** brinzhang has quit IRC | 04:51 | |
*** brinzhang has joined #openstack-manila | 04:52 | |
*** brinzhang_ has joined #openstack-manila | 04:53 | |
*** brinzhang__ has joined #openstack-manila | 04:56 | |
*** brinzhang has quit IRC | 04:57 | |
*** brinzhang has joined #openstack-manila | 04:58 | |
*** brinzhang has quit IRC | 04:59 | |
*** brinzhang_ has quit IRC | 04:59 | |
*** brinzhang__ has quit IRC | 05:00 | |
*** maaritamm has joined #openstack-manila | 06:53 | |
*** tosky has joined #openstack-manila | 07:35 | |
openstackgerrit | Mohammed Naser proposed openstack/manila stable/train: Use StrOpt for instance type https://review.opendev.org/706748 | 08:36 |
openstackgerrit | Mohammed Naser proposed openstack/manila stable/train: generic: Refactor network functions to l3_init https://review.opendev.org/706749 | 08:36 |
openstackgerrit | Mohammed Naser proposed openstack/manila stable/train: clear_outdated_routes: reduce neutron calls https://review.opendev.org/706750 | 08:36 |
openstackgerrit | Mohammed Naser proposed openstack/manila stable/train: Refactor route clearing to linux interface https://review.opendev.org/706751 | 08:36 |
openstackgerrit | Mohammed Naser proposed openstack/manila stable/train: Introduce noop interface driver https://review.opendev.org/706752 | 08:36 |
openstackgerrit | Mohammed Naser proposed openstack/manila stable/train: Use psycopg2-binary for test-requirements https://review.opendev.org/706753 | 08:36 |
openstackgerrit | Mohammed Naser proposed openstack/manila stable/train: Add opt doc and reno for noop interface driver https://review.opendev.org/706754 | 08:36 |
*** maaritamm has quit IRC | 09:07 | |
*** maaritamm has joined #openstack-manila | 09:18 | |
openstackgerrit | Tom Barron proposed openstack/manila master: Test fixing bug 1848278 https://review.opendev.org/704393 | 11:54 |
openstack | bug 1848278 in Manila "tempest extend/shrink tests may use wrong share export location" [Low,In progress] https://launchpad.net/bugs/1848278 - Assigned to Tom Barron (tpb) | 11:54 |
*** dviroel has joined #openstack-manila | 12:27 | |
*** brinzhang has joined #openstack-manila | 12:27 | |
openstackgerrit | Merged openstack/manila stable/train: Use StrOpt for instance type https://review.opendev.org/706748 | 13:05 |
openstackgerrit | Merged openstack/manila stable/train: generic: Refactor network functions to l3_init https://review.opendev.org/706749 | 13:12 |
*** enriquetaso has joined #openstack-manila | 13:21 | |
*** rraja has joined #openstack-manila | 13:24 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/python-manilaclient master: [DNM] Testing functional gate https://review.opendev.org/706828 | 13:43 |
mnaser | tbarron: thanks for your reviews -- mind kicking https://review.opendev.org/#/c/706750/ over so the rest of the stack can enter the gate? :) | 13:51 |
tbarron | mnaser: done | 13:53 |
mnaser | tbarron: thank you so much :) | 13:53 |
tbarron | mnaser: and thanks again for these contributions | 13:53 |
mnaser | tbarron: np! :) i'm sure a few others will show up here and there | 13:53 |
*** lpetrut has joined #openstack-manila | 13:55 | |
*** brinzhang has quit IRC | 14:06 | |
*** brinzhang has joined #openstack-manila | 14:10 | |
*** jvisser has joined #openstack-manila | 14:21 | |
*** brinzhang has quit IRC | 14:57 | |
*** brinzhang has joined #openstack-manila | 14:58 | |
*** brinzhang has quit IRC | 15:01 | |
*** brinzhang has joined #openstack-manila | 15:01 | |
*** eharney has joined #openstack-manila | 15:04 | |
*** lpetrut has quit IRC | 15:08 | |
openstackgerrit | Merged openstack/manila stable/train: clear_outdated_routes: reduce neutron calls https://review.opendev.org/706750 | 15:09 |
openstackgerrit | Merged openstack/manila stable/train: Refactor route clearing to linux interface https://review.opendev.org/706751 | 15:18 |
openstackgerrit | Merged openstack/manila stable/train: Introduce noop interface driver https://review.opendev.org/706752 | 15:18 |
openstackgerrit | Merged openstack/manila stable/train: Use psycopg2-binary for test-requirements https://review.opendev.org/706753 | 15:18 |
*** rraja has quit IRC | 15:22 | |
*** jmlowe has joined #openstack-manila | 15:33 | |
vkmc | o/ | 15:34 |
vkmc | tosky, maybe you can tell us | 15:34 |
vkmc | we are looking to add more test coverage for the osc implementation maaritamm is working on | 15:35 |
vkmc | at first sight, it makes sense to add more functional tests to the python-manilaclient component | 15:35 |
tosky | but? | 15:35 |
* tosky senses a but comint | 15:36 | |
tosky | coming* | 15:36 |
vkmc | tempest is integration testing and not sure if we can add integration tests for osc, is it? | 15:36 |
vkmc | no no, we will add the functional tests | 15:36 |
vkmc | but wondering if it makes sense to add tempest coverage | 15:36 |
tosky | what do you mean by "tempest coverage"? | 15:36 |
vkmc | like, with tempest we hit the apis directly, we don't test shell clients | 15:36 |
vkmc | is that accurate? | 15:37 |
tosky | not completely | 15:37 |
tosky | there is a class for testing CLI clients | 15:37 |
vkmc | that's what I wanted to get to :D | 15:37 |
tosky | at least python-cinderclient and sahara-tests contain tests which use it | 15:37 |
tosky | https://opendev.org/openstack/sahara-tests/src/branch/master/sahara_tempest_plugin/tests/cli/base.py | 15:39 |
tosky | https://opendev.org/openstack/python-cinderclient/src/branch/master/cinderclient/tests/functional/base.py | 15:39 |
tosky | there is some almost common code (look for _get_clients and credentials() respectively) that could be moved to tempest/lib at some point | 15:40 |
tosky | but it can be copied/adapted for a start | 15:40 |
tosky | well, they are not the same (the cinderclient version get the credentials from a separate configuration file, sahara-tests tries to be smart and gets them from tempest), but the idea is that you need some code for the credentials | 15:41 |
vkmc | cool | 15:44 |
vkmc | so we can look into those examples and see if we can add some tempest coverage as well | 15:44 |
vkmc | in manila-tempest-plugin | 15:44 |
vkmc | with tempest coverage I mean using the tempest suite to write some integration tests for the client | 15:44 |
vkmc | maaritamm, ^ | 15:45 |
vkmc | maaritamm, we can start with functional testing on the client side and then we look into tempest | 15:45 |
vkmc | so you get some experience working with them all | 15:45 |
maaritamm | ok so I start in python-manilaclient and try to follow these two examples, yes? | 15:49 |
vkmc | sounds good | 15:50 |
vkmc | :) | 15:51 |
maaritamm | https://github.com/openstack/python-manilaclient/tree/master/manilaclient/tests/functional | 15:51 |
maaritamm | the code should go there? | 15:51 |
vkmc | maaritamm, exactly... we might need to organize stuff a bit and see how we were testing the old cli client and where should we put the new cli client tests | 15:51 |
vkmc | let me check the code and I'll get back to you with some ideas | 15:52 |
vkmc | of course you can also check yourself and tell me where you think it would work better | 15:52 |
vkmc | in the meantime, start by running the functional tests that are already there | 15:52 |
maaritamm | ok, cool :) | 15:53 |
vkmc | thanks tosky :) | 15:57 |
*** jmlowe has quit IRC | 16:39 | |
*** tosky has quit IRC | 16:48 | |
*** openstackstatus has quit IRC | 17:57 | |
*** openstack has joined #openstack-manila | 18:00 | |
*** ChanServ sets mode: +o openstack | 18:00 | |
*** jmlowe has joined #openstack-manila | 18:12 | |
*** jmlowe has quit IRC | 19:00 | |
*** jmlowe has joined #openstack-manila | 19:03 | |
*** eharney has quit IRC | 19:07 | |
*** eharney has joined #openstack-manila | 19:09 | |
*** jmlowe has quit IRC | 19:11 | |
openstackgerrit | Carlos Eduardo proposed openstack/manila master: [WIP] Remove experimental flag from share groups feature https://review.opendev.org/706959 | 19:14 |
*** jmlowe has joined #openstack-manila | 19:20 | |
*** jmlowe has quit IRC | 19:38 | |
*** jmlowe has joined #openstack-manila | 19:40 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila master: Create wrapper client for ceph clients https://review.opendev.org/706968 | 20:21 |
*** eharney has quit IRC | 20:22 | |
*** jmlowe has quit IRC | 20:22 | |
gouthamr | one client to rule them all | 20:23 |
*** jmlowe has joined #openstack-manila | 20:36 | |
*** jmlowe has quit IRC | 20:54 | |
*** enriquetaso has quit IRC | 21:06 | |
vkmc | :D | 21:11 |
openstackgerrit | Merged openstack/manila stable/train: Add opt doc and reno for noop interface driver https://review.opendev.org/706754 | 21:17 |
gouthamr | maaritamm: there are some comments you've left in https://review.opendev.org/#/c/704157 - didn't know what they meant? | 21:31 |
gouthamr | maaritamm: my concern was about these specifically: https://review.opendev.org/#/c/704157/5/manila_ui/dashboards/project/shares/tables.py | 21:31 |
gouthamr | maaritamm/vkmc: do lemme know if we need to hold that patch for any reason | 21:32 |
*** maaritamm has quit IRC | 21:33 | |
*** maaritamm has joined #openstack-manila | 21:35 | |
maaritamm | hi gouthamr, I was asking about translation support there, I didn’t understand Akihiros comments at first. | 21:39 |
gouthamr | maaritamm: oh.. makes sense; you're okay separating that concern and addressing it in another change? | 21:43 |
maaritamm | yes, of course :) | 21:45 |
gouthamr | maaritamm: cool ty maaritamm | 21:45 |
maaritamm | sure np | 21:46 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-ui master: Raise python-manilaclient req to 1.29.0 https://review.opendev.org/706988 | 22:01 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-ui master: Raise python-manilaclient req to 1.29.0 https://review.opendev.org/706988 | 22:03 |
*** maaritamm has quit IRC | 22:28 | |
*** openstackgerrit has quit IRC | 22:46 | |
*** eharney has joined #openstack-manila | 23:02 | |
*** openstackgerrit has joined #openstack-manila | 23:03 | |
openstackgerrit | Carlos Eduardo proposed openstack/manila master: [WIP] Remove experimental flag from share groups feature https://review.opendev.org/706959 | 23:03 |
openstackgerrit | Merged openstack/manila-ui master: Update API version to 2.33 https://review.opendev.org/704157 | 23:16 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!