| *** baojg has joined #openstack-manila | 01:49 | |
| *** baojg has quit IRC | 02:39 | |
| *** LinPeiWen62 has quit IRC | 02:42 | |
| *** LinPeiWen has joined #openstack-manila | 02:56 | |
| *** ivan_lin has joined #openstack-manila | 02:59 | |
| *** baojg has joined #openstack-manila | 03:02 | |
| *** jv has quit IRC | 03:16 | |
| *** baojg has quit IRC | 04:18 | |
| *** vishalmanchanda has joined #openstack-manila | 04:22 | |
| *** baojg has joined #openstack-manila | 05:04 | |
| *** ivan_lin has quit IRC | 05:56 | |
| *** ivan_lin has joined #openstack-manila | 05:57 | |
| openstackgerrit | haixin proposed openstack/manila master: Extend share will go through scheduler https://review.opendev.org/c/openstack/manila/+/700393 | 06:07 |
|---|---|---|
| *** baojg has quit IRC | 06:14 | |
| *** baojg has joined #openstack-manila | 06:17 | |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Manila threading https://review.opendev.org/c/openstack/manila-tempest-plugin/+/764286 | 08:06 |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Update share access to "ro" during writing operation https://review.opendev.org/c/openstack/manila-tempest-plugin/+/764287 | 08:06 |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Update share access to "ro" during writing operation https://review.opendev.org/c/openstack/manila-tempest-plugin/+/764290 | 08:28 |
| *** tosky has joined #openstack-manila | 08:37 | |
| openstackgerrit | haixin proposed openstack/manila master: Extend share will go through scheduler https://review.opendev.org/c/openstack/manila/+/700393 | 09:24 |
| *** LinPeiWen has quit IRC | 09:36 | |
| *** lpetrut has joined #openstack-manila | 10:39 | |
| *** LinPeiWen has joined #openstack-manila | 10:39 | |
| *** raildo has joined #openstack-manila | 11:45 | |
| *** dviroel has joined #openstack-manila | 12:05 | |
| *** ianychoi_ has joined #openstack-manila | 12:35 | |
| *** ianychoi has quit IRC | 12:36 | |
| *** lpetrut has quit IRC | 13:08 | |
| *** lpetrut has joined #openstack-manila | 13:10 | |
| *** baojg has quit IRC | 14:11 | |
| *** iurygregory has quit IRC | 15:02 | |
| *** lpetrut has quit IRC | 15:33 | |
| *** lpetrut has joined #openstack-manila | 15:48 | |
| *** baojg has joined #openstack-manila | 16:19 | |
| *** jv has joined #openstack-manila | 16:29 | |
| *** jv has quit IRC | 16:30 | |
| *** tosky has quit IRC | 17:17 | |
| *** lpetrut has quit IRC | 20:02 | |
| *** jmlowe has joined #openstack-manila | 20:06 | |
| *** ivan_lin has quit IRC | 20:15 | |
| *** ivan_lin has joined #openstack-manila | 20:16 | |
| *** tosky has joined #openstack-manila | 21:09 | |
| *** raildo has quit IRC | 21:31 | |
| vkmc | carloss, hey, still around? | 22:00 |
| vkmc | I have an api question | 22:00 |
| vkmc | maybe you can help me | 22:00 |
| carloss | yes vkmc :) | 22:00 |
| vkmc | :D | 22:00 |
| vkmc | maybe it's silly, but I'm confused | 22:01 |
| vkmc | can we retrieve share-types by name by directly hitting the api? | 22:01 |
| vkmc | according to the api ref, we always pass the share-type-id https://docs.openstack.org/api-ref/shared-file-system/?expanded=show-share-type-detail-detail,list-default-share-types-detail#share-types | 22:02 |
| vkmc | but we have a tempest test in which we pass a name | 22:02 |
| carloss | yeah, as far as I remember the api ref is correct | 22:05 |
| vkmc | I wonder *how* this tempest test is working though | 22:05 |
| vkmc | in the gate | 22:05 |
| vkmc | at least | 22:05 |
| carloss | hehe, it is a good question | 22:06 |
| vkmc | https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/scenario/manager_share.py#L454-L456 | 22:06 |
| vkmc | this specifically | 22:06 |
| vkmc | when the default share type is picked, we use the name to define the default share type in the config file | 22:06 |
| vkmc | we usually call it "default" in the gates | 22:07 |
| vkmc | and we perform a get with the name... not the uuid | 22:07 |
| vkmc | carloss, thanks for confirming the api ref | 22:07 |
| carloss | yw vkmc | 22:08 |
| carloss | I'm trying to understand why it is working as is | 22:08 |
| carloss | it makes me curious | 22:08 |
| vkmc | unless we put the uuid instead of the name in the conf file | 22:09 |
| vkmc | but... I haven't seen that in the deployments we usually create with devstack | 22:09 |
| carloss | yep... | 22:16 |
| carloss | performed some tests specifying -d in the python-manilaclient to check the requests that were made, and found out that the requests aren't using the share-type name | 22:17 |
| vkmc | we get the id in the client | 22:18 |
| vkmc | https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/share_types.py#L134-L141 | 22:19 |
| vkmc | but in tempest | 22:19 |
| vkmc | we use a different client | 22:19 |
| vkmc | https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/services/share/json/shares_client.py#L635-L638 | 22:20 |
| vkmc | and just taking as an example one scenario test... we never retrieve the id for the default share type | 22:21 |
| vkmc | I wonder why we don't use our client for that... instead of using that implementation | 22:21 |
| *** vishalmanchanda has quit IRC | 22:21 | |
| carloss | yeah, i get your point | 22:29 |
| vkmc | I'll submit a test patch and see what happens :) | 22:36 |
| vkmc | thanks carloss++ | 22:36 |
| carloss | yw vkmc | 22:38 |
| carloss | btw, vkmc, i noticed a weird behavior | 22:38 |
| vkmc | where? | 22:39 |
| carloss | was trying some requests in postman and realized that if we specify /types/default, the request returns an objecty | 22:39 |
| carloss | but if it is another share type, i received 404 | 22:40 |
| carloss | so get /types/default works just fine, but a request to get a share type i have (dummy_dhss_false) /types/dummy_dhss_false returns 404 | 22:41 |
| carloss | so the test that specifies the share type named default will always work | 22:42 |
| carloss | but if the name is different from default, it won't | 22:42 |
| vkmc | oh wait | 22:42 |
| vkmc | that's because we have an endpoint | 22:42 |
| vkmc | https://docs.openstack.org/api-ref/shared-file-system/?expanded=show-share-type-detail-detail,list-default-share-types-detail#list-default-share-types | 22:43 |
| vkmc | this one :D | 22:43 |
| vkmc | that makes sense then | 22:43 |
| carloss | oh, that's true :) | 22:43 |
| carloss | yes, makes sense :) | 22:43 |
| vkmc | but it's a bug | 22:43 |
| vkmc | because if you create a default share type that is name carlos_default | 22:43 |
| vkmc | then it breaks | 22:43 |
| vkmc | so we need to fix the get_share_type in the tempest client AND we need to add a get_default_share_type that leverages that endpoint | 22:45 |
| carloss | oh, actually it will try to get the share type that is set as default in the manila.conf - https://github.com/openstack/manila/blob/master/manila/api/v2/share_types.py#L105 | 22:49 |
| vkmc | yes :) | 22:49 |
| vkmc | oh wait | 22:49 |
| carloss | then, if I create a default share type called carlos_default and set in the manila.conf, it will work :) | 22:49 |
| vkmc | I get it now | 22:49 |
| vkmc | perfect | 22:49 |
| vkmc | still there is a bug | 22:50 |
| vkmc | because we are passing the share type name to a function that expects the share_type id | 22:51 |
| vkmc | and there is no function calling the share-type/default endpoint | 22:52 |
| carloss | yes | 22:56 |
| carloss | if the share type we use for the test comes to have another name, it'd fail constantly | 22:57 |
| vkmc | ++ | 23:02 |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-tempest-plugin master: Adds get default share type function https://review.opendev.org/c/openstack/manila-tempest-plugin/+/764392 | 23:33 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!