| *** jungleboyj has quit IRC | 00:56 | |
| *** patrickeast has quit IRC | 00:56 | |
| *** patrickeast has joined #openstack-manila | 00:57 | |
| *** jungleboyj has joined #openstack-manila | 00:57 | |
| *** gouthamr has quit IRC | 00:57 | |
| *** gouthamr has joined #openstack-manila | 00:58 | |
| *** tosky has quit IRC | 01:01 | |
| *** LinPeiWen has quit IRC | 01:01 | |
| *** LinPeiWen has joined #openstack-manila | 02:05 | |
| *** baojg has joined #openstack-manila | 02:10 | |
| *** jmlowe has quit IRC | 03:36 | |
| *** baojg has quit IRC | 03:36 | |
| *** baojg has joined #openstack-manila | 03:37 | |
| *** jmlowe has joined #openstack-manila | 03:38 | |
| *** carloss has quit IRC | 03:41 | |
| *** baojg has quit IRC | 03:47 | |
| *** baojg has joined #openstack-manila | 03:48 | |
| *** kiwi_36 has quit IRC | 04:52 | |
| *** openstackgerrit has joined #openstack-manila | 05:35 | |
| openstackgerrit | zhongshengping proposed openstack/puppet-manila master: Prepare Wallaby M1 https://review.opendev.org/c/openstack/puppet-manila/+/765465 | 05:35 |
|---|---|---|
| *** vishalmanchanda has joined #openstack-manila | 05:38 | |
| *** lbragstad has quit IRC | 06:02 | |
| *** lbragstad has joined #openstack-manila | 06:03 | |
| *** maaritamm has left #openstack-manila | 07:00 | |
| *** maaritamm has joined #openstack-manila | 07:00 | |
| *** lpetrut has joined #openstack-manila | 07:06 | |
| openstackgerrit | Merged openstack/puppet-manila stable/ussuri: Add support for the interface parameter in authtoken middleware https://review.opendev.org/c/openstack/puppet-manila/+/765269 | 07:34 |
| *** lpetrut has quit IRC | 07:46 | |
| *** LinPeiWen has quit IRC | 08:30 | |
| *** tkajinam has quit IRC | 08:31 | |
| *** tkajinam has joined #openstack-manila | 08:32 | |
| *** LinPeiWen has joined #openstack-manila | 08:57 | |
| *** tosky has joined #openstack-manila | 09:05 | |
| *** lpetrut has joined #openstack-manila | 09:07 | |
| *** LinPeiWen has quit IRC | 09:38 | |
| *** carloss has joined #openstack-manila | 11:21 | |
| *** raissa has joined #openstack-manila | 12:51 | |
| *** jmlowe has quit IRC | 14:02 | |
| *** tkajinam has quit IRC | 14:07 | |
| *** jmlowe has joined #openstack-manila | 14:25 | |
| *** jmlowe has quit IRC | 14:31 | |
| *** openstackgerrit has quit IRC | 14:37 | |
| *** jmlowe has joined #openstack-manila | 14:41 | |
| *** jmlowe has quit IRC | 14:42 | |
| *** jmlowe has joined #openstack-manila | 14:43 | |
| *** jmlowe has quit IRC | 14:50 | |
| *** jmlowe has joined #openstack-manila | 14:52 | |
| *** jmlowe has quit IRC | 14:54 | |
| *** jmlowe has joined #openstack-manila | 15:17 | |
| *** jmlowe has quit IRC | 15:29 | |
| *** jmlowe has joined #openstack-manila | 15:51 | |
| *** jmlowe has quit IRC | 16:01 | |
| *** jmlowe has joined #openstack-manila | 16:17 | |
| *** openstackgerrit has joined #openstack-manila | 16:40 | |
| openstackgerrit | Merged openstack/puppet-manila master: Prepare Wallaby M1 https://review.opendev.org/c/openstack/puppet-manila/+/765465 | 16:40 |
| *** lpetrut has quit IRC | 17:00 | |
| *** vishalmanchanda has quit IRC | 17:58 | |
| *** jmlowe has quit IRC | 17:58 | |
| *** jmlowe has joined #openstack-manila | 18:18 | |
| *** raildo has quit IRC | 18:21 | |
| *** jmlowe has quit IRC | 18:22 | |
| *** jmlowe has joined #openstack-manila | 18:24 | |
| *** raildo has joined #openstack-manila | 18:43 | |
| *** raildo has quit IRC | 18:45 | |
| *** raildo has joined #openstack-manila | 18:48 | |
| *** jmlowe has quit IRC | 18:52 | |
| *** jmlowe has joined #openstack-manila | 19:05 | |
| *** jmlowe has quit IRC | 19:09 | |
| *** jmlowe has joined #openstack-manila | 20:36 | |
| maaritamm | Hi folks! Anyone around? I'd like to get some thoughts on something ... | 20:41 |
| maaritamm | I am implementing another list command for osc, share replicas to be exact. | 20:42 |
| maaritamm | And I did some thinkos on naming the columns ... | 20:43 |
| maaritamm | so for manila commands we always return a table, right? And we name the columns pretty, like Share ID, Is Public and such | 20:43 |
| maaritamm | but for osc, one can request the response to be json, yaml, etc | 20:44 |
| maaritamm | and now if we something like Is Public: false in yaml or json and someone tries to parse that output, having the space should cause problems, no? | 20:45 |
| maaritamm | so we might want to have the column names as share_id, is_public and such for all? | 20:47 |
| gouthamr | maaritamm: o/ | 21:05 |
| maaritamm | gouthamr \o | 21:05 |
| gouthamr | we have this problem with manila client today - and I think also that it’s implemented inconsistently | 21:06 |
| gouthamr | We allow filtering on the beautified columns in some cases and not the attributes themselves; and in some cases the other way around | 21:06 |
| gouthamr | And like you note, when the column names and attribute names match (and are a single word), things are fine | 21:07 |
| gouthamr | So I’d look at what other osc implementations do when the attributes are multi word | 21:08 |
| maaritamm | gotcha, yeah well, that also applies to osc then. Already now I see that we a bit of this an that | 21:08 |
| maaritamm | so the columns for osc are always sorted for the names we give the columns | 21:09 |
| maaritamm | I see "Created At" and "Volume ID" here https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/volume/v2/volume_snapshot.py#L251 | 21:13 |
| *** raissa has quit IRC | 21:13 | |
| gouthamr | Awesome | 21:13 |
| maaritamm | but do we want that in json/yaml? | 21:14 |
| gouthamr | So one would use “openstack share list -c ‘Is Public’”? | 21:14 |
| gouthamr | We don’t prettify the json/yaml outputs? | 21:15 |
| gouthamr | I mean, don’t alter the attribute names in any way? | 21:15 |
| maaritamm | nope, so the yaml would be : http://paste.openstack.org/show/800757/ | 21:20 |
| maaritamm | and json : http://paste.openstack.org/show/800759/ | 21:22 |
| gouthamr | I see, spaces in yaml/Json keys are kind of awkward | 21:23 |
| maaritamm | right? | 21:23 |
| gouthamr | But they work, and are acceptable :) so maybe people are okay with it? | 21:23 |
| maaritamm | ah ok :D | 21:24 |
| maaritamm | to me it looked really odd and got me thinking | 21:24 |
| maaritamm | yeah, seems like pretty column headers are a thing https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/compute/v2/server.py#L1671 | 21:35 |
| maaritamm | and yes the one will need to use “openstack share list -c ‘Is Public’” | 21:36 |
| maaritamm | for example "openstack share list -c id" will give an error: | 21:37 |
| maaritamm | No recognized column names in ['id']. Recognized columns are ['ID', 'Name', 'Size', 'Share Proto', 'Status', 'Is Public', 'Share Type Name', 'Host', 'Availability Zone']. | 21:37 |
| maaritamm | to be fair, the error message does give the options | 21:38 |
| maaritamm | But I guess I'll go ahead and keep things pretty? | 21:38 |
| maaritamm | maybe formatting the outputs can be handled on osc side of things ... | 21:39 |
| maaritamm | Anyway, thanks gouthamr! | 21:40 |
| *** raildo has quit IRC | 21:59 | |
| *** tkajinam has joined #openstack-manila | 22:00 | |
| gouthamr | maaritamm: yes, agreed | 23:10 |
| *** tosky has quit IRC | 23:54 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!