Thursday, 2021-04-22

*** carloss has quit IRC00:19
*** ivan_lin has quit IRC00:25
*** ivan_lin has joined #openstack-manila00:26
*** ivan_lin has quit IRC02:20
*** ivan_lin has joined #openstack-manila02:21
*** vhari has quit IRC02:40
*** vhari has joined #openstack-manila02:47
*** fzzf has joined #openstack-manila03:35
*** fzzf1 has joined #openstack-manila06:18
*** fzzf has quit IRC06:21
*** fzzf1 has quit IRC06:33
*** lpetrut has joined #openstack-manila06:36
*** sfernand has quit IRC07:05
*** tosky has joined #openstack-manila07:49
openstackgerritLin PeiWen proposed openstack/manila master: Fix the failure of share create form snapshot specifies'--availability-zone'  https://review.opendev.org/c/openstack/manila/+/78750708:48
openstackgerritLin PeiWen proposed openstack/manila master: Fix the failure of share create form snapshot specifies'--availability-zone'  https://review.opendev.org/c/openstack/manila/+/78750708:49
noonedeadpunko/10:18
noonedeadpunkregarding stack trace I saw yestarday http://paste.openstack.org/show/804717/10:21
noonedeadpunkit's caused by command `/openstack/venvs/manila-22.0.0.0rc2.dev166/bin/manila type-list` and goes in loop until api service restart10:22
noonedeadpunksame thing happens with `openstack share list`10:23
*** vhari has quit IRC10:28
*** vhari has joined #openstack-manila10:34
*** toabctl has joined #openstack-manila10:39
noonedeadpunkwell, I kind of found what's wrong with it10:55
noonedeadpunkfunny thing :)10:56
noonedeadpunkrelated to policy-to-yanl topic10:56
*** carloss has joined #openstack-manila11:03
noonedeadpunkhttps://bugs.launchpad.net/manila/+bug/192547511:07
openstackLaunchpad bug 1925475 in OpenStack Shared File Systems Service (Manila) "Manila API fails to handle policy issue logging when journal is used" [Undecided,New]11:07
*** lkuchlan has joined #openstack-manila11:19
noonedeadpunkbut, I how new error in tempest now one this is resolved :(11:25
noonedeadpunkhttps://zuul.opendev.org/t/openstack/build/07e0e0d7160b4196ae3c3ee01b773b9b/log/logs/host/manila-share.service.journal-17-44-54.log.txt#180211:30
noonedeadpunkbut it's already with vkmc patch applied... as I see ceph caps set like http://paste.openstack.org/show/804721/11:31
noonedeadpunkAnd not sure what subvolume is...11:31
noonedeadpunkI think manila has been operating with rbd drives themselves previously?11:31
noonedeadpunkwell, I see for devstack you using following caps ["mon", "allow *", "osd", "allow rw", "mds", "allow *", "mgr", "allow *"]11:37
gouthamrnoonedeadpunk: thanks for reporting LP 192547511:39
openstackLaunchpad bug 1925475 in OpenStack Shared File Systems Service (Manila) "Manila API fails to handle policy issue logging when journal is used" [Undecided,New] https://launchpad.net/bugs/192547511:39
gouthamrSo iiuc this issue manifests when there is a json policy file? does it go away when using a policy.yaml file?11:41
noonedeadpunkthe issue raised when there's any logging regarding policy file11:41
noonedeadpunkFor example, I created policy.yaml with wrong permissions (ie owned by root) and it was the same11:42
gouthamrOh!11:42
noonedeadpunkbut I was able to set use_journal=false and saw warnings/errors regardign policies11:42
gouthamrAwesome, ty - that info gives me some more context;11:43
gouthamrnoonedeadpunk: when you say vkmc's patch, do you mean this one? https://review.opendev.org/c/openstack/manila/+/78691211:45
vkmchey o/11:45
noonedeadpunkI meant https://opendev.org/openstack/openstack-ansible/commit/7a769bb9216693f8045e2a987c911004c06d5a15 :)11:45
noonedeadpunkbut probably not that11:46
noonedeadpunklet me try using origin/master11:47
gouthamrnoonedeadpunk: we caught a regression unfortunately with the caps, and https://review.opendev.org/c/openstack/manila/+/786912 is the fix11:47
gouthamrnoonedeadpunk: i haven't requested a release tag out of stable/wallaby yet11:47
noonedeadpunkhaving `mon "allow *" osd "allow rw" mds "allow *" mgr "allow *"` didn't help me though11:48
gouthamryep11:48
gouthamroh, hold on - vkmc: wasn't the regression that we needed "mon allow rw"11:48
gouthamr* would mean rw, no?11:48
vkmcthe caps we were missing in openstack-ansible was the mgr ones11:49
vkmcmgr "allow *"11:49
vkmcI don't know how is this related with policies11:50
vkmcare you seeing an error in the share-mgr log having cephfs as a backend?11:50
noonedeadpunknah, these are 2 separate things)11:50
noonedeadpunkyep - https://zuul.opendev.org/t/openstack/build/07e0e0d7160b4196ae3c3ee01b773b9b/log/logs/host/manila-share.service.journal-17-44-54.log.txt#180211:51
vkmcchecking11:51
* gouthamr notes that https://zuul.opendev.org/t/openstack/build/07e0e0d7160b4196ae3c3ee01b773b9b/log/logs/host/manila-share.service.journal-17-44-54.log.txt#1957-1997 is a bug as well11:51
gouthamrthe main issue however is https://zuul.opendev.org/t/openstack/build/07e0e0d7160b4196ae3c3ee01b773b9b/log/logs/host/manila-share.service.journal-17-44-54.log.txt#1915-192011:52
vkmcgouthamr, so it's the same issue we were hitting on the rdo ci11:52
gouthamryep11:52
* noonedeadpunk checking in sandbox if fix is helping here11:53
vkmcnoonedeadpunk, check if this one is in https://review.opendev.org/c/openstack/manila/+/78691211:53
noonedeadpunknah, originally it was not.11:53
noonedeadpunkwe bumped the day before it merged https://opendev.org/openstack/openstack-ansible/src/branch/master/playbooks/defaults/repo_packages/openstack_services.yml#L14011:54
gouthamroh nice, you guys don't use tags11:55
noonedeadpunknope:)11:55
noonedeadpunkbut it's confusing in prod envs tbh11:56
noonedeadpunkas you always end up with some dev version if checking pip11:56
vkmcnoonedeadpunk, let us know if applying that fix solves the issue :)12:06
noonedeadpunkseems it does:) `Apr 22 12:07:22 aio1 manila-share[227264]: 2021-04-22 12:07:22.292 227264 INFO manila.share.manager [req-e513f491-6d6b-4b11-96df-3128f867ac6d 26f2e1378890443eb935631220937b9c 9ad37a93ffc94403a016148df70bf45a - - -] Share instance a3b75a29-eacf-4031-878b-b63b4cac6e2e created successfully.`12:07
vkmc\o/12:08
gouthamrawesome! i'll request a tag right away for anyone that might need it12:08
gouthamrwhile we're doing that, can you help land two more bugfixes? https://review.opendev.org/q/project:openstack/manila+status:open+branch:stable/wallaby12:11
gouthamrvkmc carloss tbarron dviroel ^12:11
carlosssure!12:12
vkmcsure!12:13
noonedeadpunkok, thanks for your time! tempest just passed successfully for me!12:17
gouthamrnoonedeadpunk: ty for finding these bugs; i'm glad osa consumers won't see them! :)12:19
noonedeadpunkwell, we haven't released W so yeah...12:19
noonedeadpunkgood to have some more time12:20
*** ecsantos has joined #openstack-manila12:23
vkmc++12:24
*** lpetrut_ has joined #openstack-manila12:27
*** lpetrut has quit IRC12:29
*** ivan_lin has quit IRC13:04
*** ivan_lin has joined #openstack-manila13:05
*** ivan_lin has quit IRC13:05
*** ivan_lin has joined #openstack-manila13:06
*** brinzhang_ has joined #openstack-manila13:14
*** lpetrut_ has quit IRC13:45
*** brinzhang_ has quit IRC13:50
openstackgerritMerged openstack/manila stable/wallaby: Document policy rule using the description parameter  https://review.opendev.org/c/openstack/manila/+/78538713:59
*** disap has joined #openstack-manila14:05
noonedeadpunkfwiw in CI things does not look so good15:20
noonedeadpunkeventually more permissions are required that was provided atm15:20
noonedeadpunkas localy I was testing with  having `mon "allow *" osd "allow rw" mds "allow *" mgr "allow *"`15:20
noonedeadpunkAnd CI ends up with rados.Error: [errno -13] access denied: does your client key have mgr caps?15:21
noonedeadpunkhttps://zuul.opendev.org/t/openstack/build/668e476ba50a45cd882e3b9b3d79c44a/log/logs/host/manila-share.service.journal-14-23-55.log.txt#190515:21
*** lkuchlan has quit IRC15:21
gouthamrcrap, i forgot to hit "resume recording" for vb123 and ecsantos's session  :( :15:24
dviroel:(15:24
gouthamrdamn sorry about that, ecsantos15:24
gouthamrnoonedeadpunk: ouch, we're in our PTG sessions again today - vkmc/I will take a look15:25
vkmcnoonedeadpunk, looking15:26
noonedeadpunkgouthamr: yeah, sure, I'm just saying kind of)15:26
noonedeadpunkI believe caps should be like that atm http://paste.openstack.org/show/804721/15:26
vkmccaps mgr = "allow r" <- "allow *"15:27
noonedeadpunkso for mgr it should be * ?15:27
vkmcyes15:28
vkmcwonder how it was set to r15:28
noonedeadpunkwell, it was your patch I believe? https://opendev.org/openstack/openstack-ansible/commit/7a769bb9216693f8045e2a987c911004c06d5a1515:28
noonedeadpunkSo I thought that `r` is correct thing....15:29
vkmcthat's not right, no15:29
noonedeadpunk:(15:29
vkmclet me fix that15:29
noonedeadpunkI will adjust my patch that fixing tempest settings15:30
noonedeadpunkor maybe it's really worth having as a separate patch...15:31
vkmcnoonedeadpunk, give me a sec while I check the correct caps15:31
noonedeadpunkwould be great if you could push it to speed up review process :)15:31
vkmcdefinitely15:31
noonedeadpunkin devstack it's *15:32
vkmcnoonedeadpunk, just to make sure, you are using a deployment with manila wallaby and ceph octopus15:33
vkmcdevstack caps are broader than we advise15:34
vkmcnoonedeadpunk, I see this line here https://zuul.opendev.org/t/openstack/build/668e476ba50a45cd882e3b9b3d79c44a/log/logs/host/manila-share.service.journal-14-23-55.log.txt#5615:35
vkmcnoonedeadpunk, is the rados module installed?15:37
noonedeadpunkI think that's fine kind of? as we later restart service15:37
noonedeadpunkon L71615:37
noonedeadpunkI thin kwe could do better, but we install venv, deploy systemd file and only later configure service and symlink extra modules into the venv (since librados is not smth you can install with pip)15:38
noonedeadpunkyes, that patch depends-on change that updates SHA https://review.opendev.org/c/openstack/openstack-ansible/+/787540/1/playbooks/defaults/repo_packages/openstack_services.yml inlcuding your fix15:39
vkmcit's fine yes, just checking15:39
noonedeadpunkwithout it it was failing worse15:39
noonedeadpunkwell, I still have sandbox where tempest passed with devstack permissions15:40
noonedeadpunkI can change them to what we use and see the result15:41
vkmcnoonedeadpunk, can you try in your env changing the caps to mgr allow 'rw'?15:41
vkmcif that works for you, will submit the fix to osa15:41
vkmcrw should be enough15:41
noonedeadpunkrunning tempest with `ceph auth caps client.manila mon "allow *" osd "allow rw" mds "allow *" mgr "allow rw"`15:42
vkmcnoonedeadpunk++15:42
vkmcthanks for that15:42
noonedeadpunk{0} manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsNFS.test_mount_share_one_vm [158.363910s] ... ok15:44
vkmc:D15:44
vkmcok, will submit the fix to osa15:45
noonedeadpunkcool, thanks!15:45
*** dviroel is now known as dviroel|lunch15:46
noonedeadpunkhm.....15:48
noonedeadpunkceph auth caps client.manila mon "allow *" osd "allow rw" mds "allow *" mgr "allow r" also worked15:50
* noonedeadpunk needs more testing...15:51
noonedeadpunkI suppose that in caps mon permissions were missing.....15:52
noonedeadpunkas currently I have `caps mon = "allow *"`15:52
vkmcnoonedeadpunk, https://review.opendev.org/c/openstack/openstack-ansible/+/78759115:54
openstackgerritTom Barron proposed openstack/manila master: Remove deprecated config and auth  https://review.opendev.org/c/openstack/manila/+/74520616:06
openstackgerritVictoria Martinez de la Cruz proposed openstack/manila master: Updates CephFS drivers docs  https://review.opendev.org/c/openstack/manila/+/78287116:08
ecsantosnp gouthamr don't worry16:45
*** dviroel|lunch is now known as dviroel16:58
tbarronecsantos: great preso, btw!17:02
ecsantostbarron: thanks a lot :D17:06
*** disap has quit IRC17:16
dviroelecsantos++17:19
openstackgerritVictoria Martinez de la Cruz proposed openstack/manila master: Updates CephFS drivers docs  https://review.opendev.org/c/openstack/manila/+/78287117:23
vkmcnoonedeadpunk, seems we needed to fix other caps apart from adding the mgr rw one, so the last patch I submitted to osa should be what you were missing17:38
*** ianychoi_ has joined #openstack-manila17:38
vkmcnoonedeadpunk, I linked to a patch in devstack-plugin-ceph that we test this... the ci is running on that change, devstack-plugin-ceph-cephfs-native passed, now we are waiting for the nfs gate17:39
*** ecsantos has quit IRC17:42
*** ianychoi__ has quit IRC17:48
*** jv has quit IRC17:48
*** carthaca has quit IRC17:48
*** kopecmartin has quit IRC17:48
*** eharney has quit IRC17:49
*** jv has joined #openstack-manila17:54
*** eharney has joined #openstack-manila17:55
*** lbragstad_ has joined #openstack-manila18:29
*** lbragstad has quit IRC18:32
openstackgerritVictoria Martinez de la Cruz proposed openstack/manila master: Updates CephFS drivers docs  https://review.opendev.org/c/openstack/manila/+/78287119:31
*** arne_wiebalck has quit IRC19:51
*** rajinir has quit IRC19:51
*** almir-okato has quit IRC19:52
*** lbragstad_ is now known as lbragstad19:56
*** arne_wiebalck has joined #openstack-manila19:57
*** rajinir has joined #openstack-manila19:57
*** almir-okato has joined #openstack-manila19:57
*** irclogbot_0 has quit IRC21:50
*** irclogbot_2 has joined #openstack-manila21:54
*** tosky has quit IRC23:17

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!