Monday, 2021-05-10

*** LinPeiWen has joined #openstack-manila00:56
*** ivan_lin has quit IRC03:37
*** LinPeiWen has quit IRC03:37
*** ivan_lin has joined #openstack-manila03:37
*** jmlowe has quit IRC05:56
*** jmlowe has joined #openstack-manila06:34
*** LinPeiWen has joined #openstack-manila06:35
*** ivan_lin has quit IRC07:11
*** LinPeiWen has quit IRC07:11
*** ivan_lin has joined #openstack-manila07:12
*** tosky has joined #openstack-manila07:36
*** LinPeiWen has joined #openstack-manila07:48
*** ivan_lin has quit IRC07:50
*** LinPeiWen80 has joined #openstack-manila08:21
*** lpetrut has joined #openstack-manila09:27
*** carloss has joined #openstack-manila10:38
simondodsleyNeed some help with the `manila_tempest_plugin` tests. I have 7 tests that error with `Share network must be set when the driver_handles_share_servers is true` which makes no sense as the driver I am testing has DHSS set to false.13:07
simondodsleyAn example of a failing test is `test_create_shrink_and_write`13:07
*** jv has joined #openstack-manila13:12
vkmcsimondodsley, can you share your tempest.conf?13:13
vkmcmultitenancy_enabled = True <- you need this set to false if it's dhss=false13:17
vkmcmore info here https://docs.openstack.org/manila/latest/contributor/tempest_tests.html13:18
simondodsleyThis is auto-generated from Software Factory which we use for our CI system https://www.irccloud.com/pastebin/eCof90mr/13:19
simondodsleyI have `multitenancy_enabled = False`13:20
*** tosky_ has joined #openstack-manila13:27
*** tosky has quit IRC13:27
*** tosky_ is now known as tosky13:27
vkmchm13:31
vkmcsimondodsley, default_share_type_name = dhss_false <- this share type has dhss = false too, right?13:31
simondodsleyyes13:34
vkmcseems that error is raised here https://opendev.org/openstack/manila/src/branch/master/manila/api/v1/shares.py#L381-L38813:35
simondodsleythat is a default share type created by devstack13:35
vkmcwell, the default share created by devstack has the name "default"13:36
simondodsleyYes - but that has DHSS = true13:36
simondodsleymisused defauklt - it is a share type created by devstack13:36
simondodsleyIf I use `default` fir the share-type many other tests fail with the same error message.13:37
vkmcah you are right, we create default, dhss_false and dhss_true13:37
simondodsleySeems that these 7 specific tests are failing  for some other reason that is setting of this error message13:37
*** vishalmanchanda has joined #openstack-manila13:37
vkmcsimondodsley, is this showing on the patch you have up for review in the queue?13:38
simondodsleyyes13:38
vkmccool, let me take a look13:38
vkmcit's odd, I'm seeing that we define all the other gates, being those dhss true or dhss false to use the default share type for tempest13:58
vkmcand it passes13:58
vkmcdviroel, o/13:58
vkmcdviroel, maybe you can take a look? not sure what we are missing there13:58
dviroelvkmc: o/13:59
vkmcdviroel, mostly scenario tests are failing for simondodsley13:59
openstackgerritMerged openstack/devstack-plugin-ceph master: Changed minversion in tox to 3.18.0  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/79021514:00
dviroeloh, let me take a look then14:00
dviroelthis change here: https://review.opendev.org/c/openstack/manila/+/789384 ?14:00
simondodsleyyes14:01
vkmcyes14:01
vkmcdviroel, the only difference with other gates is that simondodsley is using dhss_false share type in tempest conf14:02
vkmcdviroel, for some reason we use default for all the gates, being those dhss=false or dhss=true14:02
* dviroel looking14:10
*** lpetrut has quit IRC14:22
* dviroel looking into tempest-plugin14:22
gouthamrSimon simondodsley14:39
gouthamrcan you share your local.conf file?14:39
dviroelsorry, in a meeting right now14:40
gouthamrwe’ve some devstack plug-in opts to override the default share type and the specs associated with them - the plug-in should be creating three share types by default; but, we could be having a special preference to the one called “default” somehow14:42
simondodsleygouthamr: This is the `local.conf` https://www.irccloud.com/pastebin/Hgwe79j3/14:47
* gouthamr switches to workstation14:53
gouthamrsimondodsley: the plugin tries to read backend config and set the appropriate value for the extra-spec "driver_handles_share_servers": https://github.com/openstack/manila/blob/master/devstack/plugin.sh#L53114:56
gouthamrsimondodsley: in your case, the backend is being configured via post_config...14:57
gouthamrsimondodsley: so that may be the issue here...14:58
gouthamryeah.. http://openstack-logs.purestorage.com/84/789384/2/thirdparty-check/pure-devstack-manila-tempest-aio/0c94253/job-output.txt.gz#_2021-05-10_14_20_47_69587015:00
simondodsleyso you want it created in the `DEFAULT` section? Isn't that confusing? Isn't the whole point of the `post-config` to set up specific backend stanzas15:00
simondodsleyThen I would not have to force the default share type to be something other than default as well15:01
simondodsleyI guess I did it this way as that is the way we do it in the Cinder tempest tests and that is what I know15:02
gouthamrhttp://paste.openstack.org/show/805169/15:03
simondodsleyYep - I'll change that and see what happens - thanks15:04
vkmcgouthamr++15:12
vkmcthanks for following up15:12
dviroelgouthamr++ tks15:16
vkmcsimondodsley, if that fixes it for you, could you open a doc bug?15:18
vkmcwe could clarify this in the driver maintainers docs15:18
gouthamrif this works, we could add it to the driver maintainers doc we were planning15:22
simondodsleySure15:33
simondodsleyDidn't work - the devstack build fails with this `/opt/stack/devstack/.localrc.auto: line 56: MANILA_OPTGROUP_flashblade-1_driver_handles_share_servers=False: command not found` which makes no sense15:39
simondodsleycould it be the hyphen in the backend name?15:39
gouthamrOh - yes, likely15:39
simondodsleyOK - I'll amend and try again then15:41
openstackgerritRadosław Piliszek proposed openstack/devstack-plugin-ceph master: Bump up Ceph to Pacific and Ganesha to v3.5  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/78777418:14
*** afabio has joined #openstack-manila20:21
*** vishalmanchanda has quit IRC20:27
openstackgerritGoutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: Bump up Ceph to Pacific and Ganesha to v3.5  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/78777421:54
*** iurygregory has quit IRC22:07
*** iurygregory has joined #openstack-manila22:11
*** afabio has quit IRC22:42
*** tosky has quit IRC22:57

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!