| *** ivan_lin has quit IRC | 00:23 | |
| *** ivan_lin has joined #openstack-manila | 00:24 | |
| *** ChanServ has quit IRC | 01:05 | |
| *** LinPeiWen has quit IRC | 01:12 | |
| *** ChanServ has joined #openstack-manila | 01:15 | |
| *** weber.freenode.net sets mode: +o ChanServ | 01:15 | |
| *** LinPeiWen has joined #openstack-manila | 01:37 | |
| *** carloss has quit IRC | 02:49 | |
| fzzf | Hi,I'm implementing a new driver. I noticed that there is a tests directory in the manila directory, and there is a test file corresponding to the driver in the tests. I want to ask whether the test file also needs to be implemented, and what parts need to be implemented. | 03:49 |
|---|---|---|
| *** ivan_lin has quit IRC | 05:34 | |
| *** jv has quit IRC | 05:55 | |
| *** jv has joined #openstack-manila | 05:59 | |
| *** vishalmanchanda has joined #openstack-manila | 06:54 | |
| *** tosky has joined #openstack-manila | 07:22 | |
| *** openstackgerrit has joined #openstack-manila | 07:29 | |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: If default share type exists, use it for share creation https://review.opendev.org/c/openstack/manila-tempest-plugin/+/775148 | 07:29 |
| vkmc | fzzf, o/ | 07:32 |
| vkmc | fzzf, you are referring to the unit tests, right? | 07:32 |
| fzzf | yes,it is | 07:33 |
| vkmc | fzzf, so, I don't think there is a exact implementation expectation for that, but minimum coverage is required | 07:34 |
| vkmc | fzzf, we do have the coverage suite to help you check which parts of the new logic is not being covered (and give you some insight on what needs to be tested) | 07:34 |
| fzzf | what needs to be tested,Is there any guidance? | 07:38 |
| vkmc | fzzf, I'd look previous drivers submissions | 07:38 |
| vkmc | such as | 07:38 |
| vkmc | https://opendev.org/openstack/manila/src/branch/master/manila/share/drivers/zadara | 07:39 |
| vkmc | this was the latest driver that was added | 07:39 |
| vkmc | this is* | 07:39 |
| vkmc | https://opendev.org/openstack/manila/src/branch/master/manila/tests/share/drivers/zadara/test_zadara.py <- test coverage | 07:40 |
| fzzf | Excuse me, what does * mean,does it mean it is necessary | 07:41 |
| vkmc | no, I'm correcting myself... s/this was/this is/g | 07:42 |
| vkmc | check out reviews in https://review.opendev.org/c/openstack/manila/+/768590 | 07:42 |
| vkmc | so you get an idea of what reviewers look when reviewing a new driver | 07:43 |
| fzzf | ok,I'll check it,thanks | 07:45 |
| fzzf | I have another question, *_driver.rst also need to add,right? | 07:48 |
| *** vishalmanchanda has quit IRC | 08:11 | |
| *** vishalmanchanda has joined #openstack-manila | 08:22 | |
| vkmc | fzzf, those are the docs | 08:30 |
| vkmc | and yes, it's preferred | 08:30 |
| fzzf | OK,I get it.tks:) | 08:32 |
| vkmc | fzzf, cool! | 08:37 |
| openstackgerrit | Luigi Toscano proposed openstack/devstack-plugin-ceph master: WIP Allow the usage of Clone v2 API https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/782624 | 09:33 |
| *** tinwood has quit IRC | 10:08 | |
| *** rm_work has quit IRC | 10:08 | |
| *** tinwood has joined #openstack-manila | 10:09 | |
| *** rm_work has joined #openstack-manila | 10:09 | |
| *** arne_wiebalck has quit IRC | 10:13 | |
| *** arne_wiebalck has joined #openstack-manila | 10:14 | |
| *** jv has quit IRC | 10:14 | |
| *** openstackgerrit has quit IRC | 10:14 | |
| *** bswartz has quit IRC | 10:14 | |
| *** openstackgerrit has joined #openstack-manila | 10:16 | |
| *** jv has joined #openstack-manila | 10:16 | |
| *** bswartz has joined #openstack-manila | 10:16 | |
| *** mnaser has quit IRC | 10:16 | |
| *** ganso has quit IRC | 10:17 | |
| *** jrosser has quit IRC | 10:18 | |
| *** supamatt has quit IRC | 10:18 | |
| *** hoonetorg has quit IRC | 10:18 | |
| *** andreaf has quit IRC | 10:18 | |
| *** iurygregory has quit IRC | 10:18 | |
| *** Anticimex has quit IRC | 10:18 | |
| *** vishalmanchanda has quit IRC | 10:18 | |
| *** Reepicheep has quit IRC | 10:18 | |
| *** toabctl has quit IRC | 10:18 | |
| *** johanssone has quit IRC | 10:18 | |
| *** vishalmanchanda has joined #openstack-manila | 10:20 | |
| *** hoonetorg has joined #openstack-manila | 10:20 | |
| *** supamatt has joined #openstack-manila | 10:20 | |
| *** jrosser has joined #openstack-manila | 10:20 | |
| *** Reepicheep has joined #openstack-manila | 10:20 | |
| *** toabctl has joined #openstack-manila | 10:20 | |
| *** iurygregory has joined #openstack-manila | 10:20 | |
| *** andreaf has joined #openstack-manila | 10:20 | |
| *** johanssone has joined #openstack-manila | 10:20 | |
| *** Anticimex has joined #openstack-manila | 10:20 | |
| *** mnaser has joined #openstack-manila | 10:21 | |
| *** ChanServ has quit IRC | 10:21 | |
| *** ganso has joined #openstack-manila | 10:24 | |
| *** ChanServ has joined #openstack-manila | 10:24 | |
| *** weber.freenode.net sets mode: +o ChanServ | 10:24 | |
| *** trident has quit IRC | 10:27 | |
| *** trident has joined #openstack-manila | 10:27 | |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: If default share type exists, use it for share creation https://review.opendev.org/c/openstack/manila-tempest-plugin/+/775148 | 10:32 |
| *** supamatt has quit IRC | 10:57 | |
| *** hoonetorg has quit IRC | 10:58 | |
| *** nahimsouza has joined #openstack-manila | 11:02 | |
| *** carloss has joined #openstack-manila | 11:21 | |
| *** fzzf has quit IRC | 11:24 | |
| *** dviroel has joined #openstack-manila | 11:31 | |
| *** tosky has quit IRC | 12:08 | |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: If default share type exists, use it for share creation https://review.opendev.org/c/openstack/manila-tempest-plugin/+/775148 | 12:14 |
| *** fabiooliveira has joined #openstack-manila | 12:32 | |
| *** nahimsouza has quit IRC | 13:11 | |
| *** archanaserver has joined #openstack-manila | 13:14 | |
| openstackgerrit | Hitesh Kumar proposed openstack/manila-specs master: Remove testr https://review.opendev.org/c/openstack/manila-specs/+/792985 | 14:15 |
| *** fabiooliveira has quit IRC | 14:42 | |
| *** archanaserver has quit IRC | 15:03 | |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: If default share type exists, use it for share creation https://review.opendev.org/c/openstack/manila-tempest-plugin/+/775148 | 15:06 |
| openstackgerrit | Simon Dodsley proposed openstack/manila master: Add Pure Storage FlashBlade driver https://review.opendev.org/c/openstack/manila/+/789384 | 16:06 |
| *** tosky has joined #openstack-manila | 16:14 | |
| openstackgerrit | Hitesh Kumar proposed openstack/manila-ui master: Remove testr https://review.opendev.org/c/openstack/manila-ui/+/793004 | 16:44 |
| openstackgerrit | Simon Dodsley proposed openstack/manila master: Add Pure Storage FlashBlade driver https://review.opendev.org/c/openstack/manila/+/789384 | 17:14 |
| *** hoonetorg has joined #openstack-manila | 17:25 | |
| openstackgerrit | Merged openstack/devstack-plugin-ceph master: Bump up Ceph to Pacific and Ganesha to v3.5 https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/787774 | 18:18 |
| *** mnaser has quit IRC | 18:30 | |
| *** mnaser has joined #openstack-manila | 18:30 | |
| *** archanaserver has joined #openstack-manila | 19:59 | |
| openstackgerrit | Simon Dodsley proposed openstack/manila master: Add Pure Storage FlashBlade driver https://review.opendev.org/c/openstack/manila/+/789384 | 21:11 |
| openstackgerrit | Simon Dodsley proposed openstack/manila master: Add Pure Storage FlashBlade driver https://review.opendev.org/c/openstack/manila/+/789384 | 21:15 |
| *** archanaserver has quit IRC | 21:20 | |
| openstackgerrit | Simon Dodsley proposed openstack/manila master: Add Pure Storage FlashBlade driver https://review.opendev.org/c/openstack/manila/+/789384 | 21:26 |
| openstackgerrit | Carlos Eduardo proposed openstack/python-manilaclient master: Fix typo in quota set error message https://review.opendev.org/c/openstack/python-manilaclient/+/793067 | 21:31 |
| *** vishalmanchanda has quit IRC | 22:13 | |
| *** carthaca has quit IRC | 22:16 | |
| *** tosky has quit IRC | 23:03 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/python-manilaclient master: [ci] fix neutron services in functional job https://review.opendev.org/c/openstack/python-manilaclient/+/793075 | 23:20 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/python-manilaclient master: [TrivialFix] Follow up per-share-gigabytes quota changes https://review.opendev.org/c/openstack/python-manilaclient/+/793076 | 23:27 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!