| opendevreview | haixin proposed openstack/manila-specs master: Manila share support Recycle Bin https://review.opendev.org/c/openstack/manila-specs/+/790320 | 02:27 |
|---|---|---|
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/train: Make test-setup.sh compatible with mysql8 https://review.opendev.org/c/openstack/manila/+/798759 | 04:58 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Remove unused microversions https://review.opendev.org/c/openstack/manila-tempest-plugin/+/798803 | 08:15 |
| opendevreview | Archana Kumari proposed openstack/manila-ui master: API v2.39, added share-type quotas https://review.opendev.org/c/openstack/manila-ui/+/798807 | 09:07 |
| *** dviroel|out is now known as dviroel | 11:29 | |
| opendevreview | Tobias Urdin proposed openstack/puppet-manila stable/victoria: Add support for the keystone_authtoken/service_type parameter https://review.opendev.org/c/openstack/puppet-manila/+/798775 | 11:29 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Remove unused microversions https://review.opendev.org/c/openstack/manila-tempest-plugin/+/798803 | 11:43 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/python-manilaclient master: Add --wait flag to the delete share group operation https://review.opendev.org/c/openstack/python-manilaclient/+/789018 | 13:08 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/python-manilaclient master: Add --wait flag to the delete share group operation https://review.opendev.org/c/openstack/python-manilaclient/+/789018 | 14:29 |
| opendevreview | Merged openstack/manila master: TrivialFix: Fix the filter name in config helper https://review.opendev.org/c/openstack/manila/+/798197 | 14:48 |
| opendevreview | Merged openstack/puppet-manila stable/victoria: Add support for the keystone_authtoken/service_type parameter https://review.opendev.org/c/openstack/puppet-manila/+/798775 | 16:01 |
| opendevreview | Merged openstack/manila stable/wallaby: PowerMax Manila - version change for Wallaby https://review.opendev.org/c/openstack/manila/+/798063 | 17:19 |
| simondodsley | if i perform a `manila access-deny` on a rule in error state, should this fail and if so how do I force this rule to be deleted | 18:46 |
| gouthamr | simondodsley: depends, is the failure occurring in the driver? | 19:00 |
| simondodsley | gouthamr: when the driver tries to set an incorrrect rule is sets the state as `error`. Should the driver handle deleting those, or should it be done in the core code? | 19:01 |
| gouthamr | simondodsley: the driver must ignore incorrect rules when denying access | 19:02 |
| simondodsley | ok | 19:02 |
| gouthamr | simondodsley: for your flashblade driver, you don't really "deny" (or "allow") access individually - you're doing the right thing by processing all teh rules in "access_rules" and performing an atomic update | 19:08 |
| gouthamr | simondodsley: so i'm confused by your question; "if i perform a `manila access-deny` on a rule in error state, should this fail" -- no, the rule should be deleted | 19:09 |
| gouthamr | the structures "add_rules" and "delete_rules" only serve backends that can't do an atomic update like your driver is doing | 19:10 |
| gouthamr | its safe to ignore those | 19:10 |
| simondodsley | gouthamr: thisis not for the flashblade driver - this is for another one i'm writing - for our FlashArray product | 19:12 |
| gouthamr | simondodsley: oh, i see | 19:12 |
| simondodsley | gouthamr: this uses a different methodology for access rules | 19:12 |
| gouthamr | simondodsley: ack; we do have some text here that clarifies this: https://github.com/openstack/manila/blob/f580fbc5336caf4066b19a52af94b44158631144/manila/share/driver.py#L774-L775 | 19:14 |
| gouthamr | if there's something missing, do let me know | 19:14 |
| opendevreview | Simon Dodsley proposed openstack/manila master: WIP: Add Pure Storage FlashArray driver https://review.opendev.org/c/openstack/manila/+/795180 | 20:36 |
| *** dviroel is now known as dviroel|out | 20:41 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!