| opendevreview | Vida Haririan proposed openstack/python-manilaclient master: [OSC] Implement Share Limits Show command https://review.opendev.org/c/openstack/python-manilaclient/+/805088 | 01:10 |
|---|---|---|
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/wallaby: Add documentation for share server limits https://review.opendev.org/c/openstack/manila/+/806690 | 07:13 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/train: fixes availability zone filter when creating a share from snapshot https://review.opendev.org/c/openstack/manila/+/806691 | 07:14 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/wallaby: handle replica state on migration complete https://review.opendev.org/c/openstack/manila/+/806692 | 07:15 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/wallaby: Add missing [oslo_reports] options https://review.opendev.org/c/openstack/manila/+/806693 | 07:15 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/victoria: Use oslo-config-generator conf to load options from libraries https://review.opendev.org/c/openstack/manila/+/806694 | 07:16 |
| opendevreview | Vida Haririan proposed openstack/python-manilaclient master: [OSC] Implement Share Limits Show command https://review.opendev.org/c/openstack/python-manilaclient/+/805088 | 07:53 |
| opendevreview | haixin proposed openstack/manila master: Manila share support Recycle Bin https://review.opendev.org/c/openstack/manila/+/800753 | 10:23 |
| opendevreview | Felipe Rodrigues proposed openstack/manila master: [NetApp] Add readable replication type support https://review.opendev.org/c/openstack/manila/+/803621 | 10:40 |
| opendevreview | Felipe Rodrigues proposed openstack/manila master: [NetApp] Add FlexGroup volume support https://review.opendev.org/c/openstack/manila/+/803622 | 11:46 |
| opendevreview | Felipe Rodrigues proposed openstack/manila master: [NetApp] Add FlexGroup volume support https://review.opendev.org/c/openstack/manila/+/803622 | 12:46 |
| opendevreview | Nahim Alves de Souza proposed openstack/manila master: [NetApp] Fix list of mandatory services for CIFS share creation https://review.opendev.org/c/openstack/manila/+/806764 | 15:26 |
| opendevreview | Nahim Alves de Souza proposed openstack/manila master: [NetApp] Fix list of mandatory services for CIFS share creation https://review.opendev.org/c/openstack/manila/+/806764 | 15:30 |
| opendevreview | Ashley Rodriguez proposed openstack/manila master: [WIP] Replace retrying with tenacity https://review.opendev.org/c/openstack/manila/+/801911 | 15:39 |
| *** dviroel|out is now known as dviroel|ruck | 16:54 | |
| ashrodri | hey are you around? | 16:59 |
| ashrodri | gouthamr | 16:59 |
| opendevreview | kiran pawar proposed openstack/manila master: Add Share Affinity/Anti-Affinity Scheduler Filters https://review.opendev.org/c/openstack/manila/+/775201 | 17:04 |
| gouthamr | ashrodri: ssup? | 17:29 |
| ashrodri | need some assistance with the user_mod + policy unit test | 17:31 |
| * gouthamr gets out of a meeting | 17:47 | |
| gouthamr | ashrodri: sure, is this on gerrit already? | 17:47 |
| ashrodri | yeah, https://review.opendev.org/c/openstack/manila/+/806647 | 17:51 |
| gouthamr | you're referring to https://review.opendev.org/c/openstack/manila/+/806647/1/manila/tests/api/v1/test_share_metadata.py#230 ? | 17:54 |
| ashrodri | yeah, and line #336 | 17:58 |
| opendevreview | Nahim Alves de Souza proposed openstack/python-manilaclient master: Implement OSC share instance export location commands https://review.opendev.org/c/openstack/python-manilaclient/+/805307 | 18:12 |
| gouthamr | ashrodri: hey, i don't see code setting the "user_modifiable" field in the database | 18:19 |
| gouthamr | for example: mod = {'user_modifiable': False} | 18:20 |
| gouthamr | ref = db.share_metadata_get_item( | 18:20 |
| gouthamr | self.userctxt, self.share_id, 'key11') | 18:20 |
| gouthamr | ref.update(mod) | 18:20 |
| gouthamr | ^ that update won't update the db | 18:20 |
| ashrodri | the default value is True, that ^^ wont change it to False, how do I update it? | 18:22 |
| gouthamr | the db update method could do that | 18:23 |
| gouthamr | in the "_share_metadata_update" method in sqlalchemy/api.py, check each of the "metadata" members if they specify a "user_modifiable" field | 18:24 |
| gouthamr | currently, metadata can look like this: {'foo': 'bar', 'qux': 'baz'} | 18:26 |
| ashrodri | so lines 3480-3484 in manila/db/sqlalchemy/api.py wouldnt work? | 18:26 |
| ashrodri | it checks if user_mod is false, then checks the policy. otherwise it updates metadata as it normally would | 18:27 |
| gouthamr | yes, that part looks correct | 18:28 |
| gouthamr | i meant, you're treating "key11" as non-usermodifiable metadata in your unit test | 18:29 |
| ashrodri | right | 18:29 |
| gouthamr | however, "key11" is user modifiable by default - you've not yet created a provision to override it | 18:29 |
| ashrodri | ohhhh, so I should make a new function that changes user_mod to False if the policy req is met? | 18:30 |
| gouthamr | not a new function | 18:30 |
| gouthamr | lemme take a stab, i was thinking you could add some more logic to how the metadata dict is parsed | 18:30 |
| ashrodri | could we add a user_mod=True to the _share_metadata_update function, and allow only admins to set it to False? | 18:31 |
| ashrodri | as an argument I mean | 18:31 |
| gouthamr | ashrodri: https://paste.opendev.org/show/808479/ | 18:38 |
| gouthamr | a kwarg wouldn't work since metadata is a dictionary of possibly more than one key=value pair | 18:38 |
| ashrodri | in "for meta_key, meta_value in metadata.items():" what is meta_key and meta_value supossed to be? | 18:46 |
| ashrodri | like how it is parsing metadata.items? | 18:46 |
| ashrodri | when would meta_value be a dict, and not the value part of "key: value" which is what we expect to see in metadata? | 18:48 |
| gouthamr | > 11:48:18 AM <ashrodri> when would meta_value be a dict, and not the value part of "key: value" which is what we expect to see in metadata? | 18:59 |
| gouthamr | When you/someone specifies “user_modifiable” for a metadata item | 19:00 |
| gouthamr | This functionality wouldn’t be exposed to the metadata API | 19:00 |
| gouthamr | but, I’m asking that you make it so that it’s available for use internally - you could use it to test for example | 19:01 |
| gouthamr | and we’ll soon use it in the affinity/anti-affinity scheduler hints | 19:01 |
| ashrodri | what do you mean by make it available internally? | 19:11 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/python-manilaclient master: [OSC] Implement Share Group Type Commands https://review.opendev.org/c/openstack/python-manilaclient/+/805064 | 19:14 |
| gouthamr | ashrodri: unsure if i understand the question - a manila developer can make up service specific metadata that is not supposed to be end user modifiable | 19:23 |
| gouthamr | ashrodri: examples of there are in the metadata spec (one currently in code is: "preferred" on export_locations), and we recently discussed the possibility of storing scheduler hints as metadata | 19:25 |
| gouthamr | ashrodri: such metadata is made up by the service, not an end user - so there's no need to allow end users any ability to set the "user_modifiable" attribute on metadata | 19:25 |
| gouthamr | ashrodri: however, by rewriting the code like in https://paste.opendev.org/show/808479/, you allow for a possibility where the service can set that attribute on certain metadata items | 19:26 |
| gouthamr | ashrodri: and, right now, in your unit test, you want to be able to create "key11" as metadata that's not user modifiable - but you need a way to set the "user_modifiable" key on the database -> since unit tests can use the internal sqlalchemy/db API directly, this is easy/possible | 19:28 |
| ashrodri | in your paste, you have "user_modifiable = meta_value.pop('user_modifiable', True)" wouldnt this mean that user_modfiable is always True? Even if a service tries to set it to False by submitting a dict like {'key': {'user_modifiable': False}} as metadata? unless im misinterpreting what you wrote | 19:46 |
| gouthamr | ashrodri: try it in a python interpreter :) | 19:52 |
| opendevreview | Archana Kumari proposed openstack/python-manilaclient master: [OSC] Implement Share Group Commands https://review.opendev.org/c/openstack/python-manilaclient/+/801740 | 20:02 |
| opendevreview | Ashley Rodriguez proposed openstack/manila master: [WIP] Add user_modifiable to share metadata https://review.opendev.org/c/openstack/manila/+/806647 | 20:02 |
| opendevreview | Ashley Rodriguez proposed openstack/manila master: Replace retrying with tenacity https://review.opendev.org/c/openstack/manila/+/801911 | 20:09 |
| opendevreview | Nahim Alves de Souza proposed openstack/python-manilaclient master: Implement OSC share instance export location commands https://review.opendev.org/c/openstack/python-manilaclient/+/805307 | 20:21 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: [Optimise] Use ThredGroup to manage periodic tasks https://review.opendev.org/c/openstack/manila/+/789702 | 20:48 |
| opendevreview | Goutham Pacha Ravi proposed openstack/python-manilaclient master: Manila client suppot recycle bin https://review.opendev.org/c/openstack/python-manilaclient/+/801424 | 20:55 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-ui master: Add update share-type name description and/or public access https://review.opendev.org/c/openstack/manila-ui/+/683336 | 21:04 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Fix api-ref for access rules https://review.opendev.org/c/openstack/manila/+/783885 | 21:10 |
| gouthamr | reviewers, https://etherpad.opendev.org/p/manila-xena-review-focus is updated with all the current/active changes prioritized by the ones that affect the API/clients and requirements files | 21:22 |
| gouthamr | ^ does not mean things can't merge out of order - but having something above in the list just means we need to get stuff related to it merged, or we risk pushing it out of the release | 21:23 |
| opendevreview | Archana Kumari proposed openstack/python-manilaclient master: [WIP] [OSC] Implement Share Server commands https://review.opendev.org/c/openstack/python-manilaclient/+/805107 | 21:31 |
| carloss | ack gouthamr :) | 21:34 |
| opendevreview | Merged openstack/manila master: [NetApp] Fix list of mandatory services for CIFS share creation https://review.opendev.org/c/openstack/manila/+/806764 | 22:26 |
| opendevreview | Merged openstack/manila master: [doc] add since and before parameter to message-list cli https://review.opendev.org/c/openstack/manila/+/806548 | 22:26 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!