| opendevreview | Merged openstack/python-manilaclient master: Add share groups/share group snaps to quota class https://review.opendev.org/c/openstack/python-manilaclient/+/805067 | 03:25 |
|---|---|---|
| fzzf2 | How does manila tempest test generally configure nodepool? I install softwarefactory as CI. planing run manila tempest for test manila driver. manila need connect local device. Should I configure nodepool with static provider? | 09:13 |
| opendevreview | zhongshengping proposed openstack/puppet-manila master: Update reno to the latest version https://review.opendev.org/c/openstack/puppet-manila/+/811366 | 09:15 |
| opendevreview | Merged openstack/puppet-manila master: Update reno to the latest version https://review.opendev.org/c/openstack/puppet-manila/+/811366 | 09:34 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Allow enabling/disabling management of service user and role https://review.opendev.org/c/openstack/puppet-manila/+/811384 | 09:46 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Allow disabling management of service user and role https://review.opendev.org/c/openstack/puppet-manila/+/811384 | 09:49 |
| *** dviroel|out is now known as dviroel | 11:27 | |
| *** rishabh is now known as Guest1210 | 11:57 | |
| opendevreview | Nahim Alves de Souza proposed openstack/manila master: [NetApp] Fix default thin_provisioned volumes on AFF https://review.opendev.org/c/openstack/manila/+/811417 | 13:23 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: WIP Add FIPS testing jobs https://review.opendev.org/c/openstack/manila/+/810953 | 17:08 |
| opendevreview | Merged openstack/puppet-manila master: Do not test detail of keystone::resource::service_identity https://review.opendev.org/c/openstack/puppet-manila/+/811122 | 17:29 |
| opendevreview | Merged openstack/puppet-manila master: Allow disabling management of service user and role https://review.opendev.org/c/openstack/puppet-manila/+/811384 | 17:33 |
| opendevreview | Merged openstack/manila master: Fix api-ref for access rules https://review.opendev.org/c/openstack/manila/+/783885 | 17:46 |
| opendevreview | Merged openstack/manila master: XENA release note regarding scheduler filters https://review.opendev.org/c/openstack/manila/+/810725 | 17:59 |
| rm_work | hey, we run very close to master, and it seems like something fairly recently has caused our configured `netapp_server_port` to be ignored in favor of the default (443) | 18:08 |
| rm_work | anyone else running into this issue? | 18:08 |
| rm_work | some change in the past month or two, which I guess there actually aren't many | 18:08 |
| dviroel | carloss: ^ maybe something with the recent change in the ZAPI/REST api interface? | 18:09 |
| dviroel | rm_work: hi o/ | 18:10 |
| rm_work | looks like it would have to be something merged after Aug 30th | 18:10 |
| dviroel | rm_work: maybe something that got merged in xena | 18:10 |
| rm_work | hey 🙂 | 18:10 |
| rm_work | yes | 18:10 |
| rm_work | the tag on our release changed from 12.x to 13.x | 18:10 |
| rm_work | and that's when the problem started 😛 so seems likely | 18:10 |
| dviroel | rm_work: there was at least 3 major features merged in NetApp driver | 18:10 |
| rm_work | yeah I see a few commits touching relevant files, been trying to understand how any of them could have caused this though | 18:11 |
| dviroel | lets ping the maintainers :P felipe_rodrigues fabiooliveira nahimsouza | 18:11 |
| rm_work | let me get you a traceback too | 18:11 |
| rm_work | not sure if it'll be helpful | 18:11 |
| dviroel | carloss: https://github.com/openstack/manila/blob/7d2bbed35ee72b4e904790d9f819e86808be2a69/manila/share/drivers/netapp/dataontap/client/api.py#L267-L272 | 18:14 |
| dviroel | i think that https://github.com/openstack/manila/blob/7d2bbed35ee72b4e904790d9f819e86808be2a69/manila/share/drivers/netapp/dataontap/client/api.py#L272 should be called only if 'port is None' | 18:16 |
| rm_work | https://paste.opendev.org/show/b4u2fY1Z7ABTQ7vBXiiN/ | 18:17 |
| dviroel | rm_work: are you able o change the code and test? | 18:17 |
| rm_work | may not be useful but there you go (note it's using 443) | 18:17 |
| rm_work | yeah I think I can | 18:17 |
| rm_work | will take me a sec | 18:17 |
| dviroel | maybe at: | 18:19 |
| dviroel | https://github.com/openstack/manila/blob/7d2bbed35ee72b4e904790d9f819e86808be2a69/manila/share/drivers/netapp/dataontap/client/api.py#L272 | 18:19 |
| dviroel | https://www.irccloud.com/pastebin/cHe8nK7j/ | 18:19 |
| dviroel | rm_work: can you also report a bug for us? https://bugs.launchpad.net/manila | 18:21 |
| carloss | yep... there was a bunch of changes in those files | 18:24 |
| carloss | and significant changes to the api file, where the exception is being raised | 18:24 |
| rm_work | yeah i can file a bug | 18:25 |
| dviroel | carloss: it seems that the code will always override the port with the default values | 18:25 |
| rm_work | i was hoping I would just be able to track down the issue and make a CR but nothing really jumped out at me yet | 18:25 |
| dviroel | rm_work: thanks, the fix shuould be simple | 18:25 |
| rm_work | ah so you do see it | 18:25 |
| carloss | dviroel: yep | 18:26 |
| rm_work | set_port was running like that before though, wasn't it? hmmm | 18:26 |
| dviroel | this code was refactored in xena release, to add support for REST | 18:27 |
| rm_work | oh | 18:27 |
| dviroel | NetApp storage rest interface | 18:27 |
| rm_work | yeah i see, there's a lot of new places that call set_port without a port passedd | 18:27 |
| dviroel | rm_work: we can ask netappers to test that for us | 18:28 |
| dviroel | they are around | 18:28 |
| rm_work | yeah I bet if I update that line it will fix it | 18:30 |
| rm_work | let me see if i can test | 18:30 |
| dviroel | great | 18:30 |
| felipe_rodrigues | hi guys | 18:31 |
| felipe_rodrigues | I can have a look | 18:31 |
| dviroel | felipe_rodrigues++ | 18:33 |
| felipe_rodrigues | dviroel already found the bug. thank you :)) | 18:36 |
| felipe_rodrigues | in the speed of light | 18:36 |
| rm_work | testing with the fix now | 18:36 |
| rm_work | had to set up my env | 18:36 |
| dviroel | felipe_rodrigues: yep, shall reproduce with both ZAPI and REST | 18:36 |
| felipe_rodrigues | ack | 18:38 |
| dviroel | felipe_rodrigues: you can sync with rm_work who is going to create the LP bug | 18:38 |
| rm_work | do we need a bug filed if we can just put a CR up right away? seems like almost as much paperwork as the fix XD | 18:39 |
| rm_work | yeah verified with a fixed `_set_port()` | 18:39 |
| gouthamr | :) a bug report will help other people that hit this issue | 18:40 |
| rm_work | k | 18:41 |
| felipe_rodrigues | will you create the LP bug, rm_work ?! | 18:45 |
| rm_work | I can, suree | 18:45 |
| rm_work | working on the fix first tho so I am sure I understand everything 😀 | 18:45 |
| gouthamr | sorry for making you do the paperwork, rm_work.. not the intention - skip all that bug template stuff if you like and just capture the traceback... likely netapp folks would have to patch this, and test it as dviroel said; and we'd have to backport this fix to stable/xena | 18:46 |
| rm_work | unless one of you have it | 18:46 |
| gouthamr | ah, you were meaning to patch it too! felipe_rodrigues will thank you for it | 18:46 |
| rm_work | yeah, we will need this internally ASAP, and our process is typically to post a CR then pull it down in our builder | 18:47 |
| rm_work | it's taking me longer than the 5-second test fix because I notice this is a problem in multiple places, so trying to be complete/consistent | 18:48 |
| felipe_rodrigues | there are two place: REST and ZAPI clients. They have the same issue. You may need unit tests and so on | 18:50 |
| felipe_rodrigues | If you want, just report it in the LP. I can work on this ASAP. Up to u, rm_work | 18:51 |
| rm_work | I've got the fix the way I think it should probably be done, adding testing | 18:54 |
| rm_work | just this I think https://paste.opendev.org/show/809660/ | 18:55 |
| felipe_rodrigues | nice, it looks fine! thank you rm_work | 19:00 |
| rm_work | yeah I think the real work is in tests and bug report, as typical 😀 | 19:01 |
| opendevreview | Ghanshyam proposed openstack/devstack-plugin-ceph master: Fix job definition as devstack-plugin-ceph is branched https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811478 | 19:27 |
| opendevreview | Adam Harwell proposed openstack/manila master: NetApp: properly use netapp_server_port config https://review.opendev.org/c/openstack/manila/+/811479 | 19:27 |
| rm_work | felipe_rodrigues: ^^ | 19:28 |
| rm_work | of course, I pushed that before pep8 finished running locally, so according to the laws of the universe, it will probably have a bad newline or something 😀 | 19:29 |
| opendevreview | Ghanshyam proposed openstack/devstack-plugin-ceph master: Fix job definition as devstack-plugin-ceph is branched https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811478 | 19:29 |
| opendevreview | Ghanshyam proposed openstack/devstack-plugin-ceph master: Fix job definition as devstack-plugin-ceph is branched https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811478 | 19:31 |
| opendevreview | Ghanshyam proposed openstack/devstack-plugin-ceph stable/xena: Fix job definition as devstack-plugin-ceph is branched https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811348 | 19:33 |
| opendevreview | Adam Harwell proposed openstack/manila master: NetApp: properly use netapp_server_port config https://review.opendev.org/c/openstack/manila/+/811479 | 20:51 |
| rm_work | felipe_rodrigues: thanks, addressed comments I think -- tho not sure if that ddt is missing something, can't get it to run in PyCharm | 20:51 |
| rm_work | ah nm, i think i just needed to run the whole class at once | 20:52 |
| rm_work | and not sure why zuul failed on the tempest-aio | 20:52 |
| rm_work | or the lvm plugin | 20:52 |
| rm_work | seems to be the same error but not sure it's related | 20:53 |
| opendevreview | Adam Harwell proposed openstack/manila master: NetApp: properly use netapp_server_port config https://review.opendev.org/c/openstack/manila/+/811479 | 21:10 |
| gouthamr | don't think its related rm_work - all of our dsvm jobs are failing to setup nova | 21:10 |
| rm_work | ok, so might be a bit then 😅 | 21:19 |
| gouthamr | https://zuul.opendev.org/t/openstack/build/ab32eb8898e248cc81a0e3981d92ec34/log/controller/logs/devstacklog.txt#21776-21778 :| | 21:19 |
| gouthamr | we don't really override services iirc, /me checks | 21:19 |
| gouthamr | rm_work , others - don't "recheck" manila jobs for a bit - the placement-api failure is related to http://lists.openstack.org/pipermail/openstack-discuss/2021-September/025101.html and devstack fixes are in the gate | 21:33 |
| rm_work | o7 | 21:34 |
| gouthamr | victoria: https://review.opendev.org/c/openstack/devstack/+/811399 wallaby: https://review.opendev.org/c/openstack/devstack/+/811445 xena: https://review.opendev.org/c/openstack/devstack/+/811389 master: https://review.opendev.org/c/openstack/devstack/+/811303 | 21:34 |
| opendevreview | Ghanshyam proposed openstack/devstack-plugin-ceph master: Fix job definition as devstack-plugin-ceph is branched https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811478 | 22:47 |
| opendevreview | Ghanshyam proposed openstack/devstack-plugin-ceph master: Fix job definition as devstack-plugin-ceph is branched https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811478 | 22:48 |
| opendevreview | Ghanshyam proposed openstack/devstack-plugin-ceph master: Fix job definition as devstack-plugin-ceph is branched https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811478 | 22:51 |
| opendevreview | Ghanshyam proposed openstack/devstack-plugin-ceph stable/stein: Moving the stable/rocky and odler stable jobs to stable/stein https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811510 | 22:59 |
| opendevreview | Ghanshyam proposed openstack/devstack-plugin-ceph stable/stein: Moving the stable/rocky and odler stable jobs to stable/stein https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811510 | 23:00 |
| opendevreview | Ghanshyam proposed openstack/devstack-plugin-ceph master: Fix job definition as devstack-plugin-ceph is branched https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811478 | 23:09 |
| opendevreview | Ghanshyam proposed openstack/devstack-plugin-ceph stable/stein: Moving the stable/rocky and older stable jobs to stable/stein https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/811510 | 23:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!