| *** dviroel|rover|bbl is now known as dviroel|rover | 00:05 | |
| *** dviroel|rover is now known as dviroel|rover|out | 00:38 | |
| *** dviroel|rover|out is now known as dviroel|holiday | 00:38 | |
| opendevreview | Merged openstack/manila-tempest-plugin master: Replace period to underscore https://review.opendev.org/c/openstack/manila-tempest-plugin/+/857826 | 00:57 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila stable/xena: setuptools: Disable auto discovery https://review.opendev.org/c/openstack/puppet-manila/+/863231 | 09:11 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Add tempest tests for share snapshot metadata https://review.opendev.org/c/openstack/manila-tempest-plugin/+/827925 | 09:16 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Add tempest tests for share snapshot metadata https://review.opendev.org/c/openstack/manila-tempest-plugin/+/827925 | 09:31 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Add tempest tests for share snapshot metadata https://review.opendev.org/c/openstack/manila-tempest-plugin/+/827925 | 10:36 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: [RBAC] Add share snapshot metadata tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/863251 | 10:40 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: [RBAC] Add share snapshot metadata tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/863251 | 10:43 |
| opendevreview | Merged openstack/puppet-manila stable/xena: setuptools: Disable auto discovery https://review.opendev.org/c/openstack/puppet-manila/+/863231 | 10:51 |
| sfv880_ | Hello reviewers, I have addressed the comments on the https://review.opendev.org/c/openstack/manila/+/860788 - could you please review? Thank you very much! | 10:59 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: [RBAC] Fix test tags https://review.opendev.org/c/openstack/manila-tempest-plugin/+/863253 | 11:00 |
| opendevreview | Elena Serban proposed openstack/manila stable/yoga: Fix Create From Snapshot with Server Limits https://review.opendev.org/c/openstack/manila/+/863272 | 11:21 |
| opendevreview | Silviu Paval proposed openstack/manila stable/yoga: Fix misuse of assertTrue https://review.opendev.org/c/openstack/manila/+/863274 | 11:46 |
| opendevreview | Alexander Deiter proposed openstack/manila stable/yoga: [Infinidat] add support for TLS/SSL communication https://review.opendev.org/c/openstack/manila/+/863282 | 12:05 |
| opendevreview | Gheorghita BUTNARU proposed openstack/manila stable/zed: Raise an exc if no VIP/backend is available https://review.opendev.org/c/openstack/manila/+/863283 | 12:13 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: [RBAC] Add share snapshot metadata tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/863251 | 13:01 |
| rotensepro | gouthamr: do you advise to use --amend on last fix? >>>> https://review.opendev.org/c/openstack/manila/+/858214 | 14:09 |
| rotensepro | gouthamr: or i should push a new commit ? | 14:10 |
| gouthamr | rotensepro: hmm, i see that patch's got some unwanted dependent patches | 14:13 |
| gouthamr | rotensepro: so you'll need to do a couple of things to get rid of them | 14:14 |
| gouthamr | rotensepro: bring the code to your machine, make the necessary changes and use "git commit --amend" so that you can add to the existing commit | 14:14 |
| rotensepro | gouthamr: unwanted patches like the changing from python2 to 3 and the second one "pep8: F821 undefined name 'exe'" right? | 14:16 |
| gouthamr | rotensepro: once you're done, i would suggest you do "git rebase -i origin/master" and in the interactive rebase screen that shows up, delete lines corresponding to the unnecessary commits | 14:16 |
| rotensepro | okay...noted | 14:17 |
| gouthamr | rotensepro: no, these commits are listed under "Relation Chain" on the right side on Gerrit: https://review.opendev.org/c/openstack/manila/+/858214 | 14:17 |
| rotensepro | gouthamr: ooh...i think i've seen that, here right? >>> https://prnt.sc/kT6n05NZe-Si | 14:29 |
| gouthamr | rotensepro: yes | 14:29 |
| gouthamr | the top three commits are unnecessary | 14:29 |
| gouthamr | rotensepro: on a second thought, start with this commit here: https://review.opendev.org/c/openstack/manila/+/858228/1 | 14:30 |
| gouthamr | rotensepro: see my last review comment on the patch - this way, you don't need to worry about the unnecessary dependent patches - i can help abandon them directly on gerrit | 14:31 |
| rotensepro | gouthamr: ooh thanks alot, i just checked now and saw your last patch.....So, now i need to fix just this patchset1 here https://prnt.sc/rw3F9rXoZUNC right? | 14:40 |
| gouthamr | rotensepro: yes | 14:40 |
| gouthamr | rotensepro: use "git commit --amend" -- so you can push your changes to the same change | 14:41 |
| rotensepro | okay noted...i will work on that now | 14:41 |
| rotensepro | thank you | 14:42 |
| rotensepro | :) | 14:42 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila stable/wallaby: setuptools: Disable auto discovery https://review.opendev.org/c/openstack/puppet-manila/+/863352 | 15:15 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: [RBAC] Add share snapshot metadata tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/863251 | 16:04 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila stable/wallaby: setuptools: Disable auto discovery https://review.opendev.org/c/openstack/puppet-manila/+/863352 | 16:12 |
| opendevreview | Maurice Escher proposed openstack/manila master: NetApp: Use cluster client in non-vserver contexts https://review.opendev.org/c/openstack/manila/+/835832 | 17:01 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: [RBAC] Add share snapshot metadata tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/863251 | 17:06 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!