| tkajinam | hmm. can anyone help me understand the expected format of [DEFAULT] backup_protocol_access_mapping option value | 02:27 |
|---|---|---|
| tkajinam | it sounds like each value should be a list but I don't know how that should be defined | 02:27 |
| tkajinam | usually the dict option should be put like | 02:27 |
| tkajinam | key1:value1,key2:value2 | 02:28 |
| tkajinam | I'm unsure how value1 should look like to represent a list value | 02:28 |
| tkajinam | if I do something like | 02:31 |
| gouthamr | hey tkajinam | 02:32 |
| tkajinam | key1:value11,value12:key2,value2 then this breaks parsing in oslo.config IIUC | 02:32 |
| tkajinam | gouthamr, hey o/ | 02:32 |
| gouthamr | https://docs.openstack.org/oslo.config/latest/reference/api/oslo_config.html#oslo_config.types.Dict | 02:32 |
| gouthamr | I’ve never used a dictopt like this before | 02:32 |
| gouthamr | but could we possibly set a “value_type” and get around that? | 02:33 |
| tkajinam | hmm I don't think so | 02:33 |
| tkajinam | oh, wait | 02:34 |
| gouthamr | my phone search tells me there’s another option that this might be inspired from: “protocol_access_mapping” | 02:35 |
| gouthamr | https://opendev.org/openstack/manila/src/branch/master/manila/share/driver.py#L113 | 02:36 |
| tkajinam | let me check the actual behavior but that one might not be working as expected either. | 02:36 |
| tkajinam | https://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L649-L670 | 02:37 |
| tkajinam | I guess we have to make it look like | 02:37 |
| gouthamr | can you provide it like: key1:[‘value11’,’value12’], key2: [‘value2’] | 02:38 |
| tkajinam | yeah that's what I was thinking though we need that value_type definition to accept that format IIUC | 02:38 |
| tkajinam | which is currently missing | 02:38 |
| gouthamr | ah because without it it’s treated as a string | 02:40 |
| tkajinam | yup | 02:40 |
| gouthamr | thanks tkajinam - looks like we never tested this with multiple values - thanks for finding this | 02:41 |
| tkajinam | I guess noone has tried to customize this option | 02:42 |
| tkajinam | https://github.com/openstack/manila/blob/master/manila/share/driver.py#L659-L662 | 02:43 |
| tkajinam | I'm pretty sure the logic like this may be messed up | 02:43 |
| tkajinam | gouthamr, I'll create a bug report after testing some formats. I can probably try that in puppet ci. | 02:44 |
| gouthamr | I see what you mean; but I’m confused how the default works | 02:44 |
| tkajinam | the default works. Problem is the way how it is parsed from config files | 02:45 |
| gouthamr | you’re right, users wouldn’t have overridden this; both these options look like nerd knobs :D “YAGNI” | 02:45 |
| tkajinam | yeah | 02:45 |
| gouthamr | but since we have the options, we should fix this up; thanks 🙏 | 02:45 |
| tkajinam | yeah | 02:48 |
| tkajinam | we might need to fix oslo.config to customize that value_type. fun | 02:48 |
| tkajinam | I was writing a puppet-manila patch to support share backup/restore option. I may leave this specific option until we reach the conclusion. | 02:49 |
| gouthamr | ++ | 02:49 |
| gouthamr | that’s awesome | 02:49 |
| tkajinam | (just watched the openinfra live recording and learned the feature. that was the nice presentation. | 02:49 |
| gouthamr | yep :) | 02:50 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Add support for share backup/restore options https://review.opendev.org/c/openstack/puppet-manila/+/897510 | 03:31 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Add support for share manger options https://review.opendev.org/c/openstack/puppet-manila/+/897511 | 04:17 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Add support for share backup/restore options https://review.opendev.org/c/openstack/puppet-manila/+/897510 | 04:31 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Add support for share manger options https://review.opendev.org/c/openstack/puppet-manila/+/897511 | 05:06 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Add support for share backup/restore options https://review.opendev.org/c/openstack/puppet-manila/+/897510 | 05:06 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Remove redundant order enforcement https://review.opendev.org/c/openstack/puppet-manila/+/897514 | 05:06 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Add support for share backup/restore options https://review.opendev.org/c/openstack/puppet-manila/+/897510 | 05:20 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Add support for share backup/restore options https://review.opendev.org/c/openstack/puppet-manila/+/897510 | 05:37 |
| opendevreview | Merged openstack/manila stable/xena: NetApp ONTAP: Fix SnapMirror snapshots not being cleaned up https://review.opendev.org/c/openstack/manila/+/892036 | 06:04 |
| opendevreview | Takashi Kajinami proposed openstack/manila master: Fix missing manila-data options https://review.opendev.org/c/openstack/manila/+/897550 | 13:29 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Add support for NFS share backup driver https://review.opendev.org/c/openstack/puppet-manila/+/897558 | 13:55 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Add support for NFS share backup driver https://review.opendev.org/c/openstack/puppet-manila/+/897558 | 13:58 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: PowerMax: Fix wrong nfs client package name in Ubuntu/Debian https://review.opendev.org/c/openstack/puppet-manila/+/897560 | 14:02 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Add support for NFS share backup driver https://review.opendev.org/c/openstack/puppet-manila/+/897558 | 14:03 |
| opendevreview | Carlos Eduardo proposed openstack/manila-tempest-plugin master: Run stable jobs on 2023.2 https://review.opendev.org/c/openstack/manila-tempest-plugin/+/897574 | 16:39 |
| opendevreview | Carlos Eduardo proposed openstack/manila stable/2023.2: [DNM] testing stable jobs on 2023.2 https://review.opendev.org/c/openstack/manila/+/897575 | 16:41 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: [Doc] Annotate max api microversion in Bobcat https://review.opendev.org/c/openstack/manila/+/897609 | 19:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!