| opendevreview | Takashi Kajinami proposed openstack/manila-image-elements master: Drop unnecessary export https://review.opendev.org/c/openstack/manila-image-elements/+/907159 | 01:03 |
|---|---|---|
| opendevreview | Merged openstack/manila-image-elements master: Make tox.ini compatible with recent tox versions https://review.opendev.org/c/openstack/manila-image-elements/+/906775 | 01:08 |
| opendevreview | Merged openstack/manila-test-image master: Adapt to new versions https://review.opendev.org/c/openstack/manila-test-image/+/906812 | 01:09 |
| opendevreview | Merged openstack/manila-image-elements master: Fix installation of EPEL in recent versions https://review.opendev.org/c/openstack/manila-image-elements/+/906771 | 01:14 |
| opendevreview | Joshua Cornutt proposed openstack/manila master: Fixing CORS handling https://review.opendev.org/c/openstack/manila/+/907012 | 10:55 |
| opendevreview | Takashi Kajinami proposed openstack/manila master: Fixing skipped default override for CORS options https://review.opendev.org/c/openstack/manila/+/907012 | 13:21 |
| opendevreview | Takashi Kajinami proposed openstack/manila master: api: Dump config options when deployed as a wsgi app https://review.opendev.org/c/openstack/manila/+/891564 | 13:32 |
| opendevreview | Joshua Cornutt proposed openstack/manila master: Reverting hashbang for python3 https://review.opendev.org/c/openstack/manila/+/907219 | 15:00 |
| tkajinam | eventlet was again bumped and again breaks the doc job :-( https://zuul.opendev.org/t/openstack/build/63914f9dc9e24e1180eea22bfd92e13c | 15:03 |
| gouthamr | :( | 15:03 |
| gouthamr | tkajinam: i don't know what's unique about the point that it breaks at (autodoc: failed to import module 'tests.fake_compute' from module 'manila') | 15:06 |
| tkajinam | yeah | 15:40 |
| JayF | gouthamr: looking | 15:48 |
| JayF | gouthamr: this was broken in the ironic-inspector docs job too, but we were working | 15:48 |
| JayF | so I'm curious why yours is unhappy now | 15:48 |
| JayF | I wonder if it's python version; I might have tested with 3.11 locally | 15:49 |
| JayF | so basically, autodoc has to import our code to document it, but because we're being imported into an existing python process, the monkey_patch happens late | 15:50 |
| JayF | yeah I reproduced it locally | 15:50 |
| JayF | will try to get a fix | 15:50 |
| clarkb | is the issue python version related? | 15:52 |
| JayF | No, they are broken for me locally in python 3.11 | 15:52 |
| JayF | just must be slightly different cases for ironic-inspector and manila | 15:52 |
| JayF | I have a couple ideas on how to mitigate I'll try | 15:52 |
| tkajinam | one thing I found is that some projects use sphinxcontrib.apidoc instead of sphinx.ext.autodoc and this may be something we can try ? | 15:53 |
| tkajinam | I'm not very familiar with doc builds and may need to dig into it further. | 15:54 |
| tkajinam | reference https://review.opendev.org/c/openstack/cinder/+/559151 | 15:54 |
| tkajinam | I initially suspect monkey_patch in doc/source/conf.py is causing the problem but it does not :-( | 15:54 |
| JayF | no, basically what's happening is | 15:54 |
| JayF | autodoc itself imports the code to document it | 15:55 |
| JayF | by policy of library and openstack, monkey_patch of eventlet has to be the first thing that happens in a python process | 15:55 |
| JayF | or else you have to try and "green" existing locks and things that started before eventlet | 15:55 |
| tkajinam | ook | 15:55 |
| JayF | autodoc is importing our stuff late, so we trigger that code in eventlet | 15:55 |
| JayF | which in ironic-inspector blew up in werkzeug, and here is breaking elsewhere | 15:55 |
| tkajinam | makes clear sense. | 15:56 |
| JayF | so if we can: 1) prevent the monkey_patch in autodoc cases or 2) fix whatever code in eventlet/manila is making that angry | 15:56 |
| tkajinam | sorry you already explained it earlier. should have scrolled up the window | 15:56 |
| JayF | we are in good shape | 15:56 |
| JayF | I'm going after #1 right now | 15:56 |
| tkajinam | yeah | 15:56 |
| *** manuelosorio-581e465dd73408ce4 is now known as manuelosorioManuelOsorio[m] | 15:57 | |
| JayF | this is why I posted on the list that maybe it was too late in cycle to push this though :/ | 15:59 |
| *** manuelosorioManuelOsorio[m] is now known as theManuelOsorio[m] | 15:59 | |
| *** theManuelOsorio[m] is now known as theManuelOsorio | 16:03 | |
| JayF | I think I found a bug in eventlet related to this behavior, working a fix | 16:10 |
| opendevreview | Merged openstack/puppet-manila master: Add support for oslo.reports options https://review.opendev.org/c/openstack/puppet-manila/+/907083 | 16:33 |
| JayF | tkajinam: https://github.com/eventlet/eventlet/pull/907 I suspect this will not only fix manilla, but all broken cases | 16:36 |
| opendevreview | kiran pawar proposed openstack/python-manilaclient master: Fix share force delete case https://review.opendev.org/c/openstack/python-manilaclient/+/907242 | 17:30 |
| JayF | To update, fix is landed and included in 0.35.1 release, https://review.opendev.org/c/openstack/requirements/+/907243 is rechecking against it with a single +2 | 18:27 |
| gouthamr | JayF++ thank you very much! | 18:59 |
| JayF | Turns out my testing of ironic-inspector docs was busted, so although I did it without knowing I was helping myself at the same time | 18:59 |
| JayF | I needed that fix too :D | 19:00 |
| JayF | everyone wins! lol | 19:00 |
| gouthamr | \o/ :D | 19:00 |
| ashrodri | testing | 19:10 |
| JayF | yep | 19:10 |
| ElvisKobi_ | Yep | 19:10 |
| skylarmarkegard[m] | Ping | 19:12 |
| ashrodri | hi skylar | 19:14 |
| elviskobi[m] | Hi | 19:24 |
| skylarmarkegard[m] | Hello | 19:29 |
| elviskobi[m] | Hello | 19:30 |
| opendevreview | melaku alehegn proposed openstack/manila master: Change misleading user message when user services are down https://review.opendev.org/c/openstack/manila/+/899513 | 20:36 |
| opendevreview | melaku alehegn proposed openstack/manila master: Change misleading user message when user services are down https://review.opendev.org/c/openstack/manila/+/899513 | 20:42 |
| opendevreview | Merged openstack/manila-image-elements master: Drop unnecessary export https://review.opendev.org/c/openstack/manila-image-elements/+/907159 | 23:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!