fnn45 | Hello everyone! We're looking to start the certification process and enable our CI system to comment on and vote for updates. Who can assist with this? | 09:43 |
---|---|---|
opendevreview | kiran pawar proposed openstack/manila master: Fix leak of ports on share server deletion https://review.opendev.org/c/openstack/manila/+/920513 | 12:52 |
carloss | fnn45_: I believe there are some third party CI maintainers that could help (i.e. msaravan), and I have some knowledge on it too. What would be your question? | 14:15 |
fnn45_ | Thank you carloss. Question is the following. According to OpenDev documentation: Before posting a comment to any patch, a third party testing system must contact the project they wish to test and get approval to post comments on their patches. This can be done by attending the project’s meeting. | 14:20 |
fnn45_ | So I have ci system based on zuul that is listening to opendev/manila events. Upon git review I don't see any comment from my ci system in gerrit. Although I tested it on opendev/ci-sandbox and it worked ok | 14:22 |
fnn45_ | So more specifically I just changed in projects.yaml projects: | 14:26 |
fnn45_ | - opendev/ci-sandbox ->> projects: | 14:26 |
fnn45_ | - opendev/manila | 14:26 |
fnn45_ | Ahh. Sorry for such formatting. I hope you've got idea. Question is changing this is enough for listening manila events and voting? Or someone should give us permissions to do it? | 14:27 |
opendevreview | kiran pawar proposed openstack/manila master: Fix deferred deletion in share show https://review.opendev.org/c/openstack/manila/+/920547 | 14:53 |
opendevreview | kiran pawar proposed openstack/manila master: Fix leak of ports on share server deletion https://review.opendev.org/c/openstack/manila/+/920513 | 15:06 |
carloss | fnn45__: yes, I think I do | 16:22 |
carloss | shouldn't opendev/manila be openstack/manila? | 16:22 |
carloss | all manila repositories are under openstack/ | 16:23 |
carloss | differently from sandbox | 16:23 |
fnn45__ | carloss. Typo. It is openstack/manila according to my configuration | 17:32 |
gouthamr | fnn45__: ^ (i've been away for a few days).. one more thing besides carloss's clarification, you don't need an approval to post comments on manila patches.. our third party CI accounts are like every gerrit account; we don't provide them with permissions to add "Verified" votes.. | 17:36 |
gouthamr | fnn45__: "I don't see any comment from my ci system in gerrit" --- do you see any errors logged in the Zuul logs? | 17:37 |
gouthamr | msaravan: when you see this, could you please share the zuul config from NetApp CI as an example of what you're doing? ^ | 17:43 |
gouthamr | fnn45__: i think folks at #zuul can help with any zuul config questions.. do you have a trigger added for your CI? like: "run VAST CI" or something along those lines? | 17:44 |
carloss | gouthamr++ :) | 17:53 |
fnn45__ | gouthamr, carloss. I forgot to mention that I have ci zuul app up and running. when I do git commit --amend.... git review.... I can see that zuul pipeline is being triggered upon my my git activities. In zuul logs I can see that indeed it is my gerrit change. But when pipeline is finished I don't see smth like this in gerrit UI: Build succeeded. | 18:01 |
fnn45__ | http://vast-zuul-ci-logs.s3-website-eu-west-1.amazonaws.com/t/opendev/buildset/4af3587f44b24cda9607a33b18629592 | 18:01 |
fnn45__ | manila-ci http://vast-zuul-ci-logs.s3-website-eu-west-1.amazonaws.com/t/opendev/build/d27aca183c1e40649993d7ec4244ed50 : SUCCESS in 2h 09m 36s | 18:01 |
fnn45__ | To sum up. My app listening to events for sure and act properly. But cannot post results of its work | 18:03 |
gouthamr | ah; so the problem is just with the gerrit comment.. | 18:05 |
gouthamr | can you paste your zuul config to paste.opendev.org? | 18:06 |
gouthamr | Im wondering what you have under “success” and “failure” sections of your pipeline configuration: https://zuul-ci.org/docs/zuul/latest/config/pipeline.html | 18:06 |
fnn45__ | pipelines.yaml: https://paste.opendev.org/show/b8bKZsopXvlEW4vV5pyp/ | 18:18 |
fnn45__ | zuul config: https://paste.opendev.org/show/bkhGyT2mrnXIGSdvxkDa/ | 18:19 |
gouthamr | fnn45__: try using Verified:0 in the check pipeline config | 18:23 |
fnn45__ | gouthamr. Thanks. Will try now | 18:25 |
opendevreview | Volodymyr Boiko proposed openstack/manila master: Add share driver for VastData storage https://review.opendev.org/c/openstack/manila/+/915380 | 18:40 |
clarkb | yes by default only zuul can vote +/-2 and only CI accounts ins a special group can vote +/-1. Most projects have decided to not have third party ci vote at all but that can be accomplished by adding the account to the appropriate group. Though still only for +/-1 | 22:02 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!