| opendevreview | Merged openstack/python-manilaclient stable/2023.2: Don't set availability_zone for 2.32 version of api https://review.opendev.org/c/openstack/python-manilaclient/+/921056 | 00:39 |
|---|---|---|
| ccokeke[m] | Hey carloss Thanks for clarifying the original task I wanted to take, I have understood what needs to be done but like you said, it will take a longer time to get started. I have decided to work on https://tree.taiga.io/project/silvacarloss-openstack-manila-ui/us/42?kanban-include_attachments=1&kanban-include_tasks=1&kanban-status=2679443 | 10:40 |
| ccokeke[m] | I will come back to the first task | 10:41 |
| ccokeke[m] | carloss: please clarify further. I checked `https://opendev.org/openstack/manila-ui/src/branch/master/manila_ui/dashboards/admin/share_types/tables.py#L86` and it seems not to be doing much than assigning the `filter_choices` | 10:42 |
| ccokeke[m] | gouthamr ashrodri I have checked and realzied the `filter_choices` are specified but does the task require I check the check the `API_VERSION` in the filter class and update the `filter_choices` accordingly? | 10:55 |
| opendevreview | christian okeke proposed openstack/manila-ui master: Add Filter choices to resources https://review.opendev.org/c/openstack/manila-ui/+/921277 | 11:20 |
| carloss | ccokeke[m]: hey | 11:41 |
| carloss | this is an example change: https://review.opendev.org/c/openstack/manila-ui/+/772083 | 11:41 |
| carloss | we had someone else working on the share type filters before | 11:42 |
| carloss | and yes, I think some fields will require microversion matching | 11:42 |
| carloss | I think what I would suggest is: get a "simpler" resource to get started with | 11:42 |
| carloss | lemme take a look | 11:43 |
| carloss | I think share networks is a good example to get started with. It only has two fields: name and description | 11:44 |
| carloss | so that makes it a bit easier, and you won't need to be worried about the fields' microversion | 11:44 |
| ccokeke[m] | carloss: Thanks... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/ovFYJwxsXvjzaioSMRfeIAxM>) | 11:50 |
| carloss | ccokeke[m]: yes, that's the implementation you will need to work on | 11:56 |
| carloss | testing is an interesting topic | 11:57 |
| carloss | maybe we can use you as a guinea pig tomorrow in the weekly meeting? so we can showcase everyone how to test the changes | 11:57 |
| ccokeke[m] | Perfect carloss I will be happy | 11:58 |
| carloss | or if you finish the implementation early, please let me know and I can share some steps with you | 11:58 |
| ccokeke[m] | Alright | 11:58 |
| kpdev | @carloss: which branches this needs to be backported https://review.opendev.org/c/openstack/manila/+/920513 ? For us, master is enough | 11:59 |
| carloss | kpdev: I'd say all the maintained branches would be great | 12:00 |
| carloss | kpdev: so all the way to 2023.1 (antelope) | 12:00 |
| opendevreview | christian okeke proposed openstack/manila-ui master: Add Filter choices to resources https://review.opendev.org/c/openstack/manila-ui/+/921277 | 12:27 |
| ccokeke[m] | carloss: please take a look on the patchset above. | 12:28 |
| opendevreview | christian okeke proposed openstack/manila-ui master: Add Filter choices to resources https://review.opendev.org/c/openstack/manila-ui/+/921277 | 12:44 |
| carloss | ccokeke[m]: I will, thank you | 13:19 |
| carloss | that was quick :) | 13:19 |
| opendevreview | kiran pawar proposed openstack/manila stable/2023.2: Fix leak of ports on share server deletion https://review.opendev.org/c/openstack/manila/+/921288 | 13:56 |
| opendevreview | kiran pawar proposed openstack/manila stable/2024.1: Fix leak of ports on share server deletion https://review.opendev.org/c/openstack/manila/+/921292 | 14:33 |
| gouthamr | msaravan gireesh: thought i'd ping here regarding the pending netapp patches.. i understand there's still some issues with your CI system; most of these patches don't have an impact on anything besides the netapp driver | 15:33 |
| gouthamr | so we're okay approving these if you've tested these somewhere else; please let us know on the patch if you've done this | 15:33 |
| gouthamr | these three patches for instance: | 15:34 |
| gouthamr | https://review.opendev.org/c/openstack/manila/+/916654 | 15:34 |
| gouthamr | https://review.opendev.org/c/openstack/manila/+/914987 | 15:34 |
| gouthamr | https://review.opendev.org/c/openstack/manila/+/912059 | 15:34 |
| opendevreview | Merged openstack/manila master: Fix the backup restore issue for NetApp driver for REST client https://review.opendev.org/c/openstack/manila/+/916654 | 16:58 |
| opendevreview | kiran pawar proposed openstack/manila master: Fix share instance deferred deletion race https://review.opendev.org/c/openstack/manila/+/921313 | 17:05 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!